Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

[Tim Bell]

On 04/02/13 02:54, Alan Bateman wrote:
> On 02/04/2013 10:32, Erik Joelsson wrote:
>> On 2013-03-05 16:14, Erik Joelsson wrote:
>>>
>>> On 2013-02-20 15:20, Erik Joelsson wrote:
>>>> Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the 
>>>> target bootcycle-images. Also fixing an issue with bootcycle-images 
>>>> target that prevented them from creating images.
>>>>
>>>> http://cr.openjdk.java.net/~erikj/8006828/webrev.root.01/
>>>>
>>> http://cr.openjdk.java.net/~erikj/8006828/webrev.root.02/
>>>
>>> Discovered some more problems with the bootcycle-images target that 
>>> needed to be fixed. A full bootcycle build is still not possible due 
>>> to errors like this:
>>>
>>> /localhome/mercurial/closed-jdk8-build/jdk/make/tools/src/build/tools/javazic/GenDoc.java:123: 
>>> error: cannot f
>>> ind symbol
>>>             String zonefile = ZoneInfoFile.getFileName(zonename) + 
>>> ".html";
>>>
>>>
>> Reminder that this needs to be reviewed. The above error is now 
>> verified to be gone.
> This is useful to have and the changes look fine to me (although I 
> don't consider myself an expert on the build).
>
> A small typo in bootcycle-spec.gmk.in, " acocunt" -> "account".
>
> -Alan.

Looks good to me as well.

Tim