Please review: JDK-8011348 "use of which in common/autoconf/autogen.sh is not portable"

[Andrew Hughes]

----- Original Message -----
> All -
> 
> I regret the fact that I did not test the fix for 8009988 (see below)
> when I reviewed it.  The script as written there assumes that the
> 'which' utility will return nothing if the command is not found.  On
> some platforms (Solaris and Windows/Cygwin to name two), the return is
> more like 'no autoconf-2.67 in $PATH'
> 

Sigh.  Well you can't really expect everyone to test on every obscure platform.

> Please review the fix for 8011348, which restores autogen.sh to platform
> independence.
> 
> The bug report should be visible soon at:
>    http://bugs.sun.com/view_bug.do?bug_id=8011348
> 
> Webrev is here:
>    http://cr.openjdk.java.net/~tbell/8011348/webrev.00/
> 
> Thanks in advance for any reviews.  Feedback welcome-
> 
> Tim
> 
> 
> -------- Original Message --------
> Subject: 	hg: jdk8/build: 8009988: build-infra: Fix configure output for
> zip debuginfo check
> Date: 	Tue, 02 Apr 2013 12:59:43 +0000
> From: 	ahughes at redhat.com
> To: 	jdk8-changes at openjdk.java.net, build-dev at openjdk.java.net
> 
> 
> 
> Changeset: 15c1642967c9
> Author:    andrew
> Date:      2013-04-02 13:59 +0100
> URL:       http://hg.openjdk.java.net/jdk8/build/rev/15c1642967c9
> 
> 8009988: build-infra: Fix configure output for zip debuginfo check
> Summary: No output from zip debuginfo option when default is used.
> Reviewed-by: tbell
> 
> ! common/autoconf/autogen.sh
> ! common/autoconf/generated-configure.sh
> ! common/autoconf/jdk-options.m4
> 
> 
> 
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07