RFR (S): 7172922: export_ makefile targets do not work unless all supported variants are built

David Holmes david.holmes at oracle.com
Sat Apr 13 00:10:12 UTC 2013


Hi Chris,

On 13/04/2013 4:58 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/7172922
>
> 7172922: export_ makefile targets do not work unless all supported variants are built
> Reviewed-by:
>
> GEN_DIR can be overwritten by other configurations if multiple JVM_VARIANT_*s are defined. The fix is to use the *_BASE_DIRs directly to install the correct files.
>
> make/Makefile

This looks like a simple temporary solution - thanks.

More long term I hope we should be able to generate the set of targets 
based on the selected JVM_VARIANTS, without needing all those duplicated 
blocks.

One query with the current situation: why doesn't MISC_DIR cause us a 
problem? It would seem to have the same issue as GEN_DIR. ???

Thanks,
David




More information about the build-dev mailing list