MacOS parfait problem (old build)

[David Chase]

Related bugs:  8008451, 8005879

This may generalize to new build as well, but I have not tested that.

Apparently, when you pass " -mmacosx-version-min=..." to gcc on the Mac,
it quietly generates a definition for MAC_OS_X_VERSION_MIN_REQUIRED .

Parfait (1.1) doesn't know about this trick (why should it?) and it runs into trouble
processing the include file that checks for this:

In file included from /usr/include/dlfcn.h:41:
/usr/include/AvailabilityMacros.h:140:6: error: MAC_OS_X_VERSION_MAX_ALLOWED must be >= MAC_OS_X_VERSION_MIN_REQUIRED
    #error MAC_OS_X_VERSION_MAX_ALLOWED must be >= MAC_OS_X_VERSION_MIN_REQUIRED
     ^
1 error generated.

I added a definition for ...MIN_REQUIRED to gcc.make and it got all better:

diff --git a/make/bsd/makefiles/gcc.make b/make/bsd/makefiles/gcc.make
--- a/make/bsd/makefiles/gcc.make
+++ b/make/bsd/makefiles/gcc.make
@@ -239,6 +239,7 @@
   endif
   # The macro takes the version with no dots, ex: 1070
   CFLAGS += -DMAC_OS_X_VERSION_MAX_ALLOWED=$(subst .,,$(MACOSX_VERSION_MIN)) \
+            -DMAC_OS_X_VERSION_MIN_REQUIRED=$(subst .,,$(MACOSX_VERSION_MIN)) \
             -mmacosx-version-min=$(MACOSX_VERSION_MIN)
   LDFLAGS += -mmacosx-version-min=$(MACOSX_VERSION_MIN)
 endif

So, do we call this a bug?
And assuming we do, it needs fixing in hotspot, jdk, and root, right?

David