Fix zero build on arm

Erik Joelsson erik.joelsson at oracle.com
Mon Apr 29 09:35:19 UTC 2013


Looks good!

/Erik

On 2013-04-22 19:58, Omair Majid wrote:
> Hi Erik,
>
> On 04/17/2013 03:31 AM, Erik Joelsson wrote:
>> On 2013-04-17 04:05, Omair Majid wrote:
>>> The following webrev makes zero build succesfully on arm:
>>> http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/
>>>
>>> The only problem I ran into while trying to build zero on armv7l is that
>>> the gcc there does not like -m32. The changes make the build system
>>> check whether the compiler supports the -m32/-m64 flag before using it.
>>>
>>> Any thoughts or comments?
>>>
>> In jdk/makefiles/GensrcX11Wrappers.gmk
>> Line 91: seems to be missing a dash before the m.
>>
>> ./common/autoconf/platform.m4
>> Line 422: Misspelled comment
>> Line 437 and 440, could be simplified and moved to before the if.
>> Line 436: don't you need a "test" after the if? At least that's the form
>> we have used in the configure script.
>>
> Thanks for the comments. I have updated the webrev:
> http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/01/
>
> Thanks,
> Omair
>



More information about the build-dev mailing list