RFR: JDK-8023075: JDK-5049299 has broken old make in jdk8

Brad Wetmore bradford.wetmore at oracle.com
Thu Aug 15 02:07:39 UTC 2013


Rob, I'm not sure what happened, but I'm guessing your editor made a 
couple of glaring mistakes.

     1.  <space><tab> in the clean clobber target command section 
instead of <tab>

     2.  No newline at end of file

In:

http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4b0be7341ef

% hg diff .
diff --git a/make/java/java/Makefile b/make/java/java/Makefile
--- a/make/java/java/Makefile
+++ b/make/java/java/Makefile
@@ -499,6 +499,6 @@
  build: $(HELPER_EXE)

  clean clobber::
-       $(RM) $(HELPER_EXE_FILES_o) $(HELPER_EXE)
+       $(RM) $(HELPER_EXE_FILES_o) $(HELPER_EXE)

-endif #BUILDHELPER
\ No newline at end of file
+endif #BUILDHELPER

These changes were to the old build system, did you not do a final build 
using that system?

Anyway, here's the webrev:

     http://cr.openjdk.java.net/~wetmore/8023075/webrev.00/

David, will you please review?

Brad




More information about the build-dev mailing list