RFR(S): 8022071 Some vm/jvmti tests fail because cannot attach to the Java virtual machine

Staffan Larsen staffan.larsen at oracle.com
Tue Aug 20 06:40:19 UTC 2013


Thanks, Serguei. I'll fix the copyright.

/Staffan

On 19 aug 2013, at 20:27, serguei.spitsyn at oracle.com wrote:

> The fix looks good.
> The Copyright comment of the WindowsVirtualMachine.c can be updated with 2013.
> 
> Thanks,
> Serguei
> 
> On 8/16/13 9:51 AM, Staffan Larsen wrote:
>> This failure happens when compiling with the VS 2012 compiler. The attach code relies on the order of two methods in the compiled binary and VS 2012 changed that order. The solution used is the linker flag /ORDER [1] which allows us to specify the order in which methods are laid out in the binary image. Since the flag only operates on non-static methods, the methods have been made non-static and also changed name so that they will not clash with other methods.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8022071/webrev.01/
>> 
>> The change has been tested with both VS 2010 and VS 2012.
>> 
>> Thanks,
>> /Staffan
>> 
>> 
>> [1] http://msdn.microsoft.com/en-us/library/vstudio/00kh39zz.aspx
> 




More information about the build-dev mailing list