RFR 8022183: GCC 4.6 changes default setting for omit-frame-pointer which breaks hotspot stack walking

[harold seigel]

Thanks David.

I fixed the typo before I checked it in.

Harold

On 8/22/2013 10:17 PM, David Holmes wrote:
> On 23/08/2013 1:00 AM, harold seigel wrote:
>> Please review this updated webrev for bug 8022183:
>> http://cr.openjdk.java.net/~hseigel/bug_8022183.2/
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8022183.2/>
>>
>> This change updates the comment and moves the "-fno-omit-frame-pointer"
>> option to gcc.make.  This change was tested on both 32 and 64 bit Linux
>> builds using NMT and GCBasher. Also, the build log was inspected to make
>> sure that "-fno-omit-frame-pointer" was specified during the C++ 
>> compiles.
>>
>> I verified that Clang also accepts the "-fno-omit-frame-pointer" option.
>
> Thanks for doing all that.
>
> One minor typo in the comment: Explicity
>
> David
>
>> Thanks, Harold
>>
>>
>> On 8/22/2013 10:37 AM, harold seigel wrote:
>>> Yes, I'll update the comment.
>>>
>>> Thanks, Harold
>>>
>>> On 8/22/2013 10:08 AM, Coleen Phillimore wrote:
>>>>
>>>> Harold,
>>>>
>>>> Regarding the comment, isn't it not just the serviceability agent but
>>>> the stack trace in hs_err and the stack walking in NMT. Isn't it
>>>> generally "Stack walking in the JVM relies on frame pointer..."
>>>>
>>>> thanks,
>>>> Coleen
>>>>
>>>> On 08/21/2013 06:27 PM, Daniel D. Daugherty wrote:
>>>>> On 8/21/13 3:19 PM, harold seigel wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Please review this small fix for bug 8022183.  This fix is needed
>>>>>> in order to build hotspot on 32-bit Linux with newer versions of
>>>>>> gcc. The fix explicitly specifies "-fno-omit-frame-pointer" in the
>>>>>> makefile for 32-bit Linux.
>>>>>>
>>>>>> The fix was tested using NMT with -version and with GCBasher.
>>>>>>
>>>>>> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8022183/
>>>>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8022183/>
>>>>>
>>>>> make/linux/makefiles/i486.make
>>>>>     No comments.
>>>>>
>>>>> Thumbs up!
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>>>
>>>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8022183
>>>>>>
>>>>>> JBS bug: https://jbs.oracle.com/bugs/browse/JDK-8022183
>>>>>>
>>>>>> Thanks, Harold
>>>>>
>>>>
>>>
>>