8029805/8029806: Remove XXX addPropertyChangeListener and removePropertyChangeListener methods

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Dec 11 10:03:14 UTC 2013


On 2013-12-10 12:06, Alan Bateman wrote:
>
> (This one is for the jdk9-dev forest once it is created)
>
> The addPropertyChangeListener and removePropertyChangeListener methods 
> defined by Pack200.{Packer,Unpacker} and LogManager methods are 
> deprecated and flagged with a warning that they "will be removed in a 
> future release". This is highlighted in the EDR and Public Review of 
> JSR 337 and also flagged in JEP 162.
>
> I'd like to swing the axe early in JDK 9 so as to give every 
> opportunity for anything that might have a dependency. There are a few 
> other modularity related changes that need to go in early too but this 
> is the only one that involves the removal of methods.
>
> The webrev with the changes is here:
>
> http://cr.openjdk.java.net/~alanb/8029805%2b8029806/webrev/

I'm glad to see this hackish stuff go away!

The build changes are mostly fine, however you remove the definition of 
BEANLESS_CLASSES_TARGETS but do not remove it everywhere. While it will 
work (expands to empty), it would be better if you fixed this line as well:
$(IMAGES_OUTPUTDIR)/lib$(PROFILE)/rt.jar: 
$(IMAGES_OUTPUTDIR)/lib$(PROFILE)/_the.rt.jar.contents 
$(RT_JAR_MANIFEST_FILE) $(PROFILE_VERSION_CLASS_TARGETS) 
$(BEANLESS_CLASSES_TARGETS)


/Magnus



More information about the build-dev mailing list