Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK
Kelly O'Hair
kelly.ohair at oracle.com
Mon Feb 4 17:14:21 UTC 2013
Looks ok to me too.
-kto
On Feb 4, 2013, at 6:06 AM, Erik Joelsson wrote:
> CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris directory for linux. I changed to at least use CLOSED_SRC instead. Verified on both solaris and linux, open and closed.
>
> http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.02/
>
> /Erik
>
> On 2013-02-04 12:57, David Holmes wrote:
>> Hi Erik,
>>
>> Can you use $(CLOSED_PLATFORM_SOURCE) instead of hardwiring src/closed/<os>? In theory it should be possible to relocate the "closed" repo and still have things work (by changing one definition).
>>
>> David
>>
>> On 4/02/2013 9:42 PM, Erik Joelsson wrote:
>>> Open part of this review:
>>>
>>> The docs team will start producing separate man pages for openjdk and
>>> oraclejdk. Here are the necessary changes to the makefiles to support this.
>>>
>>> http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.01/
>>>
>>> /Erik
More information about the build-dev
mailing list