Review Request: 8008294: build-infra: Build-infra closed fails on solaris 11.1
Tim Bell
tim.bell at oracle.com
Sat Feb 16 18:36:15 UTC 2013
On 02/15/13 06:19, David Holmes wrote:
> On 16/02/2013 12:11 AM, Erik Joelsson wrote:
>> On 2013-02-15 14:32, David Holmes wrote:
>>> Erik,
>>>
>>> On 15/02/2013 11:02 PM, Erik Joelsson wrote:
>>>> Small patch to enable building with a newer compiler on Solaris when
>>>> closed is available. The open part of this was fixed previously in
>>>> 8002365. The patch adds '-lc' to the link lines for solaris.
>>>
>>> I don't understand your references to open and closed here.
>>>
>>> David
>>>
>> I guess I wrote that too fast. In the bug referenced above, similar -lc
>> parameters were added to most (if not all) library link lines that are
>> part of openjdk. This patch complements those changes by adding -lc to
>> the libraries which still have their make logic in the open but source
>> in closed.
>
> Got it - thanks. Looks okay.
>
> David
Looks good to me as well.
Tim
>
>> /Erik
>>
>>>> http://cr.openjdk.java.net/~erikj/8008294/webrev.jdk.01/
>>>>
>>>> /Erik
More information about the build-dev
mailing list