RFR: 8005545: Add System property to identify ARCH specific details such as ARM hard-float binaries

David Holmes david.holmes at oracle.com
Sun Feb 24 23:34:31 UTC 2013


Adding back build-dev

On 23/02/2013 7:33 AM, Vladimir Danushevsky wrote:
> Thanks, webrev updated
> http://cr.openjdk.java.net/~vladidan/8005545/webrev.01/
> <http://cr.openjdk.java.net/~vladidan/8005545/webrev.01/>

What is missing from this is documentation on how this new variable 
should be set in a build. The proposed changes rely on two things happening:

a) JDK_ARCH_ABI_PROP_NAME=foo is either passed as a make variable, or 
set in the environment; and

b) --with-extra-cflags is used to pass -DJDK_ARCH_ABI_PROP_NAME=foo

This would go into the top-level README-builds.html, if people think it 
needs to be documented.

David

> On Feb 22, 2013, at 5:57 AM, Alan Bateman wrote:
>
>> On 21/02/2013 22:02, Vladimir Danushevsky wrote:
>>> :
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~vladidan/8005545/webrev.00/
>>> <http://cr.openjdk.java.net/%7Evladidan/8005545/webrev.00/>
>>>
>>> Separate change to the build script (e.g. in ARM Hard-Float ABI case):
>>> setenv ARCHABIPROPNAME gnueabihf
>>> -DARCHABIPROPNAME="\"$(ARCHABIPROPNAME)\""  is passed to the CFLAGS
>>>
>> I agree with Bob on the naming, otherwise it looks okay to me.
>>
>> On the release file and Images.gmk then jdk/tl was sync'ed up
>> yesterday so you will probably need to re-base the patch.
>>
>> -Alan
>



More information about the build-dev mailing list