8008950: jdk8/tl failing with SetupJavaCompilation BUILD_NASGEN contains missing directory -c on Windows
Chris Hegarty
chris.hegarty at oracle.com
Wed Feb 27 14:00:52 UTC 2013
If I understand fixpath correctly, only needs to be run/wrap commands
(to convert path arguments), rather then on actual paths, then this
looks fine to me.
Great to see tl being buildable again.
-Chris.
On 27/02/2013 13:11, Alan Bateman wrote:
>
> This is another patch to get jdk8/tl building again after the Nashorn
> build changes.
>
> The changes for 8009021 [1] that were pushed to jdk8/tl/nashorn
> yesterday break the build on Windows. The problem is that NASGEN_SRC and
> ASM_SRC shouldn't have $(FIXPATH) in the value. Kudos to David Holmes
> for identifying the problem. I've removed the $(FIXPATH) and verified
> that jdk8/tl builds on all platforms again. I'd like to get this into
> jdk8/tl today.
>
> -Alan
>
> [1] http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a90094ae5be3
>
>
> diff --git a/makefiles/BuildNashorn.gmk b/makefiles/BuildNashorn.gmk
> --- a/makefiles/BuildNashorn.gmk
> +++ b/makefiles/BuildNashorn.gmk
> @@ -57,8 +57,8 @@
> COPY:=.properties .js,\
> BIN:=$(NASHORN_OUTPUTDIR)/nashorn_classes))
>
> -NASGEN_SRC := $(FIXPATH) $(NASHORN_TOPDIR)/buildtools/nasgen/src
> -ASM_SRC := $(FIXPATH)
> $(JDK_TOPDIR)/src/share/classes/jdk/internal/org/objectweb/asm
> +NASGEN_SRC := $(NASHORN_TOPDIR)/buildtools/nasgen/src
> +ASM_SRC := $(JDK_TOPDIR)/src/share/classes/jdk/internal/org/objectweb/asm
>
> # Build nasgen
> $(eval $(call SetupJavaCompilation,BUILD_NASGEN,\
More information about the build-dev
mailing list