From erik.joelsson at oracle.com Tue Jan 1 14:39:23 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 01 Jan 2013 15:39:23 +0100 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E16274.2040507@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> Message-ID: <50E2F51B.9000102@oracle.com> New webrev. I decided that David was right, it really should be in closed so I moved it there, along with the closed version numbers file and the reading of it. These files are also changing names slightly to avoid the .numbers extension which is just weird. http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ /Erik On 2012-12-31 11:01, Erik Joelsson wrote: > No, they are not. I hesitated as to if I should move it all to closed, > but opted not to at this point, to save time more than anything. Ok if > I open a bug on moving it to fix it later? > > /Erik > > On 2012-12-30 23:45, David Holmes wrote: >> Erik, >> >> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>> Open part of this review. Configure needs to supply a couple of more >>> utilities and version string variations. >>> >>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >> >> Those new variables do not seem relevant to openjdk builds. Is any of >> this "gnumake source" relevant to openjdk builds ?? >> >> David >> >>> /Erik From kelly.ohair at oracle.com Tue Jan 1 17:36:32 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 1 Jan 2013 09:36:32 -0800 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E2F51B.9000102@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> Message-ID: <8B30E08A-B57C-4B6B-94F7-AF01C9AC53E2@oracle.com> Looks ok. --- Is it just me, or is this m4 stuff hard to review with plain diffs. :^( One of these days someone will come up with a difference tool that takes into account the type of file it is and stop treating all files as simple text files. Has anyone ever tried http://www.guiffy.com/? -kto On Jan 1, 2013, at 6:39 AM, Erik Joelsson wrote: > New webrev. I decided that David was right, it really should be in closed so I moved it there, along with the closed version numbers file and the reading of it. These files are also changing names slightly to avoid the .numbers extension which is just weird. > > http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ > > /Erik > > On 2012-12-31 11:01, Erik Joelsson wrote: >> No, they are not. I hesitated as to if I should move it all to closed, but opted not to at this point, to save time more than anything. Ok if I open a bug on moving it to fix it later? >> >> /Erik >> >> On 2012-12-30 23:45, David Holmes wrote: >>> Erik, >>> >>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>> Open part of this review. Configure needs to supply a couple of more >>>> utilities and version string variations. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>> >>> Those new variables do not seem relevant to openjdk builds. Is any of this "gnumake source" relevant to openjdk builds ?? >>> >>> David >>> >>>> /Erik From david.holmes at oracle.com Tue Jan 1 22:58:53 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 02 Jan 2013 08:58:53 +1000 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E2F51B.9000102@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> Message-ID: <50E36A2D.4020106@oracle.com> Not sure of how all the bits click together between open and closed but on the surface this looks okay. One nit. The old version number file had a copyright Copyright (c) 2012, yet somehow the new one became Copyright (c) 2011, 2012, ?? Really I think it should now be: Copyright (c) 2012, 2013, Cheers, David ----- On 2/01/2013 12:39 AM, Erik Joelsson wrote: > New webrev. I decided that David was right, it really should be in > closed so I moved it there, along with the closed version numbers file > and the reading of it. These files are also changing names slightly to > avoid the .numbers extension which is just weird. > > http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ > > /Erik > > On 2012-12-31 11:01, Erik Joelsson wrote: >> No, they are not. I hesitated as to if I should move it all to closed, >> but opted not to at this point, to save time more than anything. Ok if >> I open a bug on moving it to fix it later? >> >> /Erik >> >> On 2012-12-30 23:45, David Holmes wrote: >>> Erik, >>> >>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>> Open part of this review. Configure needs to supply a couple of more >>>> utilities and version string variations. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>> >>> Those new variables do not seem relevant to openjdk builds. Is any of >>> this "gnumake source" relevant to openjdk builds ?? >>> >>> David >>> >>>> /Erik From erik.joelsson at oracle.com Tue Jan 1 23:47:44 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 02 Jan 2013 00:47:44 +0100 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E36A2D.4020106@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> <50E36A2D.4020106@oracle.com> Message-ID: <50E375A0.30901@oracle.com> Fixed the copyright header of that file. http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/ /Erik On 2013-01-01 23:58, David Holmes wrote: > Not sure of how all the bits click together between open and closed > but on the surface this looks okay. > > One nit. The old version number file had a copyright > > Copyright (c) 2012, > > yet somehow the new one became > > Copyright (c) 2011, 2012, > > ?? > > Really I think it should now be: > > Copyright (c) 2012, 2013, > > Cheers, > David > ----- > > On 2/01/2013 12:39 AM, Erik Joelsson wrote: >> New webrev. I decided that David was right, it really should be in >> closed so I moved it there, along with the closed version numbers file >> and the reading of it. These files are also changing names slightly to >> avoid the .numbers extension which is just weird. >> >> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ >> >> /Erik >> >> On 2012-12-31 11:01, Erik Joelsson wrote: >>> No, they are not. I hesitated as to if I should move it all to closed, >>> but opted not to at this point, to save time more than anything. Ok if >>> I open a bug on moving it to fix it later? >>> >>> /Erik >>> >>> On 2012-12-30 23:45, David Holmes wrote: >>>> Erik, >>>> >>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>>> Open part of this review. Configure needs to supply a couple of more >>>>> utilities and version string variations. >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>>> >>>> Those new variables do not seem relevant to openjdk builds. Is any of >>>> this "gnumake source" relevant to openjdk builds ?? >>>> >>>> David >>>> >>>>> /Erik From david.holmes at oracle.com Wed Jan 2 00:56:08 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 02 Jan 2013 10:56:08 +1000 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E375A0.30901@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> <50E36A2D.4020106@oracle.com> <50E375A0.30901@oracle.com> Message-ID: <50E385A8.4000002@oracle.com> Sorry Erik I misunderstood the change that had been made. I thought common/autoconf/version-numbers was replacing common/autoconf/closed.version.numbers but it wasn't - that was the original copyright I was looking at. That means the correct copyright here would now be: Copyright (c) 2011, 2013, Sorry for the confusion. David On 2/01/2013 9:47 AM, Erik Joelsson wrote: > Fixed the copyright header of that file. > > http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/ > > /Erik > > On 2013-01-01 23:58, David Holmes wrote: >> Not sure of how all the bits click together between open and closed >> but on the surface this looks okay. >> >> One nit. The old version number file had a copyright >> >> Copyright (c) 2012, >> >> yet somehow the new one became >> >> Copyright (c) 2011, 2012, >> >> ?? >> >> Really I think it should now be: >> >> Copyright (c) 2012, 2013, >> >> Cheers, >> David >> ----- >> >> On 2/01/2013 12:39 AM, Erik Joelsson wrote: >>> New webrev. I decided that David was right, it really should be in >>> closed so I moved it there, along with the closed version numbers file >>> and the reading of it. These files are also changing names slightly to >>> avoid the .numbers extension which is just weird. >>> >>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ >>> >>> /Erik >>> >>> On 2012-12-31 11:01, Erik Joelsson wrote: >>>> No, they are not. I hesitated as to if I should move it all to closed, >>>> but opted not to at this point, to save time more than anything. Ok if >>>> I open a bug on moving it to fix it later? >>>> >>>> /Erik >>>> >>>> On 2012-12-30 23:45, David Holmes wrote: >>>>> Erik, >>>>> >>>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>>>> Open part of this review. Configure needs to supply a couple of more >>>>>> utilities and version string variations. >>>>>> >>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>>>> >>>>> Those new variables do not seem relevant to openjdk builds. Is any of >>>>> this "gnumake source" relevant to openjdk builds ?? >>>>> >>>>> David >>>>> >>>>>> /Erik From erik.joelsson at oracle.com Wed Jan 2 09:50:17 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 02 Jan 2013 10:50:17 +0100 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E385A8.4000002@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> <50E36A2D.4020106@oracle.com> <50E375A0.30901@oracle.com> <50E385A8.4000002@oracle.com> Message-ID: <50E402D9.6040704@oracle.com> I should have checked myself, but it was late. Here is a new webrev with all copyright years updated. http://cr.openjdk.java.net/~erikj/8005347/webrev.root.04/ /Erik On 2013-01-02 01:56, David Holmes wrote: > Sorry Erik I misunderstood the change that had been made. I thought > common/autoconf/version-numbers was replacing > common/autoconf/closed.version.numbers but it wasn't - that was the > original copyright I was looking at. > > That means the correct copyright here would now be: > > Copyright (c) 2011, 2013, > > Sorry for the confusion. > > David > > > On 2/01/2013 9:47 AM, Erik Joelsson wrote: >> Fixed the copyright header of that file. >> >> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/ >> >> /Erik >> >> On 2013-01-01 23:58, David Holmes wrote: >>> Not sure of how all the bits click together between open and closed >>> but on the surface this looks okay. >>> >>> One nit. The old version number file had a copyright >>> >>> Copyright (c) 2012, >>> >>> yet somehow the new one became >>> >>> Copyright (c) 2011, 2012, >>> >>> ?? >>> >>> Really I think it should now be: >>> >>> Copyright (c) 2012, 2013, >>> >>> Cheers, >>> David >>> ----- >>> >>> On 2/01/2013 12:39 AM, Erik Joelsson wrote: >>>> New webrev. I decided that David was right, it really should be in >>>> closed so I moved it there, along with the closed version numbers file >>>> and the reading of it. These files are also changing names slightly to >>>> avoid the .numbers extension which is just weird. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ >>>> >>>> /Erik >>>> >>>> On 2012-12-31 11:01, Erik Joelsson wrote: >>>>> No, they are not. I hesitated as to if I should move it all to >>>>> closed, >>>>> but opted not to at this point, to save time more than anything. >>>>> Ok if >>>>> I open a bug on moving it to fix it later? >>>>> >>>>> /Erik >>>>> >>>>> On 2012-12-30 23:45, David Holmes wrote: >>>>>> Erik, >>>>>> >>>>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>>>>> Open part of this review. Configure needs to supply a couple of >>>>>>> more >>>>>>> utilities and version string variations. >>>>>>> >>>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>>>>> >>>>>> Those new variables do not seem relevant to openjdk builds. Is >>>>>> any of >>>>>> this "gnumake source" relevant to openjdk builds ?? >>>>>> >>>>>> David >>>>>> >>>>>>> /Erik From erik.joelsson at oracle.com Wed Jan 2 10:46:42 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 02 Jan 2013 11:46:42 +0100 Subject: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Message-ID: <50E41012.90604@oracle.com> In build-infra, an attempt at unifying the handling of properties files was introduced and used in jaxp jaxws. It changed how properties were cleaned quite drastically for these repos, trying to mimic what was going on with StripProperties in jdk and langtools, but using sed. This worked pretty well as long as gnu sed was used, but on solaris, that's not always the case and we saw a couple of test failures in the JCK as a result of that. While working on this, I discovered more issues related to these properties and solaris sed, and came to the conclusion that we cannot support this feature at this point, but should rather revert the property cleaning in jaxp and jaxws to something as similar as possible to the filtering done in the old build and that's what I've done in this change. Changing that can be done later. The reason for not changing the implementation in common/makefiles/JavaCompilation.gmk is that the implementation there is supposed to work the same as the new solution in sjavac. So to not break that, I opted for a local implementation in each of the repos jaxp and jaxws. Instead of using sed, which is known to cause trouble on solaris, I used nawk, which seems to behave less differently. This also enabled us to remove the complex exceptions to the compare rules in common/bin/compare.sh for resources.jar. One difference does remain however, and that's an extra newline at the end of one of the properties files. The source file is missing the newline, the ant filter in the old build does not add one, but nawk does. I've added an exception for this as I regard it as a safe diff. http://cr.openjdk.java.net/~erikj/8005575/webrev.01/ /Erik From erik.joelsson at oracle.com Wed Jan 2 10:51:54 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 02 Jan 2013 10:51:54 +0000 Subject: hg: jdk8/build: 3 new changesets Message-ID: <20130102105156.B66DD474B2@hg.openjdk.java.net> Changeset: 2d9bb72b4e34 Author: erikj Date: 2012-12-30 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/2d9bb72b4e34 8004490: build-infra: mac: hotspot is always built in product, regardless of --with-debug-level setting Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: abc8078e070b Author: erikj Date: 2013-01-01 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/abc8078e070b 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable Summary: Added configure params Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/version.numbers Changeset: 14d7ebe42c8d Author: erikj Date: 2013-01-02 11:29 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/14d7ebe42c8d 8005347: build-infra: Verify 'gnumake source' at the top level works ok Reviewed-by: tbell, ohair, dholmes ! common/autoconf/basics.m4 - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in = common/autoconf/version-numbers < common/autoconf/version.numbers From erik.joelsson at oracle.com Wed Jan 2 10:58:00 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 02 Jan 2013 11:58:00 +0100 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E402D9.6040704@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> <50E36A2D.4020106@oracle.com> <50E375A0.30901@oracle.com> <50E385A8.4000002@oracle.com> <50E402D9.6040704@oracle.com> Message-ID: <50E412B8.8010303@oracle.com> I accidentally hit hg push in the wrong shell window and pushed this prematurely. What should I do now? /Erik On 2013-01-02 10:50, Erik Joelsson wrote: > I should have checked myself, but it was late. Here is a new webrev > with all copyright years updated. > > http://cr.openjdk.java.net/~erikj/8005347/webrev.root.04/ > > /Erik > > On 2013-01-02 01:56, David Holmes wrote: >> Sorry Erik I misunderstood the change that had been made. I thought >> common/autoconf/version-numbers was replacing >> common/autoconf/closed.version.numbers but it wasn't - that was the >> original copyright I was looking at. >> >> That means the correct copyright here would now be: >> >> Copyright (c) 2011, 2013, >> >> Sorry for the confusion. >> >> David >> >> >> On 2/01/2013 9:47 AM, Erik Joelsson wrote: >>> Fixed the copyright header of that file. >>> >>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/ >>> >>> /Erik >>> >>> On 2013-01-01 23:58, David Holmes wrote: >>>> Not sure of how all the bits click together between open and closed >>>> but on the surface this looks okay. >>>> >>>> One nit. The old version number file had a copyright >>>> >>>> Copyright (c) 2012, >>>> >>>> yet somehow the new one became >>>> >>>> Copyright (c) 2011, 2012, >>>> >>>> ?? >>>> >>>> Really I think it should now be: >>>> >>>> Copyright (c) 2012, 2013, >>>> >>>> Cheers, >>>> David >>>> ----- >>>> >>>> On 2/01/2013 12:39 AM, Erik Joelsson wrote: >>>>> New webrev. I decided that David was right, it really should be in >>>>> closed so I moved it there, along with the closed version numbers >>>>> file >>>>> and the reading of it. These files are also changing names >>>>> slightly to >>>>> avoid the .numbers extension which is just weird. >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ >>>>> >>>>> /Erik >>>>> >>>>> On 2012-12-31 11:01, Erik Joelsson wrote: >>>>>> No, they are not. I hesitated as to if I should move it all to >>>>>> closed, >>>>>> but opted not to at this point, to save time more than anything. >>>>>> Ok if >>>>>> I open a bug on moving it to fix it later? >>>>>> >>>>>> /Erik >>>>>> >>>>>> On 2012-12-30 23:45, David Holmes wrote: >>>>>>> Erik, >>>>>>> >>>>>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>>>>>> Open part of this review. Configure needs to supply a couple of >>>>>>>> more >>>>>>>> utilities and version string variations. >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>>>>>> >>>>>>> Those new variables do not seem relevant to openjdk builds. Is >>>>>>> any of >>>>>>> this "gnumake source" relevant to openjdk builds ?? >>>>>>> >>>>>>> David >>>>>>> >>>>>>>> /Erik From david.holmes at oracle.com Wed Jan 2 11:03:36 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 02 Jan 2013 21:03:36 +1000 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E412B8.8010303@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> <50E36A2D.4020106@oracle.com> <50E375A0.30901@oracle.com> <50E385A8.4000002@oracle.com> <50E402D9.6040704@oracle.com> <50E412B8.8010303@oracle.com> Message-ID: <50E41408.6040904@oracle.com> As it was pushed to build-infra I don't see any major problem. If there are changes needed due to review comments then push a follow up changeset. David On 2/01/2013 8:58 PM, Erik Joelsson wrote: > I accidentally hit hg push in the wrong shell window and pushed this > prematurely. What should I do now? > > /Erik > > On 2013-01-02 10:50, Erik Joelsson wrote: >> I should have checked myself, but it was late. Here is a new webrev >> with all copyright years updated. >> >> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.04/ >> >> /Erik >> >> On 2013-01-02 01:56, David Holmes wrote: >>> Sorry Erik I misunderstood the change that had been made. I thought >>> common/autoconf/version-numbers was replacing >>> common/autoconf/closed.version.numbers but it wasn't - that was the >>> original copyright I was looking at. >>> >>> That means the correct copyright here would now be: >>> >>> Copyright (c) 2011, 2013, >>> >>> Sorry for the confusion. >>> >>> David >>> >>> >>> On 2/01/2013 9:47 AM, Erik Joelsson wrote: >>>> Fixed the copyright header of that file. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/ >>>> >>>> /Erik >>>> >>>> On 2013-01-01 23:58, David Holmes wrote: >>>>> Not sure of how all the bits click together between open and closed >>>>> but on the surface this looks okay. >>>>> >>>>> One nit. The old version number file had a copyright >>>>> >>>>> Copyright (c) 2012, >>>>> >>>>> yet somehow the new one became >>>>> >>>>> Copyright (c) 2011, 2012, >>>>> >>>>> ?? >>>>> >>>>> Really I think it should now be: >>>>> >>>>> Copyright (c) 2012, 2013, >>>>> >>>>> Cheers, >>>>> David >>>>> ----- >>>>> >>>>> On 2/01/2013 12:39 AM, Erik Joelsson wrote: >>>>>> New webrev. I decided that David was right, it really should be in >>>>>> closed so I moved it there, along with the closed version numbers >>>>>> file >>>>>> and the reading of it. These files are also changing names >>>>>> slightly to >>>>>> avoid the .numbers extension which is just weird. >>>>>> >>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ >>>>>> >>>>>> /Erik >>>>>> >>>>>> On 2012-12-31 11:01, Erik Joelsson wrote: >>>>>>> No, they are not. I hesitated as to if I should move it all to >>>>>>> closed, >>>>>>> but opted not to at this point, to save time more than anything. >>>>>>> Ok if >>>>>>> I open a bug on moving it to fix it later? >>>>>>> >>>>>>> /Erik >>>>>>> >>>>>>> On 2012-12-30 23:45, David Holmes wrote: >>>>>>>> Erik, >>>>>>>> >>>>>>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>>>>>>> Open part of this review. Configure needs to supply a couple of >>>>>>>>> more >>>>>>>>> utilities and version string variations. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>>>>>>> >>>>>>>> Those new variables do not seem relevant to openjdk builds. Is >>>>>>>> any of >>>>>>>> this "gnumake source" relevant to openjdk builds ?? >>>>>>>> >>>>>>>> David >>>>>>>> >>>>>>>>> /Erik From erik.joelsson at oracle.com Wed Jan 2 16:14:57 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 02 Jan 2013 17:14:57 +0100 Subject: Review Request: 8005635: build-infra: Support building install in jprt Message-ID: <50E45D01.1090607@oracle.com> This is the open part of this review. The changes are mostly concerning compare logic and introducing a couple of new variables in spec for images directories. Contributed by Tim Bell and myself. http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ /Erik From erik.joelsson at oracle.com Wed Jan 2 18:34:26 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 02 Jan 2013 19:34:26 +0100 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E45D01.1090607@oracle.com> References: <50E45D01.1090607@oracle.com> Message-ID: <50E47DB2.7020202@oracle.com> Missed the changes to common/makefiles/Jprt.gmk. New webrev: http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ /Erik On 2013-01-02 17:14, Erik Joelsson wrote: > This is the open part of this review. The changes are mostly > concerning compare logic and introducing a couple of new variables in > spec for images directories. > > Contributed by Tim Bell and myself. > > http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ > http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ > > /Erik From kelly.ohair at oracle.com Wed Jan 2 20:55:34 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 2 Jan 2013 12:55:34 -0800 Subject: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build In-Reply-To: <50E41012.90604@oracle.com> References: <50E41012.90604@oracle.com> Message-ID: Looks ok to me. -kto On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote: > In build-infra, an attempt at unifying the handling of properties files was introduced and used in jaxp jaxws. It changed how properties were cleaned quite drastically for these repos, trying to mimic what was going on with StripProperties in jdk and langtools, but using sed. This worked pretty well as long as gnu sed was used, but on solaris, that's not always the case and we saw a couple of test failures in the JCK as a result of that. > > While working on this, I discovered more issues related to these properties and solaris sed, and came to the conclusion that we cannot support this feature at this point, but should rather revert the property cleaning in jaxp and jaxws to something as similar as possible to the filtering done in the old build and that's what I've done in this change. Changing that can be done later. > > The reason for not changing the implementation in common/makefiles/JavaCompilation.gmk is that the implementation there is supposed to work the same as the new solution in sjavac. So to not break that, I opted for a local implementation in each of the repos jaxp and jaxws. Instead of using sed, which is known to cause trouble on solaris, I used nawk, which seems to behave less differently. This also enabled us to remove the complex exceptions to the compare rules in common/bin/compare.sh for resources.jar. One difference does remain however, and that's an extra newline at the end of one of the properties files. The source file is missing the newline, the ant filter in the old build does not add one, but nawk does. I've added an exception for this as I regard it as a safe diff. > > http://cr.openjdk.java.net/~erikj/8005575/webrev.01/ > > /Erik From kelly.ohair at oracle.com Wed Jan 2 21:50:58 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 2 Jan 2013 13:50:58 -0800 Subject: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok In-Reply-To: <50E412B8.8010303@oracle.com> References: <50E046F4.1090609@oracle.com> <50E0C41F.8070507@oracle.com> <50E16274.2040507@oracle.com> <50E2F51B.9000102@oracle.com> <50E36A2D.4020106@oracle.com> <50E375A0.30901@oracle.com> <50E385A8.4000002@oracle.com> <50E402D9.6040704@oracle.com> <50E412B8.8010303@oracle.com> Message-ID: Full steam ahead... if you ask me... -kto On Jan 2, 2013, at 2:58 AM, Erik Joelsson wrote: > I accidentally hit hg push in the wrong shell window and pushed this prematurely. What should I do now? > > /Erik > > On 2013-01-02 10:50, Erik Joelsson wrote: >> I should have checked myself, but it was late. Here is a new webrev with all copyright years updated. >> >> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.04/ >> >> /Erik >> >> On 2013-01-02 01:56, David Holmes wrote: >>> Sorry Erik I misunderstood the change that had been made. I thought common/autoconf/version-numbers was replacing common/autoconf/closed.version.numbers but it wasn't - that was the original copyright I was looking at. >>> >>> That means the correct copyright here would now be: >>> >>> Copyright (c) 2011, 2013, >>> >>> Sorry for the confusion. >>> >>> David >>> >>> >>> On 2/01/2013 9:47 AM, Erik Joelsson wrote: >>>> Fixed the copyright header of that file. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/ >>>> >>>> /Erik >>>> >>>> On 2013-01-01 23:58, David Holmes wrote: >>>>> Not sure of how all the bits click together between open and closed >>>>> but on the surface this looks okay. >>>>> >>>>> One nit. The old version number file had a copyright >>>>> >>>>> Copyright (c) 2012, >>>>> >>>>> yet somehow the new one became >>>>> >>>>> Copyright (c) 2011, 2012, >>>>> >>>>> ?? >>>>> >>>>> Really I think it should now be: >>>>> >>>>> Copyright (c) 2012, 2013, >>>>> >>>>> Cheers, >>>>> David >>>>> ----- >>>>> >>>>> On 2/01/2013 12:39 AM, Erik Joelsson wrote: >>>>>> New webrev. I decided that David was right, it really should be in >>>>>> closed so I moved it there, along with the closed version numbers file >>>>>> and the reading of it. These files are also changing names slightly to >>>>>> avoid the .numbers extension which is just weird. >>>>>> >>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/ >>>>>> >>>>>> /Erik >>>>>> >>>>>> On 2012-12-31 11:01, Erik Joelsson wrote: >>>>>>> No, they are not. I hesitated as to if I should move it all to closed, >>>>>>> but opted not to at this point, to save time more than anything. Ok if >>>>>>> I open a bug on moving it to fix it later? >>>>>>> >>>>>>> /Erik >>>>>>> >>>>>>> On 2012-12-30 23:45, David Holmes wrote: >>>>>>>> Erik, >>>>>>>> >>>>>>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote: >>>>>>>>> Open part of this review. Configure needs to supply a couple of more >>>>>>>>> utilities and version string variations. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ >>>>>>>> >>>>>>>> Those new variables do not seem relevant to openjdk builds. Is any of >>>>>>>> this "gnumake source" relevant to openjdk builds ?? >>>>>>>> >>>>>>>> David >>>>>>>> >>>>>>>>> /Erik From kelly.ohair at oracle.com Wed Jan 2 21:51:09 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 2 Jan 2013 13:51:09 -0800 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E47DB2.7020202@oracle.com> References: <50E45D01.1090607@oracle.com> <50E47DB2.7020202@oracle.com> Message-ID: Looks ok with me. -kto On Jan 2, 2013, at 10:34 AM, Erik Joelsson wrote: > Missed the changes to common/makefiles/Jprt.gmk. New webrev: > > http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ > > /Erik > > On 2013-01-02 17:14, Erik Joelsson wrote: >> This is the open part of this review. The changes are mostly concerning compare logic and introducing a couple of new variables in spec for images directories. >> >> Contributed by Tim Bell and myself. >> >> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ >> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ >> >> /Erik From erik.joelsson at oracle.com Thu Jan 3 11:36:40 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 03 Jan 2013 12:36:40 +0100 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E47DB2.7020202@oracle.com> References: <50E45D01.1090607@oracle.com> <50E47DB2.7020202@oracle.com> Message-ID: <50E56D48.8020001@oracle.com> One more variable being converted for jprt. http://cr.openjdk.java.net/~erikj/8005635/webrev.root.03/ /Erik On 2013-01-02 19:34, Erik Joelsson wrote: > Missed the changes to common/makefiles/Jprt.gmk. New webrev: > > http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ > > /Erik > > On 2013-01-02 17:14, Erik Joelsson wrote: >> This is the open part of this review. The changes are mostly >> concerning compare logic and introducing a couple of new variables in >> spec for images directories. >> >> Contributed by Tim Bell and myself. >> >> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ >> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ >> >> /Erik From david.holmes at oracle.com Thu Jan 3 11:59:57 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Jan 2013 21:59:57 +1000 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E56D48.8020001@oracle.com> References: <50E45D01.1090607@oracle.com> <50E47DB2.7020202@oracle.com> <50E56D48.8020001@oracle.com> Message-ID: <50E572BD.2050002@oracle.com> spec.gmk.in: Not sure about this one. Why do the image directories need to be configure time variables placed in spec.gmk? For profiles I dynamically change JRE_IMAGE_DIR based on the profile being built. I don't think this change breaks that because I set it as a make variable on the submake invocation. But the fact that you need to do this indicates there is something that may conflict with what I am doing. David ----- On 3/01/2013 9:36 PM, Erik Joelsson wrote: > One more variable being converted for jprt. > > http://cr.openjdk.java.net/~erikj/8005635/webrev.root.03/ > > /Erik > > On 2013-01-02 19:34, Erik Joelsson wrote: >> Missed the changes to common/makefiles/Jprt.gmk. New webrev: >> >> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ >> >> /Erik >> >> On 2013-01-02 17:14, Erik Joelsson wrote: >>> This is the open part of this review. The changes are mostly >>> concerning compare logic and introducing a couple of new variables in >>> spec for images directories. >>> >>> Contributed by Tim Bell and myself. >>> >>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ >>> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ >>> >>> /Erik From erik.joelsson at oracle.com Thu Jan 3 12:22:54 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 03 Jan 2013 13:22:54 +0100 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E572BD.2050002@oracle.com> References: <50E45D01.1090607@oracle.com> <50E47DB2.7020202@oracle.com> <50E56D48.8020001@oracle.com> <50E572BD.2050002@oracle.com> Message-ID: <50E5781E.7080908@oracle.com> What I tried to achieve was to define them in one place. It seemed to me that a lot of places needed to know where they were otherwise. /Erik On 2013-01-03 12:59, David Holmes wrote: > spec.gmk.in: > > Not sure about this one. Why do the image directories need to be > configure time variables placed in spec.gmk? For profiles I > dynamically change JRE_IMAGE_DIR based on the profile being built. I > don't think this change breaks that because I set it as a make > variable on the submake invocation. But the fact that you need to do > this indicates there is something that may conflict with what I am doing. > > David > ----- > > On 3/01/2013 9:36 PM, Erik Joelsson wrote: >> One more variable being converted for jprt. >> >> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.03/ >> >> /Erik >> >> On 2013-01-02 19:34, Erik Joelsson wrote: >>> Missed the changes to common/makefiles/Jprt.gmk. New webrev: >>> >>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ >>> >>> /Erik >>> >>> On 2013-01-02 17:14, Erik Joelsson wrote: >>>> This is the open part of this review. The changes are mostly >>>> concerning compare logic and introducing a couple of new variables in >>>> spec for images directories. >>>> >>>> Contributed by Tim Bell and myself. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ >>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ >>>> >>>> /Erik From erik.joelsson at oracle.com Thu Jan 3 13:37:03 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 03 Jan 2013 14:37:03 +0100 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E5781E.7080908@oracle.com> References: <50E45D01.1090607@oracle.com> <50E47DB2.7020202@oracle.com> <50E56D48.8020001@oracle.com> <50E572BD.2050002@oracle.com> <50E5781E.7080908@oracle.com> Message-ID: <50E5897F.8030204@oracle.com> I'm trying to understand if it is a dynamically defined set of images or if in practice it's really static. Will later parts of the build (install) need to enumerate over this set of image directories too? I don't really need to define the directories in spec, I just want to keep the definition to one place, reachable by all who needs it. /Erik On 2013-01-03 13:22, Erik Joelsson wrote: > What I tried to achieve was to define them in one place. It seemed to > me that a lot of places needed to know where they were otherwise. > > /Erik > > On 2013-01-03 12:59, David Holmes wrote: >> spec.gmk.in: >> >> Not sure about this one. Why do the image directories need to be >> configure time variables placed in spec.gmk? For profiles I >> dynamically change JRE_IMAGE_DIR based on the profile being built. I >> don't think this change breaks that because I set it as a make >> variable on the submake invocation. But the fact that you need to do >> this indicates there is something that may conflict with what I am >> doing. >> >> David >> ----- >> >> On 3/01/2013 9:36 PM, Erik Joelsson wrote: >>> One more variable being converted for jprt. >>> >>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.03/ >>> >>> /Erik >>> >>> On 2013-01-02 19:34, Erik Joelsson wrote: >>>> Missed the changes to common/makefiles/Jprt.gmk. New webrev: >>>> >>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ >>>> >>>> /Erik >>>> >>>> On 2013-01-02 17:14, Erik Joelsson wrote: >>>>> This is the open part of this review. The changes are mostly >>>>> concerning compare logic and introducing a couple of new variables in >>>>> spec for images directories. >>>>> >>>>> Contributed by Tim Bell and myself. >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ >>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ >>>>> >>>>> /Erik From erik.joelsson at oracle.com Thu Jan 3 14:15:45 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 03 Jan 2013 15:15:45 +0100 Subject: Request for Review: Java SE 8 Compact Profiles In-Reply-To: <50D3FF29.6010005@oracle.com> References: <50D3FF29.6010005@oracle.com> Message-ID: <50E59291.3080305@oracle.com> Hello, Sorry for taking so long responding to this. Here are my thoughts on it. I like the idea of defined sets of files for each type of image. The current Images.gmk works with excludes, because that's how it used to work, but I would be happy to change to an include based process. Then we wouldn't need to convert include lists to exclude lists. I'm not saying this must happen at this point though. I would prefer if java class generation, compilation and also class patching would not be happening inside CreateJars.gmk. Especially since they emit files into the jdk output dir. For Version.java, I would break it out of GensrcMisc.gmk to GensrcVersion.gmk and handle all the variants of Version.java there. I would do the compilation in CompileJavaClasses.gmk. For the patching, this would be a new concept and has to happen after compilation and not in the same make invocation. Leaving patching in images could be ok even if I would prefer not to. But if it stays, the output needs to be in images and not jdk. The drawback of all this is of course that these things will get built regardless of if you intend to build profiles or not, but I don't think they take long enough to matter. If you don't agree, then please at least move the output to images. For the images:: rule in common/makefiles/Main.gmk, do you actually need to add things there that don't fit better in a closed version of jdk/makefiles/BuildJdk.gmk? I can't find any use of it in the current profiles repos. /Erik On 2012-12-21 07:18, David Holmes wrote: > The Java SE 8 Compact Profiles: > > http://openjdk.java.net/jeps/161 > > provides for subsetting of the Java SE 8 platform. While the > specification covers the platform, we are only providing a reference > implementation on Linux x86 at this time. > > This work is covered by a number of CRs due to there being a need for > a number of CC requests to modifying existing specifications > > 8004265: Add build support for Compact Profiles > 8004502: Compact Profiles contents > 8003255: (profiles) Update JAR file specification to support profiles > 8003256: (profiles) Add support for profile identification > 8004931: add/removePropertyChangeListener should not exist in subset > Profiles of Java SE > > The changes primarily involve the build, as you would imagine, the > compact profiles define: > > - which files (binaries, jars, native libs) are in a JRE > (profile-includes.txt) > - which packages/classes are in rt.jar/resources.jar > (profile-rtjar-includes.txt) > > But there are additional source changes: > - to support reporting the profile name as part of version information > - to test the versioning and tool changes > > and also changes to java, javac and jar so that you can indicate which > profile you are targeting, and have javac make sure you don't use an > API that won't be present; and which profile you need to run (listed > in your executable jar) so the launcher can reject it if it isn't the > right profile. The launcher and jar changes are included in this > webrev, while the javac changes are being integrated separately (plus > some related javadoc changes). > > Only the new build system is supported for building profiles. > > webrevs: > > top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/ > > The main change is to simply add profiles and profiles-only as top > level make targets (similar to images). There is also a change to > remove the hardcoded version information (though this may be handled > by a separate CR). > > jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ > > The overall build changes expand on the pre-existing definitions > whereby a JRE is a JDK with things take out. So a compact JRE is then > a JRE with additional things taken out. There are three compact > profiles (compact1 being the smallest) and a full JRE. For internal > build purposes these are referred to as PROFILE_1 etc, with a full JRE > being represented by PROFILE_4 when needed. The specification for > profiles indicates what is included in each profile, but the build > rules then invert this to obtain a set of exclusions for each profile: > the exclusions of a given profile is the set of inclusions of all > larger profiles and the JRE (and of course the JDK). > > Please note I only expect build folks to look at build changes and > core-libs to look at src/test changes (all of which have been > developed by Alan Bateman) and there is no need to cross-post your > responses. > > Like many I am about to head for Xmas break but I will continue to > monitor email and deal with changes as needed. This is needed for M6 > and we need to be ready to push in early January. > > Thanks, > David Holmes > From erik.joelsson at oracle.com Thu Jan 3 23:43:44 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Thu, 03 Jan 2013 23:43:44 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20130103234344.9541047517@hg.openjdk.java.net> Changeset: 348a881c6da0 Author: erikj Date: 2013-01-02 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/348a881c6da0 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: befbad2e4d87 Author: erikj Date: 2013-01-03 20:54 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/befbad2e4d87 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl ! common/makefiles/Jprt.gmk ! common/src/fixpath.c From erik.joelsson at oracle.com Thu Jan 3 23:43:53 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Thu, 03 Jan 2013 23:43:53 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20130103234416.932AE47518@hg.openjdk.java.net> Changeset: 461b069100fa Author: erikj Date: 2013-01-02 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/461b069100fa 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + makefiles/SignJars.gmk Changeset: 3841da683703 Author: erikj Date: 2013-01-03 20:55 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3841da683703 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! make/common/shared/Defs-windows.gmk ! makefiles/BuildJdk.gmk ! makefiles/Bundles.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk From david.holmes at oracle.com Fri Jan 4 02:01:50 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 04 Jan 2013 12:01:50 +1000 Subject: Review Request: 8005635: build-infra: Support building install in jprt In-Reply-To: <50E5897F.8030204@oracle.com> References: <50E45D01.1090607@oracle.com> <50E47DB2.7020202@oracle.com> <50E56D48.8020001@oracle.com> <50E572BD.2050002@oracle.com> <50E5781E.7080908@oracle.com> <50E5897F.8030204@oracle.com> Message-ID: <50E6380E.4000405@oracle.com> On 3/01/2013 11:37 PM, Erik Joelsson wrote: > I'm trying to understand if it is a dynamically defined set of images or > if in practice it's really static. Will later parts of the build > (install) need to enumerate over this set of image directories too? I > don't really need to define the directories in spec, I just want to keep > the definition to one place, reachable by all who needs it. I'm not quite sure what you are asking. The profiles target in BuildJdk.gmk uses: # Create Compact Profile images $(ALL_PROFILES): +$(MAKE) PROFILE=$@ -f CreateJars.gmk +$(MAKE) PROFILE=$@ JRE_IMAGE_DIR=$(IMAGES_OUTPUTDIR)/j2re-$(word $(call profile_number,$@),$(PROFILE_NAMES))-image -f Images.gmk profile-image For the OpenJDK RI Profiles build the install repo does not enter into things. For our internal embedded builds it is still TBD what aspects of deploy/install will be used - at present it is none. This should be discussed internally. David ----- > > /Erik > > On 2013-01-03 13:22, Erik Joelsson wrote: >> What I tried to achieve was to define them in one place. It seemed to >> me that a lot of places needed to know where they were otherwise. >> >> /Erik >> >> On 2013-01-03 12:59, David Holmes wrote: >>> spec.gmk.in: >>> >>> Not sure about this one. Why do the image directories need to be >>> configure time variables placed in spec.gmk? For profiles I >>> dynamically change JRE_IMAGE_DIR based on the profile being built. I >>> don't think this change breaks that because I set it as a make >>> variable on the submake invocation. But the fact that you need to do >>> this indicates there is something that may conflict with what I am >>> doing. >>> >>> David >>> ----- >>> >>> On 3/01/2013 9:36 PM, Erik Joelsson wrote: >>>> One more variable being converted for jprt. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.03/ >>>> >>>> /Erik >>>> >>>> On 2013-01-02 19:34, Erik Joelsson wrote: >>>>> Missed the changes to common/makefiles/Jprt.gmk. New webrev: >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/ >>>>> >>>>> /Erik >>>>> >>>>> On 2013-01-02 17:14, Erik Joelsson wrote: >>>>>> This is the open part of this review. The changes are mostly >>>>>> concerning compare logic and introducing a couple of new variables in >>>>>> spec for images directories. >>>>>> >>>>>> Contributed by Tim Bell and myself. >>>>>> >>>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/ >>>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/ >>>>>> >>>>>> /Erik From david.holmes at oracle.com Fri Jan 4 03:35:13 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 04 Jan 2013 13:35:13 +1000 Subject: Request for Review: Java SE 8 Compact Profiles In-Reply-To: <50E59291.3080305@oracle.com> References: <50D3FF29.6010005@oracle.com> <50E59291.3080305@oracle.com> Message-ID: <50E64DF1.8060004@oracle.com> Hi Erik, On 4/01/2013 12:15 AM, Erik Joelsson wrote: > Hello, > > Sorry for taking so long responding to this. Here are my thoughts on it. Thanks for getting to it, I know you have a lot on your plate at the moment. > I like the idea of defined sets of files for each type of image. The > current Images.gmk works with excludes, because that's how it used to > work, but I would be happy to change to an include based process. Then > we wouldn't need to convert include lists to exclude lists. I'm not > saying this must happen at this point though. It will definitely not happen at this point. :) There is simply no time to redesign everything. I have an update in the pipeline that constrains my changes further so that they do not affect which files are included/excluded in a full JRE. This was needed because the existing lists only work for linux/solaris at this point (but unsupported on solaris) and failed to produce correct JREs on windows and OSX due to difference in the path locations. I hope to post an updated webrev later today, or else over the weekend. > I would prefer if java class generation, compilation and also class > patching would not be happening inside CreateJars.gmk. Especially since > they emit files into the jdk output dir. For Version.java, I would break > it out of GensrcMisc.gmk to GensrcVersion.gmk and handle all the > variants of Version.java there. I would do the compilation in > CompileJavaClasses.gmk. For the patching, this would be a new concept > and has to happen after compilation and not in the same make invocation. > Leaving patching in images could be ok even if I would prefer not to. > But if it stays, the output needs to be in images and not jdk. The > drawback of all this is of course that these things will get built > regardless of if you intend to build profiles or not, but I don't think > they take long enough to matter. If you don't agree, then please at > least move the output to images. I may have to limit this to the "at least move the output to images" - at least for now - though I need all .class files in one place to package them into a jar file. Given the way the build is defined to build the world then package up jars and images based on the image contents, I was constraining myself to only affecting those two aspects. As you indicated to handle this in CompileJavaClasses the whole profile notion has to propagate through the build system into areas that really don't care about profiles or images. > For the images:: rule in common/makefiles/Main.gmk, do you actually need > to add things there that don't fit better in a closed version of > jdk/makefiles/BuildJdk.gmk? I can't find any use of it in the current > profiles repos. It is used in the jdk/make/closed repo for other build targets based on Profiles (ie the SE embedded profile images). I'm not sure how I could move it though as if it were in a closed BuildJdk.gmk then it would need to augment an open BuildJdk.gmk target - and hence the :: would simply move from one place to another. If this were only for embedded it might be doable through a new target, but there are other factors at play. (And in many ways the :: is a much simpler way of augmenting pre-existing targets.) Thanks, David > > /Erik > > On 2012-12-21 07:18, David Holmes wrote: >> The Java SE 8 Compact Profiles: >> >> http://openjdk.java.net/jeps/161 >> >> provides for subsetting of the Java SE 8 platform. While the >> specification covers the platform, we are only providing a reference >> implementation on Linux x86 at this time. >> >> This work is covered by a number of CRs due to there being a need for >> a number of CC requests to modifying existing specifications >> >> 8004265: Add build support for Compact Profiles >> 8004502: Compact Profiles contents >> 8003255: (profiles) Update JAR file specification to support profiles >> 8003256: (profiles) Add support for profile identification >> 8004931: add/removePropertyChangeListener should not exist in subset >> Profiles of Java SE >> >> The changes primarily involve the build, as you would imagine, the >> compact profiles define: >> >> - which files (binaries, jars, native libs) are in a JRE >> (profile-includes.txt) >> - which packages/classes are in rt.jar/resources.jar >> (profile-rtjar-includes.txt) >> >> But there are additional source changes: >> - to support reporting the profile name as part of version information >> - to test the versioning and tool changes >> >> and also changes to java, javac and jar so that you can indicate which >> profile you are targeting, and have javac make sure you don't use an >> API that won't be present; and which profile you need to run (listed >> in your executable jar) so the launcher can reject it if it isn't the >> right profile. The launcher and jar changes are included in this >> webrev, while the javac changes are being integrated separately (plus >> some related javadoc changes). >> >> Only the new build system is supported for building profiles. >> >> webrevs: >> >> top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/ >> >> The main change is to simply add profiles and profiles-only as top >> level make targets (similar to images). There is also a change to >> remove the hardcoded version information (though this may be handled >> by a separate CR). >> >> jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ >> >> The overall build changes expand on the pre-existing definitions >> whereby a JRE is a JDK with things take out. So a compact JRE is then >> a JRE with additional things taken out. There are three compact >> profiles (compact1 being the smallest) and a full JRE. For internal >> build purposes these are referred to as PROFILE_1 etc, with a full JRE >> being represented by PROFILE_4 when needed. The specification for >> profiles indicates what is included in each profile, but the build >> rules then invert this to obtain a set of exclusions for each profile: >> the exclusions of a given profile is the set of inclusions of all >> larger profiles and the JRE (and of course the JDK). >> >> Please note I only expect build folks to look at build changes and >> core-libs to look at src/test changes (all of which have been >> developed by Alan Bateman) and there is no need to cross-post your >> responses. >> >> Like many I am about to head for Xmas break but I will continue to >> monitor email and deal with changes as needed. This is needed for M6 >> and we need to be ready to push in early January. >> >> Thanks, >> David Holmes >> From dingxmin at linux.vnet.ibm.com Fri Jan 4 05:29:32 2013 From: dingxmin at linux.vnet.ibm.com (Frank Ding) Date: Fri, 04 Jan 2013 13:29:32 +0800 Subject: Encoding problem when building In-Reply-To: References: <50E121C0.7000209@linux.vnet.ibm.com> Message-ID: <50E668BC.6060704@linux.vnet.ibm.com> Hi Kelly I investigated how local specific characters get into generated sources in corba module. Those classes are generated by following command idlj c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" -i "../../../../src/share/classes/org/omg/PortableServer" -i "../../../../src/share/classes/org/omg/PortableInterceptor" -corba 3.0 -fall -pkgPrefix PortableServer org.omg ../../../../src/share/classes/org/omg/PortableServer/poa.idl I checked idlj help but there is no encoding specific option. My locale environment vars are listed below $ locale LANG=C LC_CTYPE="C" LC_NUMERIC="C" LC_TIME="C" LC_COLLATE="C" LC_MONETARY="C" LC_MESSAGES="C" LC_ALL= Could you give me any hint about how to force idlj to generate ascii chars only? Best regards, Frank On 1/1/2013 12:47 AM, Kelly O'Hair wrote: > In the past, the "-encoding ascii" was important, all the reasons I can't completely list right now. But it is important > that regardless of the locale, the bits created during the build should be the same for everyone. > The definition of "same" might not be bit for bit, but by minimizing the potential differences we have a fighting > chance of measuring "the same". > > But my question is, how are any locale specific characters getting into generated sources? That's what we need to find out. > > Removing "-encoding ascii" is probably not the right answer, and if it is, will require some debate. > > -kto > > On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: > >> Hi >> I have an encoding problem when building openjdk 8 on my Windows 7. My windows is Chinese environment but I exported LANG=C in cygwin bash before building. The issue is that in module corba and jdk, some java classes are generated by program. They happen to contain Chinese characters in comment. However, they are compiled with explicit option "-encoding ascii" in makefile. This results in unrecognizable chars complained by javac (Error: encoding ascii unmappable chars) . I have a patch that removes all unnecessary "-encoding ascii" but I am not sure all its side effect. Shall I submit a bug? >> >> Best regards, >> Frank >> From volker.simonis at gmail.com Fri Jan 4 08:59:00 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 4 Jan 2013 09:59:00 +0100 Subject: Encoding problem when building In-Reply-To: <50E668BC.6060704@linux.vnet.ibm.com> References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> Message-ID: This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind of comment is it? How does this comment look on a "normal" system? Regards, Volker On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding wrote: > Hi Kelly > I investigated how local specific characters get into generated sources > in corba module. Those classes are generated by following command idlj > c:/openjdk/dep/jdk1.7.0_02/**bin/idlj -J-XX:-PrintVMOptions -J-XX:+**UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m -td "c:/openjdk/ojdk8_ojdk_739/../** > ojdk8_ojdk_739-debug/corba/**gensrc" -i "../../../../src/share/** > classes/org/omg/**PortableServer" -i "../../../../src/share/** > classes/org/omg/**PortableInterceptor" -corba 3.0 -fall -pkgPrefix > PortableServer org.omg ../../../../src/share/classes/** > org/omg/PortableServer/poa.idl > > I checked idlj help but there is no encoding specific option. My locale > environment vars are listed below > > $ locale > LANG=C > LC_CTYPE="C" > LC_NUMERIC="C" > LC_TIME="C" > LC_COLLATE="C" > LC_MONETARY="C" > LC_MESSAGES="C" > LC_ALL= > > Could you give me any hint about how to force idlj to generate ascii > chars only? > > Best regards, > Frank > > > On 1/1/2013 12:47 AM, Kelly O'Hair wrote: > >> In the past, the "-encoding ascii" was important, all the reasons I can't >> completely list right now. But it is important >> that regardless of the locale, the bits created during the build should >> be the same for everyone. >> The definition of "same" might not be bit for bit, but by minimizing the >> potential differences we have a fighting >> chance of measuring "the same". >> >> But my question is, how are any locale specific characters getting into >> generated sources? That's what we need to find out. >> >> Removing "-encoding ascii" is probably not the right answer, and if it >> is, will require some debate. >> >> -kto >> >> On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: >> >> Hi >>> I have an encoding problem when building openjdk 8 on my Windows 7. >>> My windows is Chinese environment but I exported LANG=C in cygwin bash >>> before building. The issue is that in module corba and jdk, some java >>> classes are generated by program. They happen to contain Chinese >>> characters in comment. However, they are compiled with explicit option >>> "-encoding ascii" in makefile. This results in unrecognizable chars >>> complained by javac (Error: encoding ascii unmappable chars) . I have a >>> patch that removes all unnecessary "-encoding ascii" but I am not sure all >>> its side effect. Shall I submit a bug? >>> >>> Best regards, >>> Frank >>> >>> > From Alan.Bateman at oracle.com Fri Jan 4 10:02:40 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 04 Jan 2013 10:02:40 +0000 Subject: Encoding problem when building In-Reply-To: <50E668BC.6060704@linux.vnet.ibm.com> References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> Message-ID: <50E6A8C0.8020704@oracle.com> On 04/01/2013 05:29, Frank Ding wrote: > Hi Kelly > I investigated how local specific characters get into generated > sources in corba module. Those classes are generated by following > command idlj > c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions > -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m > -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td > "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" -i > "../../../../src/share/classes/org/omg/PortableServer" -i > "../../../../src/share/classes/org/omg/PortableInterceptor" -corba 3.0 > -fall -pkgPrefix PortableServer org.omg > ../../../../src/share/classes/org/omg/PortableServer/poa.idl > > I checked idlj help but there is no encoding specific option. My > locale environment vars are listed below > > $ locale > LANG=C > LC_CTYPE="C" > LC_NUMERIC="C" > LC_TIME="C" > LC_COLLATE="C" > LC_MONETARY="C" > LC_MESSAGES="C" > LC_ALL= > > Could you give me any hint about how to force idlj to generate ascii > chars only? > > Best regards, > Frank I don't know idlj but it may be using a FileWriter and therefore the default encoding. As you path is "c:/openjdk" then I assume this must be Windows and cygwin, in which case you might (I'm not sure 100% sure) need to adjust it in the control panel. As a check, can you print the value of the file.encoding property in this environment. -Alan From erik.joelsson at oracle.com Fri Jan 4 10:29:38 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 11:29:38 +0100 Subject: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build In-Reply-To: References: <50E41012.90604@oracle.com> Message-ID: <50E6AF12.7010609@oracle.com> Had to add LANG=C to the nawk line to make this work on my linux workstation, otherwise one comment wouldn't get matched because it contained some weird character. http://cr.openjdk.java.net/~erikj/8005575/webrev.02/ /Erik On 2013-01-02 21:55, Kelly O'Hair wrote: > Looks ok to me. > > -kto > > On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote: > >> In build-infra, an attempt at unifying the handling of properties files was introduced and used in jaxp jaxws. It changed how properties were cleaned quite drastically for these repos, trying to mimic what was going on with StripProperties in jdk and langtools, but using sed. This worked pretty well as long as gnu sed was used, but on solaris, that's not always the case and we saw a couple of test failures in the JCK as a result of that. >> >> While working on this, I discovered more issues related to these properties and solaris sed, and came to the conclusion that we cannot support this feature at this point, but should rather revert the property cleaning in jaxp and jaxws to something as similar as possible to the filtering done in the old build and that's what I've done in this change. Changing that can be done later. >> >> The reason for not changing the implementation in common/makefiles/JavaCompilation.gmk is that the implementation there is supposed to work the same as the new solution in sjavac. So to not break that, I opted for a local implementation in each of the repos jaxp and jaxws. Instead of using sed, which is known to cause trouble on solaris, I used nawk, which seems to behave less differently. This also enabled us to remove the complex exceptions to the compare rules in common/bin/compare.sh for resources.jar. One difference does remain however, and that's an extra newline at the end of one of the properties files. The source file is missing the newline, the ant filter in the old build does not add one, but nawk does. I've added an exception for this as I regard it as a safe diff. >> >> http://cr.openjdk.java.net/~erikj/8005575/webrev.01/ >> >> /Erik From erik.joelsson at oracle.com Fri Jan 4 11:01:03 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 12:01:03 +0100 Subject: Review Request: 8005654: build-infra: Create sec-bin.zip Message-ID: <50E6B66F.5030002@oracle.com> This patch adds building of sec-bin.zip to images target. Building using this zip will be solved later in a different bug. Had to add INCLUDE_FILES option to SetupZipArchive. Also added comparison of sec-bin.zip to compare script. http://cr.openjdk.java.net/~erikj/8005654/webrev.01/ /Erik From erik.joelsson at oracle.com Fri Jan 4 11:14:11 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 12:14:11 +0100 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build Message-ID: <50E6B983.1050806@oracle.com> This makes build-infra work with pure open builds in jprt. Most of it contributed by Kelly O'hair. http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ /Erik From david.holmes at oracle.com Fri Jan 4 11:42:01 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 04 Jan 2013 21:42:01 +1000 Subject: Review Request: 8005654: build-infra: Create sec-bin.zip In-Reply-To: <50E6B66F.5030002@oracle.com> References: <50E6B66F.5030002@oracle.com> Message-ID: <50E6C009.4050507@oracle.com> Again this synthetic zip file doesn't work in with the Profile work. But I'm thinking that if I simply leave the JARS += in CreateJars.gmk then that might just work. David On 4/01/2013 9:01 PM, Erik Joelsson wrote: > This patch adds building of sec-bin.zip to images target. Building using > this zip will be solved later in a different bug. > > Had to add INCLUDE_FILES option to SetupZipArchive. Also added > comparison of sec-bin.zip to compare script. > > http://cr.openjdk.java.net/~erikj/8005654/webrev.01/ > > /Erik From david.holmes at oracle.com Fri Jan 4 11:44:09 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 04 Jan 2013 21:44:09 +1000 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build In-Reply-To: <50E6B983.1050806@oracle.com> References: <50E6B983.1050806@oracle.com> Message-ID: <50E6C089.5050900@oracle.com> On 4/01/2013 9:14 PM, Erik Joelsson wrote: > This makes build-infra work with pure open builds in jprt. Most of it > contributed by Kelly O'hair. > > http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ Did we not resolve that Kelly grudgingly would allow us to relax this rule: + # Appears to be an open build + OPEN_BUILD := \ + $(shell \ + if [ -d $(root_dir)/jdk/src/closed \ + -o -d $(root_dir)/jdk/make/closed \ + -o -d $(root_dir)/jdk/test/closed \ + -o -d $(root_dir)/hotspot/src/closed \ + -o -d $(root_dir)/hotspot/make/closed \ + -o -d $(root_dir)/hotspot/test/closed ] ; then \ + echo "false"; \ Or is there some other way to force an OPENJDK build regardless of repos present? David > /Erik From erik.joelsson at oracle.com Fri Jan 4 11:52:46 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 12:52:46 +0100 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build In-Reply-To: <50E6C089.5050900@oracle.com> References: <50E6B983.1050806@oracle.com> <50E6C089.5050900@oracle.com> Message-ID: <50E6C28E.6030805@oracle.com> Yes, just below I added an option for looking for OPENJDK being set to true, so if you have a full closed forest and want to send a job in with stree to build just open, you can do it with -buildenv OPENJDK=true /Erik On 2013-01-04 12:44, David Holmes wrote: > On 4/01/2013 9:14 PM, Erik Joelsson wrote: >> This makes build-infra work with pure open builds in jprt. Most of it >> contributed by Kelly O'hair. >> >> http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ > > Did we not resolve that Kelly grudgingly would allow us to relax this > rule: > > + # Appears to be an open build > + OPEN_BUILD := \ > + $(shell \ > + if [ -d $(root_dir)/jdk/src/closed \ > + -o -d $(root_dir)/jdk/make/closed \ > + -o -d $(root_dir)/jdk/test/closed \ > + -o -d $(root_dir)/hotspot/src/closed \ > + -o -d $(root_dir)/hotspot/make/closed \ > + -o -d $(root_dir)/hotspot/test/closed ] ; then \ > + echo "false"; \ > > Or is there some other way to force an OPENJDK build regardless of > repos present? > > David > >> /Erik From david.holmes at oracle.com Fri Jan 4 12:00:15 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 04 Jan 2013 22:00:15 +1000 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build In-Reply-To: <50E6C28E.6030805@oracle.com> References: <50E6B983.1050806@oracle.com> <50E6C089.5050900@oracle.com> <50E6C28E.6030805@oracle.com> Message-ID: <50E6C44F.6000702@oracle.com> On 4/01/2013 9:52 PM, Erik Joelsson wrote: > Yes, just below I added an option for looking for OPENJDK being set to > true, so if you have a full closed forest and want to send a job in with > stree to build just open, you can do it with -buildenv OPENJDK=true Doh! Sorry - getting late - time to stop :) Though as per other email on this, if jdk/make/closed is present you will run into problems because of the custom-hook. So that repo needs to be "hidden" when doing the JPRT submission. :( Thanks, David > /Erik > > On 2013-01-04 12:44, David Holmes wrote: >> On 4/01/2013 9:14 PM, Erik Joelsson wrote: >>> This makes build-infra work with pure open builds in jprt. Most of it >>> contributed by Kelly O'hair. >>> >>> http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ >> >> Did we not resolve that Kelly grudgingly would allow us to relax this >> rule: >> >> + # Appears to be an open build >> + OPEN_BUILD := \ >> + $(shell \ >> + if [ -d $(root_dir)/jdk/src/closed \ >> + -o -d $(root_dir)/jdk/make/closed \ >> + -o -d $(root_dir)/jdk/test/closed \ >> + -o -d $(root_dir)/hotspot/src/closed \ >> + -o -d $(root_dir)/hotspot/make/closed \ >> + -o -d $(root_dir)/hotspot/test/closed ] ; then \ >> + echo "false"; \ >> >> Or is there some other way to force an OPENJDK build regardless of >> repos present? >> >> David >> >>> /Erik From erik.joelsson at oracle.com Fri Jan 4 12:00:34 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 13:00:34 +0100 Subject: Review Request: 8005654: build-infra: Create sec-bin.zip In-Reply-To: <50E6C009.4050507@oracle.com> References: <50E6B66F.5030002@oracle.com> <50E6C009.4050507@oracle.com> Message-ID: <50E6C462.1000507@oracle.com> Splitting the JARS variable is probably cleaner. Let the jars/zips that aren't relevant to profiles build their own target variable in CreateJars.gmk. That should reduce interference. /Erik On 2013-01-04 12:42, David Holmes wrote: > Again this synthetic zip file doesn't work in with the Profile work. > > But I'm thinking that if I simply leave the > > JARS += > > in CreateJars.gmk then that might just work. > > David > > On 4/01/2013 9:01 PM, Erik Joelsson wrote: >> This patch adds building of sec-bin.zip to images target. Building using >> this zip will be solved later in a different bug. >> >> Had to add INCLUDE_FILES option to SetupZipArchive. Also added >> comparison of sec-bin.zip to compare script. >> >> http://cr.openjdk.java.net/~erikj/8005654/webrev.01/ >> >> /Erik From erik.joelsson at oracle.com Fri Jan 4 12:08:34 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 13:08:34 +0100 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build In-Reply-To: <50E6C44F.6000702@oracle.com> References: <50E6B983.1050806@oracle.com> <50E6C089.5050900@oracle.com> <50E6C28E.6030805@oracle.com> <50E6C44F.6000702@oracle.com> Message-ID: <50E6C642.20607@oracle.com> Ideally I would like the custom hooks in configure and the makefiles guarded with checks for OPENJDK (in the closed part of the hook). I have added them to some parts that I know will affect the build, but haven't done a full audit yet. /Erik On 2013-01-04 13:00, David Holmes wrote: > On 4/01/2013 9:52 PM, Erik Joelsson wrote: >> Yes, just below I added an option for looking for OPENJDK being set to >> true, so if you have a full closed forest and want to send a job in with >> stree to build just open, you can do it with -buildenv OPENJDK=true > > Doh! Sorry - getting late - time to stop :) > > Though as per other email on this, if jdk/make/closed is present you > will run into problems because of the custom-hook. So that repo needs > to be "hidden" when doing the JPRT submission. :( > > Thanks, > David > >> /Erik >> >> On 2013-01-04 12:44, David Holmes wrote: >>> On 4/01/2013 9:14 PM, Erik Joelsson wrote: >>>> This makes build-infra work with pure open builds in jprt. Most of it >>>> contributed by Kelly O'hair. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ >>> >>> Did we not resolve that Kelly grudgingly would allow us to relax this >>> rule: >>> >>> + # Appears to be an open build >>> + OPEN_BUILD := \ >>> + $(shell \ >>> + if [ -d $(root_dir)/jdk/src/closed \ >>> + -o -d $(root_dir)/jdk/make/closed \ >>> + -o -d $(root_dir)/jdk/test/closed \ >>> + -o -d $(root_dir)/hotspot/src/closed \ >>> + -o -d $(root_dir)/hotspot/make/closed \ >>> + -o -d $(root_dir)/hotspot/test/closed ] ; then \ >>> + echo "false"; \ >>> >>> Or is there some other way to force an OPENJDK build regardless of >>> repos present? >>> >>> David >>> >>>> /Erik From erik.joelsson at oracle.com Fri Jan 4 12:26:19 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 13:26:19 +0100 Subject: Review Request: 8005692: build-infra: Target "all" should do the right thing Message-ID: <50E6CA6B.5000600@oracle.com> Small patch for adding overlay-images to the all target on solaris 64-bit platforms. http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ /Erik From erik.joelsson at oracle.com Fri Jan 4 14:33:46 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 15:33:46 +0100 Subject: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra Message-ID: <50E6E84A.1050500@oracle.com> There are a couple of minor changes in build-infra that haven't been merged to jdk8/build yet. All are small and insignificant on their own. * Removal of redundant package entries in jar exclude lists. Also sorting the lists to make it easier to spot redundant packages in the future. * Removal of unnecessary source file in native compilation * Cleaned up comment about code exclusion in CompileJavaClasses.gmk Not urgent but would be convenient to get in to reduce diff between jdk8/build and build-infra/jdk8. http://cr.openjdk.java.net/~erikj/8005694/webrev.jdk.01/ /Erik From tim.bell at oracle.com Fri Jan 4 15:23:50 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 04 Jan 2013 07:23:50 -0800 Subject: Review Request: 8005692: build-infra: Target "all" should do the right thing In-Reply-To: <50E6CA6B.5000600@oracle.com> References: <50E6CA6B.5000600@oracle.com> Message-ID: <50E6F406.9040409@oracle.com> Erik: > Small patch for adding overlay-images to the all target on solaris > 64-bit platforms. > > http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ Looks good. Tim From tim.bell at oracle.com Fri Jan 4 15:28:42 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 04 Jan 2013 07:28:42 -0800 Subject: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra In-Reply-To: <50E6E84A.1050500@oracle.com> References: <50E6E84A.1050500@oracle.com> Message-ID: <50E6F52A.2070709@oracle.com> Erik: > There are a couple of minor changes in build-infra that haven't been > merged to jdk8/build yet. All are small and insignificant on their own. > > * Removal of redundant package entries in jar exclude lists. Also > sorting the lists to make it easier to spot redundant packages in the > future. > * Removal of unnecessary source file in native compilation > * Cleaned up comment about code exclusion in CompileJavaClasses.gmk > > Not urgent but would be convenient to get in to reduce diff between > jdk8/build and build-infra/jdk8. > > http://cr.openjdk.java.net/~erikj/8005694/webrev.jdk.01/ Looks good. Might as well tie up loose ends like this. Tim From tim.bell at oracle.com Fri Jan 4 15:34:13 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 04 Jan 2013 07:34:13 -0800 Subject: Review Request: 8005654: build-infra: Create sec-bin.zip In-Reply-To: <50E6B66F.5030002@oracle.com> References: <50E6B66F.5030002@oracle.com> Message-ID: <50E6F675.6000303@oracle.com> Erik: > This patch adds building of sec-bin.zip to images target. Building > using this zip will be solved later in a different bug. > > Had to add INCLUDE_FILES option to SetupZipArchive. Also added > comparison of sec-bin.zip to compare script. > > http://cr.openjdk.java.net/~erikj/8005654/webrev.01/ > > /Erik Looks good. Tim From tim.bell at oracle.com Fri Jan 4 15:52:31 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 04 Jan 2013 07:52:31 -0800 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build In-Reply-To: <50E6C642.20607@oracle.com> References: <50E6B983.1050806@oracle.com> <50E6C089.5050900@oracle.com> <50E6C28E.6030805@oracle.com> <50E6C44F.6000702@oracle.com> <50E6C642.20607@oracle.com> Message-ID: <50E6FABF.3000301@oracle.com> Erik: Looks good. > Ideally I would like the custom hooks in configure and the makefiles > guarded with checks for OPENJDK (in the closed part of the hook). I > have added them to some parts that I know will affect the build, but > haven't done a full audit yet. Feel free to file another bug report for the audit. Tim > > /Erik > > On 2013-01-04 13:00, David Holmes wrote: >> On 4/01/2013 9:52 PM, Erik Joelsson wrote: >>> Yes, just below I added an option for looking for OPENJDK being set to >>> true, so if you have a full closed forest and want to send a job in >>> with >>> stree to build just open, you can do it with -buildenv OPENJDK=true >> >> Doh! Sorry - getting late - time to stop :) >> >> Though as per other email on this, if jdk/make/closed is present you >> will run into problems because of the custom-hook. So that repo needs >> to be "hidden" when doing the JPRT submission. :( >> >> Thanks, >> David >> >>> /Erik >>> >>> On 2013-01-04 12:44, David Holmes wrote: >>>> On 4/01/2013 9:14 PM, Erik Joelsson wrote: >>>>> This makes build-infra work with pure open builds in jprt. Most of it >>>>> contributed by Kelly O'hair. >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ >>>> >>>> Did we not resolve that Kelly grudgingly would allow us to relax this >>>> rule: >>>> >>>> + # Appears to be an open build >>>> + OPEN_BUILD := \ >>>> + $(shell \ >>>> + if [ -d $(root_dir)/jdk/src/closed \ >>>> + -o -d $(root_dir)/jdk/make/closed \ >>>> + -o -d $(root_dir)/jdk/test/closed \ >>>> + -o -d $(root_dir)/hotspot/src/closed \ >>>> + -o -d $(root_dir)/hotspot/make/closed \ >>>> + -o -d $(root_dir)/hotspot/test/closed ] ; then \ >>>> + echo "false"; \ >>>> >>>> Or is there some other way to force an OPENJDK build regardless of >>>> repos present? >>>> >>>> David >>>> >>>>> /Erik From tim.bell at oracle.com Fri Jan 4 15:57:10 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 04 Jan 2013 07:57:10 -0800 Subject: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build In-Reply-To: <50E6AF12.7010609@oracle.com> References: <50E41012.90604@oracle.com> <50E6AF12.7010609@oracle.com> Message-ID: <50E6FBD6.5010207@oracle.com> Hi Erik Looks good. Is there an issue open for the future "unified functionality in JavaCompilation.gmk" Tim On 01/04/13 02:29, Erik Joelsson wrote: > Had to add LANG=C to the nawk line to make this work on my linux > workstation, otherwise one comment wouldn't get matched because it > contained some weird character. > > http://cr.openjdk.java.net/~erikj/8005575/webrev.02/ > > /Erik > > On 2013-01-02 21:55, Kelly O'Hair wrote: >> Looks ok to me. >> >> -kto >> >> On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote: >> >>> In build-infra, an attempt at unifying the handling of properties >>> files was introduced and used in jaxp jaxws. It changed how >>> properties were cleaned quite drastically for these repos, trying to >>> mimic what was going on with StripProperties in jdk and langtools, >>> but using sed. This worked pretty well as long as gnu sed was used, >>> but on solaris, that's not always the case and we saw a couple of >>> test failures in the JCK as a result of that. >>> >>> While working on this, I discovered more issues related to these >>> properties and solaris sed, and came to the conclusion that we >>> cannot support this feature at this point, but should rather revert >>> the property cleaning in jaxp and jaxws to something as similar as >>> possible to the filtering done in the old build and that's what I've >>> done in this change. Changing that can be done later. >>> >>> The reason for not changing the implementation in >>> common/makefiles/JavaCompilation.gmk is that the implementation >>> there is supposed to work the same as the new solution in sjavac. So >>> to not break that, I opted for a local implementation in each of the >>> repos jaxp and jaxws. Instead of using sed, which is known to cause >>> trouble on solaris, I used nawk, which seems to behave less >>> differently. This also enabled us to remove the complex exceptions >>> to the compare rules in common/bin/compare.sh for resources.jar. One >>> difference does remain however, and that's an extra newline at the >>> end of one of the properties files. The source file is missing the >>> newline, the ant filter in the old build does not add one, but nawk >>> does. I've added an exception for this as I regard it as a safe diff. >>> >>> http://cr.openjdk.java.net/~erikj/8005575/webrev.01/ >>> >>> /Erik From erik.joelsson at oracle.com Fri Jan 4 16:00:06 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 17:00:06 +0100 Subject: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build In-Reply-To: <50E6FBD6.5010207@oracle.com> References: <50E41012.90604@oracle.com> <50E6AF12.7010609@oracle.com> <50E6FBD6.5010207@oracle.com> Message-ID: <50E6FC86.9030204@oracle.com> Thanks! I guess there isn't. Should probably open one. /Erik On 2013-01-04 16:57, Tim Bell wrote: > Hi Erik > > Looks good. > > Is there an issue open for the future "unified functionality in > JavaCompilation.gmk" > > Tim > > > On 01/04/13 02:29, Erik Joelsson wrote: >> Had to add LANG=C to the nawk line to make this work on my linux >> workstation, otherwise one comment wouldn't get matched because it >> contained some weird character. >> >> http://cr.openjdk.java.net/~erikj/8005575/webrev.02/ >> >> /Erik >> >> On 2013-01-02 21:55, Kelly O'Hair wrote: >>> Looks ok to me. >>> >>> -kto >>> >>> On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote: >>> >>>> In build-infra, an attempt at unifying the handling of properties >>>> files was introduced and used in jaxp jaxws. It changed how >>>> properties were cleaned quite drastically for these repos, trying >>>> to mimic what was going on with StripProperties in jdk and >>>> langtools, but using sed. This worked pretty well as long as gnu >>>> sed was used, but on solaris, that's not always the case and we saw >>>> a couple of test failures in the JCK as a result of that. >>>> >>>> While working on this, I discovered more issues related to these >>>> properties and solaris sed, and came to the conclusion that we >>>> cannot support this feature at this point, but should rather revert >>>> the property cleaning in jaxp and jaxws to something as similar as >>>> possible to the filtering done in the old build and that's what >>>> I've done in this change. Changing that can be done later. >>>> >>>> The reason for not changing the implementation in >>>> common/makefiles/JavaCompilation.gmk is that the implementation >>>> there is supposed to work the same as the new solution in sjavac. >>>> So to not break that, I opted for a local implementation in each of >>>> the repos jaxp and jaxws. Instead of using sed, which is known to >>>> cause trouble on solaris, I used nawk, which seems to behave less >>>> differently. This also enabled us to remove the complex exceptions >>>> to the compare rules in common/bin/compare.sh for resources.jar. >>>> One difference does remain however, and that's an extra newline at >>>> the end of one of the properties files. The source file is missing >>>> the newline, the ant filter in the old build does not add one, but >>>> nawk does. I've added an exception for this as I regard it as a >>>> safe diff. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005575/webrev.01/ >>>> >>>> /Erik > > From kelly.ohair at oracle.com Fri Jan 4 17:24:35 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:24:35 -0800 Subject: Review Request: 8005692: build-infra: Target "all" should do the right thing In-Reply-To: <50E6CA6B.5000600@oracle.com> References: <50E6CA6B.5000600@oracle.com> Message-ID: <171CCC3F-D5C0-460F-9108-B4DE58D91D74@oracle.com> Looks good. -kto On Jan 4, 2013, at 4:26 AM, Erik Joelsson wrote: > Small patch for adding overlay-images to the all target on solaris 64-bit platforms. > > http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ > > /Erik From kelly.ohair at oracle.com Fri Jan 4 17:26:00 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:26:00 -0800 Subject: Review Request: 8005654: build-infra: Create sec-bin.zip In-Reply-To: <50E6B66F.5030002@oracle.com> References: <50E6B66F.5030002@oracle.com> Message-ID: <47B7F6DA-3ECC-48ED-93EB-6A456982F3CC@oracle.com> Looks ok. -kto On Jan 4, 2013, at 3:01 AM, Erik Joelsson wrote: > This patch adds building of sec-bin.zip to images target. Building using this zip will be solved later in a different bug. > > Had to add INCLUDE_FILES option to SetupZipArchive. Also added comparison of sec-bin.zip to compare script. > > http://cr.openjdk.java.net/~erikj/8005654/webrev.01/ > > /Erik From kelly.ohair at oracle.com Fri Jan 4 17:27:37 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:27:37 -0800 Subject: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build In-Reply-To: <50E6B983.1050806@oracle.com> References: <50E6B983.1050806@oracle.com> Message-ID: <807AC5B5-7026-4050-8855-B1C25EBC8062@oracle.com> Looks ok, and yes David, I know we need to work more on this. -kto On Jan 4, 2013, at 3:14 AM, Erik Joelsson wrote: > This makes build-infra work with pure open builds in jprt. Most of it contributed by Kelly O'hair. > > http://cr.openjdk.java.net/~erikj/8005597/webrev.root.01/ > > /Erik From kelly.ohair at oracle.com Fri Jan 4 17:28:41 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:28:41 -0800 Subject: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build In-Reply-To: <50E6AF12.7010609@oracle.com> References: <50E41012.90604@oracle.com> <50E6AF12.7010609@oracle.com> Message-ID: Looks ok. -kto On Jan 4, 2013, at 2:29 AM, Erik Joelsson wrote: > Had to add LANG=C to the nawk line to make this work on my linux workstation, otherwise one comment wouldn't get matched because it contained some weird character. > > http://cr.openjdk.java.net/~erikj/8005575/webrev.02/ > > /Erik > > On 2013-01-02 21:55, Kelly O'Hair wrote: >> Looks ok to me. >> >> -kto >> >> On Jan 2, 2013, at 2:46 AM, Erik Joelsson wrote: >> >>> In build-infra, an attempt at unifying the handling of properties files was introduced and used in jaxp jaxws. It changed how properties were cleaned quite drastically for these repos, trying to mimic what was going on with StripProperties in jdk and langtools, but using sed. This worked pretty well as long as gnu sed was used, but on solaris, that's not always the case and we saw a couple of test failures in the JCK as a result of that. >>> >>> While working on this, I discovered more issues related to these properties and solaris sed, and came to the conclusion that we cannot support this feature at this point, but should rather revert the property cleaning in jaxp and jaxws to something as similar as possible to the filtering done in the old build and that's what I've done in this change. Changing that can be done later. >>> >>> The reason for not changing the implementation in common/makefiles/JavaCompilation.gmk is that the implementation there is supposed to work the same as the new solution in sjavac. So to not break that, I opted for a local implementation in each of the repos jaxp and jaxws. Instead of using sed, which is known to cause trouble on solaris, I used nawk, which seems to behave less differently. This also enabled us to remove the complex exceptions to the compare rules in common/bin/compare.sh for resources.jar. One difference does remain however, and that's an extra newline at the end of one of the properties files. The source file is missing the newline, the ant filter in the old build does not add one, but nawk does. I've added an exception for this as I regard it as a safe diff. >>> >>> http://cr.openjdk.java.net/~erikj/8005575/webrev.01/ >>> >>> /Erik From kelly.ohair at oracle.com Fri Jan 4 17:29:55 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:29:55 -0800 Subject: Review Request: 8005692: build-infra: Target "all" should do the right thing In-Reply-To: <50E6CA6B.5000600@oracle.com> References: <50E6CA6B.5000600@oracle.com> Message-ID: <7CD8690E-D97E-4DF0-83FB-62E81E9634BF@oracle.com> Looks ok. -kto P.S. The network and email is REALLY slow today, apologies if you get dups on email, some of my emails seem to be going poof. :^( On Jan 4, 2013, at 4:26 AM, Erik Joelsson wrote: > Small patch for adding overlay-images to the all target on solaris 64-bit platforms. > > http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ > > /Erik From kelly.ohair at oracle.com Fri Jan 4 17:31:45 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:31:45 -0800 Subject: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra In-Reply-To: <50E6E84A.1050500@oracle.com> References: <50E6E84A.1050500@oracle.com> Message-ID: <5574E599-F93F-4724-AD1B-D00A82D615F7@oracle.com> Looks ok, although I did not do a complete inventory on these package names. The comparisons will have caught any issues. -kto On Jan 4, 2013, at 6:33 AM, Erik Joelsson wrote: > There are a couple of minor changes in build-infra that haven't been merged to jdk8/build yet. All are small and insignificant on their own. > > * Removal of redundant package entries in jar exclude lists. Also sorting the lists to make it easier to spot redundant packages in the future. > * Removal of unnecessary source file in native compilation > * Cleaned up comment about code exclusion in CompileJavaClasses.gmk > > Not urgent but would be convenient to get in to reduce diff between jdk8/build and build-infra/jdk8. > > http://cr.openjdk.java.net/~erikj/8005694/webrev.jdk.01/ > > /Erik From kelly.ohair at oracle.com Fri Jan 4 17:32:38 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 09:32:38 -0800 Subject: Encoding problem when building In-Reply-To: <50E6A8C0.8020704@oracle.com> References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> <50E6A8C0.8020704@oracle.com> Message-ID: I assume someone will file a bug on this? I kind of have my hands full with build-infra right now. -kto On Jan 4, 2013, at 2:02 AM, Alan Bateman wrote: > On 04/01/2013 05:29, Frank Ding wrote: >> Hi Kelly >> I investigated how local specific characters get into generated sources in corba module. Those classes are generated by following command idlj >> c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" -i "../../../../src/share/classes/org/omg/PortableServer" -i "../../../../src/share/classes/org/omg/PortableInterceptor" -corba 3.0 -fall -pkgPrefix PortableServer org.omg ../../../../src/share/classes/org/omg/PortableServer/poa.idl >> >> I checked idlj help but there is no encoding specific option. My locale environment vars are listed below >> >> $ locale >> LANG=C >> LC_CTYPE="C" >> LC_NUMERIC="C" >> LC_TIME="C" >> LC_COLLATE="C" >> LC_MONETARY="C" >> LC_MESSAGES="C" >> LC_ALL= >> >> Could you give me any hint about how to force idlj to generate ascii chars only? >> >> Best regards, >> Frank > I don't know idlj but it may be using a FileWriter and therefore the default encoding. As you path is "c:/openjdk" then I assume this must be Windows and cygwin, in which case you might (I'm not sure 100% sure) need to adjust it in the control panel. As a check, can you print the value of the file.encoding property in this environment. > > -Alan From erik.joelsson at oracle.com Fri Jan 4 21:13:04 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 04 Jan 2013 21:13:04 +0000 Subject: hg: jdk8/build: 4 new changesets Message-ID: <20130104211304.BF76047565@hg.openjdk.java.net> Changeset: 39194e004ade Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/39194e004ade 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! common/autoconf/compare.sh.in ! common/bin/compare.sh Changeset: 9263657c2756 Author: erikj Date: 2013-01-04 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/9263657c2756 8005692: build-infra: Target "all" should do the right thing Reviewed-by: tbell ! common/makefiles/Main.gmk Changeset: c874a8a27933 Author: erikj Date: 2013-01-04 17:05 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/c874a8a27933 8005597: build-infra: bridgeBuild broken for pure openjdk build Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: 7b9c42f14281 Author: erikj Date: 2013-01-04 17:08 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/7b9c42f14281 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! common/bin/compare.sh ! common/makefiles/JavaCompilation.gmk From erik.joelsson at oracle.com Fri Jan 4 21:13:09 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 04 Jan 2013 21:13:09 +0000 Subject: hg: jdk8/build/jaxp: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Message-ID: <20130104211314.A026047566@hg.openjdk.java.net> Changeset: 278a2f60c55b Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/278a2f60c55b 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxp.gmk From erik.joelsson at oracle.com Fri Jan 4 21:13:12 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 04 Jan 2013 21:13:12 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20130104211350.4E87747568@hg.openjdk.java.net> Changeset: a8d25b689563 Author: erikj Date: 2013-01-04 16:54 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a8d25b689563 8005694: build-infra: Cleanup of misc changes in build-infra Reviewed-by: tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: 3824d8469dcf Author: erikj Date: 2013-01-04 17:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3824d8469dcf 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! makefiles/CreateJars.gmk From erik.joelsson at oracle.com Fri Jan 4 21:13:11 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 04 Jan 2013 21:13:11 +0000 Subject: hg: jdk8/build/jaxws: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Message-ID: <20130104211315.CBB7747567@hg.openjdk.java.net> Changeset: 51f3117e2b75 Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/51f3117e2b75 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxws.gmk From erik.joelsson at oracle.com Fri Jan 4 21:21:55 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 04 Jan 2013 22:21:55 +0100 Subject: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Message-ID: <50E747F3.10904@oracle.com> Adding support for two more zip files that weren't created in build-infra. Also adding compare support. http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ /Erik From tim.bell at oracle.com Fri Jan 4 21:45:54 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 04 Jan 2013 13:45:54 -0800 Subject: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing In-Reply-To: <50E747F3.10904@oracle.com> References: <50E747F3.10904@oracle.com> Message-ID: <50E74D92.4030700@oracle.com> Erik: > Adding support for two more zip files that weren't created in > build-infra. Also adding compare support. > > http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ Looks good. Thanks. Tim From kelly.ohair at oracle.com Fri Jan 4 22:47:11 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 14:47:11 -0800 Subject: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing In-Reply-To: <50E747F3.10904@oracle.com> References: <50E747F3.10904@oracle.com> Message-ID: <1A681061-00E2-4B13-8A3A-54838663A08F@oracle.com> Looks ok. -kto On Jan 4, 2013, at 1:21 PM, Erik Joelsson wrote: > Adding support for two more zip files that weren't created in build-infra. Also adding compare support. > > http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ > > /Erik From sadhak001 at gmail.com Sat Jan 5 00:39:39 2013 From: sadhak001 at gmail.com (Mani Sarkar) Date: Sat, 5 Jan 2013 00:39:39 +0000 Subject: OpenJDK builds: Ant build issues with jdk (netbeans) sub-projects - awt2d, j2se and jarzip Message-ID: Hi All, I have furthered my pursuits with building *OpenJDK projects *by building the JDK sub-projects like swing, etc... but came across issues with building 3 different projects which I wasn't able to build due configuration issues. These sub-projects are located under the netbeans subfolder under the .../jdk/make/ folder. They all are getting compiled for version 8 with the below args (which is leading to a build failure): -source 8 -target 8 *jdk/awt2d* https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/awt2d/awt2dAntBuild.log *jdk/j2se* https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/j2se/j2seAntBuild.log *jdk/jarzip* https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/jarzip/jarzipAntBuild.log Where is this version configuration set for these projects, that I can change either through file changes or alternative build.properties setting changes? My other question is why are there no make files available for the jdk sub-projects (i.e. *awt2d, j2se,* etc...) except for under *javax/swing*has make files to build this project instead Ant build.xml files are available. Is it possible to hook these ant files with the new build system, instead of only being able to build the sub-projects via the old build system (using the ALT_... variables via make.options). Thanks. Regards, mani -- Twitter: @theNeomatrix369 Blog: http://neomatrix369.wordpress.com *Don't chase success, rather aim for "Excellence", and success will come chasing after you!* From erik.joelsson at oracle.com Sat Jan 5 03:25:06 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Sat, 05 Jan 2013 03:25:06 +0000 Subject: hg: jdk8/build: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Message-ID: <20130105032506.DBACD4756E@hg.openjdk.java.net> Changeset: 2597feac57c0 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/2597feac57c0 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl From erik.joelsson at oracle.com Sat Jan 5 03:25:16 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Sat, 05 Jan 2013 03:25:16 +0000 Subject: hg: jdk8/build/jdk: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Message-ID: <20130105032538.921E74756F@hg.openjdk.java.net> Changeset: d98e73b7bc78 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d98e73b7bc78 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! makefiles/CreateJars.gmk From kelly.ohair at oracle.com Sat Jan 5 05:04:18 2013 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Sat, 05 Jan 2013 05:04:18 +0000 Subject: hg: jdk8/build: 8004229: build-infra: Umbrella for switch of default "make" to new makefiles Message-ID: <20130105050418.48F1F47570@hg.openjdk.java.net> Changeset: 5cf7750c8c43 Author: ohair Date: 2013-01-04 21:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/5cf7750c8c43 8004229: build-infra: Umbrella for switch of default "make" to new makefiles Reviewed-by: erikj, tbell ! Makefile ! make/jprt.properties From kelly.ohair at oracle.com Sat Jan 5 05:07:47 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Jan 2013 21:07:47 -0800 Subject: jdk8 Build changes References: Message-ID: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> Excuse the wide mailing, but it was important to try and reach anyone building jdk8. The jdk8/build repositories at http://hg.openjdk.java.net/jdk8/build have been changed to use the new build-infra "configure&make" build setup, so it is official, but it still needs to be integrated into the main jdk8/jdk8 repositories at http://hg.openjdk.java.net/jdk8/jdk8. This is expected to happen in 2 weeks. A few bullet points: * ANY changes to ANY make/ files from now until we integrate into jdk8/jdk8 represents a risk, please talk to us first. * Windows CYGWIN 1.7.16+ will be required, MKS will no longer work. * This only applies to builds being done from the top repository, i.e. building the entire JDK * Should be faster in all cases, however we have seen some cases where the benefit is slight, depends on the machine&disk used. * The highly parallel building could swamp some systems, you may need to use "make JOBS=2" to dial it down * For a limited time, the old Makefiles can still be used with "make NEWBUILD=false" * Also for a limited time, people allergic to using "configure" can try "make bridgeBuild" Please let us know about any issues you encounter, if you have access to JBS to file the issue please do so, use component=infrastructure and subcomponent=build, and add the label "build-infra". If you don't have access to JBS, provide us the details and we will file the issue for you. -kto From dingxmin at linux.vnet.ibm.com Sat Jan 5 05:37:57 2013 From: dingxmin at linux.vnet.ibm.com (Frank Ding) Date: Sat, 05 Jan 2013 13:37:57 +0800 Subject: Encoding problem when building In-Reply-To: References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> Message-ID: <50E7BC35.5040409@linux.vnet.ibm.com> Hi Volker, Yes, I think so. The comment is pasted below. /** * org/omg/PortableServer/Current.java . * ?IDL-to-Java ??? (???), ?? "3.2"?? * ?../../../../src/share/classes/org/omg/PortableServer/poa.idl * 2013?1?4? ??? ??01?21?01? CST */ It's in Chinese, and it says when translated to English that "Generated by IDL-to-Java compiler(portable) version 3.2 and the date. You can also view a "normal" English one under openjdk folder "corba\gensrc\" after performing a build. An relevant question is that in my env (export LANG=C), java output without any param always gives me Chinese help. Even though we may find out which env var or value jvm reads on startup, it could be impossible to change them. Any insight or idea on the mechanism is welcome. Best regards, Frank On 1/4/2013 4:59 PM, Volker Simonis wrote: > This is just a wild guess, but perhaps idlj uses the value of some > environment variables (or values derived from them - check > System.getProperties()) which contain non ASCII characters? This could > be something like PATH, HOSTNAME, USER. What exact characters are > there in the comment and what kind of comment is it? How does this > comment look on a "normal" system? > > Regards, > Volker > > > On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding > > wrote: > > Hi Kelly > I investigated how local specific characters get into generated > sources in corba module. Those classes are generated by following > command idlj > c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions > -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m > -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td > "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" > -i "../../../../src/share/classes/org/omg/PortableServer" -i > "../../../../src/share/classes/org/omg/PortableInterceptor" -corba > 3.0 -fall -pkgPrefix PortableServer org.omg > ../../../../src/share/classes/org/omg/PortableServer/poa.idl > > I checked idlj help but there is no encoding specific option. My > locale environment vars are listed below > > $ locale > LANG=C > LC_CTYPE="C" > LC_NUMERIC="C" > LC_TIME="C" > LC_COLLATE="C" > LC_MONETARY="C" > LC_MESSAGES="C" > LC_ALL= > > Could you give me any hint about how to force idlj to generate > ascii chars only? > > Best regards, > Frank > > > On 1/1/2013 12:47 AM, Kelly O'Hair wrote: > > In the past, the "-encoding ascii" was important, all the > reasons I can't completely list right now. But it is important > that regardless of the locale, the bits created during the > build should be the same for everyone. > The definition of "same" might not be bit for bit, but by > minimizing the potential differences we have a fighting > chance of measuring "the same". > > But my question is, how are any locale specific characters > getting into generated sources? That's what we need to find out. > > Removing "-encoding ascii" is probably not the right answer, > and if it is, will require some debate. > > -kto > > On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: > > Hi > I have an encoding problem when building openjdk 8 on my > Windows 7. My windows is Chinese environment but I > exported LANG=C in cygwin bash before building. The issue > is that in module corba and jdk, some java classes are > generated by program. They happen to contain Chinese > characters in comment. However, they are compiled with > explicit option "-encoding ascii" in makefile. This > results in unrecognizable chars complained by javac > (Error: encoding ascii unmappable chars) . I have a patch > that removes all unnecessary "-encoding ascii" but I am > not sure all its side effect. Shall I submit a bug? > > Best regards, > Frank > > > From jonathan.gibbons at oracle.com Sat Jan 5 17:24:17 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Sat, 05 Jan 2013 09:24:17 -0800 Subject: hg: jdk8/build: 8004229: build-infra: Umbrella for switch of default "make" to new makefiles In-Reply-To: <20130105050418.48F1F47570@hg.openjdk.java.net> References: <20130105050418.48F1F47570@hg.openjdk.java.net> Message-ID: <50E861C1.7090806@oracle.com> Congratulations! -- Jon On 01/04/2013 09:04 PM, kelly.ohair at oracle.com wrote: > Changeset: 5cf7750c8c43 > Author: ohair > Date: 2013-01-04 21:04 -0800 > URL: http://hg.openjdk.java.net/jdk8/build/rev/5cf7750c8c43 > > 8004229: build-infra: Umbrella for switch of default "make" to new makefiles > Reviewed-by: erikj, tbell > > ! Makefile > ! make/jprt.properties > From chris.hegarty at oracle.com Sat Jan 5 18:12:05 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Sat, 05 Jan 2013 18:12:05 +0000 Subject: hg: jdk8/build: 8004229: build-infra: Umbrella for switch of default "make" to new makefiles In-Reply-To: <50E861C1.7090806@oracle.com> References: <20130105050418.48F1F47570@hg.openjdk.java.net> <50E861C1.7090806@oracle.com> Message-ID: <50E86CF5.4050604@oracle.com> On 05/01/2013 17:24, Jonathan Gibbons wrote: > Congratulations! +1 great work guys. Can't wait until this makes its way into TL. -Chris. > > -- Jon > > On 01/04/2013 09:04 PM, kelly.ohair at oracle.com wrote: >> Changeset: 5cf7750c8c43 >> Author: ohair >> Date: 2013-01-04 21:04 -0800 >> URL: http://hg.openjdk.java.net/jdk8/build/rev/5cf7750c8c43 >> >> 8004229: build-infra: Umbrella for switch of default "make" to new >> makefiles >> Reviewed-by: erikj, tbell >> >> ! Makefile >> ! make/jprt.properties >> > From sadhak001 at gmail.com Sun Jan 6 00:05:51 2013 From: sadhak001 at gmail.com (Mani Sarkar) Date: Sun, 6 Jan 2013 00:05:51 +0000 Subject: OpenJDK builds: Ant build issues with jdk (netbeans) sub-projects - awt2d, j2se and jarzip In-Reply-To: References: Message-ID: Hi all, I have made some progress with the below three sub-projects, and have successfully built jarzip. But still get new error messages with awt2d and j2se. I answered my own question about the -source 8, its basically expecting the images/j2sdk-image to be assigned to the respective ALT_... variables via the make.options property in build.properties for all three projects. Unfortunately I wasn't able to build swing via the .../javax/swing/ folder where the required make file(s) are present. But my other queries still stand, if you can throw some light on them, it would be help make progress with these builds using the new build system. Thanks. Regards, Mani On Sat, Jan 5, 2013 at 12:39 AM, Mani Sarkar wrote: > Hi All, > > I have furthered my pursuits with building *OpenJDK projects *by building > the JDK sub-projects like swing, etc... but came across issues with > building 3 different projects which I wasn't able to build due > configuration issues. These sub-projects are located under the netbeans > subfolder under the .../jdk/make/ folder. > > They all are getting compiled for version 8 with the below args (which is > leading to a build failure): > > -source 8 -target 8 > > *jdk/awt2d* > > https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/awt2d/awt2dAntBuild.log > > *jdk/j2se* > > https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/j2se/j2seAntBuild.log > > *jdk/jarzip* > > https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/jarzip/jarzipAntBuild.log > > Where is this version configuration set for these projects, that I can > change either through file changes or alternative build.properties setting > changes? My other question is why are there no make files available for the > jdk sub-projects (i.e. *awt2d, j2se,* etc...) except for under * > javax/swing* has make files to build this project instead Ant build.xml > files are available. Is it possible to hook these ant files with the new > build system, instead of only being able to build the sub-projects via the > old build system (using the ALT_... variables via make.options). > > Thanks. > > Regards, > mani > > -- > Twitter: @theNeomatrix369 > Blog: http://neomatrix369.wordpress.com > > *Don't chase success, rather aim for "Excellence", and success will come > chasing after you!* > -- Twitter: @theNeomatrix369 Blog: http://neomatrix369.wordpress.com *Don't chase success, rather aim for "Excellence", and success will come chasing after you!* From jonathan.gibbons at oracle.com Sun Jan 6 01:26:51 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Sat, 05 Jan 2013 17:26:51 -0800 Subject: OpenJDK builds: Ant build issues with jdk (netbeans) sub-projects - awt2d, j2se and jarzip In-Reply-To: References: Message-ID: <50E8D2DB.6090206@oracle.com> Mani, I think you'd be better off working with the groups (if any) using these projects. They are likely to have ideas of how to evolve these projects in the context of the new build system. -- Jon On 01/05/2013 04:05 PM, Mani Sarkar wrote: > Hi all, > > I have made some progress with the below three sub-projects, and have > successfully built jarzip. But still get new error messages with awt2d and > j2se. > > I answered my own question about the -source 8, its basically expecting the > images/j2sdk-image to be assigned to the respective ALT_... variables via > the make.options property in build.properties for all three projects. > > Unfortunately I wasn't able to build swing via the .../javax/swing/ folder > where the required make file(s) are present. > > But my other queries still stand, if you can throw some light on them, it > would be help make progress with these builds using the new build system. > > Thanks. > > Regards, > Mani > > On Sat, Jan 5, 2013 at 12:39 AM, Mani Sarkar wrote: > >> Hi All, >> >> I have furthered my pursuits with building *OpenJDK projects *by building >> the JDK sub-projects like swing, etc... but came across issues with >> building 3 different projects which I wasn't able to build due >> configuration issues. These sub-projects are located under the netbeans >> subfolder under the .../jdk/make/ folder. >> >> They all are getting compiled for version 8 with the below args (which is >> leading to a build failure): >> >> -source 8 -target 8 >> >> *jdk/awt2d* >> >> https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/awt2d/awt2dAntBuild.log >> >> *jdk/j2se* >> >> https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/j2se/j2seAntBuild.log >> >> *jdk/jarzip* >> >> https://github.com/neomatrix369/BuildHelpers/blob/master/EclipseProjectsForOpenJDK/Logs/jdk/jarzip/jarzipAntBuild.log >> >> Where is this version configuration set for these projects, that I can >> change either through file changes or alternative build.properties setting >> changes? My other question is why are there no make files available for the >> jdk sub-projects (i.e. *awt2d, j2se,* etc...) except for under * >> javax/swing* has make files to build this project instead Ant build.xml >> files are available. Is it possible to hook these ant files with the new >> build system, instead of only being able to build the sub-projects via the >> old build system (using the ALT_... variables via make.options). >> >> Thanks. >> >> Regards, >> mani >> >> -- >> Twitter: @theNeomatrix369 >> Blog: http://neomatrix369.wordpress.com >> >> *Don't chase success, rather aim for "Excellence", and success will come >> chasing after you!* >> > > From Alan.Bateman at oracle.com Mon Jan 7 09:43:34 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Jan 2013 09:43:34 +0000 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 Message-ID: <50EA98C6.9030504@oracle.com> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? -Alan From joel.franck at oracle.com Mon Jan 7 10:03:00 2013 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Mon, 7 Jan 2013 11:03:00 +0100 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <50EA98C6.9030504@oracle.com> References: <50EA98C6.9030504@oracle.com> Message-ID: On 7 jan 2013, at 10:43, Alan Bateman wrote: > > I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). > > For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? > I have export CPATH="/usr/X11/include" set while building tl with the old makefile. There is an Intrinsic.h in /usr/X11/include/X11 hope this helps. cheers /Joel From Alan.Bateman at oracle.com Mon Jan 7 12:35:08 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Jan 2013 12:35:08 +0000 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: References: <50EA98C6.9030504@oracle.com> Message-ID: <50EAC0FC.8070502@oracle.com> On 07/01/2013 10:03, Joel Borggr?n-Franck wrote: > On 7 jan 2013, at 10:43, Alan Bateman wrote: > >> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >> >> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >> > I have > > export CPATH="/usr/X11/include" > > set while building tl with the old makefile. There is an Intrinsic.h in /usr/X11/include/X11 > Thanks that works (although I run into the same issue as the new build with sed when building images). -Alan From spoole at linux.vnet.ibm.com Mon Jan 7 13:57:24 2013 From: spoole at linux.vnet.ibm.com (Steve Poole) Date: Mon, 7 Jan 2013 13:57:24 +0000 Subject: jdk8 Build changes In-Reply-To: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> References: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> Message-ID: <9F6CABBB-16C2-43DD-A9CA-D45B66C83FEB@linux.vnet.ibm.com> hi Kelly, It's great to see these changes about to go mainstream. Really appreciate everyones effort in making this happen. I have a few questions though (apologies if you've already answered them elsewhere) 1 - What does 'a limited time' mean when referring to being able to use the old make file system? 2 - Do you plan to actively remove obsolete files? 3- If so, on what sort of timescale will these files be removed? Cheers Steve On 5 Jan 2013, at 05:07, Kelly O'Hair wrote: > Excuse the wide mailing, but it was important to try and reach anyone building jdk8. > > The jdk8/build repositories at http://hg.openjdk.java.net/jdk8/build have been changed to use the new > build-infra "configure&make" build setup, so it is official, but it still needs to be integrated into the > main jdk8/jdk8 repositories at http://hg.openjdk.java.net/jdk8/jdk8. This is expected to happen > in 2 weeks. > > A few bullet points: > > * ANY changes to ANY make/ files from now until we integrate into jdk8/jdk8 represents a risk, please talk to us first. > * Windows CYGWIN 1.7.16+ will be required, MKS will no longer work. > * This only applies to builds being done from the top repository, i.e. building the entire JDK > * Should be faster in all cases, however we have seen some cases where the benefit is slight, depends on the machine&disk used. > * The highly parallel building could swamp some systems, you may need to use "make JOBS=2" to dial it down > * For a limited time, the old Makefiles can still be used with "make NEWBUILD=false" > * Also for a limited time, people allergic to using "configure" can try "make bridgeBuild" > > Please let us know about any issues you encounter, if you have access to JBS to file the issue please do so, > use component=infrastructure and subcomponent=build, and add the label "build-infra". > If you don't have access to JBS, provide us the details and we will file the issue for you. > > -kto > From oehrstroem at gmail.com Mon Jan 7 13:57:58 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 7 Jan 2013 14:57:58 +0100 Subject: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo. In-Reply-To: References: <03256ADC-1068-472A-9610-B79074B7B51B@Oracle.com> Message-ID: 2012/12/16 Kelly O'Hair : > Looks ok to me. But do the makefile comments need to be adjusted? The makefile comments, comment on the fact that Java sources that reside inside make/tools are in fact part of the dt.jar (ie part of the jdk, not just a tool). However this is not that easy to fix, since the actual tool that generates the swing classes, needs these files. So instead of copying the sources out from src/share/classes to compile the tool, or linking to the classes in the boot jdk dt.jar, they are simply stored in make/tools. Something for future generations to ponder. The comments should be updated to reflect the new positions of the source files inside the tools directory. //Fredrik From Alan.Bateman at oracle.com Mon Jan 7 14:09:53 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Jan 2013 14:09:53 +0000 Subject: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo. In-Reply-To: References: <03256ADC-1068-472A-9610-B79074B7B51B@Oracle.com> Message-ID: <50EAD731.5060301@oracle.com> On 07/01/2013 13:57, Fredrik ?hrstr?m wrote: > : > The makefile comments, comment on the fact that Java sources that > reside inside make/tools > are in fact part of the dt.jar (ie part of the jdk, not just a tool). > > However this is not that easy to fix, since the actual tool that > generates the swing classes, > needs these files. So instead of copying the sources out from > src/share/classes to compile the tool, > or linking to the classes in the boot jdk dt.jar, they are simply > stored in make/tools. > > Something for future generations to ponder. The comments should be updated to > reflect the new positions of the source files inside the tools directory. > > //Fredrik Just an FYI that we will eventually need to get rid of dt.jar, see: http://bugs.sun.com/view_bug.do?bug_id=7179078 -Alan. From oehrstroem at gmail.com Mon Jan 7 15:59:00 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 7 Jan 2013 16:59:00 +0100 Subject: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo. In-Reply-To: <50D06400.4090808@oracle.com> References: <03256ADC-1068-472A-9610-B79074B7B51B@Oracle.com> <50D06400.4090808@oracle.com> Message-ID: 2012/12/18 Sergey Malenkov : > Looks OK to me. But there are a lot of images in the > make/tools/swing-beans/beaninfo/images folder. Could you please check the > make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar > library will be packed correctly? Yes, I have verified that the gifs are in the same folder. > Also I think that moving of java files from the > make/tools/swing-beans/beaninfo folder is redundant, because we could copy > them to the expected folder from the current location. Yes, copying to a temporary, correct package directory, would work. But I think it is better to move them into the correct package directory, it is simpler and cleaner. However here is another question. With this change, the following 46 source files appear in src.zip: /javax/swing/AbstractButtonBeanInfo.java /javax/swing/BoxBeanInfo.java ---- 8< ---- javax/swing/SwingBeanInfoBase.java /javax/swing/text/JTextComponentBeanInfo.java It seems to be reasonable that these sources should be part of the src.zip and that it was a bug previously that they were not. Can you confirm this Sergey? //Fredrik From volker.simonis at gmail.com Mon Jan 7 16:09:16 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 7 Jan 2013 17:09:16 +0100 Subject: jdk8 Build changes In-Reply-To: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> References: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> Message-ID: On Sat, Jan 5, 2013 at 6:07 AM, Kelly O'Hair wrote: > Excuse the wide mailing, but it was important to try and reach anyone > building jdk8. > > The jdk8/build repositories at http://hg.openjdk.java.net/jdk8/build have > been changed to use the new > build-infra "configure&make" build setup, so it is official, but it still > needs to be integrated into the > main jdk8/jdk8 repositories at http://hg.openjdk.java.net/jdk8/jdk8. This > is expected to happen > in 2 weeks. > > A few bullet points: > > * ANY changes to ANY make/ files from now until we integrate into > jdk8/jdk8 represents a risk, please talk to us first. > * Windows CYGWIN 1.7.16+ will be required, MKS will no longer work. > What about the MinGW build? Recently there have been changes (7152336 : Enable builds on Windows with MinGW/MSYS and 7181175 : Enable builds on Windows with MinGW/MSYS) which enabled the MinGW build in the http://hg.openjdk.java.net/jdk8/buildforest. I always thought that the MinGW build would be the default for the new build systems but reading your mail this apparently isn't true. Will the MinGW build just not be the default one or will it not work / not be supported at all? If not, will the MinGW changes just get lost in the old build infrastructure? Regards, Volker > * This only applies to builds being done from the top repository, i.e. > building the entire JDK > * Should be faster in all cases, however we have seen some cases where the > benefit is slight, depends on the machine&disk used. > * The highly parallel building could swamp some systems, you may need to > use "make JOBS=2" to dial it down > * For a limited time, the old Makefiles can still be used with "make > NEWBUILD=false" > * Also for a limited time, people allergic to using "configure" can try > "make bridgeBuild" > > Please let us know about any issues you encounter, if you have access to > JBS to file the issue please do so, > use component=infrastructure and subcomponent=build, and add the label > "build-infra". > If you don't have access to JBS, provide us the details and we will file > the issue for you. > > -kto > > From tim.bell at oracle.com Mon Jan 7 16:33:12 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 07 Jan 2013 08:33:12 -0800 Subject: jdk8 Build changes In-Reply-To: References: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> Message-ID: <50EAF8C8.6040509@oracle.com> Hi Volker: > I always thought that the > MinGW build would be the default for the > new build systems but reading your mail this apparently isn't true. > > Will the MinGW build just not be the default one or will it not work / not > be supported at all? > If not, will the MinGW changes just get lost in the old build > infrastructure? MinGW/MSYS is not forgotten. We had to focus on Cygwin to get past this milestone. I will circle back and work on MSYS support, hopefully starting this week. Tim From kelly.ohair at oracle.com Mon Jan 7 17:50:42 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 09:50:42 -0800 Subject: jdk8 Build changes In-Reply-To: <50EAF8C8.6040509@oracle.com> References: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> <50EAF8C8.6040509@oracle.com> Message-ID: On Jan 7, 2013, at 8:33 AM, Tim Bell wrote: > Hi Volker: > >> I always thought that the >> MinGW build would be the default for the >> new build systems but reading your mail this apparently isn't true. >> >> Will the MinGW build just not be the default one or will it not work / not >> be supported at all? >> If not, will the MinGW changes just get lost in the old build >> infrastructure? > > MinGW/MSYS is not forgotten. We had to focus on Cygwin to get past this milestone. > > I will circle back and work on MSYS support, hopefully starting this week. > > Tim > Tim is correct, we aren't forgetting it, but we had to focus on CYGWIN, which was a known quantity to most of us. We also had some performance and stability issues with MSYS which we never got to the bottom of. When we cranked up the -j settings MSYS make seemed to have some issues for us. But that was before Erik re-did the 'images' logic, which even with CYGWIN had some predictability issues. So we need to go back and try it again at some point. But internally, we would like to change to Windows 2008 R2 X64 as the standard build OS, for 32 and 64 bit builds, and I think that will have a higher priority as far as Windows efforts go, at least for the immediate time frame. We are using XP and 2003 and need to get off those systems asap. -kto From kelly.ohair at oracle.com Mon Jan 7 18:07:44 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 10:07:44 -0800 Subject: jdk8 Build changes In-Reply-To: <9F6CABBB-16C2-43DD-A9CA-D45B66C83FEB@linux.vnet.ibm.com> References: <2F74F6AA-BD56-4F30-BF2C-B1C3DEEF8EE7@oracle.com> <9F6CABBB-16C2-43DD-A9CA-D45B66C83FEB@linux.vnet.ibm.com> Message-ID: <96DC53C4-02D5-4C29-8660-C59A88AD8A8D@oracle.com> On Jan 7, 2013, at 5:57 AM, Steve Poole wrote: > hi Kelly, > > It's great to see these changes about to go mainstream. Really appreciate everyones effort in making this happen. I have a few questions though (apologies if you've already answered them elsewhere) > > 1 - What does 'a limited time' mean when referring to being able to use the old make file system? Not exactly sure, but as soon as our JDK8 Release Engineering team is completely off the old makefiles, and no other team is dependent on them. That's a hard date to predict, but that would be the start date for decommission. The overhead of keeping two different build systems working is pretty significant. > 2 - Do you plan to actively remove obsolete files? Yes. > 3- If so, on what sort of timescale will these files be removed? Incremental, starting when we know teams no longer need the old makefiles, the above 'start date'. Some of the files might be removed right away, like the corba/make, jaxp/make, and jaxws/make files. The langtools/make files may remain until we have an ant script that uses the langtools/makefiles or we have some kind of NetBeans solution for that team, if they don't have one already. Some of the jdk/make files might go quickly, as will some of the top repo make/* files, but we have some other Oracle jdk dependencies on some of these files so we need to craft a solution to that dependency. --- Let me know if that answers your questions. -kto > > Cheers > > Steve > > > > On 5 Jan 2013, at 05:07, Kelly O'Hair wrote: > >> Excuse the wide mailing, but it was important to try and reach anyone building jdk8. >> >> The jdk8/build repositories at http://hg.openjdk.java.net/jdk8/build have been changed to use the new >> build-infra "configure&make" build setup, so it is official, but it still needs to be integrated into the >> main jdk8/jdk8 repositories at http://hg.openjdk.java.net/jdk8/jdk8. This is expected to happen >> in 2 weeks. >> >> A few bullet points: >> >> * ANY changes to ANY make/ files from now until we integrate into jdk8/jdk8 represents a risk, please talk to us first. >> * Windows CYGWIN 1.7.16+ will be required, MKS will no longer work. >> * This only applies to builds being done from the top repository, i.e. building the entire JDK >> * Should be faster in all cases, however we have seen some cases where the benefit is slight, depends on the machine&disk used. >> * The highly parallel building could swamp some systems, you may need to use "make JOBS=2" to dial it down >> * For a limited time, the old Makefiles can still be used with "make NEWBUILD=false" >> * Also for a limited time, people allergic to using "configure" can try "make bridgeBuild" >> >> Please let us know about any issues you encounter, if you have access to JBS to file the issue please do so, >> use component=infrastructure and subcomponent=build, and add the label "build-infra". >> If you don't have access to JBS, provide us the details and we will file the issue for you. >> >> -kto >> > From kelly.ohair at oracle.com Mon Jan 7 19:41:37 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 11:41:37 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <50EAC0FC.8070502@oracle.com> References: <50EA98C6.9030504@oracle.com> <50EAC0FC.8070502@oracle.com> Message-ID: If someone could document everything that was done to get this working I would appreciate it. We have a bunch of 10.8 macs that we need to figure out how to get them to build the jdk for 10.7 or we have to come up with a better answer. I assume Mac 10.7 support in jdk7u and jdk8 will continue, but when the newer Macs only work with 10.8 that makes things difficult. -kto On Jan 7, 2013, at 4:35 AM, Alan Bateman wrote: > On 07/01/2013 10:03, Joel Borggr?n-Franck wrote: >> On 7 jan 2013, at 10:43, Alan Bateman wrote: >> >>> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >>> >>> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >>> >> I have >> >> export CPATH="/usr/X11/include" >> >> set while building tl with the old makefile. There is an Intrinsic.h in /usr/X11/include/X11 >> > Thanks that works (although I run into the same issue as the new build with sed when building images). > > -Alan From kelly.ohair at oracle.com Mon Jan 7 19:42:34 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 11:42:34 -0800 Subject: Encoding problem when building In-Reply-To: <50E7BC35.5040409@linux.vnet.ibm.com> References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> <50E7BC35.5040409@linux.vnet.ibm.com> Message-ID: Did a bug report get filed for this issue? -kto On Jan 4, 2013, at 9:37 PM, Frank Ding wrote: > Hi Volker, > Yes, I think so. The comment is pasted below. > /** > * org/omg/PortableServer/Current.java . > * ?IDL-to-Java ??? (???), ?? "3.2"?? > * ?../../../../src/share/classes/org/omg/PortableServer/poa.idl > * 2013?1?4? ??? ??01?21?01? CST > */ > > It's in Chinese, and it says when translated to English that "Generated by IDL-to-Java compiler(portable) version 3.2 and the date. You can also view a "normal" English one under openjdk folder "corba\gensrc\" after performing a build. > > An relevant question is that in my env (export LANG=C), java output without any param always gives me Chinese help. Even though we may find out which env var or value jvm reads on startup, it could be impossible to change them. Any insight or idea on the mechanism is welcome. > > Best regards, > Frank > > On 1/4/2013 4:59 PM, Volker Simonis wrote: >> This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind of comment is it? How does this comment look on a "normal" system? >> >> Regards, >> Volker >> >> >> On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding > wrote: >> >> Hi Kelly >> I investigated how local specific characters get into generated >> sources in corba module. Those classes are generated by following >> command idlj >> c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions >> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td >> "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" >> -i "../../../../src/share/classes/org/omg/PortableServer" -i >> "../../../../src/share/classes/org/omg/PortableInterceptor" -corba >> 3.0 -fall -pkgPrefix PortableServer org.omg >> ../../../../src/share/classes/org/omg/PortableServer/poa.idl >> >> I checked idlj help but there is no encoding specific option. My >> locale environment vars are listed below >> >> $ locale >> LANG=C >> LC_CTYPE="C" >> LC_NUMERIC="C" >> LC_TIME="C" >> LC_COLLATE="C" >> LC_MONETARY="C" >> LC_MESSAGES="C" >> LC_ALL= >> >> Could you give me any hint about how to force idlj to generate >> ascii chars only? >> >> Best regards, >> Frank >> >> >> On 1/1/2013 12:47 AM, Kelly O'Hair wrote: >> >> In the past, the "-encoding ascii" was important, all the >> reasons I can't completely list right now. But it is important >> that regardless of the locale, the bits created during the >> build should be the same for everyone. >> The definition of "same" might not be bit for bit, but by >> minimizing the potential differences we have a fighting >> chance of measuring "the same". >> >> But my question is, how are any locale specific characters >> getting into generated sources? That's what we need to find out. >> >> Removing "-encoding ascii" is probably not the right answer, >> and if it is, will require some debate. >> >> -kto >> >> On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: >> >> Hi >> I have an encoding problem when building openjdk 8 on my >> Windows 7. My windows is Chinese environment but I >> exported LANG=C in cygwin bash before building. The issue >> is that in module corba and jdk, some java classes are >> generated by program. They happen to contain Chinese >> characters in comment. However, they are compiled with >> explicit option "-encoding ascii" in makefile. This >> results in unrecognizable chars complained by javac >> (Error: encoding ascii unmappable chars) . I have a patch >> that removes all unnecessary "-encoding ascii" but I am >> not sure all its side effect. Shall I submit a bug? >> >> Best regards, >> Frank >> >> >> > From kelly.ohair at oracle.com Mon Jan 7 20:47:12 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 12:47:12 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <50EA98C6.9030504@oracle.com> References: <50EA98C6.9030504@oracle.com> Message-ID: <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was supposedly some kind of compiler option we need to make sure was used on all compiles. I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( -kto On Jan 7, 2013, at 1:43 AM, Alan Bateman wrote: > > I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). > > For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? > > -Alan From david.dehaven at oracle.com Mon Jan 7 21:05:32 2013 From: david.dehaven at oracle.com (David DeHaven) Date: Mon, 7 Jan 2013 13:05:32 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> References: <50EA98C6.9030504@oracle.com> <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> Message-ID: <634157C4-03FF-4153-95BE-0EB48148FC2D@oracle.com> -mmacosx-version-min=version ? -DrD- > In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was > supposedly some kind of compiler option we need to make sure was used on all compiles. > > I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( > > -kto > > On Jan 7, 2013, at 1:43 AM, Alan Bateman wrote: > >> >> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >> >> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >> >> -Alan > From tim.bell at oracle.com Mon Jan 7 22:01:43 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Mon, 07 Jan 2013 22:01:43 +0000 Subject: hg: jdk8/build: 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later Message-ID: <20130107220143.EF626470CB@hg.openjdk.java.net> Changeset: 7a3c6ffdf1fb Author: tbell Date: 2013-01-07 14:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/7a3c6ffdf1fb 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later Reviewed-by: ohair ! common/autoconf/autogen.sh From kelly.ohair at oracle.com Mon Jan 7 22:07:28 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 14:07:28 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <634157C4-03FF-4153-95BE-0EB48148FC2D@oracle.com> References: <50EA98C6.9030504@oracle.com> <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> <634157C4-03FF-4153-95BE-0EB48148FC2D@oracle.com> Message-ID: <13720F99-5459-469B-99D9-DCC4899F2F20@oracle.com> Yeah, that's it -mmacosx-version-min=10.7 it needs to be added to all compile and link lines as I recall. -kto On Jan 7, 2013, at 1:05 PM, David DeHaven wrote: > > -mmacosx-version-min=version ? > > -DrD- > >> In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was >> supposedly some kind of compiler option we need to make sure was used on all compiles. >> >> I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( >> >> -kto >> >> On Jan 7, 2013, at 1:43 AM, Alan Bateman wrote: >> >>> >>> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >>> >>> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >>> >>> -Alan >> > From david.dehaven at oracle.com Mon Jan 7 23:32:14 2013 From: david.dehaven at oracle.com (David DeHaven) Date: Mon, 7 Jan 2013 15:32:14 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <13720F99-5459-469B-99D9-DCC4899F2F20@oracle.com> References: <50EA98C6.9030504@oracle.com> <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> <634157C4-03FF-4153-95BE-0EB48148FC2D@oracle.com> <13720F99-5459-469B-99D9-DCC4899F2F20@oracle.com> Message-ID: <5CCFAB02-3C6B-4087-9154-9ABA4743143D@oracle.com> Yes, generally added to CFLAGS. Both compilers (clang and gcc) support this option and will also pick up MACOSX_DEPLOYMENT_TARGET from the environment if -mmacosx-version-min is not given on the command line. By default this is set to the version of the OS it was built on, so if someone builds on 10.8.2 it won't run on anything earlier. If you're calling ld directly then pass "-macosx_version_min version" instead. -DrD- > Yeah, that's it -mmacosx-version-min=10.7 > > it needs to be added to all compile and link lines as I recall. > > -kto > > On Jan 7, 2013, at 1:05 PM, David DeHaven wrote: > >> >> -mmacosx-version-min=version ? >> >> -DrD- >> >>> In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was >>> supposedly some kind of compiler option we need to make sure was used on all compiles. >>> >>> I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( >>> >>> -kto >>> >>> On Jan 7, 2013, at 1:43 AM, Alan Bateman wrote: >>> >>>> >>>> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >>>> >>>> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >>>> >>>> -Alan >>> >> > From kelly.ohair at oracle.com Mon Jan 7 23:40:46 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Jan 2013 15:40:46 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <5CCFAB02-3C6B-4087-9154-9ABA4743143D@oracle.com> References: <50EA98C6.9030504@oracle.com> <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> <634157C4-03FF-4153-95BE-0EB48148FC2D@oracle.com> <13720F99-5459-469B-99D9-DCC4899F2F20@oracle.com> <5CCFAB02-3C6B-4087-9154-9ABA4743143D@oracle.com> Message-ID: <858A86E8-8AC5-4BD7-81A0-A4DB60626C1C@oracle.com> So all we need to do is: export MACOSX_DEPLOYMENT_TARGET=10.7 ??? That would be easy. -kto On Jan 7, 2013, at 3:32 PM, David DeHaven wrote: > > Yes, generally added to CFLAGS. Both compilers (clang and gcc) support this option and will also pick up MACOSX_DEPLOYMENT_TARGET from the environment if -mmacosx-version-min is not given on the command line. By default this is set to the version of the OS it was built on, so if someone builds on 10.8.2 it won't run on anything earlier. > > If you're calling ld directly then pass "-macosx_version_min version" instead. > > -DrD- > >> Yeah, that's it -mmacosx-version-min=10.7 >> >> it needs to be added to all compile and link lines as I recall. >> >> -kto >> >> On Jan 7, 2013, at 1:05 PM, David DeHaven wrote: >> >>> >>> -mmacosx-version-min=version ? >>> >>> -DrD- >>> >>>> In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was >>>> supposedly some kind of compiler option we need to make sure was used on all compiles. >>>> >>>> I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( >>>> >>>> -kto >>>> >>>> On Jan 7, 2013, at 1:43 AM, Alan Bateman wrote: >>>> >>>>> >>>>> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >>>>> >>>>> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >>>>> >>>>> -Alan >>>> >>> >> > From david.r.chase at oracle.com Tue Jan 8 00:03:06 2013 From: david.r.chase at oracle.com (David Chase) Date: Mon, 7 Jan 2013 19:03:06 -0500 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: References: <50EA98C6.9030504@oracle.com> <50EAC0FC.8070502@oracle.com> Message-ID: <4B4EBE96-4D41-472A-B838-79BFE2DAA0F4@oracle.com> On 2013-01-07, at 2:41 PM, Kelly O'Hair wrote: > If someone could document everything that was done to get this working I would appreciate it. > > We have a bunch of 10.8 macs that we need to figure out how to get them to build the jdk for 10.7 > or we have to come up with a better answer. > I assume Mac 10.7 support in jdk7u and jdk8 will continue, but when the newer Macs only work with 10.8 > that makes things difficult. > > -kto New build worked last time I tried it; I will try again after sending this email. I just tried this old-build script, which has worked before with jdk8 on a mac, but this time it failed bizarrely. Script (invoked as "./macosmake all"): unset CLASSPATH export ALT_BOOTDIR=/Library/Java/JavaVirtualMachines/1.7.0.jdk/Contents/Home export LANG=C export LC_ALL=C export X11_PATH=/opt/X11 export LP64=1 export OTHER_INCLUDES=-I/opt/X11/include make "$@" Failure: cd /Users/dr2chase/work/jdk8tl/build/macosx-x86_64/j2re-image/lib && \ /Library/Java/JavaVirtualMachines/1.7.0.jdk/Contents/Home/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Djava.awt.headless=true -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m -jar /Users/dr2chase/work/jdk8tl/build/macosx-x86_64/btjars/buildmetaindex.jar \ -o meta-index *.jar Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -7 at java.lang.String.substring(String.java:1958) at build.tools.buildmetaindex.JarMetaIndex.isPrefixKnown(BuildMetaIndex.java:315) at build.tools.buildmetaindex.JarMetaIndex.getMetaIndex(BuildMetaIndex.java:233) at build.tools.buildmetaindex.BuildMetaIndex.main(BuildMetaIndex.java:97) make[2]: *** [initial-image-jre] Error 1 make[1]: *** [jdk-build] Error 2 make: *** [build_product_image] Error 2 > > On Jan 7, 2013, at 4:35 AM, Alan Bateman wrote: > >> On 07/01/2013 10:03, Joel Borggr?n-Franck wrote: >>> On 7 jan 2013, at 10:43, Alan Bateman wrote: >>> >>>> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >>>> >>>> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >>>> >>> I have >>> >>> export CPATH="/usr/X11/include" >>> >>> set while building tl with the old makefile. There is an Intrinsic.h in /usr/X11/include/X11 >>> >> Thanks that works (although I run into the same issue as the new build with sed when building images). >> >> -Alan > From david.dehaven at oracle.com Tue Jan 8 00:45:29 2013 From: david.dehaven at oracle.com (David DeHaven) Date: Mon, 7 Jan 2013 16:45:29 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <858A86E8-8AC5-4BD7-81A0-A4DB60626C1C@oracle.com> References: <50EA98C6.9030504@oracle.com> <2289CDB3-21BB-4467-A416-9F607D2D3681@oracle.com> <634157C4-03FF-4153-95BE-0EB48148FC2D@oracle.com> <13720F99-5459-469B-99D9-DCC4899F2F20@oracle.com> <5CCFAB02-3C6B-4087-9154-9ABA4743143D@oracle.com> <858A86E8-8AC5-4BD7-81A0-A4DB60626C1C@oracle.com> Message-ID: Yeah, that should work, as long as make is set up to handle the environment correctly :) -DrD- > So all we need to do is: > > export MACOSX_DEPLOYMENT_TARGET=10.7 > > ??? > > That would be easy. > > -kto > > On Jan 7, 2013, at 3:32 PM, David DeHaven wrote: > >> >> Yes, generally added to CFLAGS. Both compilers (clang and gcc) support this option and will also pick up MACOSX_DEPLOYMENT_TARGET from the environment if -mmacosx-version-min is not given on the command line. By default this is set to the version of the OS it was built on, so if someone builds on 10.8.2 it won't run on anything earlier. >> >> If you're calling ld directly then pass "-macosx_version_min version" instead. >> >> -DrD- >> >>> Yeah, that's it -mmacosx-version-min=10.7 >>> >>> it needs to be added to all compile and link lines as I recall. >>> >>> -kto >>> >>> On Jan 7, 2013, at 1:05 PM, David DeHaven wrote: >>> >>>> >>>> -mmacosx-version-min=version ? >>>> >>>> -DrD- >>>> >>>>> In order for the bits created on 10.8 to work on 10.7 (which is what we ultimately need), there was >>>>> supposedly some kind of compiler option we need to make sure was used on all compiles. >>>>> >>>>> I don't have that spelling on the option right now, apparently beehive deleted my email stash. :^( >>>>> >>>>> -kto >>>>> >>>>> On Jan 7, 2013, at 1:43 AM, Alan Bateman wrote: >>>>> >>>>>> >>>>>> I upgraded a Mac to 10.8.2 and Xcode 4.5.2 over the break, now I'm trying to get the jdk7u/jdk7u-dev, jdk8/tl and jigsaw/jigsaw forests building again. I installed XQuartz 2.7.2 so I have X11 and jdk8/tl builds fine with the new build (except for the "images" target, there's an issue with sed there). >>>>>> >>>>>> For the old build (jdk7u-dev and jigsaw) then AWT won't build because it can't find X11/Intrinsic.h. With XQuartz then it looks like the X11 bits are in /opt/X11. The include files are there so I tried to build with ALT_X11_PATH=/opt/X11 but that doesn't help. Is there anything else I need to know? >>>>>> >>>>>> -Alan >>>>> >>>> >>> >> > From david.dehaven at oracle.com Tue Jan 8 00:53:59 2013 From: david.dehaven at oracle.com (David DeHaven) Date: Mon, 7 Jan 2013 16:53:59 -0800 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <4B4EBE96-4D41-472A-B838-79BFE2DAA0F4@oracle.com> References: <50EA98C6.9030504@oracle.com> <50EAC0FC.8070502@oracle.com> <4B4EBE96-4D41-472A-B838-79BFE2DAA0F4@oracle.com> Message-ID: <34472D25-442F-4BF6-A9A8-7540BE58CB46@oracle.com> >> Thanks that works (although I run into the same issue as the new build with sed when building images). I have GNU sed installed via MacPorts and pass SED=/opt/local/bin/gsed to make. -DrD- From david.r.chase at oracle.com Tue Jan 8 02:11:38 2013 From: david.r.chase at oracle.com (David Chase) Date: Mon, 7 Jan 2013 21:11:38 -0500 Subject: X11/Intrinsic.h not found, ALT_X11_PATH=/opt/X11 In-Reply-To: <4B4EBE96-4D41-472A-B838-79BFE2DAA0F4@oracle.com> References: <50EA98C6.9030504@oracle.com> <50EAC0FC.8070502@oracle.com> <4B4EBE96-4D41-472A-B838-79BFE2DAA0F4@oracle.com> Message-ID: <7A7773CD-A8B7-410C-AFD2-2A2145312C70@oracle.com> > > New build worked last time I tried it; I will try again after sending this email. New build (jdk8tl) confirmed to (still) work on MacOS 10.8.2 with recent Developer Tools and XQuartz. (I got as far as running a properties-printer with the built system.) David From dingxmin at linux.vnet.ibm.com Tue Jan 8 05:59:43 2013 From: dingxmin at linux.vnet.ibm.com (Frank Ding) Date: Tue, 08 Jan 2013 13:59:43 +0800 Subject: Encoding problem when building In-Reply-To: References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> <50E7BC35.5040409@linux.vnet.ibm.com> Message-ID: <50EBB5CF.3090505@linux.vnet.ibm.com> Hi Kelly, I have filed a bug whose internal review id is 2421470. It was filed with "Product/Category" being "JDK/JRE" and "Subcategory" being "Problems common to more than one tool". I am wondering since it only happens when building OpenJDK, is it eligible for a Java bug? In addition, do you have any idea on how to force java programs such as idlj to use ascii? Best regards, Frank On 1/8/2013 3:42 AM, Kelly O'Hair wrote: > Did a bug report get filed for this issue? > > -kto > > On Jan 4, 2013, at 9:37 PM, Frank Ding wrote: > >> Hi Volker, >> Yes, I think so. The comment is pasted below. >> /** >> * org/omg/PortableServer/Current.java . >> * ?IDL-to-Java ??? (???), ?? "3.2"?? >> * ?../../../../src/share/classes/org/omg/PortableServer/poa.idl >> * 2013?1?4? ??? ??01?21?01? CST >> */ >> >> It's in Chinese, and it says when translated to English that "Generated by IDL-to-Java compiler(portable) version 3.2 and the date. You can also view a "normal" English one under openjdk folder "corba\gensrc\" after performing a build. >> >> An relevant question is that in my env (export LANG=C), java output without any param always gives me Chinese help. Even though we may find out which env var or value jvm reads on startup, it could be impossible to change them. Any insight or idea on the mechanism is welcome. >> >> Best regards, >> Frank >> >> On 1/4/2013 4:59 PM, Volker Simonis wrote: >>> This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind of comment is it? How does this comment look on a "normal" system? >>> >>> Regards, >>> Volker >>> >>> >>> On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding > wrote: >>> >>> Hi Kelly >>> I investigated how local specific characters get into generated >>> sources in corba module. Those classes are generated by following >>> command idlj >>> c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions >>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td >>> "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" >>> -i "../../../../src/share/classes/org/omg/PortableServer" -i >>> "../../../../src/share/classes/org/omg/PortableInterceptor" -corba >>> 3.0 -fall -pkgPrefix PortableServer org.omg >>> ../../../../src/share/classes/org/omg/PortableServer/poa.idl >>> >>> I checked idlj help but there is no encoding specific option. My >>> locale environment vars are listed below >>> >>> $ locale >>> LANG=C >>> LC_CTYPE="C" >>> LC_NUMERIC="C" >>> LC_TIME="C" >>> LC_COLLATE="C" >>> LC_MONETARY="C" >>> LC_MESSAGES="C" >>> LC_ALL= >>> >>> Could you give me any hint about how to force idlj to generate >>> ascii chars only? >>> >>> Best regards, >>> Frank >>> >>> >>> On 1/1/2013 12:47 AM, Kelly O'Hair wrote: >>> >>> In the past, the "-encoding ascii" was important, all the >>> reasons I can't completely list right now. But it is important >>> that regardless of the locale, the bits created during the >>> build should be the same for everyone. >>> The definition of "same" might not be bit for bit, but by >>> minimizing the potential differences we have a fighting >>> chance of measuring "the same". >>> >>> But my question is, how are any locale specific characters >>> getting into generated sources? That's what we need to find out. >>> >>> Removing "-encoding ascii" is probably not the right answer, >>> and if it is, will require some debate. >>> >>> -kto >>> >>> On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: >>> >>> Hi >>> I have an encoding problem when building openjdk 8 on my >>> Windows 7. My windows is Chinese environment but I >>> exported LANG=C in cygwin bash before building. The issue >>> is that in module corba and jdk, some java classes are >>> generated by program. They happen to contain Chinese >>> characters in comment. However, they are compiled with >>> explicit option "-encoding ascii" in makefile. This >>> results in unrecognizable chars complained by javac >>> (Error: encoding ascii unmappable chars) . I have a patch >>> that removes all unnecessary "-encoding ascii" but I am >>> not sure all its side effect. Shall I submit a bug? >>> >>> Best regards, >>> Frank >>> >>> >>> From david.holmes at oracle.com Tue Jan 8 08:02:21 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 08 Jan 2013 18:02:21 +1000 Subject: Request for Review: Java SE 8 Compact Profiles In-Reply-To: <50E64DF1.8060004@oracle.com> References: <50D3FF29.6010005@oracle.com> <50E59291.3080305@oracle.com> <50E64DF1.8060004@oracle.com> Message-ID: <50EBD28D.5020409@oracle.com> I have updated webrevs: http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/ http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/ I've addressed the minor suggestions that have been given by Kelly and Erik eg: - better comment on the jarreorder change (and a CR to follow up) - the de-beaned classes now go to the images output directory not JDK (thanks to Alan) The major change is that I no longer use the profiles files to define the contents of a full JRE. So the file lists that had moved to Profiles.gmk have moved back to Images.gmk and are not used when creating a profile image. This means that the only change for non-profiles builds (outside the Version.java modifications) is in how the list of JARS to build is put together. I've also integrated this with latest jdk8/build changes including all the UNSIGNED jar updates - which fit in quite nicely. One thing to note that I didn't mention originally, the change to makefiles/GensrcX11Wrappers.gmk is a hack to make cross-compilation work. The real fix is languishing in the build-infra forest and needs to get moved into jdk8/build ASAP. Thanks, David On 4/01/2013 1:35 PM, David Holmes wrote: > Hi Erik, > > On 4/01/2013 12:15 AM, Erik Joelsson wrote: >> Hello, >> >> Sorry for taking so long responding to this. Here are my thoughts on it. > > Thanks for getting to it, I know you have a lot on your plate at the > moment. > >> I like the idea of defined sets of files for each type of image. The >> current Images.gmk works with excludes, because that's how it used to >> work, but I would be happy to change to an include based process. Then >> we wouldn't need to convert include lists to exclude lists. I'm not >> saying this must happen at this point though. > > It will definitely not happen at this point. :) There is simply no time > to redesign everything. I have an update in the pipeline that constrains > my changes further so that they do not affect which files are > included/excluded in a full JRE. This was needed because the existing > lists only work for linux/solaris at this point (but unsupported on > solaris) and failed to produce correct JREs on windows and OSX due to > difference in the path locations. I hope to post an updated webrev later > today, or else over the weekend. > >> I would prefer if java class generation, compilation and also class >> patching would not be happening inside CreateJars.gmk. Especially since >> they emit files into the jdk output dir. For Version.java, I would break >> it out of GensrcMisc.gmk to GensrcVersion.gmk and handle all the >> variants of Version.java there. I would do the compilation in >> CompileJavaClasses.gmk. For the patching, this would be a new concept >> and has to happen after compilation and not in the same make invocation. >> Leaving patching in images could be ok even if I would prefer not to. >> But if it stays, the output needs to be in images and not jdk. The >> drawback of all this is of course that these things will get built >> regardless of if you intend to build profiles or not, but I don't think >> they take long enough to matter. If you don't agree, then please at >> least move the output to images. > > I may have to limit this to the "at least move the output to images" - > at least for now - though I need all .class files in one place to > package them into a jar file. Given the way the build is defined to > build the world then package up jars and images based on the image > contents, I was constraining myself to only affecting those two aspects. > As you indicated to handle this in CompileJavaClasses the whole profile > notion has to propagate through the build system into areas that really > don't care about profiles or images. > >> For the images:: rule in common/makefiles/Main.gmk, do you actually need >> to add things there that don't fit better in a closed version of >> jdk/makefiles/BuildJdk.gmk? I can't find any use of it in the current >> profiles repos. > > It is used in the jdk/make/closed repo for other build targets based on > Profiles (ie the SE embedded profile images). I'm not sure how I could > move it though as if it were in a closed BuildJdk.gmk then it would need > to augment an open BuildJdk.gmk target - and hence the :: would simply > move from one place to another. If this were only for embedded it might > be doable through a new target, but there are other factors at play. > (And in many ways the :: is a much simpler way of augmenting > pre-existing targets.) > > Thanks, > David > >> >> /Erik >> >> On 2012-12-21 07:18, David Holmes wrote: >>> The Java SE 8 Compact Profiles: >>> >>> http://openjdk.java.net/jeps/161 >>> >>> provides for subsetting of the Java SE 8 platform. While the >>> specification covers the platform, we are only providing a reference >>> implementation on Linux x86 at this time. >>> >>> This work is covered by a number of CRs due to there being a need for >>> a number of CC requests to modifying existing specifications >>> >>> 8004265: Add build support for Compact Profiles >>> 8004502: Compact Profiles contents >>> 8003255: (profiles) Update JAR file specification to support profiles >>> 8003256: (profiles) Add support for profile identification >>> 8004931: add/removePropertyChangeListener should not exist in subset >>> Profiles of Java SE >>> >>> The changes primarily involve the build, as you would imagine, the >>> compact profiles define: >>> >>> - which files (binaries, jars, native libs) are in a JRE >>> (profile-includes.txt) >>> - which packages/classes are in rt.jar/resources.jar >>> (profile-rtjar-includes.txt) >>> >>> But there are additional source changes: >>> - to support reporting the profile name as part of version information >>> - to test the versioning and tool changes >>> >>> and also changes to java, javac and jar so that you can indicate which >>> profile you are targeting, and have javac make sure you don't use an >>> API that won't be present; and which profile you need to run (listed >>> in your executable jar) so the launcher can reject it if it isn't the >>> right profile. The launcher and jar changes are included in this >>> webrev, while the javac changes are being integrated separately (plus >>> some related javadoc changes). >>> >>> Only the new build system is supported for building profiles. >>> >>> webrevs: >>> >>> top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/ >>> >>> The main change is to simply add profiles and profiles-only as top >>> level make targets (similar to images). There is also a change to >>> remove the hardcoded version information (though this may be handled >>> by a separate CR). >>> >>> jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ >>> >>> The overall build changes expand on the pre-existing definitions >>> whereby a JRE is a JDK with things take out. So a compact JRE is then >>> a JRE with additional things taken out. There are three compact >>> profiles (compact1 being the smallest) and a full JRE. For internal >>> build purposes these are referred to as PROFILE_1 etc, with a full JRE >>> being represented by PROFILE_4 when needed. The specification for >>> profiles indicates what is included in each profile, but the build >>> rules then invert this to obtain a set of exclusions for each profile: >>> the exclusions of a given profile is the set of inclusions of all >>> larger profiles and the JRE (and of course the JDK). >>> >>> Please note I only expect build folks to look at build changes and >>> core-libs to look at src/test changes (all of which have been >>> developed by Alan Bateman) and there is no need to cross-post your >>> responses. >>> >>> Like many I am about to head for Xmas break but I will continue to >>> monitor email and deal with changes as needed. This is needed for M6 >>> and we need to be ready to push in early January. >>> >>> Thanks, >>> David Holmes >>> From erik.joelsson at oracle.com Tue Jan 8 11:03:21 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 08 Jan 2013 12:03:21 +0100 Subject: Review Request: 8005794: in new infra, how do we change java -version? Message-ID: <50EBFCF9.6090404@oracle.com> Adding a configure parameter --with-user-release-suffix which acts as the USER_RELEASE_SUFFIX variable used to do. If build number isn't set or is set to b00, this gets added to the full version string, overriding the default value _. It's also possible to override this variable directly (same name as before) on the make command line. The difference to the old build is that setting it in the environment isn't honored. http://cr.openjdk.java.net/~erikj/8005794/webrev.root.01/ From erik.joelsson at oracle.com Tue Jan 8 12:56:28 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 08 Jan 2013 13:56:28 +0100 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom Message-ID: <50EC177C.7000205@oracle.com> The open part of this review. Move handling of --enable-openjdk-only to before the first custom hook call. http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ From erik.joelsson at oracle.com Tue Jan 8 13:35:37 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 08 Jan 2013 14:35:37 +0100 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling Message-ID: <50EC20A9.3020604@oracle.com> Filter away -R flags from X_LIBS variable in configure. http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ From erik.joelsson at oracle.com Tue Jan 8 14:07:59 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 08 Jan 2013 15:07:59 +0100 Subject: Review Request: 8005856: build-infra: Remove special handling of base module classes header generation Message-ID: <50EC283F.1050601@oracle.com> Five classes which in jigsaw will be located in the base module currently have their native headers generated in a special way (explicitly with javah). This was because the base module could not be made dependent on the compiler module where the annotation javax.tools.annotation.GenerateNativeHeader is. Now there is a new annotation on fields, java.lang.annotation.Native, that can be used for these classes. Since this change touches java files, I'm adding core-libs to the review. Original change in build-infra was made by Fredrik Ohrstrom. http://cr.openjdk.java.net/~erikj/8005856/webrev.jdk.01/ /Erik From Alan.Bateman at oracle.com Tue Jan 8 14:17:30 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 08 Jan 2013 14:17:30 +0000 Subject: Review Request: 8005856: build-infra: Remove special handling of base module classes header generation In-Reply-To: <50EC283F.1050601@oracle.com> References: <50EC283F.1050601@oracle.com> Message-ID: <50EC2A7A.9050408@oracle.com> On 08/01/2013 14:07, Erik Joelsson wrote: > Five classes which in jigsaw will be located in the base module > currently have their native headers generated in a special way > (explicitly with javah). This was because the base module could not be > made dependent on the compiler module where the annotation > javax.tools.annotation.GenerateNativeHeader is. Now there is a new > annotation on fields, java.lang.annotation.Native, that can be used > for these classes. > > Since this change touches java files, I'm adding core-libs to the review. > > Original change in build-infra was made by Fredrik Ohrstrom. > > http://cr.openjdk.java.net/~erikj/8005856/webrev.jdk.01/ > > /Erik This looks good to me. -Alan From erik.joelsson at oracle.com Tue Jan 8 14:21:29 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 08 Jan 2013 15:21:29 +0100 Subject: Review Request: 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh Message-ID: <50EC2B69.1060309@oracle.com> When submitting JDK-8005723 to jdk8/build, I missed adding the comparisons of these files to compare.sh. The implementation was already done in build-infra. http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/ /Erik From tim.bell at oracle.com Tue Jan 8 15:48:36 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 08 Jan 2013 07:48:36 -0800 Subject: Review Request: 8005794: in new infra, how do we change java -version? In-Reply-To: <50EBFCF9.6090404@oracle.com> References: <50EBFCF9.6090404@oracle.com> Message-ID: <50EC3FD4.3090701@oracle.com> Hi Erik Joelsson: > Adding a configure parameter --with-user-release-suffix which acts as > the USER_RELEASE_SUFFIX variable used to do. If build number isn't set > or is set to b00, this gets added to the full version string, > overriding the default value _. It's also > possible to override this variable directly (same name as before) on > the make command line. The difference to the old build is that setting > it in the environment isn't honored. > > http://cr.openjdk.java.net/~erikj/8005794/webrev.root.01/ Looks good- Tim From tim.bell at oracle.com Tue Jan 8 18:41:09 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 08 Jan 2013 10:41:09 -0800 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom In-Reply-To: <50EC177C.7000205@oracle.com> References: <50EC177C.7000205@oracle.com> Message-ID: <50EC6845.7030109@oracle.com> Erik: > The open part of this review. Move handling of --enable-openjdk-only > to before the first custom hook call. > > http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ Looks good. Tim From tim.bell at oracle.com Tue Jan 8 19:02:55 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 08 Jan 2013 11:02:55 -0800 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <50EC20A9.3020604@oracle.com> References: <50EC20A9.3020604@oracle.com> Message-ID: <50EC6D5F.7000401@oracle.com> Hi Erik: > Filter away -R flags from X_LIBS variable in configure. > > http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ common/autoconf/libraries.m4: 143 X_LIBS=`$ECHO $X_LIBS | $SED 's/-R.*//g'` If I am reading this correctly, sed will delete everything from -R to end of line. Is that correct? Thumbs up if so - but this could have unexpected consequences if not. Tim From tim.bell at oracle.com Tue Jan 8 19:07:56 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 08 Jan 2013 11:07:56 -0800 Subject: Review Request: 8005856: build-infra: Remove special handling of base module classes header generation In-Reply-To: <50EC2A7A.9050408@oracle.com> References: <50EC283F.1050601@oracle.com> <50EC2A7A.9050408@oracle.com> Message-ID: <50EC6E8C.7070203@oracle.com> On 01/08/13 06:17, Alan Bateman wrote: > On 08/01/2013 14:07, Erik Joelsson wrote: >> Five classes which in jigsaw will be located in the base module >> currently have their native headers generated in a special way >> (explicitly with javah). This was because the base module could not >> be made dependent on the compiler module where the annotation >> javax.tools.annotation.GenerateNativeHeader is. Now there is a new >> annotation on fields, java.lang.annotation.Native, that can be used >> for these classes. >> >> Since this change touches java files, I'm adding core-libs to the >> review. >> >> Original change in build-infra was made by Fredrik Ohrstrom. >> >> http://cr.openjdk.java.net/~erikj/8005856/webrev.jdk.01/ >> >> /Erik > This looks good to me. > > -Alan Looks good to me as well. Tim From tim.bell at oracle.com Tue Jan 8 19:11:26 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 08 Jan 2013 11:11:26 -0800 Subject: Review Request: 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh In-Reply-To: <50EC2B69.1060309@oracle.com> References: <50EC2B69.1060309@oracle.com> Message-ID: <50EC6F5E.7010002@oracle.com> Erik: > When submitting JDK-8005723 to jdk8/build, I missed adding the > comparisons of these files to compare.sh. The implementation was > already done in build-infra. > > http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/ Looks good. Tim From kelly.ohair at oracle.com Tue Jan 8 19:49:36 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 Jan 2013 11:49:36 -0800 Subject: Review Request: 8005794: in new infra, how do we change java -version? In-Reply-To: <50EBFCF9.6090404@oracle.com> References: <50EBFCF9.6090404@oracle.com> Message-ID: <2DBFDC8A-E050-4625-9070-7117468F5181@oracle.com> Looks fine. -kto On Jan 8, 2013, at 3:03 AM, Erik Joelsson wrote: > Adding a configure parameter --with-user-release-suffix which acts as the USER_RELEASE_SUFFIX variable used to do. If build number isn't set or is set to b00, this gets added to the full version string, overriding the default value _. It's also possible to override this variable directly (same name as before) on the make command line. The difference to the old build is that setting it in the environment isn't honored. > > http://cr.openjdk.java.net/~erikj/8005794/webrev.root.01/ From kelly.ohair at oracle.com Tue Jan 8 19:50:54 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 Jan 2013 11:50:54 -0800 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom In-Reply-To: <50EC177C.7000205@oracle.com> References: <50EC177C.7000205@oracle.com> Message-ID: Looks fine. -kto On Jan 8, 2013, at 4:56 AM, Erik Joelsson wrote: > The open part of this review. Move handling of --enable-openjdk-only to before the first custom hook call. > > http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ From kelly.ohair at oracle.com Tue Jan 8 19:52:30 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 Jan 2013 11:52:30 -0800 Subject: Review Request: 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh In-Reply-To: <50EC2B69.1060309@oracle.com> References: <50EC2B69.1060309@oracle.com> Message-ID: Looks fine. -kto On Jan 8, 2013, at 6:21 AM, Erik Joelsson wrote: > When submitting JDK-8005723 to jdk8/build, I missed adding the comparisons of these files to compare.sh. The implementation was already done in build-infra. > > http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/ > > /Erik From kelly.ohair at oracle.com Tue Jan 8 19:56:03 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 Jan 2013 11:56:03 -0800 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <50EC20A9.3020604@oracle.com> References: <50EC20A9.3020604@oracle.com> Message-ID: <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> I need more info on this, what is X_LIBS for, and why remove ALL -R options. I always considered the -R options to be LD options, not library specifications really. The -L and -l options are library specifications, but -R is just a path that gets baked into the .so for runtime access to the libraries, the paths don't have to exist at build time. -kto On Jan 8, 2013, at 5:35 AM, Erik Joelsson wrote: > Filter away -R flags from X_LIBS variable in configure. > > http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ From kelly.ohair at oracle.com Tue Jan 8 19:59:04 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 Jan 2013 11:59:04 -0800 Subject: Review Request: 8005856: build-infra: Remove special handling of base module classes header generation In-Reply-To: <50EC283F.1050601@oracle.com> References: <50EC283F.1050601@oracle.com> Message-ID: <0A506F33-B14F-437E-A3B3-747A9A17D0FD@oracle.com> Looks good. -kto On Jan 8, 2013, at 6:07 AM, Erik Joelsson wrote: > Five classes which in jigsaw will be located in the base module currently have their native headers generated in a special way (explicitly with javah). This was because the base module could not be made dependent on the compiler module where the annotation javax.tools.annotation.GenerateNativeHeader is. Now there is a new annotation on fields, java.lang.annotation.Native, that can be used for these classes. > > Since this change touches java files, I'm adding core-libs to the review. > > Original change in build-infra was made by Fredrik Ohrstrom. > > http://cr.openjdk.java.net/~erikj/8005856/webrev.jdk.01/ > > /Erik From david.katleman at oracle.com Tue Jan 8 21:24:36 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:24:36 +0000 Subject: hg: jdk8/build/corba: 2 new changesets Message-ID: <20130108212437.E629647111@hg.openjdk.java.net> Changeset: 8171d23e914d Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/8171d23e914d Added tag jdk8-b70 for changeset 603cceb495c8 ! .hgtags Changeset: cb40427f4714 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/cb40427f4714 Added tag jdk8-b71 for changeset 8171d23e914d ! .hgtags From david.katleman at oracle.com Tue Jan 8 21:24:33 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:24:33 +0000 Subject: hg: jdk8/build: 7 new changesets Message-ID: <20130108212433.7B17947110@hg.openjdk.java.net> Changeset: 3fb32a5a2388 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/3fb32a5a2388 Added tag jdk8-b70 for changeset 105a25ffa4a4 ! .hgtags Changeset: 2ed5be3dd506 Author: lana Date: 2012-12-16 22:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/2ed5be3dd506 Merge Changeset: a0779b1e9a4d Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/a0779b1e9a4d 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk Changeset: 68a81db3ceb1 Author: lana Date: 2012-12-18 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/68a81db3ceb1 Merge Changeset: 51ad2a343420 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/51ad2a343420 Merge Changeset: c1be681d80a1 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/c1be681d80a1 Added tag jdk8-b71 for changeset 51ad2a343420 ! .hgtags Changeset: 64a9ebad39fe Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/64a9ebad39fe Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers From david.katleman at oracle.com Tue Jan 8 21:27:15 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:27:15 +0000 Subject: hg: jdk8/build/jaxp: 8 new changesets Message-ID: <20130108212734.E6E7E47113@hg.openjdk.java.net> Changeset: 63815efd132f Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/63815efd132f Added tag jdk8-b70 for changeset 6ec9edffc286 ! .hgtags Changeset: b1fdb101c82e Author: joehw Date: 2012-12-14 13:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/b1fdb101c82e 8003260: [findbug] some fields should be package protected Summary: change public or protected mutable static fields to private or package private. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 8a20e948b806 Author: lana Date: 2012-12-16 22:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/8a20e948b806 Merge Changeset: 15b32367b23c Author: joehw Date: 2012-12-18 21:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/15b32367b23c 8003261: static field is public but not final Summary: add final to fVersion field, and make it a non-compile time constant. Reviewed-by: hawtin, lancea, dholmes, chegar ! src/com/sun/org/apache/xerces/internal/impl/Version.java Changeset: d4aea0225e80 Author: joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 499be952a291 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/499be952a291 Merge Changeset: bdf2af722a6b Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/bdf2af722a6b Added tag jdk8-b71 for changeset 499be952a291 ! .hgtags Changeset: 2e4d87e6662e Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/2e4d87e6662e Merge From david.katleman at oracle.com Tue Jan 8 21:26:12 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:26:12 +0000 Subject: hg: jdk8/build/hotspot: 2 new changesets Message-ID: <20130108212616.8325F47112@hg.openjdk.java.net> Changeset: 0847210f8548 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0847210f8548 Added tag jdk8-b70 for changeset e94068d4ff52 ! .hgtags Changeset: d5cb5830f570 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d5cb5830f570 Added tag jdk8-b71 for changeset 0847210f8548 ! .hgtags From david.katleman at oracle.com Tue Jan 8 21:27:39 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:27:39 +0000 Subject: hg: jdk8/build/jaxws: 3 new changesets Message-ID: <20130108212745.BF5BB47114@hg.openjdk.java.net> Changeset: f577a39c9fb3 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f577a39c9fb3 Added tag jdk8-b70 for changeset 3b1c2733d47e ! .hgtags Changeset: d9707230294d Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/d9707230294d Added tag jdk8-b71 for changeset f577a39c9fb3 ! .hgtags Changeset: dd7473082690 Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/dd7473082690 Merge From david.katleman at oracle.com Tue Jan 8 21:29:28 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:29:28 +0000 Subject: hg: jdk8/build/jdk: 55 new changesets Message-ID: <20130108213948.33C6747115@hg.openjdk.java.net> Changeset: 8d7651351cfe Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8d7651351cfe Added tag jdk8-b70 for changeset a996b57e5541 ! .hgtags Changeset: a988c23b8553 Author: jgodinez Date: 2012-12-20 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a988c23b8553 7180359: Assertion in awt_Win32GraphicsDevice.cpp when running specjbb in jprt Reviewed-by: bae, prr ! src/windows/native/sun/windows/awt_Debug.cpp Changeset: 2cf07dbdee64 Author: bae Date: 2012-12-24 14:03 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2cf07dbdee64 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244,244,0 Reviewed-by: prr ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c + test/sun/java2d/cmm/ColorConvertOp/GrayTest.java Changeset: 3c1c0b7abe51 Author: bae Date: 2012-12-24 14:22 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c1c0b7abe51 8005402: Need to provide benchmarks for color management Reviewed-by: jgodinez, prr ! src/share/demo/java2d/J2DBench/build.xml ! src/share/demo/java2d/J2DBench/src/j2dbench/J2DBench.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/CMMTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConvertOpTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/DataConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ProfileTests.java Changeset: 1316d6d0900e Author: lana Date: 2012-12-28 18:28 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1316d6d0900e Merge Changeset: c25ea633b4de Author: malenkov Date: 2012-12-17 16:58 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c25ea633b4de 8005065: [findbugs] reference to mutable array in JavaBeans Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/Statement.java + test/java/beans/Introspector/Test8005065.java Changeset: a78cb3c5d434 Author: neugens Date: 2012-12-17 17:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a78cb3c5d434 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list Summary: Don't consider extraenous bits when checking button mask, so that grabWindowRef on the window is not confused and released correctly Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java Changeset: 985b523712c8 Author: kshefov Date: 2012-12-18 15:17 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/985b523712c8 7104594: [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default Reviewed-by: yan, alexsch + test/javax/swing/JFrame/4962534/bug4962534.html + test/javax/swing/JFrame/4962534/bug4962534.java Changeset: 90ad9e922042 Author: lana Date: 2012-12-18 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/90ad9e922042 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: 7082a96c02d2 Author: alexp Date: 2012-12-21 19:11 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7082a96c02d2 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx Reviewed-by: anthony, alexsch ! test/javax/swing/AncestorNotifier/7193219/bug7193219.java Changeset: 14269f504837 Author: dcherepanov Date: 2012-12-27 16:08 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/14269f504837 8001161: mac: EmbeddedFrame doesn't become active window Reviewed-by: ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: cf2bcb293f0b Author: lana Date: 2012-12-28 18:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf2bcb293f0b Merge Changeset: 69fd3f3d20c1 Author: alanb Date: 2012-12-15 15:07 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/69fd3f3d20c1 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Reviewed-by: chegar ! src/share/classes/java/net/URLConnection.java Changeset: eaaec81aa974 Author: weijun Date: 2012-12-17 12:18 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eaaec81aa974 7197159: accept different kvno if there no match Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java + test/sun/security/krb5/auto/KvnoNA.java ! test/sun/security/krb5/auto/MoreKvno.java Changeset: f959e0cc8766 Author: lana Date: 2012-12-16 22:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f959e0cc8766 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: a02212de8db6 Author: uta Date: 2012-12-17 14:34 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a02212de8db6 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung ! test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java ! test/java/lang/Throwable/LegacyChainedExceptionSerialization.java ! test/java/lang/management/CompilationMXBean/Basic.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/util/Collections/EmptyIterator.java ! test/java/util/logging/LoggingDeadlock4.java ! test/sun/tools/jrunscript/common.sh Changeset: e4d88a7352c6 Author: mullan Date: 2012-12-17 08:28 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e4d88a7352c6 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Reviewed-by: alanb, weijun ! src/share/classes/javax/security/auth/kerberos/package.html Changeset: 4a21f818ebb1 Author: mullan Date: 2012-12-17 08:30 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a21f818ebb1 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: bcf79e6f52a0 Author: chegar Date: 2012-12-17 16:27 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bcf79e6f52a0 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Reviewed-by: alanb ! test/java/util/prefs/PrefsSpi.sh Changeset: 9f1b516cd9cb Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9f1b516cd9cb 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! make/docs/NON_CORE_PKGS.gmk Changeset: bac477d67867 Author: jjg Date: 2012-12-17 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bac477d67867 8004832: Add new doclint package Reviewed-by: erikj, ohair ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! makefiles/CreateJars.gmk Changeset: 0fabdf676395 Author: martin Date: 2012-12-17 18:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0fabdf676395 8004863: Infinite Loop in KeepAliveStream Reviewed-by: chegar ! src/share/classes/sun/net/www/http/KeepAliveStream.java + test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java Changeset: 0a1398021c7c Author: darcy Date: 2012-12-18 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0a1398021c7c 8005042: Add Method.isDefault to core reflection Reviewed-by: alanb, forax, mduigou, jgish, mchung ! src/share/classes/java/lang/reflect/Method.java + test/java/lang/reflect/Method/IsDefaultTest.java Changeset: 6d977f61af5e Author: darcy Date: 2012-12-18 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Reviewed-by: darcy, dholmes Contributed-by: joel.franck at oracle.com ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java Changeset: e515956879cd Author: lana Date: 2012-12-18 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e515956879cd Merge Changeset: c79b26b8efe0 Author: sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a java test 3) some shell commands were not supported in some Solaris machines. Reviewed-by: dsamersoff, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java Changeset: b600d490dc57 Author: dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java Changeset: e43f90d5af11 Author: dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expect UnmarshalException Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java Changeset: 3f014bc09297 Author: dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is CONNECTED Reviewed-by: sjiang Contributed-by: jaroslav.bachorik at oracle.com ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: d01a810798e0 Author: dl Date: 2012-12-20 13:44 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d01a810798e0 8002356: Add ForkJoin common pool and CountedCompleter Reviewed-by: chegar, mduigou ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java Changeset: 31d2f9995d6c Author: chegar Date: 2012-12-20 15:04 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/31d2f9995d6c 8005306: Redundant cast warning in KeepAliveStream.java Reviewed-by: alanb ! src/share/classes/sun/net/www/http/KeepAliveStream.java Changeset: c1a55ee9618e Author: dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaroslav.bachorik at oracle.com + test/com/sun/jmx/remote/CCAdminReconnectTest.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh + test/javax/management/MBeanInfo/SerializationTest1.java Changeset: edb71a37fcb7 Author: alanb Date: 2012-12-20 20:29 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/edb71a37fcb7 8001048: JSR-160: Allow IIOP transport to be optional Reviewed-by: dsamersoff, dfuchs, mchung ! src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/package.html ! test/javax/management/remote/mandatory/connection/AddressableTest.java ! test/javax/management/remote/mandatory/connection/CloseableTest.java ! test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java ! test/javax/management/remote/mandatory/connection/IIOPURLTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java Changeset: eeda18683ddc Author: alanb Date: 2012-12-20 20:40 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eeda18683ddc 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Reviewed-by: mchung ! src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java + test/java/util/Properties/ConcurrentLoadAndStoreXML.java Changeset: 60adb69bf043 Author: smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java Changeset: 42ee6b6ad373 Author: jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call gotIOException((IOException)e) instead of restart((IOException)e) when detecting a communication error, because the method gotIOException will send a failure notification if necessary. Reviewed-by: emcmanus, sjiang Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: 86c10d1484e9 Author: sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: c1227b872a12 Author: joehw Date: 2012-12-21 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c1227b872a12 8005280: (props) Improve test coverage for small XML parser Summary: added a few more invalid XML files, international characters to LoadAndStore test, and a behavior compatibility test. Reviewed-by: alanb, lancea + test/java/util/Properties/Compatibility.xml + test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadDocType.xml - test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/DTDRootNotMatch.xml + test/java/util/Properties/invalidxml/IllegalComment.xml + test/java/util/Properties/invalidxml/IllegalEntry.xml + test/java/util/Properties/invalidxml/IllegalEntry1.xml + test/java/util/Properties/invalidxml/IllegalKeyAttribute.xml + test/java/util/Properties/invalidxml/NoDocType.xml - test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoNamespaceSupport.xml Changeset: 4d28776d7007 Author: mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java Changeset: d9cab18f326a Author: mullan Date: 2012-12-26 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d9cab18f326a Merge - make/jdk/asm/Makefile Changeset: 9d984ccd17fc Author: chegar Date: 2012-12-27 21:55 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: david.holmes at oracle.com, dl at cs.oswego.edu, chris.hegarty at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Arrays.java + src/share/classes/java/util/ArraysParallelSortHelpers.java + test/java/util/Arrays/ParallelSorting.java Changeset: 4ad38db38fff Author: okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/TimeZone/CLDRDisplayNamesTest.java Changeset: 1da019e7999a Author: peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConformance.java + test/java/text/Bidi/Bug8005277.java Changeset: f3ac419e2bf0 Author: okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java Changeset: 645d774b683a Author: xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms". This will impact providers that adhere to this security property. Reviewed-by: mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java ! test/java/security/cert/pkix/policyChanges/TestPolicy.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java + test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh Changeset: 4472a641b4dc Author: xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: 46675076f753 Author: sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy of listener set to do iterate. Reviewed-by: alanb ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! test/ProblemList.txt + test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java Changeset: 0cfcba56cfa7 Author: jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: ac5e29b62288 Author: smarks Date: 2012-12-28 17:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac5e29b62288 Merge Changeset: 2a5af0f766d0 Author: lana Date: 2012-12-28 18:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2a5af0f766d0 Merge - make/jdk/asm/Makefile ! makefiles/CreateJars.gmk ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 32a57e645e01 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/32a57e645e01 Added tag jdk8-b71 for changeset 2a5af0f766d0 ! .hgtags Changeset: 244e481f538b Author: katleman Date: 2013-01-08 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/244e481f538b Merge ! makefiles/CreateJars.gmk From david.katleman at oracle.com Tue Jan 8 21:42:46 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 08 Jan 2013 21:42:46 +0000 Subject: hg: jdk8/build/langtools: 21 new changesets Message-ID: <20130108214337.1527C47117@hg.openjdk.java.net> Changeset: 7d5032c2d747 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7d5032c2d747 Added tag jdk8-b70 for changeset 47f71d7c124f ! .hgtags Changeset: 37a5d7eccb87 Author: vromero Date: 2012-12-14 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/37a5d7eccb87 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Reviewed-by: jjg, mcimadamore ! test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java Changeset: de1ec6fc93fe Author: vromero Date: 2012-12-15 13:54 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/de1ec6fc93fe 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + test/tools/javac/8000518/DuplicateConstantPoolEntry.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: f72dc656a306 Author: lana Date: 2012-12-16 22:10 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f72dc656a306 Merge Changeset: 02a18f209ab3 Author: vromero Date: 2012-12-17 14:54 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/02a18f209ab3 8004814: javadoc should be able to detect default methods Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/javadoc/MethodDoc.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java Changeset: 75ab654b5cd5 Author: jjg Date: 2012-12-17 07:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/75ab654b5cd5 8004832: Add new doclint package Reviewed-by: mcimadamore ! make/build.properties ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TreePath.java + src/share/classes/com/sun/tools/doclint/Checker.java + src/share/classes/com/sun/tools/doclint/DocLint.java + src/share/classes/com/sun/tools/doclint/Entity.java + src/share/classes/com/sun/tools/doclint/Env.java + src/share/classes/com/sun/tools/doclint/HtmlTag.java + src/share/classes/com/sun/tools/doclint/Messages.java + src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocPretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/doclint/AccessTest.java + test/tools/doclint/AccessTest.package.out + test/tools/doclint/AccessTest.private.out + test/tools/doclint/AccessTest.protected.out + test/tools/doclint/AccessTest.public.out + test/tools/doclint/AccessibilityTest.java + test/tools/doclint/AccessibilityTest.out + test/tools/doclint/DocLintTester.java + test/tools/doclint/EmptyAuthorTest.java + test/tools/doclint/EmptyAuthorTest.out + test/tools/doclint/EmptyExceptionTest.java + test/tools/doclint/EmptyExceptionTest.out + test/tools/doclint/EmptyParamTest.java + test/tools/doclint/EmptyParamTest.out + test/tools/doclint/EmptyReturnTest.java + test/tools/doclint/EmptyReturnTest.out + test/tools/doclint/EmptySerialDataTest.java + test/tools/doclint/EmptySerialDataTest.out + test/tools/doclint/EmptySerialFieldTest.java + test/tools/doclint/EmptySerialFieldTest.out + test/tools/doclint/EmptySinceTest.java + test/tools/doclint/EmptySinceTest.out + test/tools/doclint/EmptyVersionTest.java + test/tools/doclint/EmptyVersionTest.out + test/tools/doclint/HtmlAttrsTest.java + test/tools/doclint/HtmlAttrsTest.out + test/tools/doclint/HtmlTagsTest.java + test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/MissingCommentTest.java + test/tools/doclint/MissingCommentTest.out + test/tools/doclint/MissingParamsTest.java + test/tools/doclint/MissingParamsTest.out + test/tools/doclint/MissingReturnTest.java + test/tools/doclint/MissingReturnTest.out + test/tools/doclint/MissingThrowsTest.java + test/tools/doclint/MissingThrowsTest.out + test/tools/doclint/OptionTest.java + test/tools/doclint/OverridesTest.java + test/tools/doclint/ReferenceTest.java + test/tools/doclint/ReferenceTest.out + test/tools/doclint/RunTest.java + test/tools/doclint/SyntaxTest.java + test/tools/doclint/SyntaxTest.out + test/tools/doclint/SyntheticTest.java + test/tools/doclint/ValidTest.java + test/tools/doclint/tidy/AnchorAlreadyDefined.java + test/tools/doclint/tidy/AnchorAlreadyDefined.out + test/tools/doclint/tidy/BadEnd.java + test/tools/doclint/tidy/BadEnd.out + test/tools/doclint/tidy/InsertImplicit.java + test/tools/doclint/tidy/InsertImplicit.out + test/tools/doclint/tidy/InvalidEntity.java + test/tools/doclint/tidy/InvalidEntity.out + test/tools/doclint/tidy/InvalidName.java + test/tools/doclint/tidy/InvalidName.out + test/tools/doclint/tidy/InvalidTag.java + test/tools/doclint/tidy/InvalidTag.out + test/tools/doclint/tidy/InvalidURI.java + test/tools/doclint/tidy/InvalidURI.out + test/tools/doclint/tidy/MissingGT.java + test/tools/doclint/tidy/MissingGT.out + test/tools/doclint/tidy/MissingTag.java + test/tools/doclint/tidy/MissingTag.out + test/tools/doclint/tidy/NestedTag.java + test/tools/doclint/tidy/NestedTag.out + test/tools/doclint/tidy/ParaInPre.java + test/tools/doclint/tidy/ParaInPre.out + test/tools/doclint/tidy/README.txt + test/tools/doclint/tidy/RepeatedAttr.java + test/tools/doclint/tidy/RepeatedAttr.out + test/tools/doclint/tidy/TextNotAllowed.java + test/tools/doclint/tidy/TextNotAllowed.out + test/tools/doclint/tidy/TrimmingEmptyTag.java + test/tools/doclint/tidy/TrimmingEmptyTag.out + test/tools/doclint/tidy/UnescapedOrUnknownEntity.java + test/tools/doclint/tidy/UnescapedOrUnknownEntity.out + test/tools/doclint/tidy/util/Main.java + test/tools/doclint/tidy/util/tidy.sh + test/tools/javac/diags/examples/NoContent.java Changeset: f20568328a57 Author: mcimadamore Date: 2012-12-17 16:13 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use methodArguments to correctly format actuals Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/BadMethodCall2.java + test/tools/javac/lambda/BadMethodCall2.out Changeset: 064e372f273d Author: jjg Date: 2012-12-17 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/064e372f273d 8004961: rename Plugin.call to Plugin.init Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/plugin/showtype/ShowTypePlugin.java ! test/tools/javac/plugin/showtype/Test.java Changeset: ef537bcc825a Author: mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.java Changeset: bc74006c2d8d Author: darcy Date: 2012-12-18 00:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bc74006c2d8d 8005046: Provide checking for a default method in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java + test/tools/javac/processing/model/element/TestExecutableElement.java Changeset: 92fcf299cd09 Author: ohrstrom Date: 2012-12-18 10:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/92fcf299cd09 8004657: Add hooks to javac to enable reporting dependency information. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 250f0acf880c Author: mcimadamore Date: 2012-12-18 22:16 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! test/tools/javac/lambda/BadMethodCall2.out Changeset: 573b38691a74 Author: lana Date: 2012-12-18 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/573b38691a74 Merge Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java Changeset: a22f23fb7abf Author: jjg Date: 2012-12-20 17:59 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a22f23fb7abf 8005307: fix missing @bug tags Reviewed-by: jjh ! test/tools/doclint/AccessTest.java ! test/tools/doclint/AccessTest.package.out ! test/tools/doclint/AccessTest.private.out ! test/tools/doclint/AccessTest.protected.out ! test/tools/doclint/AccessTest.public.out ! test/tools/doclint/AccessibilityTest.java ! test/tools/doclint/AccessibilityTest.out ! test/tools/doclint/EmptyAuthorTest.java ! test/tools/doclint/EmptyAuthorTest.out ! test/tools/doclint/EmptyExceptionTest.java ! test/tools/doclint/EmptyExceptionTest.out ! test/tools/doclint/EmptyParamTest.java ! test/tools/doclint/EmptyParamTest.out ! test/tools/doclint/EmptyReturnTest.java ! test/tools/doclint/EmptyReturnTest.out ! test/tools/doclint/EmptySerialDataTest.java ! test/tools/doclint/EmptySerialDataTest.out ! test/tools/doclint/EmptySerialFieldTest.java ! test/tools/doclint/EmptySerialFieldTest.out ! test/tools/doclint/EmptySinceTest.java ! test/tools/doclint/EmptySinceTest.out ! test/tools/doclint/EmptyVersionTest.java ! test/tools/doclint/EmptyVersionTest.out ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out ! test/tools/doclint/MissingParamsTest.java ! test/tools/doclint/MissingParamsTest.out ! test/tools/doclint/MissingReturnTest.java ! test/tools/doclint/MissingReturnTest.out ! test/tools/doclint/MissingThrowsTest.java ! test/tools/doclint/MissingThrowsTest.out ! test/tools/doclint/OptionTest.java ! test/tools/doclint/OverridesTest.java ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out ! test/tools/doclint/RunTest.java ! test/tools/doclint/SyntaxTest.java ! test/tools/doclint/SyntaxTest.out ! test/tools/doclint/SyntheticTest.java ! test/tools/doclint/ValidTest.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/tools/doclint/tidy/BadEnd.java ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/InsertImplicit.java ! test/tools/doclint/tidy/InsertImplicit.out ! test/tools/doclint/tidy/InvalidEntity.java ! test/tools/doclint/tidy/InvalidEntity.out ! test/tools/doclint/tidy/InvalidName.java ! test/tools/doclint/tidy/InvalidName.out ! test/tools/doclint/tidy/InvalidTag.java ! test/tools/doclint/tidy/InvalidTag.out ! test/tools/doclint/tidy/InvalidURI.java ! test/tools/doclint/tidy/InvalidURI.out ! test/tools/doclint/tidy/MissingGT.java ! test/tools/doclint/tidy/MissingGT.out ! test/tools/doclint/tidy/MissingTag.java ! test/tools/doclint/tidy/MissingTag.out ! test/tools/doclint/tidy/NestedTag.java ! test/tools/doclint/tidy/NestedTag.out ! test/tools/doclint/tidy/ParaInPre.java ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/RepeatedAttr.java ! test/tools/doclint/tidy/RepeatedAttr.out ! test/tools/doclint/tidy/TextNotAllowed.java ! test/tools/doclint/tidy/TextNotAllowed.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.java ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.out Changeset: b52a38d4536c Author: darcy Date: 2012-12-21 08:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b52a38d4536c 8005282: Use @library tag with non-relative path for javac tests Reviewed-by: jjg ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/classreader/T7031108.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/file/T7018098.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/options/T7022337.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6359313/T6359313.java ! test/tools/javac/processing/6365040/T6365040.java ! test/tools/javac/processing/6413690/T6413690.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6499119/ClassProcessor.java ! test/tools/javac/processing/6511613/clss41701.java ! test/tools/javac/processing/6512707/T6512707.java ! test/tools/javac/processing/6634138/T6634138.java ! test/tools/javac/processing/6994946/SemanticErrorTest.java ! test/tools/javac/processing/6994946/SyntaxErrorTest.java ! test/tools/javac/processing/T6920317.java ! test/tools/javac/processing/T7196462.java ! test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/processing/environment/round/TestContext.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/tools/javac/processing/errors/TestErrorCount.java ! test/tools/javac/processing/errors/TestFatalityOfParseErrors.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/processing/filer/TestFilerConstraints.java ! test/tools/javac/processing/filer/TestGetResource.java ! test/tools/javac/processing/filer/TestGetResource2.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestLastRound.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/messager/MessagerBasics.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/6341534/T6341534.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/element/TestNames.java ! test/tools/javac/processing/model/element/TestPackageElement.java ! test/tools/javac/processing/model/element/TestResourceElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/element/TestTypeParameter.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/BinaryName.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/NoSupers.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java ! test/tools/javac/processing/model/util/TypesBadArg.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java ! test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java ! test/tools/javac/processing/model/util/elements/TestGetPackageOf.java ! test/tools/javac/processing/model/util/filter/TestIterables.java ! test/tools/javac/processing/options/testCommandLineClasses/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java ! test/tools/javac/processing/werror/WError1.java ! test/tools/javac/processing/werror/WErrorGen.java ! test/tools/javac/processing/werror/WErrorLast.java ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/util/T6597678.java ! test/tools/javac/util/context/T7021650.java Changeset: 189b26e3818f Author: vromero Date: 2012-12-21 15:27 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/189b26e3818f 8003512: javac doesn't work with jar files with >64k entries Reviewed-by: jjg, ksrini Contributed-by: martinrb at google.com ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + test/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java ! test/tools/javac/file/zip/Utils.java Changeset: 690c41cdab55 Author: bpatel Date: 2012-12-25 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/690c41cdab55 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg/A.java + test/com/sun/javadoc/testLambdaFeature/pkg/B.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java Changeset: 467e4d9281bc Author: lana Date: 2012-12-28 18:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/467e4d9281bc Merge ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 6f0986ed9b7e Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6f0986ed9b7e Added tag jdk8-b71 for changeset 467e4d9281bc ! .hgtags From Kelly.Ohair at oracle.com Tue Jan 8 22:23:53 2013 From: Kelly.Ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 Jan 2013 14:23:53 -0800 Subject: Request for Review: Java SE 8 Compact Profiles In-Reply-To: <50EBD28D.5020409@oracle.com> References: <50D3FF29.6010005@oracle.com> <50E59291.3080305@oracle.com> <50E64DF1.8060004@oracle.com> <50EBD28D.5020409@oracle.com> Message-ID: On Jan 8, 2013, at 12:02 AM, David Holmes wrote: > I have updated webrevs: > > http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/ > > http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/ They look ok to me. > > I've addressed the minor suggestions that have been given by Kelly and Erik eg: > - better comment on the jarreorder change (and a CR to follow up) > - the de-beaned classes now go to the images output directory not JDK (thanks to Alan) > > The major change is that I no longer use the profiles files to define the contents of a full JRE. So the file lists that had moved to Profiles.gmk have moved back to Images.gmk and are not used when creating a profile image. This means that the only change for non-profiles builds (outside the Version.java modifications) is in how the list of JARS to build is put together. > > I've also integrated this with latest jdk8/build changes including all the UNSIGNED jar updates - which fit in quite nicely. > > One thing to note that I didn't mention originally, the change to makefiles/GensrcX11Wrappers.gmk is a hack to make cross-compilation work. The real fix is languishing in the build-infra forest and needs to get moved into jdk8/build ASAP. Is this the Issue: JDK-8003958 build-infra: Cross-compilation of sizers utility has been broken ??? -kto > > Thanks, > David > > On 4/01/2013 1:35 PM, David Holmes wrote: >> Hi Erik, >> >> On 4/01/2013 12:15 AM, Erik Joelsson wrote: >>> Hello, >>> >>> Sorry for taking so long responding to this. Here are my thoughts on it. >> >> Thanks for getting to it, I know you have a lot on your plate at the >> moment. >> >>> I like the idea of defined sets of files for each type of image. The >>> current Images.gmk works with excludes, because that's how it used to >>> work, but I would be happy to change to an include based process. Then >>> we wouldn't need to convert include lists to exclude lists. I'm not >>> saying this must happen at this point though. >> >> It will definitely not happen at this point. :) There is simply no time >> to redesign everything. I have an update in the pipeline that constrains >> my changes further so that they do not affect which files are >> included/excluded in a full JRE. This was needed because the existing >> lists only work for linux/solaris at this point (but unsupported on >> solaris) and failed to produce correct JREs on windows and OSX due to >> difference in the path locations. I hope to post an updated webrev later >> today, or else over the weekend. >> >>> I would prefer if java class generation, compilation and also class >>> patching would not be happening inside CreateJars.gmk. Especially since >>> they emit files into the jdk output dir. For Version.java, I would break >>> it out of GensrcMisc.gmk to GensrcVersion.gmk and handle all the >>> variants of Version.java there. I would do the compilation in >>> CompileJavaClasses.gmk. For the patching, this would be a new concept >>> and has to happen after compilation and not in the same make invocation. >>> Leaving patching in images could be ok even if I would prefer not to. >>> But if it stays, the output needs to be in images and not jdk. The >>> drawback of all this is of course that these things will get built >>> regardless of if you intend to build profiles or not, but I don't think >>> they take long enough to matter. If you don't agree, then please at >>> least move the output to images. >> >> I may have to limit this to the "at least move the output to images" - >> at least for now - though I need all .class files in one place to >> package them into a jar file. Given the way the build is defined to >> build the world then package up jars and images based on the image >> contents, I was constraining myself to only affecting those two aspects. >> As you indicated to handle this in CompileJavaClasses the whole profile >> notion has to propagate through the build system into areas that really >> don't care about profiles or images. >> >>> For the images:: rule in common/makefiles/Main.gmk, do you actually need >>> to add things there that don't fit better in a closed version of >>> jdk/makefiles/BuildJdk.gmk? I can't find any use of it in the current >>> profiles repos. >> >> It is used in the jdk/make/closed repo for other build targets based on >> Profiles (ie the SE embedded profile images). I'm not sure how I could >> move it though as if it were in a closed BuildJdk.gmk then it would need >> to augment an open BuildJdk.gmk target - and hence the :: would simply >> move from one place to another. If this were only for embedded it might >> be doable through a new target, but there are other factors at play. >> (And in many ways the :: is a much simpler way of augmenting >> pre-existing targets.) >> >> Thanks, >> David >> >>> >>> /Erik >>> >>> On 2012-12-21 07:18, David Holmes wrote: >>>> The Java SE 8 Compact Profiles: >>>> >>>> http://openjdk.java.net/jeps/161 >>>> >>>> provides for subsetting of the Java SE 8 platform. While the >>>> specification covers the platform, we are only providing a reference >>>> implementation on Linux x86 at this time. >>>> >>>> This work is covered by a number of CRs due to there being a need for >>>> a number of CC requests to modifying existing specifications >>>> >>>> 8004265: Add build support for Compact Profiles >>>> 8004502: Compact Profiles contents >>>> 8003255: (profiles) Update JAR file specification to support profiles >>>> 8003256: (profiles) Add support for profile identification >>>> 8004931: add/removePropertyChangeListener should not exist in subset >>>> Profiles of Java SE >>>> >>>> The changes primarily involve the build, as you would imagine, the >>>> compact profiles define: >>>> >>>> - which files (binaries, jars, native libs) are in a JRE >>>> (profile-includes.txt) >>>> - which packages/classes are in rt.jar/resources.jar >>>> (profile-rtjar-includes.txt) >>>> >>>> But there are additional source changes: >>>> - to support reporting the profile name as part of version information >>>> - to test the versioning and tool changes >>>> >>>> and also changes to java, javac and jar so that you can indicate which >>>> profile you are targeting, and have javac make sure you don't use an >>>> API that won't be present; and which profile you need to run (listed >>>> in your executable jar) so the launcher can reject it if it isn't the >>>> right profile. The launcher and jar changes are included in this >>>> webrev, while the javac changes are being integrated separately (plus >>>> some related javadoc changes). >>>> >>>> Only the new build system is supported for building profiles. >>>> >>>> webrevs: >>>> >>>> top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/ >>>> >>>> The main change is to simply add profiles and profiles-only as top >>>> level make targets (similar to images). There is also a change to >>>> remove the hardcoded version information (though this may be handled >>>> by a separate CR). >>>> >>>> jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ >>>> >>>> The overall build changes expand on the pre-existing definitions >>>> whereby a JRE is a JDK with things take out. So a compact JRE is then >>>> a JRE with additional things taken out. There are three compact >>>> profiles (compact1 being the smallest) and a full JRE. For internal >>>> build purposes these are referred to as PROFILE_1 etc, with a full JRE >>>> being represented by PROFILE_4 when needed. The specification for >>>> profiles indicates what is included in each profile, but the build >>>> rules then invert this to obtain a set of exclusions for each profile: >>>> the exclusions of a given profile is the set of inclusions of all >>>> larger profiles and the JRE (and of course the JDK). >>>> >>>> Please note I only expect build folks to look at build changes and >>>> core-libs to look at src/test changes (all of which have been >>>> developed by Alan Bateman) and there is no need to cross-post your >>>> responses. >>>> >>>> Like many I am about to head for Xmas break but I will continue to >>>> monitor email and deal with changes as needed. This is needed for M6 >>>> and we need to be ready to push in early January. >>>> >>>> Thanks, >>>> David Holmes >>>> From tim.bell at oracle.com Wed Jan 9 00:25:53 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 09 Jan 2013 00:25:53 +0000 Subject: hg: jdk8/build: 8005794: in new infra, how do we change java -version? Message-ID: <20130109002554.25A554711E@hg.openjdk.java.net> Changeset: b284980b7d9a Author: tbell Date: 2013-01-08 16:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/b284980b7d9a 8005794: in new infra, how do we change java -version? Summary: Added configure parameter --with-user-release-suffix Reviewed-by: ohair, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 From david.holmes at oracle.com Wed Jan 9 02:44:23 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 09 Jan 2013 12:44:23 +1000 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom In-Reply-To: <50EC177C.7000205@oracle.com> References: <50EC177C.7000205@oracle.com> Message-ID: <50ECD987.80102@oracle.com> On 8/01/2013 10:56 PM, Erik Joelsson wrote: > The open part of this review. Move handling of --enable-openjdk-only to > before the first custom hook call. > > http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ Minor nit: SUPPRESS has two P's :) One concern I have with this is that we keep conflating custom and closed. The OpenJDK build system provides a facility whereby the user can augment it with custom build files - both at the configure level and makefile level. The customizations that Oracle builds include are what we refer to as "closed" and generally involve additional "closed" repositories in the forest. In that regard to me --enable-openjdk-only was actually a closed addition only needed for Oracle closed builds, as a convenience to say "yes I have a full forest of open and closed parts but ignore the closed parts and do me an openjdk build". Magnus argued that any build with customizations is not an OpenJDK build. But if you follow that line then --enable-openjdk-only should disable all use of customizations. What we have now seems to switch back and forth between custom and closed. Something to clean up at a later time. Thanks, David From david.holmes at oracle.com Wed Jan 9 02:56:47 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 09 Jan 2013 12:56:47 +1000 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> References: <50EC20A9.3020604@oracle.com> <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> Message-ID: <50ECDC6F.7010602@oracle.com> On 9/01/2013 5:56 AM, Kelly O'Hair wrote: > I need more info on this, what is X_LIBS for, and why remove ALL -R options. IIRC Fredrik added this to deal with some binary difference detected on OSX. I don't know what these variables actually contain > I always considered the -R options to be LD options, not library specifications really. > The -L and -l options are library specifications, but -R is just a path that gets baked into the .so > for runtime access to the libraries, the paths don't have to exist at build time. The paths that get baked in at build time may not exist at runtime. Also for cross-compilation the -R option is not recognized - which is what https://jbs.oracle.com/bugs/browse/JDK-8003958 build-infra: Cross-compilation of sizers utility has been broken is all about. So these two bugs seems to be overlapping somewhat - but the real fix is 8003958. David ----- > -kto > > On Jan 8, 2013, at 5:35 AM, Erik Joelsson wrote: > >> Filter away -R flags from X_LIBS variable in configure. >> >> http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ > From david.holmes at oracle.com Wed Jan 9 03:06:24 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 09 Jan 2013 13:06:24 +1000 Subject: Request for Review: Java SE 8 Compact Profiles In-Reply-To: References: <50D3FF29.6010005@oracle.com> <50E59291.3080305@oracle.com> <50E64DF1.8060004@oracle.com> <50EBD28D.5020409@oracle.com> Message-ID: <50ECDEB0.9070006@oracle.com> On 9/01/2013 8:23 AM, Kelly O'Hair wrote: > > On Jan 8, 2013, at 12:02 AM, David Holmes wrote: > >> I have updated webrevs: >> >> http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/ >> >> http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/ > > They look ok to me. Thanks. >> >> I've addressed the minor suggestions that have been given by Kelly and Erik eg: >> - better comment on the jarreorder change (and a CR to follow up) >> - the de-beaned classes now go to the images output directory not JDK (thanks to Alan) >> >> The major change is that I no longer use the profiles files to define the contents of a full JRE. So the file lists that had moved to Profiles.gmk have moved back to Images.gmk and are not used when creating a profile image. This means that the only change for non-profiles builds (outside the Version.java modifications) is in how the list of JARS to build is put together. >> >> I've also integrated this with latest jdk8/build changes including all the UNSIGNED jar updates - which fit in quite nicely. >> >> One thing to note that I didn't mention originally, the change to makefiles/GensrcX11Wrappers.gmk is a hack to make cross-compilation work. The real fix is languishing in the build-infra forest and needs to get moved into jdk8/build ASAP. > > Is this the Issue: > JDK-8003958 build-infra: Cross-compilation of sizers utility has been broken > > ??? Yes. David ----- > > -kto > >> >> Thanks, >> David >> >> On 4/01/2013 1:35 PM, David Holmes wrote: >>> Hi Erik, >>> >>> On 4/01/2013 12:15 AM, Erik Joelsson wrote: >>>> Hello, >>>> >>>> Sorry for taking so long responding to this. Here are my thoughts on it. >>> >>> Thanks for getting to it, I know you have a lot on your plate at the >>> moment. >>> >>>> I like the idea of defined sets of files for each type of image. The >>>> current Images.gmk works with excludes, because that's how it used to >>>> work, but I would be happy to change to an include based process. Then >>>> we wouldn't need to convert include lists to exclude lists. I'm not >>>> saying this must happen at this point though. >>> >>> It will definitely not happen at this point. :) There is simply no time >>> to redesign everything. I have an update in the pipeline that constrains >>> my changes further so that they do not affect which files are >>> included/excluded in a full JRE. This was needed because the existing >>> lists only work for linux/solaris at this point (but unsupported on >>> solaris) and failed to produce correct JREs on windows and OSX due to >>> difference in the path locations. I hope to post an updated webrev later >>> today, or else over the weekend. >>> >>>> I would prefer if java class generation, compilation and also class >>>> patching would not be happening inside CreateJars.gmk. Especially since >>>> they emit files into the jdk output dir. For Version.java, I would break >>>> it out of GensrcMisc.gmk to GensrcVersion.gmk and handle all the >>>> variants of Version.java there. I would do the compilation in >>>> CompileJavaClasses.gmk. For the patching, this would be a new concept >>>> and has to happen after compilation and not in the same make invocation. >>>> Leaving patching in images could be ok even if I would prefer not to. >>>> But if it stays, the output needs to be in images and not jdk. The >>>> drawback of all this is of course that these things will get built >>>> regardless of if you intend to build profiles or not, but I don't think >>>> they take long enough to matter. If you don't agree, then please at >>>> least move the output to images. >>> >>> I may have to limit this to the "at least move the output to images" - >>> at least for now - though I need all .class files in one place to >>> package them into a jar file. Given the way the build is defined to >>> build the world then package up jars and images based on the image >>> contents, I was constraining myself to only affecting those two aspects. >>> As you indicated to handle this in CompileJavaClasses the whole profile >>> notion has to propagate through the build system into areas that really >>> don't care about profiles or images. >>> >>>> For the images:: rule in common/makefiles/Main.gmk, do you actually need >>>> to add things there that don't fit better in a closed version of >>>> jdk/makefiles/BuildJdk.gmk? I can't find any use of it in the current >>>> profiles repos. >>> >>> It is used in the jdk/make/closed repo for other build targets based on >>> Profiles (ie the SE embedded profile images). I'm not sure how I could >>> move it though as if it were in a closed BuildJdk.gmk then it would need >>> to augment an open BuildJdk.gmk target - and hence the :: would simply >>> move from one place to another. If this were only for embedded it might >>> be doable through a new target, but there are other factors at play. >>> (And in many ways the :: is a much simpler way of augmenting >>> pre-existing targets.) >>> >>> Thanks, >>> David >>> >>>> >>>> /Erik >>>> >>>> On 2012-12-21 07:18, David Holmes wrote: >>>>> The Java SE 8 Compact Profiles: >>>>> >>>>> http://openjdk.java.net/jeps/161 >>>>> >>>>> provides for subsetting of the Java SE 8 platform. While the >>>>> specification covers the platform, we are only providing a reference >>>>> implementation on Linux x86 at this time. >>>>> >>>>> This work is covered by a number of CRs due to there being a need for >>>>> a number of CC requests to modifying existing specifications >>>>> >>>>> 8004265: Add build support for Compact Profiles >>>>> 8004502: Compact Profiles contents >>>>> 8003255: (profiles) Update JAR file specification to support profiles >>>>> 8003256: (profiles) Add support for profile identification >>>>> 8004931: add/removePropertyChangeListener should not exist in subset >>>>> Profiles of Java SE >>>>> >>>>> The changes primarily involve the build, as you would imagine, the >>>>> compact profiles define: >>>>> >>>>> - which files (binaries, jars, native libs) are in a JRE >>>>> (profile-includes.txt) >>>>> - which packages/classes are in rt.jar/resources.jar >>>>> (profile-rtjar-includes.txt) >>>>> >>>>> But there are additional source changes: >>>>> - to support reporting the profile name as part of version information >>>>> - to test the versioning and tool changes >>>>> >>>>> and also changes to java, javac and jar so that you can indicate which >>>>> profile you are targeting, and have javac make sure you don't use an >>>>> API that won't be present; and which profile you need to run (listed >>>>> in your executable jar) so the launcher can reject it if it isn't the >>>>> right profile. The launcher and jar changes are included in this >>>>> webrev, while the javac changes are being integrated separately (plus >>>>> some related javadoc changes). >>>>> >>>>> Only the new build system is supported for building profiles. >>>>> >>>>> webrevs: >>>>> >>>>> top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/ >>>>> >>>>> The main change is to simply add profiles and profiles-only as top >>>>> level make targets (similar to images). There is also a change to >>>>> remove the hardcoded version information (though this may be handled >>>>> by a separate CR). >>>>> >>>>> jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ >>>>> >>>>> The overall build changes expand on the pre-existing definitions >>>>> whereby a JRE is a JDK with things take out. So a compact JRE is then >>>>> a JRE with additional things taken out. There are three compact >>>>> profiles (compact1 being the smallest) and a full JRE. For internal >>>>> build purposes these are referred to as PROFILE_1 etc, with a full JRE >>>>> being represented by PROFILE_4 when needed. The specification for >>>>> profiles indicates what is included in each profile, but the build >>>>> rules then invert this to obtain a set of exclusions for each profile: >>>>> the exclusions of a given profile is the set of inclusions of all >>>>> larger profiles and the JRE (and of course the JDK). >>>>> >>>>> Please note I only expect build folks to look at build changes and >>>>> core-libs to look at src/test changes (all of which have been >>>>> developed by Alan Bateman) and there is no need to cross-post your >>>>> responses. >>>>> >>>>> Like many I am about to head for Xmas break but I will continue to >>>>> monitor email and deal with changes as needed. This is needed for M6 >>>>> and we need to be ready to push in early January. >>>>> >>>>> Thanks, >>>>> David Holmes >>>>> > From david.r.chase at oracle.com Wed Jan 9 03:30:11 2013 From: david.r.chase at oracle.com (David Chase) Date: Tue, 8 Jan 2013 22:30:11 -0500 Subject: Mac build fun Message-ID: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> I had a failure building on a Mac (Mountain Lion, 10.8.2), both new build and old build, at this step: /Library/Java/JavaVirtualMachines/1.7.0.jdk/Contents/Home/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Djava.awt.headless=true -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m -jar /Users/dr2chase/work/jdk8tl/build/macosx-x86_64/../macosx-x86_64-debug/btjars/buildmetaindex.jar \ -o meta-index *.jar Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -7 at java.lang.String.substring(String.java:1958) at build.tools.buildmetaindex.JarMetaIndex.isPrefixKnown(BuildMetaIndex.java:317) at build.tools.buildmetaindex.JarMetaIndex.getMetaIndex(BuildMetaIndex.java:233) at build.tools.buildmetaindex.BuildMetaIndex.main(BuildMetaIndex.java:97) I did some snooping, and this was the problem: firstSlashIndex = 5, name = javax/.DS_Store I.E. I must have visited a directory in the Finder or some such, and it created a .DS_Store file for me. Joy. And it turns out, using the usual command for getting rid of them, that they are getting recreated again, very quickly. find . -name .DS_Store -exec rm '{}' \; find . -name .DS_Store -print the second command would find things to print. I closed all my finder and spotlight windows, deleted again, and it stayed deleted, and my build succeeded. I think this also explains mystery failures (directory not empty) in various attempts at make clean. I plan to look into a "solution" that redirects .DS_Store files into a separate directory: http://asepsis.binaryage.com/#about Just a heads up. I'm not sure whether it makes sense to harden the build against this or not; it seems like a royal pain. David From erik.joelsson at oracle.com Wed Jan 9 09:49:51 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 09 Jan 2013 10:49:51 +0100 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom In-Reply-To: <50ECD987.80102@oracle.com> References: <50EC177C.7000205@oracle.com> <50ECD987.80102@oracle.com> Message-ID: <50ED3D3F.9010305@oracle.com> On 2013-01-09 03:44, David Holmes wrote: > On 8/01/2013 10:56 PM, Erik Joelsson wrote: >> The open part of this review. Move handling of --enable-openjdk-only to >> before the first custom hook call. >> >> http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ > > Minor nit: SUPPRESS has two P's :) > > One concern I have with this is that we keep conflating custom and > closed. The OpenJDK build system provides a facility whereby the user > can augment it with custom build files - both at the configure level > and makefile level. The customizations that Oracle builds include are > what we refer to as "closed" and generally involve additional "closed" > repositories in the forest. > > In that regard to me --enable-openjdk-only was actually a closed > addition only needed for Oracle closed builds, as a convenience to say > "yes I have a full forest of open and closed parts but ignore the > closed parts and do me an openjdk build". > > Magnus argued that any build with customizations is not an OpenJDK > build. But if you follow that line then --enable-openjdk-only should > disable all use of customizations. > > What we have now seems to switch back and forth between custom and > closed. > > Something to clean up at a later time. > > Thanks, > David My interpretation of custom and closed was that we would try to implement a general way for anyone to put custom src and makefiles on top of openjdk and then have Oracle's "closed" implementation use this functionality rather than being a special case. We aren't nearly there yet of course, but that's how I've tried to apply the terminology. This surely needs to be cleaned up more. /Erik From erik.joelsson at oracle.com Wed Jan 9 09:52:06 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 09 Jan 2013 10:52:06 +0100 Subject: Mac build fun In-Reply-To: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> References: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> Message-ID: <50ED3DC6.3050007@oracle.com> Interesting observations. Definitely something to keep in mind at least. /Erik On 2013-01-09 04:30, David Chase wrote: > I had a failure building on a Mac (Mountain Lion, 10.8.2), both new build and old build, at this step: > > /Library/Java/JavaVirtualMachines/1.7.0.jdk/Contents/Home/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Djava.awt.headless=true -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m -jar /Users/dr2chase/work/jdk8tl/build/macosx-x86_64/../macosx-x86_64-debug/btjars/buildmetaindex.jar \ > -o meta-index *.jar > Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -7 > at java.lang.String.substring(String.java:1958) > at build.tools.buildmetaindex.JarMetaIndex.isPrefixKnown(BuildMetaIndex.java:317) > at build.tools.buildmetaindex.JarMetaIndex.getMetaIndex(BuildMetaIndex.java:233) > at build.tools.buildmetaindex.BuildMetaIndex.main(BuildMetaIndex.java:97) > > I did some snooping, and this was the problem: > > firstSlashIndex = 5, name = javax/.DS_Store > > I.E. I must have visited a directory in the Finder or some such, and it created a .DS_Store file for me. > Joy. > > And it turns out, using the usual command for getting rid of them, that they are getting recreated again, very quickly. > > find . -name .DS_Store -exec rm '{}' \; > find . -name .DS_Store -print > > the second command would find things to print. > > I closed all my finder and spotlight windows, deleted again, and it stayed deleted, and my build succeeded. > I think this also explains mystery failures (directory not empty) in various attempts at make clean. > I plan to look into a "solution" that redirects .DS_Store files into a separate directory: > > http://asepsis.binaryage.com/#about > > Just a heads up. I'm not sure whether it makes sense to harden the build against this or not; it seems like a royal pain. > > David > > From michael.x.mcmahon at oracle.com Wed Jan 9 10:07:29 2013 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Wed, 09 Jan 2013 10:07:29 +0000 Subject: Mac build fun In-Reply-To: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> References: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> Message-ID: <50ED4161.3080809@oracle.com> Are you building on a remote filesystem like NFS? Those .DS_Store files get created by the finder and can cause problems on remote filesystems where they become visible to other software. There is a way to disable creation of .DS_Store on remote filesystems documented at http://support.apple.com/kb/HT1629 - Michael On 09/01/13 03:30, David Chase wrote: > I had a failure building on a Mac (Mountain Lion, 10.8.2), both new build and old build, at this step: > > /Library/Java/JavaVirtualMachines/1.7.0.jdk/Contents/Home/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -Djava.awt.headless=true -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m -jar /Users/dr2chase/work/jdk8tl/build/macosx-x86_64/../macosx-x86_64-debug/btjars/buildmetaindex.jar \ > -o meta-index *.jar > Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -7 > at java.lang.String.substring(String.java:1958) > at build.tools.buildmetaindex.JarMetaIndex.isPrefixKnown(BuildMetaIndex.java:317) > at build.tools.buildmetaindex.JarMetaIndex.getMetaIndex(BuildMetaIndex.java:233) > at build.tools.buildmetaindex.BuildMetaIndex.main(BuildMetaIndex.java:97) > > I did some snooping, and this was the problem: > > firstSlashIndex = 5, name = javax/.DS_Store > > I.E. I must have visited a directory in the Finder or some such, and it created a .DS_Store file for me. > Joy. > > And it turns out, using the usual command for getting rid of them, that they are getting recreated again, very quickly. > > find . -name .DS_Store -exec rm '{}' \; > find . -name .DS_Store -print > > the second command would find things to print. > > I closed all my finder and spotlight windows, deleted again, and it stayed deleted, and my build succeeded. > I think this also explains mystery failures (directory not empty) in various attempts at make clean. > I plan to look into a "solution" that redirects .DS_Store files into a separate directory: > > http://asepsis.binaryage.com/#about > > Just a heads up. I'm not sure whether it makes sense to harden the build against this or not; it seems like a royal pain. > > David > > From Sergey.Malenkov at oracle.com Wed Jan 9 10:41:31 2013 From: Sergey.Malenkov at oracle.com (Sergey Malenkov) Date: Wed, 09 Jan 2013 14:41:31 +0400 Subject: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo. In-Reply-To: References: <03256ADC-1068-472A-9610-B79074B7B51B@Oracle.com> <50D06400.4090808@oracle.com> Message-ID: <50ED495B.2060707@oracle.com> Hi Fredrik, > It seems to be reasonable that these sources should be part of the > src.zip and that it was a bug previously that they were not. I don't think so. First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will be strange to provide sources for nonexistent (by default) classes. Second, *BeanInfo java files are generated automatically. They are not well-formatted and well-documented. Thanks, SAM On 07.01.2013 19:59, Fredrik ?hrstr?m wrote: > 2012/12/18 Sergey Malenkov : >> Looks OK to me. But there are a lot of images in the >> make/tools/swing-beans/beaninfo/images folder. Could you please check the >> make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the dt.jar >> library will be packed correctly? > > Yes, I have verified that the gifs are in the same folder. > >> Also I think that moving of java files from the >> make/tools/swing-beans/beaninfo folder is redundant, because we could copy >> them to the expected folder from the current location. > > Yes, copying to a temporary, correct package directory, would work. But I think > it is better to move them into the correct package directory, it is simpler > and cleaner. > > However here is another question. With this change, > > the following 46 source files appear in src.zip: > > /javax/swing/AbstractButtonBeanInfo.java > /javax/swing/BoxBeanInfo.java > ---- 8< ---- > javax/swing/SwingBeanInfoBase.java > /javax/swing/text/JTextComponentBeanInfo.java > > It seems to be reasonable that these sources should be part of the > src.zip and that it was a bug previously that they were not. > Can you confirm this Sergey? > > //Fredrik > From oehrstroem at gmail.com Wed Jan 9 12:07:08 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 9 Jan 2013 13:07:08 +0100 Subject: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo. In-Reply-To: <50ED495B.2060707@oracle.com> References: <03256ADC-1068-472A-9610-B79074B7B51B@Oracle.com> <50D06400.4090808@oracle.com> <50ED495B.2060707@oracle.com> Message-ID: 2013/1/9 Sergey Malenkov : > First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will > be strange to provide sources for nonexistent (by default) classes. > Second, *BeanInfo java files are generated automatically. They are not > well-formatted and well-documented. Ok, I have updated the patch, and the beaninfo files are no longer in src.zip. Here is the new webrev: http://cr.openjdk.java.net/~ohrstrom/webrev-8005096-move-a-few-files-v2/ //Fredrik From Sergey.Malenkov at oracle.com Wed Jan 9 12:03:54 2013 From: Sergey.Malenkov at oracle.com (Sergey Malenkov) Date: Wed, 09 Jan 2013 16:03:54 +0400 Subject: Review request: 8005096: Move a few source files in swing/beaninfo and in a demo. In-Reply-To: References: <03256ADC-1068-472A-9610-B79074B7B51B@Oracle.com> <50D06400.4090808@oracle.com> <50ED495B.2060707@oracle.com> Message-ID: <50ED5CAA.6070608@oracle.com> Hi Fredrik, Thanks! It looks good to me. Regards, SAM On 09.01.2013 16:07, Fredrik ?hrstr?m wrote: > 2013/1/9 Sergey Malenkov : >> First, *BeanInfo classes must be packed to dt.jar, not rt.jar. So, it will >> be strange to provide sources for nonexistent (by default) classes. >> Second, *BeanInfo java files are generated automatically. They are not >> well-formatted and well-documented. > > Ok, I have updated the patch, and the beaninfo files are no longer in src.zip. > Here is the new webrev: > > http://cr.openjdk.java.net/~ohrstrom/webrev-8005096-move-a-few-files-v2/ > > //Fredrik > From fredrik.ohrstrom at oracle.com Wed Jan 9 12:41:05 2013 From: fredrik.ohrstrom at oracle.com (fredrik.ohrstrom at oracle.com) Date: Wed, 09 Jan 2013 12:41:05 +0000 Subject: hg: jdk8/build/jdk: 8005096: Move a few source files in swing/beaninfo and in a demo. Message-ID: <20130109124151.5BD574713B@hg.openjdk.java.net> Changeset: 1868bde529b8 Author: ohrstrom Date: 2013-01-09 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1868bde529b8 8005096: Move a few source files in swing/beaninfo and in a demo. Reviewed-by: ohair, erikj, malenkov ! make/javax/swing/beaninfo/SwingBeans.gmk - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java + make/tools/swing-beans/javax/swing/SwingBeanInfoBase.java + make/tools/swing-beans/sun/swing/BeanInfoUtils.java ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcSwing.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethod.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethodDescriptor.java From erik.joelsson at oracle.com Wed Jan 9 13:04:09 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 09 Jan 2013 14:04:09 +0100 Subject: Request for Review: Java SE 8 Compact Profiles In-Reply-To: <50EBD28D.5020409@oracle.com> References: <50D3FF29.6010005@oracle.com> <50E59291.3080305@oracle.com> <50E64DF1.8060004@oracle.com> <50EBD28D.5020409@oracle.com> Message-ID: <50ED6AC9.40506@oracle.com> Looks good to me now. /Erik On 2013-01-08 09:02, David Holmes wrote: > I have updated webrevs: > > http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/ > > http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/ > > I've addressed the minor suggestions that have been given by Kelly and > Erik eg: > - better comment on the jarreorder change (and a CR to follow up) > - the de-beaned classes now go to the images output directory not JDK > (thanks to Alan) > > The major change is that I no longer use the profiles files to define > the contents of a full JRE. So the file lists that had moved to > Profiles.gmk have moved back to Images.gmk and are not used when > creating a profile image. This means that the only change for > non-profiles builds (outside the Version.java modifications) is in how > the list of JARS to build is put together. > > I've also integrated this with latest jdk8/build changes including all > the UNSIGNED jar updates - which fit in quite nicely. > > One thing to note that I didn't mention originally, the change to > makefiles/GensrcX11Wrappers.gmk is a hack to make cross-compilation > work. The real fix is languishing in the build-infra forest and needs > to get moved into jdk8/build ASAP. > > Thanks, > David > > On 4/01/2013 1:35 PM, David Holmes wrote: >> Hi Erik, >> >> On 4/01/2013 12:15 AM, Erik Joelsson wrote: >>> Hello, >>> >>> Sorry for taking so long responding to this. Here are my thoughts on >>> it. >> >> Thanks for getting to it, I know you have a lot on your plate at the >> moment. >> >>> I like the idea of defined sets of files for each type of image. The >>> current Images.gmk works with excludes, because that's how it used to >>> work, but I would be happy to change to an include based process. Then >>> we wouldn't need to convert include lists to exclude lists. I'm not >>> saying this must happen at this point though. >> >> It will definitely not happen at this point. :) There is simply no time >> to redesign everything. I have an update in the pipeline that constrains >> my changes further so that they do not affect which files are >> included/excluded in a full JRE. This was needed because the existing >> lists only work for linux/solaris at this point (but unsupported on >> solaris) and failed to produce correct JREs on windows and OSX due to >> difference in the path locations. I hope to post an updated webrev later >> today, or else over the weekend. >> >>> I would prefer if java class generation, compilation and also class >>> patching would not be happening inside CreateJars.gmk. Especially since >>> they emit files into the jdk output dir. For Version.java, I would >>> break >>> it out of GensrcMisc.gmk to GensrcVersion.gmk and handle all the >>> variants of Version.java there. I would do the compilation in >>> CompileJavaClasses.gmk. For the patching, this would be a new concept >>> and has to happen after compilation and not in the same make >>> invocation. >>> Leaving patching in images could be ok even if I would prefer not to. >>> But if it stays, the output needs to be in images and not jdk. The >>> drawback of all this is of course that these things will get built >>> regardless of if you intend to build profiles or not, but I don't think >>> they take long enough to matter. If you don't agree, then please at >>> least move the output to images. >> >> I may have to limit this to the "at least move the output to images" - >> at least for now - though I need all .class files in one place to >> package them into a jar file. Given the way the build is defined to >> build the world then package up jars and images based on the image >> contents, I was constraining myself to only affecting those two aspects. >> As you indicated to handle this in CompileJavaClasses the whole profile >> notion has to propagate through the build system into areas that really >> don't care about profiles or images. >> >>> For the images:: rule in common/makefiles/Main.gmk, do you actually >>> need >>> to add things there that don't fit better in a closed version of >>> jdk/makefiles/BuildJdk.gmk? I can't find any use of it in the current >>> profiles repos. >> >> It is used in the jdk/make/closed repo for other build targets based on >> Profiles (ie the SE embedded profile images). I'm not sure how I could >> move it though as if it were in a closed BuildJdk.gmk then it would need >> to augment an open BuildJdk.gmk target - and hence the :: would simply >> move from one place to another. If this were only for embedded it might >> be doable through a new target, but there are other factors at play. >> (And in many ways the :: is a much simpler way of augmenting >> pre-existing targets.) >> >> Thanks, >> David >> >>> >>> /Erik >>> >>> On 2012-12-21 07:18, David Holmes wrote: >>>> The Java SE 8 Compact Profiles: >>>> >>>> http://openjdk.java.net/jeps/161 >>>> >>>> provides for subsetting of the Java SE 8 platform. While the >>>> specification covers the platform, we are only providing a reference >>>> implementation on Linux x86 at this time. >>>> >>>> This work is covered by a number of CRs due to there being a need for >>>> a number of CC requests to modifying existing specifications >>>> >>>> 8004265: Add build support for Compact Profiles >>>> 8004502: Compact Profiles contents >>>> 8003255: (profiles) Update JAR file specification to support profiles >>>> 8003256: (profiles) Add support for profile identification >>>> 8004931: add/removePropertyChangeListener should not exist in subset >>>> Profiles of Java SE >>>> >>>> The changes primarily involve the build, as you would imagine, the >>>> compact profiles define: >>>> >>>> - which files (binaries, jars, native libs) are in a JRE >>>> (profile-includes.txt) >>>> - which packages/classes are in rt.jar/resources.jar >>>> (profile-rtjar-includes.txt) >>>> >>>> But there are additional source changes: >>>> - to support reporting the profile name as part of version information >>>> - to test the versioning and tool changes >>>> >>>> and also changes to java, javac and jar so that you can indicate which >>>> profile you are targeting, and have javac make sure you don't use an >>>> API that won't be present; and which profile you need to run (listed >>>> in your executable jar) so the launcher can reject it if it isn't the >>>> right profile. The launcher and jar changes are included in this >>>> webrev, while the javac changes are being integrated separately (plus >>>> some related javadoc changes). >>>> >>>> Only the new build system is supported for building profiles. >>>> >>>> webrevs: >>>> >>>> top-level repo: >>>> http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/ >>>> >>>> The main change is to simply add profiles and profiles-only as top >>>> level make targets (similar to images). There is also a change to >>>> remove the hardcoded version information (though this may be handled >>>> by a separate CR). >>>> >>>> jdk repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.jdk/ >>>> >>>> The overall build changes expand on the pre-existing definitions >>>> whereby a JRE is a JDK with things take out. So a compact JRE is then >>>> a JRE with additional things taken out. There are three compact >>>> profiles (compact1 being the smallest) and a full JRE. For internal >>>> build purposes these are referred to as PROFILE_1 etc, with a full JRE >>>> being represented by PROFILE_4 when needed. The specification for >>>> profiles indicates what is included in each profile, but the build >>>> rules then invert this to obtain a set of exclusions for each profile: >>>> the exclusions of a given profile is the set of inclusions of all >>>> larger profiles and the JRE (and of course the JDK). >>>> >>>> Please note I only expect build folks to look at build changes and >>>> core-libs to look at src/test changes (all of which have been >>>> developed by Alan Bateman) and there is no need to cross-post your >>>> responses. >>>> >>>> Like many I am about to head for Xmas break but I will continue to >>>> monitor email and deal with changes as needed. This is needed for M6 >>>> and we need to be ready to push in early January. >>>> >>>> Thanks, >>>> David Holmes >>>> From erik.joelsson at oracle.com Wed Jan 9 13:14:09 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 09 Jan 2013 14:14:09 +0100 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <50ECDC6F.7010602@oracle.com> References: <50EC20A9.3020604@oracle.com> <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> <50ECDC6F.7010602@oracle.com> Message-ID: <50ED6D21.5080604@oracle.com> 8003958 fixes this for sizer generation yes, but there is also one library in CompileNativeLibraries that has X_LIBS on the link line. But I suppose we shouldn't fix it unless there is a problem with it. /Erik On 2013-01-09 03:56, David Holmes wrote: > On 9/01/2013 5:56 AM, Kelly O'Hair wrote: >> I need more info on this, what is X_LIBS for, and why remove ALL -R >> options. > > IIRC Fredrik added this to deal with some binary difference detected > on OSX. I don't know what these variables actually contain > >> I always considered the -R options to be LD options, not library >> specifications really. >> The -L and -l options are library specifications, but -R is just a >> path that gets baked into the .so >> for runtime access to the libraries, the paths don't have to exist at >> build time. > > The paths that get baked in at build time may not exist at runtime. > > Also for cross-compilation the -R option is not recognized - which is > what > > https://jbs.oracle.com/bugs/browse/JDK-8003958 > > build-infra: Cross-compilation of sizers utility has been broken > > is all about. So these two bugs seems to be overlapping somewhat - but > the real fix is 8003958. > > David > ----- > >> -kto >> >> On Jan 8, 2013, at 5:35 AM, Erik Joelsson wrote: >> >>> Filter away -R flags from X_LIBS variable in configure. >>> >>> http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ >> From david.r.chase at oracle.com Wed Jan 9 13:33:18 2013 From: david.r.chase at oracle.com (David Chase) Date: Wed, 9 Jan 2013 08:33:18 -0500 Subject: Mac build fun In-Reply-To: <50ED4161.3080809@oracle.com> References: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> <50ED4161.3080809@oracle.com> Message-ID: <78163DD9-B46E-4635-A642-8C9BE59E3993@oracle.com> On 2013-01-09, at 5:07 AM, Michael McMahon wrote: > Are you building on a remote filesystem like NFS? Those .DS_Store files get created by the finder > and can cause problems on remote filesystems where they become visible to other software. > > There is a way to disable creation of .DS_Store on remote filesystems documented at > http://support.apple.com/kb/HT1629 No, the problem is in a local filesystem, and the .DS_Store files confused the jar packager. I figured I had better let someone know what the cause was, else there would be much time wasted when this happened to the next person building on a Mac. We might catch that exception, check for .DS_Store in the name, and provide a more useful explanation of the root cause, even if we don't get around to "fixing" it soon. For example: String secondPkgElement = null; try { secondPkgElement = name.substring(firstSlashIndex + 1, name.indexOf("/", firstSlashIndex + 1)); } catch (StringIndexOutOfBoundsException ex) { if (name.endsWith("/.DS_Store")) System.err.println ("Unexpected Mac OS Finder file " + name); throw ex; } I'm trying asepsis right now. David From erik.joelsson at oracle.com Wed Jan 9 13:47:45 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 09 Jan 2013 14:47:45 +0100 Subject: Review Request: 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib Message-ID: <50ED7501.5050104@oracle.com> Correcting the symlink to libjli in the macosx jdk bundle. http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/ /Erik From tim.bell at oracle.com Wed Jan 9 15:05:15 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 09 Jan 2013 07:05:15 -0800 Subject: Review Request: 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib In-Reply-To: <50ED7501.5050104@oracle.com> References: <50ED7501.5050104@oracle.com> Message-ID: <50ED872B.1040208@oracle.com> Hi Erik: > Correcting the symlink to libjli in the macosx jdk bundle. > > http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/ > Looks good. Tim From erik.joelsson at oracle.com Wed Jan 9 15:15:28 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 09 Jan 2013 15:15:28 +0000 Subject: hg: jdk8/build/jdk: 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib Message-ID: <20130109151555.34F7E47144@hg.openjdk.java.net> Changeset: 2cc29d0b9eaf Author: erikj Date: 2013-01-09 16:13 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2cc29d0b9eaf 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib Reviewed-by: tbell ! makefiles/Bundles.gmk From kelly.ohair at oracle.com Wed Jan 9 17:06:04 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Jan 2013 09:06:04 -0800 Subject: Mac build fun In-Reply-To: <78163DD9-B46E-4635-A642-8C9BE59E3993@oracle.com> References: <5884F3C6-5C48-459F-B4DD-C709F4BD8AC2@oracle.com> <50ED4161.3080809@oracle.com> <78163DD9-B46E-4635-A642-8C9BE59E3993@oracle.com> Message-ID: <490CC563-15B0-4727-A4A8-E709DADD41E9@oracle.com> Just for the record, I filed a P4 bug JDK-8005946 - Mac build problems with .DS_Store files so this information about .DS_Store files doesn't get completely lost. Not sure what we can do, but figured I should save the issue. -kto On Jan 9, 2013, at 5:33 AM, David Chase wrote: > > On 2013-01-09, at 5:07 AM, Michael McMahon wrote: > >> Are you building on a remote filesystem like NFS? Those .DS_Store files get created by the finder >> and can cause problems on remote filesystems where they become visible to other software. >> >> There is a way to disable creation of .DS_Store on remote filesystems documented at >> http://support.apple.com/kb/HT1629 > > No, the problem is in a local filesystem, and the .DS_Store files confused the jar packager. > I figured I had better let someone know what the cause was, else there would be much time wasted when this happened to the next person building on a Mac. We might catch that exception, check for .DS_Store in the name, and provide a more useful explanation of the root cause, even if we don't get around to "fixing" it soon. For example: > > String secondPkgElement = null; > try { > secondPkgElement = name.substring(firstSlashIndex + 1, > name.indexOf("/", > firstSlashIndex + 1)); > } catch (StringIndexOutOfBoundsException ex) { > if (name.endsWith("/.DS_Store")) > System.err.println ("Unexpected Mac OS Finder file " + name); > throw ex; > } > > > I'm trying asepsis right now. > > David > From kelly.ohair at oracle.com Wed Jan 9 17:09:00 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Jan 2013 09:09:00 -0800 Subject: Review Request: 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib In-Reply-To: <50ED7501.5050104@oracle.com> References: <50ED7501.5050104@oracle.com> Message-ID: Looks correct. -kto On Jan 9, 2013, at 5:47 AM, Erik Joelsson wrote: > Correcting the symlink to libjli in the macosx jdk bundle. > > http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/ > > /Erik From kelly.ohair at oracle.com Wed Jan 9 17:27:19 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Jan 2013 09:27:19 -0800 Subject: Encoding problem when building In-Reply-To: <50EBB5CF.3090505@linux.vnet.ibm.com> References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> <50E7BC35.5040409@linux.vnet.ibm.com> <50EBB5CF.3090505@linux.vnet.ibm.com> Message-ID: I don't know where this bug has been filed. I will file one in the new JBS system. JDK-8005947 - Windows builds in Chinese environment create generated files with Chinese characters It's P4 for now. I can adjust it to P3 but we think we can fix it, but right now my team is swamped. -kto On Jan 7, 2013, at 9:59 PM, Frank Ding wrote: > Hi Kelly, > I have filed a bug whose internal review id is 2421470. It was filed with "Product/Category" being "JDK/JRE" and "Subcategory" being "Problems common to more than one tool". I am wondering since it only happens when building OpenJDK, is it eligible for a Java bug? > In addition, do you have any idea on how to force java programs such as idlj to use ascii? > > Best regards, > Frank > > On 1/8/2013 3:42 AM, Kelly O'Hair wrote: >> Did a bug report get filed for this issue? >> >> -kto >> >> On Jan 4, 2013, at 9:37 PM, Frank Ding wrote: >> >>> Hi Volker, >>> Yes, I think so. The comment is pasted below. >>> /** >>> * org/omg/PortableServer/Current.java . >>> * ?IDL-to-Java ??? (???), ?? "3.2"?? >>> * ?../../../../src/share/classes/org/omg/PortableServer/poa.idl >>> * 2013?1?4? ??? ??01?21?01? CST >>> */ >>> >>> It's in Chinese, and it says when translated to English that "Generated by IDL-to-Java compiler(portable) version 3.2 and the date. You can also view a "normal" English one under openjdk folder "corba\gensrc\" after performing a build. >>> >>> An relevant question is that in my env (export LANG=C), java output without any param always gives me Chinese help. Even though we may find out which env var or value jvm reads on startup, it could be impossible to change them. Any insight or idea on the mechanism is welcome. >>> >>> Best regards, >>> Frank >>> >>> On 1/4/2013 4:59 PM, Volker Simonis wrote: >>>> This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind of comment is it? How does this comment look on a "normal" system? >>>> >>>> Regards, >>>> Volker >>>> >>>> >>>> On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding > wrote: >>>> >>>> Hi Kelly >>>> I investigated how local specific characters get into generated >>>> sources in corba module. Those classes are generated by following >>>> command idlj >>>> c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions >>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td >>>> "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" >>>> -i "../../../../src/share/classes/org/omg/PortableServer" -i >>>> "../../../../src/share/classes/org/omg/PortableInterceptor" -corba >>>> 3.0 -fall -pkgPrefix PortableServer org.omg >>>> ../../../../src/share/classes/org/omg/PortableServer/poa.idl >>>> >>>> I checked idlj help but there is no encoding specific option. My >>>> locale environment vars are listed below >>>> >>>> $ locale >>>> LANG=C >>>> LC_CTYPE="C" >>>> LC_NUMERIC="C" >>>> LC_TIME="C" >>>> LC_COLLATE="C" >>>> LC_MONETARY="C" >>>> LC_MESSAGES="C" >>>> LC_ALL= >>>> >>>> Could you give me any hint about how to force idlj to generate >>>> ascii chars only? >>>> >>>> Best regards, >>>> Frank >>>> >>>> >>>> On 1/1/2013 12:47 AM, Kelly O'Hair wrote: >>>> >>>> In the past, the "-encoding ascii" was important, all the >>>> reasons I can't completely list right now. But it is important >>>> that regardless of the locale, the bits created during the >>>> build should be the same for everyone. >>>> The definition of "same" might not be bit for bit, but by >>>> minimizing the potential differences we have a fighting >>>> chance of measuring "the same". >>>> >>>> But my question is, how are any locale specific characters >>>> getting into generated sources? That's what we need to find out. >>>> >>>> Removing "-encoding ascii" is probably not the right answer, >>>> and if it is, will require some debate. >>>> >>>> -kto >>>> >>>> On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: >>>> >>>> Hi >>>> I have an encoding problem when building openjdk 8 on my >>>> Windows 7. My windows is Chinese environment but I >>>> exported LANG=C in cygwin bash before building. The issue >>>> is that in module corba and jdk, some java classes are >>>> generated by program. They happen to contain Chinese >>>> characters in comment. However, they are compiled with >>>> explicit option "-encoding ascii" in makefile. This >>>> results in unrecognizable chars complained by javac >>>> (Error: encoding ascii unmappable chars) . I have a patch >>>> that removes all unnecessary "-encoding ascii" but I am >>>> not sure all its side effect. Shall I submit a bug? >>>> >>>> Best regards, >>>> Frank >>>> >>>> >>>> > From david.r.chase at oracle.com Wed Jan 9 18:43:13 2013 From: david.r.chase at oracle.com (David Chase) Date: Wed, 9 Jan 2013 13:43:13 -0500 Subject: Mac problem(?), new build, --with-debug-level=slowdebug Message-ID: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> Summary: I wanted to debug, I configured thoroughly with slowdebug, but was not able to debug the result. More detailed: I configured jdk8tl in common/makefiles, sh ../autoconf/configure --with-debug-level=slowdebug cleaned, and then built: make CONF=macosx-x86_64-normal-server-slowdebug images Then export JAVA_HOME=/Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image Then in hotspot-comp, I also configure for slowdebug, and make CONF=macosx-x86_64-normal-server-slowdebug all I then attempt to debug gamma: cd /Users/dr2chase/work/hotspot-comp/build/macosx-x86_64-normal-server-slowdebug/hotspot/bsd_amd64_compiler2/product DYLD_LIBRARY_PATH=. ./gamma -version Using java runtime at: /Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image/jre openjdk version "1.8.0-internal-debug" OpenJDK Runtime Environment (build 1.8.0-internal-debug-dr2chase_2013_01_09_11_52-b00) OpenJDK 64-Bit Server VM (build 25.0-b15, mixed mode) DYLD_LIBRARY_PATH=. gdb ./gamma ... And I seem to get no symbols. Line numbers don't match code, I can't print variables, etc. Other people (Vladimir Kozlov) using old build DO get symbols, and CAN print variables. We're running the same version of the OS, and the same version of gdb. I cannot tell if this is pilot error or a bug. Are there any suggestions for missteps I might have made? If necessary, I can distill this down to about a dozen commands to reproduce, though it takes time to run them. David From jonathan.gibbons at oracle.com Wed Jan 9 22:17:48 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 09 Jan 2013 14:17:48 -0800 Subject: Request for review: 8004834: Add doclint support into javadoc Message-ID: <50EDEC8C.8000809@oracle.com> Build folk, We will soon want to push changes into TL to enable doclint support in javadoc. This will require a minor build change until we can fix up (lots of) errors in our javadoc comments. The problem is that because of the many errors in our doc comments, javadoc will now exit with a non-zero exit code, unless we either disable doclint, for now, or ignore exit codes. The interim solution is to disable the use of doclint when generating docs during the build, by specifying a new option -Xdoclint:none. Although there is only one change, it appears in two places, for the old and new build: The webrevs are here: http://cr.openjdk.java.net/~jjg/8004834/ The langtools part of the webrev, enabling doclint, will be reviewed separately. -- Jon From kelly.ohair at oracle.com Wed Jan 9 22:26:02 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Jan 2013 14:26:02 -0800 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> Message-ID: <712739A9-7B05-42C9-97A3-4A699C7EEFA1@oracle.com> Question 1: What specific forest did you get your sources from? -kto On Jan 9, 2013, at 10:43 AM, David Chase wrote: > Summary: I wanted to debug, I configured thoroughly with slowdebug, but was not able to debug the result. > > More detailed: > > I configured jdk8tl in common/makefiles, > > sh ../autoconf/configure --with-debug-level=slowdebug > > cleaned, and then built: > > make CONF=macosx-x86_64-normal-server-slowdebug images > > Then export JAVA_HOME=/Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image > > Then in hotspot-comp, I also configure for slowdebug, and > > make CONF=macosx-x86_64-normal-server-slowdebug all > > I then attempt to debug gamma: > > cd /Users/dr2chase/work/hotspot-comp/build/macosx-x86_64-normal-server-slowdebug/hotspot/bsd_amd64_compiler2/product > DYLD_LIBRARY_PATH=. ./gamma -version > Using java runtime at: /Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image/jre > openjdk version "1.8.0-internal-debug" > OpenJDK Runtime Environment (build 1.8.0-internal-debug-dr2chase_2013_01_09_11_52-b00) > OpenJDK 64-Bit Server VM (build 25.0-b15, mixed mode) > DYLD_LIBRARY_PATH=. gdb ./gamma > ... > > And I seem to get no symbols. Line numbers don't match code, I can't print variables, etc. > Other people (Vladimir Kozlov) using old build DO get symbols, and CAN print variables. > We're running the same version of the OS, and the same version of gdb. > > I cannot tell if this is pilot error or a bug. Are there any suggestions for missteps I might have made? > > If necessary, I can distill this down to about a dozen commands to reproduce, though it takes time to run them. > > David > From david.r.chase at oracle.com Wed Jan 9 22:43:12 2013 From: david.r.chase at oracle.com (David Chase) Date: Wed, 9 Jan 2013 17:43:12 -0500 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <712739A9-7B05-42C9-97A3-4A699C7EEFA1@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <712739A9-7B05-42C9-97A3-4A699C7EEFA1@oracle.com> Message-ID: On 2013-01-09, at 5:26 PM, Kelly O'Hair wrote: > Question 1: What specific forest did you get your sources from? > > -kto >> I configured jdk8tl in common/makefiles, default = http://hg.openjdk.java.net/jdk8/tl >> Then in hotspot-comp, I also configure for slowdebug, and default = http://hg.openjdk.java.net/hsx/hotspot-comp Both of them, I did hg tpull -u earlier today. David From tim.bell at oracle.com Wed Jan 9 22:48:29 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 09 Jan 2013 14:48:29 -0800 Subject: Request for review: 8004834: Add doclint support into javadoc In-Reply-To: <50EDEC8C.8000809@oracle.com> References: <50EDEC8C.8000809@oracle.com> Message-ID: <50EDF3BD.9080307@oracle.com> Jon: > We will soon want to push changes into TL to enable doclint support in > javadoc. This will require a minor build change until we can fix up > (lots of) errors in our javadoc comments. The problem is that because > of the many errors in our doc comments, javadoc will now exit with a > non-zero exit code, unless we either disable doclint, for now, or > ignore exit codes. > > The interim solution is to disable the use of doclint when generating > docs during the build, by specifying a new option -Xdoclint:none. > > Although there is only one change, it appears in two places, for the > old and new build: > The webrevs are here: http://cr.openjdk.java.net/~jjg/8004834/ Looks good. Tim From kelly.ohair at oracle.com Wed Jan 9 22:50:48 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Jan 2013 14:50:48 -0800 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <712739A9-7B05-42C9-97A3-4A699C7EEFA1@oracle.com> Message-ID: <70C9A930-A53F-4991-B7A6-5460067B946A@oracle.com> Not sure the configure&make setup works in those repos yet. Just the jdk8/build forest at this time. You could try: hg clone http://hg.openjdk.java.net/jdk8/build jdk8-build cd jdk8-build sh ./get_source.sh sh ./get_source.ch http://closedjdk.us.oracle.com # If you want the full closed forest sh ./configure make all I'm not a trees.py user yet. -kto On Jan 9, 2013, at 2:43 PM, David Chase wrote: > > On 2013-01-09, at 5:26 PM, Kelly O'Hair wrote: > >> Question 1: What specific forest did you get your sources from? >> >> -kto > >>> I configured jdk8tl in common/makefiles, > default = http://hg.openjdk.java.net/jdk8/tl > > >>> Then in hotspot-comp, I also configure for slowdebug, and > default = http://hg.openjdk.java.net/hsx/hotspot-comp > > Both of them, I did hg tpull -u earlier today. > > David > From oehrstroem at gmail.com Thu Jan 10 08:31:57 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 10 Jan 2013 09:31:57 +0100 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> Message-ID: Could you post the hotspot-spec.gmk file? 2013/1/9 David Chase : > Summary: I wanted to debug, I configured thoroughly with slowdebug, but was not able to debug the result. > > More detailed: > > I configured jdk8tl in common/makefiles, > > sh ../autoconf/configure --with-debug-level=slowdebug > > cleaned, and then built: > > make CONF=macosx-x86_64-normal-server-slowdebug images > > Then export JAVA_HOME=/Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image > > Then in hotspot-comp, I also configure for slowdebug, and > > make CONF=macosx-x86_64-normal-server-slowdebug all > > I then attempt to debug gamma: > > cd /Users/dr2chase/work/hotspot-comp/build/macosx-x86_64-normal-server-slowdebug/hotspot/bsd_amd64_compiler2/product > DYLD_LIBRARY_PATH=. ./gamma -version > Using java runtime at: /Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image/jre > openjdk version "1.8.0-internal-debug" > OpenJDK Runtime Environment (build 1.8.0-internal-debug-dr2chase_2013_01_09_11_52-b00) > OpenJDK 64-Bit Server VM (build 25.0-b15, mixed mode) > DYLD_LIBRARY_PATH=. gdb ./gamma > ... > > And I seem to get no symbols. Line numbers don't match code, I can't print variables, etc. > Other people (Vladimir Kozlov) using old build DO get symbols, and CAN print variables. > We're running the same version of the OS, and the same version of gdb. > > I cannot tell if this is pilot error or a bug. Are there any suggestions for missteps I might have made? > > If necessary, I can distill this down to about a dozen commands to reproduce, though it takes time to run them. > > David > From staffan.larsen at oracle.com Thu Jan 10 08:56:09 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 10 Jan 2013 09:56:09 +0100 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> Message-ID: <1C2C7448-C7F1-4F38-8DB0-7DF595FCF185@oracle.com> See: http://bugs.sun.com/view_bug.do?bug_id=8004490 Patch: http://hg.openjdk.java.net/jdk8/build/rev/2d9bb72b4e34 /Staffan On 10 jan 2013, at 09:31, Fredrik ?hrstr?m wrote: > Could you post the hotspot-spec.gmk file? > > 2013/1/9 David Chase : >> Summary: I wanted to debug, I configured thoroughly with slowdebug, but was not able to debug the result. >> >> More detailed: >> >> I configured jdk8tl in common/makefiles, >> >> sh ../autoconf/configure --with-debug-level=slowdebug >> >> cleaned, and then built: >> >> make CONF=macosx-x86_64-normal-server-slowdebug images >> >> Then export JAVA_HOME=/Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image >> >> Then in hotspot-comp, I also configure for slowdebug, and >> >> make CONF=macosx-x86_64-normal-server-slowdebug all >> >> I then attempt to debug gamma: >> >> cd /Users/dr2chase/work/hotspot-comp/build/macosx-x86_64-normal-server-slowdebug/hotspot/bsd_amd64_compiler2/product >> DYLD_LIBRARY_PATH=. ./gamma -version >> Using java runtime at: /Users/dr2chase/work/jdk8tl/build/macosx-x86_64-normal-server-slowdebug/images/j2sdk-image/jre >> openjdk version "1.8.0-internal-debug" >> OpenJDK Runtime Environment (build 1.8.0-internal-debug-dr2chase_2013_01_09_11_52-b00) >> OpenJDK 64-Bit Server VM (build 25.0-b15, mixed mode) >> DYLD_LIBRARY_PATH=. gdb ./gamma >> ... >> >> And I seem to get no symbols. Line numbers don't match code, I can't print variables, etc. >> Other people (Vladimir Kozlov) using old build DO get symbols, and CAN print variables. >> We're running the same version of the OS, and the same version of gdb. >> >> I cannot tell if this is pilot error or a bug. Are there any suggestions for missteps I might have made? >> >> If necessary, I can distill this down to about a dozen commands to reproduce, though it takes time to run them. >> >> David >> From erik.joelsson at oracle.com Thu Jan 10 09:34:29 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 10 Jan 2013 10:34:29 +0100 Subject: Request for review: 8004834: Add doclint support into javadoc In-Reply-To: <50EDEC8C.8000809@oracle.com> References: <50EDEC8C.8000809@oracle.com> Message-ID: <50EE8B25.5090204@oracle.com> Looks good to me too. /Erik On 2013-01-09 23:17, Jonathan Gibbons wrote: > Build folk, > > We will soon want to push changes into TL to enable doclint support in > javadoc. This will require a minor build change until we can fix up > (lots of) errors in our javadoc comments. The problem is that because > of the many errors in our doc comments, javadoc will now exit with a > non-zero exit code, unless we either disable doclint, for now, or > ignore exit codes. > > The interim solution is to disable the use of doclint when generating > docs during the build, by specifying a new option -Xdoclint:none. > > Although there is only one change, it appears in two places, for the > old and new build: > The webrevs are here: http://cr.openjdk.java.net/~jjg/8004834/ > > The langtools part of the webrev, enabling doclint, will be reviewed > separately. > > -- Jon > > From erik.joelsson at oracle.com Thu Jan 10 11:09:59 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 10 Jan 2013 12:09:59 +0100 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom In-Reply-To: <50ECD987.80102@oracle.com> References: <50EC177C.7000205@oracle.com> <50ECD987.80102@oracle.com> Message-ID: <50EEA187.5070402@oracle.com> Fixed the spelling error http://cr.openjdk.java.net/~erikj/8005850/webrev.root.02/ /Erik On 2013-01-09 03:44, David Holmes wrote: > On 8/01/2013 10:56 PM, Erik Joelsson wrote: >> The open part of this review. Move handling of --enable-openjdk-only to >> before the first custom hook call. >> >> http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ > > Minor nit: SUPPRESS has two P's :) > > One concern I have with this is that we keep conflating custom and > closed. The OpenJDK build system provides a facility whereby the user > can augment it with custom build files - both at the configure level > and makefile level. The customizations that Oracle builds include are > what we refer to as "closed" and generally involve additional "closed" > repositories in the forest. > > In that regard to me --enable-openjdk-only was actually a closed > addition only needed for Oracle closed builds, as a convenience to say > "yes I have a full forest of open and closed parts but ignore the > closed parts and do me an openjdk build". > > Magnus argued that any build with customizations is not an OpenJDK > build. But if you follow that line then --enable-openjdk-only should > disable all use of customizations. > > What we have now seems to switch back and forth between custom and > closed. > > Something to clean up at a later time. > > Thanks, > David From tim.bell at oracle.com Thu Jan 10 19:40:01 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 10 Jan 2013 11:40:01 -0800 Subject: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom In-Reply-To: <50EEA187.5070402@oracle.com> References: <50EC177C.7000205@oracle.com> <50ECD987.80102@oracle.com> <50EEA187.5070402@oracle.com> Message-ID: <50EF1911.8070804@oracle.com> On 01/10/13 03:09, Erik Joelsson wrote: > Fixed the spelling error > > http://cr.openjdk.java.net/~erikj/8005850/webrev.root.02/ Looks good to me. Tim > > /Erik > > On 2013-01-09 03:44, David Holmes wrote: >> On 8/01/2013 10:56 PM, Erik Joelsson wrote: >>> The open part of this review. Move handling of --enable-openjdk-only to >>> before the first custom hook call. >>> >>> http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ >> >> Minor nit: SUPPRESS has two P's :) >> >> One concern I have with this is that we keep conflating custom and >> closed. The OpenJDK build system provides a facility whereby the user >> can augment it with custom build files - both at the configure level >> and makefile level. The customizations that Oracle builds include are >> what we refer to as "closed" and generally involve additional >> "closed" repositories in the forest. >> >> In that regard to me --enable-openjdk-only was actually a closed >> addition only needed for Oracle closed builds, as a convenience to >> say "yes I have a full forest of open and closed parts but ignore the >> closed parts and do me an openjdk build". >> >> Magnus argued that any build with customizations is not an OpenJDK >> build. But if you follow that line then --enable-openjdk-only should >> disable all use of customizations. >> >> What we have now seems to switch back and forth between custom and >> closed. >> >> Something to clean up at a later time. >> >> Thanks, >> David From erik.joelsson at oracle.com Fri Jan 11 09:41:56 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 11 Jan 2013 10:41:56 +0100 Subject: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk Message-ID: <50EFDE64.5030101@oracle.com> This small patch fixes a problem with configure, Cygwin and Microsoft SDK SetEnv.Cmd as reported in this mail: http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html http://cr.openjdk.java.net/~erikj/8006074/webrev.root.01/ From david.r.chase at oracle.com Fri Jan 11 14:54:16 2013 From: david.r.chase at oracle.com (David Chase) Date: Fri, 11 Jan 2013 09:54:16 -0500 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <1C2C7448-C7F1-4F38-8DB0-7DF595FCF185@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <1C2C7448-C7F1-4F38-8DB0-7DF595FCF185@oracle.com> Message-ID: <77339976-6F29-439B-B7F6-F58AA627DA7A@oracle.com> On 2013-01-10, at 3:56 AM, Staffan Larsen wrote: > See: http://bugs.sun.com/view_bug.do?bug_id=8004490 > > Patch: http://hg.openjdk.java.net/jdk8/build/rev/2d9bb72b4e34 > > /Staffan I tried the workaround in this patch, and it did not seem to result in a debuggable hotspot. I also tried the steps you recommended with jdk8-build (last night, checked out fresh), both exactly as you specified (minus closed repositories) and with the HOTSPOT_MAKE_ARGS=universal_fastdebug workaround from the bug report mentioned previously ( http://bugs.sun.com/view_bug.do?bug_id=8004490 ) This did not work either. I did a little looking, and "compile.o" is about 20 times larger in the working old-build system, and the output of "symbols compile.o" has 6000 lines instead of 1000. I then did some builds with logging turned on to get a look at the compilation line: not-debuggable compilation line: CCACHE_COMPRESS=1 CCACHE_SLOPPINESS=time_macros /opt/local/bin/ccache /Developer/usr/bin/g++-4.2 -D_ALLBSD_SOURCE -D_GNU_SOURCE -DAMD64 -DASSERT -DDEBUG -I. -IROOT/hotspot/src/share/vm/prims -IROOT/hotspot/src/share/vm -IROOT/hotspot/src/share/vm/precompiled -IROOT/hotspot/src/cpu/x86/vm -IROOT/hotspot/src/os_cpu/bsd_x86/vm -IROOT/hotspot/src/os/bsd/vm -IROOT/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION="\"25.0-b14\"" -DHOTSPOT_BUILD_TARGET="\"jvmg\"" -DHOTSPOT_BUILD_USER="\"dr2chase\"" -DHOTSPOT_LIB_ARCH=\"amd64\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DTARGET_OS_FAMILY_bsd -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_bsd_x86 -DTARGET_OS_ARCH_MODEL_bsd_x86_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -pthread -fcheck-new -m64 -pipe -fno-strict-aliasing -g -D_NMT_NOINLINE_ -DVM_LITTLE_ENDIAN -D_LP64=1 -fno-omit-frame-pointer -DINCLUDE_TRACE -Werror -Wpointer-arith -Wconversion -Wsign-compare -DDTRACE_ENABLED -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -c -fpch-deps -MMD -MP -MF ../generated/dependencies/compile.o.d -o compile.o ROOT/hotspot/src/share/vm/opto/compile.cpp debuggable compilation line: llvm-g++ -D_ALLBSD_SOURCE -D_GNU_SOURCE -DAMD64 -DASSERT -DDEBUG -I. -IROOT/src/closed/share/vm/prims -IROOT/src/share/vm/prims -IROOT/src/closed/share/vm -IROOT/src/share/vm -IROOT/src/share/vm/precompiled -IROOT/src/closed/cpu/x86/vm -IROOT/src/cpu/x86/vm -IROOT/src/os_cpu/bsd_x86/vm -IROOT/src/os/bsd/vm -IROOT/src/closed/os/posix/vm -IROOT/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION="\"25.0-b15-internal\"" -DHOTSPOT_BUILD_TARGET="\"jvmg\"" -DHOTSPOT_BUILD_USER="\"dr2chase\"" -DHOTSPOT_LIB_ARCH=\"amd64\" -DHOTSPOT_VM_DISTRO="\"Java HotSpot(TM)\"" -DTARGET_OS_FAMILY_bsd -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_bsd_x86 -DTARGET_OS_ARCH_MODEL_bsd_x86_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -pthread -fcheck-new -m64 -pipe -fno-strict-aliasing -g -D_NMT_NOINLINE_ -DVM_LITTLE_ENDIAN -D_LP64=1 -fno-omit-frame-pointer -DINCLUDE_TRACE -Werror -Wpointer-arith -Wconversion -Wsign-compare -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -c -fpch-deps -MMD -MP -MF ../generated/dependencies/compile.o.d -o compile.o ROOT/src/share/vm/opto/compile.cpp One obvious difference is that a different compiler is used. I then tried to build using llvm-g++ instead of g++-4.2, but failed to obtain this result three times: first trial: make LOG=debug HOSTCXX=llvm-g++ >& modcxx.log second trial: make LOG=debug HOSTCXX=llvm-g++ BUILD_CXX=llvm-g++ >& modcxx.log third trial: CXX=llvm-g++ sh ./configure --with-debug-level=slowdebug In all three case, the C++ compiler actually used for the build was g++-4.2, not llvm-g++. I have no idea if this is the cause of my debugging problem, but it seems like a serious bug that the documented methods for specifying the C++ compiler don't work as documented. The output of "sh ./configure help" includes: Some influential environment variables: ... CXX C++ compiler command CXXFLAGS C++ compiler flags ... Use these variables to override the choices made by `configure' or to help it to find libraries and programs with nonstandard names/locations. I checked the contents of ./build/macosx-x86_64-normal-server-slowdebug/hotspot-spec.gmk AFTER specifying CXX=llvm-g++ to configure and the string "llvm" was not contained in it. In particular: find . -name *.gmk -exec egrep -n llvm /dev/null {} ; ./jdk/make/common/shared/Compiler-llvm.gmk:34: CC = $(COMPILER_PATH)llvm-gcc ./jdk/make/common/shared/Compiler-llvm.gmk:36: CPP = $(COMPILER_PATH)llvm-gcc -E ./jdk/make/common/shared/Compiler-llvm.gmk:38: CXX = $(COMPILER_PATH)llvm-g++ ./jdk/make/common/shared/Compiler-llvm.gmk:52:# Get llvm version ./jdk/make/common/shared/Defs-versions.gmk:49: override CC_VERSION = llvm I'll continue poking at this. Again, this is on Mountain Lion. Contents of ./build/macosx-x86_64-normal-server-slowdebug/hotspot-spec.gmk WITHOUT tweaked configure settings: =========================== # # Copyright (c) 2011, 2012, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it # under the terms of the GNU General Public License version 2 only, as # published by the Free Software Foundation. Oracle designates this # particular file as subject to the "Classpath" exception as provided # by Oracle in the LICENSE file that accompanied this code. # # This code is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or # FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License # version 2 for more details (a copy is included in the LICENSE file that # accompanied this code). # # You should have received a copy of the GNU General Public License version # 2 along with this work; if not, write to the Free Software Foundation, # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. # # Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA # or visit www.oracle.com if you need additional information or have any # questions. # # Chaining of spec files HOTSPOT_SPEC:=$(dir $(SPEC))hotspot-spec.gmk override SPEC=$(HOTSPOT_SPEC) # Now include the base spec.gmk file include $(BASE_SPEC) # Additional legacy variables defined for Hotspot OPENJDK=true # Legacy defines controlled by the SUPPORT_HEADLESS and SUPPORT_HEADFUL options. BUILD_HEADLESS:=true # Legacy setting: OPT or DBG VARIANT:=DBG # Legacy setting: true or false FASTDEBUG:=false # Legacy setting: debugging the class files? DEBUG_CLASSFILES:=true ALT_CUPS_HEADERS_PATH:=$(patsubst -I%,%,$(filter -I%,)) # The HOSTCC/HOSTCXX is Hotspot terminology for the BUILD_CC/BUILD_CXX, i.e. the # compiler that produces code that can be run on the build platform. HOSTCC:= /Developer/usr/bin/gcc-4.2 HOSTCXX:= /Developer/usr/bin/g++-4.2 #################################################### # # Legacy Hotspot support # If cross compiling, then define CROSS_COMPILE_ARCH:=cpu_name here. # Old name for OPENJDK_TARGET_OS (aix,bsd,hpux,linux,macosx,solaris,windows etc) PLATFORM=$(OPENJDK_TARGET_OS) # 32 or 64 bit ARCH_DATA_MODEL=$(OPENJDK_TARGET_CPU_BITS) ALT_BOOTDIR=$(BOOT_JDK) # Can be /sparcv9 or /amd64 on Solaris ISA_DIR=$(OPENJDK_TARGET_CPU_ISADIR) # Yet another name for arch used for an extra subdir below the jvm lib. # Uses i386 and amd64, instead of x86 and x86_64. LIBARCH=$(OPENJDK_TARGET_CPU_LEGACY_LIB) # Old name for OPENJDK_TARGET_CPU, uses i586 and amd64, instead of x86 and x86_64. ARCH=$(OPENJDK_TARGET_CPU_LEGACY) # Legacy setting for building for a 64 bit machine. # If yes then this expands to _LP64:=1 LP64:= ALT_OUTPUTDIR=$(HOTSPOT_OUTPUTDIR) ALT_EXPORT_PATH=$(HOTSPOT_DIST) HOTSPOT_MAKE_ARGS:=universal_product # This is used from the libjvm build for C/C++ code. HOTSPOT_BUILD_JOBS:=4 # Control wether Hotspot runs Queens test after building TEST_IN_BUILD=false # For hotspot, override compiler/tools definition to not include FIXPATH prefix. # Hotspot has its own handling on the Windows path situation. CXX:=CCACHE_COMPRESS=1 CCACHE_SLOPPINESS=time_macros /opt/local/bin/ccache /Developer/usr/bin/g++-4.2 LD:=/Developer/usr/bin/gcc-4.2 MT:= RC:= EXTRA_CFLAGS= EXTRA_CXXFLAGS= EXTRA_LDFLAGS= USE_PRECOMPILED_HEADER=1 # Hotspot expects the variable FULL_DEBUG_SYMBOLS=1/0 to control debug symbols # creation. ifeq ($(ENABLE_DEBUG_SYMBOLS), true) FULL_DEBUG_SYMBOLS=1 # Ensure hotspot uses the objcopy that configure located ALT_OBJCOPY:=$(OBJCOPY) else FULL_DEBUG_SYMBOLS=0 endif # Hotspot expects the variable ZIP_DEBUGINFO_FILES=1/0 and not true/false. ifeq ($(ZIP_DEBUGINFO_FILES)$(ENABLE_DEBUG_SYMBOLS), truetrue) ZIP_DEBUGINFO_FILES:=1 endif ifeq ($(ZIP_DEBUGINFO_FILES), false) ZIP_DEBUGINFO_FILES:=0 endif # Sneak this in via the spec.gmk file, since we don't want to mess around too much with the Hotspot make files. # This is needed to get the LOG setting to work properly. include $(SRC_ROOT)/common/makefiles/MakeBase.gmk =========================== From tim.bell at oracle.com Fri Jan 11 15:01:47 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 11 Jan 2013 07:01:47 -0800 Subject: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk In-Reply-To: <50EFDE64.5030101@oracle.com> References: <50EFDE64.5030101@oracle.com> Message-ID: <50F0295B.5070509@oracle.com> Erik: > This small patch fixes a problem with configure, Cygwin and Microsoft > SDK SetEnv.Cmd as reported in this mail: > > http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html > > > http://cr.openjdk.java.net/~erikj/8006074/webrev.root.01/ Looks good. Thanks for fixing this. Tim From erik.joelsson at oracle.com Fri Jan 11 16:25:38 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 11 Jan 2013 17:25:38 +0100 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt Message-ID: <50F03D02.8030306@oracle.com> This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Even if several people would like to do away with the overlay images, that change should be separate to switching to build-infra. /Erik From tim.bell at oracle.com Fri Jan 11 16:38:10 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 11 Jan 2013 08:38:10 -0800 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt In-Reply-To: <50F03D02.8030306@oracle.com> References: <50F03D02.8030306@oracle.com> Message-ID: <50F03FF2.8060203@oracle.com> Erik: > This fixes the bundles target for jprt so that overlay images are > bundled up for solaris 64bit. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Looks good. > Even if several people would like to do away with the overlay images, > that change should be separate to switching to build-infra. I agree. That is a worthwhile project, but it can be done at some point after the current build-infra changes are completed. Tim From kelly.ohair at oracle.com Fri Jan 11 16:44:12 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 11 Jan 2013 08:44:12 -0800 Subject: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk In-Reply-To: <50EFDE64.5030101@oracle.com> References: <50EFDE64.5030101@oracle.com> Message-ID: <8EEF4FAC-39EA-44E0-ACC6-088D34537C58@oracle.com> Looks good. -kto On Jan 11, 2013, at 1:41 AM, Erik Joelsson wrote: > This small patch fixes a problem with configure, Cygwin and Microsoft SDK SetEnv.Cmd as reported in this mail: > > http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html > > http://cr.openjdk.java.net/~erikj/8006074/webrev.root.01/ From erik.joelsson at oracle.com Fri Jan 11 16:55:44 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 11 Jan 2013 16:55:44 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20130111165544.60AAD471F3@hg.openjdk.java.net> Changeset: db3984e4eb97 Author: erikj Date: 2013-01-10 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/db3984e4eb97 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh Reviewed-by: tbell, ohair ! common/bin/compare.sh Changeset: 6f8f7a5449f6 Author: erikj Date: 2013-01-11 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/6f8f7a5449f6 8005850: build-infra: Make --enable-openjdk-only really disable custom Reviewed-by: ohair, dholmes ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 From erik.joelsson at oracle.com Fri Jan 11 16:55:55 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Fri, 11 Jan 2013 16:55:55 +0000 Subject: hg: jdk8/build/jdk: 8005856: build-infra: Remove special handling of base module classes header generation Message-ID: <20130111165626.27ACD471F4@hg.openjdk.java.net> Changeset: f92ab6dbbff8 Author: erikj Date: 2013-01-10 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f92ab6dbbff8 8005856: build-infra: Remove special handling of base module classes header generation Reviewed-by: alanb, tbell, ohair Contributed-by: fredrik.ohrstrom at oracle.com ! makefiles/CompileJavaClasses.gmk ! src/share/classes/java/io/FileSystem.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/windows/classes/sun/nio/ch/PollArrayWrapper.java From kelly.ohair at oracle.com Fri Jan 11 17:04:09 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 11 Jan 2013 09:04:09 -0800 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt In-Reply-To: <50F03D02.8030306@oracle.com> References: <50F03D02.8030306@oracle.com> Message-ID: Looks good. -kto On Jan 11, 2013, at 8:25 AM, Erik Joelsson wrote: > This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ > > Even if several people would like to do away with the overlay images, that change should be separate to switching to build-infra. > > /Erik From david.r.chase at oracle.com Fri Jan 11 21:01:20 2013 From: david.r.chase at oracle.com (David Chase) Date: Fri, 11 Jan 2013 16:01:20 -0500 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> Message-ID: <4B57FB8A-EBD7-4274-AD89-D538547BCCBA@oracle.com> Problem solved: /Developer consider harmful, at least on Mountain Lion. Removing that and using the compilers installed by XCode in /usr/bin did the trick. HOWEVER - it seems dubious to me that configure should ignore the environment specification of CXX. I tried the following, where /usr/local/bin/g++ is a 4.8.0 compiler that configure will accept if it appears first on the path (this does not lead to a happy build, it merely demonstrates that the compiler is acceptable to configure): (1) sh ./configure CXX=/usr/local/bin/g++ (2) CXX=/usr/local/bin/g++ sh ./configure I tried (2) because of ambiguous language from sh ./configure -help: To assign environment variables (e.g., CC, CFLAGS...), specify them as VAR=VALUE. See below for descriptions of some of the useful variables. I understand that environment variable bindings precede the command on the command line, but the instructions did not say this explicitly, so I tried it both ways. I verified that my "sh" is not doing anything non-standard with its environment: bash-3.2$ CXX=/usr/local/bin/g++ sh -c printenv | grep CXX CXX=/usr/local/bin/g++ In both cases this was the result of the configure: Tools summary: * Boot JDK: ... * C Compiler: i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build) version 2336.11.00) (at /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2) * C++ Compiler: i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build) version 2336.11.00) (at /usr/llvm-gcc-4.2/bin/llvm-g++-4.2) So, bug? David From naoto.sato at oracle.com Fri Jan 11 21:18:22 2013 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 11 Jan 2013 13:18:22 -0800 Subject: [8]Review Request: 7162007: Clean up i18n related caches Message-ID: <50F0819E.1080306@oracle.com> Hello, (To build-dev folks, I am sending this to you as the change includes one modification in make directory. It is just simply adding a new Java file, so I think it won't affect the new build-infra structure) Please review the changes for this issue: http://bugs.sun.com/view_bug.do?bug_id=7162007 Currently locale sensitive services cache their data in a very ad-hoc manner, scattered everywhere. This issue intends to consolidate them into a centralized location in sun.util.locale.provider package. The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/7162007/webrev.00/ Naoto From kelly.ohair at oracle.com Sat Jan 12 01:40:32 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 11 Jan 2013 17:40:32 -0800 Subject: [8]Review Request: 7162007: Clean up i18n related caches In-Reply-To: <50F0819E.1080306@oracle.com> References: <50F0819E.1080306@oracle.com> Message-ID: makefile change is fine, no need to change the new build makefiles at all. -kto On Jan 11, 2013, at 1:18 PM, Naoto Sato wrote: > Hello, > > (To build-dev folks, I am sending this to you as the change includes one modification in make directory. It is just simply adding a new Java file, so I think it won't affect the new build-infra structure) > > Please review the changes for this issue: > > http://bugs.sun.com/view_bug.do?bug_id=7162007 > > Currently locale sensitive services cache their data in a very ad-hoc manner, scattered everywhere. This issue intends to consolidate them into a centralized location in sun.util.locale.provider package. > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/7162007/webrev.00/ > > Naoto From masayoshi.okutsu at oracle.com Sat Jan 12 07:58:27 2013 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Sat, 12 Jan 2013 16:58:27 +0900 Subject: [8]Review Request: 7162007: Clean up i18n related caches In-Reply-To: <50F0819E.1080306@oracle.com> References: <50F0819E.1080306@oracle.com> Message-ID: <50F117A3.9040309@oracle.com> Looks good to me. Masayoshi On 1/12/2013 6:18 AM, Naoto Sato wrote: > Hello, > > (To build-dev folks, I am sending this to you as the change includes > one modification in make directory. It is just simply adding a new > Java file, so I think it won't affect the new build-infra structure) > > Please review the changes for this issue: > > http://bugs.sun.com/view_bug.do?bug_id=7162007 > > Currently locale sensitive services cache their data in a very ad-hoc > manner, scattered everywhere. This issue intends to consolidate them > into a centralized location in sun.util.locale.provider package. > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/7162007/webrev.00/ > > Naoto From david.holmes at oracle.com Mon Jan 14 00:17:50 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 14 Jan 2013 10:17:50 +1000 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <4B57FB8A-EBD7-4274-AD89-D538547BCCBA@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <4B57FB8A-EBD7-4274-AD89-D538547BCCBA@oracle.com> Message-ID: <50F34EAE.8020207@oracle.com> David, I could be mistaken but I thought the use of CXX= was intended as a make variable to override the value that configure places in the spec.gmk file - not as a way to force configure to output something to spec.gmk. In that case the problem is likely that, due to various level of nested makes, these top-level make variable definitions may not get passed down to all the places that need them. In particular we have already seen several problems where things were not passed to hotspot in a way that hotspot would use. David On 12/01/2013 7:01 AM, David Chase wrote: > Problem solved: /Developer consider harmful, at least on Mountain Lion. > Removing that and using the compilers installed by XCode in /usr/bin did the trick. > > HOWEVER - it seems dubious to me that configure should ignore the environment specification of CXX. > I tried the following, > where /usr/local/bin/g++ is a 4.8.0 compiler that configure will accept if it appears first on the path > (this does not lead to a happy build, it merely demonstrates that the compiler is acceptable to configure): > > (1) sh ./configure CXX=/usr/local/bin/g++ > (2) CXX=/usr/local/bin/g++ sh ./configure > > I tried (2) because of ambiguous language from sh ./configure -help: > > To assign environment variables (e.g., CC, CFLAGS...), specify them as > VAR=VALUE. See below for descriptions of some of the useful variables. > > I understand that environment variable bindings precede the command on the command line, > but the instructions did not say this explicitly, so I tried it both ways. > > I verified that my "sh" is not doing anything non-standard with its environment: > > bash-3.2$ CXX=/usr/local/bin/g++ sh -c printenv | grep CXX > CXX=/usr/local/bin/g++ > > In both cases this was the result of the configure: > > Tools summary: > * Boot JDK: ... > * C Compiler: i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build) version 2336.11.00) (at /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2) > * C++ Compiler: i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build) version 2336.11.00) (at /usr/llvm-gcc-4.2/bin/llvm-g++-4.2) > > So, bug? > > David > From david.r.chase at oracle.com Mon Jan 14 00:32:59 2013 From: david.r.chase at oracle.com (David Chase) Date: Sun, 13 Jan 2013 19:32:59 -0500 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <50F34EAE.8020207@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <4B57FB8A-EBD7-4274-AD89-D538547BCCBA@oracle.com> <50F34EAE.8020207@oracle.com> Message-ID: On 2013-01-13, at 7:17 PM, David Holmes wrote: > David, > > I could be mistaken but I thought the use of CXX= was intended as a make variable to override the value that configure places in the spec.gmk file - not as a way to force configure to output something to spec.gmk. It's entirely likely that I misunderstood, but I think the output of "sh ./configure -help" could be made less ambiguous. I would ordinarily expect "make help" to inform me of relevant EVs for running make. -------------- Running generated-configure.sh `configure' configures OpenJDK jdk8 to adapt to many kinds of systems. Usage: ./common/autoconf/configure [OPTION]... [VAR=VALUE]... To assign environment variables (e.g., CC, CFLAGS...), specify them as VAR=VALUE. See below for descriptions of some of the useful variables. ... (below) Some influential environment variables: PKG_CONFIG path to pkg-config utility CC C compiler command CFLAGS C compiler flags LDFLAGS linker flags, e.g. -L if you have libraries in a nonstandard directory LIBS libraries to pass to the linker, e.g. -l CPPFLAGS (Objective) C/C++ preprocessor flags, e.g. -I if you have headers in a nonstandard directory CXX C++ compiler command CXXFLAGS C++ compiler flags OBJC Objective C compiler command OBJCFLAGS Objective C compiler flags CPP C preprocessor CXXCPP C++ preprocessor XMKMF Path to xmkmf, Makefile generator for X Window System FREETYPE2_CFLAGS C compiler flags for FREETYPE2, overriding pkg-config FREETYPE2_LIBS linker flags for FREETYPE2, overriding pkg-config ALSA_CFLAGS C compiler flags for ALSA, overriding pkg-config ALSA_LIBS linker flags for ALSA, overriding pkg-config Use these variables to override the choices made by `configure' or to help it to find libraries and programs with nonstandard names/locations. -------------- From erik.joelsson at oracle.com Mon Jan 14 09:10:42 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 14 Jan 2013 10:10:42 +0100 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <4B57FB8A-EBD7-4274-AD89-D538547BCCBA@oracle.com> <50F34EAE.8020207@oracle.com> Message-ID: <50F3CB92.5060909@oracle.com> Hello, The help text produced by autoconf is part specific to our scripts and part is standard autoconf stuff. The variable section is part of the standard help. It's bad that the script isn't behaving as the help text suggests and we should try to fix that if possible. We definitely need to review the documentation. We have avoided letting environment variables affect configure. The reason is reproducibility, we want to force configuration options to the command line so that it's obvious someone put them there for a reason, rather than something hidden in the environment secretly changing things. For this issue I'm not sure which would be the best solution. It could use some discussion. /Erik On 2013-01-14 01:32, David Chase wrote: > On 2013-01-13, at 7:17 PM, David Holmes wrote: > >> David, >> >> I could be mistaken but I thought the use of CXX= was intended as a make variable to override the value that configure places in the spec.gmk file - not as a way to force configure to output something to spec.gmk. > It's entirely likely that I misunderstood, but I think the output of "sh ./configure -help" > could be made less ambiguous. I would ordinarily expect "make help" to inform me of > relevant EVs for running make. > -------------- > Running generated-configure.sh > `configure' configures OpenJDK jdk8 to adapt to many kinds of systems. > > Usage: ./common/autoconf/configure [OPTION]... [VAR=VALUE]... > > To assign environment variables (e.g., CC, CFLAGS...), specify them as > VAR=VALUE. See below for descriptions of some of the useful variables. > ... > (below) > Some influential environment variables: > PKG_CONFIG path to pkg-config utility > CC C compiler command > CFLAGS C compiler flags > LDFLAGS linker flags, e.g. -L if you have libraries in a > nonstandard directory > LIBS libraries to pass to the linker, e.g. -l > CPPFLAGS (Objective) C/C++ preprocessor flags, e.g. -I if > you have headers in a nonstandard directory > CXX C++ compiler command > CXXFLAGS C++ compiler flags > OBJC Objective C compiler command > OBJCFLAGS Objective C compiler flags > CPP C preprocessor > CXXCPP C++ preprocessor > XMKMF Path to xmkmf, Makefile generator for X Window System > FREETYPE2_CFLAGS > C compiler flags for FREETYPE2, overriding pkg-config > FREETYPE2_LIBS > linker flags for FREETYPE2, overriding pkg-config > ALSA_CFLAGS C compiler flags for ALSA, overriding pkg-config > ALSA_LIBS linker flags for ALSA, overriding pkg-config > > Use these variables to override the choices made by `configure' or to help > it to find libraries and programs with nonstandard names/locations. > -------------- > From Vladislav.Karnaukhov at oracle.com Mon Jan 14 12:21:02 2013 From: Vladislav.Karnaukhov at oracle.com (Vladislav Karnaukhov) Date: Mon, 14 Jan 2013 16:21:02 +0400 Subject: JDK BridgeSupport Mac OS X build issue Message-ID: <50F3F82E.7050907@oracle.com> Hello, I'm trying to build JDK using previously built Hotspot/JDK as a bootstrap. Everything seems to work fine until it comes to BridgeSupport: Updating bridge support in /Users/karnaukhovv/projects/tmp/jdk/build/bridge_metadata (cd /Users/karnaukhovv/projects/tmp/jdk/build/bridge_metadata; make STABLE_GEN_DIR="/Users/karnaukhovv/projects/tmp/jdk/build/stable_bridge_metadata" FRAMEWORKS="Foundation CoreFoundation AppKit" -f ../../../src/macosx/native/jobjc/bridgesupport.gmk all) make[3]: ../../../src/macosx/native/jobjc/bridgesupport.gmk: No such file or directory make[3]: *** No rule to make target `../../../src/macosx/native/jobjc/bridgesupport.gmk'. Stop. make[2]: *** [stabilize] Error 2 make[1]: *** [all] Error 1 make: *** [all] Error 1 I run make from jdk/make dir, but looks like make searches for .gmk file in a wrong place. I found changesets for issues 8005597 and 7176225, but they don't seem to be connected with my issue. Is it a known issue? Am I doing anything wrong? Regards, - Vlad From erik.joelsson at oracle.com Mon Jan 14 13:24:37 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 14 Jan 2013 14:24:37 +0100 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt In-Reply-To: <50F03D02.8030306@oracle.com> References: <50F03D02.8030306@oracle.com> Message-ID: <50F40715.2090602@oracle.com> This didn't quite work as I expected. Found the issue in needing to include SPEC before Jprt.gmk so that variables from SPEC would be available in Jprt.gmk at parse time. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ /Erik On 2013-01-11 17:25, Erik Joelsson wrote: > This fixes the bundles target for jprt so that overlay images are > bundled up for solaris 64bit. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ > > Even if several people would like to do away with the overlay images, > that change should be separate to switching to build-infra. > > /Erik From tim.bell at oracle.com Mon Jan 14 14:28:16 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 14 Jan 2013 06:28:16 -0800 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt In-Reply-To: <50F40715.2090602@oracle.com> References: <50F03D02.8030306@oracle.com> <50F40715.2090602@oracle.com> Message-ID: <50F415FF.8050704@oracle.com> Erik: > This didn't quite work as I expected. Found the issue in needing to > include SPEC before Jprt.gmk so that variables from SPEC would be > available in Jprt.gmk at parse time. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ Looks good. Tim > /Erik > > On 2013-01-11 17:25, Erik Joelsson wrote: >> This fixes the bundles target for jprt so that overlay images are >> bundled up for solaris 64bit. >> >> http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ >> >> Even if several people would like to do away with the overlay images, >> that change should be separate to switching to build-infra. >> >> /Erik From Alan.Bateman at oracle.com Mon Jan 14 14:44:40 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 14 Jan 2013 14:44:40 +0000 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt In-Reply-To: <50F40715.2090602@oracle.com> References: <50F03D02.8030306@oracle.com> <50F40715.2090602@oracle.com> Message-ID: <50F419D8.7080707@oracle.com> On 14/01/2013 13:24, Erik Joelsson wrote: > This didn't quite work as I expected. Found the issue in needing to > include SPEC before Jprt.gmk so that variables from SPEC would be > available in Jprt.gmk at parse time. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ > > /Erik Thanks Erik, I've just tried this patch and it works well (so thumbs up from me). -Alan. From david.r.chase at oracle.com Mon Jan 14 15:32:00 2013 From: david.r.chase at oracle.com (David Chase) Date: Mon, 14 Jan 2013 10:32:00 -0500 Subject: Mac problem(?), new build, --with-debug-level=slowdebug In-Reply-To: <50F3CB92.5060909@oracle.com> References: <90740E1D-D1CA-432C-AF9C-2AFC978296CA@oracle.com> <4B57FB8A-EBD7-4274-AD89-D538547BCCBA@oracle.com> <50F34EAE.8020207@oracle.com> <50F3CB92.5060909@oracle.com> Message-ID: <0889E003-1E25-42DE-939B-6C4BB0D47109@oracle.com> Just a nit, but configure is quite happy to use the PATH environment variable, not that it mentions this anywhere in the output of "sh configure help". Yes, I know that PATH is implicit, yes, I know that I am complaining about Unix documentation, yes I know that the new build system is in fact still new, and yes I know that the people who write documentation never get the time/respect that they deserve. Also note that the output of "sh configure -help" uses the word "PATH" to refer to the directory value for whatever option is currently being described, as in: --with-cups specify prefix directory for the cups package (expecting the headers under PATH/include) Probably best not to do that. Long term it would be good to rationalize both configure and make w.r.t. to documentation and flags. Sample problem #1 (does the documentation tell us this?) how do I specify a flag to the assembler? Sample problem #2 (does the documentation tell us this?) how do I specify a particular compiler for Objective C source? (I "solved" sample problem #1 with find, grep, and trial and error. I have not solved sample problem #2.) David On 2013-01-14, at 4:10 AM, Erik Joelsson wrote: > Hello, > > The help text produced by autoconf is part specific to our scripts and part is standard autoconf stuff. The variable section is part of the standard help. It's bad that the script isn't behaving as the help text suggests and we should try to fix that if possible. We definitely need to review the documentation. > > We have avoided letting environment variables affect configure. The reason is reproducibility, we want to force configuration options to the command line so that it's obvious someone put them there for a reason, rather than something hidden in the environment secretly changing things. For this issue I'm not sure which would be the best solution. It could use some discussion. > > /Erik > From kelly.ohair at oracle.com Mon Jan 14 16:27:04 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 14 Jan 2013 08:27:04 -0800 Subject: Review Request: 8006100: build-infra: Bundle up the correct images in jprt In-Reply-To: <50F40715.2090602@oracle.com> References: <50F03D02.8030306@oracle.com> <50F40715.2090602@oracle.com> Message-ID: Ok from me. -kto On Jan 14, 2013, at 5:24 AM, Erik Joelsson wrote: > This didn't quite work as I expected. Found the issue in needing to include SPEC before Jprt.gmk so that variables from SPEC would be available in Jprt.gmk at parse time. > > http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ > > /Erik > > On 2013-01-11 17:25, Erik Joelsson wrote: >> This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. >> >> http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ >> >> Even if several people would like to do away with the overlay images, that change should be separate to switching to build-infra. >> >> /Erik From kelly.ohair at oracle.com Tue Jan 15 00:38:31 2013 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 15 Jan 2013 00:38:31 +0000 Subject: hg: jdk8/build: 8005284: build-infra: nonstandard copyright headers under common/autoconf/build-aux Message-ID: <20130115003831.52BB647271@hg.openjdk.java.net> Changeset: b66c81dfa291 Author: ohair Date: 2013-01-14 16:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/b66c81dfa291 8005284: build-infra: nonstandard copyright headers under common/autoconf/build-aux Reviewed-by: katleman ! common/autoconf/build-aux/autoconf-config.guess ! common/autoconf/build-aux/config.sub ! common/autoconf/build-aux/pkg.m4 From erik.joelsson at oracle.com Tue Jan 15 11:13:25 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 15 Jan 2013 12:13:25 +0100 Subject: Review Request: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. Message-ID: <50F539D5.9010402@oracle.com> This fix adds the missing manifest to sunmscapi.jar. This should fix javax/crypto/sanity/CheckManifestForRelease.java which is currently failing for build-infra builds. http://cr.openjdk.java.net/~erikj/8006296/webrev.jdk.01/ /Erik From Alan.Bateman at oracle.com Tue Jan 15 11:33:52 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 15 Jan 2013 11:33:52 +0000 Subject: Review Request: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. In-Reply-To: <50F539D5.9010402@oracle.com> References: <50F539D5.9010402@oracle.com> Message-ID: <50F53EA0.60608@oracle.com> On 15/01/2013 11:13, Erik Joelsson wrote: > This fix adds the missing manifest to sunmscapi.jar. This should fix > javax/crypto/sanity/CheckManifestForRelease.java which is currently > failing for build-infra builds. > > http://cr.openjdk.java.net/~erikj/8006296/webrev.jdk.01/ > > /Erik This looks good to me. -Alan From erik.joelsson at oracle.com Tue Jan 15 12:37:46 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Tue, 15 Jan 2013 12:37:46 +0000 Subject: hg: jdk8/build: 3 new changesets Message-ID: <20130115123748.076234728C@hg.openjdk.java.net> Changeset: 3540aa40c868 Author: erikj Date: 2013-01-14 13:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/3540aa40c868 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk Reviewed-by: tbell, ohair ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh Changeset: 6e822b534678 Author: erikj Date: 2013-01-14 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/6e822b534678 8006100: build-infra: Bundle up the correct images in jprt Reviewed-by: tbell ! NewMakefile.gmk ! common/makefiles/Jprt.gmk Changeset: 52cce3326649 Author: erikj Date: 2013-01-15 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/52cce3326649 Merge From tim.bell at oracle.com Tue Jan 15 14:42:32 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 15 Jan 2013 06:42:32 -0800 Subject: Review Request: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. In-Reply-To: <50F53EA0.60608@oracle.com> References: <50F539D5.9010402@oracle.com> <50F53EA0.60608@oracle.com> Message-ID: <50F56AD8.1040404@oracle.com> On 01/15/13 03:33, Alan Bateman wrote: > On 15/01/2013 11:13, Erik Joelsson wrote: >> This fix adds the missing manifest to sunmscapi.jar. This should fix >> javax/crypto/sanity/CheckManifestForRelease.java which is currently >> failing for build-infra builds. >> >> http://cr.openjdk.java.net/~erikj/8006296/webrev.jdk.01/ >> >> /Erik > This looks good to me. Looks good to me as well. Tim From erik.joelsson at oracle.com Tue Jan 15 15:58:38 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Tue, 15 Jan 2013 15:58:38 +0000 Subject: hg: jdk8/build/jdk: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. Message-ID: <20130115155928.2FE324728E@hg.openjdk.java.net> Changeset: 4d80ab394efa Author: erikj Date: 2013-01-15 16:50 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4d80ab394efa 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. Reviewed-by: alanb, tbell ! makefiles/CreateJars.gmk From david.katleman at oracle.com Tue Jan 15 18:15:03 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:15:03 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20130115181503.5D9AB4729B@hg.openjdk.java.net> Changeset: f03f90a4308d Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/f03f90a4308d Added tag jdk8-b72 for changeset c1be681d80a1 ! .hgtags Changeset: fe1c94aca5a8 Author: katleman Date: 2013-01-15 10:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/fe1c94aca5a8 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers From david.katleman at oracle.com Tue Jan 15 18:15:07 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:15:07 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b72 for changeset cb40427f4714 Message-ID: <20130115181507.A820F4729C@hg.openjdk.java.net> Changeset: 191afde59e7b Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/191afde59e7b Added tag jdk8-b72 for changeset cb40427f4714 ! .hgtags From david.katleman at oracle.com Tue Jan 15 18:17:53 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:17:53 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b72 for changeset d5cb5830f570 Message-ID: <20130115181757.E85AB4729D@hg.openjdk.java.net> Changeset: 11619f33cd68 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/11619f33cd68 Added tag jdk8-b72 for changeset d5cb5830f570 ! .hgtags From david.katleman at oracle.com Tue Jan 15 18:19:27 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:19:27 +0000 Subject: hg: jdk8/build/jaxp: 2 new changesets Message-ID: <20130115181933.E71D14729E@hg.openjdk.java.net> Changeset: 84946404d1e1 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/84946404d1e1 Added tag jdk8-b72 for changeset bdf2af722a6b ! .hgtags Changeset: a317d3e1bbac Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a317d3e1bbac Merge From david.katleman at oracle.com Tue Jan 15 18:19:38 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:19:38 +0000 Subject: hg: jdk8/build/jaxws: 2 new changesets Message-ID: <20130115181944.646C64729F@hg.openjdk.java.net> Changeset: c606f644a5d9 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/c606f644a5d9 Added tag jdk8-b72 for changeset d9707230294d ! .hgtags Changeset: b8fd32e44c26 Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b8fd32e44c26 Merge From david.katleman at oracle.com Tue Jan 15 18:19:57 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:19:57 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20130115182031.ED807472A0@hg.openjdk.java.net> Changeset: c9a914b11436 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c9a914b11436 Added tag jdk8-b72 for changeset 32a57e645e01 ! .hgtags Changeset: 6d1a3d43851d Author: katleman Date: 2013-01-15 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6d1a3d43851d Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java From kelly.ohair at oracle.com Tue Jan 15 18:20:50 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 15 Jan 2013 10:20:50 -0800 Subject: Review Request: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. In-Reply-To: <50F539D5.9010402@oracle.com> References: <50F539D5.9010402@oracle.com> Message-ID: <05F318A6-656D-4777-A1E6-C3D3DA412165@oracle.com> Looks good. -kto On Jan 15, 2013, at 3:13 AM, Erik Joelsson wrote: > This fix adds the missing manifest to sunmscapi.jar. This should fix javax/crypto/sanity/CheckManifestForRelease.java which is currently failing for build-infra builds. > > http://cr.openjdk.java.net/~erikj/8006296/webrev.jdk.01/ > > /Erik From david.katleman at oracle.com Tue Jan 15 18:22:21 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 15 Jan 2013 18:22:21 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b72 for changeset 6f0986ed9b7e Message-ID: <20130115182226.0787D472A1@hg.openjdk.java.net> Changeset: 45fed5cfd1c3 Author: katleman Date: 2013-01-10 09:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/45fed5cfd1c3 Added tag jdk8-b72 for changeset 6f0986ed9b7e ! .hgtags From tom.deneau at amd.com Tue Jan 15 22:17:50 2013 From: tom.deneau at amd.com (Deneau, Tom) Date: Tue, 15 Jan 2013 22:17:50 +0000 Subject: javadocs with NEWBUILD Message-ID: Is there a way to build javadocs with NEWBUILD=true. I get the following :~/lambda$ make NEWBUILD=true javadocs cd common/makefiles && make -f MakefileJavadoc.gmk make[1]: Entering directory `lambda/common/makefiles' make[1]: MakefileJavadoc.gmk: No such file or directory make[1]: *** No rule to make target `MakefileJavadoc.gmk'. Stop. make[1]: Leaving directory `lambda/common/makefiles' make: *** [javadocs] Error 2 -- Tom Deneau From tim.bell at oracle.com Tue Jan 15 22:27:08 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 15 Jan 2013 14:27:08 -0800 Subject: javadocs with NEWBUILD In-Reply-To: References: Message-ID: <50F5D7BC.10700@oracle.com> On 01/15/13 14:17, Deneau, Tom wrote: > Is there a way to build javadocs with NEWBUILD=true. > I get the following > > :~/lambda$ make NEWBUILD=true javadocs > cd common/makefiles && make -f MakefileJavadoc.gmk > make[1]: Entering directory `lambda/common/makefiles' > make[1]: MakefileJavadoc.gmk: No such file or directory > make[1]: *** No rule to make target `MakefileJavadoc.gmk'. Stop. > make[1]: Leaving directory `lambda/common/makefiles' > make: *** [javadocs] Error 2 The correct target is "docs". The "javadocs" target will be removed from build-infra in the next integration. Refer to this email thread for more information: http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002917.html Hope this helps- Tim From mike.duigou at oracle.com Wed Jan 16 00:31:31 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 15 Jan 2013 16:31:31 -0800 Subject: MacOSX misrecognized as i386 by common/autoconf/build-aux/autoconf-config.guess? Message-ID: With my most recent pull of jdk8/jdk8 I am seeing a surprising error on MacOSX Lion: ./configure: configure: error: The tested number of bits in the target (64) differs from the number of bits expected to be found in the target (32) configure exiting with result code 1 Which seems to be due to: #bash common/autoconf/build-aux/autoconf-config.guess i386-apple-darwin11.4.2 Anyone else seen this? Why did it suddenly appear? Mike From mike.duigou at oracle.com Wed Jan 16 02:42:43 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 15 Jan 2013 18:42:43 -0800 Subject: False Alarm : MacOSX misrecognized as i386 by common/autoconf/build-aux/autoconf-config.guess? Message-ID: False alarm unless you, like me, use mac ports. The problem turned out to be caused by the mac ports version of 'file' (required by their port of subversion). For a unix executable foo it outputs foo: Mach-O 64-bit executable rather than the expected (by common/autoconf/build-aux/autoconf-config.guess) value: foo: Mach-O 64-bit executable x86_64 I've now put mac ports at the end of my command path. Be warned that it installs itself at the head of the command path so it's versions of commands will replace the MacOS built-in versions. Mike From erik.joelsson at oracle.com Wed Jan 16 11:12:03 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 16 Jan 2013 12:12:03 +0100 Subject: Review Request: 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server Message-ID: <50F68B03.7090500@oracle.com> Fix for the jre/lib/i386/server/libjsig.diz file which in build-infra contained the path to the file relative to the file system root instead of the directory of the file. http://cr.openjdk.java.net/~erikj/8006385/webrev.jdk.01/ From tim.bell at oracle.com Wed Jan 16 14:43:08 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 16 Jan 2013 06:43:08 -0800 Subject: Review Request: 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server In-Reply-To: <50F68B03.7090500@oracle.com> References: <50F68B03.7090500@oracle.com> Message-ID: <50F6BC7C.7070407@oracle.com> Hi Erik: > Fix for the jre/lib/i386/server/libjsig.diz file which in build-infra > contained the path to the file relative to the file system root > instead of the directory of the file. > > http://cr.openjdk.java.net/~erikj/8006385/webrev.jdk.01/ Looks good. Tim From erik.joelsson at oracle.com Wed Jan 16 15:41:20 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 16 Jan 2013 15:41:20 +0000 Subject: hg: jdk8/build/jdk: 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server Message-ID: <20130116154213.08CF0472E9@hg.openjdk.java.net> Changeset: 3eef1e0540c4 Author: erikj Date: 2013-01-16 16:40 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3eef1e0540c4 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server Reviewed-by: tbell ! makefiles/Import.gmk From kelly.ohair at oracle.com Wed Jan 16 17:04:36 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 16 Jan 2013 09:04:36 -0800 Subject: Review Request: 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server In-Reply-To: <50F68B03.7090500@oracle.com> References: <50F68B03.7090500@oracle.com> Message-ID: Looks ok. -kto On Jan 16, 2013, at 3:12 AM, Erik Joelsson wrote: > Fix for the jre/lib/i386/server/libjsig.diz file which in build-infra contained the path to the file relative to the file system root instead of the directory of the file. > > http://cr.openjdk.java.net/~erikj/8006385/webrev.jdk.01/ From mike.duigou at oracle.com Thu Jan 17 00:53:17 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 16 Jan 2013 16:53:17 -0800 Subject: Patch : improve common/bin/hgforest.sh python detection Message-ID: With the mac ports version of mercurial (wasn't I just complaining about another mac ports problems yesterday? ;-) ) the path to python in the mercurial launcher has is /opt/local/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python Note the capital "P" which is what was running afoul of the hgforest.sh detection. The following patch uses a different technique for checking the python executable. Mike PS:- I assume that the make/scripts/hgforest.sh is going away at some point? diff --git a/common/bin/hgforest.sh b/common/bin/hgforest.sh --- a/common/bin/hgforest.sh +++ b/common/bin/hgforest.sh @@ -51,7 +51,7 @@ bpython="`basename "$python"`" fi -if [ "python" = "$bpython" -a -x "$python" ] ; then +if [ -x "$python" -a ! -d "$python" -a "`${python} --version 2>&1 | cut -f 1 -d " "`" == "Python" ] ; then hg="${python} -u ${whichhg}" else echo Cannot find python from hg launcher. Running plain hg, which probably has buffered stdout. From david.katleman at oracle.com Thu Jan 17 06:28:19 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:28:19 +0000 Subject: hg: jdk8/build: 5 new changesets Message-ID: <20130117062819.E73A547349@hg.openjdk.java.net> Changeset: c37401e77c80 Author: mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl Changeset: b845a2494261 Author: lana Date: 2013-01-01 12:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/b845a2494261 Merge Changeset: 93b9664f97ee Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/93b9664f97ee Merge Changeset: 4090847a5444 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/4090847a5444 Added tag jdk8-b73 for changeset 93b9664f97ee ! .hgtags Changeset: dc84b505b408 Author: katleman Date: 2013-01-16 22:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/dc84b505b408 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl From david.katleman at oracle.com Thu Jan 17 06:28:23 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:28:23 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b73 for changeset 191afde59e7b Message-ID: <20130117062825.14BFE4734A@hg.openjdk.java.net> Changeset: 2132845cf5f7 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/2132845cf5f7 Added tag jdk8-b73 for changeset 191afde59e7b ! .hgtags From david.katleman at oracle.com Thu Jan 17 06:30:05 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:30:05 +0000 Subject: hg: jdk8/build/hotspot: 39 new changesets Message-ID: <20130117063123.131C84734C@hg.openjdk.java.net> Changeset: cd962e15c08e Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cd962e15c08e 8005382: new hotspot build - hs25-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e51c9860cf66 Author: jmasa Date: 2012-12-03 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e51c9860cf66 8005082: NPG: Add specialized Metachunk sizes for reflection and anonymous classloaders Reviewed-by: johnc, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/globals.hpp Changeset: 1de1b145f6bc Author: jmasa Date: 2012-12-26 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1de1b145f6bc 8005486: NPG: Incorrect assertion in ChunkManager::list_index() Reviewed-by: coleenp ! src/share/vm/memory/metaspace.cpp Changeset: b735136e0d82 Author: johnc Date: 2013-01-02 11:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b735136e0d82 8004132: SerialGC: ValidateMarkSweep broken when running GCOld Summary: Remove bit-rotten ValidateMarkSweep functionality and flag. Reviewed-by: johnc, jmasa Contributed-by: tamao ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/debug.cpp Changeset: 37f7535e5f18 Author: johnc Date: 2012-12-21 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/37f7535e5f18 8001424: G1: Rename certain G1-specific flags Summary: Rename G1DefaultMinNewGenPercent, G1DefaultMaxNewGenPercent, and G1OldCSetRegionLiveThresholdPercent to G1NewSizePercent, G1MaxNewSizePercent, and G1MixedGCLiveThresholdPercent respectively. The previous names are no longer accepted. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d275c3dc73e6 Author: johnc Date: 2013-01-03 16:28 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d275c3dc73e6 8004816: G1: Kitchensink failures after marking stack changes Summary: Reset the marking state, including the mark stack overflow flag, in the event of a marking stack overflow during serial reference processing. Reviewed-by: jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: ca0a78017dc7 Author: brutisso Date: 2012-12-30 08:47 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ca0a78017dc7 8005396: Use ParNew with only one thread instead of DefNew as default for CMS on single CPU machines Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/runtime/arguments.cpp Changeset: e0ab18eafbde Author: brutisso Date: 2013-01-04 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e0ab18eafbde 8003820: Deprecate untested and rarely used GC combinations Summary: Log warning messages for DefNew+CMS and ParNew+SerialOld Reviewed-by: ysr, jwilhelm, jcoomes ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: c98b676a98b4 Author: brutisso Date: 2013-01-04 21:33 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c98b676a98b4 8003822: Deprecate the incremental mode of CMS Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp Changeset: 6e9174173e00 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6e9174173e00 8000325: Change default for CMSClassUnloadingEnabled to true Reviewed-by: stefank, ysr ! src/share/vm/runtime/globals.hpp Changeset: 0b54ffe4c2d3 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0b54ffe4c2d3 8005672: Clean up some changes to GC logging with GCCause's Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 7d42f3b08300 Author: dcubed Date: 2012-12-19 10:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7d42f3b08300 8005044: remove crufty '_g' support from HS runtime code Summary: Phase 2 is removing '_g' support from the Runtime code. Reviewed-by: dcubed, coleenp, hseigel Contributed-by: ron.durbin at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/vm/runtime/arguments.cpp Changeset: 35431a769282 Author: stefank Date: 2012-12-20 10:22 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/35431a769282 8004823: Add VM support for type annotation reflection Reviewed-by: dholmes, coleenp Contributed-by: joel.franck at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflection.cpp Changeset: 4daebd4cc1dd Author: minqi Date: 2012-12-24 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4daebd4cc1dd Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/arguments.cpp Changeset: cc6a617fffd2 Author: coleenp Date: 2013-01-02 20:28 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cc6a617fffd2 8005494: SIGSEGV in Rewriter::relocate_and_link() when testing Weblogic with CompressedOops and KlassPtrs Summary: Relocate functions with jsr's when rewriting so not repeated after reading shared archive Reviewed-by: twisti, jrose ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/handles.inline.hpp Changeset: 6c3f47d964f3 Author: hseigel Date: 2013-01-07 15:32 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6c3f47d964f3 8003705: CDS failed on Windows: can not map in the CDS. Summary: Map memory only once to prevent 'already mapped' failures. Reviewed-by: acorn, zgu ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 561148896559 Author: hseigel Date: 2013-01-08 13:38 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/561148896559 8005076: Creating a CDS archive with one alignment and running another causes a crash. Summary: Save the alignment when writing the CDS and compare it when reading the CDS. Reviewed-by: kvn, coleenp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ade95d680b42 Author: coleenp Date: 2013-01-08 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ade95d680b42 8004728: Add hotspot support for parameter reflection Summary: Add hotspot support for parameter reflection Reviewed-by: acorn, jrose, coleenp Contributed-by: eric.mccorkle at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileStream.cpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp Changeset: 185a2c979a0e Author: coleenp Date: 2013-01-08 13:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/185a2c979a0e Merge Changeset: ecd24264898b Author: zgu Date: 2013-01-08 14:04 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ecd24264898b 8005048: NMT: #loaded classes needs to just show the # defined classes Summary: Count number of instance classes so that it matches class metadata size Reviewed-by: coleenp, acorn ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: 37a3e8b7a1e9 Author: zgu Date: 2013-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/37a3e8b7a1e9 Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 0c93d4818214 Author: zgu Date: 2013-01-08 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0c93d4818214 Merge Changeset: 1f6d10b4cc0c Author: acorn Date: 2013-01-09 18:06 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1f6d10b4cc0c Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 608b2e8a0063 Author: bpittore Date: 2013-01-03 15:08 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/608b2e8a0063 8004051: assert(_oprs_len[mode] < maxNumberOfOperands) failed: array overflow Summary: assert is triggered when number of register based arguments passed to a java method exceeds 16. Reviewed-by: roland, vladidan ! src/share/vm/c1/c1_LIR.hpp Changeset: 0c8717a92b2d Author: jiangli Date: 2013-01-08 13:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0c8717a92b2d 8001341: SIGSEGV in methodOopDesc::fast_exception_handler_bci_for(KlassHandle,int,Thread*)+0x3e9. Summary: Use methodHandle. Reviewed-by: coleenp, acorn, twisti, sspitsyn ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 18c3c3fa291b Author: dlong Date: 2013-01-09 21:18 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/18c3c3fa291b Merge ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 4c8bf5e55392 Author: brutisso Date: 2013-01-09 09:48 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4c8bf5e55392 8005489: VM hangs during GC with ParallelGC and ParallelGCThreads=0 Summary: Print an error message and exit the VM if UseParallalGC is combined with ParllelGCThreads==0. Also reviewed by vitalyd at gmail.com. Reviewed-by: stefank, ehelin ! src/share/vm/runtime/arguments.cpp Changeset: b2fef6b220e9 Author: jmasa Date: 2013-01-10 07:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b2fef6b220e9 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d092d1b31229 Author: roland Date: 2012-12-23 17:08 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d092d1b31229 8005071: Incremental inlining for JSR 292 Summary: post parse inlining driven by number of live nodes. Reviewed-by: twisti, kvn, jrose ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 00af3a3a8df4 Author: kvn Date: 2013-01-03 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/00af3a3a8df4 8005522: use fast-string instructions on x86 for zeroing Summary: use 'rep stosb' instead of 'rep stosq' when fast-string operations are available. Reviewed-by: twisti, roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/memnode.cpp Changeset: e2e6bf86682c Author: kvn Date: 2013-01-03 16:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e2e6bf86682c 8005544: Use 256bit YMM registers in arraycopy stubs on x86 Summary: Use YMM registers in arraycopy and array_fill stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: ffa87474d7a4 Author: twisti Date: 2013-01-07 14:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ffa87474d7a4 8004537: replace AbstractAssembler emit_long with emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 038dd2875b94 Author: kvn Date: 2013-01-08 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/038dd2875b94 8005419: Improve intrinsics code performance on x86 by using AVX2 Summary: use 256bit vpxor,vptest instructions in String.compareTo() and equals() intrinsics. Reviewed-by: twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp + test/compiler/8005419/Test8005419.java Changeset: 5698813d45eb Author: twisti Date: 2013-01-09 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5698813d45eb 8005418: JSR 292: virtual dispatch bug in 292 impl Reviewed-by: jrose, kvn ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp Changeset: f1c06dcee0b5 Author: kvn Date: 2013-01-10 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f1c06dcee0b5 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 1e129851479e Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1e129851479e Merge Changeset: b5e6bec76f4a Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b5e6bec76f4a Added tag hs25-b15 for changeset 1e129851479e ! .hgtags Changeset: 41ccb2e737fb Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/41ccb2e737fb Added tag jdk8-b73 for changeset 11619f33cd68 ! .hgtags Changeset: 1a3e54283c54 Author: katleman Date: 2013-01-16 20:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a3e54283c54 Merge ! .hgtags From david.katleman at oracle.com Thu Jan 17 06:32:34 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:32:34 +0000 Subject: hg: jdk8/build/jaxp: 2 new changesets Message-ID: <20130117063241.B6B634734D@hg.openjdk.java.net> Changeset: cf0917c0d771 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/cf0917c0d771 Added tag jdk8-b73 for changeset 84946404d1e1 ! .hgtags Changeset: 2087e24a4357 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/2087e24a4357 Merge From david.katleman at oracle.com Thu Jan 17 06:32:45 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:32:45 +0000 Subject: hg: jdk8/build/jaxws: 2 new changesets Message-ID: <20130117063251.61DB84734E@hg.openjdk.java.net> Changeset: 68f508979ffe Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/68f508979ffe Added tag jdk8-b73 for changeset c606f644a5d9 ! .hgtags Changeset: 12db3c5a3393 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/12db3c5a3393 Merge From david.katleman at oracle.com Thu Jan 17 06:34:12 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:34:12 +0000 Subject: hg: jdk8/build/jdk: 32 new changesets Message-ID: <20130117064157.E5A764734F@hg.openjdk.java.net> Changeset: d54922883f4c Author: alexsch Date: 2013-01-09 16:52 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d54922883f4c 8005019: JTable passes row index instead of length when inserts selection interval Reviewed-by: serb, denis ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/8005019/bug8005019.java Changeset: b2c425d7e5be Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b2c425d7e5be Merge Changeset: 28b47ed08c63 Author: mchung Date: 2012-12-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/28b47ed08c63 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk Changeset: 3cc25d0e3bb0 Author: chegar Date: 2012-12-29 11:00 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3cc25d0e3bb0 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Reviewed-by: alanb ! test/java/net/Socks/SocksV4Test.java Changeset: 38b9a7646093 Author: lana Date: 2013-01-01 17:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/38b9a7646093 Merge ! makefiles/CreateJars.gmk Changeset: cc78ceb99284 Author: jgish Date: 2012-12-28 16:56 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cc78ceb99284 8005118: Javadoc styles are inconsistent Summary: use a common javadoc style in the String classes Reviewed-by: darcy ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java ! src/share/classes/java/lang/StringIndexOutOfBoundsException.java Changeset: 21708d15553b Author: chegar Date: 2013-01-03 10:00 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/21708d15553b 8005634: tools/launcher/VersionCheck.java fails version check on jdeps Summary: add jdeps to the list of tools that do not support '-version' Reviewed-by: mchung ! test/tools/launcher/VersionCheck.java Changeset: 438d37d16417 Author: chegar Date: 2013-01-04 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/438d37d16417 8005659: Add tools/pack200/AttributeTests.java to exclude list (ProblemList.txt) until pack200 updated to support method parameters Reviewed-by: mchung, ksrini ! test/ProblemList.txt Changeset: 6d814b2f9112 Author: chegar Date: 2013-01-04 11:34 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6d814b2f9112 8005638: Less secure Authentication schemes should work when more secure schemes are not available Reviewed-by: alanb ! src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java Changeset: 92c3b24a8e9a Author: smarks Date: 2013-01-04 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/92c3b24a8e9a 8005683: ProblemList.txt updates (01/2013) Reviewed-by: mchung, alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 0c89465b656a Author: chegar Date: 2013-01-05 17:06 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0c89465b656a 8005709: Add at since tags to new FJP getCommonPoolParallelism and commonPool Reviewed-by: dl ! src/share/classes/java/util/concurrent/ForkJoinPool.java Changeset: 1d9638ba5202 Author: ksrini Date: 2013-01-07 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1d9638ba5202 8004547: Extend JavaFX launcher support to allow full JavaFX launch feature set Reviewed-by: mchung, kcr, ksrini Contributed-by: david.dehaven at oracle.com ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/FXLauncherTest.java Changeset: dbc692ea3f0a Author: bchristi Date: 2013-01-07 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dbc692ea3f0a 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] Summary: Hard-code sun.jnu.encoding to UTF-8 on Mac Reviewed-by: naoto ! src/share/native/java/lang/System.c ! src/solaris/native/java/lang/java_props_md.c + test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java + test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 797e8a3dcd51 Author: smarks Date: 2013-01-07 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/797e8a3dcd51 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently Summary: Tighten up JavaVM test library API, and adjust tests to match. Reviewed-by: mchung, dmocek ! test/ProblemList.txt ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/sun/rmi/runtime/Log/4504153/Test4504153.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java Changeset: 98935c514de4 Author: weijun Date: 2013-01-08 14:54 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/98935c514de4 8005447: default principal should act as anyone Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/InitSecContextToken.java ! src/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5MechFactory.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + src/share/classes/sun/security/jgss/krb5/ServiceCreds.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/krb5/KrbApReq.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java + test/sun/security/krb5/ServiceCredsCombination.java + test/sun/security/krb5/auto/AcceptPermissions.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/DiffNameSameKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/KeyTabCompat.java + test/sun/security/krb5/auto/TwoOrThree.java Changeset: d29a7ce28189 Author: dxu Date: 2013-01-08 20:37 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d29a7ce28189 8002306: (se) Selector.open fails if invoked with thread interrupt status set [win] Reviewed-by: alanb ! src/windows/classes/sun/nio/ch/PipeImpl.java + test/java/nio/channels/Pipe/PipeInterrupt.java Changeset: 46e6a4b7ca26 Author: valeriep Date: 2013-01-07 11:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/46e6a4b7ca26 6996769: support AEAD cipher Summary: Added implementation for GCM mode under AES cipher Reviewed-by: weijun ! src/share/classes/com/sun/crypto/provider/AESCipher.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/CipherTextStealing.java ! src/share/classes/com/sun/crypto/provider/FeedbackCipher.java + src/share/classes/com/sun/crypto/provider/GCMParameters.java + src/share/classes/com/sun/crypto/provider/GCTR.java + src/share/classes/com/sun/crypto/provider/GHASH.java + src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/spec/GCMParameterSpec.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512524.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512704.java ! test/com/sun/crypto/provider/Cipher/AES/Test4517355.java ! test/com/sun/crypto/provider/Cipher/AES/Test4626070.java + test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java + test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java ! test/javax/crypto/Cipher/GCMAPI.java Changeset: 5333a4c8cade Author: valeriep Date: 2013-01-07 14:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5333a4c8cade Merge Changeset: 3c5a62290939 Author: valeriep Date: 2013-01-08 11:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c5a62290939 8004044: Lazily instantiate SunJCE.RANDOM Summary: Replace the static initialization of SunJCE.RANDOM object w/ lazy initialization Reviewed-by: mchung ! src/share/classes/com/sun/crypto/provider/AESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/BlowfishKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacMD5KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/ISO10126Padding.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java Changeset: 9b6a29cb04ac Author: valeriep Date: 2013-01-08 13:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9b6a29cb04ac Merge Changeset: ac5fd681a7a2 Author: darcy Date: 2013-01-08 16:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac5fd681a7a2 8005298: Add FunctionalInterface type to the core libraries Reviewed-by: mduigou + src/share/classes/java/lang/FunctionalInterface.java Changeset: 86828e84654f Author: mullan Date: 2013-01-08 19:00 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/86828e84654f 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Summary: Add new java.security.Principal.implies method Reviewed-by: alanb ! src/share/classes/java/security/Principal.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/PolicyParser.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java + test/java/security/Principal/Implies.java ! test/sun/security/provider/PolicyFile/Comparator.java Changeset: bf6d0bca5ea7 Author: mullan Date: 2013-01-08 19:02 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bf6d0bca5ea7 Merge - make/jdk/asm/Makefile - src/share/classes/sun/awt/TextureSizeConstraining.java - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: f0ed9ef84637 Author: mullan Date: 2013-01-09 08:59 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f0ed9ef84637 Merge Changeset: 4c8b37f159f9 Author: mchung Date: 2013-01-09 16:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4c8b37f159f9 7103957: NegativeArraySizeException while initializing class IntegerCache Reviewed-by: darcy, mchung Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/lang/Integer.java Changeset: 4176e6cc499e Author: darcy Date: 2013-01-09 20:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4176e6cc499e 8005713: Simplify library support for repeating annotations in java.lang.annotation Reviewed-by: abuckley + src/share/classes/java/lang/annotation/Repeatable.java Changeset: c622df692bfb Author: bchristi Date: 2013-01-10 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c622df692bfb 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments Summary: Test script now sets LC_ALL, other small changes, relocate test Reviewed-by: naoto, alanb + test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java + test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 13ff1089e625 Author: jgish Date: 2013-01-10 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/13ff1089e625 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup Reviewed-by: chegar ! test/java/lang/Runtime/exec/WinCommand.java Changeset: 3e906ccad412 Author: chegar Date: 2013-01-10 21:52 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3e906ccad412 8006007: j.u.c.atomic classes should use intrinsic getAndXXX provided by 7023898 Reviewed-by: dl, shade ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: 733885f57e14 Author: lana Date: 2013-01-10 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/733885f57e14 Merge Changeset: 965e89e2abd3 Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/965e89e2abd3 Added tag jdk8-b73 for changeset 733885f57e14 ! .hgtags Changeset: 54bbeb149525 Author: katleman Date: 2013-01-16 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/54bbeb149525 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! src/share/classes/java/lang/Integer.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java From david.katleman at oracle.com Thu Jan 17 06:43:53 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 Jan 2013 06:43:53 +0000 Subject: hg: jdk8/build/langtools: 17 new changesets Message-ID: <20130117064437.DB74B47350@hg.openjdk.java.net> Changeset: 0c244701188e Author: mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtools.gmk ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java + src/share/classes/com/sun/tools/jdeps/Archive.java + src/share/classes/com/sun/tools/jdeps/ClassFileReader.java + src/share/classes/com/sun/tools/jdeps/JdepsTask.java + src/share/classes/com/sun/tools/jdeps/Main.java + src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + src/share/classes/com/sun/tools/jdeps/resources/jdk.properties + src/share/classes/com/sun/tools/jdeps/resources/version.properties-template ! test/Makefile + test/tools/jdeps/Basic.java + test/tools/jdeps/Test.java + test/tools/jdeps/p/Foo.java Changeset: 31780dd06ec7 Author: jjg Date: 2012-12-29 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/31780dd06ec7 8004727: Add compiler support for parameter reflection Reviewed-by: jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javac/MethodParameters.java + test/tools/javap/MethodParameters.java Changeset: 383bc0fbd759 Author: jjg Date: 2012-12-30 06:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/383bc0fbd759 8005195: Doclint regression tests fail on windows Reviewed-by: mcimadamore ! test/tools/doclint/DocLintTester.java Changeset: 1d8438db45f2 Author: lana Date: 2013-01-01 17:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1d8438db45f2 Merge Changeset: 0e17c3c23e3b Author: bpatel Date: 2013-01-04 23:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/0e17c3c23e3b 8004891: Check for abstract method in javadoc does not conform to the language model Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java + test/com/sun/javadoc/testAbstractMethod/TestAbstractMethod.java + test/com/sun/javadoc/testAbstractMethod/pkg/A.java + test/com/sun/javadoc/testAbstractMethod/pkg/B.java + test/com/sun/javadoc/testAbstractMethod/pkg/C.java Changeset: 8c0c63a6e3b7 Author: bpatel Date: 2013-01-05 00:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8c0c63a6e3b7 8005092: javadoc should check for synthesized bit on an annotation Reviewed-by: jjg ! src/share/classes/com/sun/javadoc/AnnotationDesc.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java + test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/D.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/NonSynthDocContainer.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegArryDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValNotDoc.java Changeset: a9cb93cca229 Author: jjh Date: 2013-01-07 17:51 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a9cb93cca229 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows Summary: Fix javap to not output \r\r\n Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! test/tools/javac/MethodParameters.java ! test/tools/javap/MethodParameters.java Changeset: 38d3d1027f5a Author: mcimadamore Date: 2013-01-08 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/38d3d1027f5a 8005243: Restructure method check code to allow pluggable checkers Summary: Add interface to perform a method check - to be implemented by helper classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: db91d860156a Author: mcimadamore Date: 2013-01-08 10:16 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/db91d860156a 8005179: Cleanup Resolve.AmbiguityError Summary: Linearize nested ambiguity errors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out Changeset: d07340b61e6a Author: mcimadamore Date: 2013-01-08 10:17 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d07340b61e6a 8005184: Restructure DeferredAttr to allow pluggable deferred type completers Summary: Add hooks to generalize deferred type completion via custom helper objects Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java Changeset: 954541f13717 Author: vromero Date: 2013-01-08 13:47 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/954541f13717 8005167: execution time of combo tests in javac should be improved Reviewed-by: jjg, jjh ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java + test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: d2eb08b3f64f Author: jjg Date: 2013-01-09 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d2eb08b3f64f 8005644: set default max errs and max warns Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/Messager.java + test/tools/javadoc/MaxWarns.java Changeset: 7612fe48be90 Author: darcy Date: 2013-01-09 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7612fe48be90 8004730: Add language model support for parameter reflection Reviewed-by: abuckley ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/VariableElement.java ! src/share/classes/javax/lang/model/element/package-info.java Changeset: d462da465da6 Author: jjg Date: 2013-01-10 14:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d462da465da6 8006037: extra space in javac -help for -J and @ options Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java + test/tools/javac/main/Option_J_At_Test.java Changeset: 7d2f628f04f1 Author: jjg Date: 2013-01-10 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7d2f628f04f1 8006033: bug in Pretty.toSimpleString Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/PrettySimpleStringTest.java Changeset: 8d0baee36c71 Author: lana Date: 2013-01-10 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8d0baee36c71 Merge Changeset: 56c97aff46bb Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/56c97aff46bb Added tag jdk8-b73 for changeset 8d0baee36c71 ! .hgtags From yong.huang at oracle.com Thu Jan 17 09:33:28 2013 From: yong.huang at oracle.com (yong.huang at oracle.com) Date: Thu, 17 Jan 2013 09:33:28 +0000 Subject: hg: jdk8/build/jdk: 4 new changesets Message-ID: <20130117093425.8A3D747357@hg.openjdk.java.net> Changeset: 6d849e883c40 Author: yhuang Date: 2013-01-13 18:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6d849e883c40 7114053: [sq] Inproper tanslation for iso lanugage of Albanian Reviewed-by: naoto ! src/share/classes/sun/util/resources/sq/LocaleNames_sq.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 2de23975ee10 Author: yhuang Date: 2013-01-15 19:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2de23975ee10 Merge Changeset: 68fc838d5e89 Author: yhuang Date: 2013-01-16 19:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/68fc838d5e89 Merge Changeset: 595baf3cc781 Author: yhuang Date: 2013-01-16 23:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/595baf3cc781 Merge From david.holmes at oracle.com Thu Jan 17 11:22:54 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 17 Jan 2013 21:22:54 +1000 Subject: Patch : improve common/bin/hgforest.sh python detection In-Reply-To: References: Message-ID: <50F7DF0E.8010107@oracle.com> On 17/01/2013 10:53 AM, Mike Duigou wrote: > With the mac ports version of mercurial (wasn't I just complaining about another mac ports problems yesterday? ;-) ) the path to python in the mercurial launcher has is > > /opt/local/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python > > Note the capital "P" which is what was running afoul of the hgforest.sh detection. The following patch uses a different technique for checking the python executable. > > Mike > > PS:- I assume that the make/scripts/hgforest.sh is going away at some point? Why? What would replace it? David > diff --git a/common/bin/hgforest.sh b/common/bin/hgforest.sh > --- a/common/bin/hgforest.sh > +++ b/common/bin/hgforest.sh > @@ -51,7 +51,7 @@ > bpython="`basename "$python"`" > fi > > -if [ "python" = "$bpython" -a -x "$python" ] ; then > +if [ -x "$python" -a ! -d "$python" -a "`${python} --version 2>&1 | cut -f 1 -d " "`" == "Python" ] ; then > hg="${python} -u ${whichhg}" > else > echo Cannot find python from hg launcher. Running plain hg, which probably has buffered stdout. > From erik.joelsson at oracle.com Thu Jan 17 11:27:12 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 17 Jan 2013 12:27:12 +0100 Subject: Patch : improve common/bin/hgforest.sh python detection In-Reply-To: <50F7DF0E.8010107@oracle.com> References: <50F7DF0E.8010107@oracle.com> Message-ID: <50F7E010.7030400@oracle.com> On 2013-01-17 12:22, David Holmes wrote: > On 17/01/2013 10:53 AM, Mike Duigou wrote: >> With the mac ports version of mercurial (wasn't I just complaining >> about another mac ports problems yesterday? ;-) ) the path to python >> in the mercurial launcher has is >> >> /opt/local/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python >> >> >> Note the capital "P" which is what was running afoul of the >> hgforest.sh detection. The following patch uses a different technique >> for checking the python executable. >> >> Mike >> >> PS:- I assume that the make/scripts/hgforest.sh is going away at some >> point? > > Why? What would replace it? > > David common/bin/hgforest.sh was added a while back. /Erik > >> diff --git a/common/bin/hgforest.sh b/common/bin/hgforest.sh >> --- a/common/bin/hgforest.sh >> +++ b/common/bin/hgforest.sh >> @@ -51,7 +51,7 @@ >> bpython="`basename "$python"`" >> fi >> >> -if [ "python" = "$bpython" -a -x "$python" ] ; then >> +if [ -x "$python" -a ! -d "$python" -a "`${python} --version 2>&1 | >> cut -f 1 -d " "`" == "Python" ] ; then >> hg="${python} -u ${whichhg}" >> else >> echo Cannot find python from hg launcher. Running plain hg, which >> probably has buffered stdout. >> From erik.joelsson at oracle.com Thu Jan 17 14:09:36 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 17 Jan 2013 15:09:36 +0100 Subject: Review Request: 8006520: build-infra: Fix sparkle-framework configure parameter Message-ID: <50F80620.9010900@oracle.com> Adding sparkle-framework to bridgeBuild. http://cr.openjdk.java.net/~erikj/8006520/webrev.root.01/ /Erik From tim.bell at oracle.com Thu Jan 17 14:39:29 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 17 Jan 2013 06:39:29 -0800 Subject: Review Request: 8006520: build-infra: Fix sparkle-framework configure parameter In-Reply-To: <50F80620.9010900@oracle.com> References: <50F80620.9010900@oracle.com> Message-ID: <50F80D21.3080706@oracle.com> Erik: > Adding sparkle-framework to bridgeBuild. > > http://cr.openjdk.java.net/~erikj/8006520/webrev.root.01/ Looks good. Tim From kelly.ohair at oracle.com Thu Jan 17 19:37:56 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 17 Jan 2013 11:37:56 -0800 Subject: Review Request: 8006520: build-infra: Fix sparkle-framework configure parameter In-Reply-To: <50F80620.9010900@oracle.com> References: <50F80620.9010900@oracle.com> Message-ID: <98DFB77F-3AD2-4F09-9CFD-E38796DF4163@oracle.com> Looks good. -kto On Jan 17, 2013, at 6:09 AM, Erik Joelsson wrote: > Adding sparkle-framework to bridgeBuild. > > http://cr.openjdk.java.net/~erikj/8006520/webrev.root.01/ > > /Erik From kelly.ohair at oracle.com Thu Jan 17 21:45:07 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 17 Jan 2013 13:45:07 -0800 Subject: Patch : improve common/bin/hgforest.sh python detection In-Reply-To: <50F7E010.7030400@oracle.com> References: <50F7DF0E.8010107@oracle.com> <50F7E010.7030400@oracle.com> Message-ID: <26C4043A-CC3E-4EF0-B41F-74479D790760@oracle.com> On Jan 17, 2013, at 3:27 AM, Erik Joelsson wrote: >>> >>> PS:- I assume that the make/scripts/hgforest.sh is going away at some point? >> >> Why? What would replace it? >> >> David > common/bin/hgforest.sh was added a while back. Yes, the intention is to replace it, but it's just low on our priority list right now. -kto From weijun.wang at oracle.com Fri Jan 18 02:07:47 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 18 Jan 2013 10:07:47 +0800 Subject: --enable-sjavac not enabled in tl repo yet? Message-ID: <50F8AE73.8000809@oracle.com> Just tried on a latest jdk8/tl clone and Building Java(TM) for target 'all' in configuration '/space/repos/jdk8/tl/build/linux-x86_64-sjavac' ## Starting langtools Compiling 2 files for BUILD_TOOLS Compiling 26 properties into resource bundles Compiling 720 files for BUILD_BOOTSTRAP_LANGTOOLS Creating langtools/dist/bootstrap/lib/javac.jar Updating langtools/dist/lib/src.zip Creating langtools/dist/bootstrap/lib/javah.jar Creating langtools/dist/bootstrap/lib/javap.jar Compiling BUILD_FULL_JAVAC Creating langtools/dist/bootstrap/lib/javadoc.jar The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac wrapper! make[1]: *** [/space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/classes/javac_state] Error 255 make[1]: *** Waiting for unfinished jobs.... make: *** [langtools-only] Error 2 Thanks Max From jonathan.gibbons at oracle.com Fri Jan 18 02:49:46 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 17 Jan 2013 18:49:46 -0800 Subject: --enable-sjavac not enabled in tl repo yet? In-Reply-To: <50F8AE73.8000809@oracle.com> References: <50F8AE73.8000809@oracle.com> Message-ID: <50F8B84A.4000800@oracle.com> Anyone else having trouble deciphering the error message: The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac wrapper! -- Jon On 01/17/2013 06:07 PM, Weijun Wang wrote: > Just tried on a latest jdk8/tl clone and > > Building Java(TM) for target 'all' in configuration > '/space/repos/jdk8/tl/build/linux-x86_64-sjavac' > > ## Starting langtools > Compiling 2 files for BUILD_TOOLS > Compiling 26 properties into resource bundles > Compiling 720 files for BUILD_BOOTSTRAP_LANGTOOLS > Creating langtools/dist/bootstrap/lib/javac.jar > Updating langtools/dist/lib/src.zip > Creating langtools/dist/bootstrap/lib/javah.jar > Creating langtools/dist/bootstrap/lib/javap.jar > Compiling BUILD_FULL_JAVAC > Creating langtools/dist/bootstrap/lib/javadoc.jar > The makefile listed source > /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java > was not calculated by the smart javac wrapper! > make[1]: *** > [/space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/classes/javac_state] > Error 255 > make[1]: *** Waiting for unfinished jobs.... > make: *** [langtools-only] Error 2 > > Thanks > Max From fredrik.ohrstrom at oracle.com Fri Jan 18 06:58:39 2013 From: fredrik.ohrstrom at oracle.com (=?iso-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Fri, 18 Jan 2013 07:58:39 +0100 Subject: --enable-sjavac not enabled in tl repo yet? In-Reply-To: <50F8AE73.8000809@oracle.com> References: <50F8AE73.8000809@oracle.com> Message-ID: <88BFD301-5CC2-4878-8185-44C55F7639BF@oracle.com> 18 jan 2013 kl. 03:07 skrev Weijun Wang: > Just tried on a latest jdk8/tl clone and > The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac Ok, as the old saying goes, this works for me.... :-) So could you please tar up your build directory and email it to me? As for the error message, since the build system has to handle building with javac as well as with sjavac, the logic for finding which java files to compile, is implemented both in make and in java (sjavac). Sjavac has the option: --compare-found-sources file_with_list_of_files which is used to make sjavac compare its own calculated list of source files with the list supplied by make. If they differ, you will get the error message > was not calculated by the smart javac So why do we need to calculate the files to be compiled? Is it not just compiling the required source roots? For example like this? sjavac src/share/classes src/posix/classes src/linux/classes -d bin Lets say, that we have an opportunity to organize the source in this way. At the moment for example, when build the OpenJDK the snmp classes have to be excluded, thus the compile command looks more like: sjavac -x sun.management.snmp.* src/share/classes -d bin (In make the same calculation is handled by find and grep and sed et al.) The full filtering rules for compiling the main jdk looks like this: sjavac -x com.sun.pept.* -x com.sun.tools.example.trace.* -x com.sun.tools.example.debug.bdi.* -x com.sun.tools.example.debug.event.* -x com.sun.tools.example.debug.gui.* -x sun.dc.* -x com.sun.jmx.snmp.* -x sun.management.snmp.* -x com.sun.script.* -x com.oracle.security.* -x sun.java2d.cmm.kcms.* -xf *SolarisAclFileAttributeView.java -xf *SolarisFileStore.java -xf *SolarisFileSystem.java -xf *SolarisFileSystemProvider.java -xf *SolarisNativeDispatcher.java -xf *SolarisUserDefinedFileAttributeView.java -xf *SolarisWatchService.java -xf *SolarisAclFileAttributeView.java -xf *SolarisLoginModule.java -xf *SolarisSystem.java -xf *sun/nio/ch/DevPollArrayWrapper.java -xf *sun/nio/ch/DevPollSelectorImpl.java -xf *sun/nio/ch/DevPollSelectorProvider.java -xf *sun/nio/ch/EventPortSelectorImpl.java -xf *sun/nio/ch/EventPortSelectorProvider.java -xf *sun/nio/ch/EventPortWrapper.java -xf *sun/nio/ch/SolarisAsynchronousChannelProvider.java -xf *sun/nio/ch/SolarisEventPort.java -xf *sun/tools/attach/SolarisAttachProvider.java -xf *sun/tools/attach/SolarisVirtualMachine.java -xf *WrapperGenerator.java -xf *NTLoginModule.java -xf *NTSystem.java -xf *sun/nio/ch/BsdAsynchronousChannelProvider.java -xf *sun/nio/ch/KQueue.java -xf *sun/nio/ch/KQueuePort.java -xf *sun/nio/fs/BsdFileStore.java -xf *sun/nio/fs/BsdFileSystem.java -xf *sun/nio/fs/BsdFileSystemProvider.java -xf *sun/nio/fs/BsdNativeDispatcher.java -xf *sun/nio/fs/MacOSXFileSystemProvider.java -xf *sun/nio/fs/MacOSXFileSystem.java -xf *sun/nio/fs/MacOSXNativeDispatcher.java -xf *sun/tools/attach/BsdAttachProvider.java -xf *sun/tools/attach/BsdVirtualMachine.java -xf *sun/text/resources/BreakIteratorRules.java -xf *sun/text/resources/BreakIteratorRules_th.java -xf *sun/awt/AWTCharset.java -xf *sun/awt/X11/ScreenFormat.java -xf *sun/awt/X11/XArc.java -xf *sun/awt/X11/XChar2b.java -xf *sun/awt/X11/XCharStruct.java -xf *sun/awt/X11/XClassHint.java -xf *sun/awt/X11/XComposeStatus.java -xf *sun/awt/X11/XExtCodes.java -xf *sun/awt/X11/XFontProp.java -xf *sun/awt/X11/XFontSetExtents.java -xf *sun/awt/X11/XFontStruct.java -xf *sun/awt/X11/XGCValues.java -xf *sun/awt/X11/XHostAddress.java -xf *sun/awt/X11/XIMCallback.java -xf *sun/awt/X11/XIMHotKeyTrigger.java -xf *sun/awt/X11/XIMHotKeyTriggers.java -xf *sun/awt/X11/XIMPreeditCaretCallbackStruct.java -xf *sun/awt/X11/XIMPreeditDrawCallbackStruct.java -xf *sun/awt/X11/XIMPreeditStateNotifyCallbackStruct.java -xf *sun/awt/X11/XIMStatusDrawCallbackStruct.java -xf *sun/awt/X11/XIMStringConversionCallbackStruct.java -xf *sun/awt/X11/XIMStringConversionText.java -xf *sun/awt/X11/XIMStyles.java -xf *sun/awt/X11/XIMText.java -xf *sun/awt/X11/XIMValuesList.java -xf *sun/awt/X11/XImage.java -xf *sun/awt/X11/XKeyboardControl.java -xf *sun/awt/X11/XKeyboardState.java -xf *sun/awt/X11/XOMCharSetList.java -xf *sun/awt/X11/XOMFontInfo.java -xf *sun/awt/X11/XOMOrientation.java -xf *sun/awt/X11/XPoint.java -xf *sun/awt/X11/XRectangle.java -xf *sun/awt/X11/XSegment.java -xf *sun/awt/X11/XStandardColormap.java -xf *sun/awt/X11/XTextItem.java -xf *sun/awt/X11/XTextItem16.java -xf *sun/awt/X11/XTextProperty.java -xf *sun/awt/X11/XTimeCoord.java -xf *sun/awt/X11/XWindowChanges.java -xf *sun/awt/X11/XdbeSwapInfo.java -xf *sun/awt/X11/XmbTextItem.java -xf *sun/awt/X11/XwcTextItem.java -xf *sun/util/locale/AsciiUtil.java -xf *sun/nio/fs/PollingWatchService.java -xf *-linux-arm.java -xf *-linux-ppc.java -xf *javax/swing/plaf/nimbus/InternalFrameTitlePanePainter.java -xf *javax/swing/plaf/nimbus/OptionPaneMessageAreaPainter.java -xf *javax/swing/plaf/nimbus/ScrollBarPainter.java -xf *javax/swing/plaf/nimbus/SliderPainter.java -xf *javax/swing/plaf/nimbus/SpinnerPainter.java -xf *javax/swing/plaf/nimbus/SplitPanePainter.java -xf *javax/swing/plaf/nimbus/TabbedPanePainter.java -src "/home/fohrstro/jdk8/jdk/src/share/classes:/home/fohrstro/jdk8/jdk/src/solaris/classes:/home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc:/home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip" -bootclasspath /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/classes -source 8 -target 8 -encoding ascii -XDignore.symbol.file=true -Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally -h /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc_headers -d /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/classes From dingxmin at linux.vnet.ibm.com Fri Jan 18 06:59:26 2013 From: dingxmin at linux.vnet.ibm.com (Frank Ding) Date: Fri, 18 Jan 2013 14:59:26 +0800 Subject: Encoding problem when building In-Reply-To: References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> <50E7BC35.5040409@linux.vnet.ibm.com> <50EBB5CF.3090505@linux.vnet.ibm.com> Message-ID: <50F8F2CE.404@linux.vnet.ibm.com> Hi kto, Thank you. Somehow I think we cannot submit bugs since the new JBS system. Best regards, Frank On 1/10/2013 1:27 AM, Kelly O'Hair wrote: > I don't know where this bug has been filed. > > I will file one in the new JBS system. > JDK-8005947 - Windows builds in Chinese environment create generated files with Chinese characters > > It's P4 for now. I can adjust it to P3 but we think we can fix it, but right now my team is swamped. > > > -kto > > On Jan 7, 2013, at 9:59 PM, Frank Ding wrote: > >> Hi Kelly, >> I have filed a bug whose internal review id is 2421470. It was filed with "Product/Category" being "JDK/JRE" and "Subcategory" being "Problems common to more than one tool". I am wondering since it only happens when building OpenJDK, is it eligible for a Java bug? >> In addition, do you have any idea on how to force java programs such as idlj to use ascii? >> >> Best regards, >> Frank >> >> On 1/8/2013 3:42 AM, Kelly O'Hair wrote: >>> Did a bug report get filed for this issue? >>> >>> -kto >>> >>> On Jan 4, 2013, at 9:37 PM, Frank Ding wrote: >>> >>>> Hi Volker, >>>> Yes, I think so. The comment is pasted below. >>>> /** >>>> * org/omg/PortableServer/Current.java . >>>> * ?IDL-to-Java ??? (???), ?? "3.2"?? >>>> * ?../../../../src/share/classes/org/omg/PortableServer/poa.idl >>>> * 2013?1?4? ??? ??01?21?01? CST >>>> */ >>>> >>>> It's in Chinese, and it says when translated to English that "Generated by IDL-to-Java compiler(portable) version 3.2 and the date. You can also view a "normal" English one under openjdk folder "corba\gensrc\" after performing a build. >>>> >>>> An relevant question is that in my env (export LANG=C), java output without any param always gives me Chinese help. Even though we may find out which env var or value jvm reads on startup, it could be impossible to change them. Any insight or idea on the mechanism is welcome. >>>> >>>> Best regards, >>>> Frank >>>> >>>> On 1/4/2013 4:59 PM, Volker Simonis wrote: >>>>> This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind of comment is it? How does this comment look on a "normal" system? >>>>> >>>>> Regards, >>>>> Volker >>>>> >>>>> >>>>> On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding > wrote: >>>>> >>>>> Hi Kelly >>>>> I investigated how local specific characters get into generated >>>>> sources in corba module. Those classes are generated by following >>>>> command idlj >>>>> c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions >>>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td >>>>> "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" >>>>> -i "../../../../src/share/classes/org/omg/PortableServer" -i >>>>> "../../../../src/share/classes/org/omg/PortableInterceptor" -corba >>>>> 3.0 -fall -pkgPrefix PortableServer org.omg >>>>> ../../../../src/share/classes/org/omg/PortableServer/poa.idl >>>>> >>>>> I checked idlj help but there is no encoding specific option. My >>>>> locale environment vars are listed below >>>>> >>>>> $ locale >>>>> LANG=C >>>>> LC_CTYPE="C" >>>>> LC_NUMERIC="C" >>>>> LC_TIME="C" >>>>> LC_COLLATE="C" >>>>> LC_MONETARY="C" >>>>> LC_MESSAGES="C" >>>>> LC_ALL= >>>>> >>>>> Could you give me any hint about how to force idlj to generate >>>>> ascii chars only? >>>>> >>>>> Best regards, >>>>> Frank >>>>> >>>>> >>>>> On 1/1/2013 12:47 AM, Kelly O'Hair wrote: >>>>> >>>>> In the past, the "-encoding ascii" was important, all the >>>>> reasons I can't completely list right now. But it is important >>>>> that regardless of the locale, the bits created during the >>>>> build should be the same for everyone. >>>>> The definition of "same" might not be bit for bit, but by >>>>> minimizing the potential differences we have a fighting >>>>> chance of measuring "the same". >>>>> >>>>> But my question is, how are any locale specific characters >>>>> getting into generated sources? That's what we need to find out. >>>>> >>>>> Removing "-encoding ascii" is probably not the right answer, >>>>> and if it is, will require some debate. >>>>> >>>>> -kto >>>>> >>>>> On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: >>>>> >>>>> Hi >>>>> I have an encoding problem when building openjdk 8 on my >>>>> Windows 7. My windows is Chinese environment but I >>>>> exported LANG=C in cygwin bash before building. The issue >>>>> is that in module corba and jdk, some java classes are >>>>> generated by program. They happen to contain Chinese >>>>> characters in comment. However, they are compiled with >>>>> explicit option "-encoding ascii" in makefile. This >>>>> results in unrecognizable chars complained by javac >>>>> (Error: encoding ascii unmappable chars) . I have a patch >>>>> that removes all unnecessary "-encoding ascii" but I am >>>>> not sure all its side effect. Shall I submit a bug? >>>>> >>>>> Best regards, >>>>> Frank >>>>> >>>>> >>>>> From fredrik.ohrstrom at oracle.com Fri Jan 18 07:12:11 2013 From: fredrik.ohrstrom at oracle.com (=?iso-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Fri, 18 Jan 2013 08:12:11 +0100 Subject: --enable-sjavac not enabled in tl repo yet? In-Reply-To: <50F8B84A.4000800@oracle.com> References: <50F8AE73.8000809@oracle.com> <50F8B84A.4000800@oracle.com> Message-ID: The fix for moving a few source files for the awt bean info classes has not yet propagated into tl, from build. Until then, the tl with --enable-sjavac build will stop somewhere in the jdk when generating sources for awt bean infos. //Fredrik From weijun.wang at oracle.com Fri Jan 18 08:45:45 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 18 Jan 2013 16:45:45 +0800 Subject: --enable-sjavac not enabled in tl repo yet? In-Reply-To: <88BFD301-5CC2-4878-8185-44C55F7639BF@oracle.com> References: <50F8AE73.8000809@oracle.com> <88BFD301-5CC2-4878-8185-44C55F7639BF@oracle.com> Message-ID: <50F90BB9.3060600@oracle.com> On 01/18/2013 02:58 PM, Fredrik ?hrstr?m wrote: > 18 jan 2013 kl. 03:07 skrev Weijun Wang: > >> Just tried on a latest jdk8/tl clone and >> The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac > > > Ok, as the old saying goes, this works for me.... :-) So could you please tar up your build directory and email it to me? I just find something interesting. /space on my machine is a symlink to /home/more/space. If I cd to /home/more/space/repos/jdk8/tl/build/linux-x86_64-sjavac and configure/make there, everything is fine. Do you still need the tar? It's already 28MB when the failure happens. Thanks Max > > As for the error message, since the build system has to handle building with javac as well as with sjavac, the logic for finding which java > files to compile, is implemented both in make and in java (sjavac). Sjavac has the option: > --compare-found-sources file_with_list_of_files > which is used to make sjavac compare its own calculated list of source files with the list supplied by make. > If they differ, you will get the error message >> was not calculated by the smart javac > > > So why do we need to calculate the files to be compiled? Is it not just > compiling the required source roots? For example like this? > > sjavac src/share/classes src/posix/classes src/linux/classes -d bin > > Lets say, that we have an opportunity to organize the source in this way. > At the moment for example, when build the OpenJDK the snmp classes have to be excluded, > thus the compile command looks more like: > sjavac -x sun.management.snmp.* src/share/classes -d bin > > (In make the same calculation is handled by find and grep and sed et al.) > > The full filtering rules for compiling the main jdk looks like this: > > sjavac -x com.sun.pept.* -x com.sun.tools.example.trace.* -x com.sun.tools.example.debug.bdi.* -x com.sun.tools.example.debug.event.* -x com.sun.tools.example.debug.gui.* -x sun.dc.* -x com.sun.jmx.snmp.* -x sun.management.snmp.* -x com.sun.script.* -x com.oracle.security.* -x sun.java2d.cmm.kcms.* -xf *SolarisAclFileAttributeView.java -xf *SolarisFileStore.java -xf *SolarisFileSystem.java -xf *SolarisFileSystemProvider.java -xf *SolarisNativeDispatcher.java -xf *SolarisUserDefinedFileAttributeView.java -xf *SolarisWatchService.java -xf *SolarisAclFileAttributeView.java -xf *SolarisLoginModule.java -xf *SolarisSystem.java -xf *sun/nio/ch/DevPollArrayWrapper.java -xf *sun/nio/ch/DevPollSelectorImpl.java -xf *sun/nio/ch/DevPollSelectorProvider.java -xf *sun/nio/ch/EventPortSelectorImpl.java -xf *sun/nio/ch/EventPortSelectorProvider.java -xf *sun/nio/ch/EventPortWrapper.java -xf *sun/nio/ch/SolarisAsynchronousChannelProvider.java -xf *sun/nio/ch/SolarisEventPort.java -xf *su! n/tools/at tach/SolarisAttachProvider.java -xf *sun/tools/attach/SolarisVirtualMachine.java -xf *WrapperGenerator.java -xf *NTLoginModule.java -xf *NTSystem.java -xf *sun/nio/ch/BsdAsynchronousChannelProvider.java -xf *sun/nio/ch/KQueue.java -xf *sun/nio/ch/KQueuePort.java -xf *sun/nio/fs/BsdFileStore.java -xf *sun/nio/fs/BsdFileSystem.java -xf *sun/nio/fs/BsdFileSystemProvider.java -xf *sun/nio/fs/BsdNativeDispatcher.java -xf *sun/nio/fs/MacOSXFileSystemProvider.java -xf *sun/nio/fs/MacOSXFileSystem.java -xf *sun/nio/fs/MacOSXNativeDispatcher.java -xf *sun/tools/attach/BsdAttachProvider.java -xf *sun/tools/attach/BsdVirtualMachine.java -xf *sun/text/resources/BreakIteratorRules.java -xf *sun/text/resources/BreakIteratorRules_th.java -xf *sun/awt/AWTCharset.java -xf *sun/awt/X11/ScreenFormat.java -xf *sun/awt/X11/XArc.java -xf *sun/awt/X11/XChar2b.java -xf *sun/awt/X11/XCharStruct.java -xf *sun/awt/X11/XClassHint.java -xf *sun/awt/X11/XComposeStatus.java -xf *sun/awt/X11/XExtCodes.java! -xf *sun/ awt/X11/XFontProp.java -xf *sun/awt/X11/XFontSetExtents.java -xf *sun/awt/X11/XFontStruct.java -xf *sun/awt/X11/XGCValues.java -xf *sun/awt/X11/XHostAddress.java -xf *sun/awt/X11/XIMCallback.java -xf *sun/awt/X11/XIMHotKeyTrigger.java -xf *sun/awt/X11/XIMHotKeyTriggers.java -xf *sun/awt/X11/XIMPreeditCaretCallbackStruct.java -xf *sun/awt/X11/XIMPreeditDrawCallbackStruct.java -xf *sun/awt/X11/XIMPreeditStateNotifyCallbackStruct.java -xf *sun/awt/X11/XIMStatusDrawCallbackStruct.java -xf *sun/awt/X11/XIMStringConversionCallbackStruct.java -xf *sun/awt/X11/XIMStringConversionText.java -xf *sun/awt/X11/XIMStyles.java -xf *sun/awt/X11/XIMText.java -xf *sun/awt/X11/XIMValuesList.java -xf *sun/awt/X11/XImage.java -xf *sun/awt/X11/XKeyboardControl.java -xf *sun/awt/X11/XKeyboardState.java -xf *sun/awt/X11/XOMCharSetList.java -xf *sun/awt/X11/XOMFontInfo.java -xf *sun/awt/X11/XOMOrientation.java -xf *sun/awt/X11/XPoint.java -xf *sun/awt/X11/XRectangle.java -xf *sun/awt/X11/XSegment.ja! va -xf *su n/awt/X11/XStandardColormap.java -xf *sun/awt/X11/XTextItem.java -xf *sun/awt/X11/XTextItem16.java -xf *sun/awt/X11/XTextProperty.java -xf *sun/awt/X11/XTimeCoord.java -xf *sun/awt/X11/XWindowChanges.java -xf *sun/awt/X11/XdbeSwapInfo.java -xf *sun/awt/X11/XmbTextItem.java -xf *sun/awt/X11/XwcTextItem.java -xf *sun/util/locale/AsciiUtil.java -xf *sun/nio/fs/PollingWatchService.java -xf *-linux-arm.java -xf *-linux-ppc.java -xf *javax/swing/plaf/nimbus/InternalFrameTitlePanePainter.java -xf *javax/swing/plaf/nimbus/OptionPaneMessageAreaPainter.java -xf *javax/swing/plaf/nimbus/ScrollBarPainter.java -xf *javax/swing/plaf/nimbus/SliderPainter.java -xf *javax/swing/plaf/nimbus/SpinnerPainter.java -xf *javax/swing/plaf/nimbus/SplitPanePainter.java -xf *javax/swing/plaf/nimbus/TabbedPanePainter.java -src "/home/fohrstro/jdk8/jdk/src/share/classes:/home/fohrstro/jdk8/jdk/src/solaris/classes:/home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc:/home/fohrstro/jdk8! /build/lin ux-x86_64-normal-server-release/jdk/gensrc_no_srczip" > -bootclasspath /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/classes > -source 8 -target 8 -encoding ascii -XDignore.symbol.file=true -Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally > -h /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc_headers > -d /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/classes > From oehrstroem at gmail.com Fri Jan 18 09:20:04 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Fri, 18 Jan 2013 10:20:04 +0100 Subject: --enable-sjavac not enabled in tl repo yet? In-Reply-To: <50F90BB9.3060600@oracle.com> References: <50F8AE73.8000809@oracle.com> <88BFD301-5CC2-4878-8185-44C55F7639BF@oracle.com> <50F90BB9.3060600@oracle.com> Message-ID: 2013/1/18 Weijun Wang : > I just find something interesting. /space on my machine is a symlink to > /home/more/space. If I cd to > /home/more/space/repos/jdk8/tl/build/linux-x86_64-sjavac and configure/make > there, everything is fine. Ah, then sjavac is probably doing canonical or absolute on the paths, thus the makefile list will look different even though they point to the same files. That should be easy to fix! Thanks for the bug report! > > Do you still need the tar? It's already 28MB when the failure happens. No. //Fredrik From erik.joelsson at oracle.com Fri Jan 18 11:01:37 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 18 Jan 2013 12:01:37 +0100 Subject: Review Request: 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot) Message-ID: <50F92B91.4030209@oracle.com> Making it possible to use --with-import-hotspot through bridgeBuild and jprt. Also converted check for open only to use same wildcard construction as the new HOTSPOT_AVAILABLE to avoid unneeded shell expressions. http://cr.openjdk.java.net/~erikj/8003693/webrev.root.01/ /Erik From erik.joelsson at oracle.com Fri Jan 18 14:05:50 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 18 Jan 2013 15:05:50 +0100 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: <50C1BF60.8050807@oracle.com> References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> <50BF4A08.2050700@oracle.com> <50C1BF60.8050807@oracle.com> Message-ID: <50F956BE.8020309@oracle.com> Here is a new webrev with my sorts incorporated. This has been baking for quite a while in build-infra now and seems to be working. http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.04/ /Erik On 2012-12-07 11:05, Erik Joelsson wrote: > (resending to full recepients list) > > I just hit another issue. I tried using a jdk8 boot-jdk and the order > of the output was different in the generated sizes file compared to > the one in the repo. Sorting both resulted in a clean diff. > > /Erik > > On 2012-12-05 14:20, Fredrik ?hrstr?m wrote: >> 2012-11-29 15:54, Fredrik ?hrstr?m skrev: >>> 2012-11-29 15:36, Erik Joelsson skrev: >>>> I just submitted a patch to build-infra for the dual generation on >>>> all platforms since it breaks comparisons between old and new >>>> build. In general, we can't change behavior in new build without >>>> also changing the old before the old is removed. >>>> >>>> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >>>> so I have readded it to build-infra. >>> >>> Thanks Erik! The new and updated webrev is here: >>> >>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ >>> >>> >>> >> Ok, new webrev incorporating a few more Erik changes. Any comments >> from the AWT experts? >> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ >> >> //Fredrik From peter.brunet at oracle.com Fri Jan 18 15:09:00 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 09:09:00 -0600 Subject: jdk8 - no docs directory Message-ID: <50F9658C.7090800@oracle.com> Hi, I built jdk8 last night and left NO_DOCS=true off but I have no docs directory. What do I need to do? Here are the highlights of what did: - install the import bundle from http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz - set ALT_JDK_IMPORT_PATH pointing to it - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk - cd ...\jdk\make - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build The build ran a long time and appears to have finished normally. Pete From erik.joelsson at oracle.com Fri Jan 18 15:21:32 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 18 Jan 2013 16:21:32 +0100 Subject: Review Request: 8006567: jre/lib/applet missing from Mac JDK installation Message-ID: <50F9687C.10402@oracle.com> When copying the j2*-image dirs to j2*-bundle, empty directories weren't included. This caused jre/lib/applet to be missing. This patch makes sure empty directories are also copied over. http://cr.openjdk.java.net/~erikj/8006567/webrev.jdk.01/ /Erik From erik.joelsson at oracle.com Fri Jan 18 15:36:35 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 18 Jan 2013 16:36:35 +0100 Subject: jdk8 - no docs directory In-Reply-To: <50F9658C.7090800@oracle.com> References: <50F9658C.7090800@oracle.com> Message-ID: <50F96C03.6000404@oracle.com> The fastdebug target in jdk/make/Makefile does not include running docs. The target in that makefile is 'docs', but I've never used it from there and can't say if it works. /Erik On 2013-01-18 16:09, Pete Brunet wrote: > Hi, I built jdk8 last night and left NO_DOCS=true off but I have no docs > directory. What do I need to do? Here are the highlights of what did: > - install the import bundle from > http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz > - set ALT_JDK_IMPORT_PATH pointing to it > - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt > - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk > - cd ...\jdk\make > - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build > > The build ran a long time and appears to have finished normally. > > Pete From tim.bell at oracle.com Fri Jan 18 15:40:35 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 18 Jan 2013 07:40:35 -0800 Subject: Review Request: 8006567: jre/lib/applet missing from Mac JDK installation In-Reply-To: <50F9687C.10402@oracle.com> References: <50F9687C.10402@oracle.com> Message-ID: <50F96CF3.5030406@oracle.com> Erik: > When copying the j2*-image dirs to j2*-bundle, empty directories > weren't included. This caused jre/lib/applet to be missing. This patch > makes sure empty directories are also copied over. > > http://cr.openjdk.java.net/~erikj/8006567/webrev.jdk.01/ Looks good. Tim From tim.bell at oracle.com Fri Jan 18 15:45:38 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 18 Jan 2013 07:45:38 -0800 Subject: Review Request: 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot) In-Reply-To: <50F92B91.4030209@oracle.com> References: <50F92B91.4030209@oracle.com> Message-ID: <50F96E22.4070209@oracle.com> Erik: > Making it possible to use --with-import-hotspot through bridgeBuild > and jprt. Also converted check for open only to use same wildcard > construction as the new HOTSPOT_AVAILABLE to avoid unneeded shell > expressions. > > http://cr.openjdk.java.net/~erikj/8003693/webrev.root.01/ Looks good- Tim From erik.joelsson at oracle.com Fri Jan 18 16:14:49 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 18 Jan 2013 17:14:49 +0100 Subject: Review Request: 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. Message-ID: <50F974F9.5060902@oracle.com> Small patch to fix a minor difference between new and old build. In jvm.cfg, alias -server to -client when no server jvm is built. http://cr.openjdk.java.net/~erikj/8006579/webrev.jdk.01/ /Erik From peter.brunet at oracle.com Fri Jan 18 16:31:41 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 10:31:41 -0600 Subject: jdk8 - no docs directory In-Reply-To: <50F96C03.6000404@oracle.com> References: <50F9658C.7090800@oracle.com> <50F96C03.6000404@oracle.com> Message-ID: <50F978ED.1060701@oracle.com> Thanks Erik, That worked. -Pete On 1/18/13 9:36 AM, Erik Joelsson wrote: > The fastdebug target in jdk/make/Makefile does not include running > docs. The target in that makefile is 'docs', but I've never used it > from there and can't say if it works. > > /Erik > > On 2013-01-18 16:09, Pete Brunet wrote: >> Hi, I built jdk8 last night and left NO_DOCS=true off but I have no docs >> directory. What do I need to do? Here are the highlights of what did: >> - install the import bundle from >> http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz >> >> - set ALT_JDK_IMPORT_PATH pointing to it >> - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt >> - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk >> - cd ...\jdk\make >> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build >> >> The build ran a long time and appears to have finished normally. >> >> Pete From erik.joelsson at oracle.com Fri Jan 18 16:36:19 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 18 Jan 2013 17:36:19 +0100 Subject: Review Request: 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip Message-ID: <50F97A03.3030207@oracle.com> Cleanup after JDK-8005096, which accidentally added /javax/swing/SwingBeanInfoBase.java to src.zip for build-infra but not for old build. http://cr.openjdk.java.net/~erikj/8006583/webrev.jdk.01/ /Erik From tim.bell at oracle.com Fri Jan 18 16:43:24 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 18 Jan 2013 08:43:24 -0800 Subject: Review Request: 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. In-Reply-To: <50F974F9.5060902@oracle.com> References: <50F974F9.5060902@oracle.com> Message-ID: <50F97BAC.7050108@oracle.com> Erik: > Small patch to fix a minor difference between new and old build. In > jvm.cfg, alias -server to -client when no server jvm is built. > > http://cr.openjdk.java.net/~erikj/8006579/webrev.jdk.01/ Looks good. Tim From peter.brunet at oracle.com Fri Jan 18 17:23:15 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 11:23:15 -0600 Subject: unexpected hg status report Message-ID: <50F98503.4030608@oracle.com> I just ran hg status on a newly cloned jdk8 jdk directory and everything is listed as modified. I don't know if I did something wrong or something else is broken. Here's what I did: - install the import bundle from http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz - set ALT_JDK_IMPORT_PATH pointing to it - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk - cd ...\jdk\make - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out fastdebug doesn't build docs - cd .. - hg import --no-commit ...\jdk.patch (patches for 3 files) // it failed, due to uncommitted changes - hg status // all files in jdk tree listed as modified Do I have to start over? Pete From peter.brunet at oracle.com Fri Jan 18 17:34:50 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 11:34:50 -0600 Subject: unexpected hg status report In-Reply-To: <50F98503.4030608@oracle.com> References: <50F98503.4030608@oracle.com> Message-ID: <50F987BA.3080603@oracle.com> I diffed one of the files: old mode 100644 new mode 100755 While I've occasionally run into mode differences before on files I've changed I haven't seen this problem on every file. I'm running cygwig on Win 7. Pete On 1/18/13 11:23 AM, Pete Brunet wrote: > I just ran hg status on a newly cloned jdk8 jdk directory and everything > is listed as modified. I don't know if I did something wrong or > something else is broken. Here's what I did: > > - install the import bundle from > http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz > - set ALT_JDK_IMPORT_PATH pointing to it > - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt > - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk > - cd ...\jdk\make > - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build > - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out > fastdebug doesn't build docs > - cd .. > - hg import --no-commit ...\jdk.patch (patches for 3 files) // it > failed, due to uncommitted changes > - hg status // all files in jdk tree listed as modified > > Do I have to start over? > > Pete From tim.bell at oracle.com Fri Jan 18 18:02:12 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 18 Jan 2013 10:02:12 -0800 Subject: Review Request: 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip In-Reply-To: <50F97A03.3030207@oracle.com> References: <50F97A03.3030207@oracle.com> Message-ID: <50F98E24.5070102@oracle.com> Hi Erik- > Cleanup after JDK-8005096, which accidentally added > /javax/swing/SwingBeanInfoBase.java to src.zip for build-infra but not > for old build. > > http://cr.openjdk.java.net/~erikj/8006583/webrev.jdk.01/ Looks good. Tim From peter.brunet at oracle.com Fri Jan 18 18:39:12 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 12:39:12 -0600 Subject: unexpected hg status report In-Reply-To: <50F987BA.3080603@oracle.com> References: <50F98503.4030608@oracle.com> <50F987BA.3080603@oracle.com> Message-ID: <50F996D0.7070907@oracle.com> This is probably not the right workaround but it worked for me: cd ... // one level above awt chmod -R 644 awt cd .../jdk hg status // two files found, an exe and a bat chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat chmod 755 test/sun/management/windows/revokeall.exe Now hg status runs clean. cding to directories fails and would require more 755s on dirs you want to cd too but Win Explorer doesn't complain. Pete On 1/18/13 11:34 AM, Pete Brunet wrote: > I diffed one of the files: > old mode 100644 > new mode 100755 > > While I've occasionally run into mode differences before on files I've > changed I haven't seen this problem on every file. I'm running cygwig > on Win 7. > > Pete > > On 1/18/13 11:23 AM, Pete Brunet wrote: >> I just ran hg status on a newly cloned jdk8 jdk directory and everything >> is listed as modified. I don't know if I did something wrong or >> something else is broken. Here's what I did: >> >> - install the import bundle from >> http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz >> - set ALT_JDK_IMPORT_PATH pointing to it >> - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt >> - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk >> - cd ...\jdk\make >> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build >> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out >> fastdebug doesn't build docs >> - cd .. >> - hg import --no-commit ...\jdk.patch (patches for 3 files) // it >> failed, due to uncommitted changes >> - hg status // all files in jdk tree listed as modified >> >> Do I have to start over? >> >> Pete From tim.bell at oracle.com Fri Jan 18 18:55:33 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 18 Jan 2013 10:55:33 -0800 Subject: unexpected hg status report In-Reply-To: <50F996D0.7070907@oracle.com> References: <50F98503.4030608@oracle.com> <50F987BA.3080603@oracle.com> <50F996D0.7070907@oracle.com> Message-ID: <50F99AA5.4000404@oracle.com> There have been other reports of similar file permission problems when command line access via Cygwin is mixed with creating directories or doing other operations via the Windows GUI (explorer?). I don't have a reference handy, but some searching should be able to uncover the email threads in archives of build-dev or build-infra-dev at openjdk.java.net My solution is to eschew the Windows GUI and use the command line, just as you would on any other server. Tim On 01/18/13 10:39, Pete Brunet wrote: > This is probably not the right workaround but it worked for me: > cd ... // one level above awt > chmod -R 644 awt > cd .../jdk > hg status // two files found, an exe and a bat > chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat > chmod 755 test/sun/management/windows/revokeall.exe > > Now hg status runs clean. > > cding to directories fails and would require more 755s on dirs you want > to cd too but Win Explorer doesn't complain. > > Pete > > On 1/18/13 11:34 AM, Pete Brunet wrote: >> I diffed one of the files: >> old mode 100644 >> new mode 100755 >> >> While I've occasionally run into mode differences before on files I've >> changed I haven't seen this problem on every file. I'm running cygwig >> on Win 7. >> >> Pete >> >> On 1/18/13 11:23 AM, Pete Brunet wrote: >>> I just ran hg status on a newly cloned jdk8 jdk directory and everything >>> is listed as modified. I don't know if I did something wrong or >>> something else is broken. Here's what I did: >>> >>> - install the import bundle from >>> http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz >>> - set ALT_JDK_IMPORT_PATH pointing to it >>> - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt >>> - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk >>> - cd ...\jdk\make >>> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build >>> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out >>> fastdebug doesn't build docs >>> - cd .. >>> - hg import --no-commit ...\jdk.patch (patches for 3 files) // it >>> failed, due to uncommitted changes >>> - hg status // all files in jdk tree listed as modified >>> >>> Do I have to start over? >>> >>> Pete From peter.brunet at oracle.com Fri Jan 18 19:42:50 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 13:42:50 -0600 Subject: unexpected hg status report In-Reply-To: <50F99AA5.4000404@oracle.com> References: <50F98503.4030608@oracle.com> <50F987BA.3080603@oracle.com> <50F996D0.7070907@oracle.com> <50F99AA5.4000404@oracle.com> Message-ID: <50F9A5BA.9050001@oracle.com> Hi Tim, I did the whole process from the cygwin command line, as I normally do. I just mentioned Explorer as a way to look through directories since I 644'd everything as a workaround and so was getting access denied messages when cding to 644'd directories. This issue of hg status reporting that everything has been modified after a clone is new. hg diff indicates that the repo thinks all my files should be 644 but the clone process apparently made them all 755. At least that's what I think is going on. I don't know if the permissions are wrong in the cloned repo (.hg directory) or the cloned files in the workspace. Pete On 1/18/13 12:55 PM, Tim Bell wrote: > There have been other reports of similar file permission problems when > command line access via Cygwin is mixed with creating directories or > doing other operations via the Windows GUI (explorer?). > > I don't have a reference handy, but some searching should be able to > uncover the email threads in archives of build-dev or > build-infra-dev at openjdk.java.net > > My solution is to eschew the Windows GUI and use the command line, > just as you would on any other server. > > Tim > > On 01/18/13 10:39, Pete Brunet wrote: >> This is probably not the right workaround but it worked for me: >> cd ... // one level above awt >> chmod -R 644 awt >> cd .../jdk >> hg status // two files found, an exe and a bat >> chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat >> chmod 755 test/sun/management/windows/revokeall.exe >> >> Now hg status runs clean. >> >> cding to directories fails and would require more 755s on dirs you want >> to cd too but Win Explorer doesn't complain. >> >> Pete >> >> On 1/18/13 11:34 AM, Pete Brunet wrote: >>> I diffed one of the files: >>> old mode 100644 >>> new mode 100755 >>> >>> While I've occasionally run into mode differences before on files I've >>> changed I haven't seen this problem on every file. I'm running cygwig >>> on Win 7. >>> >>> Pete >>> >>> On 1/18/13 11:23 AM, Pete Brunet wrote: >>>> I just ran hg status on a newly cloned jdk8 jdk directory and >>>> everything >>>> is listed as modified. I don't know if I did something wrong or >>>> something else is broken. Here's what I did: >>>> >>>> - install the import bundle from >>>> http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz >>>> >>>> - set ALT_JDK_IMPORT_PATH pointing to it >>>> - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt >>>> - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk >>>> - cd ...\jdk\make >>>> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build >>>> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out >>>> fastdebug doesn't build docs >>>> - cd .. >>>> - hg import --no-commit ...\jdk.patch (patches for 3 files) // it >>>> failed, due to uncommitted changes >>>> - hg status // all files in jdk tree listed as modified >>>> >>>> Do I have to start over? >>>> >>>> Pete > > From peter.brunet at oracle.com Fri Jan 18 22:07:12 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 18 Jan 2013 16:07:12 -0600 Subject: unexpected hg status report In-Reply-To: <50F9A5BA.9050001@oracle.com> References: <50F98503.4030608@oracle.com> <50F987BA.3080603@oracle.com> <50F996D0.7070907@oracle.com> <50F99AA5.4000404@oracle.com> <50F9A5BA.9050001@oracle.com> Message-ID: <50F9C790.2000209@oracle.com> This issue may have been due to using hg clone from the dos prompt instead of the cygwin prompt. I cloned again from the cygwin prompt and now hg status doesn't indicate any modified files. -Pete On 1/18/13 1:42 PM, Pete Brunet wrote: > Hi Tim, I did the whole process from the cygwin command line, as I > normally do. I just mentioned Explorer as a way to look through > directories since I 644'd everything as a workaround and so was getting > access denied messages when cding to 644'd directories. This issue of > hg status reporting that everything has been modified after a clone is > new. hg diff indicates that the repo thinks all my files should be 644 > but the clone process apparently made them all 755. At least that's > what I think is going on. I don't know if the permissions are wrong in > the cloned repo (.hg directory) or the cloned files in the workspace. > > Pete > > On 1/18/13 12:55 PM, Tim Bell wrote: >> There have been other reports of similar file permission problems when >> command line access via Cygwin is mixed with creating directories or >> doing other operations via the Windows GUI (explorer?). >> >> I don't have a reference handy, but some searching should be able to >> uncover the email threads in archives of build-dev or >> build-infra-dev at openjdk.java.net >> >> My solution is to eschew the Windows GUI and use the command line, >> just as you would on any other server. >> >> Tim >> >> On 01/18/13 10:39, Pete Brunet wrote: >>> This is probably not the right workaround but it worked for me: >>> cd ... // one level above awt >>> chmod -R 644 awt >>> cd .../jdk >>> hg status // two files found, an exe and a bat >>> chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat >>> chmod 755 test/sun/management/windows/revokeall.exe >>> >>> Now hg status runs clean. >>> >>> cding to directories fails and would require more 755s on dirs you want >>> to cd too but Win Explorer doesn't complain. >>> >>> Pete >>> >>> On 1/18/13 11:34 AM, Pete Brunet wrote: >>>> I diffed one of the files: >>>> old mode 100644 >>>> new mode 100755 >>>> >>>> While I've occasionally run into mode differences before on files I've >>>> changed I haven't seen this problem on every file. I'm running cygwig >>>> on Win 7. >>>> >>>> Pete >>>> >>>> On 1/18/13 11:23 AM, Pete Brunet wrote: >>>>> I just ran hg status on a newly cloned jdk8 jdk directory and >>>>> everything >>>>> is listed as modified. I don't know if I did something wrong or >>>>> something else is broken. Here's what I did: >>>>> >>>>> - install the import bundle from >>>>> http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz >>>>> >>>>> - set ALT_JDK_IMPORT_PATH pointing to it >>>>> - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt >>>>> - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk >>>>> - cd ...\jdk\make >>>>> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build >>>>> - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out >>>>> fastdebug doesn't build docs >>>>> - cd .. >>>>> - hg import --no-commit ...\jdk.patch (patches for 3 files) // it >>>>> failed, due to uncommitted changes >>>>> - hg status // all files in jdk tree listed as modified >>>>> >>>>> Do I have to start over? >>>>> >>>>> Pete >> From david.holmes at oracle.com Mon Jan 21 02:04:25 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 21 Jan 2013 12:04:25 +1000 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: <50F956BE.8020309@oracle.com> References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> <50BF4A08.2050700@oracle.com> <50C1BF60.8050807@oracle.com> <50F956BE.8020309@oracle.com> Message-ID: <50FCA229.6080006@oracle.com> Minor typo in the gmk file 32 # These are the once used. once -> ones Thanks, David On 19/01/2013 12:05 AM, Erik Joelsson wrote: > Here is a new webrev with my sorts incorporated. This has been baking > for quite a while in build-infra now and seems to be working. > > http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.04/ > > /Erik > > On 2012-12-07 11:05, Erik Joelsson wrote: >> (resending to full recepients list) >> >> I just hit another issue. I tried using a jdk8 boot-jdk and the order >> of the output was different in the generated sizes file compared to >> the one in the repo. Sorting both resulted in a clean diff. >> >> /Erik >> >> On 2012-12-05 14:20, Fredrik ?hrstr?m wrote: >>> 2012-11-29 15:54, Fredrik ?hrstr?m skrev: >>>> 2012-11-29 15:36, Erik Joelsson skrev: >>>>> I just submitted a patch to build-infra for the dual generation on >>>>> all platforms since it breaks comparisons between old and new >>>>> build. In general, we can't change behavior in new build without >>>>> also changing the old before the old is removed. >>>>> >>>>> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >>>>> so I have readded it to build-infra. >>>> >>>> Thanks Erik! The new and updated webrev is here: >>>> >>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ >>>> >>>> >>>> >>> Ok, new webrev incorporating a few more Erik changes. Any comments >>> from the AWT experts? >>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ >>> >>> //Fredrik From oehrstroem at gmail.com Mon Jan 21 08:28:11 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 21 Jan 2013 09:28:11 +0100 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: <50FCA229.6080006@oracle.com> References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> <50BF4A08.2050700@oracle.com> <50C1BF60.8050807@oracle.com> <50F956BE.8020309@oracle.com> <50FCA229.6080006@oracle.com> Message-ID: double slash here: -I$(JDK_TOPDIR)//src/share/native/common 2013/1/21 David Holmes : > Minor typo in the gmk file > > 32 # These are the once used. > > once -> ones > > Thanks, > David > > > On 19/01/2013 12:05 AM, Erik Joelsson wrote: >> >> Here is a new webrev with my sorts incorporated. This has been baking >> for quite a while in build-infra now and seems to be working. >> >> http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.04/ >> >> /Erik >> >> On 2012-12-07 11:05, Erik Joelsson wrote: >>> >>> (resending to full recepients list) >>> >>> I just hit another issue. I tried using a jdk8 boot-jdk and the order >>> of the output was different in the generated sizes file compared to >>> the one in the repo. Sorting both resulted in a clean diff. >>> >>> /Erik >>> >>> On 2012-12-05 14:20, Fredrik ?hrstr?m wrote: >>>> >>>> 2012-11-29 15:54, Fredrik ?hrstr?m skrev: >>>>> >>>>> 2012-11-29 15:36, Erik Joelsson skrev: >>>>>> >>>>>> I just submitted a patch to build-infra for the dual generation on >>>>>> all platforms since it breaks comparisons between old and new >>>>>> build. In general, we can't change behavior in new build without >>>>>> also changing the old before the old is removed. >>>>>> >>>>>> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >>>>>> so I have readded it to build-infra. >>>>> >>>>> >>>>> Thanks Erik! The new and updated webrev is here: >>>>> >>>>> >>>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ >>>>> >>>>> >>>>> >>>>> >>>> Ok, new webrev incorporating a few more Erik changes. Any comments >>>> from the AWT experts? >>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ >>>> >>>> //Fredrik From erik.joelsson at oracle.com Mon Jan 21 13:49:14 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Mon, 21 Jan 2013 13:49:14 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20130121134915.35DBC4741E@hg.openjdk.java.net> Changeset: 5a5e97f9ac0a Author: erikj Date: 2013-01-18 09:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/5a5e97f9ac0a 8006520: build-infra: Fix sparkle-framework configure parameter Reviewed-by: tbell, ohair ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: edad83acbd46 Author: erikj Date: 2013-01-18 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/edad83acbd46 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot) Reviewed-by: tbell ! common/makefiles/Jprt.gmk From erik.joelsson at oracle.com Mon Jan 21 13:49:15 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Mon, 21 Jan 2013 13:49:15 +0000 Subject: hg: jdk8/build/jdk: 3 new changesets Message-ID: <20130121135001.647E34741F@hg.openjdk.java.net> Changeset: 478d8354285a Author: erikj Date: 2013-01-18 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/478d8354285a 8006567: jre/lib/applet missing from Mac JDK installation Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: 92d8880d5406 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/92d8880d5406 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip Reviewed-by: tbell ! makefiles/GensrcSwing.gmk Changeset: a9839ed93340 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a9839ed93340 Merge From erik.joelsson at oracle.com Mon Jan 21 13:59:54 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Mon, 21 Jan 2013 13:59:54 +0000 Subject: hg: jdk8/build/jdk: 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. Message-ID: <20130121140017.D8D0E47422@hg.openjdk.java.net> Changeset: 506bf3d23f06 Author: erikj Date: 2013-01-21 14:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/506bf3d23f06 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. Reviewed-by: tbell ! makefiles/CopyFiles.gmk From erik.joelsson at oracle.com Mon Jan 21 14:17:20 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 21 Jan 2013 15:17:20 +0100 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> <50BF4A08.2050700@oracle.com> <50C1BF60.8050807@oracle.com> <50F956BE.8020309@oracle.com> <50FCA229.6080006@oracle.com> Message-ID: <50FD4DF0.7080306@oracle.com> Fixed both issues reported below http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.05/ /Erik On 2013-01-21 09:28, Fredrik ?hrstr?m wrote: > double slash here: -I$(JDK_TOPDIR)//src/share/native/common > > 2013/1/21 David Holmes: >> Minor typo in the gmk file >> >> 32 # These are the once used. >> >> once -> ones >> >> Thanks, >> David >> >> >> On 19/01/2013 12:05 AM, Erik Joelsson wrote: >>> Here is a new webrev with my sorts incorporated. This has been baking >>> for quite a while in build-infra now and seems to be working. >>> >>> http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.04/ >>> >>> /Erik >>> >>> On 2012-12-07 11:05, Erik Joelsson wrote: >>>> (resending to full recepients list) >>>> >>>> I just hit another issue. I tried using a jdk8 boot-jdk and the order >>>> of the output was different in the generated sizes file compared to >>>> the one in the repo. Sorting both resulted in a clean diff. >>>> >>>> /Erik >>>> >>>> On 2012-12-05 14:20, Fredrik ?hrstr?m wrote: >>>>> 2012-11-29 15:54, Fredrik ?hrstr?m skrev: >>>>>> 2012-11-29 15:36, Erik Joelsson skrev: >>>>>>> I just submitted a patch to build-infra for the dual generation on >>>>>>> all platforms since it breaks comparisons between old and new >>>>>>> build. In general, we can't change behavior in new build without >>>>>>> also changing the old before the old is removed. >>>>>>> >>>>>>> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >>>>>>> so I have readded it to build-infra. >>>>>> >>>>>> Thanks Erik! The new and updated webrev is here: >>>>>> >>>>>> >>>>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ >>>>>> >>>>>> >>>>>> >>>>>> >>>>> Ok, new webrev incorporating a few more Erik changes. Any comments >>>>> from the AWT experts? >>>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ >>>>> >>>>> //Fredrik From david.holmes at oracle.com Tue Jan 22 01:57:30 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 22 Jan 2013 11:57:30 +1000 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: <50F956BE.8020309@oracle.com> References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> <50BF4A08.2050700@oracle.com> <50C1BF60.8050807@oracle.com> <50F956BE.8020309@oracle.com> Message-ID: <50FDF20A.2040701@oracle.com> Hi Erik, I need this pushed to jdk8/build yesterday! :) Seriously! This is now a blocker for the Profiles integration work. I thought I was utilizing 8005855 as a workaround but it never got pushed - instead I still have my hack of deleting the X_LIBS and X_CFLAGS from the sizer build. I can't have that hack in the repo that will go to PIT this week for the Profiles work, but I need something to get cross-compilation working. Thanks, David On 19/01/2013 12:05 AM, Erik Joelsson wrote: > Here is a new webrev with my sorts incorporated. This has been baking > for quite a while in build-infra now and seems to be working. > > http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.04/ > > /Erik > > On 2012-12-07 11:05, Erik Joelsson wrote: >> (resending to full recepients list) >> >> I just hit another issue. I tried using a jdk8 boot-jdk and the order >> of the output was different in the generated sizes file compared to >> the one in the repo. Sorting both resulted in a clean diff. >> >> /Erik >> >> On 2012-12-05 14:20, Fredrik ?hrstr?m wrote: >>> 2012-11-29 15:54, Fredrik ?hrstr?m skrev: >>>> 2012-11-29 15:36, Erik Joelsson skrev: >>>>> I just submitted a patch to build-infra for the dual generation on >>>>> all platforms since it breaks comparisons between old and new >>>>> build. In general, we can't change behavior in new build without >>>>> also changing the old before the old is removed. >>>>> >>>>> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >>>>> so I have readded it to build-infra. >>>> >>>> Thanks Erik! The new and updated webrev is here: >>>> >>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ >>>> >>>> >>>> >>> Ok, new webrev incorporating a few more Erik changes. Any comments >>> from the AWT experts? >>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ >>> >>> //Fredrik From erik.joelsson at oracle.com Tue Jan 22 08:02:42 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Tue, 22 Jan 2013 08:02:42 +0000 Subject: hg: jdk8/build/jdk: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable Message-ID: <20130122080305.DBC1F4744D@hg.openjdk.java.net> Changeset: 57d5d9544628 Author: erikj Date: 2013-01-22 09:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/57d5d9544628 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable Reviewed-by: dholmes, ohrstrom ! makefiles/GensrcX11Wrappers.gmk + src/solaris/classes/sun/awt/X11/generator/sizes.32 + src/solaris/classes/sun/awt/X11/generator/sizes.64 From erik.joelsson at oracle.com Tue Jan 22 09:13:44 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 22 Jan 2013 10:13:44 +0100 Subject: Review Request: 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER Message-ID: <50FE5848.5000600@oracle.com> In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable. But by mistake, JDK_BUILD_NUMBER could get picked up from the environment while MILESTONE couldn't. They should behave the same and at this time, listening to the environment is needed. http://cr.openjdk.java.net/~erikj/8006658/webrev.root.01/ /Erik From oehrstroem at gmail.com Tue Jan 22 09:38:18 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Tue, 22 Jan 2013 10:38:18 +0100 Subject: Review Request: 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER In-Reply-To: <50FE5848.5000600@oracle.com> References: <50FE5848.5000600@oracle.com> Message-ID: Ok! 2013/1/22 Erik Joelsson : > In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable. But > by mistake, JDK_BUILD_NUMBER could get picked up from the environment while > MILESTONE couldn't. They should behave the same and at this time, listening > to the environment is needed. > > http://cr.openjdk.java.net/~erikj/8006658/webrev.root.01/ > > /Erik From erik.joelsson at oracle.com Tue Jan 22 09:51:25 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 22 Jan 2013 10:51:25 +0100 Subject: Review Request: 8006661: build-infra: Use LC_ALL=C instead of LANG=C in compare.sh Message-ID: <50FE611D.3090505@oracle.com> Use LC_ALL=C instead of LANG=C because the latter does not change LC_MESSAGES, which is necessary if we are grepping for english words in the output from diff. Contributed by ohrstrom http://cr.openjdk.java.net/~erikj/8006661/webrev.root.01/ /Erik From erik.joelsson at oracle.com Tue Jan 22 10:03:50 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 22 Jan 2013 11:03:50 +0100 Subject: Review Request: 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh Message-ID: <50FE6406.1080803@oracle.com> Adding functionality to compare.sh to take two zip/jar files as arguments and just compare those. http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/ /Erik From oehrstroem at gmail.com Tue Jan 22 10:06:14 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Tue, 22 Jan 2013 11:06:14 +0100 Subject: Review Request: 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh In-Reply-To: <50FE6406.1080803@oracle.com> References: <50FE6406.1080803@oracle.com> Message-ID: Ok! 2013/1/22 Erik Joelsson : > Adding functionality to compare.sh to take two zip/jar files as arguments > and just compare those. > > http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/ > > /Erik From erik.joelsson at oracle.com Tue Jan 22 10:18:00 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 22 Jan 2013 11:18:00 +0100 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <50ED6D21.5080604@oracle.com> References: <50EC20A9.3020604@oracle.com> <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> <50ECDC6F.7010602@oracle.com> <50ED6D21.5080604@oracle.com> Message-ID: <50FE6758.2070603@oracle.com> New webrev for this: http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/ I changed the sed to only remove the -R argument and made it conditional on cross compilation. A bit of background on this. The X_LIBS variable is created by autoconf by calling some special macros to locate libraries needed for X11. On some systems nothing extra is needed and X_LIBS is left empty, but on some, extra -L arguments are needed. Autoconf then also adds -R to put these extra paths in the runtime search path for the built library/executable. In the case where we cross compile, the extra -R paths are unwanted however. On the build host, autoconf will typically find them in something like /path/to/cross-toolkit/lib. This directory is unlikely to exist on the target host. The extra rpath entry in the built binary is usually harmless, but also not correct. The main point though is that it wasn't there in the old build and that's why we are trying to remove it in the new. /Erik On 2013-01-09 14:14, Erik Joelsson wrote: > 8003958 fixes this for sizer generation yes, but there is also one > library in CompileNativeLibraries that has X_LIBS on the link line. > But I suppose we shouldn't fix it unless there is a problem with it. > > /Erik > > On 2013-01-09 03:56, David Holmes wrote: >> On 9/01/2013 5:56 AM, Kelly O'Hair wrote: >>> I need more info on this, what is X_LIBS for, and why remove ALL -R >>> options. >> >> IIRC Fredrik added this to deal with some binary difference detected >> on OSX. I don't know what these variables actually contain >> >>> I always considered the -R options to be LD options, not library >>> specifications really. >>> The -L and -l options are library specifications, but -R is just a >>> path that gets baked into the .so >>> for runtime access to the libraries, the paths don't have to exist >>> at build time. >> >> The paths that get baked in at build time may not exist at runtime. >> >> Also for cross-compilation the -R option is not recognized - which is >> what >> >> https://jbs.oracle.com/bugs/browse/JDK-8003958 >> >> build-infra: Cross-compilation of sizers utility has been broken >> >> is all about. So these two bugs seems to be overlapping somewhat - >> but the real fix is 8003958. >> >> David >> ----- >> >>> -kto >>> >>> On Jan 8, 2013, at 5:35 AM, Erik Joelsson wrote: >>> >>>> Filter away -R flags from X_LIBS variable in configure. >>>> >>>> http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ >>> From david.holmes at oracle.com Tue Jan 22 11:06:46 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 22 Jan 2013 21:06:46 +1000 Subject: Review Request: 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER In-Reply-To: <50FE5848.5000600@oracle.com> References: <50FE5848.5000600@oracle.com> Message-ID: <50FE72C6.3090809@oracle.com> Looks good to me. Thanks, David On 22/01/2013 7:13 PM, Erik Joelsson wrote: > In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable. > But by mistake, JDK_BUILD_NUMBER could get picked up from the > environment while MILESTONE couldn't. They should behave the same and at > this time, listening to the environment is needed. > > http://cr.openjdk.java.net/~erikj/8006658/webrev.root.01/ > > /Erik From david.holmes at oracle.com Tue Jan 22 11:09:15 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 22 Jan 2013 21:09:15 +1000 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <50FE6758.2070603@oracle.com> References: <50EC20A9.3020604@oracle.com> <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> <50ECDC6F.7010602@oracle.com> <50ED6D21.5080604@oracle.com> <50FE6758.2070603@oracle.com> Message-ID: <50FE735B.6060904@oracle.com> Okay. I can't attest to the accuracy of the sed command but I agree with the intent :) Though I'm not sure there still exists any place where we use X_LIBS if cross-compiling. Thanks, David On 22/01/2013 8:18 PM, Erik Joelsson wrote: > New webrev for this: > > http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/ > > I changed the sed to only remove the -R argument and made it conditional > on cross compilation. > > A bit of background on this. The X_LIBS variable is created by autoconf > by calling some special macros to locate libraries needed for X11. On > some systems nothing extra is needed and X_LIBS is left empty, but on > some, extra -L arguments are needed. Autoconf then also adds -R to put > these extra paths in the runtime search path for the built > library/executable. > > In the case where we cross compile, the extra -R paths are unwanted > however. On the build host, autoconf will typically find them in > something like /path/to/cross-toolkit/lib. This directory is unlikely to > exist on the target host. The extra rpath entry in the built binary is > usually harmless, but also not correct. The main point though is that it > wasn't there in the old build and that's why we are trying to remove it > in the new. > > /Erik > > On 2013-01-09 14:14, Erik Joelsson wrote: >> 8003958 fixes this for sizer generation yes, but there is also one >> library in CompileNativeLibraries that has X_LIBS on the link line. >> But I suppose we shouldn't fix it unless there is a problem with it. >> >> /Erik >> >> On 2013-01-09 03:56, David Holmes wrote: >>> On 9/01/2013 5:56 AM, Kelly O'Hair wrote: >>>> I need more info on this, what is X_LIBS for, and why remove ALL -R >>>> options. >>> >>> IIRC Fredrik added this to deal with some binary difference detected >>> on OSX. I don't know what these variables actually contain >>> >>>> I always considered the -R options to be LD options, not library >>>> specifications really. >>>> The -L and -l options are library specifications, but -R is just a >>>> path that gets baked into the .so >>>> for runtime access to the libraries, the paths don't have to exist >>>> at build time. >>> >>> The paths that get baked in at build time may not exist at runtime. >>> >>> Also for cross-compilation the -R option is not recognized - which is >>> what >>> >>> https://jbs.oracle.com/bugs/browse/JDK-8003958 >>> >>> build-infra: Cross-compilation of sizers utility has been broken >>> >>> is all about. So these two bugs seems to be overlapping somewhat - >>> but the real fix is 8003958. >>> >>> David >>> ----- >>> >>>> -kto >>>> >>>> On Jan 8, 2013, at 5:35 AM, Erik Joelsson wrote: >>>> >>>>> Filter away -R flags from X_LIBS variable in configure. >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ >>>> From dmitry.samersoff at oracle.com Tue Jan 22 14:49:19 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 22 Jan 2013 18:49:19 +0400 Subject: Review Request: 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh In-Reply-To: <50FE6406.1080803@oracle.com> References: <50FE6406.1080803@oracle.com> Message-ID: <50FEA6EF.3000407@oracle.com> Erik, What is the purpose of this comparison. Is it time critical? On a brief look unzip -v > /tmp/1 unzip -v > /tmp/2 diff /tmp/1 /tmp/2 do exactly the same but much much faster. Maybe I missed something. -Dmitry On 2013-01-22 14:03, Erik Joelsson wrote: > Adding functionality to compare.sh to take two zip/jar files as > arguments and just compare those. > > http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/ > > /Erik -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From erik.joelsson at oracle.com Tue Jan 22 15:05:17 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 22 Jan 2013 16:05:17 +0100 Subject: Review Request: 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh In-Reply-To: <50FEA6EF.3000407@oracle.com> References: <50FE6406.1080803@oracle.com> <50FEA6EF.3000407@oracle.com> Message-ID: <50FEAAAD.800@oracle.com> Hello, The purpose of compare.sh is to compare build output between builds to check that nothing changed that shouldn't have. It has been developed and used in the build-infra project. Several file types need extra care when comparing and various exceptions to be made. For example zip and jar files need their contents compared rather than the files. Generated class, java and properties files often contain timestamps or other build unique strings that need to be filtered. All of this is handled in compare.sh. The problem in this case was that the UI available from compare.sh only lets you compare full build output directories. This patch adds a way to use the existing functionality for only 2 jar or zip files. I implemented it as part of converting the nashorn build to be able to verify that I produced an equivalent jar to the old ant build, but thought it would be worth pushing it in on its own. Your suggested solution is basically what compare.sh does with a zip file, but doesn't handle all the exceptions and special cases specific to openjdk build output. /Erik On 2013-01-22 15:49, Dmitry Samersoff wrote: > Erik, > > What is the purpose of this comparison. Is it time critical? > > On a brief look > > unzip -v> /tmp/1 > unzip -v> /tmp/2 > diff /tmp/1 /tmp/2 > > do exactly the same but much much faster. > > Maybe I missed something. > > -Dmitry > > > On 2013-01-22 14:03, Erik Joelsson wrote: >> Adding functionality to compare.sh to take two zip/jar files as >> arguments and just compare those. >> >> http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/ >> >> /Erik > From dmitry.samersoff at oracle.com Tue Jan 22 15:11:42 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 22 Jan 2013 19:11:42 +0400 Subject: Review Request: 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh In-Reply-To: <50FEAAAD.800@oracle.com> References: <50FE6406.1080803@oracle.com> <50FEA6EF.3000407@oracle.com> <50FEAAAD.800@oracle.com> Message-ID: <50FEAC2E.1000104@oracle.com> Erik, Thank you for explanation! -Dmitry On 2013-01-22 19:05, Erik Joelsson wrote: > Hello, > > The purpose of compare.sh is to compare build output between builds to > check that nothing changed that shouldn't have. It has been developed > and used in the build-infra project. Several file types need extra care > when comparing and various exceptions to be made. For example zip and > jar files need their contents compared rather than the files. Generated > class, java and properties files often contain timestamps or other build > unique strings that need to be filtered. All of this is handled in > compare.sh. > > The problem in this case was that the UI available from compare.sh only > lets you compare full build output directories. This patch adds a way to > use the existing functionality for only 2 jar or zip files. I > implemented it as part of converting the nashorn build to be able to > verify that I produced an equivalent jar to the old ant build, but > thought it would be worth pushing it in on its own. > > Your suggested solution is basically what compare.sh does with a zip > file, but doesn't handle all the exceptions and special cases specific > to openjdk build output. > > /Erik > > On 2013-01-22 15:49, Dmitry Samersoff wrote: >> Erik, >> >> What is the purpose of this comparison. Is it time critical? >> >> On a brief look >> >> unzip -v> /tmp/1 >> unzip -v> /tmp/2 >> diff /tmp/1 /tmp/2 >> >> do exactly the same but much much faster. >> >> Maybe I missed something. >> >> -Dmitry >> >> >> On 2013-01-22 14:03, Erik Joelsson wrote: >>> Adding functionality to compare.sh to take two zip/jar files as >>> arguments and just compare those. >>> >>> http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/ >>> >>> /Erik >> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From tim.bell at oracle.com Tue Jan 22 16:36:00 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 22 Jan 2013 08:36:00 -0800 Subject: Review Request: 8005855: build-infra: Remove -R flag when cross compiling In-Reply-To: <50FE6758.2070603@oracle.com> References: <50EC20A9.3020604@oracle.com> <385FF28A-CF2E-4567-8DE9-D98216EE7D62@oracle.com> <50ECDC6F.7010602@oracle.com> <50ED6D21.5080604@oracle.com> <50FE6758.2070603@oracle.com> Message-ID: <50FEBFF0.2050106@oracle.com> Hi Erik: > New webrev for this: > > http://cr.openjdk.java.net/~erikj/8005855/webrev.root.02/ > > I changed the sed to only remove the -R argument and made it > conditional on cross compilation. Looks good. Thanks for the background! Tim > A bit of background on this. The X_LIBS variable is created by > autoconf by calling some special macros to locate libraries needed for > X11. On some systems nothing extra is needed and X_LIBS is left empty, > but on some, extra -L arguments are needed. Autoconf then also adds -R > to put these extra paths in the runtime search path for the built > library/executable. > > In the case where we cross compile, the extra -R paths are unwanted > however. On the build host, autoconf will typically find them in > something like /path/to/cross-toolkit/lib. This directory is unlikely > to exist on the target host. The extra rpath entry in the built binary > is usually harmless, but also not correct. The main point though is > that it wasn't there in the old build and that's why we are trying to > remove it in the new. > > /Erik > > On 2013-01-09 14:14, Erik Joelsson wrote: >> 8003958 fixes this for sizer generation yes, but there is also one >> library in CompileNativeLibraries that has X_LIBS on the link line. >> But I suppose we shouldn't fix it unless there is a problem with it. >> >> /Erik >> >> On 2013-01-09 03:56, David Holmes wrote: >>> On 9/01/2013 5:56 AM, Kelly O'Hair wrote: >>>> I need more info on this, what is X_LIBS for, and why remove ALL -R >>>> options. >>> >>> IIRC Fredrik added this to deal with some binary difference detected >>> on OSX. I don't know what these variables actually contain >>> >>>> I always considered the -R options to be LD options, not library >>>> specifications really. >>>> The -L and -l options are library specifications, but -R is just a >>>> path that gets baked into the .so >>>> for runtime access to the libraries, the paths don't have to exist >>>> at build time. >>> >>> The paths that get baked in at build time may not exist at runtime. >>> >>> Also for cross-compilation the -R option is not recognized - which >>> is what >>> >>> https://jbs.oracle.com/bugs/browse/JDK-8003958 >>> >>> build-infra: Cross-compilation of sizers utility has been broken >>> >>> is all about. So these two bugs seems to be overlapping somewhat - >>> but the real fix is 8003958. >>> >>> David >>> ----- >>> >>>> -kto >>>> >>>> On Jan 8, 2013, at 5:35 AM, Erik Joelsson wrote: >>>> >>>>> Filter away -R flags from X_LIBS variable in configure. >>>>> >>>>> http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ >>>> From tim.bell at oracle.com Tue Jan 22 16:58:24 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 22 Jan 2013 08:58:24 -0800 Subject: Review Request: 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh In-Reply-To: <50FE6406.1080803@oracle.com> References: <50FE6406.1080803@oracle.com> Message-ID: <50FEC530.6000909@oracle.com> Erik: > Adding functionality to compare.sh to take two zip/jar files as > arguments and just compare those. > > http://cr.openjdk.java.net/~erikj/8006663/webrev.root.01/ Looks good. Tim From tim.bell at oracle.com Tue Jan 22 17:01:37 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 22 Jan 2013 09:01:37 -0800 Subject: Review Request: 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER In-Reply-To: References: <50FE5848.5000600@oracle.com> Message-ID: <50FEC5F1.6090104@oracle.com> Hi Erik Looks good to me as well. Tim On 01/22/13 01:38, Fredrik ?hrstr?m wrote: > Ok! > > 2013/1/22 Erik Joelsson : >> In JDK-8001895, MILESTONE and JDK_BUILD_NUMBER were made customizable. But >> by mistake, JDK_BUILD_NUMBER could get picked up from the environment while >> MILESTONE couldn't. They should behave the same and at this time, listening >> to the environment is needed. >> >> http://cr.openjdk.java.net/~erikj/8006658/webrev.root.01/ >> >> /Erik From eric.mccorkle at oracle.com Tue Jan 22 18:47:32 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 22 Jan 2013 13:47:32 -0500 Subject: Review makefile changes for JDK-8004729: Method parameter reflection API Message-ID: <50FEDEC4.7090601@oracle.com> Hello, Please review and approve the makefile changes for JDK-8004729. This patch add a native method (getParameters0) to the Executable class, and uses the JVM_GetMethodParameters function exported from the JVM. http://cr.openjdk.java.net/~emc/8004729/webrev.00/ For more discussion of the feature, see the review on core-libs-dev. Thanks, Eric From Alan.Bateman at oracle.com Tue Jan 22 19:52:35 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 22 Jan 2013 19:52:35 +0000 Subject: Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50FEE3F0.40906@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> <50FEE3F0.40906@oracle.com> Message-ID: <50FEEE03.4080701@oracle.com> On 22/01/2013 19:09, Xueming Shen wrote: > Hi, > > Webrev has been updated to address the build issue in the > new build infra. M > > (1) added the java.time packages into > common/makefiles.javadoc/CORE_PKGS.gmk > to be included into ct.sym > > http://cr.openjdk.java.net/~sherman/8003680/webrev_ctrl/ > > (2) not sure which one should be used for lib/tzdb.jar. It > appears > the tzdb.jar will not be picked for "images" if use > $(JDK_OUTPUTDIR)/lib and > it does not get copied for "overlay-image", if use > $(IMAGES_OUTPUTDIR)/lib. > Guess something need to be tweak in Images.gmk. But I'm running out of > time, > so now I copy the tzdb into both to make both happy for M6. > > http://cr.openjdk.java.net/~sherman/8003680/webrev/makefiles/GendataTZDB.gmk.html > cc'ing build-dev as I think you need Erik or Kelly to comment on this. I'm not an expert on the new build but I think you just need to add something like this to CreateJars.gmk: $(IMAGES_OUTPUTDIR)/lib/tzdb.jar: $(JDK_OUTPUTDIR)/lib/tzdb.jar $(install-file) JARS += $(IMAGES_OUTPUTDIR)/lib/tzdb.jar and remove the copying that you are doing in GendataTZDB.gmk. I looked at the changes to the top-level repo and the changes look fine to me. -Alan. From mike.duigou at oracle.com Tue Jan 22 21:15:49 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 22 Jan 2013 13:15:49 -0800 Subject: RFR : 8006594/8006595 : Define jdk_core test set Message-ID: <216D5987-F917-473E-98EF-C84BAB302C53@oracle.com> Hello all; This is a two piece patch. 8006594: Add jdk_core target to jdk/test/Makefile 8006595: Use jdk/test/Makefile targets in preference to local definitions I chose to do it as two patches because the changes are in different repos and the changes in 8006594 could be committed without the 8006595 changes. The webrevs are: http://cr.openjdk.java.net/~mduigou/8006594/0/webrev/ http://cr.openjdk.java.net/~mduigou/8006595/0/webrev/ The overall goal is to provide a target to the top level OpenJDK for a core set of tests. ie. make test TEST=jdk_core The "core" test set is the set of JDK tests which should be run to smoketest prior to posting a webrev or committing any OpenJDK change or for nightly regression testing. These patches are the first of a planned series of patches to incrementally improve test execution and the selection of tests. I would like to commit these changes to jdk8/build repo so will need a committer from that project to push the changes for me once reviewed. Mike From mike.duigou at oracle.com Tue Jan 22 21:27:08 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 22 Jan 2013 13:27:08 -0800 Subject: RFR: 8006709 : Add minimal support of MacOSX platform for JDK NetBeans Projects Message-ID: <1C444A52-9B11-41BB-8B73-990097AC914C@oracle.com> Hello all; This is a patch that has been lingering around in the lambda/lambda repo for a long time. It adds minimal support for the MacOSX platform to the JDK NetBeans projects. It could also be used as the basis for similar support for the langtools NetBeans projects. The patch also adjust the source level of the project to 1.8 and removes some long obsolete cruft. http://cr.openjdk.java.net/~mduigou/8006709/0/webrev/ Mike From david.holmes at oracle.com Tue Jan 22 22:19:48 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 23 Jan 2013 08:19:48 +1000 Subject: Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50FEEE03.4080701@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> <50FEE3F0.40906@oracle.com> <50FEEE03.4080701@oracle.com> Message-ID: <50FF1084.1070404@oracle.com> On 23/01/2013 5:52 AM, Alan Bateman wrote: > On 22/01/2013 19:09, Xueming Shen wrote: >> Hi, >> >> Webrev has been updated to address the build issue in the >> new build infra. M >> >> (1) added the java.time packages into >> common/makefiles.javadoc/CORE_PKGS.gmk >> to be included into ct.sym >> >> http://cr.openjdk.java.net/~sherman/8003680/webrev_ctrl/ >> >> (2) not sure which one should be used for lib/tzdb.jar. It >> appears >> the tzdb.jar will not be picked for "images" if use >> $(JDK_OUTPUTDIR)/lib and >> it does not get copied for "overlay-image", if use >> $(IMAGES_OUTPUTDIR)/lib. >> Guess something need to be tweak in Images.gmk. But I'm running out of >> time, >> so now I copy the tzdb into both to make both happy for M6. >> >> http://cr.openjdk.java.net/~sherman/8003680/webrev/makefiles/GendataTZDB.gmk.html >> > cc'ing build-dev as I think you need Erik or Kelly to comment on this. > > I'm not an expert on the new build but I think you just need to add > something like this to CreateJars.gmk: > > $(IMAGES_OUTPUTDIR)/lib/tzdb.jar: $(JDK_OUTPUTDIR)/lib/tzdb.jar > $(install-file) > > JARS += $(IMAGES_OUTPUTDIR)/lib/tzdb.jar > > and remove the copying that you are doing in GendataTZDB.gmk. I'd also like Erik's input on this. All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable) to build into jdk/lib and then copy over. That said all other jar creation is handled via CreateJars.gmk so perhaps this does need a special case. But again I'd like the build-infra experts to comment on it. This isn't a blocker. I just want to make sure we have a good resolution to the issue. I also verified the new build approach with cross-compilation - everything good! Thanks, David > I looked at the changes to the top-level repo and the changes look fine > to me. > > -Alan. From Alan.Bateman at oracle.com Tue Jan 22 22:58:19 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 22 Jan 2013 22:58:19 +0000 Subject: Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50FF1084.1070404@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> <50FEE3F0.40906@oracle.com> <50FEEE03.4080701@oracle.com> <50FF1084.1070404@oracle.com> Message-ID: <50FF198B.8060009@oracle.com> On 22/01/2013 22:19, David Holmes wrote: > All of the jar building was modified so that jars go into images/lib > not jdk/lib. So it should not be necessary (or desirable) to build > into jdk/lib and then copy over. Sherman can confirm, but I believe the TzdbZoneRulesProvider requires it in the lib directory so it would need to in jdk/lib when running/testing without in a non-images build. -Alan. From david.holmes at oracle.com Wed Jan 23 00:02:41 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 23 Jan 2013 10:02:41 +1000 Subject: Review makefile changes for JDK-8004729: Method parameter reflection API In-Reply-To: <50FEDEC4.7090601@oracle.com> References: <50FEDEC4.7090601@oracle.com> Message-ID: <50FF28A1.8030403@oracle.com> Hi Eric, On 23/01/2013 4:47 AM, Eric McCorkle wrote: > Hello, > > Please review and approve the makefile changes for JDK-8004729. > > This patch add a native method (getParameters0) to the Executable class, > and uses the JVM_GetMethodParameters function exported from the JVM. > > http://cr.openjdk.java.net/~emc/8004729/webrev.00/ > > For more discussion of the feature, see the review on core-libs-dev. The build changes look okay to me and there is no impact on the new build AFAICS. Tim is also taking a look. David > Thanks, > Eric From david.holmes at oracle.com Wed Jan 23 00:14:25 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 23 Jan 2013 10:14:25 +1000 Subject: Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50FF1BD7.7090707@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> <50FEE3F0.40906@oracle.com> <50FEEE03.4080701@oracle.com> <50FF1084.1070404@oracle.com> <50FF198B.8060009@oracle.com> <50FF1BD7.7090707@oracle.com> Message-ID: <50FF2B61.2010101@oracle.com> On 23/01/2013 9:08 AM, Xueming Shen wrote: > On 01/22/2013 02:58 PM, Alan Bateman wrote: >> On 22/01/2013 22:19, David Holmes wrote: >>> All of the jar building was modified so that jars go into images/lib >>> not jdk/lib. So it should not be necessary (or desirable) to build >>> into jdk/lib and then copy over. >> Sherman can confirm, but I believe the TzdbZoneRulesProvider requires >> it in the lib directory so it would need to in jdk/lib when >> running/testing without in a non-images build. >> >> -Alan. > > tzdb.jar is special that it is a data file in jar format. It's not a jar > for classes. > It needs to be generated in jdk/lib (non-images build) for developing and > testing. Okay - sounds reasonable then. Thanks, David > -Sherman From tim.bell at oracle.com Wed Jan 23 01:14:33 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 22 Jan 2013 17:14:33 -0800 Subject: Review makefile changes for JDK-8004729: Method parameter reflection API In-Reply-To: <50FF28A1.8030403@oracle.com> References: <50FEDEC4.7090601@oracle.com> <50FF28A1.8030403@oracle.com> Message-ID: <50FF3979.7050904@oracle.com> On 01/22/13 16:02, David Holmes wrote: > Hi Eric, > > On 23/01/2013 4:47 AM, Eric McCorkle wrote: >> Hello, >> >> Please review and approve the makefile changes for JDK-8004729. >> >> This patch add a native method (getParameters0) to the Executable class, >> and uses the JVM_GetMethodParameters function exported from the JVM. >> >> http://cr.openjdk.java.net/~emc/8004729/webrev.00/ >> >> For more discussion of the feature, see the review on core-libs-dev. > > The build changes look okay to me and there is no impact on the new > build AFAICS. > > Tim is also taking a look. The build changes look fine to me. This is not Makefile related, but I wonder whether you need lines 33...40 of src/share/native/java/lang/reflect/Executable.c. Is that #define and comment serving a purpose? I did not find anything similar in nearby source files. Tim From eric.mccorkle at oracle.com Wed Jan 23 03:53:28 2013 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 22 Jan 2013 22:53:28 -0500 Subject: Review makefile changes for JDK-8004729: Method parameter reflection API In-Reply-To: <50FF3979.7050904@oracle.com> References: <50FEDEC4.7090601@oracle.com> <50FF28A1.8030403@oracle.com> <50FF3979.7050904@oracle.com> Message-ID: <50FF5EB8.1050503@oracle.com> On 01/22/13 20:14, Tim Bell wrote: > On 01/22/13 16:02, David Holmes wrote: >> Hi Eric, >> >> On 23/01/2013 4:47 AM, Eric McCorkle wrote: >>> Hello, >>> >>> Please review and approve the makefile changes for JDK-8004729. >>> >>> This patch add a native method (getParameters0) to the Executable class, >>> and uses the JVM_GetMethodParameters function exported from the JVM. >>> >>> http://cr.openjdk.java.net/~emc/8004729/webrev.00/ >>> >>> For more discussion of the feature, see the review on core-libs-dev. >> >> The build changes look okay to me and there is no impact on the new >> build AFAICS. >> >> Tim is also taking a look. > > The build changes look fine to me. > > This is not Makefile related, but I wonder whether you need lines > 33...40 of src/share/native/java/lang/reflect/Executable.c. Is that > #define and comment serving a purpose? I did not find anything similar > in nearby source files. > It was left-over code that hadn't gotten removed. It's gone now. Thanks for the reviews, all! > Tim > From erik.joelsson at oracle.com Wed Jan 23 09:43:41 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 23 Jan 2013 10:43:41 +0100 Subject: Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50FF2B61.2010101@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> <50FEE3F0.40906@oracle.com> <50FEEE03.4080701@oracle.com> <50FF1084.1070404@oracle.com> <50FF198B.8060009@oracle.com> <50FF1BD7.7090707@oracle.com> <50FF2B61.2010101@oracle.com> Message-ID: <50FFB0CD.3050109@oracle.com> On 2013-01-23 01:14, David Holmes wrote: > On 23/01/2013 9:08 AM, Xueming Shen wrote: >> On 01/22/2013 02:58 PM, Alan Bateman wrote: >>> On 22/01/2013 22:19, David Holmes wrote: >>>> All of the jar building was modified so that jars go into images/lib >>>> not jdk/lib. So it should not be necessary (or desirable) to build >>>> into jdk/lib and then copy over. >>> Sherman can confirm, but I believe the TzdbZoneRulesProvider requires >>> it in the lib directory so it would need to in jdk/lib when >>> running/testing without in a non-images build. >>> >>> -Alan. >> >> tzdb.jar is special that it is a data file in jar format. It's not a jar >> for classes. >> It needs to be generated in jdk/lib (non-images build) for developing >> and >> testing. > > Okay - sounds reasonable then. > David is indeed correct with how we would like to have it. But I can understand the exception explained by Alan, so I think this is ok and the correct way of doing it. /Erik From Alan.Bateman at oracle.com Wed Jan 23 14:35:07 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 Jan 2013 14:35:07 +0000 Subject: RFR : 8006594/8006595 : Define jdk_core test set In-Reply-To: <216D5987-F917-473E-98EF-C84BAB302C53@oracle.com> References: <216D5987-F917-473E-98EF-C84BAB302C53@oracle.com> Message-ID: <50FFF51B.1030809@oracle.com> On 22/01/2013 21:15, Mike Duigou wrote: > Hello all; > > This is a two piece patch. > > 8006594: Add jdk_core target to jdk/test/Makefile > 8006595: Use jdk/test/Makefile targets in preference to local definitions > > I chose to do it as two patches because the changes are in different repos and the changes in 8006594 could be committed without the 8006595 changes. > > The webrevs are: > > http://cr.openjdk.java.net/~mduigou/8006594/0/webrev/ The changes in this one look okay to me but doesn't it mean that not all targets will be run if there is a test failure? For example, if a test in the jdk_lang target failures then I assume this will cause make to abort and none of the other test targets will run. The other thing that is that I assume this means the results are in scattered locations where I would think that anyone doing "make test TEST=jdk_core" would expect to get one set of results. As an aside, I personally prefer to run jtreg directly and I keep a "core.list" with the exploded list of directories that corresponds to jdk_core in this webrev. The nice thing about it is that it is one jtreg run so all the results in together and easily browsed. You mentioned that this is the in a series of patches so you might be looking into moving in that direction too. > > http://cr.openjdk.java.net/~mduigou/8006595/0/webrev/ The comment on L83 says "everything", maybe that should be updated (it was wrong before your change too). Otherwise I think this is okay. It's a pity that we have the list of targets in so many places, it's so easy to have mis-matches. You mentioned pushing this via jdk8/build but it's probably okay to push it via jdk8/tl because the build doesn't care about the test Makefiles. -Alan. From jonathan.gibbons at oracle.com Wed Jan 23 15:45:54 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 23 Jan 2013 07:45:54 -0800 Subject: RFR : 8006594/8006595 : Define jdk_core test set In-Reply-To: <50FFF51B.1030809@oracle.com> References: <216D5987-F917-473E-98EF-C84BAB302C53@oracle.com> <50FFF51B.1030809@oracle.com> Message-ID: <510005B2.5080706@oracle.com> On 01/23/2013 06:35 AM, Alan Bateman wrote: > > The other thing that is that I assume this means the results are in > scattered locations where I would think that anyone doing "make test > TEST=jdk_core" would expect to get one set of results. As an aside, I > personally prefer to run jtreg directly and I keep a "core.list" with > the exploded list of directories that corresponds to jdk_core in this > webrev. The nice thing about it is that it is one jtreg run so all the > results in together and easily browsed. You mentioned that this is the > in a series of patches so you might be looking into moving in that > direction too. I agree that it would be good to have a target that is capable of running the tests in a single batch, even if this target is not normally used by JPRT. -- Jon From kelly.ohair at oracle.com Wed Jan 23 18:25:05 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 23 Jan 2013 10:25:05 -0800 Subject: Encoding problem when building In-Reply-To: <50F8F2CE.404@linux.vnet.ibm.com> References: <50E121C0.7000209@linux.vnet.ibm.com> <50E668BC.6060704@linux.vnet.ibm.com> <50E7BC35.5040409@linux.vnet.ibm.com> <50EBB5CF.3090505@linux.vnet.ibm.com> <50F8F2CE.404@linux.vnet.ibm.com> Message-ID: Getting an Open JBS system is one of our top priority issues, it's happening, just so damn slowly. sorry. -kto On Jan 17, 2013, at 10:59 PM, Frank Ding wrote: > Hi kto, > Thank you. Somehow I think we cannot submit bugs since the new JBS system. > > Best regards, > Frank > On 1/10/2013 1:27 AM, Kelly O'Hair wrote: >> I don't know where this bug has been filed. >> >> I will file one in the new JBS system. >> JDK-8005947 - Windows builds in Chinese environment create generated files with Chinese characters >> >> It's P4 for now. I can adjust it to P3 but we think we can fix it, but right now my team is swamped. >> >> >> -kto >> >> On Jan 7, 2013, at 9:59 PM, Frank Ding wrote: >> >>> Hi Kelly, >>> I have filed a bug whose internal review id is 2421470. It was filed with "Product/Category" being "JDK/JRE" and "Subcategory" being "Problems common to more than one tool". I am wondering since it only happens when building OpenJDK, is it eligible for a Java bug? >>> In addition, do you have any idea on how to force java programs such as idlj to use ascii? >>> >>> Best regards, >>> Frank >>> >>> On 1/8/2013 3:42 AM, Kelly O'Hair wrote: >>>> Did a bug report get filed for this issue? >>>> >>>> -kto >>>> >>>> On Jan 4, 2013, at 9:37 PM, Frank Ding wrote: >>>> >>>>> Hi Volker, >>>>> Yes, I think so. The comment is pasted below. >>>>> /** >>>>> * org/omg/PortableServer/Current.java . >>>>> * ?IDL-to-Java ??? (???), ?? "3.2"?? >>>>> * ?../../../../src/share/classes/org/omg/PortableServer/poa.idl >>>>> * 2013?1?4? ??? ??01?21?01? CST >>>>> */ >>>>> >>>>> It's in Chinese, and it says when translated to English that "Generated by IDL-to-Java compiler(portable) version 3.2 and the date. You can also view a "normal" English one under openjdk folder "corba\gensrc\" after performing a build. >>>>> >>>>> An relevant question is that in my env (export LANG=C), java output without any param always gives me Chinese help. Even though we may find out which env var or value jvm reads on startup, it could be impossible to change them. Any insight or idea on the mechanism is welcome. >>>>> >>>>> Best regards, >>>>> Frank >>>>> >>>>> On 1/4/2013 4:59 PM, Volker Simonis wrote: >>>>>> This is just a wild guess, but perhaps idlj uses the value of some environment variables (or values derived from them - check System.getProperties()) which contain non ASCII characters? This could be something like PATH, HOSTNAME, USER. What exact characters are there in the comment and what kind of comment is it? How does this comment look on a "normal" system? >>>>>> >>>>>> Regards, >>>>>> Volker >>>>>> >>>>>> >>>>>> On Fri, Jan 4, 2013 at 6:29 AM, Frank Ding > wrote: >>>>>> >>>>>> Hi Kelly >>>>>> I investigated how local specific characters get into generated >>>>>> sources in corba module. Those classes are generated by following >>>>>> command idlj >>>>>> c:/openjdk/dep/jdk1.7.0_02/bin/idlj -J-XX:-PrintVMOptions >>>>>> -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m >>>>>> -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -td >>>>>> "c:/openjdk/ojdk8_ojdk_739/../ojdk8_ojdk_739-debug/corba/gensrc" >>>>>> -i "../../../../src/share/classes/org/omg/PortableServer" -i >>>>>> "../../../../src/share/classes/org/omg/PortableInterceptor" -corba >>>>>> 3.0 -fall -pkgPrefix PortableServer org.omg >>>>>> ../../../../src/share/classes/org/omg/PortableServer/poa.idl >>>>>> >>>>>> I checked idlj help but there is no encoding specific option. My >>>>>> locale environment vars are listed below >>>>>> >>>>>> $ locale >>>>>> LANG=C >>>>>> LC_CTYPE="C" >>>>>> LC_NUMERIC="C" >>>>>> LC_TIME="C" >>>>>> LC_COLLATE="C" >>>>>> LC_MONETARY="C" >>>>>> LC_MESSAGES="C" >>>>>> LC_ALL= >>>>>> >>>>>> Could you give me any hint about how to force idlj to generate >>>>>> ascii chars only? >>>>>> >>>>>> Best regards, >>>>>> Frank >>>>>> >>>>>> >>>>>> On 1/1/2013 12:47 AM, Kelly O'Hair wrote: >>>>>> >>>>>> In the past, the "-encoding ascii" was important, all the >>>>>> reasons I can't completely list right now. But it is important >>>>>> that regardless of the locale, the bits created during the >>>>>> build should be the same for everyone. >>>>>> The definition of "same" might not be bit for bit, but by >>>>>> minimizing the potential differences we have a fighting >>>>>> chance of measuring "the same". >>>>>> >>>>>> But my question is, how are any locale specific characters >>>>>> getting into generated sources? That's what we need to find out. >>>>>> >>>>>> Removing "-encoding ascii" is probably not the right answer, >>>>>> and if it is, will require some debate. >>>>>> >>>>>> -kto >>>>>> >>>>>> On Dec 30, 2012, at 9:25 PM, Frank Ding wrote: >>>>>> >>>>>> Hi >>>>>> I have an encoding problem when building openjdk 8 on my >>>>>> Windows 7. My windows is Chinese environment but I >>>>>> exported LANG=C in cygwin bash before building. The issue >>>>>> is that in module corba and jdk, some java classes are >>>>>> generated by program. They happen to contain Chinese >>>>>> characters in comment. However, they are compiled with >>>>>> explicit option "-encoding ascii" in makefile. This >>>>>> results in unrecognizable chars complained by javac >>>>>> (Error: encoding ascii unmappable chars) . I have a patch >>>>>> that removes all unnecessary "-encoding ascii" but I am >>>>>> not sure all its side effect. Shall I submit a bug? >>>>>> >>>>>> Best regards, >>>>>> Frank >>>>>> >>>>>> >>>>>> > From tim.bell at oracle.com Wed Jan 23 21:32:02 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 23 Jan 2013 21:32:02 +0000 Subject: hg: jdk8/build: 8006797: build-infra JPRT builds need JPRT_ARCHIVE_INSTALL_BUNDLE in common/makefiles/Jprt.gmk Message-ID: <20130123213203.116D2474E7@hg.openjdk.java.net> Changeset: c3bf62746a80 Author: tbell Date: 2013-01-23 13:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/c3bf62746a80 8006797: build-infra JPRT builds need JPRT_ARCHIVE_INSTALL_BUNDLE in common/makefiles/Jprt.gmk Reviewed-by: ohair ! common/makefiles/Jprt.gmk From dan.xu at oracle.com Wed Jan 23 22:20:11 2013 From: dan.xu at oracle.com (Dan Xu) Date: Wed, 23 Jan 2013 14:20:11 -0800 Subject: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code Message-ID: <5100621B.20600@oracle.com> Hi, I have a fix for JDK-8001334 to remove JVM_* functions and replace with direct system calls. It introduces newmake filechangesin IO area especially on Windows platform. Please help review and approve them. Bug: https://jbs.oracle.com/bugs/browse/JDK-8001334 webrev: http://cr.openjdk.java.net/~dxu/8001334/webrev.00/ Thanks, -Dan From martinrb at google.com Thu Jan 24 00:23:28 2013 From: martinrb at google.com (Martin Buchholz) Date: Wed, 23 Jan 2013 16:23:28 -0800 Subject: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code In-Reply-To: <5100621B.20600@oracle.com> References: <5100621B.20600@oracle.com> Message-ID: On Wed, Jan 23, 2013 at 2:20 PM, Dan Xu wrote: > Hi, > > I have a fix for JDK-8001334 to remove JVM_* functions and replace with > direct system calls. It introduces newmake filechangesin IO area especially > on Windows platform. Please help review and approve them. > > Bug: https://jbs.oracle.com/bugs/**browse/JDK-8001334 jbs seems to be down > > webrev: http://cr.openjdk.java.net/~**dxu/8001334/webrev.00/< > http://cr.openjdk.java.net/%**7Edxu/8001334/webrev.00/ > > > There seems to be little to no documentation on these various internal functions. E.g. How are read, IO_Read, and JVM_Read supposed to differ? Where's the interface doc? Many years ago I filed http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4904617 that remains unaddressed :-( Perhaps as part of this change or set of changes, that bug could be dealt with? Perhaps even by deleting JVM_Read? From david.katleman at oracle.com Thu Jan 24 00:26:10 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 24 Jan 2013 00:26:10 +0000 Subject: hg: jdk8/build: 6 new changesets Message-ID: <20130124002611.59554474F8@hg.openjdk.java.net> Changeset: 50307da0149e Author: jqzuo Date: 2012-12-31 14:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/rev/50307da0149e 8005583: Install build(gnumake all) failed preventing RE from doing JDK8 combo builds Reviewed-by: paulk, billyh ! make/install-rules.gmk Changeset: e5664599a127 Author: cgruszka Date: 2013-01-02 14:54 -0500 URL: http://hg.openjdk.java.net/jdk8/build/rev/e5664599a127 Merge Changeset: 75634cbeab47 Author: cgruszka Date: 2013-01-04 13:11 -0500 URL: http://hg.openjdk.java.net/jdk8/build/rev/75634cbeab47 Merge Changeset: 61d7e2971723 Author: cgruszka Date: 2013-01-14 14:40 -0500 URL: http://hg.openjdk.java.net/jdk8/build/rev/61d7e2971723 Merge Changeset: f9163f9cb1da Author: cgruszka Date: 2013-01-23 08:50 -0500 URL: http://hg.openjdk.java.net/jdk8/build/rev/f9163f9cb1da Merge Changeset: b43aa5bd8ca5 Author: katleman Date: 2013-01-23 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/b43aa5bd8ca5 Merge From joe.darcy at oracle.com Thu Jan 24 00:37:20 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Wed, 23 Jan 2013 16:37:20 -0800 Subject: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code In-Reply-To: References: <5100621B.20600@oracle.com> Message-ID: <51008240.8000004@oracle.com> On 1/23/2013 4:23 PM, Martin Buchholz wrote: > On Wed, Jan 23, 2013 at 2:20 PM, Dan Xu wrote: > >> Hi, >> >> I have a fix for JDK-8001334 to remove JVM_* functions and replace with >> direct system calls. It introduces newmake filechangesin IO area especially >> on Windows platform. Please help review and approve them. >> >> Bug: https://jbs.oracle.com/bugs/**browse/JDK-8001334 > > jbs seems to be down > jbs is not visible externally yet (being worked on). -Joe From erik.joelsson at oracle.com Thu Jan 24 09:58:48 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 24 Jan 2013 10:58:48 +0100 Subject: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code In-Reply-To: <5100621B.20600@oracle.com> References: <5100621B.20600@oracle.com> Message-ID: <510105D8.6030807@oracle.com> Hello, Makefile changes look fine to me. /Erik On 2013-01-23 23:20, Dan Xu wrote: > Hi, > > I have a fix for JDK-8001334 to remove JVM_* functions and replace > with direct system calls. It introduces newmake filechangesin IO area > especially on Windows platform. Please help review and approve them. > > Bug: https://jbs.oracle.com/bugs/browse/JDK-8001334 > webrev: http://cr.openjdk.java.net/~dxu/8001334/webrev.00/ > > > Thanks, > > -Dan From Alan.Bateman at oracle.com Thu Jan 24 11:12:12 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 24 Jan 2013 11:12:12 +0000 Subject: Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code In-Reply-To: References: <5100621B.20600@oracle.com> Message-ID: <5101170C.5000000@oracle.com> On 24/01/2013 00:23, Martin Buchholz wrote: > : > > Many years ago I filed > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4904617 > that remains unaddressed :-( > Perhaps as part of this change or set of changes, that bug could be dealt > with? > Perhaps even by deleting JVM_Read? I believe there is effort under way in the Common VM Interface project [1] to javadoc the interface between the VM and libraries. I don't think this needs to be part of Dan's work as his change is just eliminating the usage of these functions in the java.io code (we need to do the same eventually in the java.net code). -Alan [1] http://openjdk.java.net/projects/cvmi/ From erik.joelsson at oracle.com Thu Jan 24 11:15:57 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Thu, 24 Jan 2013 11:15:57 +0000 Subject: hg: jdk8/build: 4 new changesets Message-ID: <20130124111558.6C3BE4750E@hg.openjdk.java.net> Changeset: 0d4b0a13adb2 Author: erikj Date: 2013-01-23 11:37 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/0d4b0a13adb2 8005855: build-infra: Remove -R flag when cross compiling Reviewed-by: dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: ea6379d4624f Author: erikj Date: 2013-01-23 11:41 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/ea6379d4624f 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh Reviewed-by: tbell ! common/bin/compare.sh Changeset: 0d46733cfffb Author: erikj Date: 2013-01-23 11:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/0d46733cfffb 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER Reviewed-by: ohrstrom, dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: 9e5847257731 Author: erikj Date: 2013-01-24 09:17 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/9e5847257731 Merge From oehrstroem at gmail.com Thu Jan 24 19:57:59 2013 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 24 Jan 2013 20:57:59 +0100 Subject: Review Request: 8006872: build-infra: Stop creating 4 identical jars in langtools Message-ID: Stop creating 4 identical jars in langtools. The jars javac.jar,javap.jar,javah.jar and javadoc.jar contain the same content, except for a minor difference in the manifest that tells where the main class is. This is unnecessary, in particular since javap and javah are not used in the build. A single jar on the classpath followed by the main class name. E.g. -cp ....javac.jar com.sun.tools.javac.Main -cp ....javac.jar com.sun.tools.javadoc.Main is good enough. Also move the specification of how to run the boostrap javac into spec.gmk where it is called NEW_JAVAC. Everything should be pushable into the build repo. The change in langtools is so small that it does not need to be handled through tl. http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-root/ http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-langtools/ http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-corba/ http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-jaxp/ http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-jaxws/ http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-jdk/ //Fredrik From david.r.chase at oracle.com Thu Jan 24 21:44:59 2013 From: david.r.chase at oracle.com (David Chase) Date: Thu, 24 Jan 2013 16:44:59 -0500 Subject: Questionable new-build failure Message-ID: <0CD3B4D3-44A6-4FCF-82C9-C4D47142400F@oracle.com> I'm trying new-build on a Solaris 10 box, and it goes okay till this comparison: COMPARING /export/drchase/jdk8tl/build/solaris-x86_64-normal-server-fastdebug/jdk/gensrc_x11wrappers/sizer/sizes.64 and /export/drchase/jdk8tl/jdk/src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 The two files are identical if sorted, but the comparison does not pre-sort, and it fails after spewing all the differences. Any suggestions? Is this a bug, or yet another pilot error? I'm poking through WrapperGenerator.java to see if I see anything obvious. David From calderon.christian760 at gmail.com Thu Jan 24 22:33:19 2013 From: calderon.christian760 at gmail.com (Christian Calderon) Date: Thu, 24 Jan 2013 22:33:19 +0000 (UTC) Subject: Building OpenJDK for ppc64 Message-ID: Hi, I am wondering if anyone here has ever attempted an openjdk7 build for the ppc64 arch, or for ppc. I have compiled some things from source before, I am just looking for advice! This is gonna be on a PowerMac G5 running OS X 10.5.8. Thanks! From david.holmes at oracle.com Thu Jan 24 23:00:36 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 25 Jan 2013 09:00:36 +1000 Subject: Questionable new-build failure In-Reply-To: <0CD3B4D3-44A6-4FCF-82C9-C4D47142400F@oracle.com> References: <0CD3B4D3-44A6-4FCF-82C9-C4D47142400F@oracle.com> Message-ID: <5101BD14.8040903@oracle.com> On 25/01/2013 7:44 AM, David Chase wrote: > I'm trying new-build on a Solaris 10 box, and it goes okay till this comparison: > > COMPARING > /export/drchase/jdk8tl/build/solaris-x86_64-normal-server-fastdebug/jdk/gensrc_x11wrappers/sizer/sizes.64 > and > /export/drchase/jdk8tl/jdk/src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 > > The two files are identical if sorted, but the comparison does not pre-sort, and it fails after spewing all the differences. > > Any suggestions? Is this a bug, or yet another pilot error? It's a bug. Changes to this were only pushed in the past couple of days. As you note the generated file needs to be sorted before doing the comparison. David > I'm poking through WrapperGenerator.java to see if I see anything obvious. > > David > From david.holmes at oracle.com Thu Jan 24 23:02:52 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 25 Jan 2013 09:02:52 +1000 Subject: Building OpenJDK for ppc64 In-Reply-To: References: Message-ID: <5101BD9C.50102@oracle.com> Christian, On 25/01/2013 8:33 AM, Christian Calderon wrote: > Hi, I am wondering if anyone here has ever attempted an openjdk7 build for the > ppc64 arch, or for ppc. I have compiled some things from source before, I am > just looking for advice! This is gonna be on a PowerMac G5 running OS X 10.5.8. OpenJDK doesn't have a ppc port at this time. You'd have to take a look at using Zero from the IcedTea distribution. David > Thanks! > From volker.simonis at gmail.com Fri Jan 25 08:17:21 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 25 Jan 2013 09:17:21 +0100 Subject: Building OpenJDK for ppc64 In-Reply-To: References: Message-ID: Hi Christian, you can have a look at our OpenJDK PowerPC Port for Linux and AIX(it builds and runs on Linux/PPC64 ). Porting it to 32-bit PPC would be possible although I expect it to be quite an effort (i.e. assembler hacking) and we currently don't have any plans to do it (our focus will be Java 8 and the integration into the main branch). Regards, Volker On Thu, Jan 24, 2013 at 11:33 PM, Christian Calderon < calderon.christian760 at gmail.com> wrote: > Hi, I am wondering if anyone here has ever attempted an openjdk7 build for > the > ppc64 arch, or for ppc. I have compiled some things from source before, I > am > just looking for advice! This is gonna be on a PowerMac G5 running OS X > 10.5.8. > > Thanks! > > From tim.bell at oracle.com Fri Jan 25 10:36:33 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 25 Jan 2013 02:36:33 -0800 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations Message-ID: <51026031.7020200@oracle.com> Here is the bug report: http://bugs.sun.com/view_bug.do?bug_id=8006933 Use nawk instead of awk to avoid "awk: string too long near line 1" errors when running idlj in corba. For new 'build-infra' style builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk The errors are seen if the path to the build directory in the source tree is too long, greater than ~92. http://cr.openjdk.java.net/~tbell/8006933/00/ Thanks in advance for any feedback. Tim From david.holmes at oracle.com Fri Jan 25 11:31:14 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 25 Jan 2013 21:31:14 +1000 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51026031.7020200@oracle.com> References: <51026031.7020200@oracle.com> Message-ID: <51026D02.3010402@oracle.com> Hi Tim, On 25/01/2013 8:36 PM, Tim Bell wrote: > Here is the bug report: > http://bugs.sun.com/view_bug.do?bug_id=8006933 > > Use nawk instead of awk to avoid "awk: string too long near line 1" > errors when running idlj in corba. For new 'build-infra' style builds, > this needs to be fixed in common/makefiles/IdlCompilation.gmk Do we fix the old build in the corba repo too? > The errors are seen if the path to the build directory in the source > tree is too long, greater than ~92. > > http://cr.openjdk.java.net/~tbell/8006933/00/ > > Thanks in advance for any feedback. Can we also fix the fact that the failure doesn't cause make to detect the error? I think that is caused by the whole thing being executed in a sub-shell. David > Tim > From dmitry.samersoff at oracle.com Fri Jan 25 14:25:22 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 25 Jan 2013 18:25:22 +0400 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51026031.7020200@oracle.com> References: <51026031.7020200@oracle.com> Message-ID: <510295D2.7010503@oracle.com> Tim, It might be better to remove AWK completely $(FIND) . -type f | sed 's!\./!$3 : $4/!g' > $5 or ever find . -type f -printf "$3%s : $4\n" -Dmitry On 2013-01-25 14:36, Tim Bell wrote: > Here is the bug report: > http://bugs.sun.com/view_bug.do?bug_id=8006933 > > Use nawk instead of awk to avoid "awk: string too long near line 1" > errors when running idlj in corba. For new 'build-infra' style builds, > this needs to be fixed in common/makefiles/IdlCompilation.gmk > > The errors are seen if the path to the build directory in the source > tree is too long, greater than ~92. > > http://cr.openjdk.java.net/~tbell/8006933/00/ > > Thanks in advance for any feedback. > > Tim > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From dalibor.topic at oracle.com Fri Jan 25 09:14:38 2013 From: dalibor.topic at oracle.com (dalibor.topic at oracle.com) Date: Fri, 25 Jan 2013 10:14:38 +0100 Subject: JDK 8 Build Failure Message-ID: <51024CFE.6050504@oracle.com> I checked out jdk8/jdk8 and gave it a go using the new build system. It failed eventually with Generating exceptions classes Generating icon classes /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/jre/lib/rt.jar: invalid LOC header (bad signature) Exception in thread "main" java.lang.NoClassDefFoundError: sun/awt/image/SunWritableRaster$DataStealer at java.awt.image.DataBuffer.(DataBuffer.java:517) at javax.imageio.ImageTypeSpecifier.createComponentCM(ImageTypeSpecifier.java:249) at javax.imageio.ImageTypeSpecifier$Interleaved.(ImageTypeSpecifier.java:304) at javax.imageio.ImageTypeSpecifier.createInterleaved(ImageTypeSpecifier.java:399) at javax.imageio.ImageTypeSpecifier.createSpecifier(ImageTypeSpecifier.java:1169) at javax.imageio.ImageTypeSpecifier.getSpecifier(ImageTypeSpecifier.java:1118) at javax.imageio.ImageTypeSpecifier.createFromBufferedImageType(ImageTypeSpecifier.java:901) at com.sun.imageio.plugins.png.PNGImageReader.getImageTypes(PNGImageReader.java:1494) at com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1280) at com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1577) at javax.imageio.ImageIO.read(ImageIO.java:1448) at javax.imageio.ImageIO.read(ImageIO.java:1352) at sun.awt.X11.ToBin.main(ToBin.java:35) gmake[2]: *** [/media/OpenJDK/nashorn/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] Error 1 gmake[1]: *** [gensrc-only] Error 2 cheers, dalibor topic From kelly.ohair at oracle.com Fri Jan 25 21:49:07 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 25 Jan 2013 13:49:07 -0800 Subject: JDK 8 Build Failure In-Reply-To: <51024CFE.6050504@oracle.com> References: <51024CFE.6050504@oracle.com> Message-ID: <40A26397-4524-4132-A6B9-B32CA00E6C08@oracle.com> I would recommend you file a JBS Issue at this time. Don't know when we will be able to track it down. You might try again, with a clean slate, and use make JOBS=2 or make JOBS=1 -kto On Jan 25, 2013, at 1:14 AM, dalibor.topic at oracle.com wrote: > I checked out jdk8/jdk8 and gave it a go using the new build system. It failed eventually with > > Generating exceptions classes > Generating icon classes > /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/jre/lib/rt.jar: invalid LOC header (bad signature) > Exception in thread "main" java.lang.NoClassDefFoundError: sun/awt/image/SunWritableRaster$DataStealer > at java.awt.image.DataBuffer.(DataBuffer.java:517) > at javax.imageio.ImageTypeSpecifier.createComponentCM(ImageTypeSpecifier.java:249) > at javax.imageio.ImageTypeSpecifier$Interleaved.(ImageTypeSpecifier.java:304) > at javax.imageio.ImageTypeSpecifier.createInterleaved(ImageTypeSpecifier.java:399) > at javax.imageio.ImageTypeSpecifier.createSpecifier(ImageTypeSpecifier.java:1169) > at javax.imageio.ImageTypeSpecifier.getSpecifier(ImageTypeSpecifier.java:1118) > at javax.imageio.ImageTypeSpecifier.createFromBufferedImageType(ImageTypeSpecifier.java:901) > at com.sun.imageio.plugins.png.PNGImageReader.getImageTypes(PNGImageReader.java:1494) > at com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1280) > at com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1577) > at javax.imageio.ImageIO.read(ImageIO.java:1448) > at javax.imageio.ImageIO.read(ImageIO.java:1352) > at sun.awt.X11.ToBin.main(ToBin.java:35) > gmake[2]: *** [/media/OpenJDK/nashorn/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] Error 1 > gmake[1]: *** [gensrc-only] Error 2 > > cheers, > dalibor topic From kelly.ohair at oracle.com Fri Jan 25 21:55:31 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 25 Jan 2013 13:55:31 -0800 Subject: Questionable new-build failure In-Reply-To: <5101BD14.8040903@oracle.com> References: <0CD3B4D3-44A6-4FCF-82C9-C4D47142400F@oracle.com> <5101BD14.8040903@oracle.com> Message-ID: <4D1C915D-7C99-42A0-AAE2-33C8BD62931B@oracle.com> Please file JBS Issues. And keep in mind every "Solaris 10" system could be different. It depends on which Solaris 10 Update it is, and also potentially if it has all the latest patches or not. We try and use Solaris 10u6 for building, usually with all latest required and recommended patches. The changes to Solaris 10, via Updates and even patches has become quite aggressive, at least much more aggressive than in the past. Which creates quite a moving target for anyone using the utilities or expecting the exact same behaviors. I realize that this may be a goodness to some people. ;^) And it's not easy to determine what you have. Solaris 11 has introduced a 'uname -v' which will tell you if it is 11.0 or 11.1 (Update 1), but Solaris 10 does not have that. Best you can do is look at the /etc/release file. -kto On Jan 24, 2013, at 3:00 PM, David Holmes wrote: > On 25/01/2013 7:44 AM, David Chase wrote: >> I'm trying new-build on a Solaris 10 box, and it goes okay till this comparison: >> >> COMPARING >> /export/drchase/jdk8tl/build/solaris-x86_64-normal-server-fastdebug/jdk/gensrc_x11wrappers/sizer/sizes.64 >> and >> /export/drchase/jdk8tl/jdk/src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 >> >> The two files are identical if sorted, but the comparison does not pre-sort, and it fails after spewing all the differences. >> >> Any suggestions? Is this a bug, or yet another pilot error? > > It's a bug. Changes to this were only pushed in the past couple of days. As you note the generated file needs to be sorted before doing the comparison. > > David > >> I'm poking through WrapperGenerator.java to see if I see anything obvious. >> >> David >> From martinrb at google.com Fri Jan 25 23:51:45 2013 From: martinrb at google.com (Martin Buchholz) Date: Fri, 25 Jan 2013 15:51:45 -0800 Subject: New build system problems Message-ID: I was trying out the shiny new build system. Problem: configure is not executable - must run bash ./configure It's traditional for configure scripts to be executable. Problem: Your life is hell if you have a non-compiler "cl" command on your PATH, even on Linux. checking for cl... /usr/bin/cl configure: Resolving CC (as /usr/bin/cl) failed, using /usr/bin/cl directly. with subsequent failure to compile. Even if you specify the compiler explicitly, it doesn't help: CC=/usr/bin/gcc CXX=/usr/bin/g++ bash ./configure Of course, one can work around this by creating a "tools dir", but excising the unloved cl from the configure script is tempting and effective. From erik.joelsson at oracle.com Mon Jan 28 09:35:17 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 28 Jan 2013 10:35:17 +0100 Subject: JDK 8 Build Failure In-Reply-To: <51024CFE.6050504@oracle.com> References: <51024CFE.6050504@oracle.com> Message-ID: <51064655.5010609@oracle.com> Which platform are you building on? What kind of boot jdk are you using. It looks like there is an exception in one of the build tools (java source generation for X11) running on the boot jdk. /Erik On 2013-01-25 10:14, dalibor.topic at oracle.com wrote: > I checked out jdk8/jdk8 and gave it a go using the new build system. > It failed eventually with > > Generating exceptions classes > Generating icon classes > /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/jre/lib/rt.jar: invalid > LOC header (bad signature) > Exception in thread "main" java.lang.NoClassDefFoundError: > sun/awt/image/SunWritableRaster$DataStealer > at java.awt.image.DataBuffer.(DataBuffer.java:517) > at > javax.imageio.ImageTypeSpecifier.createComponentCM(ImageTypeSpecifier.java:249) > at > javax.imageio.ImageTypeSpecifier$Interleaved.(ImageTypeSpecifier.java:304) > at > javax.imageio.ImageTypeSpecifier.createInterleaved(ImageTypeSpecifier.java:399) > at > javax.imageio.ImageTypeSpecifier.createSpecifier(ImageTypeSpecifier.java:1169) > at > javax.imageio.ImageTypeSpecifier.getSpecifier(ImageTypeSpecifier.java:1118) > at > javax.imageio.ImageTypeSpecifier.createFromBufferedImageType(ImageTypeSpecifier.java:901) > at > com.sun.imageio.plugins.png.PNGImageReader.getImageTypes(PNGImageReader.java:1494) > at > com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1280) > at > com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1577) > at javax.imageio.ImageIO.read(ImageIO.java:1448) > at javax.imageio.ImageIO.read(ImageIO.java:1352) > at sun.awt.X11.ToBin.main(ToBin.java:35) > gmake[2]: *** > [/media/OpenJDK/nashorn/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] > Error 1 > gmake[1]: *** [gensrc-only] Error 2 > > cheers, > dalibor topic From erik.joelsson at oracle.com Mon Jan 28 09:38:36 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 28 Jan 2013 10:38:36 +0100 Subject: Questionable new-build failure In-Reply-To: <5101BD14.8040903@oracle.com> References: <0CD3B4D3-44A6-4FCF-82C9-C4D47142400F@oracle.com> <5101BD14.8040903@oracle.com> Message-ID: <5106471C.4@oracle.com> Hello, What sourced did you clone? As David Holmes says, this issue should have been fixed recently. /Erik On 2013-01-25 00:00, David Holmes wrote: > On 25/01/2013 7:44 AM, David Chase wrote: >> I'm trying new-build on a Solaris 10 box, and it goes okay till this >> comparison: >> >> COMPARING >> /export/drchase/jdk8tl/build/solaris-x86_64-normal-server-fastdebug/jdk/gensrc_x11wrappers/sizer/sizes.64 >> >> and >> /export/drchase/jdk8tl/jdk/src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 >> >> >> The two files are identical if sorted, but the comparison does not >> pre-sort, and it fails after spewing all the differences. >> >> Any suggestions? Is this a bug, or yet another pilot error? > > It's a bug. Changes to this were only pushed in the past couple of > days. As you note the generated file needs to be sorted before doing > the comparison. > > David > >> I'm poking through WrapperGenerator.java to see if I see anything >> obvious. >> >> David >> From erik.joelsson at oracle.com Mon Jan 28 09:47:28 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 28 Jan 2013 10:47:28 +0100 Subject: New build system problems In-Reply-To: References: Message-ID: <51064930.7050800@oracle.com> On 2013-01-26 00:51, Martin Buchholz wrote: > I was trying out the shiny new build system. > > Problem: configure is not executable - must run bash ./configure > It's traditional for configure scripts to be executable. > I would like configure to be executable too, but openjdk has a tradition of not allowing executable files in the source repos. > Problem: Your life is hell if you have a non-compiler "cl" command on your > PATH, even on Linux. > > checking for cl... /usr/bin/cl > configure: Resolving CC (as /usr/bin/cl) failed, using /usr/bin/cl directly. > > with subsequent failure to compile. This is bad and should definitely be fixed. Filed issue 8006988. > Even if you specify the compiler explicitly, it doesn't help: > > CC=/usr/bin/gcc CXX=/usr/bin/g++ bash ./configure > > Of course, one can work around this by creating a "tools dir", but excising > the unloved cl from the configure script is tempting and effective. This should probably also be looked at, but it's a separate issue. Filed issue 8006989. /Erik From erik.joelsson at oracle.com Mon Jan 28 10:39:56 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 28 Jan 2013 11:39:56 +0100 Subject: Review Request: 8006872: build-infra: Stop creating 4 identical jars in langtools In-Reply-To: References: Message-ID: <5106557C.2040905@oracle.com> Looks good except for missing common/makefiles/javadoc/Javadoc.gmk. Could you please make sure the docs target works too? /Erik On 2013-01-24 20:57, Fredrik ?hrstr?m wrote: > Stop creating 4 identical jars in langtools. The jars > javac.jar,javap.jar,javah.jar and javadoc.jar > contain the same content, except for a minor difference in the > manifest that tells where the main class is. > This is unnecessary, in particular since javap and javah are not used > in the build. > > A single jar on the classpath followed by the main class name. E.g. > -cp ....javac.jar com.sun.tools.javac.Main > -cp ....javac.jar com.sun.tools.javadoc.Main > is good enough. > > Also move the specification of how to run the boostrap javac into spec.gmk > where it is called NEW_JAVAC. > > Everything should be pushable into the build repo. The change in langtools > is so small that it does not need to be handled through tl. > > http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-root/ > http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-langtools/ > http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-corba/ > http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-jaxp/ > http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-jaxws/ > http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-8006872-jdk/ > > //Fredrik From erik.joelsson at oracle.com Mon Jan 28 10:42:28 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 28 Jan 2013 11:42:28 +0100 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51026031.7020200@oracle.com> References: <51026031.7020200@oracle.com> Message-ID: <51065614.1090008@oracle.com> The fix looks good to me. What strikes me most is the use of "sed" instead of $(SED) on the same line. /Erik On 2013-01-25 11:36, Tim Bell wrote: > Here is the bug report: > http://bugs.sun.com/view_bug.do?bug_id=8006933 > > Use nawk instead of awk to avoid "awk: string too long near line 1" > errors when running idlj in corba. For new 'build-infra' style > builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk > > The errors are seen if the path to the build directory in the source > tree is too long, greater than ~92. > > http://cr.openjdk.java.net/~tbell/8006933/00/ > > Thanks in advance for any feedback. > > Tim > From dalibor.topic at oracle.com Mon Jan 28 11:59:15 2013 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 28 Jan 2013 12:59:15 +0100 Subject: JDK 8 Build Failure In-Reply-To: <51064655.5010609@oracle.com> References: <51024CFE.6050504@oracle.com> <51064655.5010609@oracle.com> Message-ID: <51066813.7030402@oracle.com> On 1/28/13 10:35 AM, Erik Joelsson wrote: > Which platform are you building on? Oracle Linux 6.3 (Linux OBI). > What kind of boot jdk are you using. config.status: BOOT_JDK=/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/ > It looks like there is an exception in one of the build tools (java source generation for X11) running on the boot jdk. Anything I can dig into to help track this one down? cheers, dalibor topic > /Erik > > On 2013-01-25 10:14, dalibor.topic at oracle.com wrote: >> I checked out jdk8/jdk8 and gave it a go using the new build system. It failed eventually with >> >> Generating exceptions classes >> Generating icon classes >> /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/jre/lib/rt.jar: invalid LOC header (bad signature) >> Exception in thread "main" java.lang.NoClassDefFoundError: sun/awt/image/SunWritableRaster$DataStealer >> at java.awt.image.DataBuffer.(DataBuffer.java:517) >> at javax.imageio.ImageTypeSpecifier.createComponentCM(ImageTypeSpecifier.java:249) >> at javax.imageio.ImageTypeSpecifier$Interleaved.(ImageTypeSpecifier.java:304) >> at javax.imageio.ImageTypeSpecifier.createInterleaved(ImageTypeSpecifier.java:399) >> at javax.imageio.ImageTypeSpecifier.createSpecifier(ImageTypeSpecifier.java:1169) >> at javax.imageio.ImageTypeSpecifier.getSpecifier(ImageTypeSpecifier.java:1118) >> at javax.imageio.ImageTypeSpecifier.createFromBufferedImageType(ImageTypeSpecifier.java:901) >> at com.sun.imageio.plugins.png.PNGImageReader.getImageTypes(PNGImageReader.java:1494) >> at com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1280) >> at com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1577) >> at javax.imageio.ImageIO.read(ImageIO.java:1448) >> at javax.imageio.ImageIO.read(ImageIO.java:1352) >> at sun.awt.X11.ToBin.main(ToBin.java:35) >> gmake[2]: *** [/media/OpenJDK/nashorn/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] Error 1 >> gmake[1]: *** [gensrc-only] Error 2 >> >> cheers, >> dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From tim.bell at oracle.com Mon Jan 28 15:34:58 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 28 Jan 2013 07:34:58 -0800 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51065614.1090008@oracle.com> References: <51026031.7020200@oracle.com> <51065614.1090008@oracle.com> Message-ID: <51069AA2.3080007@oracle.com> Thanks, Erik I'll fix the use of sed versus $(SED) as well. I am working on round two of the fix based on feedback from you, David, and Dmitry. Tim On 01/28/13 02:42, Erik Joelsson wrote: > The fix looks good to me. What strikes me most is the use of "sed" > instead of $(SED) on the same line. > > /Erik > > On 2013-01-25 11:36, Tim Bell wrote: >> Here is the bug report: >> http://bugs.sun.com/view_bug.do?bug_id=8006933 >> >> Use nawk instead of awk to avoid "awk: string too long near line 1" >> errors when running idlj in corba. For new 'build-infra' style >> builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk >> >> The errors are seen if the path to the build directory in the source >> tree is too long, greater than ~92. >> >> http://cr.openjdk.java.net/~tbell/8006933/00/ >> >> Thanks in advance for any feedback. >> >> Tim >> From kelly.ohair at oracle.com Mon Jan 28 16:37:44 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 28 Jan 2013 08:37:44 -0800 Subject: JDK 8 Build Failure In-Reply-To: <51066813.7030402@oracle.com> References: <51024CFE.6050504@oracle.com> <51064655.5010609@oracle.com> <51066813.7030402@oracle.com> Message-ID: <07B88770-4AF1-4012-8443-B35961330FD3@oracle.com> The official boot jdk for jdk8 is jdk7u7. It is unclear what jdk7 update you have. Newer should be fine, and it's quite possible that older ones could work too, but officially, for RE/JPRT builds, we use 7u7. I have never had good luck using the OEL 5 systems, the gcc is too old, but have never used OEL 6. And I have never used the distro jdk7's as a boot jdk, but in theory they should work. My tendency would be to install an Oracle jdk7u7, and try that, see if we can at least isolate it to some kind of boot jdk issue. -kto On Jan 28, 2013, at 3:59 AM, Dalibor Topic wrote: > On 1/28/13 10:35 AM, Erik Joelsson wrote: >> Which platform are you building on? > > Oracle Linux 6.3 (Linux OBI). > >> What kind of boot jdk are you using. > > config.status: > BOOT_JDK=/usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/ > >> It looks like there is an exception in one of the build tools (java source generation for X11) running on the boot jdk. > > Anything I can dig into to help track this one down? > > cheers, > dalibor topic > >> /Erik >> >> On 2013-01-25 10:14, dalibor.topic at oracle.com wrote: >>> I checked out jdk8/jdk8 and gave it a go using the new build system. It failed eventually with >>> >>> Generating exceptions classes >>> Generating icon classes >>> /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.9.x86_64/jre/lib/rt.jar: invalid LOC header (bad signature) >>> Exception in thread "main" java.lang.NoClassDefFoundError: sun/awt/image/SunWritableRaster$DataStealer >>> at java.awt.image.DataBuffer.(DataBuffer.java:517) >>> at javax.imageio.ImageTypeSpecifier.createComponentCM(ImageTypeSpecifier.java:249) >>> at javax.imageio.ImageTypeSpecifier$Interleaved.(ImageTypeSpecifier.java:304) >>> at javax.imageio.ImageTypeSpecifier.createInterleaved(ImageTypeSpecifier.java:399) >>> at javax.imageio.ImageTypeSpecifier.createSpecifier(ImageTypeSpecifier.java:1169) >>> at javax.imageio.ImageTypeSpecifier.getSpecifier(ImageTypeSpecifier.java:1118) >>> at javax.imageio.ImageTypeSpecifier.createFromBufferedImageType(ImageTypeSpecifier.java:901) >>> at com.sun.imageio.plugins.png.PNGImageReader.getImageTypes(PNGImageReader.java:1494) >>> at com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1280) >>> at com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1577) >>> at javax.imageio.ImageIO.read(ImageIO.java:1448) >>> at javax.imageio.ImageIO.read(ImageIO.java:1352) >>> at sun.awt.X11.ToBin.main(ToBin.java:35) >>> gmake[2]: *** [/media/OpenJDK/nashorn/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] Error 1 >>> gmake[1]: *** [gensrc-only] Error 2 >>> >>> cheers, >>> dalibor topic > > > > -- > Oracle > Dalibor Topic | Principal Product Manager > Phone: +494089091214 | Mobile: +491737185961 > Oracle Java Platform Group > > ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg > > ORACLE Deutschland B.V. & Co. KG > Hauptverwaltung: Riesstr. 25, D-80992 M?nchen > Registergericht: Amtsgericht M?nchen, HRA 95603 > Gesch?ftsf?hrer: J?rgen Kunz > > Komplement?rin: ORACLE Deutschland Verwaltung B.V. > Hertogswetering 163/167, 3543 AS Utrecht, Niederlande > Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 > Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher > > Green Oracle Oracle is committed to developing practices and products that help protect the environment From kelly.ohair at oracle.com Mon Jan 28 19:58:00 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 28 Jan 2013 11:58:00 -0800 Subject: New build system problems In-Reply-To: <51064930.7050800@oracle.com> References: <51064930.7050800@oracle.com> Message-ID: >> I was trying out the shiny new build system. Which is great, and the fact that you provided feedback. Thanks for that. >> >> Problem: configure is not executable - must run bash ./configure >> It's traditional for configure scripts to be executable. >> > I would like configure to be executable too, but openjdk has a tradition of not allowing executable files in the source repos. To avoid the possibility of any executable binaries being put into the OpenJDK "source" repositories, we disallowed any files with execute permissions. I myself think this is a good policy and I don't think we should change that policy. I have seen too many files creep into source repositories with execute permissions that were actually mistakes. -kto From david.r.chase at oracle.com Mon Jan 28 20:41:02 2013 From: david.r.chase at oracle.com (David Chase) Date: Mon, 28 Jan 2013 15:41:02 -0500 Subject: Questionable new-build failure In-Reply-To: <4D1C915D-7C99-42A0-AAE2-33C8BD62931B@oracle.com> References: <0CD3B4D3-44A6-4FCF-82C9-C4D47142400F@oracle.com> <5101BD14.8040903@oracle.com> <4D1C915D-7C99-42A0-AAE2-33C8BD62931B@oracle.com> Message-ID: <4E652F10-BE86-4DC8-8AA5-1414E6BDB043@oracle.com> On 2013-01-25, at 4:55 PM, Kelly O'Hair wrote: > Please file JBS Issues. So this is a new bug that needs filing? I think it's sort of a duplicate, see below. > And keep in mind every "Solaris 10" system could be different. Solaris 10 10/09 s10x_u8wos_08a X86 Builds with jdk8, fails with jdk7. I am pretty sure that the cause of the bug is a dependence (in WrapperGenerator) on the order in which items are iterated out of a hash table. That appears to have changed in the transition from jdk7 to jdk8. That change was apparently necessary to make it (very much) harder to DOS a hashtable with collisions. I observed different output running WrapperGenerator with the exact same inputs under 7 and 8, cutting and pasting from a build and replacing only the target directory and the host VM. It seems to be fixed in jdk8-build as of six days ago (I checked), as a side-effect of fixing 8004151 David From martinrb at google.com Mon Jan 28 21:02:23 2013 From: martinrb at google.com (Martin Buchholz) Date: Mon, 28 Jan 2013 13:02:23 -0800 Subject: New build system problems In-Reply-To: References: <51064930.7050800@oracle.com> Message-ID: On Mon, Jan 28, 2013 at 11:58 AM, Kelly O'Hair wrote: > I would like configure to be executable too, but openjdk has a tradition > of not allowing executable files in the source repos. > > > To avoid the possibility of any executable binaries being put into the > OpenJDK "source" repositories, we disallowed > any files with execute permissions. I myself think this is a good policy > and I don't think we should change that policy. > > I have seen too many files creep into source repositories with execute > permissions that were actually mistakes. > > How hard would it be to teach jcheck to only accept executable files that start with "#!/" ? Or jcheck could maintain a whitelist of permitted executable scripts. Not having configure be executable violates developer expectations. From erik.joelsson at oracle.com Tue Jan 29 14:54:00 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 29 Jan 2013 15:54:00 +0100 Subject: Review Request: 8006873: SWAT-b74 msvcr100.dll does not have the permission for all Message-ID: <5107E288.6000401@oracle.com> Adding a chmod when copying msvcr100.dll into the jdk output dir. The unix permissions shouldn't be needed on windows, but if the bundles are unzipped on unix and accessed over nfs or samba, permissions matter. http://cr.openjdk.java.net/~erikj/8006873/webrev.jdk.01/ /Erik From boaznahum at gmail.com Tue Jan 29 14:55:01 2013 From: boaznahum at gmail.com (Boaz Nahum) Date: Tue, 29 Jan 2013 16:55:01 +0200 Subject: Build failure(?) on windows Message-ID: Hi. On windows and Linux(Ubuntu 12.10) default target works fine, but 'images' fails. On windows the error is: $ make NEWBUILD=true images *Images.gmk:612: warning: ignoring old recipe for target `/release' Images.gmk:620: warning: overriding recipe for target `/release' Images.gmk:616: warning: ignoring old recipe for target `/release' /usr/bin/mkdir: missing operand Try `/usr/bin/mkdir --help' for more information. Images.gmk:573: recipe for target `/LICENSE' failed make[2]: *** [/LICENSE] Error 1 make[2]: *** Waiting for unfinished jobs.... /usr/bin/mkdir: missing operand Try `/usr/bin/mkdir --help' for more information. Images.gmk:573: recipe for target `/THIRD_PARTY_README' failed make[2]: *** [/THIRD_PARTY_README] Error 1 /usr/bin/mkdir: missing operand Try `/usr/bin/mkdir --help' for more information. Images.gmk:573: recipe for target `/ASSEMBLY_EXCEPTION' failed make[2]: *** [/ASSEMBLY_EXCEPTION] Error 1 BuildJdk.gmk:90: recipe for target `images' failed make[1]: *** [images] Error 2 /cygdrive/f/jdk8build/LL1//common/makefiles/Main.gmk:127: recipe for target `images-only' failed make: *** [images-only] Error 2 * Thanks boaz From Alan.Bateman at oracle.com Tue Jan 29 14:59:24 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 29 Jan 2013 14:59:24 +0000 Subject: Review Request: 8006873: SWAT-b74 msvcr100.dll does not have the permission for all In-Reply-To: <5107E288.6000401@oracle.com> References: <5107E288.6000401@oracle.com> Message-ID: <5107E3CC.6040803@oracle.com> On 29/01/2013 14:54, Erik Joelsson wrote: > Adding a chmod when copying msvcr100.dll into the jdk output dir. The > unix permissions shouldn't be needed on windows, but if the bundles > are unzipped on unix and accessed over nfs or samba, permissions matter. > > http://cr.openjdk.java.net/~erikj/8006873/webrev.jdk.01/ > > /Erik For NFS or samba cases then this looks good to me (not interesting for the local case of course). -Alan From erik.joelsson at oracle.com Tue Jan 29 15:10:37 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 29 Jan 2013 16:10:37 +0100 Subject: Build failure(?) on windows In-Reply-To: References: Message-ID: <5107E66D.7020704@oracle.com> It looks like you haven't rerun configure since you pulled changes last. /Erik On 2013-01-29 15:55, Boaz Nahum wrote: > Hi. > > On windows and Linux(Ubuntu 12.10) default target works fine, but 'images' > fails. > > On windows the error is: > > $ make NEWBUILD=true images > > *Images.gmk:612: warning: ignoring old recipe for target `/release' > Images.gmk:620: warning: overriding recipe for target `/release' > Images.gmk:616: warning: ignoring old recipe for target `/release' > /usr/bin/mkdir: missing operand > Try `/usr/bin/mkdir --help' for more information. > Images.gmk:573: recipe for target `/LICENSE' failed > make[2]: *** [/LICENSE] Error 1 > make[2]: *** Waiting for unfinished jobs.... > /usr/bin/mkdir: missing operand > Try `/usr/bin/mkdir --help' for more information. > Images.gmk:573: recipe for target `/THIRD_PARTY_README' failed > make[2]: *** [/THIRD_PARTY_README] Error 1 > /usr/bin/mkdir: missing operand > Try `/usr/bin/mkdir --help' for more information. > Images.gmk:573: recipe for target `/ASSEMBLY_EXCEPTION' failed > make[2]: *** [/ASSEMBLY_EXCEPTION] Error 1 > BuildJdk.gmk:90: recipe for target `images' failed > make[1]: *** [images] Error 2 > /cygdrive/f/jdk8build/LL1//common/makefiles/Main.gmk:127: recipe for target > `images-only' failed > make: *** [images-only] Error 2 > > * > Thanks > boaz From tim.bell at oracle.com Tue Jan 29 15:30:41 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 29 Jan 2013 07:30:41 -0800 Subject: Review Request: 8006873: SWAT-b74 msvcr100.dll does not have the permission for all In-Reply-To: <5107E288.6000401@oracle.com> References: <5107E288.6000401@oracle.com> Message-ID: <5107EB21.1070400@oracle.com> Hi Erik: > Adding a chmod when copying msvcr100.dll into the jdk output dir. The > unix permissions shouldn't be needed on windows, but if the bundles > are unzipped on unix and accessed over nfs or samba, permissions matter. > > http://cr.openjdk.java.net/~erikj/8006873/webrev.jdk.01/ Looks good - approved! Tim From erik.joelsson at oracle.com Tue Jan 29 15:33:12 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 29 Jan 2013 16:33:12 +0100 Subject: Build failure(?) on windows In-Reply-To: <5107E66D.7020704@oracle.com> References: <5107E66D.7020704@oracle.com> Message-ID: <5107EBB8.3080508@oracle.com> This is the second report of this we get in a short time. I've filed an issue on adding a check to make that the configuration is up to date. Testing a solution now. /Erik On 2013-01-29 16:10, Erik Joelsson wrote: > It looks like you haven't rerun configure since you pulled changes last. > > /Erik > > On 2013-01-29 15:55, Boaz Nahum wrote: >> Hi. >> >> On windows and Linux(Ubuntu 12.10) default target works fine, but >> 'images' >> fails. >> >> On windows the error is: >> >> $ make NEWBUILD=true images >> >> *Images.gmk:612: warning: ignoring old recipe for target `/release' >> Images.gmk:620: warning: overriding recipe for target `/release' >> Images.gmk:616: warning: ignoring old recipe for target `/release' >> /usr/bin/mkdir: missing operand >> Try `/usr/bin/mkdir --help' for more information. >> Images.gmk:573: recipe for target `/LICENSE' failed >> make[2]: *** [/LICENSE] Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> /usr/bin/mkdir: missing operand >> Try `/usr/bin/mkdir --help' for more information. >> Images.gmk:573: recipe for target `/THIRD_PARTY_README' failed >> make[2]: *** [/THIRD_PARTY_README] Error 1 >> /usr/bin/mkdir: missing operand >> Try `/usr/bin/mkdir --help' for more information. >> Images.gmk:573: recipe for target `/ASSEMBLY_EXCEPTION' failed >> make[2]: *** [/ASSEMBLY_EXCEPTION] Error 1 >> BuildJdk.gmk:90: recipe for target `images' failed >> make[1]: *** [images] Error 2 >> /cygdrive/f/jdk8build/LL1//common/makefiles/Main.gmk:127: recipe for >> target >> `images-only' failed >> make: *** [images-only] Error 2 >> >> * >> Thanks >> boaz From erik.joelsson at oracle.com Tue Jan 29 15:42:14 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Tue, 29 Jan 2013 15:42:14 +0000 Subject: hg: jdk8/build/jdk: 8006873: SWAT-b74 msvcr100.dll does not have the permission for all Message-ID: <20130129154257.1CD6A4764B@hg.openjdk.java.net> Changeset: 3c499051a5df Author: erikj Date: 2013-01-29 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c499051a5df 8006873: SWAT-b74 msvcr100.dll does not have the permission for all Reviewed-by: alanb, tbell ! makefiles/CopyFiles.gmk From Sergey.Bylokhov at oracle.com Tue Jan 29 17:25:53 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 29 Jan 2013 21:25:53 +0400 Subject: Build failure on windows Message-ID: <51080621.8060400@oracle.com> Hello. Does anybody know how to fix this error message? ## Starting jdk make[2]: Entering directory `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' make[3]: Entering directory `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' Generating Nimbus source files Exception in thread "main" java.lang.NullPointerException at java.io.Reader.(Reader.java:78) at java.io.InputStreamReader.(InputStreamReader.java:72) at build.tools.generatenimbus.Generator$TemplateReader.(Generator. java:251) at build.tools.generatenimbus.Generator.writeSrcFileImpl(Generator.java: 224) at build.tools.generatenimbus.Generator.writeSrcFile(Generator.java:241) at build.tools.generatenimbus.PainterGenerator.writePainter(PainterGener ator.java:625) at build.tools.generatenimbus.UIRegion.write(UIRegion.java:174) at build.tools.generatenimbus.SynthModel.write(SynthModel.java:74) at build.tools.generatenimbus.Generator.generate(Generator.java:206) at build.tools.generatenimbus.Generator.main(Generator.java:112) New build system was used. Ws is from http://hg.openjdk.java.net/jdk8/awt This is clean build. Thanks. -- Best regards, Sergey. From kelly.ohair at oracle.com Tue Jan 29 17:26:40 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 Jan 2013 09:26:40 -0800 Subject: New build system problems In-Reply-To: References: <51064930.7050800@oracle.com> Message-ID: <05018776-A97E-4176-9A16-C6C86D6CB524@oracle.com> On Jan 28, 2013, at 1:02 PM, Martin Buchholz wrote: > > > On Mon, Jan 28, 2013 at 11:58 AM, Kelly O'Hair wrote: >> I would like configure to be executable too, but openjdk has a tradition of not allowing executable files in the source repos. > > > To avoid the possibility of any executable binaries being put into the OpenJDK "source" repositories, we disallowed > any files with execute permissions. I myself think this is a good policy and I don't think we should change that policy. > > I have seen too many files creep into source repositories with execute permissions that were actually mistakes. > > > How hard would it be to teach jcheck to only accept executable files that start with "#!/" ? > Or jcheck could maintain a whitelist of permitted executable scripts. > Not having configure be executable violates developer expectations. You are free to propose changes to jcheck http://hg.openjdk.java.net/code-tools/jcheck/ I still see no issue with saying run "bash ./configure", developers need to read the README first. Having to run "bash ./get_source.sh" probably violates something too. I say, get over it. We have a right to be a little different. ;^) -kto From chris.hegarty at oracle.com Tue Jan 29 17:31:24 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 29 Jan 2013 17:31:24 +0000 Subject: New build system problems In-Reply-To: <05018776-A97E-4176-9A16-C6C86D6CB524@oracle.com> References: <51064930.7050800@oracle.com> <05018776-A97E-4176-9A16-C6C86D6CB524@oracle.com> Message-ID: <5108076C.3080907@oracle.com> On 01/29/2013 05:26 PM, Kelly O'Hair wrote: > > On Jan 28, 2013, at 1:02 PM, Martin Buchholz wrote: > >> >> >> On Mon, Jan 28, 2013 at 11:58 AM, Kelly O'Hair wrote: >>> I would like configure to be executable too, but openjdk has a tradition of not allowing executable files in the source repos. >> >> >> To avoid the possibility of any executable binaries being put into the OpenJDK "source" repositories, we disallowed >> any files with execute permissions. I myself think this is a good policy and I don't think we should change that policy. >> >> I have seen too many files creep into source repositories with execute permissions that were actually mistakes. >> >> >> How hard would it be to teach jcheck to only accept executable files that start with "#!/" ? >> Or jcheck could maintain a whitelist of permitted executable scripts. >> Not having configure be executable violates developer expectations. > > You are free to propose changes to jcheck http://hg.openjdk.java.net/code-tools/jcheck/ > > I still see no issue with saying run "bash ./configure", developers need to read the README first. > Having to run "bash ./get_source.sh" probably violates something too. I say, get over it. > We have a right to be a little different. ;^) FWIW, this kinda surprised me too. I would prefer if configure was executable, but don't see it as being a big issue. I'm already over it! -Chris. > > -kto > > From kelly.ohair at oracle.com Tue Jan 29 17:35:24 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 Jan 2013 09:35:24 -0800 Subject: Build failure on windows In-Reply-To: <51080621.8060400@oracle.com> References: <51080621.8060400@oracle.com> Message-ID: On Windows, check your file and directory permissions. -kto On Jan 29, 2013, at 9:25 AM, Sergey Bylokhov wrote: > Hello. > Does anybody know how to fix this error message? > > ## Starting jdk > make[2]: Entering directory `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' > make[3]: Entering directory `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' > Generating Nimbus source files > Exception in thread "main" java.lang.NullPointerException > at java.io.Reader.(Reader.java:78) > at java.io.InputStreamReader.(InputStreamReader.java:72) > at build.tools.generatenimbus.Generator$TemplateReader.(Generator. > java:251) > at build.tools.generatenimbus.Generator.writeSrcFileImpl(Generator.java: > 224) > at build.tools.generatenimbus.Generator.writeSrcFile(Generator.java:241) > > at build.tools.generatenimbus.PainterGenerator.writePainter(PainterGener > ator.java:625) > at build.tools.generatenimbus.UIRegion.write(UIRegion.java:174) > at build.tools.generatenimbus.SynthModel.write(SynthModel.java:74) > at build.tools.generatenimbus.Generator.generate(Generator.java:206) > at build.tools.generatenimbus.Generator.main(Generator.java:112) > > New build system was used. Ws is from http://hg.openjdk.java.net/jdk8/awt > This is clean build. > Thanks. > > -- > Best regards, Sergey. > From erik.joelsson at oracle.com Wed Jan 30 10:04:23 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 30 Jan 2013 11:04:23 +0100 Subject: Build failure on windows In-Reply-To: <51080621.8060400@oracle.com> References: <51080621.8060400@oracle.com> Message-ID: <5108F027.7070803@oracle.com> When a java source generation tool is failing, I usually suspect the boot jdk first. What did you use for boot jdk? /Erik On 2013-01-29 18:25, Sergey Bylokhov wrote: > Hello. > Does anybody know how to fix this error message? > > ## Starting jdk > make[2]: Entering directory > `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' > make[3]: Entering directory > `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' > Generating Nimbus source files > Exception in thread "main" java.lang.NullPointerException > at java.io.Reader.(Reader.java:78) > at java.io.InputStreamReader.(InputStreamReader.java:72) > at > build.tools.generatenimbus.Generator$TemplateReader.(Generator. > java:251) > at > build.tools.generatenimbus.Generator.writeSrcFileImpl(Generator.java: > 224) > at > build.tools.generatenimbus.Generator.writeSrcFile(Generator.java:241) > > at > build.tools.generatenimbus.PainterGenerator.writePainter(PainterGener > ator.java:625) > at build.tools.generatenimbus.UIRegion.write(UIRegion.java:174) > at > build.tools.generatenimbus.SynthModel.write(SynthModel.java:74) > at > build.tools.generatenimbus.Generator.generate(Generator.java:206) > at build.tools.generatenimbus.Generator.main(Generator.java:112) > > New build system was used. Ws is from http://hg.openjdk.java.net/jdk8/awt > This is clean build. > Thanks. > From chris.hegarty at oracle.com Wed Jan 30 12:22:08 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 30 Jan 2013 12:22:08 +0000 Subject: Could not instantiate Graphics Environment with building on mac Message-ID: <51091070.8030004@oracle.com> Anyone see this failure when trying to build on mac. I have the latest jdk8/tl forest, as of 28th Jan. ## Starting jdk Importing CORBA classes.jar Importing CORBA src.zip Importing CORBA bin.zip Importing JAXP classes.jar Importing JAXP src.zip Importing JAXWS classes.jar Importing JAXWS src.zip Importing LANGTOOLS src.zip Importing LANGTOOLS classes.jar Compiling 182 files for BUILD_TOOLS Generating charsetmapping classes Generating buffer classes Generating exceptions classes Generating icon classes Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. Compiling 522 properties into resource bundles Copying and cleaning 53 properties Creating sun/util/LocaleDataMetaInfo.java from 421 found resources. Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 Classes: Table size 32 (5 bits), shift 1, max chain depth 3 Cache: Table size 32 (5 bits), shift 1, max chain depth 3 MergingHash:thePoint[name]: thePoint => aPoint Exception in thread "main" java.lang.Error: Could not instantiate Graphics Environment: sun.java2d.HeadlessGraphicsEnvironment at java.awt.GraphicsEnvironment.createGE(GraphicsEnvironment.java:118) at java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:81) at java.awt.image.BufferedImage.createGraphics(BufferedImage.java:1152) at java.awt.image.BufferedImage.getGraphics(BufferedImage.java:1142) at sun.awt.X11.ToBin.main(ToBin.java:41) make[2]: *** [/Users/chhegar/repos/tl/build/macosx-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] Error 1 make[2]: *** Waiting for unfinished jobs.... MergingHash:thePoint[name]: thePoint => aPoint make[1]: *** [gensrc-only] Error 2 make: *** [jdk-only] Error 2 mikemac:macosx-x86_64-normal-server-release chhegar$ -Chris. From erik.joelsson at oracle.com Wed Jan 30 12:32:05 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 30 Jan 2013 13:32:05 +0100 Subject: Could not instantiate Graphics Environment with building on mac In-Reply-To: <51091070.8030004@oracle.com> References: <51091070.8030004@oracle.com> Message-ID: <510912C5.5010906@oracle.com> I've seen this when running in an ssh session without a mac gui and using jdk7 (no updates) as boot jdk. Logging in with graphics or using at least 7u4 solved it for me. /Erik On 2013-01-30 13:22, Chris Hegarty wrote: > > Anyone see this failure when trying to build on mac. I have the latest > jdk8/tl forest, as of 28th Jan. > > ## Starting jdk > Importing CORBA classes.jar > Importing CORBA src.zip > Importing CORBA bin.zip > Importing JAXP classes.jar > Importing JAXP src.zip > Importing JAXWS classes.jar > Importing JAXWS src.zip > Importing LANGTOOLS src.zip > Importing LANGTOOLS classes.jar > Compiling 182 files for BUILD_TOOLS > Generating charsetmapping classes > Generating buffer classes > Generating exceptions classes > Generating icon classes > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > Compiling 522 properties into resource bundles > Copying and cleaning 53 properties > Creating sun/util/LocaleDataMetaInfo.java from 421 found resources. > Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 > Classes: Table size 32 (5 bits), shift 1, max chain depth 3 > Cache: Table size 32 (5 bits), shift 1, max chain depth 3 > MergingHash:thePoint[name]: thePoint > => aPoint > Exception in thread "main" java.lang.Error: Could not instantiate > Graphics Environment: sun.java2d.HeadlessGraphicsEnvironment > at > java.awt.GraphicsEnvironment.createGE(GraphicsEnvironment.java:118) > at > java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:81) > at > java.awt.image.BufferedImage.createGraphics(BufferedImage.java:1152) > at java.awt.image.BufferedImage.getGraphics(BufferedImage.java:1142) > at sun.awt.X11.ToBin.main(ToBin.java:41) > make[2]: *** > [/Users/chhegar/repos/tl/build/macosx-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] > Error 1 > make[2]: *** Waiting for unfinished jobs.... > MergingHash:thePoint[name]: thePoint > => aPoint > make[1]: *** [gensrc-only] Error 2 > make: *** [jdk-only] Error 2 > mikemac:macosx-x86_64-normal-server-release chhegar$ > > -Chris. From weijun.wang at oracle.com Wed Jan 30 12:34:03 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 30 Jan 2013 20:34:03 +0800 Subject: Could not instantiate Graphics Environment with building on mac In-Reply-To: <51091070.8030004@oracle.com> References: <51091070.8030004@oracle.com> Message-ID: <9AFFC4B2-C0BB-419F-B8DB-A25E9B052ECC@oracle.com> Have you installed XQuartz? On Jan 30, 2013, at 20:22, Chris Hegarty wrote: > > Anyone see this failure when trying to build on mac. I have the latest jdk8/tl forest, as of 28th Jan. > > ## Starting jdk > Importing CORBA classes.jar > Importing CORBA src.zip > Importing CORBA bin.zip > Importing JAXP classes.jar > Importing JAXP src.zip > Importing JAXWS classes.jar > Importing JAXWS src.zip > Importing LANGTOOLS src.zip > Importing LANGTOOLS classes.jar > Compiling 182 files for BUILD_TOOLS > Generating charsetmapping classes > Generating buffer classes > Generating exceptions classes > Generating icon classes > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > Compiling 522 properties into resource bundles > Copying and cleaning 53 properties > Creating sun/util/LocaleDataMetaInfo.java from 421 found resources. > Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 > Classes: Table size 32 (5 bits), shift 1, max chain depth 3 > Cache: Table size 32 (5 bits), shift 1, max chain depth 3 > MergingHash:thePoint[name]: thePoint => aPoint > Exception in thread "main" java.lang.Error: Could not instantiate Graphics Environment: sun.java2d.HeadlessGraphicsEnvironment > at java.awt.GraphicsEnvironment.createGE(GraphicsEnvironment.java:118) > at java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:81) > at java.awt.image.BufferedImage.createGraphics(BufferedImage.java:1152) > at java.awt.image.BufferedImage.getGraphics(BufferedImage.java:1142) > at sun.awt.X11.ToBin.main(ToBin.java:41) > make[2]: *** [/Users/chhegar/repos/tl/build/macosx-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] Error 1 > make[2]: *** Waiting for unfinished jobs.... > MergingHash:thePoint[name]: thePoint => aPoint > make[1]: *** [gensrc-only] Error 2 > make: *** [jdk-only] Error 2 > mikemac:macosx-x86_64-normal-server-release chhegar$ > > -Chris. From tim.bell at oracle.com Wed Jan 30 17:39:58 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 30 Jan 2013 09:39:58 -0800 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51069AA2.3080007@oracle.com> References: <51026031.7020200@oracle.com> <51065614.1090008@oracle.com> <51069AA2.3080007@oracle.com> Message-ID: <51095AEE.5020804@oracle.com> Second round of this change: http://cr.openjdk.java.net/~tbell/8006933/01/ In response to feedback raised on this thread: David wrote: > Do we fix the old build in the corba repo too? No, the old build does not generate accurate dependencies in this area, so there is nothing similar to fix - the old corba build is all or nothing. > Can we also fix the fact that the failure doesn't cause make to detect > the error? I think that is caused by the whole thing being executed in a > sub-shell. I tried without success (many ways) to trap the error from the original /usr/bin/awk. Given that we are using nawk after this change, I'd like to move on. Dmitry wrote: > It might be better to remove AWK completely > > $(FIND) . -type f | sed 's!\./!$3 : $4/!g' > $5 Good idea, but I was not able to implement it because sed does not support captures, and the expression suggested above would drop part of the string. Let me give an example: If the output of the find is ./org/omg/CORBA/StringSeqHolder.java $3 is /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ $4 is /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl $(SED) 's!\./!$3 : $4/!g' would generate: /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ : /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl (losing the /org/omg/CORBA/StringSeqHolder.java substring) $(SED) 's!\./!$3/!g' | $(NAWK) '{ print $$$$1 ": $4" }' would generate what we want: /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/org/omg/CORBA/StringSeqHolder.java: /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl (and you can see why the length of the strings becomes a problem for the old Solaris awk which predates the Posix standard) > or ever > > find . -type f -printf "$3%s : $4\n" Another good suggestion, but not all versions of find support printf (MacOS, and /usr/bin/find on Solaris). It would be possible to use /usr/bin/gfind on Solaris, but I don't know of a solution on the Mac. Tim > On 01/28/13 02:42, Erik Joelsson wrote: >> The fix looks good to me. What strikes me most is the use of "sed" >> instead of $(SED) on the same line. >> >> /Erik >> >> On 2013-01-25 11:36, Tim Bell wrote: >>> Here is the bug report: >>> http://bugs.sun.com/view_bug.do?bug_id=8006933 >>> >>> Use nawk instead of awk to avoid "awk: string too long near line 1" >>> errors when running idlj in corba. For new 'build-infra' style >>> builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk >>> >>> The errors are seen if the path to the build directory in the source >>> tree is too long, greater than ~92. >>> >>> http://cr.openjdk.java.net/~tbell/8006933/00/ >>> >>> Thanks in advance for any feedback. >>> >>> Tim From chris.hegarty at oracle.com Wed Jan 30 19:35:39 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 30 Jan 2013 19:35:39 +0000 Subject: Could not instantiate Graphics Environment with building on mac In-Reply-To: <510912C5.5010906@oracle.com> References: <51091070.8030004@oracle.com> <510912C5.5010906@oracle.com> Message-ID: <5109760B.8010601@oracle.com> On 01/30/2013 12:32 PM, Erik Joelsson wrote: > I've seen this when running in an ssh session without a mac gui and > using jdk7 (no updates) as boot jdk. Logging in with graphics or using > at least 7u4 solved it for me. A more recent bootstrap jdk solved the problem. Thank you Eric. -Chris. > > /Erik > > On 2013-01-30 13:22, Chris Hegarty wrote: >> >> Anyone see this failure when trying to build on mac. I have the latest >> jdk8/tl forest, as of 28th Jan. >> >> ## Starting jdk >> Importing CORBA classes.jar >> Importing CORBA src.zip >> Importing CORBA bin.zip >> Importing JAXP classes.jar >> Importing JAXP src.zip >> Importing JAXWS classes.jar >> Importing JAXWS src.zip >> Importing LANGTOOLS src.zip >> Importing LANGTOOLS classes.jar >> Compiling 182 files for BUILD_TOOLS >> Generating charsetmapping classes >> Generating buffer classes >> Generating exceptions classes >> Generating icon classes >> Note: Some input files use unchecked or unsafe operations. >> Note: Recompile with -Xlint:unchecked for details. >> Compiling 522 properties into resource bundles >> Copying and cleaning 53 properties >> Creating sun/util/LocaleDataMetaInfo.java from 421 found resources. >> Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 >> Classes: Table size 32 (5 bits), shift 1, max chain depth 3 >> Cache: Table size 32 (5 bits), shift 1, max chain depth 3 >> MergingHash:thePoint[name]: thePoint >> => aPoint >> Exception in thread "main" java.lang.Error: Could not instantiate >> Graphics Environment: sun.java2d.HeadlessGraphicsEnvironment >> at >> java.awt.GraphicsEnvironment.createGE(GraphicsEnvironment.java:118) >> at >> java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:81) >> >> at >> java.awt.image.BufferedImage.createGraphics(BufferedImage.java:1152) >> at java.awt.image.BufferedImage.getGraphics(BufferedImage.java:1142) >> at sun.awt.X11.ToBin.main(ToBin.java:41) >> make[2]: *** >> [/Users/chhegar/repos/tl/build/macosx-x86_64-normal-server-release/jdk/gensrc/sun/awt/X11/XAWTIcon32_java_icon16_png.java] >> Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> MergingHash:thePoint[name]: thePoint >> => aPoint >> make[1]: *** [gensrc-only] Error 2 >> make: *** [jdk-only] Error 2 >> mikemac:macosx-x86_64-normal-server-release chhegar$ >> >> -Chris. From mike.duigou at oracle.com Wed Jan 30 20:24:25 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 30 Jan 2013 12:24:25 -0800 Subject: RFR: 8006709 : Add minimal support of MacOSX platform for JDK NetBeans Projects In-Reply-To: <1C444A52-9B11-41BB-8B73-990097AC914C@oracle.com> References: <1C444A52-9B11-41BB-8B73-990097AC914C@oracle.com> Message-ID: <9A51B7B9-BB2C-4F25-9FD6-22D4389980C0@oracle.com> This issue still needs a reviewer. Mike On Jan 22 2013, at 13:27 , Mike Duigou wrote: > Hello all; > > This is a patch that has been lingering around in the lambda/lambda repo for a long time. It adds minimal support for the MacOSX platform to the JDK NetBeans projects. It could also be used as the basis for similar support for the langtools NetBeans projects. > > The patch also adjust the source level of the project to 1.8 and removes some long obsolete cruft. > > http://cr.openjdk.java.net/~mduigou/8006709/0/webrev/ > > Mike From kelly.ohair at oracle.com Wed Jan 30 20:36:39 2013 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 30 Jan 2013 12:36:39 -0800 Subject: RFR: 8006709 : Add minimal support of MacOSX platform for JDK NetBeans Projects In-Reply-To: <9A51B7B9-BB2C-4F25-9FD6-22D4389980C0@oracle.com> References: <1C444A52-9B11-41BB-8B73-990097AC914C@oracle.com> <9A51B7B9-BB2C-4F25-9FD6-22D4389980C0@oracle.com> Message-ID: <8169D370-829E-40B1-AA9B-E43DB858667D@oracle.com> I don't use these netbeans projects, but the changes seem fine to me. The copyright on the new files says 2007, I assume they need to say 2013? -kto On Jan 30, 2013, at 12:24 PM, Mike Duigou wrote: > This issue still needs a reviewer. > > Mike > > On Jan 22 2013, at 13:27 , Mike Duigou wrote: > >> Hello all; >> >> This is a patch that has been lingering around in the lambda/lambda repo for a long time. It adds minimal support for the MacOSX platform to the JDK NetBeans projects. It could also be used as the basis for similar support for the langtools NetBeans projects. >> >> The patch also adjust the source level of the project to 1.8 and removes some long obsolete cruft. >> >> http://cr.openjdk.java.net/~mduigou/8006709/0/webrev/ >> >> Mike > From david.katleman at oracle.com Wed Jan 30 21:44:34 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 21:44:34 +0000 Subject: hg: jdk8/build: 10 new changesets Message-ID: <20130130214435.55A81476B9@hg.openjdk.java.net> Changeset: cd2fa0d0ed3d Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/cd2fa0d0ed3d Added tag jdk8-b74 for changeset b43aa5bd8ca5 ! .hgtags Changeset: 1129fb75f611 Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/1129fb75f611 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: cecfba251e4a Author: lana Date: 2013-01-16 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/cecfba251e4a Merge Changeset: 2e12a508d7ae Author: lana Date: 2013-01-20 23:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/2e12a508d7ae Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/makefiles/javadoc/Javadoc.gmk Changeset: 8209c91b751d Author: sherman Date: 2013-01-22 21:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/8209c91b751d 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! common/makefiles/javadoc/CORE_PKGS.gmk ! make/jprt.properties ! test/Makefile Changeset: 039783b67959 Author: lana Date: 2013-01-26 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/039783b67959 Merge Changeset: e28985c549aa Author: raginip Date: 2013-01-18 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/e28985c549aa 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! common/bin/compare_exceptions.sh.incl Changeset: db46b1c27a93 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/db46b1c27a93 Merge - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl Changeset: 8baaaba2ee6b Author: lana Date: 2013-01-29 20:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/8baaaba2ee6b Merge Changeset: 2a713921952c Author: katleman Date: 2013-01-30 13:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/2a713921952c Merge ! common/autoconf/generated-configure.sh From david.katleman at oracle.com Wed Jan 30 21:44:39 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 21:44:39 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b74 for changeset 2132845cf5f7 Message-ID: <20130130214440.A7F21476BA@hg.openjdk.java.net> Changeset: d4e68ce17795 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/d4e68ce17795 Added tag jdk8-b74 for changeset 2132845cf5f7 ! .hgtags From david.katleman at oracle.com Wed Jan 30 21:47:21 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 21:47:21 +0000 Subject: hg: jdk8/build/hotspot: 65 new changesets Message-ID: <20130130214925.68C83476BB@hg.openjdk.java.net> Changeset: 89fc17e8d808 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/89fc17e8d808 Added tag jdk8-b74 for changeset 1a3e54283c54 ! .hgtags Changeset: d58b7b43031b Author: amurillo Date: 2013-01-11 02:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d58b7b43031b 8006034: new hotspot build - hs25-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: adc176e95bf2 Author: acorn Date: 2013-01-09 11:39 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/adc176e95bf2 8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests Summary: Fix verifier for new interface access flags Reviewed-by: acorn, kvn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/classfile/classFileParser.cpp Changeset: dd7248d3e151 Author: zgu Date: 2013-01-09 14:46 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dd7248d3e151 7152671: RFE: Windows decoder should add some std dirs to the symbol search path Summary: Added JRE/JDK bin directories to decoder's symbol search path Reviewed-by: dcubed, sla ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp Changeset: 97ee8abd6ab2 Author: zgu Date: 2013-01-09 12:10 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/97ee8abd6ab2 Merge Changeset: aefb345d3f5e Author: acorn Date: 2013-01-10 17:38 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/aefb345d3f5e 7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow Summary: Reduce scope of placeholder table entries to improve cleanup Reviewed-by: dholmes, coleenp ! src/share/vm/classfile/placeholders.cpp ! src/share/vm/classfile/placeholders.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/utilities/exceptions.hpp Changeset: 91bf7da5c609 Author: mikael Date: 2013-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/91bf7da5c609 8004747: Remove last_entry from VM_STRUCT macros Summary: Instead of passing in last_entry to all the VM_ macros just expand it in the main vmStructs.cpp file. Reviewed-by: dholmes, sspitsyn, minqi ! src/cpu/sparc/vm/vmStructs_sparc.hpp ! src/cpu/x86/vm/vmStructs_x86.hpp ! src/cpu/zero/vm/vmStructs_zero.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c1c8479222cd Author: dholmes Date: 2013-01-10 21:00 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c1c8479222cd 8005921: Memory leaks in vmStructs.cpp Reviewed-by: dholmes, mikael, rasbold Contributed-by: Jeremy Manson ! src/share/vm/runtime/vmStructs.cpp Changeset: e0cf9af8978e Author: zgu Date: 2013-01-11 12:30 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e0cf9af8978e 8005936: PrintNMTStatistics doesn't work for normal JVM exit Summary: Moved NMT shutdown code to JVM exit handler to ensure NMT statistics is printed when PrintNMTStatistics is enabled Reviewed-by: acorn, dholmes, coleenp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 90a92d5bca17 Author: zgu Date: 2013-01-11 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/90a92d5bca17 Merge Changeset: 4a916f2ce331 Author: jwilhelm Date: 2013-01-14 15:17 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4a916f2ce331 8003985: Support @Contended Annotation - JEP 142 Summary: HotSpot changes to support @Contended annotation. Reviewed-by: coleenp, kvn, jrose Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f9eb431c3efe Author: coleenp Date: 2013-01-14 11:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f9eb431c3efe 8006005: Fix constant pool index validation and alignment trap for method parameter reflection Summary: This patch addresses an alignment trap due to the storage format of method parameters data in constMethod. It also adds code to validate constant pool indexes for method parameters data. Reviewed-by: jrose, dholmes Contributed-by: eric.mccorkle at oracle.com ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/reflection.cpp Changeset: 5b6a231e5a86 Author: coleenp Date: 2013-01-14 08:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5b6a231e5a86 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: fe1472c87a27 Author: mikael Date: 2013-01-14 11:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fe1472c87a27 8005592: ClassLoaderDataGraph::_unloading incorrectly defined as nonstatic in vmStructs Summary: Added assertion to catch problem earlier and removed the unused field Reviewed-by: dholmes, acorn ! src/share/vm/runtime/vmStructs.cpp Changeset: c793367610c1 Author: coleenp Date: 2013-01-15 17:05 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c793367610c1 8005467: CDS size information is incorrect and unfriendly Summary: Changed words to bytes, and added usage percentage information Reviewed-by: coleenp, twisti Contributed-by: ioi.lam at oracle.com ! src/share/vm/memory/metaspaceShared.cpp Changeset: 92d4b5d8dde4 Author: acorn Date: 2013-01-16 18:23 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/92d4b5d8dde4 Merge ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 337e1dd9d902 Author: jiangli Date: 2013-01-11 16:55 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/337e1dd9d902 8005895: Inefficient InstanceKlass field packing wasts memory. Summary: Pack _misc_has_default_methods into the _misc_flags, move _idnum_allocated_count. Reviewed-by: coleenp, shade ! src/share/vm/oops/instanceKlass.hpp Changeset: 94fa3c4e7643 Author: vladidan Date: 2013-01-14 13:44 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/94fa3c4e7643 8005639: Move InlineSynchronizedMethods flag from develop to product Summary: Move InlineSynchronizedMethods flag from develop to product Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/c1/c1_globals.hpp Changeset: 9deda4d8e126 Author: vladidan Date: 2013-01-14 13:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9deda4d8e126 8005204: Code Cache Reduction: command line options implementation Summary: Adding more detailed output on CodeCache usage Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 212c5b9c38e7 Author: dlong Date: 2013-01-17 01:27 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/212c5b9c38e7 Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: a3f92e6c0274 Author: twisti Date: 2013-01-11 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a3f92e6c0274 8006031: LibraryCallKit::inline_array_copyOf disabled unintentionally with 7172640 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: f9bda35f4226 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f9bda35f4226 8005816: Shark: fix volatile float field access Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkBlock.cpp Changeset: c566b81b3323 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c566b81b3323 8005817: Shark: implement deoptimization support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/frame_zero.cpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/sharkFrame_zero.hpp ! src/share/vm/shark/sharkInvariants.hpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: c095a7f289aa Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c095a7f289aa 8005818: Shark: fix OSR for non-empty incoming stack Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkFunction.cpp ! src/share/vm/shark/sharkInvariants.hpp Changeset: 606eada1bf86 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/606eada1bf86 8005820: Shark: enable JSR292 support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkCompiler.hpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkInliner.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: 6d1f5516534e Author: twisti Date: 2013-01-11 20:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6d1f5516534e 8006127: remove printing code added with 8006031 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: d92fa52a5d03 Author: vlivanov Date: 2013-01-14 08:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d92fa52a5d03 8006095: C1: SIGSEGV w/ -XX:+LogCompilation Summary: avoid printing inlining decision when compilation fails Reviewed-by: kvn, roland ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f1de9dbc914e Author: twisti Date: 2013-01-15 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f1de9dbc914e 8006109: test/java/util/AbstractSequentialList/AddAll.java fails: assert(rtype == ctype) failed: mismatched return types Reviewed-by: kvn ! src/share/vm/ci/ciType.cpp ! src/share/vm/ci/ciType.hpp ! src/share/vm/opto/doCall.cpp Changeset: 5b8548391bf3 Author: kvn Date: 2013-01-15 14:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5b8548391bf3 8005821: C2: -XX:+PrintIntrinsics is broken Summary: Check all print inlining flags when processing inlining list. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! src/share/vm/opto/compile.cpp Changeset: bf623b2d5508 Author: kvn Date: 2013-01-16 14:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bf623b2d5508 8006204: please JTREGify test/compiler/7190310/Test7190310.java Summary: Add proper jtreg annotations in the preceding comment, including an explicit timeout. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! test/compiler/7190310/Test7190310.java Changeset: eab4f9ed602c Author: kvn Date: 2013-01-17 18:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/eab4f9ed602c Merge ! src/share/vm/compiler/compileBroker.cpp Changeset: 689e1218d7fe Author: brutisso Date: 2013-01-14 09:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/689e1218d7fe 8004018: Remove old initialization flags Reviewed-by: dholmes, stefank Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: a30e7b564541 Author: brutisso Date: 2013-01-14 21:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a30e7b564541 8005972: ParNew should not update the tenuring threshold when promotion failed has occurred Reviewed-by: ysr, johnc, jwilhelm ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp Changeset: ed6154d7d259 Author: stefank Date: 2013-01-15 13:32 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ed6154d7d259 8005590: java_lang_Class injected field resolved_constructor appears unused Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ff0a7943fd29 Author: stefank Date: 2013-01-15 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ff0a7943fd29 8005994: Method annotations are allocated unnecessarily during class file parsing Summary: Also reviewed by: vitalyd at gmail.com Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/prims/jvm.cpp Changeset: 4967eb4f67a9 Author: johnc Date: 2013-01-15 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4967eb4f67a9 8001425: G1: Change the default values for certain G1 specific flags Summary: Changes to default and ergonomic flag values recommended by performance team. Changes were also reviewed by Monica Beckwith . Reviewed-by: brutisso, huntch ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 2dce7c34c564 Author: stefank Date: 2013-01-17 11:39 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2dce7c34c564 8006513: Null pointer in DefaultMethods::generate_default_methods when merging annotations Reviewed-by: brutisso, jfranck ! src/share/vm/classfile/defaultMethods.cpp Changeset: 59a58e20dc60 Author: jmasa Date: 2013-01-17 19:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/59a58e20dc60 8006537: Assert when dumping archive with default methods Reviewed-by: coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metadataFactory.hpp Changeset: f422634e5828 Author: brutisso Date: 2013-01-18 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f422634e5828 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 70c89bd6b895 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/70c89bd6b895 Merge Changeset: 2b878edabfc0 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2b878edabfc0 Added tag hs25-b16 for changeset 70c89bd6b895 ! .hgtags Changeset: 46e60405583b Author: amurillo Date: 2013-01-18 05:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/46e60405583b 8006511: new hotspot build - hs25-b17 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e94ed1591b42 Author: sla Date: 2013-01-16 16:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e94ed1591b42 8006403: Regression: jstack failed due to the FieldInfo regression in SA Reviewed-by: sla, dholmes Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 557bda927cc2 Author: sla Date: 2013-01-18 14:15 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/557bda927cc2 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: 617b18aadb33 Author: sla Date: 2013-01-18 19:13 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/617b18aadb33 Merge Changeset: 203f64878aab Author: hseigel Date: 2013-01-17 10:25 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/203f64878aab 7102489: RFE: cleanup jlong typedef on __APPLE__and _LLP64 systems. Summary: Define jlong as long on all LP64 platforms and add JLONG_FORMAT macro. Reviewed-by: dholmes, coleenp, mikael, kvn ! src/cpu/x86/vm/jni_x86.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/java_md.h ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/launcher/java_md.c ! src/os/windows/launcher/java_md.h ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/share/tools/launcher/java.c ! src/share/tools/launcher/java.h ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/aprofiler.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/taskqueue.cpp Changeset: b14da2e6f2dc Author: coleenp Date: 2013-01-17 13:40 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b14da2e6f2dc 7174978: NPG: Fix bactrace builder for class redefinition Summary: Remove Method* from backtrace but save version so redefine classes doesn't give inaccurate line numbers. Removed old Merlin API with duplicate code. Reviewed-by: dholmes, sspitsyn ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: b5f6465019f6 Author: coleenp Date: 2013-01-17 22:11 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b5f6465019f6 8006548: version wrong in new constantPool code Summary: fix increment problem with saved_version Reviewed-by: dholmes ! src/share/vm/oops/constantPool.hpp Changeset: c07c102cbad7 Author: brutisso Date: 2013-01-21 09:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c07c102cbad7 8006431: os::Bsd::initialize_system_info() sets _physical_memory too large Summary: Use HW_MEMSIZE instead of HW_USERMEM to get a 64 bit value of the physical memory on the machine. Also reviewed by vitalyd at gmail.com. Reviewed-by: sla, dholmes, dlong, mikael ! src/os/bsd/vm/os_bsd.cpp Changeset: c73c3f2c5b3b Author: acorn Date: 2013-01-21 16:11 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c73c3f2c5b3b Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/services/diagnosticArgument.cpp Changeset: f3184f32ce0b Author: dcubed Date: 2013-01-22 05:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f3184f32ce0b 6444286: Possible naked oop related to biased locking revocation safepoint in jni_exit() Summary: Add missing Handle. Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/synchronizer.cpp Changeset: 22ba8c8ce6a6 Author: dcubed Date: 2013-01-22 05:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/22ba8c8ce6a6 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/objectMonitor.inline.hpp Changeset: 5ce621176715 Author: dcubed Date: 2013-01-22 05:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5ce621176715 8004903: VMThread::execute() calls Thread::check_for_valid_safepoint_state() on concurrent VM ops Summary: check_for_valid_safepoint_state() only applies to blocking VM ops Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/vmThread.cpp Changeset: edd23b35b1a5 Author: zgu Date: 2013-01-22 14:27 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/edd23b35b1a5 6871190: Don't terminate JVM if it is running in a non-interactive session Summary: Don't handle CTRL_LOGOFF_EVENT event when the process is running in a non-interactive session Reviewed-by: ctornqvi, acorn ! src/os/windows/vm/os_windows.cpp Changeset: 2ef7061f13b4 Author: zgu Date: 2013-01-22 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2ef7061f13b4 Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7df93f7c14a5 Author: brutisso Date: 2013-01-16 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7df93f7c14a5 8006242: G1: WorkerDataArray::verify() too strict for double calculations Summary: Also reviewed by vitalyd at gmail.com. Reviewed-by: johnc, mgerdin ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp Changeset: bf8c2b2c8cfa Author: mgerdin Date: 2013-01-22 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bf8c2b2c8cfa 8004147: test/Makefile jtreg_tests target does not work with cygwin Reviewed-by: ctornqvi, brutisso ! test/Makefile Changeset: d754ef7b9352 Author: jmasa Date: 2013-01-24 06:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d754ef7b9352 Merge Changeset: a7114d3d712e Author: kvn Date: 2013-01-22 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a7114d3d712e 8005055: pass outputStream to more opto debug routines Summary: pass the output stream to node->dump() and everything reachable from there Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/regalloc.cpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp Changeset: b30b3c2a0cf2 Author: kvn Date: 2013-01-22 15:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b30b3c2a0cf2 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86 Summary: Use SSE4.2 and AVX2 instructions for encodeArray intrinsic. Reviewed-by: roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp + test/compiler/6896617/Test6896617.java Changeset: 522c328b8b77 Author: kvn Date: 2013-01-23 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/522c328b8b77 8003878: compiler/7196199 test failed on OS X since 8b54, jdk7u12b01 Summary: Limit vectors size to 16 bytes on BSD until the problem is fixed Reviewed-by: twisti ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: 22ead76da3f4 Author: kmo Date: 2013-01-24 02:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/22ead76da3f4 8006758: LinkResolver assertion (caused by @Contended changes) Summary: treat anonymous classes as privileged code to restore the special handling for @Compiled during class file parsing Reviewed-by: jrose, coleenp, kvn, dholmes ! src/share/vm/classfile/classFileParser.cpp Changeset: 274a29bf5682 Author: kmo Date: 2013-01-24 09:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/274a29bf5682 Merge Changeset: b4391649e91e Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b4391649e91e Merge ! .hgtags Changeset: 6778d0b16593 Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6778d0b16593 Added tag hs25-b17 for changeset b4391649e91e ! .hgtags From david.katleman at oracle.com Wed Jan 30 21:50:57 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 21:50:57 +0000 Subject: hg: jdk8/build/jaxp: 5 new changesets Message-ID: <20130130215110.B1AF3476BC@hg.openjdk.java.net> Changeset: 69bc57b1ebdd Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/69bc57b1ebdd Added tag jdk8-b74 for changeset 2087e24a4357 ! .hgtags Changeset: 47738fa4d411 Author: dbuck Date: 2013-01-10 20:26 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/47738fa4d411 8003147: port fix for BCEL bug 39695 Summary: Added support for Local Variable Type Table so that BCEL library can be used to modify methods with generics-related debug data without violating class file format Reviewed-by: lancea ! src/com/sun/org/apache/bcel/internal/Constants.java ! src/com/sun/org/apache/bcel/internal/classfile/Attribute.java ! src/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java ! src/com/sun/org/apache/bcel/internal/classfile/EmptyVisitor.java + src/com/sun/org/apache/bcel/internal/classfile/LocalVariableTypeTable.java ! src/com/sun/org/apache/bcel/internal/classfile/Visitor.java ! src/com/sun/org/apache/bcel/internal/generic/MethodGen.java Changeset: 06827097cdd3 Author: lana Date: 2013-01-16 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/06827097cdd3 Merge Changeset: 4e049aa2495f Author: lana Date: 2013-01-20 23:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/4e049aa2495f Merge Changeset: ff0b73a6b3f6 Author: lana Date: 2013-01-26 18:25 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/ff0b73a6b3f6 Merge From david.katleman at oracle.com Wed Jan 30 21:51:17 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 21:51:17 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b74 for changeset 12db3c5a3393 Message-ID: <20130130215121.1BBA1476BD@hg.openjdk.java.net> Changeset: 966bf9f3c41a Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/966bf9f3c41a Added tag jdk8-b74 for changeset 12db3c5a3393 ! .hgtags From david.katleman at oracle.com Wed Jan 30 21:53:23 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 21:53:23 +0000 Subject: hg: jdk8/build/jdk: 92 new changesets Message-ID: <20130130221102.21385476BE@hg.openjdk.java.net> Changeset: ef592aceb40e Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ef592aceb40e Added tag jdk8-b74 for changeset 57d5d9544628 ! .hgtags Changeset: c6e8a518c3cd Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c6e8a518c3cd 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! make/docs/Makefile Changeset: c9308137ad9e Author: jjg Date: 2013-01-10 19:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c9308137ad9e Merge - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 86c563dc70ca Author: darcy Date: 2013-01-10 21:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/86c563dc70ca 8006062: Add @Repeatable to repeating annotations regression tests in JDK repo Reviewed-by: jjg ! test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java Changeset: 0ca2e39a110d Author: alanb Date: 2013-01-11 12:27 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0ca2e39a110d 8005566: (fs) test/java/nio/file/Files/Misc.java failing (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! test/java/nio/file/Files/Misc.java Changeset: 7da291690aa0 Author: alanb Date: 2013-01-11 20:19 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7da291690aa0 8005978: shell tests need to use the $COMPILEJDK for javac, jar and other tools Reviewed-by: chegar ! test/ProblemList.txt ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/getEnclosingClass/build.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh ! test/java/lang/Thread/UncaughtExceptions.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/instrument/AppendToBootstrapClassPathSetUp.sh ! test/java/lang/instrument/AppendToClassPathSetUp.sh ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/MakeJAR.sh ! test/java/lang/instrument/MakeJAR2.sh ! test/java/lang/instrument/MakeJAR3.sh ! test/java/lang/instrument/MakeJAR4.sh ! test/java/lang/instrument/ManifestTest.sh ! test/java/lang/instrument/ParallelTransformerLoader.sh ! test/java/lang/instrument/PremainClass/NoPremainAgent.sh ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineClassWithNativeMethod.sh ! test/java/lang/instrument/RedefineMethodAddInvoke.sh ! test/java/lang/instrument/RedefineSetUp.sh ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/charset/spi/basic.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Formatter/Basic.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/PrefsSpi.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/script/CommonSetup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/security/krb5/config/dns.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/keytool/autotest.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/readjar.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/util/Oid/S11N.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/ClassPathWildCard.sh ! test/tools/launcher/MultipleJRE.sh Changeset: bc1f16f5566f Author: darcy Date: 2013-01-11 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc1f16f5566f 7131459: [Fmt-De] DecimalFormat produces wrong format() results when close to a tie Reviewed-by: darcy Contributed-by: olivier.lagneau at oracle.com ! src/share/classes/java/text/DigitList.java ! src/share/classes/sun/misc/FloatingDecimal.java + test/java/text/Format/DecimalFormat/TieRoundingTest.java Changeset: 6f6246aced89 Author: sherman Date: 2013-01-11 22:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6f6246aced89 8005466: JAR file entry hash table uses too much memory (zlib_util.c) Summary: realign the fields of jzcell struct Reviewed-by: sherman Contributed-by: ioi.lam at oracle.com ! src/share/native/java/util/zip/zip_util.h Changeset: 8009c7e3899e Author: sherman Date: 2013-01-11 22:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8009c7e3899e Merge Changeset: 7db04ae3378f Author: chegar Date: 2013-01-13 22:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7db04ae3378f 8006153: HTTP protocol handler authenication should use Base64 API Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java Changeset: 1109bfff4e92 Author: dholmes Date: 2013-01-13 19:57 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1109bfff4e92 8005232: (JEP-149) Class Instance size reduction Summary: Moved the fields for cached reflection objects into a seperate ReflectionData object to reduce dynamic footprint. Reviewed-by: dholmes, mchung, shade Contributed-by: Peter Levart ! src/share/classes/java/lang/Class.java Changeset: 1d7a6adf499f Author: naoto Date: 2013-01-14 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1d7a6adf499f 7162007: Clean up i18n related caches Reviewed-by: okutsu, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/text/resources/zh/CollationData_zh_HK.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_HK.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/CollatorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CurrencyNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + src/share/classes/sun/util/locale/provider/ResourceBundleBasedAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_SG.java ! src/share/classes/sun/util/resources/zh/LocaleNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_HK.java ! test/java/util/PluggableLocale/BreakIteratorProviderTest.java ! test/java/util/PluggableLocale/CollatorProviderTest.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/DateFormatProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.java ! test/java/util/PluggableLocale/NumberFormatProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java Changeset: dcb64d498d5b Author: ksrini Date: 2013-01-14 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dcb64d498d5b 8005252: pack200 should support MethodParameters Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/main.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/ProblemList.txt ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java Changeset: edb7e34a0531 Author: xuelei Date: 2013-01-14 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/edb7e34a0531 8006265: Add test SSLEngineDeadlock.java to ProblemList Reviewed-by: weijun ! test/ProblemList.txt Changeset: a40052a54801 Author: uta Date: 2013-01-15 14:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a40052a54801 8005250: Downgrade normative references to ${java.home}/lib folder from Java client code. Summary: Javadoc was changed in accordance with CCC-8005250 request. Reviewed-by: alanb, amenkov ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/javax/imageio/spi/IIORegistry.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/swing/UIManager.java Changeset: 4b012af44f24 Author: chegar Date: 2013-01-15 11:44 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b012af44f24 8005406: HTTP server implementation should use Base64 API Reviewed-by: khazra, alanb, chegar Contributed-by: Mark Sheppard ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java Changeset: 44d6cabc9a3f Author: robm Date: 2013-01-15 19:58 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/44d6cabc9a3f 8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java Changeset: 9d8ef6174cfd Author: dl Date: 2013-01-16 10:14 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9d8ef6174cfd 8005926: Merge ThreadLocalRandom state into java.lang.Thread Reviewed-by: shade, chegar ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java Changeset: a546d8897e0d Author: dl Date: 2013-01-16 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a546d8897e0d 8001666: Add lambda-compatible atomics and accumulators to the ActomicXXX classes Reviewed-by: dl, chegar, darcy, goetz Contributed-by: dl at cs.oswego.edu, chris.hegarty at oracle.com ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: c7d54f93d3e5 Author: juh Date: 2013-01-16 09:51 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c7d54f93d3e5 8005389: Backout fix for JDK-6500133 Reviewed-by: mullan ! src/share/classes/sun/security/x509/URIName.java ! test/sun/security/x509/URIName/Parse.java Changeset: f7f77bdf248b Author: juh Date: 2013-01-16 13:35 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f7f77bdf248b 8005939: sun/security/x509/{X509CRLImplX509CertImpl}/Verify.java fail in confusing way when some providers not present Reviewed-by: mullan, weijun ! test/sun/security/x509/X509CRLImpl/Verify.java ! test/sun/security/x509/X509CertImpl/Verify.java Changeset: 9fed48caac80 Author: lana Date: 2013-01-16 12:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9fed48caac80 Merge Changeset: 787c7c1c210f Author: sherman Date: 2013-01-17 12:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/787c7c1c210f 8006090: Formatter asserts with -esa Summary: removed the offending assert Reviewed-by: alanb, darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/util/Formatter.java ! test/ProblemList.txt Changeset: e8414d69692c Author: khazra Date: 2013-01-17 14:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e8414d69692c 7171415: java.net.URI.equals/hashCode not consistent for some URIs Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed by vitalyd at gmail.com, schlosna at gmail.com Reviewed-by: chegar ! src/share/classes/java/net/URI.java ! test/java/net/URI/Test.java Changeset: 79fed1733d4a Author: jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number of ports in the reserved range Reviewed-by: mduigou ! test/java/rmi/testlibrary/TestLibrary.java Changeset: f88e963960ae Author: jzavgren Date: 2013-01-18 17:34 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f88e963960ae 8005120: Compiler warnings in socket transport native code Reviewed-by: chegar, dsamersoff ! src/share/transport/socket/socketTransport.c ! src/share/transport/socket/sysSocket.h ! src/solaris/transport/socket/socket_md.c ! src/windows/transport/socket/socket_md.c Changeset: 06da87777d0e Author: alanb Date: 2013-01-18 18:48 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/06da87777d0e 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java Changeset: 33d0175ea8d9 Author: msheppar Date: 2013-01-19 08:39 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/33d0175ea8d9 8006568: HTTP protocol handler NLTM Authentication should use Base64 API Reviewed-by: chegar, alanb ! src/solaris/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java ! test/sun/net/www/protocol/http/ProxyTunnelServer.java Changeset: 78514544980d Author: lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Changeset: d3da0d29d7cd Author: lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverManager.java + src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLTimeoutException.java + src/share/classes/java/sql/SQLType.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Types.java ! src/share/classes/java/sql/package.html ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java Changeset: bb2ed83676d2 Author: chegar Date: 2013-01-20 09:37 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb2ed83676d2 8006560: java/net/ipv6tests/B6521014.java fails intermittently Reviewed-by: khazra, wetmore ! test/java/net/ipv6tests/B6521014.java Changeset: 6ca6b6f07653 Author: okutsu Date: 2013-01-21 12:04 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6ca6b6f07653 4745761: (cal) RFE: Support builder for constructing Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java + test/java/util/Calendar/Builder/BuilderTest.java ! test/java/util/Calendar/CalendarTypeTest.java Changeset: 3c1a440a1e12 Author: okutsu Date: 2013-01-21 15:41 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c1a440a1e12 8004489: Add support for Minguo and Hijrah calendars to CalendarNameProvider SPI 8006509: Add more calendar symbol names from CLDR Reviewed-by: peytoia ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/CalendarType.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/java/util/Calendar/CldrFormatNamesTest.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: bb940b2107bd Author: juh Date: 2013-01-21 15:05 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb940b2107bd 8006092: SecurityPermission: printIdentity doesn't exist Reviewed-by: weijun ! test/sun/security/tools/policytool/UpdatePermissions.html Changeset: f21a3c273fb2 Author: dl Date: 2013-01-21 13:50 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f21a3c273fb2 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder Reviewed-by: chegar, darcy, goetz ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java + src/share/classes/java/util/concurrent/atomic/DoubleAdder.java + src/share/classes/java/util/concurrent/atomic/LongAccumulator.java + src/share/classes/java/util/concurrent/atomic/LongAdder.java + src/share/classes/java/util/concurrent/atomic/Striped64.java + test/java/util/concurrent/atomic/DoubleAdderDemo.java + test/java/util/concurrent/atomic/LongAdderDemo.java Changeset: de30e46250c5 Author: lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java Changeset: 8b1857409159 Author: lana Date: 2013-01-20 23:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b1857409159 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 7f4e3da76ec1 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7f4e3da76ec1 Merge Changeset: 8ee6d45348ba Author: vinnie Date: 2013-01-22 23:32 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8ee6d45348ba 6263419: No way to clean the memory for a java.security.Key Reviewed-by: mullan ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java ! src/share/classes/javax/security/auth/Destroyable.java + test/javax/security/auth/Destroyable/KeyDestructionTest.java Changeset: c18f28312c49 Author: smarks Date: 2013-01-22 18:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c18f28312c49 8005646: TEST_BUG: java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup leaves process running Reviewed-by: mchung ! test/java/rmi/activation/ActivationSystem/unregisterGroup/ActivateMe.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/rmid.security.policy Changeset: 919afffa70b0 Author: sherman Date: 2013-01-22 20:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/919afffa70b0 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! make/docs/CORE_PKGS.gmk ! make/java/Makefile + make/java/time/Makefile ! make/jprt.properties ! make/sun/Makefile + make/sun/tzdb/Makefile ! make/tools/Makefile + make/tools/src/build/tools/tzdb/ChronoField.java + make/tools/src/build/tools/tzdb/DateTimeException.java + make/tools/src/build/tools/tzdb/LocalDate.java + make/tools/src/build/tools/tzdb/LocalDateTime.java + make/tools/src/build/tools/tzdb/LocalTime.java + make/tools/src/build/tools/tzdb/TimeDefinition.java + make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/tools/src/build/tools/tzdb/Utils.java + make/tools/src/build/tools/tzdb/ZoneOffset.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/tools/src/build/tools/tzdb/ZoneRules.java + make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java + make/tools/tzdb/Makefile ! makefiles/CreateJars.gmk + makefiles/GendataTZDB.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk + src/share/classes/java/time/Clock.java + src/share/classes/java/time/DateTimeException.java + src/share/classes/java/time/DayOfWeek.java + src/share/classes/java/time/Duration.java + src/share/classes/java/time/Instant.java + src/share/classes/java/time/LocalDate.java + src/share/classes/java/time/LocalDateTime.java + src/share/classes/java/time/LocalTime.java + src/share/classes/java/time/Month.java + src/share/classes/java/time/Period.java + src/share/classes/java/time/PeriodParser.java + src/share/classes/java/time/Ser.java + src/share/classes/java/time/ZoneId.java + src/share/classes/java/time/ZoneOffset.java + src/share/classes/java/time/ZoneRegion.java + src/share/classes/java/time/ZonedDateTime.java + src/share/classes/java/time/calendar/ChronoDateImpl.java + src/share/classes/java/time/calendar/HijrahChrono.java + src/share/classes/java/time/calendar/HijrahDate.java + src/share/classes/java/time/calendar/HijrahDeviationReader.java + src/share/classes/java/time/calendar/HijrahEra.java + src/share/classes/java/time/calendar/JapaneseChrono.java + src/share/classes/java/time/calendar/JapaneseDate.java + src/share/classes/java/time/calendar/JapaneseEra.java + src/share/classes/java/time/calendar/MinguoChrono.java + src/share/classes/java/time/calendar/MinguoDate.java + src/share/classes/java/time/calendar/MinguoEra.java + src/share/classes/java/time/calendar/Ser.java + src/share/classes/java/time/calendar/ThaiBuddhistChrono.java + src/share/classes/java/time/calendar/ThaiBuddhistDate.java + src/share/classes/java/time/calendar/ThaiBuddhistEra.java + src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/format/DateTimeBuilder.java + src/share/classes/java/time/format/DateTimeFormatStyleProvider.java + src/share/classes/java/time/format/DateTimeFormatSymbols.java + src/share/classes/java/time/format/DateTimeFormatter.java + src/share/classes/java/time/format/DateTimeFormatterBuilder.java + src/share/classes/java/time/format/DateTimeFormatters.java + src/share/classes/java/time/format/DateTimeParseContext.java + src/share/classes/java/time/format/DateTimeParseException.java + src/share/classes/java/time/format/DateTimePrintContext.java + src/share/classes/java/time/format/DateTimePrintException.java + src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/SignStyle.java + src/share/classes/java/time/format/TextStyle.java + src/share/classes/java/time/format/package-info.java + src/share/classes/java/time/overview.html + src/share/classes/java/time/package-info.java + src/share/classes/java/time/temporal/Adjusters.java + src/share/classes/java/time/temporal/Chrono.java + src/share/classes/java/time/temporal/ChronoField.java + src/share/classes/java/time/temporal/ChronoLocalDate.java + src/share/classes/java/time/temporal/ChronoLocalDateTime.java + src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/temporal/ChronoUnit.java + src/share/classes/java/time/temporal/ChronoZonedDateTime.java + src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/temporal/Era.java + src/share/classes/java/time/temporal/ISOChrono.java + src/share/classes/java/time/temporal/ISOEra.java + src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/JulianFields.java + src/share/classes/java/time/temporal/MonthDay.java + src/share/classes/java/time/temporal/OffsetDate.java + src/share/classes/java/time/temporal/OffsetDateTime.java + src/share/classes/java/time/temporal/OffsetTime.java + src/share/classes/java/time/temporal/Queries.java + src/share/classes/java/time/temporal/Ser.java + src/share/classes/java/time/temporal/SimplePeriod.java + src/share/classes/java/time/temporal/Temporal.java + src/share/classes/java/time/temporal/TemporalAccessor.java + src/share/classes/java/time/temporal/TemporalAdder.java + src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalField.java + src/share/classes/java/time/temporal/TemporalQuery.java + src/share/classes/java/time/temporal/TemporalSubtractor.java + src/share/classes/java/time/temporal/TemporalUnit.java + src/share/classes/java/time/temporal/ValueRange.java + src/share/classes/java/time/temporal/WeekFields.java + src/share/classes/java/time/temporal/Year.java + src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package-info.java + src/share/classes/java/time/zone/Ser.java + src/share/classes/java/time/zone/TzdbZoneRulesProvider.java + src/share/classes/java/time/zone/ZoneOffsetTransition.java + src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java + src/share/classes/java/time/zone/ZoneRules.java + src/share/classes/java/time/zone/ZoneRulesException.java + src/share/classes/java/time/zone/ZoneRulesProvider.java + src/share/classes/java/time/zone/package-info.java ! src/share/classes/java/util/Formatter.java ! test/Makefile + test/java/time/META-INF/services/java.time.temporal.Chrono + test/java/time/TEST.properties + test/java/time/tck/java/time/AbstractDateTimeTest.java + test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/TCKClock.java + test/java/time/tck/java/time/TCKClock_Fixed.java + test/java/time/tck/java/time/TCKClock_Offset.java + test/java/time/tck/java/time/TCKClock_System.java + test/java/time/tck/java/time/TCKClock_Tick.java + test/java/time/tck/java/time/TCKDayOfWeek.java + test/java/time/tck/java/time/TCKDuration.java + test/java/time/tck/java/time/TCKInstant.java + test/java/time/tck/java/time/TCKLocalDate.java + test/java/time/tck/java/time/TCKLocalDateTime.java + test/java/time/tck/java/time/TCKLocalTime.java + test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKZoneId.java + test/java/time/tck/java/time/TCKZoneOffset.java + test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/calendar/CopticChrono.java + test/java/time/tck/java/time/calendar/CopticDate.java + test/java/time/tck/java/time/calendar/CopticEra.java + test/java/time/tck/java/time/calendar/TestChronoLocalDate.java + test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java + test/java/time/tck/java/time/calendar/TestHijrahChrono.java + test/java/time/tck/java/time/calendar/TestJapaneseChrono.java + test/java/time/tck/java/time/calendar/TestMinguoChrono.java + test/java/time/tck/java/time/calendar/TestServiceLoader.java + test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java + test/java/time/tck/java/time/format/TCKDateTimeFormatter.java + test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java + test/java/time/tck/java/time/format/TCKDateTimeFormatters.java + test/java/time/tck/java/time/format/TCKDateTimePrintException.java + test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java + test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java + test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java + test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/TCKMonthDay.java + test/java/time/tck/java/time/temporal/TCKOffsetDate.java + test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java + test/java/time/tck/java/time/temporal/TCKOffsetTime.java + test/java/time/tck/java/time/temporal/TCKSimplePeriod.java + test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/TCKYear.java + test/java/time/tck/java/time/temporal/TCKYearMonth.java + test/java/time/tck/java/time/temporal/TestChrono.java + test/java/time/tck/java/time/temporal/TestChronoLocalDate.java + test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java + test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java + test/java/time/tck/java/time/temporal/TestISOChrono.java + test/java/time/tck/java/time/zone/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java + test/java/time/test/java/time/AbstractTest.java + test/java/time/test/java/time/MockSimplePeriod.java + test/java/time/test/java/time/TestClock_Fixed.java + test/java/time/test/java/time/TestClock_Offset.java + test/java/time/test/java/time/TestClock_System.java + test/java/time/test/java/time/TestClock_Tick.java + test/java/time/test/java/time/TestDuration.java + test/java/time/test/java/time/TestInstant.java + test/java/time/test/java/time/TestLocalDate.java + test/java/time/test/java/time/TestLocalDateTime.java + test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestPeriod.java + test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/TestZoneOffset.java + test/java/time/test/java/time/TestZonedDateTime.java + test/java/time/test/java/time/format/AbstractTestPrinterParser.java + test/java/time/test/java/time/format/MockIOExceptionAppendable.java + test/java/time/test/java/time/format/TestCharLiteralParser.java + test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java + test/java/time/test/java/time/format/TestDateTimeFormatter.java + test/java/time/test/java/time/format/TestDateTimeFormatters.java + test/java/time/test/java/time/format/TestDateTimePrintException.java + test/java/time/test/java/time/format/TestDateTimeTextProvider.java + test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNumberParser.java + test/java/time/test/java/time/format/TestNumberPrinter.java + test/java/time/test/java/time/format/TestPadParserDecorator.java + test/java/time/test/java/time/format/TestPadPrinterDecorator.java + test/java/time/test/java/time/format/TestReducedParser.java + test/java/time/test/java/time/format/TestReducedPrinter.java + test/java/time/test/java/time/format/TestSettingsParser.java + test/java/time/test/java/time/format/TestStringLiteralParser.java + test/java/time/test/java/time/format/TestStringLiteralPrinter.java + test/java/time/test/java/time/format/TestTextParser.java + test/java/time/test/java/time/format/TestTextPrinter.java + test/java/time/test/java/time/format/TestZoneIdParser.java + test/java/time/test/java/time/format/TestZoneOffsetParser.java + test/java/time/test/java/time/format/TestZoneOffsetPrinter.java + test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/temporal/MockFieldNoValue.java + test/java/time/test/java/time/temporal/MockFieldValue.java + test/java/time/test/java/time/temporal/TestChronoUnit.java + test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java + test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java + test/java/time/test/java/time/temporal/TestDateTimeValueRange.java + test/java/time/test/java/time/temporal/TestISOChronoImpl.java + test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestMonthDay.java + test/java/time/test/java/time/temporal/TestOffsetDate.java + test/java/time/test/java/time/temporal/TestOffsetDateTime.java + test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java + test/java/time/test/java/time/temporal/TestOffsetTime.java + test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java + test/java/time/test/java/time/temporal/TestYear.java + test/java/time/test/java/time/temporal/TestYearMonth.java + test/java/time/test/java/time/zone/TestFixedZoneRules.java + test/java/time/test/java/util/TestFormatter.java Changeset: 71691b9d45ab Author: vinnie Date: 2013-01-23 09:49 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java Changeset: 01b36b400145 Author: uta Date: 2013-01-23 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/01b36b400145 6519127: user.home property not set correctly Summary: Registry-based approach was changed to SHGetKnownFolderPath/SHGetFolderPathW Reviewed-by: alanb, anthony ! src/windows/native/java/lang/java_props_md.c Changeset: bf2a14ebb6e9 Author: chegar Date: 2013-01-23 14:45 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java Changeset: 53064bbaeec5 Author: alanb Date: 2013-01-23 15:12 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk Changeset: c9eb1d3ef37f Author: robm Date: 2013-01-23 17:54 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c9eb1d3ef37f 8004729: Add java.lang.reflect.Parameter and related changes for parameter reflection Reviewed-by: darcy, forax, psandoz, dholmes, tbell ! make/java/java/Exportedfiles.gmk ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java + src/share/classes/java/lang/reflect/Parameter.java ! src/share/javavm/export/jvm.h + src/share/native/java/lang/reflect/Executable.c + test/java/lang/reflect/Parameter/WithParameters.java + test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: e0552f13f4a2 Author: sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb ! test/java/util/zip/ZipFile/FinalizeZipFile.java Changeset: 87f5569effdd Author: sherman Date: 2013-01-23 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/87f5569effdd Merge Changeset: 0c86df653029 Author: vinnie Date: 2013-01-23 21:25 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/java/security/KeyStore/PBETest.java Changeset: 1da93663f8f3 Author: vinnie Date: 2013-01-23 23:13 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/java/security/PKCS12Attribute.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/share/classes/sun/security/x509/AlgorithmId.java + test/sun/security/pkcs12/StorePasswordTest.java + test/sun/security/pkcs12/StoreSecretKeyTest.java + test/sun/security/pkcs12/StoreTrustedCertTest.java + test/sun/security/pkcs12/trusted.pem Changeset: 89f37f7188df Author: mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: b68ac92d0b2a Author: alanb Date: 2013-01-24 09:47 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b68ac92d0b2a 8006524: JSR-3: Allows java.beans to be optional Reviewed-by: dfuchs, mchung ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/monitor/package.html Changeset: 943af87e0269 Author: vinnie Date: 2013-01-24 16:44 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/943af87e0269 8006855: PKCS12 test failures due to unsupported algorithm Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/StoreSecretKeyTest.java Changeset: 1fd613016ad9 Author: ksrini Date: 2013-01-24 09:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1fd613016ad9 8006850: [pack200] disable pack200 tests until JSR-308 is implemented Reviewed-by: alanb ! test/ProblemList.txt Changeset: b3f0e0c79bcc Author: vinnie Date: 2013-01-24 18:21 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b3f0e0c79bcc 8006863: javadoc cleanup for 8005408 Reviewed-by: alanb ! src/share/classes/java/security/PKCS12Attribute.java Changeset: 4d3c05cc21d5 Author: darcy Date: 2013-01-24 16:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4d3c05cc21d5 8006895: Clarify that FunctionalInferface is only informative Reviewed-by: briangoetz ! src/share/classes/java/lang/FunctionalInterface.java Changeset: 4c9fcb5cbc07 Author: dingxmin Date: 2013-01-25 17:00 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4c9fcb5cbc07 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource() Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/sun/misc/URLClassPath/JarLoaderTest.java Changeset: 4a4b97f7f83b Author: alanb Date: 2013-01-25 13:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a4b97f7f83b 8006565: java.lang.instrument specification should make it clear that -javaagent is optional Reviewed-by: sla, dcubed, mchung ! src/share/classes/java/lang/instrument/package.html Changeset: c6ea84a629db Author: vinnie Date: 2013-01-25 16:19 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c6ea84a629db 8006946: PKCS12 test failure due to incorrect alias name Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 117491dd58c2 Author: vinnie Date: 2013-01-25 17:47 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/117491dd58c2 8006951: Avoid storing duplicate PKCS12 attributes Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 77bde15bc6a9 Author: khazra Date: 2013-01-25 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77bde15bc6a9 7017962: Obsolete link is used in URL class level spec Summary: Change the link to an archived document Reviewed-by: chegar, mduigou ! src/share/classes/java/net/URL.java Changeset: 4209b3936a7f Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4209b3936a7f 8005632: Extend java.util.Logger to use Supplier for messages Reviewed-by: briangoetz, mduigou Contributed-by: henry.jen at oracle.com ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LoggerSupplierAPIsTest.java Changeset: 1d918647332e Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1d918647332e 8004201: Add static utility methods to primitives to be used for redution operations. Reviewed-by: darcy, mduigou, briangoetz, dholmes Contributed-by: akhil.arora at oracle.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java + test/java/lang/PrimitiveSumMinMaxTest.java Changeset: 86a5b435c928 Author: jgish Date: 2013-01-22 11:14 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/86a5b435c928 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java Changeset: e96577d82cbb Author: alanb Date: 2013-01-26 16:57 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e96577d82cbb 8006503: JVM_PrintStackTrace is not used in JDK Reviewed-by: alanb, darcy Contributed-by: eric.mccorkle at oracle.com ! src/share/javavm/export/jvm.h Changeset: 57561ea851d2 Author: lana Date: 2013-01-26 19:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/57561ea851d2 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 4faaaf5027a5 Author: alexsch Date: 2013-01-14 08:32 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4faaaf5027a5 7166409: bug4331515.java fail with NullPointerException on ubuntu10.04-x86 for JDK8 Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java Changeset: 9c6ca265b4a1 Author: alexsch Date: 2013-01-15 12:49 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9c6ca265b4a1 8003978: closed/javax/swing/JRootPane/bug4670486.java fails since jdk7u12b01 on macosx Reviewed-by: serb, leonidr ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/sun/swing/SwingUtilities2.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java Changeset: 1b886bd5e5bf Author: serb Date: 2013-01-15 21:57 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1b886bd5e5bf 7124525: [macosx] No animation on certain Swing components in Aqua LaF Reviewed-by: alexsch, swingler ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/macosx/classes/com/apple/laf/ImageCache.java Changeset: 7ea1372be2fe Author: mcherkas Date: 2013-01-16 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7ea1372be2fe 8005492: Reduce number of warnings in sun/awt/* classes Reviewed-by: art, anthony ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/TextArea.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/sun/awt/image/SurfaceManager.java Changeset: 23f9955ae34a Author: lana Date: 2013-01-16 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/23f9955ae34a Merge Changeset: 47243a4efb8b Author: kshefov Date: 2013-01-17 15:08 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/47243a4efb8b 7124209: [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] Reviewed-by: serb, alexsch + test/javax/swing/SpringLayout/4726194/bug4726194.java Changeset: 035f87fc9f74 Author: anthony Date: 2013-01-18 14:17 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/035f87fc9f74 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m Summary: Allow one to start AWT on the main thread w/o exceptions Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 5309fed435b5 Author: serb Date: 2013-01-18 18:17 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5309fed435b5 7179050: [macosx] Make LWAWT be able to run on AppKit thread Summary: Removed irrelevant assertions from the LWAWT native methods Reviewed-by: serb, anthony Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/ApplicationDelegate.m ! src/macosx/native/sun/awt/CClipboard.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CDesktopPeer.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! src/macosx/native/sun/awt/CImage.m ! src/macosx/native/sun/awt/CInputMethod.m ! src/macosx/native/sun/awt/CMenu.m ! src/macosx/native/sun/awt/CMenuComponent.m ! src/macosx/native/sun/awt/CMenuItem.m ! src/macosx/native/sun/awt/CPopupMenu.m ! src/macosx/native/sun/awt/CTrayIcon.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/JavaComponentAccessibility.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: 112c08b41ca2 Author: alitvinov Date: 2013-01-18 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/112c08b41ca2 8006417: JComboBox.showPopup(), hidePopup() fails in JRE 1.7 on OS X Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/javax/swing/JComboBox/ShowPopupAfterHidePopupTest/ShowPopupAfterHidePopupTest.java Changeset: b4131358120a Author: raginip Date: 2013-01-18 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b4131358120a 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! make/Makefile + make/bridge/AccessBridgeJava/Makefile + make/bridge/JAWTAccessBridge/Files_cpp.gmk + make/bridge/JAWTAccessBridge/Makefile + make/bridge/Jabswitch/Makefile + make/bridge/Jaccess/Makefile + make/bridge/JavaAccessBridge/Files_cpp.gmk + make/bridge/JavaAccessBridge/Makefile + make/bridge/Makefile + make/bridge/WindowsAccessBridge/Files_cpp.gmk + make/bridge/WindowsAccessBridge/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk Changeset: f55d869052dd Author: alexsch Date: 2013-01-21 17:55 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f55d869052dd 8004298: NPE in WindowsTreeUI.ensureRowsAreVisible Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java + test/javax/swing/JTree/8004298/bug8004298.java Changeset: dd7e1cc4253c Author: alexp Date: 2013-01-24 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dd7e1cc4253c 7147078: [macosx] Echo char set in TextField doesn't prevent word jumping Reviewed-by: art ! src/macosx/classes/com/apple/laf/AquaKeyBindings.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 04d2005fa178 Author: alexp Date: 2013-01-24 15:52 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/04d2005fa178 7132793: [macosx] setWheelScrollEnabled action reversed Reviewed-by: serb, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWScrollPanePeer.java Changeset: 40a45a72a120 Author: serb Date: 2013-01-24 15:55 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/40a45a72a120 8005997: [macosx] Printer Dialog opens an additional title bar Reviewed-by: anthony, art Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: fab11b21ee6e Author: kizune Date: 2013-01-24 16:09 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fab11b21ee6e 7143768: [macosx] Unexpected NullPointerException and java.io.IOException during DnD Reviewed-by: alexp ! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java Changeset: 7dd1896b37c8 Author: malenkov Date: 2013-01-24 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7dd1896b37c8 6817933: Setting the background of an HTML Widget changes the native Windows JFileChooser Reviewed-by: alexsch ! src/share/classes/sun/swing/WindowsPlacesBar.java + test/javax/swing/JFileChooser/6817933/Test6817933.java Changeset: f8526b99b825 Author: serb Date: 2013-01-24 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f8526b99b825 8003173: [macosx] Fullscreen on Mac leaves an empty rectangle Reviewed-by: anthony, alexsch ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java Changeset: 32721a1a8da8 Author: malenkov Date: 2013-01-24 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/32721a1a8da8 8005138: test/java/beans/Introspector/TestTypeResolver.java fails Reviewed-by: alexsch ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 7cda96a78260 Author: malenkov Date: 2013-01-24 18:06 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7cda96a78260 8003400: JTree scrolling problem when using large model in WindowsLookAndFeel Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003400/Test8003400.java Changeset: e616c28c5120 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e616c28c5120 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: a1a55db02f34 Author: lana Date: 2013-01-29 20:19 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a1a55db02f34 Merge ! makefiles/CreateJars.gmk Changeset: 9d5c43050210 Author: dl Date: 2013-01-11 16:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9d5c43050210 8006123: Support @Contended Annotation - JEP 142 (jdk part) Summary: jdk changes for 8003895. Reviewed-by: darcy, jrose, coleenp, dholmes, kvn Contributed-by: Aleksey Shipilev + src/share/classes/sun/misc/Contended.java Changeset: 739351a0a7a1 Author: kvn Date: 2013-01-23 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/739351a0a7a1 8006799: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() (jdk part of 6896617) Summary: Move hot loop in ISO_8859_1$Encode.encodeArrayLoop() into separate method encodeISOArray() to be replaced by JVM JIT compiler with optimized intrinsic code. Reviewed-by: alanb, sherman ! src/share/classes/sun/nio/cs/ISO_8859_1.java Changeset: e9d00d30fcca Author: amurillo Date: 2013-01-25 03:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e9d00d30fcca Merge Changeset: ac286bf65242 Author: amurillo Date: 2013-01-30 10:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac286bf65242 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java Changeset: 4a67fdb752b7 Author: katleman Date: 2013-01-30 13:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a67fdb752b7 Merge ! makefiles/CopyFiles.gmk From david.katleman at oracle.com Wed Jan 30 22:15:03 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 Jan 2013 22:15:03 +0000 Subject: hg: jdk8/build/langtools: 35 new changesets Message-ID: <20130130221631.7AA65476BF@hg.openjdk.java.net> Changeset: 54e4ba223319 Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/54e4ba223319 Added tag jdk8-b74 for changeset 56c97aff46bb ! .hgtags Changeset: fc4cb1577ad6 Author: jjg Date: 2013-01-10 19:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/fc4cb1577ad6 8004834: Add doclint support into javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! test/com/sun/javadoc/5093723/T5093723.java ! test/com/sun/javadoc/testBadSourceFile/TestBadSourceFile.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testReturnTag/TestReturnTag.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnBadParamNames/TestWarnBadParamNames.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/tools/javadoc/6958836/Test.java ! test/tools/javadoc/6964914/Test.java ! test/tools/javadoc/6964914/TestStdDoclet.java ! test/tools/javadoc/MaxWarns.java ! test/tools/javadoc/T6551367.java + test/tools/javadoc/doclint/DocLintTest.java Changeset: 9f42a06a49c0 Author: jfranck Date: 2013-01-14 19:52 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9f42a06a49c0 7193719: Support repeating annotations in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/javax/lang/model/element/Element.java Changeset: df694c775e8a Author: jjg Date: 2013-01-14 13:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/df694c775e8a 8006119: update javac to follow latest spec for repeatable annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/BasicRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/CheckTargets.java ! test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java ! test/tools/javac/annotations/repeatingAnnotations/ContainerHasRepeatedContained.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.out ! test/tools/javac/annotations/repeatingAnnotations/DefaultCasePresent.java ! test/tools/javac/annotations/repeatingAnnotations/DelayRepeatedContainer.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InvalidTarget.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.out - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.java ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.out ! test/tools/javac/annotations/repeatingAnnotations/MultiLevelRepeatableAnno.java ! test/tools/javac/annotations/repeatingAnnotations/MultipleAnnoMixedOrder.java ! test/tools/javac/annotations/repeatingAnnotations/NestedContainers.java ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out ! test/tools/javac/annotations/repeatingAnnotations/RepMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepSelfMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingAndContainerPresent.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/annotations/repeatingAnnotations/SelfRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/SingleRepeatingAndContainer.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java + test/tools/javac/annotations/repeatingAnnotations/UseWrongRepeatable.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.out ! test/tools/javac/annotations/repeatingAnnotations/combo/BasicSyntaxCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DeprecatedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DocumentedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/InheritedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/RetentionAnnoCombo.java ! test/tools/javac/diags/examples.not-yet.txt - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java ! test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java + test/tools/javac/diags/examples/RepeatableDocumentedMismatch.java + test/tools/javac/diags/examples/RepeatableInheritedMismatch.java + test/tools/javac/diags/examples/RepeatableNoValue.java + test/tools/javac/diags/examples/RepeatableNonDefault.java + test/tools/javac/diags/examples/RepeatableRetentionMismatch.java + test/tools/javac/diags/examples/RepeatableTargetMismatch.java + test/tools/javac/diags/examples/RepeatableWrongValueType.java ! test/tools/javac/diags/examples/RepeatingAnnotationAndContainer.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java Changeset: d54b4a091450 Author: jjg Date: 2013-01-14 14:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d54b4a091450 8006241: Test DocRootSlash.java fails Reviewed-by: darcy ! test/com/sun/javadoc/DocRootSlash/DocRootSlash.java Changeset: f805b5e3c9d1 Author: chegar Date: 2013-01-15 20:38 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f805b5e3c9d1 8006344: Broken javadoc link in javax.lang.model.element.Element Reviewed-by: lancea, alanb, jfranck ! src/share/classes/javax/lang/model/element/Element.java Changeset: bc1023e0e533 Author: jjg Date: 2013-01-15 13:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bc1023e0e533 8006224: Doclint NPE for attribute with no value Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/AnchorTest.java + test/tools/doclint/AnchorTest.out Changeset: f785dcac17b7 Author: mcimadamore Date: 2013-01-16 16:27 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f785dcac17b7 8005854: Add support for array constructor references Summary: Support constructor references of the kind int[]::new Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/lambda/MethodReference59.java + test/tools/javac/lambda/MethodReference60.java + test/tools/javac/lambda/MethodReference60.out Changeset: 7aa2025bbb7b Author: mcimadamore Date: 2013-01-16 16:30 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7aa2025bbb7b 8005299: Add FunctionalInterface checking to javac Summary: Javac should check that types annotated with @FunctionalInterface are indeed functional interfaces Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/BadFunctionalIntfAnno.java ! test/tools/javac/lambda/BadConv03.out ! test/tools/javac/lambda/BadLambdaPos.out ! test/tools/javac/lambda/BadTargetType.out + test/tools/javac/lambda/FunctionalInterfaceAnno.java + test/tools/javac/lambda/FunctionalInterfaceAnno.out ! test/tools/javac/lambda/Intersection01.out ! test/tools/javac/lambda/LambdaConv09.out ! test/tools/javac/lambda/LambdaExpr10.out ! test/tools/javac/lambda/MethodReference04.out ! test/tools/javac/lambda/TargetType17.out ! test/tools/javac/lambda/TargetType43.out ! test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM3.out ! test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.out ! test/tools/javac/lambda/lambdaExpression/InvalidExpression5.out Changeset: 1afdf1f1472b Author: mcimadamore Date: 2013-01-16 17:40 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1afdf1f1472b 8005964: Regression: difference in error recovery after ambiguity causes JCK test failure Summary: Wrong implementation of ResolveError.access in AmbiguityError Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 6b6311a8c9cc Author: jjg Date: 2013-01-16 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6b6311a8c9cc 8006236: doclint: structural issue hidden Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/EndTagsTest.java + test/tools/doclint/EndTagsTest.out Changeset: 63b20bde7cd6 Author: lana Date: 2013-01-16 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/63b20bde7cd6 Merge Changeset: 8b749558767b Author: darcy Date: 2013-01-16 13:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8b749558767b 8006283: Change to Class.cast() in javax.lang.model implementation for repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/JavacElements.java Changeset: 916143318f10 Author: jjg Date: 2013-01-16 20:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/916143318f10 8006228: Doclint doesn't detect {@code nested inline} Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/LiteralTest.java + test/tools/doclint/LiteralTest.out Changeset: 2d2b2be57c78 Author: mcimadamore Date: 2013-01-17 18:15 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/lambda/LambdaParserTest.java Changeset: 22e417cdddee Author: ohrstrom Date: 2013-01-18 00:16 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/22e417cdddee 8004658: Add internal smart javac wrapper to solve JEP 139 Reviewed-by: jjg ! make/build.properties ! make/build.xml + src/share/classes/com/sun/tools/sjavac/BuildState.java + src/share/classes/com/sun/tools/sjavac/CleanProperties.java + src/share/classes/com/sun/tools/sjavac/CompileChunk.java + src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java + src/share/classes/com/sun/tools/sjavac/CompileProperties.java + src/share/classes/com/sun/tools/sjavac/CopyFile.java + src/share/classes/com/sun/tools/sjavac/JavacState.java + src/share/classes/com/sun/tools/sjavac/Log.java + src/share/classes/com/sun/tools/sjavac/Main.java + src/share/classes/com/sun/tools/sjavac/Module.java + src/share/classes/com/sun/tools/sjavac/Package.java + src/share/classes/com/sun/tools/sjavac/ProblemException.java + src/share/classes/com/sun/tools/sjavac/Source.java + src/share/classes/com/sun/tools/sjavac/Transformer.java + src/share/classes/com/sun/tools/sjavac/Util.java + src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java + src/share/classes/com/sun/tools/sjavac/comp/JavaCompilerWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/PubapiVisitor.java + src/share/classes/com/sun/tools/sjavac/comp/ResolveWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileManager.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileObject.java + src/share/classes/com/sun/tools/sjavac/comp/SmartWriter.java + src/share/classes/com/sun/tools/sjavac/server/CompilerPool.java + src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java + src/share/classes/com/sun/tools/sjavac/server/JavacServer.java + src/share/classes/com/sun/tools/sjavac/server/PortFile.java + src/share/classes/com/sun/tools/sjavac/server/SysInfo.java + test/tools/sjavac/SJavac.java Changeset: 3d84ae209919 Author: mcimadamore Date: 2013-01-18 15:38 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg + test/tools/javac/diags/examples/UnderscoreAsIdentifier.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.out Changeset: 4a3cfc970c6f Author: jjg Date: 2013-01-21 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/4a3cfc970c6f 8006263: Supplementary test cases needed for doclint Reviewed-by: mcimadamore Contributed-by: peter.jensen at oracle.com ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Entity.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java + test/tools/doclint/CoverageExtras.java ! test/tools/doclint/DocLintTester.java + test/tools/doclint/html/EntitiesTest.java + test/tools/doclint/html/EntitiesTest.out + test/tools/doclint/tool/HelpTest.java + test/tools/doclint/tool/HelpTest.out + test/tools/doclint/tool/MaxDiagsTest.java + test/tools/doclint/tool/MaxDiagsTest.out + test/tools/doclint/tool/PathsTest.java + test/tools/doclint/tool/RunTest.java + test/tools/doclint/tool/StatsTest.java + test/tools/doclint/tool/StatsTest.out Changeset: 967052c425a1 Author: jjg Date: 2013-01-21 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/967052c425a1 8006251: doclint: incorrect position for diagnostic for illegal text in tags Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/html/BlockTagsTest.java + test/tools/doclint/html/InlineTagsTest.java + test/tools/doclint/html/ListTagsTest.java + test/tools/doclint/html/OtherTagsTest.java + test/tools/doclint/html/OtherTagsTest.out + test/tools/doclint/html/TableTagsTest.java + test/tools/doclint/html/TagNotAllowed.java + test/tools/doclint/html/TagNotAllowed.out + test/tools/doclint/html/TextNotAllowed.java + test/tools/doclint/html/TextNotAllowed.out ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/TextNotAllowed.out Changeset: b450959b42ff Author: lana Date: 2013-01-20 23:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b450959b42ff Merge Changeset: 1985e35e97b2 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1985e35e97b2 Merge Changeset: 7873d37f5b37 Author: mcimadamore Date: 2013-01-21 20:13 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7873d37f5b37 8005244: Implement overload resolution as per latest spec EDR Summary: Add support for stuck expressions and provisional applicability Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/Diagnostics/6722234/T6722234d_1.out ! test/tools/javac/Diagnostics/6722234/T6722234d_2.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java ! test/tools/javac/diags/examples/WhereIntersection.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg10.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/lambda/MethodReference25.java + test/tools/javac/lambda/MethodReference25.out ! test/tools/javac/lambda/MethodReference26.java - test/tools/javac/lambda/MethodReference26.out ! test/tools/javac/lambda/MethodReference43.java ! test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType01.out ! test/tools/javac/lambda/TargetType06.java - test/tools/javac/lambda/TargetType06.out ! test/tools/javac/lambda/TargetType10.out ! test/tools/javac/lambda/TargetType11.java - test/tools/javac/lambda/TargetType11.out ! test/tools/javac/lambda/TargetType14.out ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out ! test/tools/javac/lambda/TargetType26.out ! test/tools/javac/lambda/TargetType27.out ! test/tools/javac/lambda/TargetType28.out ! test/tools/javac/lambda/TargetType39.out ! test/tools/javac/lambda/TargetType45.java - test/tools/javac/lambda/TargetType45.out ! test/tools/javac/lambda/TargetType50.out + test/tools/javac/lambda/TargetType51.java + test/tools/javac/lambda/TargetType52.java + test/tools/javac/lambda/TargetType52.out ! test/tools/javac/lambda/VoidCompatibility.java - test/tools/javac/lambda/VoidCompatibility.out ! test/tools/javac/lambda/lambdaExpression/SamConversionComboTest.java ! test/tools/javac/lambda/methodReference/SamConversion.java ! test/tools/javac/lambda/methodReference/SamConversionComboTest.java ! test/tools/javac/lambda/typeInference/InferenceTest_neg5.out ! test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java Changeset: c7c41a044e7c Author: mcimadamore Date: 2013-01-21 20:14 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c7c41a044e7c 8006566: Remove transient lambda-related guards from JavacParser Summary: Remove transitional internal flag for allowing intersection types in cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/cast/intersection/IntersectionTypeParserTest.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java ! test/tools/javac/lambda/Intersection01.java ! test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java Changeset: b12ffdfa1341 Author: mcimadamore Date: 2013-01-21 20:15 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b12ffdfa1341 8005851: Remove support for synchronized interface methods Summary: Synchronized default methods are no longer supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: cf84b07a82db Author: mcimadamore Date: 2013-01-21 20:19 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/cf84b07a82db 8005166: Add support for static interface methods Summary: Support public static interface methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/defaultMethods/static/Static01.java + test/tools/javac/defaultMethods/static/Static02.java + test/tools/javac/defaultMethods/static/Static02.out + test/tools/javac/defaultMethods/static/hiding/InterfaceMethodHidingTest.java + test/tools/javac/defaultMethods/static/import/StaticImport1.java + test/tools/javac/defaultMethods/static/import/StaticImport2.java + test/tools/javac/defaultMethods/static/import/StaticImport2.out + test/tools/javac/defaultMethods/static/import/StaticImport3.java + test/tools/javac/defaultMethods/static/import/StaticImport3.out + test/tools/javac/defaultMethods/static/import/pkg/A.java + test/tools/javac/defaultMethods/static/import/pkg/B.java + test/tools/javac/defaultMethods/static/import/pkg/C.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/IllegalStaticIntfMethCall.java + test/tools/javac/diags/examples/StaticIntfMethodNotSupported.java Changeset: be443002e970 Author: mcimadamore Date: 2013-01-22 16:23 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/be443002e970 8006673: TargetType52 fails because of bad golden file Summary: Fix golden file in negative test Reviewed-by: jjg ! test/tools/javac/lambda/TargetType52.out Changeset: b61e5f801f7c Author: mcimadamore Date: 2013-01-22 16:39 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b61e5f801f7c 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack Summary: Lambda desugaring generates spurious references to 'this' in static contexts Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaExpr21.java Changeset: 8943b4213f59 Author: jjg Date: 2013-01-22 18:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8943b4213f59 8006723: sjavac test fails to compile on clean build Reviewed-by: ksrini ! test/tools/sjavac/SJavac.java + test/tools/sjavac/SJavacWrapper.java Changeset: f5b70712e0d5 Author: jjg Date: 2013-01-22 19:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f5b70712e0d5 8006728: temporarily workaround jtreg problems for doclint tests in othervm Reviewed-by: jjh + test/tools/doclint/html/AAA.java + test/tools/doclint/tidy/AAA.java + test/tools/doclint/tool/AAA.java Changeset: 385828dd5604 Author: jjg Date: 2013-01-22 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/385828dd5604 Merge Changeset: 97bd5e7151bc Author: mcimadamore Date: 2013-01-23 15:08 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8006692/T8006692.java Changeset: 5c956be64b9e Author: vromero Date: 2013-01-23 20:57 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! test/Makefile ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: 71f35e4b93a5 Author: jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mernst at cs.washington.edu, wmdietl at cs.washington.edu, mpapi at csail.mit.edu, mahmood at notnoop.com + src/share/classes/com/sun/javadoc/AnnotatedType.java ! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java ! src/share/classes/com/sun/javadoc/Type.java ! src/share/classes/com/sun/javadoc/TypeVariable.java + src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java + src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java + src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java + src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! src/share/classes/javax/lang/model/SourceVersion.java + src/share/classes/javax/lang/model/type/AnnotatedType.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/Types.java + test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java + test/com/sun/javadoc/testAnnotationOptional/pkg/AnnotationOptional.java + test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java + test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref ! test/tools/javac/T6873845.java + test/tools/javac/T6985181.java ! test/tools/javac/annotations/6881115/T6881115.java ! test/tools/javac/annotations/6881115/T6881115.out + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.java + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.out + test/tools/javac/annotations/typeAnnotations/InnerClass.java + test/tools/javac/annotations/typeAnnotations/MultipleTargets.java + test/tools/javac/annotations/typeAnnotations/TargetTypes.java + test/tools/javac/annotations/typeAnnotations/TypeParameterTarget.java + test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java + test/tools/javac/annotations/typeAnnotations/TypeUseTarget.java + test/tools/javac/annotations/typeAnnotations/api/AnnotatedArrayOrder.java + test/tools/javac/annotations/typeAnnotations/api/ArrayCreationTree.java + test/tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java + test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java + test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java + test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/NoTargetAnnotations.java + test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out + test/tools/javac/annotations/typeAnnotations/failures/BadCast.java + test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out + test/tools/javac/annotations/typeAnnotations/failures/LintCast.java + test/tools/javac/annotations/typeAnnotations/failures/LintCast.out + test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.out + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/TypeAndField.java + test/tools/javac/annotations/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.java + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.out + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.java + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.out + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.out + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.java + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.out + test/tools/javac/annotations/typeAnnotations/newlocations/BasicTest.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/ConstructorTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Expressions.java + test/tools/javac/annotations/typeAnnotations/newlocations/Fields.java + test/tools/javac/annotations/typeAnnotations/newlocations/LocalVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodReturnType.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/newlocations/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/newlocations/Parameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Receivers.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.out + test/tools/javac/annotations/typeAnnotations/newlocations/ResourceVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/Throws.java + test/tools/javac/annotations/typeAnnotations/newlocations/TopLevelBlocks.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Varargs.java + test/tools/javac/annotations/typeAnnotations/newlocations/Wildcards.java + test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/Anno.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/MyClass.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/package-info.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/FromSpecification.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReceivers.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReturns.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeTests.java ! test/tools/javac/api/EndPositions.java ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateStaticClass.java + test/tools/javac/diags/examples/IncorrectReceiverType.java + test/tools/javac/diags/examples/NoAnnotationsOnDotClass.java + test/tools/javac/diags/examples/ThisAsIdentifier.java + test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/processing/6994946/SemanticErrorTest.2.out ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.ref ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java + test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.ref ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/tree/TreePosTest.java + test/tools/javac/treeannotests/AnnoTreeTests.java ! test/tools/javac/treeannotests/TestProcessor.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out + test/tools/javap/typeAnnotations/JSR175Annotations.java + test/tools/javap/typeAnnotations/NewArray.java + test/tools/javap/typeAnnotations/Presence.java + test/tools/javap/typeAnnotations/PresenceInner.java + test/tools/javap/typeAnnotations/T6855990.java + test/tools/javap/typeAnnotations/TypeCasts.java + test/tools/javap/typeAnnotations/Visibility.java + test/tools/javap/typeAnnotations/Wildcards.java Changeset: 09f65aad4759 Author: darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/AnnotationValueVisitor.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java Changeset: c2e11e2ec4a3 Author: lana Date: 2013-01-26 19:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c2e11e2ec4a3 Merge - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java - test/tools/javac/lambda/MethodReference26.out - test/tools/javac/lambda/TargetType06.out - test/tools/javac/lambda/TargetType11.out - test/tools/javac/lambda/TargetType45.out - test/tools/javac/lambda/VoidCompatibility.out - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out From david.holmes at oracle.com Thu Jan 31 08:42:52 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 31 Jan 2013 18:42:52 +1000 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51095AEE.5020804@oracle.com> References: <51026031.7020200@oracle.com> <51065614.1090008@oracle.com> <51069AA2.3080007@oracle.com> <51095AEE.5020804@oracle.com> Message-ID: <510A2E8C.9040202@oracle.com> On 31/01/2013 3:39 AM, Tim Bell wrote: > Second round of this change: > > http://cr.openjdk.java.net/~tbell/8006933/01/ Ok. > In response to feedback raised on this thread: > > David wrote: > >> Do we fix the old build in the corba repo too? > > No, the old build does not generate accurate dependencies in this area, > so there is nothing similar to fix - the old corba build is all or nothing. You mean even though the corba Defs-utils.gmk defines NAWK as awk this isn't a problem because it doesn't actually get used? >> Can we also fix the fact that the failure doesn't cause make to detect >> the error? I think that is caused by the whole thing being executed in a >> sub-shell. > > I tried without success (many ways) to trap the error from the original > /usr/bin/awk. Given that we are using nawk after this change, I'd like > to move on. Ok. I did some experimenting too and am a bit perplexed as, as far as I can tell, the sub-shell exits with the return code from the last command. So I don't understand why make did not detect this error. :( Thanks, David > Dmitry wrote: > >> It might be better to remove AWK completely >> >> $(FIND) . -type f | sed 's!\./!$3 : $4/!g' > $5 > > Good idea, but I was not able to implement it because sed does not > support captures, and the expression suggested above would drop part of > the string. > > Let me give an example: > > If the output of the find is ./org/omg/CORBA/StringSeqHolder.java > > $3 is /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ > > $4 is > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > $(SED) 's!\./!$3 : $4/!g' would generate: > > /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ : > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > (losing the /org/omg/CORBA/StringSeqHolder.java substring) > > $(SED) 's!\./!$3/!g' | $(NAWK) '{ print $$$$1 ": $4" }' would generate > what we want: > > /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/org/omg/CORBA/StringSeqHolder.java: > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > > (and you can see why the length of the strings becomes a problem for the > old Solaris awk which predates the Posix standard) > > >> or ever >> >> find . -type f -printf "$3%s : $4\n" > > Another good suggestion, but not all versions of find support printf > (MacOS, and /usr/bin/find on Solaris). It would be possible to use > /usr/bin/gfind on Solaris, but I don't know of a solution on the Mac. > > > Tim > >> On 01/28/13 02:42, Erik Joelsson wrote: >>> The fix looks good to me. What strikes me most is the use of "sed" >>> instead of $(SED) on the same line. >>> >>> /Erik >>> >>> On 2013-01-25 11:36, Tim Bell wrote: >>>> Here is the bug report: >>>> http://bugs.sun.com/view_bug.do?bug_id=8006933 >>>> >>>> Use nawk instead of awk to avoid "awk: string too long near line 1" >>>> errors when running idlj in corba. For new 'build-infra' style >>>> builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk >>>> >>>> The errors are seen if the path to the build directory in the source >>>> tree is too long, greater than ~92. >>>> >>>> http://cr.openjdk.java.net/~tbell/8006933/00/ >>>> >>>> Thanks in advance for any feedback. >>>> >>>> Tim From erik.joelsson at oracle.com Thu Jan 31 10:09:48 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 31 Jan 2013 11:09:48 +0100 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51095AEE.5020804@oracle.com> References: <51026031.7020200@oracle.com> <51065614.1090008@oracle.com> <51069AA2.3080007@oracle.com> <51095AEE.5020804@oracle.com> Message-ID: <510A42EC.80909@oracle.com> This looks good, Tim. /Erik On 2013-01-30 18:39, Tim Bell wrote: > Second round of this change: > > http://cr.openjdk.java.net/~tbell/8006933/01/ > > In response to feedback raised on this thread: > > David wrote: > >> Do we fix the old build in the corba repo too? > > No, the old build does not generate accurate dependencies in this > area, so there is nothing similar to fix - the old corba build is all > or nothing. > >> Can we also fix the fact that the failure doesn't cause make to detect >> the error? I think that is caused by the whole thing being executed in a >> sub-shell. > > I tried without success (many ways) to trap the error from the > original /usr/bin/awk. Given that we are using nawk after this > change, I'd like to move on. > > Dmitry wrote: > >> It might be better to remove AWK completely >> >> $(FIND) . -type f | sed 's!\./!$3 : $4/!g' > $5 > > Good idea, but I was not able to implement it because sed does not > support captures, and the expression suggested above would drop part > of the string. > > Let me give an example: > > If the output of the find is ./org/omg/CORBA/StringSeqHolder.java > > $3 is /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ > > $4 is > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > $(SED) 's!\./!$3 : $4/!g' would generate: > > /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ : > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > (losing the /org/omg/CORBA/StringSeqHolder.java substring) > > $(SED) 's!\./!$3/!g' | $(NAWK) '{ print $$$$1 ": $4" }' would generate > what we want: > > /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/org/omg/CORBA/StringSeqHolder.java: > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > > (and you can see why the length of the strings becomes a problem for > the old Solaris awk which predates the Posix standard) > > >> or ever >> >> find . -type f -printf "$3%s : $4\n" > > Another good suggestion, but not all versions of find support printf > (MacOS, and /usr/bin/find on Solaris). It would be possible to use > /usr/bin/gfind on Solaris, but I don't know of a solution on the Mac. > > > Tim > >> On 01/28/13 02:42, Erik Joelsson wrote: >>> The fix looks good to me. What strikes me most is the use of "sed" >>> instead of $(SED) on the same line. >>> >>> /Erik >>> >>> On 2013-01-25 11:36, Tim Bell wrote: >>>> Here is the bug report: >>>> http://bugs.sun.com/view_bug.do?bug_id=8006933 >>>> >>>> Use nawk instead of awk to avoid "awk: string too long near line 1" >>>> errors when running idlj in corba. For new 'build-infra' style >>>> builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk >>>> >>>> The errors are seen if the path to the build directory in the >>>> source tree is too long, greater than ~92. >>>> >>>> http://cr.openjdk.java.net/~tbell/8006933/00/ >>>> >>>> Thanks in advance for any feedback. >>>> >>>> Tim From dmitry.samersoff at oracle.com Thu Jan 31 10:42:35 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 31 Jan 2013 14:42:35 +0400 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <51095AEE.5020804@oracle.com> References: <51026031.7020200@oracle.com> <51065614.1090008@oracle.com> <51069AA2.3080007@oracle.com> <51095AEE.5020804@oracle.com> Message-ID: <510A4A9B.70808@oracle.com> Looks good for me. -Dmitry On 2013-01-30 21:39, Tim Bell wrote: > Second round of this change: > > http://cr.openjdk.java.net/~tbell/8006933/01/ > > In response to feedback raised on this thread: > > David wrote: > >> Do we fix the old build in the corba repo too? > > No, the old build does not generate accurate dependencies in this area, > so there is nothing similar to fix - the old corba build is all or nothing. > >> Can we also fix the fact that the failure doesn't cause make to detect >> the error? I think that is caused by the whole thing being executed in a >> sub-shell. > > I tried without success (many ways) to trap the error from the original > /usr/bin/awk. Given that we are using nawk after this change, I'd like > to move on. > > Dmitry wrote: > >> It might be better to remove AWK completely >> >> $(FIND) . -type f | sed 's!\./!$3 : $4/!g' > $5 > > Good idea, but I was not able to implement it because sed does not > support captures, and the expression suggested above would drop part of > the string. > > Let me give an example: > > If the output of the find is ./org/omg/CORBA/StringSeqHolder.java > > $3 is /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ > > $4 is > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > $(SED) 's!\./!$3 : $4/!g' would generate: > > /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/ : > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > (losing the /org/omg/CORBA/StringSeqHolder.java substring) > > $(SED) 's!\./!$3/!g' | $(NAWK) '{ print $$$$1 ": $4" }' would generate > what we want: > > /tmp/jdk8/build/solaris-x86-normal-server-release/corba/gensrc/org/omg/CORBA/StringSeqHolder.java: > /tmp/jdk8/corba/src/share/classes/org/omg/PortableInterceptor/CORBAX.idl > > > (and you can see why the length of the strings becomes a problem for the > old Solaris awk which predates the Posix standard) > > >> or ever >> >> find . -type f -printf "$3%s : $4\n" > > Another good suggestion, but not all versions of find support printf > (MacOS, and /usr/bin/find on Solaris). It would be possible to use > /usr/bin/gfind on Solaris, but I don't know of a solution on the Mac. > > > Tim > >> On 01/28/13 02:42, Erik Joelsson wrote: >>> The fix looks good to me. What strikes me most is the use of "sed" >>> instead of $(SED) on the same line. >>> >>> /Erik >>> >>> On 2013-01-25 11:36, Tim Bell wrote: >>>> Here is the bug report: >>>> http://bugs.sun.com/view_bug.do?bug_id=8006933 >>>> >>>> Use nawk instead of awk to avoid "awk: string too long near line 1" >>>> errors when running idlj in corba. For new 'build-infra' style >>>> builds, this needs to be fixed in common/makefiles/IdlCompilation.gmk >>>> >>>> The errors are seen if the path to the build directory in the source >>>> tree is too long, greater than ~92. >>>> >>>> http://cr.openjdk.java.net/~tbell/8006933/00/ >>>> >>>> Thanks in advance for any feedback. >>>> >>>> Tim -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From Sergey.Bylokhov at oracle.com Thu Jan 31 14:12:08 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 31 Jan 2013 18:12:08 +0400 Subject: Build failure on windows In-Reply-To: References: <51080621.8060400@oracle.com> Message-ID: <510A7BB8.3040903@oracle.com> Hi, Kelly. You're partially right. The problem was in the permission of the generated files in the build directory. To fix it I run chmod - R 777 several times on the build directory after each build failure. Solution which helped me: http://stackoverflow.com/questions/5828037/cygwin-sets-file-permission-to-000 29.01.2013 21:35, Kelly O'Hair wrote: > On Windows, check your file and directory permissions. > > -kto > > On Jan 29, 2013, at 9:25 AM, Sergey Bylokhov wrote: > >> Hello. >> Does anybody know how to fix this error message? >> >> ## Starting jdk >> make[2]: Entering directory `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' >> make[3]: Entering directory `/cygdrive/c/moe/workspaces/jdk/8/awt-work/jdk/makefiles' >> Generating Nimbus source files >> Exception in thread "main" java.lang.NullPointerException >> at java.io.Reader.(Reader.java:78) >> at java.io.InputStreamReader.(InputStreamReader.java:72) >> at build.tools.generatenimbus.Generator$TemplateReader.(Generator. >> java:251) >> at build.tools.generatenimbus.Generator.writeSrcFileImpl(Generator.java: >> 224) >> at build.tools.generatenimbus.Generator.writeSrcFile(Generator.java:241) >> >> at build.tools.generatenimbus.PainterGenerator.writePainter(PainterGener >> ator.java:625) >> at build.tools.generatenimbus.UIRegion.write(UIRegion.java:174) >> at build.tools.generatenimbus.SynthModel.write(SynthModel.java:74) >> at build.tools.generatenimbus.Generator.generate(Generator.java:206) >> at build.tools.generatenimbus.Generator.main(Generator.java:112) >> >> New build system was used. Ws is from http://hg.openjdk.java.net/jdk8/awt >> This is clean build. >> Thanks. >> >> -- >> Best regards, Sergey. >> -- Best regards, Sergey. From tim.bell at oracle.com Thu Jan 31 21:54:26 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 31 Jan 2013 13:54:26 -0800 Subject: Review request: 8006933: Need to use nawk on Solaris to avoid awk limitations In-Reply-To: <510A2E8C.9040202@oracle.com> References: <51026031.7020200@oracle.com> <51065614.1090008@oracle.com> <51069AA2.3080007@oracle.com> <51095AEE.5020804@oracle.com> <510A2E8C.9040202@oracle.com> Message-ID: <510AE812.90305@oracle.com> On 01/31/13 00:42, David Holmes wrote: > You mean even though the corba Defs-utils.gmk defines NAWK as awk this > isn't a problem because it doesn't actually get used? Correct. It is set in corba/make/common/shared/Defs-utils.gmk but never used. This is probably an artifact of copying Defs-utils.gmk from the jdk repo. The only other place in corba using awk is in make/common/shared/Platform.gmk, and that section is BSD specific. Tim From tim.bell at oracle.com Thu Jan 31 23:45:02 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Thu, 31 Jan 2013 23:45:02 +0000 Subject: hg: jdk8/build: 8006933: Need to use nawk on Solaris to avoid awk limitations Message-ID: <20130131234502.6F22047715@hg.openjdk.java.net> Changeset: 6e296219633d Author: tbell Date: 2013-01-31 13:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/6e296219633d 8006933: Need to use nawk on Solaris to avoid awk limitations Reviewed-by: erikj, dholmes, dsamersoff ! common/makefiles/IdlCompilation.gmk From xueming.shen at oracle.com Tue Jan 22 23:08:07 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 22 Jan 2013 15:08:07 -0800 Subject: Codereview request for 8003680: JSR 310: Date/Time API In-Reply-To: <50FF198B.8060009@oracle.com> References: <50F5F08D.5000008@oracle.com> <50F9E2CE.9090500@oracle.com> <50FEE3F0.40906@oracle.com> <50FEEE03.4080701@oracle.com> <50FF1084.1070404@oracle.com> <50FF198B.8060009@oracle.com> Message-ID: <50FF1BD7.7090707@oracle.com> On 01/22/2013 02:58 PM, Alan Bateman wrote: > On 22/01/2013 22:19, David Holmes wrote: >> All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or desirable) to build into jdk/lib and then copy over. > Sherman can confirm, but I believe the TzdbZoneRulesProvider requires it in the lib directory so it would need to in jdk/lib when running/testing without in a non-images build. > > -Alan. tzdb.jar is special that it is a data file in jar format. It's not a jar for classes. It needs to be generated in jdk/lib (non-images build) for developing and testing. -Sherman