Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok

[David Holmes]

As it was pushed to build-infra I don't see any major problem. If there 
are changes needed due to review comments then push a follow up changeset.

David

On 2/01/2013 8:58 PM, Erik Joelsson wrote:
> I accidentally hit hg push in the wrong shell window and pushed this
> prematurely. What should I do now?
>
> /Erik
>
> On 2013-01-02 10:50, Erik Joelsson wrote:
>> I should have checked myself, but it was late. Here is a new webrev
>> with all copyright years updated.
>>
>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.04/
>>
>> /Erik
>>
>> On 2013-01-02 01:56, David Holmes wrote:
>>> Sorry Erik I misunderstood the change that had been made. I thought
>>> common/autoconf/version-numbers was replacing
>>> common/autoconf/closed.version.numbers but it wasn't - that was the
>>> original copyright I was looking at.
>>>
>>> That means the correct copyright here would now be:
>>>
>>> Copyright (c) 2011, 2013,
>>>
>>> Sorry for the confusion.
>>>
>>> David
>>>
>>>
>>> On 2/01/2013 9:47 AM, Erik Joelsson wrote:
>>>> Fixed the copyright header of that file.
>>>>
>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.03/
>>>>
>>>> /Erik
>>>>
>>>> On 2013-01-01 23:58, David Holmes wrote:
>>>>> Not sure of how all the bits click together between open and closed
>>>>> but on the surface this looks okay.
>>>>>
>>>>> One nit. The old version number file had a copyright
>>>>>
>>>>> Copyright (c) 2012,
>>>>>
>>>>> yet somehow the new one became
>>>>>
>>>>> Copyright (c) 2011, 2012,
>>>>>
>>>>> ??
>>>>>
>>>>> Really I think it should now be:
>>>>>
>>>>> Copyright (c) 2012, 2013,
>>>>>
>>>>> Cheers,
>>>>> David
>>>>> -----
>>>>>
>>>>> On 2/01/2013 12:39 AM, Erik Joelsson wrote:
>>>>>> New webrev. I decided that David was right, it really should be in
>>>>>> closed so I moved it there, along with the closed version numbers
>>>>>> file
>>>>>> and the reading of it. These files are also changing names
>>>>>> slightly to
>>>>>> avoid the .numbers extension which is just weird.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.02/
>>>>>>
>>>>>> /Erik
>>>>>>
>>>>>> On 2012-12-31 11:01, Erik Joelsson wrote:
>>>>>>> No, they are not. I hesitated as to if I should move it all to
>>>>>>> closed,
>>>>>>> but opted not to at this point, to save time more than anything.
>>>>>>> Ok if
>>>>>>> I open a bug on moving it to fix it later?
>>>>>>>
>>>>>>> /Erik
>>>>>>>
>>>>>>> On 2012-12-30 23:45, David Holmes wrote:
>>>>>>>> Erik,
>>>>>>>>
>>>>>>>> On 30/12/2012 11:51 PM, Erik Joelsson wrote:
>>>>>>>>> Open part of this review. Configure needs to supply a couple of
>>>>>>>>> more
>>>>>>>>> utilities and version string variations.
>>>>>>>>>
>>>>>>>>> http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/
>>>>>>>>
>>>>>>>> Those new variables do not seem relevant to openjdk builds. Is
>>>>>>>> any of
>>>>>>>> this "gnumake source" relevant to openjdk builds ??
>>>>>>>>
>>>>>>>> David
>>>>>>>>
>>>>>>>>> /Erik