Review Request: 8005635: build-infra: Support building install in jprt

[Erik Joelsson]

I'm trying to understand if it is a dynamically defined set of images or 
if in practice it's really static. Will later parts of the build 
(install) need to enumerate over this set of image directories too? I 
don't really need to define the directories in spec, I just want to keep 
the definition to one place, reachable by all who needs it.

/Erik

On 2013-01-03 13:22, Erik Joelsson wrote:
> What I tried to achieve was to define them in one place. It seemed to 
> me that a lot of places needed to know where they were otherwise.
>
> /Erik
>
> On 2013-01-03 12:59, David Holmes wrote:
>> spec.gmk.in:
>>
>> Not sure about this one. Why do the image directories need to be 
>> configure time variables placed in spec.gmk? For profiles I 
>> dynamically change JRE_IMAGE_DIR based on the profile being built. I 
>> don't think this change breaks that because I set it as a make 
>> variable on the submake invocation. But the fact that you need to do 
>> this indicates there is something that may conflict with what I am 
>> doing.
>>
>> David
>> -----
>>
>> On 3/01/2013 9:36 PM, Erik Joelsson wrote:
>>> One more variable being converted for jprt.
>>>
>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.03/
>>>
>>> /Erik
>>>
>>> On 2013-01-02 19:34, Erik Joelsson wrote:
>>>> Missed the changes to common/makefiles/Jprt.gmk. New webrev:
>>>>
>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.02/
>>>>
>>>> /Erik
>>>>
>>>> On 2013-01-02 17:14, Erik Joelsson wrote:
>>>>> This is the open part of this review. The changes are mostly
>>>>> concerning compare logic and introducing a couple of new variables in
>>>>> spec for images directories.
>>>>>
>>>>> Contributed by Tim Bell and myself.
>>>>>
>>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.root.01/
>>>>> http://cr.openjdk.java.net/~erikj/8005635/webrev.jdk.01/
>>>>>
>>>>> /Erik