Review Request: 8005856: build-infra: Remove special handling of base module classes header generation

Tim Bell tim.bell at oracle.com
Tue Jan 8 19:07:56 UTC 2013


On 01/08/13 06:17, Alan Bateman wrote:
> On 08/01/2013 14:07, Erik Joelsson wrote:
>> Five classes which in jigsaw will be located in the base module 
>> currently have their native headers generated in a special way 
>> (explicitly with javah). This was because the base module could not 
>> be made dependent on the compiler module where the annotation 
>> javax.tools.annotation.GenerateNativeHeader is. Now there is a new 
>> annotation on fields, java.lang.annotation.Native, that can be used 
>> for these classes.
>>
>> Since this change touches java files, I'm adding core-libs to the 
>> review.
>>
>> Original change in build-infra was made by Fredrik Ohrstrom.
>>
>> http://cr.openjdk.java.net/~erikj/8005856/webrev.jdk.01/
>>
>> /Erik
> This looks good to me.
>
> -Alan

Looks good to me as well.

Tim





More information about the build-dev mailing list