--enable-sjavac not enabled in tl repo yet?

[Fredrik Öhrström]

18 jan 2013 kl. 03:07 skrev Weijun Wang:

> Just tried on a latest jdk8/tl clone and
> The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac 


Ok, as the old saying goes, this works for me.... :-) So could you please tar up your build directory and email it to me?

As for the error message, since the build system has to handle building with javac as well as with sjavac, the logic for finding which java
files to compile, is implemented both in make and in java (sjavac). Sjavac has the option:
--compare-found-sources file_with_list_of_files
which is used to make sjavac compare its own calculated list of source files with the list supplied by make.
If they differ, you will get the error message
> was not calculated by the smart javac 


So why do we need to calculate the files to be compiled? Is it not just
compiling the required source roots? For example like this?

sjavac src/share/classes src/posix/classes src/linux/classes -d bin

Lets say, that we have an opportunity to organize the source in this way.
At the moment for example, when build the OpenJDK the snmp classes have to be excluded,
thus the compile command looks more like:
sjavac -x sun.management.snmp.* src/share/classes -d bin

(In make the same calculation is handled by find and grep and sed et al.)

The full filtering rules for compiling the main jdk looks like this:

sjavac -x com.sun.pept.* -x com.sun.tools.example.trace.* -x com.sun.tools.example.debug.bdi.* -x com.sun.tools.example.debug.event.* -x com.sun.tools.example.debug.gui.* -x sun.dc.* -x com.sun.jmx.snmp.* -x sun.management.snmp.* -x com.sun.script.* -x com.oracle.security.* -x sun.java2d.cmm.kcms.*  -xf *SolarisAclFileAttributeView.java -xf *SolarisFileStore.java -xf *SolarisFileSystem.java -xf *SolarisFileSystemProvider.java -xf *SolarisNativeDispatcher.java -xf *SolarisUserDefinedFileAttributeView.java -xf *SolarisWatchService.java -xf *SolarisAclFileAttributeView.java -xf *SolarisLoginModule.java -xf *SolarisSystem.java -xf *sun/nio/ch/DevPollArrayWrapper.java -xf *sun/nio/ch/DevPollSelectorImpl.java -xf *sun/nio/ch/DevPollSelectorProvider.java -xf *sun/nio/ch/EventPortSelectorImpl.java -xf *sun/nio/ch/EventPortSelectorProvider.java -xf *sun/nio/ch/EventPortWrapper.java -xf *sun/nio/ch/SolarisAsynchronousChannelProvider.java -xf *sun/nio/ch/SolarisEventPort.java -xf *sun/tools/attach/SolarisAttachProvider.java -xf *sun/tools/attach/SolarisVirtualMachine.java -xf *WrapperGenerator.java -xf *NTLoginModule.java -xf *NTSystem.java -xf *sun/nio/ch/BsdAsynchronousChannelProvider.java -xf *sun/nio/ch/KQueue.java -xf *sun/nio/ch/KQueuePort.java -xf *sun/nio/fs/BsdFileStore.java -xf *sun/nio/fs/BsdFileSystem.java -xf *sun/nio/fs/BsdFileSystemProvider.java -xf *sun/nio/fs/BsdNativeDispatcher.java -xf *sun/nio/fs/MacOSXFileSystemProvider.java -xf *sun/nio/fs/MacOSXFileSystem.java -xf *sun/nio/fs/MacOSXNativeDispatcher.java -xf *sun/tools/attach/BsdAttachProvider.java -xf *sun/tools/attach/BsdVirtualMachine.java -xf *sun/text/resources/BreakIteratorRules.java -xf *sun/text/resources/BreakIteratorRules_th.java -xf *sun/awt/AWTCharset.java -xf *sun/awt/X11/ScreenFormat.java -xf *sun/awt/X11/XArc.java -xf *sun/awt/X11/XChar2b.java -xf *sun/awt/X11/XCharStruct.java -xf *sun/awt/X11/XClassHint.java -xf *sun/awt/X11/XComposeStatus.java -xf *sun/awt/X11/XExtCodes.java -xf *sun/awt/X11/XFontProp.java -xf *sun/awt/X11/XFontSetExtents.java -xf *sun/awt/X11/XFontStruct.java -xf *sun/awt/X11/XGCValues.java -xf *sun/awt/X11/XHostAddress.java -xf *sun/awt/X11/XIMCallback.java -xf *sun/awt/X11/XIMHotKeyTrigger.java -xf *sun/awt/X11/XIMHotKeyTriggers.java -xf *sun/awt/X11/XIMPreeditCaretCallbackStruct.java -xf *sun/awt/X11/XIMPreeditDrawCallbackStruct.java -xf *sun/awt/X11/XIMPreeditStateNotifyCallbackStruct.java -xf *sun/awt/X11/XIMStatusDrawCallbackStruct.java -xf *sun/awt/X11/XIMStringConversionCallbackStruct.java -xf *sun/awt/X11/XIMStringConversionText.java -xf *sun/awt/X11/XIMStyles.java -xf *sun/awt/X11/XIMText.java -xf *sun/awt/X11/XIMValuesList.java -xf *sun/awt/X11/XImage.java -xf *sun/awt/X11/XKeyboardControl.java -xf *sun/awt/X11/XKeyboardState.java -xf *sun/awt/X11/XOMCharSetList.java -xf *sun/awt/X11/XOMFontInfo.java -xf *sun/awt/X11/XOMOrientation.java -xf *sun/awt/X11/XPoint.java -xf *sun/awt/X11/XRectangle.java -xf *sun/awt/X11/XSegment.java -xf *sun/awt/X11/XStandardColormap.java -xf *sun/awt/X11/XTextItem.java -xf *sun/awt/X11/XTextItem16.java -xf *sun/awt/X11/XTextProperty.java -xf *sun/awt/X11/XTimeCoord.java -xf *sun/awt/X11/XWindowChanges.java -xf *sun/awt/X11/XdbeSwapInfo.java -xf *sun/awt/X11/XmbTextItem.java -xf *sun/awt/X11/XwcTextItem.java -xf *sun/util/locale/AsciiUtil.java -xf *sun/nio/fs/PollingWatchService.java -xf *-linux-arm.java -xf *-linux-ppc.java -xf *javax/swing/plaf/nimbus/InternalFrameTitlePanePainter.java -xf *javax/swing/plaf/nimbus/OptionPaneMessageAreaPainter.java -xf *javax/swing/plaf/nimbus/ScrollBarPainter.java -xf *javax/swing/plaf/nimbus/SliderPainter.java -xf *javax/swing/plaf/nimbus/SpinnerPainter.java -xf *javax/swing/plaf/nimbus/SplitPanePainter.java -xf *javax/swing/plaf/nimbus/TabbedPanePainter.java  -src "/home/fohrstro/jdk8/jdk/src/share/classes:/home/fohrstro/jdk8/jdk/src/solaris/classes:/home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc:/home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip" 
-bootclasspath /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/classes 
-source 8 -target 8 -encoding ascii -XDignore.symbol.file=true -Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally   
-h /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/gensrc_headers 
-d /home/fohrstro/jdk8/build/linux-x86_64-normal-server-release/jdk/classes