Codereview request for 8003680: JSR 310: Date/Time API

Erik Joelsson erik.joelsson at oracle.com
Wed Jan 23 09:43:41 UTC 2013


On 2013-01-23 01:14, David Holmes wrote:
> On 23/01/2013 9:08 AM, Xueming Shen wrote:
>> On 01/22/2013 02:58 PM, Alan Bateman wrote:
>>> On 22/01/2013 22:19, David Holmes wrote:
>>>> All of the jar building was modified so that jars go into images/lib
>>>> not jdk/lib. So it should not be necessary (or desirable) to build
>>>> into jdk/lib and then copy over.
>>> Sherman can confirm, but I believe the TzdbZoneRulesProvider requires
>>> it in the lib directory so it would need to in jdk/lib when
>>> running/testing without in a non-images build.
>>>
>>> -Alan.
>>
>> tzdb.jar is special that it is a data file in jar format. It's not a jar
>> for classes.
>> It needs to be generated in jdk/lib (non-images build) for developing 
>> and
>> testing.
>
> Okay - sounds reasonable then.
>
David is indeed correct with how we would like to have it. But I can 
understand the exception explained by Alan, so I think this is ok and 
the correct way of doing it.

/Erik




More information about the build-dev mailing list