Review Makefile Changes For JDK-8001334 - Remove use of JVM_* functions from java.io code
Martin Buchholz
martinrb at google.com
Thu Jan 24 00:23:28 UTC 2013
On Wed, Jan 23, 2013 at 2:20 PM, Dan Xu <dan.xu at oracle.com> wrote:
> Hi,
>
> I have a fix for JDK-8001334 to remove JVM_* functions and replace with
> direct system calls. It introduces newmake filechangesin IO area especially
> on Windows platform. Please help review and approve them.
>
> Bug: https://jbs.oracle.com/bugs/**browse/JDK-8001334<https://jbs.oracle.com/bugs/browse/JDK-8001334>
jbs seems to be down
>
> webrev: http://cr.openjdk.java.net/~**dxu/8001334/webrev.00/<http://cr.openjdk.java.net/~dxu/8001334/webrev.00/><
> http://cr.openjdk.java.net/%**7Edxu/8001334/webrev.00/<http://cr.openjdk.java.net/%7Edxu/8001334/webrev.00/>
> >
>
There seems to be little to no documentation on these various internal
functions. E.g. How are read, IO_Read, and JVM_Read supposed to differ?
Where's the interface doc?
Many years ago I filed
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4904617
that remains unaddressed :-(
Perhaps as part of this change or set of changes, that bug could be dealt
with?
Perhaps even by deleting JVM_Read?
More information about the build-dev
mailing list