From erik.joelsson at oracle.com Mon Jul 1 09:36:42 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 01 Jul 2013 11:36:42 +0200 Subject: RFR: 8009744: build-infra: REGRESSION: Publisher was NOT set for some JDK files Message-ID: <51D14DAA.4010007@oracle.com> Please review this patch which moves the expansion of version variables for RC_FLAGS from configure to spec.gmk. This makes it possible to override these variables with custom values for OracleJDK. http://cr.openjdk.java.net/~erikj/8009744/webrev.root.01/ /Erik From tim.bell at oracle.com Mon Jul 1 11:27:18 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 01 Jul 2013 04:27:18 -0700 Subject: RFR: 8009744: build-infra: REGRESSION: Publisher was NOT set for some JDK files In-Reply-To: <51D14DAA.4010007@oracle.com> References: <51D14DAA.4010007@oracle.com> Message-ID: <51D16796.9090905@oracle.com> Erik: > Please review this patch which moves the expansion of version > variables for RC_FLAGS from configure to spec.gmk. This makes it > possible to override these variables with custom values for OracleJDK. > > http://cr.openjdk.java.net/~erikj/8009744/webrev.root.01 Looks good to me. Thanks- Tim From erik.joelsson at oracle.com Mon Jul 1 16:31:39 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Mon, 01 Jul 2013 16:31:39 +0000 Subject: hg: jdk8/build: 8009744: build-infra: REGRESSION: Publisher was NOT set for some JDK files Message-ID: <20130701163139.AAB1C486CE@hg.openjdk.java.net> Changeset: dd3b314f4471 Author: erikj Date: 2013-07-01 15:40 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/dd3b314f4471 8009744: build-infra: REGRESSION: Publisher was NOT set for some JDK files Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 From tao.mao at oracle.com Mon Jul 1 20:18:08 2013 From: tao.mao at oracle.com (Tao Mao) Date: Mon, 01 Jul 2013 13:18:08 -0700 Subject: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit Message-ID: <51D1E400.6020100@oracle.com> The hsx25 fix has been pushed already. Then I got the 7u40-critical-approved. When I tried backporting to hsx24, it didn't apply to the hsx24 repo cleanly. Thus, I made the patch manually (copy-and-paste style) and now need some quick reviews to get it in since it's 7u40 related P3 CR. hsx24 webrev: http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ (original) hsx25 webrev: http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ Thanks. Tao From vladimir.kozlov at oracle.com Tue Jul 2 03:48:37 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Mon, 01 Jul 2013 20:48:37 -0700 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> Message-ID: <51D24D95.7050207@oracle.com> Need help from JDK build experts. I applied next 2 changesets: http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ and got JPRT build problems (-control build) only on MacOS and Win64: http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ ------------------------------------------------------------------------------ macosx_x64_10.7-product (details from log file) ... Warning: The generated configure file contains changes not present in the custom generated file. Running autogen.sh to correct the situation Autoconf found: /usr/bin/autoconf Autoconf-2.67 found: Generating generated-configure.sh with /usr/bin/autoconf /usr/bin/gm4:stdin:187: bad expression in eval: 32 > autom4te: /usr/bin/gm4 failed with exit status: 1 Generating custom generated-configure.sh /usr/bin/gm4:stdin:187: bad expression in eval: 32 > autom4te: /usr/bin/gm4 failed with exit status: 1 ------------------------------------------------------------------------------ windows_x64_5.2-fastdebug (details from log file) ... Warning: The generated configure file contains changes not present in the custom generated file. Error: Cannot continue Cannot locate autoconf, unable to correct situation. Please install autoconf and run 'bash autogen.sh' to update the generated files. make: *** [bridge2configure] Error 1 ------------------------------------------------------------------------------ Without these changes the output is: Running custom generated-configure.sh configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. configure: configure script generated at timestamp 1371547939. Thanks, Vladimir On 6/28/13 12:04 AM, Volker Simonis wrote: > Ok, that's fine. > > Could you please let me know when you've verified these changes. I > will then push them to the staging repository. > > > Regards, > Volker > > > On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov > wrote: >> On 6/27/13 10:16 AM, Iris Clark wrote: >>> >>> Hi, Volker. >>> >>> I think that the right thing for this change [1] is for you to push into >>> ppc-aix-port/stage once you get the necessary reviews (presumably Erik and >>> possibly Alan). While your changeset contains some general purpose updates, >>> it also contains PPC/AIX-specific files which can't be added to a JDK >>> release repository until stage is pushed into the a JDK release. >>> >>> The recommendation to push to stage of course assumes that Vladimir >>> doesn't think that this will adversely affect the Hotspot work already being >>> pushed to stage. >> >> >> This should not affect Hotspot in stage repo. Me or Albert will do JPRT >> bootstrap control build of jdk with this changes to make sure it works. >> After that Volker can push it into stage. >> >> When I talked about pushing *general* changes into main sources I meant >> changes with no ppc64 specific code. The example of such changes was recent >> Goetz's fix for '8017531: 8010460 changes broke bytecodeInterpreter.cpp'. >> >> Thanks, >> Vladimir >> >> >>> >>> Thanks, >>> iris >>> >>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>> >>> -----Original Message----- >>> From: Volker Simonis [mailto:volker.simonis at gmail.com] >>> Sent: Thursday, June 27, 2013 9:23 AM >>> To: Erik Joelsson >>> Cc: Kumar Srinivasan; build-dev; ppc-aix-port-dev at openjdk.java.net; Alan >>> Bateman >>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) >>> >>> Hi Erik, >>> >>> we have no polices which are carved in stone:) It's all done informally >>> and by common sense. >>> >>> The main reason for the ppc-aix-port/stage repository is to have a sandbox >>> for in-depth review and testing of changes we had to make in shared code >>> before pushing them to the main repository (and this especially applies to >>> hotspot changes). If you feel comfortable with the current changes and don't >>> think that they will break anything (e.g. by running tests build on your >>> supported platforms including the closed source ones) I'd really appreciate >>> if you could push them to the build repository. >>> >>> Otherwise I'll push them to the staging repository and you'll get them >>> once we're finished with the integration of the port. >>> >>> Thank you and best regards, >>> Volker >>> >>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson >>> wrote: >>>> >>>> >>>> >>>> On 2013-06-27 13:00, Volker Simonis wrote: >>>> >>>> >>>> >>>> >>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson >>>> >>>> wrote: >>>>> >>>>> >>>>> Hello Volker, >>>>> >>>>> I wasn't aware of this project until now. From what I (now) >>>>> understand, generic patches can go into jdk8 repos, but port specific >>>>> things need to go to staging and go in with the rest later. These >>>>> changes contain a couple of port specific things so as it looks now >>>>> they would need to go through staging. >>>>> >>>> >>>> Yes, that's the general approach. But I'd argue that for the most part >>>> this changes are generic (enable CPP-interpreter, enable CORE build, >>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix typos) >>>> with only very few PPC64 specific parts (map-files and a few defines). >>>> The problem we want to avoid is that some of our fixes go into the >>>> main repositories in parallel which would result in merging pain when >>>> integrating the staging into the main repository. >>>> >>>> So if you think you don't need any of the general fixes any time soon, >>>> I'll push the changes into the staging repository. Otherwise I think >>>> it would be better to push them right into the main repositories. >>>> >>>> Several of the general fixes in there are good and I don't want to >>>> hinder those getting in. I also don't want to break policies I'm not >>>> familiar with. >>>> >>>> /Erik >>>> >>>> Thanks, >>>> Volker >>>> >>>>> >>>>> /Erik >>>>> >>>>> >>>>> On 2013-06-27 12:03, Volker Simonis wrote: >>>>> >>>>> Hi Erik, >>>>> >>>>> as Vladimir explained, we have a special staging repository for our >>>>> PPC64/AIX port: >>>>> >>>>> I would be happy if you could push the changes right into the >>>>> build-infra repositories and we will then get them into our staging >>>>> repository via jdk8/jdk8. >>>>> >>>>> Otherwise I'll have to push them to our staging repository and later >>>>> when the whole port is completed in the staging repo they will be >>>>> bulk-integrated into jdk8. >>>>> >>>>> What do you think? >>>>> >>>>> Regards, >>>>> Volker >>>>> >>>>> >>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov >>>>> wrote: >>>>>> >>>>>> >>>>>> Erik, >>>>>> >>>>>> We have special staging forest for PPC64/AIX port: >>>>>> >>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage >>>>>> >>>>>> We collect Hotspot and JDK changes there for testing before pushing >>>>>> into main sources in a future. But some general fixes we push >>>>>> directly into our main sources. >>>>>> If you think these build changes are acceptable for main, please, >>>>>> ask someone sponsor these changes. >>>>>> >>>>>> Alan is our official contact for PPC64/AIX project. I CC him. >>>>>> >>>>>> Thanks, >>>>>> Vladimir >>>>>> >>>>>> >>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: >>>>>>> >>>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> If you by staging area mean the build-infra forest, that's more or >>>>>>> less dead now. >>>>>>> >>>>>>> I think these changes look good now (both top level and jdk). It >>>>>>> should be fine to push this to jdk8/build. >>>>>>> >>>>>>> /Erik >>>>>>> >>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: >>>>>>>> >>>>>>>> >>>>>>>> Hi Erik, >>>>>>>> >>>>>>>> thank you for looking at this. I've prepared a new webrev at: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> What do you think, do you want to push this directly into the >>>>>>>> build repositories or should I push it into the staging repository >>>>>>>> first? >>>>>>>> >>>>>>>> Please see my further comments inline. >>>>>>>> >>>>>>>> Thank you and best regards, >>>>>>>> Volker >>>>>>>> >>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson >>>>>>>> > wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: >>>>>>>> >>>>>>>> Hello Volker, >>>>>>>> >>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: >>>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> could somebody please review the following change and >>>>>>>> create an appropriate >>>>>>>> Bug ID for it: >>>>>>>> >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ >>>>>>>> >>>>>>>> >>>>>>> /> >>>>>>>> >>>>>>>> >>>>>>>> The patch contains two little changes which are required >>>>>>>> to build the class >>>>>>>> library part of the OpenJDK on Linux/PPC64. Most of the >>>>>>>> build magic is >>>>>>>> contained in the top-level part of this change which is >>>>>>>> separately reviewed >>>>>>>> at >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> CompileLaunchers.gmk >>>>>>>> >>>>>>>> Remove mapfile from build instructions of >>>>>>>> BUILD_UNPACKEXE: >>>>>>>> >>>>>>>> CFLAGS_macosx:=-fPIC, \ >>>>>>>> - >>>>>>>> >>>>>>>> >>>>>>>> MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ >>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ >>>>>>>> >>>>>>>> I think it makes no sense to use a version script file >>>>>>>> for an executable >>>>>>>> and older linkers (e.g. on SLES 10) complain with: >>>>>>>> "*Invalid version tag >>>>>>>> `SUNWprivate_1.1'. Only anonymous version tag is allowed >>>>>>>> in executable.*" >>>>>>>> The GNU ld >>>>>>>> >>>>>>>> >>>>>>>> manualstates: >>>>>>>> "*Version scripts are only meaningful when creating >>>>>>>> shared >>>>>>>> libraries.*" >>>>>>>> Morover unpack200 was the only executable which used a >>>>>>>> version script file. >>>>>>>> >>>>>>>> Unpackexe has some weirdness and this isn't surprising me. >>>>>>>> Would be good if someone with more historic knowledge could >>>>>>>> fill in on the reason for this. Someone apparently went >>>>>>>> through the trouble of creating a special mapfile for this >>>>>>>> executable. Also, if not using it, should it be removed? >>>>>>>> >>>>>>>> I looked closer at this. These mapfiles were explicitly added in >>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it was noted >>>>>>>> that it broke builds for architectures that didn't have mapfiles >>>>>>>> defined. If you look at the launchers, the mapfile is only set >>>>>>>> if >>>>>>>> the arch specific one exists. I think a safer change here would >>>>>>>> be >>>>>>>> to make the mapfile conditional on platform or arch for >>>>>>>> unpackexe. >>>>>>>> >>>>>>>> >>>>>>>> I still do not fully understand why we need map-files for >>>>>>>> executables, but I also understand that you don't want to change the >>>>>>>> current setup. >>>>>>>> So I went the hard (and hopefully right:) way and implemented a >>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on SLES >>>>>>>> 10) which complain with: "Invalid version tag `SUNWprivate_1.1' >>>>>>>> during the configure step (see top-level change). Unfortunately we >>>>>>>> still have quite a lot of these systems so we really need the >>>>>>>> build with that buggy ld. >>>>>>>> >>>>>>>> I've therefore added map files with anonymous version tags for >>>>>>>> these buggy linkers which are only used if the buggy linker was >>>>>>>> detected during the configure step (i.e. if >>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 specific >>>>>>>> problem but a occurs on all SuSE 10 platforms. >>>>>>>> >>>>>>>> And you've been right. I also had to add the arch specific map >>>>>>>> files for ppc64 in order to use them for the other launchers. >>>>>>>> >>>>>>>> Kumar, you made the change referred to here, do you have >>>>>>>> anything >>>>>>>> to add? >>>>>>>> >>>>>>>> /Erik >>>>>>>> >>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>> >>>>>>>> default: all >>>>>>>> >>>>>>>> CompileNativeLibraries.gmk >>>>>>>> >>>>>>>> Only use $(OPENWIN_LIB) for linking LIBSPLASHSCREEN on >>>>>>>> Solaris! The old >>>>>>>> code worked only accidentally when the X-libraries are >>>>>>>> in >>>>>>>> the default >>>>>>>> linker path anyway. The right solution is to use >>>>>>>> $(X_LIBS) >>>>>>>> if not on >>>>>>>> Windows or Solaris. >>>>>>>> >>>>>>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on PPC64. >>>>>>>> The value of >>>>>>>> X_ARCHisn't actually used on the PPC architectures, but >>>>>>>> there's a >>>>>>>> check to verify >>>>>>>> that it is set. >>>>>>>> >>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>> >>>>>>>> default: all >>>>>>>> >>>>>>>> >>>>>>>> Otherwise looks good. >>>>>>>> >>>>>>>> /Erik >>>>>>>> >>>>>>>> >>>>> >>>> >> From tao.mao at oracle.com Tue Jul 2 06:05:46 2013 From: tao.mao at oracle.com (Tao Mao) Date: Mon, 01 Jul 2013 23:05:46 -0700 Subject: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit In-Reply-To: <51D1E400.6020100@oracle.com> References: <51D1E400.6020100@oracle.com> Message-ID: <51D26DBA.8010309@oracle.com> The format of passing cxxflag to a specific file is different in hsx24 than in hsx25. I've changed the setting accordingly in order to pass through the compilation. Please review the new webrev below and ignore webrev.00. hsx24 webrev: http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ (original) hsx25 webrev: http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ Test: Builds were tested on Linux-i586, Solaris-i586, and Solaris-sparc. Builds were successful and they all passed test of the gc-log size limit of 2G. Thanks. Tao On 7/1/13 1:18 PM, Tao Mao wrote: > The hsx25 fix has been pushed already. Then I got the > 7u40-critical-approved. > > When I tried backporting to hsx24, it didn't apply to the hsx24 repo > cleanly. Thus, I made the patch manually (copy-and-paste style) and > now need some quick reviews to get it in since it's 7u40 related P3 CR. > > hsx24 webrev: > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ > > (original) hsx25 webrev: > http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ > > Thanks. > Tao From erik.joelsson at oracle.com Tue Jul 2 07:16:00 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 02 Jul 2013 09:16:00 +0200 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: <51D24D95.7050207@oracle.com> References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> <51D24D95.7050207@oracle.com> Message-ID: <51D27E30.2010002@oracle.com> This looks like you have applied a change to configure input files (*.m4) and haven't regenerated configure locally afterwards. The JPRT machines don't have autoconf setup so they can't do it. In this case it looks like one of them, probably the mac, has a faulty version of autoconf that gets picked up. I have seen this happen before on mac. The fix is to execute "bash common/autoconf/autogen.sh" locally and then resubmit to jprt. You need to have autoconf version 2.67 or newer installed for it to work. /Erik On 2013-07-02 05:48, Vladimir Kozlov wrote: > Need help from JDK build experts. > > I applied next 2 changesets: > > http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ > http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ > > and got JPRT build problems (-control build) only on MacOS and Win64: > > http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ > > > ------------------------------------------------------------------------------ > > macosx_x64_10.7-product (details from log file) > > ... > > Warning: The generated configure file contains changes not present in > the custom generated file. > Running autogen.sh to correct the situation > Autoconf found: /usr/bin/autoconf > Autoconf-2.67 found: > Generating generated-configure.sh with /usr/bin/autoconf > /usr/bin/gm4:stdin:187: bad expression in eval: 32 > > autom4te: /usr/bin/gm4 failed with exit status: 1 > Generating custom generated-configure.sh > /usr/bin/gm4:stdin:187: bad expression in eval: 32 > > autom4te: /usr/bin/gm4 failed with exit status: 1 > > ------------------------------------------------------------------------------ > > windows_x64_5.2-fastdebug (details from log file) > > ... > > Warning: The generated configure file contains changes not present in > the custom generated file. > Error: Cannot continue > Cannot locate autoconf, unable to correct situation. > Please install autoconf and run 'bash autogen.sh' to update the > generated files. > make: *** [bridge2configure] Error 1 > > ------------------------------------------------------------------------------ > > > Without these changes the output is: > > Running custom generated-configure.sh > configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. > configure: configure script generated at timestamp 1371547939. > > Thanks, > Vladimir > > On 6/28/13 12:04 AM, Volker Simonis wrote: >> Ok, that's fine. >> >> Could you please let me know when you've verified these changes. I >> will then push them to the staging repository. >> >> >> Regards, >> Volker >> >> >> On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov >> wrote: >>> On 6/27/13 10:16 AM, Iris Clark wrote: >>>> >>>> Hi, Volker. >>>> >>>> I think that the right thing for this change [1] is for you to push >>>> into >>>> ppc-aix-port/stage once you get the necessary reviews (presumably >>>> Erik and >>>> possibly Alan). While your changeset contains some general purpose >>>> updates, >>>> it also contains PPC/AIX-specific files which can't be added to a JDK >>>> release repository until stage is pushed into the a JDK release. >>>> >>>> The recommendation to push to stage of course assumes that Vladimir >>>> doesn't think that this will adversely affect the Hotspot work >>>> already being >>>> pushed to stage. >>> >>> >>> This should not affect Hotspot in stage repo. Me or Albert will do JPRT >>> bootstrap control build of jdk with this changes to make sure it works. >>> After that Volker can push it into stage. >>> >>> When I talked about pushing *general* changes into main sources I meant >>> changes with no ppc64 specific code. The example of such changes was >>> recent >>> Goetz's fix for '8017531: 8010460 changes broke >>> bytecodeInterpreter.cpp'. >>> >>> Thanks, >>> Vladimir >>> >>> >>>> >>>> Thanks, >>>> iris >>>> >>>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>> >>>> -----Original Message----- >>>> From: Volker Simonis [mailto:volker.simonis at gmail.com] >>>> Sent: Thursday, June 27, 2013 9:23 AM >>>> To: Erik Joelsson >>>> Cc: Kumar Srinivasan; build-dev; ppc-aix-port-dev at openjdk.java.net; >>>> Alan >>>> Bateman >>>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) >>>> >>>> Hi Erik, >>>> >>>> we have no polices which are carved in stone:) It's all done >>>> informally >>>> and by common sense. >>>> >>>> The main reason for the ppc-aix-port/stage repository is to have a >>>> sandbox >>>> for in-depth review and testing of changes we had to make in shared >>>> code >>>> before pushing them to the main repository (and this especially >>>> applies to >>>> hotspot changes). If you feel comfortable with the current changes >>>> and don't >>>> think that they will break anything (e.g. by running tests build on >>>> your >>>> supported platforms including the closed source ones) I'd really >>>> appreciate >>>> if you could push them to the build repository. >>>> >>>> Otherwise I'll push them to the staging repository and you'll get them >>>> once we're finished with the integration of the port. >>>> >>>> Thank you and best regards, >>>> Volker >>>> >>>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson >>>> >>>> wrote: >>>>> >>>>> >>>>> >>>>> On 2013-06-27 13:00, Volker Simonis wrote: >>>>> >>>>> >>>>> >>>>> >>>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson >>>>> >>>>> wrote: >>>>>> >>>>>> >>>>>> Hello Volker, >>>>>> >>>>>> I wasn't aware of this project until now. From what I (now) >>>>>> understand, generic patches can go into jdk8 repos, but port >>>>>> specific >>>>>> things need to go to staging and go in with the rest later. These >>>>>> changes contain a couple of port specific things so as it looks now >>>>>> they would need to go through staging. >>>>>> >>>>> >>>>> Yes, that's the general approach. But I'd argue that for the most >>>>> part >>>>> this changes are generic (enable CPP-interpreter, enable CORE build, >>>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix typos) >>>>> with only very few PPC64 specific parts (map-files and a few >>>>> defines). >>>>> The problem we want to avoid is that some of our fixes go into the >>>>> main repositories in parallel which would result in merging pain when >>>>> integrating the staging into the main repository. >>>>> >>>>> So if you think you don't need any of the general fixes any time >>>>> soon, >>>>> I'll push the changes into the staging repository. Otherwise I think >>>>> it would be better to push them right into the main repositories. >>>>> >>>>> Several of the general fixes in there are good and I don't want to >>>>> hinder those getting in. I also don't want to break policies I'm not >>>>> familiar with. >>>>> >>>>> /Erik >>>>> >>>>> Thanks, >>>>> Volker >>>>> >>>>>> >>>>>> /Erik >>>>>> >>>>>> >>>>>> On 2013-06-27 12:03, Volker Simonis wrote: >>>>>> >>>>>> Hi Erik, >>>>>> >>>>>> as Vladimir explained, we have a special staging repository for our >>>>>> PPC64/AIX port: >>>>>> >>>>>> I would be happy if you could push the changes right into the >>>>>> build-infra repositories and we will then get them into our staging >>>>>> repository via jdk8/jdk8. >>>>>> >>>>>> Otherwise I'll have to push them to our staging repository and later >>>>>> when the whole port is completed in the staging repo they will be >>>>>> bulk-integrated into jdk8. >>>>>> >>>>>> What do you think? >>>>>> >>>>>> Regards, >>>>>> Volker >>>>>> >>>>>> >>>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> Erik, >>>>>>> >>>>>>> We have special staging forest for PPC64/AIX port: >>>>>>> >>>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage >>>>>>> >>>>>>> We collect Hotspot and JDK changes there for testing before pushing >>>>>>> into main sources in a future. But some general fixes we push >>>>>>> directly into our main sources. >>>>>>> If you think these build changes are acceptable for main, please, >>>>>>> ask someone sponsor these changes. >>>>>>> >>>>>>> Alan is our official contact for PPC64/AIX project. I CC him. >>>>>>> >>>>>>> Thanks, >>>>>>> Vladimir >>>>>>> >>>>>>> >>>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: >>>>>>>> >>>>>>>> >>>>>>>> Hello, >>>>>>>> >>>>>>>> If you by staging area mean the build-infra forest, that's more or >>>>>>>> less dead now. >>>>>>>> >>>>>>>> I think these changes look good now (both top level and jdk). It >>>>>>>> should be fine to push this to jdk8/build. >>>>>>>> >>>>>>>> /Erik >>>>>>>> >>>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> Hi Erik, >>>>>>>>> >>>>>>>>> thank you for looking at this. I've prepared a new webrev at: >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> What do you think, do you want to push this directly into the >>>>>>>>> build repositories or should I push it into the staging >>>>>>>>> repository >>>>>>>>> first? >>>>>>>>> >>>>>>>>> Please see my further comments inline. >>>>>>>>> >>>>>>>>> Thank you and best regards, >>>>>>>>> Volker >>>>>>>>> >>>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson >>>>>>>>> > >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: >>>>>>>>> >>>>>>>>> Hello Volker, >>>>>>>>> >>>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> could somebody please review the following >>>>>>>>> change and >>>>>>>>> create an appropriate >>>>>>>>> Bug ID for it: >>>>>>>>> >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>>> /> >>>>>>>>> >>>>>>>>> >>>>>>>>> The patch contains two little changes which are >>>>>>>>> required >>>>>>>>> to build the class >>>>>>>>> library part of the OpenJDK on Linux/PPC64. Most >>>>>>>>> of the >>>>>>>>> build magic is >>>>>>>>> contained in the top-level part of this change >>>>>>>>> which is >>>>>>>>> separately reviewed >>>>>>>>> at >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> CompileLaunchers.gmk >>>>>>>>> >>>>>>>>> Remove mapfile from build instructions of >>>>>>>>> BUILD_UNPACKEXE: >>>>>>>>> >>>>>>>>> CFLAGS_macosx:=-fPIC, \ >>>>>>>>> - >>>>>>>>> >>>>>>>>> >>>>>>>>> MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ >>>>>>>>> >>>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ >>>>>>>>> >>>>>>>>> I think it makes no sense to use a version >>>>>>>>> script file >>>>>>>>> for an executable >>>>>>>>> and older linkers (e.g. on SLES 10) complain with: >>>>>>>>> "*Invalid version tag >>>>>>>>> `SUNWprivate_1.1'. Only anonymous version tag is >>>>>>>>> allowed >>>>>>>>> in executable.*" >>>>>>>>> The GNU ld >>>>>>>>> >>>>>>>>> >>>>>>>>> manualstates: >>>>>>>>> >>>>>>>>> "*Version scripts are only meaningful when creating >>>>>>>>> shared >>>>>>>>> libraries.*" >>>>>>>>> Morover unpack200 was the only executable which >>>>>>>>> used a >>>>>>>>> version script file. >>>>>>>>> >>>>>>>>> Unpackexe has some weirdness and this isn't >>>>>>>>> surprising me. >>>>>>>>> Would be good if someone with more historic >>>>>>>>> knowledge could >>>>>>>>> fill in on the reason for this. Someone apparently went >>>>>>>>> through the trouble of creating a special mapfile >>>>>>>>> for this >>>>>>>>> executable. Also, if not using it, should it be >>>>>>>>> removed? >>>>>>>>> >>>>>>>>> I looked closer at this. These mapfiles were explicitly >>>>>>>>> added in >>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it >>>>>>>>> was noted >>>>>>>>> that it broke builds for architectures that didn't have >>>>>>>>> mapfiles >>>>>>>>> defined. If you look at the launchers, the mapfile is >>>>>>>>> only set >>>>>>>>> if >>>>>>>>> the arch specific one exists. I think a safer change >>>>>>>>> here would >>>>>>>>> be >>>>>>>>> to make the mapfile conditional on platform or arch for >>>>>>>>> unpackexe. >>>>>>>>> >>>>>>>>> >>>>>>>>> I still do not fully understand why we need map-files for >>>>>>>>> executables, but I also understand that you don't want to >>>>>>>>> change the >>>>>>>>> current setup. >>>>>>>>> So I went the hard (and hopefully right:) way and implemented a >>>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on >>>>>>>>> SLES >>>>>>>>> 10) which complain with: "Invalid version tag `SUNWprivate_1.1' >>>>>>>>> during the configure step (see top-level change). >>>>>>>>> Unfortunately we >>>>>>>>> still have quite a lot of these systems so we really need the >>>>>>>>> build with that buggy ld. >>>>>>>>> >>>>>>>>> I've therefore added map files with anonymous version tags for >>>>>>>>> these buggy linkers which are only used if the buggy linker was >>>>>>>>> detected during the configure step (i.e. if >>>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 specific >>>>>>>>> problem but a occurs on all SuSE 10 platforms. >>>>>>>>> >>>>>>>>> And you've been right. I also had to add the arch specific map >>>>>>>>> files for ppc64 in order to use them for the other launchers. >>>>>>>>> >>>>>>>>> Kumar, you made the change referred to here, do you have >>>>>>>>> anything >>>>>>>>> to add? >>>>>>>>> >>>>>>>>> /Erik >>>>>>>>> >>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>> >>>>>>>>> default: all >>>>>>>>> >>>>>>>>> CompileNativeLibraries.gmk >>>>>>>>> >>>>>>>>> Only use $(OPENWIN_LIB) for linking >>>>>>>>> LIBSPLASHSCREEN on >>>>>>>>> Solaris! The old >>>>>>>>> code worked only accidentally when the >>>>>>>>> X-libraries are >>>>>>>>> in >>>>>>>>> the default >>>>>>>>> linker path anyway. The right solution is to use >>>>>>>>> $(X_LIBS) >>>>>>>>> if not on >>>>>>>>> Windows or Solaris. >>>>>>>>> >>>>>>>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on >>>>>>>>> PPC64. >>>>>>>>> The value of >>>>>>>>> X_ARCHisn't actually used on the PPC >>>>>>>>> architectures, but >>>>>>>>> there's a >>>>>>>>> check to verify >>>>>>>>> that it is set. >>>>>>>>> >>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>> >>>>>>>>> default: all >>>>>>>>> >>>>>>>>> >>>>>>>>> Otherwise looks good. >>>>>>>>> >>>>>>>>> /Erik >>>>>>>>> >>>>>>>>> >>>>>> >>>>> >>> From volker.simonis at gmail.com Tue Jul 2 07:31:14 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 2 Jul 2013 09:31:14 +0200 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: <51D27E30.2010002@oracle.com> References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> <51D24D95.7050207@oracle.com> <51D27E30.2010002@oracle.com> Message-ID: Hi Erik, thank you for looking into this. On Tue, Jul 2, 2013 at 9:16 AM, Erik Joelsson wrote: > This looks like you have applied a change to configure input files (*.m4) > and haven't regenerated configure locally afterwards. The JPRT machines > don't have autoconf setup so they can't do it. In this case it looks like > one of them, probably the mac, has a faulty version of autoconf that gets > picked up. I have seen this happen before on mac. > Actually, that was my guess as well. On the other hand that's still strange, because my patch also contains an updated 'common/autoconf/generated- configure.sh' and it works on the other platforms (and also locally for me on MacOS X) without regenerating it. I just saw that the mail I wrote yesterday wasn't send to the lists so I quote my assumptions here: ... >From your logs I only see that the make process does not find any configuration, but the configuration should have been created by running configure. Then it tries to call configure but doesn't succeed because it says "The generated configure file contains changes not present in the custom generated file." That's also strange because my changesets also patch 'common/autoconf/generated- configure.sh' so it should not be re-generated. And finally the build fails because there's not autoconf on Windows and probably because the autoconf on Mac is too old (the checked-in file is generated by autoconf 2.8). I've just synced jdk8/jdk8 and applied the two patches. I could build without any problems on MacOS X 10.8 with the following command line. sh /usr/work/d046063/OpenJDK/ppc-aix-port/stage/configure --with-boot-jdk=/darwinintel64/output/sapjvm_7 --with-target-bits=64 --with-debug-level=release make images LOG=debug Attached you can find the output I get from running configure. Could you please retry one more time? If you still have problems, can you please run configure by hand and post the output. PS: I also saw from your logs that '/usr/bin/make sanity' is called. This also seems strange to me because I think there aren't any sanity targets any more in the new build system. Maybe you have a mismatch between old and new build system? ... Erik, could you please try this locally on Mac or Windows and post you findings. Alternatively, could you please explain post the complete JPRT output and explain what JPRT is trying to do. From Vladimir's log snippets it's hard for me t understand the whole picture. Thank you and best regards, Volker > The fix is to execute "bash common/autoconf/autogen.sh" locally and then > resubmit to jprt. You need to have autoconf version 2.67 or newer installed > for it to work. > > /Erik > > > On 2013-07-02 05:48, Vladimir Kozlov wrote: >> >> Need help from JDK build experts. >> >> I applied next 2 changesets: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ >> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >> >> and got JPRT build problems (-control build) only on MacOS and Win64: >> >> >> http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ >> >> >> ------------------------------------------------------------------------------ >> macosx_x64_10.7-product (details from log file) >> >> ... >> >> Warning: The generated configure file contains changes not present in the >> custom generated file. >> Running autogen.sh to correct the situation >> Autoconf found: /usr/bin/autoconf >> Autoconf-2.67 found: >> Generating generated-configure.sh with /usr/bin/autoconf >> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >> autom4te: /usr/bin/gm4 failed with exit status: 1 >> Generating custom generated-configure.sh >> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >> autom4te: /usr/bin/gm4 failed with exit status: 1 >> >> >> ------------------------------------------------------------------------------ >> windows_x64_5.2-fastdebug (details from log file) >> >> ... >> >> Warning: The generated configure file contains changes not present in the >> custom generated file. >> Error: Cannot continue >> Cannot locate autoconf, unable to correct situation. >> Please install autoconf and run 'bash autogen.sh' to update the generated >> files. >> make: *** [bridge2configure] Error 1 >> >> >> ------------------------------------------------------------------------------ >> >> Without these changes the output is: >> >> Running custom generated-configure.sh >> configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. >> configure: configure script generated at timestamp 1371547939. >> >> Thanks, >> Vladimir >> >> On 6/28/13 12:04 AM, Volker Simonis wrote: >>> >>> Ok, that's fine. >>> >>> Could you please let me know when you've verified these changes. I >>> will then push them to the staging repository. >>> >>> >>> Regards, >>> Volker >>> >>> >>> On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov >>> wrote: >>>> >>>> On 6/27/13 10:16 AM, Iris Clark wrote: >>>>> >>>>> >>>>> Hi, Volker. >>>>> >>>>> I think that the right thing for this change [1] is for you to push >>>>> into >>>>> ppc-aix-port/stage once you get the necessary reviews (presumably Erik >>>>> and >>>>> possibly Alan). While your changeset contains some general purpose >>>>> updates, >>>>> it also contains PPC/AIX-specific files which can't be added to a JDK >>>>> release repository until stage is pushed into the a JDK release. >>>>> >>>>> The recommendation to push to stage of course assumes that Vladimir >>>>> doesn't think that this will adversely affect the Hotspot work already >>>>> being >>>>> pushed to stage. >>>> >>>> >>>> >>>> This should not affect Hotspot in stage repo. Me or Albert will do JPRT >>>> bootstrap control build of jdk with this changes to make sure it works. >>>> After that Volker can push it into stage. >>>> >>>> When I talked about pushing *general* changes into main sources I meant >>>> changes with no ppc64 specific code. The example of such changes was >>>> recent >>>> Goetz's fix for '8017531: 8010460 changes broke >>>> bytecodeInterpreter.cpp'. >>>> >>>> Thanks, >>>> Vladimir >>>> >>>> >>>>> >>>>> Thanks, >>>>> iris >>>>> >>>>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>> >>>>> -----Original Message----- >>>>> From: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>> Sent: Thursday, June 27, 2013 9:23 AM >>>>> To: Erik Joelsson >>>>> Cc: Kumar Srinivasan; build-dev; ppc-aix-port-dev at openjdk.java.net; >>>>> Alan >>>>> Bateman >>>>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) >>>>> >>>>> Hi Erik, >>>>> >>>>> we have no polices which are carved in stone:) It's all done informally >>>>> and by common sense. >>>>> >>>>> The main reason for the ppc-aix-port/stage repository is to have a >>>>> sandbox >>>>> for in-depth review and testing of changes we had to make in shared >>>>> code >>>>> before pushing them to the main repository (and this especially applies >>>>> to >>>>> hotspot changes). If you feel comfortable with the current changes and >>>>> don't >>>>> think that they will break anything (e.g. by running tests build on >>>>> your >>>>> supported platforms including the closed source ones) I'd really >>>>> appreciate >>>>> if you could push them to the build repository. >>>>> >>>>> Otherwise I'll push them to the staging repository and you'll get them >>>>> once we're finished with the integration of the port. >>>>> >>>>> Thank you and best regards, >>>>> Volker >>>>> >>>>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson >>>>> >>>>> wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 2013-06-27 13:00, Volker Simonis wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson >>>>>> >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> Hello Volker, >>>>>>> >>>>>>> I wasn't aware of this project until now. From what I (now) >>>>>>> understand, generic patches can go into jdk8 repos, but port specific >>>>>>> things need to go to staging and go in with the rest later. These >>>>>>> changes contain a couple of port specific things so as it looks now >>>>>>> they would need to go through staging. >>>>>>> >>>>>> >>>>>> Yes, that's the general approach. But I'd argue that for the most part >>>>>> this changes are generic (enable CPP-interpreter, enable CORE build, >>>>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix typos) >>>>>> with only very few PPC64 specific parts (map-files and a few defines). >>>>>> The problem we want to avoid is that some of our fixes go into the >>>>>> main repositories in parallel which would result in merging pain when >>>>>> integrating the staging into the main repository. >>>>>> >>>>>> So if you think you don't need any of the general fixes any time soon, >>>>>> I'll push the changes into the staging repository. Otherwise I think >>>>>> it would be better to push them right into the main repositories. >>>>>> >>>>>> Several of the general fixes in there are good and I don't want to >>>>>> hinder those getting in. I also don't want to break policies I'm not >>>>>> familiar with. >>>>>> >>>>>> /Erik >>>>>> >>>>>> Thanks, >>>>>> Volker >>>>>> >>>>>>> >>>>>>> /Erik >>>>>>> >>>>>>> >>>>>>> On 2013-06-27 12:03, Volker Simonis wrote: >>>>>>> >>>>>>> Hi Erik, >>>>>>> >>>>>>> as Vladimir explained, we have a special staging repository for our >>>>>>> PPC64/AIX port: >>>>>>> >>>>>>> I would be happy if you could push the changes right into the >>>>>>> build-infra repositories and we will then get them into our staging >>>>>>> repository via jdk8/jdk8. >>>>>>> >>>>>>> Otherwise I'll have to push them to our staging repository and later >>>>>>> when the whole port is completed in the staging repo they will be >>>>>>> bulk-integrated into jdk8. >>>>>>> >>>>>>> What do you think? >>>>>>> >>>>>>> Regards, >>>>>>> Volker >>>>>>> >>>>>>> >>>>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov >>>>>>> wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Erik, >>>>>>>> >>>>>>>> We have special staging forest for PPC64/AIX port: >>>>>>>> >>>>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage >>>>>>>> >>>>>>>> We collect Hotspot and JDK changes there for testing before pushing >>>>>>>> into main sources in a future. But some general fixes we push >>>>>>>> directly into our main sources. >>>>>>>> If you think these build changes are acceptable for main, please, >>>>>>>> ask someone sponsor these changes. >>>>>>>> >>>>>>>> Alan is our official contact for PPC64/AIX project. I CC him. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Vladimir >>>>>>>> >>>>>>>> >>>>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> If you by staging area mean the build-infra forest, that's more or >>>>>>>>> less dead now. >>>>>>>>> >>>>>>>>> I think these changes look good now (both top level and jdk). It >>>>>>>>> should be fine to push this to jdk8/build. >>>>>>>>> >>>>>>>>> /Erik >>>>>>>>> >>>>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hi Erik, >>>>>>>>>> >>>>>>>>>> thank you for looking at this. I've prepared a new webrev at: >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> What do you think, do you want to push this directly into the >>>>>>>>>> build repositories or should I push it into the staging repository >>>>>>>>>> first? >>>>>>>>>> >>>>>>>>>> Please see my further comments inline. >>>>>>>>>> >>>>>>>>>> Thank you and best regards, >>>>>>>>>> Volker >>>>>>>>>> >>>>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson >>>>>>>>>> > >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: >>>>>>>>>> >>>>>>>>>> Hello Volker, >>>>>>>>>> >>>>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: >>>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> could somebody please review the following change >>>>>>>>>> and >>>>>>>>>> create an appropriate >>>>>>>>>> Bug ID for it: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>> /> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The patch contains two little changes which are >>>>>>>>>> required >>>>>>>>>> to build the class >>>>>>>>>> library part of the OpenJDK on Linux/PPC64. Most of >>>>>>>>>> the >>>>>>>>>> build magic is >>>>>>>>>> contained in the top-level part of this change which >>>>>>>>>> is >>>>>>>>>> separately reviewed >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> CompileLaunchers.gmk >>>>>>>>>> >>>>>>>>>> Remove mapfile from build instructions of >>>>>>>>>> BUILD_UNPACKEXE: >>>>>>>>>> >>>>>>>>>> CFLAGS_macosx:=-fPIC, \ >>>>>>>>>> - >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ >>>>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ >>>>>>>>>> >>>>>>>>>> I think it makes no sense to use a version script >>>>>>>>>> file >>>>>>>>>> for an executable >>>>>>>>>> and older linkers (e.g. on SLES 10) complain with: >>>>>>>>>> "*Invalid version tag >>>>>>>>>> `SUNWprivate_1.1'. Only anonymous version tag is >>>>>>>>>> allowed >>>>>>>>>> in executable.*" >>>>>>>>>> The GNU ld >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> manualstates: >>>>>>>>>> "*Version scripts are only meaningful when creating >>>>>>>>>> shared >>>>>>>>>> libraries.*" >>>>>>>>>> Morover unpack200 was the only executable which used >>>>>>>>>> a >>>>>>>>>> version script file. >>>>>>>>>> >>>>>>>>>> Unpackexe has some weirdness and this isn't surprising >>>>>>>>>> me. >>>>>>>>>> Would be good if someone with more historic knowledge >>>>>>>>>> could >>>>>>>>>> fill in on the reason for this. Someone apparently went >>>>>>>>>> through the trouble of creating a special mapfile for >>>>>>>>>> this >>>>>>>>>> executable. Also, if not using it, should it be removed? >>>>>>>>>> >>>>>>>>>> I looked closer at this. These mapfiles were explicitly >>>>>>>>>> added in >>>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it was >>>>>>>>>> noted >>>>>>>>>> that it broke builds for architectures that didn't have >>>>>>>>>> mapfiles >>>>>>>>>> defined. If you look at the launchers, the mapfile is only >>>>>>>>>> set >>>>>>>>>> if >>>>>>>>>> the arch specific one exists. I think a safer change here >>>>>>>>>> would >>>>>>>>>> be >>>>>>>>>> to make the mapfile conditional on platform or arch for >>>>>>>>>> unpackexe. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> I still do not fully understand why we need map-files for >>>>>>>>>> executables, but I also understand that you don't want to change >>>>>>>>>> the >>>>>>>>>> current setup. >>>>>>>>>> So I went the hard (and hopefully right:) way and implemented a >>>>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on SLES >>>>>>>>>> 10) which complain with: "Invalid version tag `SUNWprivate_1.1' >>>>>>>>>> during the configure step (see top-level change). Unfortunately we >>>>>>>>>> still have quite a lot of these systems so we really need the >>>>>>>>>> build with that buggy ld. >>>>>>>>>> >>>>>>>>>> I've therefore added map files with anonymous version tags for >>>>>>>>>> these buggy linkers which are only used if the buggy linker was >>>>>>>>>> detected during the configure step (i.e. if >>>>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 specific >>>>>>>>>> problem but a occurs on all SuSE 10 platforms. >>>>>>>>>> >>>>>>>>>> And you've been right. I also had to add the arch specific map >>>>>>>>>> files for ppc64 in order to use them for the other launchers. >>>>>>>>>> >>>>>>>>>> Kumar, you made the change referred to here, do you have >>>>>>>>>> anything >>>>>>>>>> to add? >>>>>>>>>> >>>>>>>>>> /Erik >>>>>>>>>> >>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>> >>>>>>>>>> default: all >>>>>>>>>> >>>>>>>>>> CompileNativeLibraries.gmk >>>>>>>>>> >>>>>>>>>> Only use $(OPENWIN_LIB) for linking LIBSPLASHSCREEN >>>>>>>>>> on >>>>>>>>>> Solaris! The old >>>>>>>>>> code worked only accidentally when the X-libraries >>>>>>>>>> are >>>>>>>>>> in >>>>>>>>>> the default >>>>>>>>>> linker path anyway. The right solution is to use >>>>>>>>>> $(X_LIBS) >>>>>>>>>> if not on >>>>>>>>>> Windows or Solaris. >>>>>>>>>> >>>>>>>>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on >>>>>>>>>> PPC64. >>>>>>>>>> The value of >>>>>>>>>> X_ARCHisn't actually used on the PPC architectures, >>>>>>>>>> but >>>>>>>>>> there's a >>>>>>>>>> check to verify >>>>>>>>>> that it is set. >>>>>>>>>> >>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>> >>>>>>>>>> default: all >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Otherwise looks good. >>>>>>>>>> >>>>>>>>>> /Erik >>>>>>>>>> >>>>>>>>>> >>>>>>> >>>>>> >>>> > From vladimir.kozlov at oracle.com Tue Jul 2 07:56:34 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 02 Jul 2013 00:56:34 -0700 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> <51D24D95.7050207@oracle.com> <51D27E30.2010002@oracle.com> Message-ID: <51D287B2.7080201@oracle.com> JPRT uses own target to build forest: jprt_build_product: sanity all_product_build http://hg.openjdk.java.net/ppc-aix-port/stage/file/c156084add48/make/jprt.gmk That is why 'make sanity' is called I think. Note the next warning was present in JPRT logs on all platforms: Warning: The generated configure file contains changes not present in the custom generated file. I verified that submitted source common/autoconf/generated-configure.sh is matching file in stage repo plus changes from patch. Hmm, may be the problem is next change in generated-configure.sh: -DATE_WHEN_GENERATED=1371547824 +DATE_WHEN_GENERATED=1372238067 It is date when Volker generated generated-configure.sh but the date of changed .m4 files is when I applied patch which is later. It looks like I need to regenerate generated-configure.sh file myself as Erik said. I will give it a try tomorrow. Vladimir On 7/2/13 12:31 AM, Volker Simonis wrote: > Hi Erik, > > thank you for looking into this. > > On Tue, Jul 2, 2013 at 9:16 AM, Erik Joelsson wrote: >> This looks like you have applied a change to configure input files (*.m4) >> and haven't regenerated configure locally afterwards. The JPRT machines >> don't have autoconf setup so they can't do it. In this case it looks like >> one of them, probably the mac, has a faulty version of autoconf that gets >> picked up. I have seen this happen before on mac. >> > > Actually, that was my guess as well. On the other hand that's still > strange, because my patch also contains an updated > 'common/autoconf/generated- > configure.sh' and it works on the other platforms (and also locally > for me on MacOS X) without regenerating it. I just saw that the mail I > wrote yesterday wasn't send to the lists so I quote my assumptions > here: > > ... > From your logs I only see that the make process does not find any > configuration, but the configuration should have been created by > running configure. Then it tries to call configure but doesn't succeed > because it says "The generated configure file contains changes not > present in the custom generated file." That's also strange because my > changesets also patch 'common/autoconf/generated- > configure.sh' so it should not be re-generated. And finally the build > fails because there's not autoconf on Windows and probably because the > autoconf on Mac is too old (the checked-in file is generated by > autoconf 2.8). > > I've just synced jdk8/jdk8 and applied the two patches. I could build > without any problems on MacOS X 10.8 with the following command line. > > sh /usr/work/d046063/OpenJDK/ppc-aix-port/stage/configure > --with-boot-jdk=/darwinintel64/output/sapjvm_7 > --with-target-bits=64 --with-debug-level=release > > make images LOG=debug > > Attached you can find the output I get from running configure. > > Could you please retry one more time? If you still have problems, can > you please run configure by hand and post the output. > > PS: I also saw from your logs that '/usr/bin/make sanity' is called. > This also seems strange to me because I think there aren't any sanity > targets any more in the new build system. Maybe you have a mismatch > between old and new build system? > ... > > Erik, could you please try this locally on Mac or Windows and post you > findings. Alternatively, could you please explain post the complete > JPRT output and explain what JPRT is trying to do. From Vladimir's log > snippets it's hard for me t understand the whole picture. > > Thank you and best regards, > Volker > >> The fix is to execute "bash common/autoconf/autogen.sh" locally and then >> resubmit to jprt. You need to have autoconf version 2.67 or newer installed >> for it to work. >> >> /Erik >> >> >> On 2013-07-02 05:48, Vladimir Kozlov wrote: >>> >>> Need help from JDK build experts. >>> >>> I applied next 2 changesets: >>> >>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ >>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>> >>> and got JPRT build problems (-control build) only on MacOS and Win64: >>> >>> >>> http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ >>> >>> >>> ------------------------------------------------------------------------------ >>> macosx_x64_10.7-product (details from log file) >>> >>> ... >>> >>> Warning: The generated configure file contains changes not present in the >>> custom generated file. >>> Running autogen.sh to correct the situation >>> Autoconf found: /usr/bin/autoconf >>> Autoconf-2.67 found: >>> Generating generated-configure.sh with /usr/bin/autoconf >>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >>> autom4te: /usr/bin/gm4 failed with exit status: 1 >>> Generating custom generated-configure.sh >>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >>> autom4te: /usr/bin/gm4 failed with exit status: 1 >>> >>> >>> ------------------------------------------------------------------------------ >>> windows_x64_5.2-fastdebug (details from log file) >>> >>> ... >>> >>> Warning: The generated configure file contains changes not present in the >>> custom generated file. >>> Error: Cannot continue >>> Cannot locate autoconf, unable to correct situation. >>> Please install autoconf and run 'bash autogen.sh' to update the generated >>> files. >>> make: *** [bridge2configure] Error 1 >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> Without these changes the output is: >>> >>> Running custom generated-configure.sh >>> configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. >>> configure: configure script generated at timestamp 1371547939. >>> >>> Thanks, >>> Vladimir >>> >>> On 6/28/13 12:04 AM, Volker Simonis wrote: >>>> >>>> Ok, that's fine. >>>> >>>> Could you please let me know when you've verified these changes. I >>>> will then push them to the staging repository. >>>> >>>> >>>> Regards, >>>> Volker >>>> >>>> >>>> On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov >>>> wrote: >>>>> >>>>> On 6/27/13 10:16 AM, Iris Clark wrote: >>>>>> >>>>>> >>>>>> Hi, Volker. >>>>>> >>>>>> I think that the right thing for this change [1] is for you to push >>>>>> into >>>>>> ppc-aix-port/stage once you get the necessary reviews (presumably Erik >>>>>> and >>>>>> possibly Alan). While your changeset contains some general purpose >>>>>> updates, >>>>>> it also contains PPC/AIX-specific files which can't be added to a JDK >>>>>> release repository until stage is pushed into the a JDK release. >>>>>> >>>>>> The recommendation to push to stage of course assumes that Vladimir >>>>>> doesn't think that this will adversely affect the Hotspot work already >>>>>> being >>>>>> pushed to stage. >>>>> >>>>> >>>>> >>>>> This should not affect Hotspot in stage repo. Me or Albert will do JPRT >>>>> bootstrap control build of jdk with this changes to make sure it works. >>>>> After that Volker can push it into stage. >>>>> >>>>> When I talked about pushing *general* changes into main sources I meant >>>>> changes with no ppc64 specific code. The example of such changes was >>>>> recent >>>>> Goetz's fix for '8017531: 8010460 changes broke >>>>> bytecodeInterpreter.cpp'. >>>>> >>>>> Thanks, >>>>> Vladimir >>>>> >>>>> >>>>>> >>>>>> Thanks, >>>>>> iris >>>>>> >>>>>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>> >>>>>> -----Original Message----- >>>>>> From: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>>> Sent: Thursday, June 27, 2013 9:23 AM >>>>>> To: Erik Joelsson >>>>>> Cc: Kumar Srinivasan; build-dev; ppc-aix-port-dev at openjdk.java.net; >>>>>> Alan >>>>>> Bateman >>>>>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) >>>>>> >>>>>> Hi Erik, >>>>>> >>>>>> we have no polices which are carved in stone:) It's all done informally >>>>>> and by common sense. >>>>>> >>>>>> The main reason for the ppc-aix-port/stage repository is to have a >>>>>> sandbox >>>>>> for in-depth review and testing of changes we had to make in shared >>>>>> code >>>>>> before pushing them to the main repository (and this especially applies >>>>>> to >>>>>> hotspot changes). If you feel comfortable with the current changes and >>>>>> don't >>>>>> think that they will break anything (e.g. by running tests build on >>>>>> your >>>>>> supported platforms including the closed source ones) I'd really >>>>>> appreciate >>>>>> if you could push them to the build repository. >>>>>> >>>>>> Otherwise I'll push them to the staging repository and you'll get them >>>>>> once we're finished with the integration of the port. >>>>>> >>>>>> Thank you and best regards, >>>>>> Volker >>>>>> >>>>>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson >>>>>> >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 2013-06-27 13:00, Volker Simonis wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson >>>>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Hello Volker, >>>>>>>> >>>>>>>> I wasn't aware of this project until now. From what I (now) >>>>>>>> understand, generic patches can go into jdk8 repos, but port specific >>>>>>>> things need to go to staging and go in with the rest later. These >>>>>>>> changes contain a couple of port specific things so as it looks now >>>>>>>> they would need to go through staging. >>>>>>>> >>>>>>> >>>>>>> Yes, that's the general approach. But I'd argue that for the most part >>>>>>> this changes are generic (enable CPP-interpreter, enable CORE build, >>>>>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix typos) >>>>>>> with only very few PPC64 specific parts (map-files and a few defines). >>>>>>> The problem we want to avoid is that some of our fixes go into the >>>>>>> main repositories in parallel which would result in merging pain when >>>>>>> integrating the staging into the main repository. >>>>>>> >>>>>>> So if you think you don't need any of the general fixes any time soon, >>>>>>> I'll push the changes into the staging repository. Otherwise I think >>>>>>> it would be better to push them right into the main repositories. >>>>>>> >>>>>>> Several of the general fixes in there are good and I don't want to >>>>>>> hinder those getting in. I also don't want to break policies I'm not >>>>>>> familiar with. >>>>>>> >>>>>>> /Erik >>>>>>> >>>>>>> Thanks, >>>>>>> Volker >>>>>>> >>>>>>>> >>>>>>>> /Erik >>>>>>>> >>>>>>>> >>>>>>>> On 2013-06-27 12:03, Volker Simonis wrote: >>>>>>>> >>>>>>>> Hi Erik, >>>>>>>> >>>>>>>> as Vladimir explained, we have a special staging repository for our >>>>>>>> PPC64/AIX port: >>>>>>>> >>>>>>>> I would be happy if you could push the changes right into the >>>>>>>> build-infra repositories and we will then get them into our staging >>>>>>>> repository via jdk8/jdk8. >>>>>>>> >>>>>>>> Otherwise I'll have to push them to our staging repository and later >>>>>>>> when the whole port is completed in the staging repo they will be >>>>>>>> bulk-integrated into jdk8. >>>>>>>> >>>>>>>> What do you think? >>>>>>>> >>>>>>>> Regards, >>>>>>>> Volker >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Erik, >>>>>>>>> >>>>>>>>> We have special staging forest for PPC64/AIX port: >>>>>>>>> >>>>>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage >>>>>>>>> >>>>>>>>> We collect Hotspot and JDK changes there for testing before pushing >>>>>>>>> into main sources in a future. But some general fixes we push >>>>>>>>> directly into our main sources. >>>>>>>>> If you think these build changes are acceptable for main, please, >>>>>>>>> ask someone sponsor these changes. >>>>>>>>> >>>>>>>>> Alan is our official contact for PPC64/AIX project. I CC him. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Vladimir >>>>>>>>> >>>>>>>>> >>>>>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> If you by staging area mean the build-infra forest, that's more or >>>>>>>>>> less dead now. >>>>>>>>>> >>>>>>>>>> I think these changes look good now (both top level and jdk). It >>>>>>>>>> should be fine to push this to jdk8/build. >>>>>>>>>> >>>>>>>>>> /Erik >>>>>>>>>> >>>>>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Erik, >>>>>>>>>>> >>>>>>>>>>> thank you for looking at this. I've prepared a new webrev at: >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> What do you think, do you want to push this directly into the >>>>>>>>>>> build repositories or should I push it into the staging repository >>>>>>>>>>> first? >>>>>>>>>>> >>>>>>>>>>> Please see my further comments inline. >>>>>>>>>>> >>>>>>>>>>> Thank you and best regards, >>>>>>>>>>> Volker >>>>>>>>>>> >>>>>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson >>>>>>>>>>> > >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: >>>>>>>>>>> >>>>>>>>>>> Hello Volker, >>>>>>>>>>> >>>>>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> could somebody please review the following change >>>>>>>>>>> and >>>>>>>>>>> create an appropriate >>>>>>>>>>> Bug ID for it: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> /> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> The patch contains two little changes which are >>>>>>>>>>> required >>>>>>>>>>> to build the class >>>>>>>>>>> library part of the OpenJDK on Linux/PPC64. Most of >>>>>>>>>>> the >>>>>>>>>>> build magic is >>>>>>>>>>> contained in the top-level part of this change which >>>>>>>>>>> is >>>>>>>>>>> separately reviewed >>>>>>>>>>> at >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> CompileLaunchers.gmk >>>>>>>>>>> >>>>>>>>>>> Remove mapfile from build instructions of >>>>>>>>>>> BUILD_UNPACKEXE: >>>>>>>>>>> >>>>>>>>>>> CFLAGS_macosx:=-fPIC, \ >>>>>>>>>>> - >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ >>>>>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ >>>>>>>>>>> >>>>>>>>>>> I think it makes no sense to use a version script >>>>>>>>>>> file >>>>>>>>>>> for an executable >>>>>>>>>>> and older linkers (e.g. on SLES 10) complain with: >>>>>>>>>>> "*Invalid version tag >>>>>>>>>>> `SUNWprivate_1.1'. Only anonymous version tag is >>>>>>>>>>> allowed >>>>>>>>>>> in executable.*" >>>>>>>>>>> The GNU ld >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> manualstates: >>>>>>>>>>> "*Version scripts are only meaningful when creating >>>>>>>>>>> shared >>>>>>>>>>> libraries.*" >>>>>>>>>>> Morover unpack200 was the only executable which used >>>>>>>>>>> a >>>>>>>>>>> version script file. >>>>>>>>>>> >>>>>>>>>>> Unpackexe has some weirdness and this isn't surprising >>>>>>>>>>> me. >>>>>>>>>>> Would be good if someone with more historic knowledge >>>>>>>>>>> could >>>>>>>>>>> fill in on the reason for this. Someone apparently went >>>>>>>>>>> through the trouble of creating a special mapfile for >>>>>>>>>>> this >>>>>>>>>>> executable. Also, if not using it, should it be removed? >>>>>>>>>>> >>>>>>>>>>> I looked closer at this. These mapfiles were explicitly >>>>>>>>>>> added in >>>>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it was >>>>>>>>>>> noted >>>>>>>>>>> that it broke builds for architectures that didn't have >>>>>>>>>>> mapfiles >>>>>>>>>>> defined. If you look at the launchers, the mapfile is only >>>>>>>>>>> set >>>>>>>>>>> if >>>>>>>>>>> the arch specific one exists. I think a safer change here >>>>>>>>>>> would >>>>>>>>>>> be >>>>>>>>>>> to make the mapfile conditional on platform or arch for >>>>>>>>>>> unpackexe. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I still do not fully understand why we need map-files for >>>>>>>>>>> executables, but I also understand that you don't want to change >>>>>>>>>>> the >>>>>>>>>>> current setup. >>>>>>>>>>> So I went the hard (and hopefully right:) way and implemented a >>>>>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on SLES >>>>>>>>>>> 10) which complain with: "Invalid version tag `SUNWprivate_1.1' >>>>>>>>>>> during the configure step (see top-level change). Unfortunately we >>>>>>>>>>> still have quite a lot of these systems so we really need the >>>>>>>>>>> build with that buggy ld. >>>>>>>>>>> >>>>>>>>>>> I've therefore added map files with anonymous version tags for >>>>>>>>>>> these buggy linkers which are only used if the buggy linker was >>>>>>>>>>> detected during the configure step (i.e. if >>>>>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 specific >>>>>>>>>>> problem but a occurs on all SuSE 10 platforms. >>>>>>>>>>> >>>>>>>>>>> And you've been right. I also had to add the arch specific map >>>>>>>>>>> files for ppc64 in order to use them for the other launchers. >>>>>>>>>>> >>>>>>>>>>> Kumar, you made the change referred to here, do you have >>>>>>>>>>> anything >>>>>>>>>>> to add? >>>>>>>>>>> >>>>>>>>>>> /Erik >>>>>>>>>>> >>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>>> >>>>>>>>>>> default: all >>>>>>>>>>> >>>>>>>>>>> CompileNativeLibraries.gmk >>>>>>>>>>> >>>>>>>>>>> Only use $(OPENWIN_LIB) for linking LIBSPLASHSCREEN >>>>>>>>>>> on >>>>>>>>>>> Solaris! The old >>>>>>>>>>> code worked only accidentally when the X-libraries >>>>>>>>>>> are >>>>>>>>>>> in >>>>>>>>>>> the default >>>>>>>>>>> linker path anyway. The right solution is to use >>>>>>>>>>> $(X_LIBS) >>>>>>>>>>> if not on >>>>>>>>>>> Windows or Solaris. >>>>>>>>>>> >>>>>>>>>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on >>>>>>>>>>> PPC64. >>>>>>>>>>> The value of >>>>>>>>>>> X_ARCHisn't actually used on the PPC architectures, >>>>>>>>>>> but >>>>>>>>>>> there's a >>>>>>>>>>> check to verify >>>>>>>>>>> that it is set. >>>>>>>>>>> >>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>>> >>>>>>>>>>> default: all >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Otherwise looks good. >>>>>>>>>>> >>>>>>>>>>> /Erik >>>>>>>>>>> >>>>>>>>>>> >>>>>>>> >>>>>>> >>>>> >> > From volker.simonis at gmail.com Tue Jul 2 08:42:00 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 2 Jul 2013 10:42:00 +0200 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: <51D287B2.7080201@oracle.com> References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> <51D24D95.7050207@oracle.com> <51D27E30.2010002@oracle.com> <51D287B2.7080201@oracle.com> Message-ID: On Tue, Jul 2, 2013 at 9:56 AM, Vladimir Kozlov wrote: > JPRT uses own target to build forest: > > jprt_build_product: sanity all_product_build > > http://hg.openjdk.java.net/ppc-aix-port/stage/file/c156084add48/make/jprt.gmk > > That is why 'make sanity' is called I think. > > Note the next warning was present in JPRT logs on all platforms: > > Warning: The generated configure file contains changes not present in the > custom generated file. > > I verified that submitted source common/autoconf/generated-configure.sh is > matching file in stage repo plus changes from patch. > > Hmm, may be the problem is next change in generated-configure.sh: > > -DATE_WHEN_GENERATED=1371547824 > +DATE_WHEN_GENERATED=1372238067 > > It is date when Volker generated generated-configure.sh but the date of > changed .m4 files is when I applied patch which is later. It looks like I > need to regenerate generated-configure.sh file myself as Erik said. I will > give it a try tomorrow. > I doubt that that's the only reason, because I did exactly the same yesterday on MacOS without these problems: - clone jdk8/jdk8 - import the patches into the base and jdk repositroy - configure - make Is there a way I can simulate a JPRT build? If I just call 'make jprt_build_product' in the build directory where I have previously called 'configure' it fails because it wants to call configure again and doesn't find it. So from which directory am I supposed to start a JPRT build and which parameters should I pass to it? > Vladimir > > > On 7/2/13 12:31 AM, Volker Simonis wrote: >> >> Hi Erik, >> >> thank you for looking into this. >> >> On Tue, Jul 2, 2013 at 9:16 AM, Erik Joelsson >> wrote: >>> >>> This looks like you have applied a change to configure input files (*.m4) >>> and haven't regenerated configure locally afterwards. The JPRT machines >>> don't have autoconf setup so they can't do it. In this case it looks like >>> one of them, probably the mac, has a faulty version of autoconf that gets >>> picked up. I have seen this happen before on mac. >>> >> >> Actually, that was my guess as well. On the other hand that's still >> strange, because my patch also contains an updated >> 'common/autoconf/generated- >> configure.sh' and it works on the other platforms (and also locally >> for me on MacOS X) without regenerating it. I just saw that the mail I >> wrote yesterday wasn't send to the lists so I quote my assumptions >> here: >> >> ... >> From your logs I only see that the make process does not find any >> configuration, but the configuration should have been created by >> running configure. Then it tries to call configure but doesn't succeed >> because it says "The generated configure file contains changes not >> present in the custom generated file." That's also strange because my >> changesets also patch 'common/autoconf/generated- >> configure.sh' so it should not be re-generated. And finally the build >> fails because there's not autoconf on Windows and probably because the >> autoconf on Mac is too old (the checked-in file is generated by >> autoconf 2.8). >> >> I've just synced jdk8/jdk8 and applied the two patches. I could build >> without any problems on MacOS X 10.8 with the following command line. >> >> sh /usr/work/d046063/OpenJDK/ppc-aix-port/stage/configure >> --with-boot-jdk=/darwinintel64/output/sapjvm_7 >> --with-target-bits=64 --with-debug-level=release >> >> make images LOG=debug >> >> Attached you can find the output I get from running configure. >> >> Could you please retry one more time? If you still have problems, can >> you please run configure by hand and post the output. >> >> PS: I also saw from your logs that '/usr/bin/make sanity' is called. >> This also seems strange to me because I think there aren't any sanity >> targets any more in the new build system. Maybe you have a mismatch >> between old and new build system? >> ... >> >> Erik, could you please try this locally on Mac or Windows and post you >> findings. Alternatively, could you please explain post the complete >> JPRT output and explain what JPRT is trying to do. From Vladimir's log >> snippets it's hard for me t understand the whole picture. >> >> Thank you and best regards, >> Volker >> >>> The fix is to execute "bash common/autoconf/autogen.sh" locally and then >>> resubmit to jprt. You need to have autoconf version 2.67 or newer >>> installed >>> for it to work. >>> >>> /Erik >>> >>> >>> On 2013-07-02 05:48, Vladimir Kozlov wrote: >>>> >>>> >>>> Need help from JDK build experts. >>>> >>>> I applied next 2 changesets: >>>> >>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ >>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>> >>>> and got JPRT build problems (-control build) only on MacOS and Win64: >>>> >>>> >>>> >>>> http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> macosx_x64_10.7-product (details from log file) >>>> >>>> ... >>>> >>>> Warning: The generated configure file contains changes not present in >>>> the >>>> custom generated file. >>>> Running autogen.sh to correct the situation >>>> Autoconf found: /usr/bin/autoconf >>>> Autoconf-2.67 found: >>>> Generating generated-configure.sh with /usr/bin/autoconf >>>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >>>> autom4te: /usr/bin/gm4 failed with exit status: 1 >>>> Generating custom generated-configure.sh >>>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >>>> autom4te: /usr/bin/gm4 failed with exit status: 1 >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> windows_x64_5.2-fastdebug (details from log file) >>>> >>>> ... >>>> >>>> Warning: The generated configure file contains changes not present in >>>> the >>>> custom generated file. >>>> Error: Cannot continue >>>> Cannot locate autoconf, unable to correct situation. >>>> Please install autoconf and run 'bash autogen.sh' to update the >>>> generated >>>> files. >>>> make: *** [bridge2configure] Error 1 >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> Without these changes the output is: >>>> >>>> Running custom generated-configure.sh >>>> configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. >>>> configure: configure script generated at timestamp 1371547939. >>>> >>>> Thanks, >>>> Vladimir >>>> >>>> On 6/28/13 12:04 AM, Volker Simonis wrote: >>>>> >>>>> >>>>> Ok, that's fine. >>>>> >>>>> Could you please let me know when you've verified these changes. I >>>>> will then push them to the staging repository. >>>>> >>>>> >>>>> Regards, >>>>> Volker >>>>> >>>>> >>>>> On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov >>>>> wrote: >>>>>> >>>>>> >>>>>> On 6/27/13 10:16 AM, Iris Clark wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> Hi, Volker. >>>>>>> >>>>>>> I think that the right thing for this change [1] is for you to push >>>>>>> into >>>>>>> ppc-aix-port/stage once you get the necessary reviews (presumably >>>>>>> Erik >>>>>>> and >>>>>>> possibly Alan). While your changeset contains some general purpose >>>>>>> updates, >>>>>>> it also contains PPC/AIX-specific files which can't be added to a JDK >>>>>>> release repository until stage is pushed into the a JDK release. >>>>>>> >>>>>>> The recommendation to push to stage of course assumes that Vladimir >>>>>>> doesn't think that this will adversely affect the Hotspot work >>>>>>> already >>>>>>> being >>>>>>> pushed to stage. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> This should not affect Hotspot in stage repo. Me or Albert will do >>>>>> JPRT >>>>>> bootstrap control build of jdk with this changes to make sure it >>>>>> works. >>>>>> After that Volker can push it into stage. >>>>>> >>>>>> When I talked about pushing *general* changes into main sources I >>>>>> meant >>>>>> changes with no ppc64 specific code. The example of such changes was >>>>>> recent >>>>>> Goetz's fix for '8017531: 8010460 changes broke >>>>>> bytecodeInterpreter.cpp'. >>>>>> >>>>>> Thanks, >>>>>> Vladimir >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> iris >>>>>>> >>>>>>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>>>> Sent: Thursday, June 27, 2013 9:23 AM >>>>>>> To: Erik Joelsson >>>>>>> Cc: Kumar Srinivasan; build-dev; ppc-aix-port-dev at openjdk.java.net; >>>>>>> Alan >>>>>>> Bateman >>>>>>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) >>>>>>> >>>>>>> Hi Erik, >>>>>>> >>>>>>> we have no polices which are carved in stone:) It's all done >>>>>>> informally >>>>>>> and by common sense. >>>>>>> >>>>>>> The main reason for the ppc-aix-port/stage repository is to have a >>>>>>> sandbox >>>>>>> for in-depth review and testing of changes we had to make in shared >>>>>>> code >>>>>>> before pushing them to the main repository (and this especially >>>>>>> applies >>>>>>> to >>>>>>> hotspot changes). If you feel comfortable with the current changes >>>>>>> and >>>>>>> don't >>>>>>> think that they will break anything (e.g. by running tests build on >>>>>>> your >>>>>>> supported platforms including the closed source ones) I'd really >>>>>>> appreciate >>>>>>> if you could push them to the build repository. >>>>>>> >>>>>>> Otherwise I'll push them to the staging repository and you'll get >>>>>>> them >>>>>>> once we're finished with the integration of the port. >>>>>>> >>>>>>> Thank you and best regards, >>>>>>> Volker >>>>>>> >>>>>>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson >>>>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 2013-06-27 13:00, Volker Simonis wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson >>>>>>>> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Hello Volker, >>>>>>>>> >>>>>>>>> I wasn't aware of this project until now. From what I (now) >>>>>>>>> understand, generic patches can go into jdk8 repos, but port >>>>>>>>> specific >>>>>>>>> things need to go to staging and go in with the rest later. These >>>>>>>>> changes contain a couple of port specific things so as it looks now >>>>>>>>> they would need to go through staging. >>>>>>>>> >>>>>>>> >>>>>>>> Yes, that's the general approach. But I'd argue that for the most >>>>>>>> part >>>>>>>> this changes are generic (enable CPP-interpreter, enable CORE build, >>>>>>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix >>>>>>>> typos) >>>>>>>> with only very few PPC64 specific parts (map-files and a few >>>>>>>> defines). >>>>>>>> The problem we want to avoid is that some of our fixes go into the >>>>>>>> main repositories in parallel which would result in merging pain >>>>>>>> when >>>>>>>> integrating the staging into the main repository. >>>>>>>> >>>>>>>> So if you think you don't need any of the general fixes any time >>>>>>>> soon, >>>>>>>> I'll push the changes into the staging repository. Otherwise I think >>>>>>>> it would be better to push them right into the main repositories. >>>>>>>> >>>>>>>> Several of the general fixes in there are good and I don't want to >>>>>>>> hinder those getting in. I also don't want to break policies I'm not >>>>>>>> familiar with. >>>>>>>> >>>>>>>> /Erik >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Volker >>>>>>>> >>>>>>>>> >>>>>>>>> /Erik >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2013-06-27 12:03, Volker Simonis wrote: >>>>>>>>> >>>>>>>>> Hi Erik, >>>>>>>>> >>>>>>>>> as Vladimir explained, we have a special staging repository for our >>>>>>>>> PPC64/AIX port: >>>>>>>>> >>>>>>>>> I would be happy if you could push the changes right into the >>>>>>>>> build-infra repositories and we will then get them into our staging >>>>>>>>> repository via jdk8/jdk8. >>>>>>>>> >>>>>>>>> Otherwise I'll have to push them to our staging repository and >>>>>>>>> later >>>>>>>>> when the whole port is completed in the staging repo they will be >>>>>>>>> bulk-integrated into jdk8. >>>>>>>>> >>>>>>>>> What do you think? >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Volker >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Erik, >>>>>>>>>> >>>>>>>>>> We have special staging forest for PPC64/AIX port: >>>>>>>>>> >>>>>>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage >>>>>>>>>> >>>>>>>>>> We collect Hotspot and JDK changes there for testing before >>>>>>>>>> pushing >>>>>>>>>> into main sources in a future. But some general fixes we push >>>>>>>>>> directly into our main sources. >>>>>>>>>> If you think these build changes are acceptable for main, please, >>>>>>>>>> ask someone sponsor these changes. >>>>>>>>>> >>>>>>>>>> Alan is our official contact for PPC64/AIX project. I CC him. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Vladimir >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hello, >>>>>>>>>>> >>>>>>>>>>> If you by staging area mean the build-infra forest, that's more >>>>>>>>>>> or >>>>>>>>>>> less dead now. >>>>>>>>>>> >>>>>>>>>>> I think these changes look good now (both top level and jdk). It >>>>>>>>>>> should be fine to push this to jdk8/build. >>>>>>>>>>> >>>>>>>>>>> /Erik >>>>>>>>>>> >>>>>>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Hi Erik, >>>>>>>>>>>> >>>>>>>>>>>> thank you for looking at this. I've prepared a new webrev at: >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> What do you think, do you want to push this directly into the >>>>>>>>>>>> build repositories or should I push it into the staging >>>>>>>>>>>> repository >>>>>>>>>>>> first? >>>>>>>>>>>> >>>>>>>>>>>> Please see my further comments inline. >>>>>>>>>>>> >>>>>>>>>>>> Thank you and best regards, >>>>>>>>>>>> Volker >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson >>>>>>>>>>>> > >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hello Volker, >>>>>>>>>>>> >>>>>>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> could somebody please review the following change >>>>>>>>>>>> and >>>>>>>>>>>> create an appropriate >>>>>>>>>>>> Bug ID for it: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> /> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> The patch contains two little changes which are >>>>>>>>>>>> required >>>>>>>>>>>> to build the class >>>>>>>>>>>> library part of the OpenJDK on Linux/PPC64. Most >>>>>>>>>>>> of >>>>>>>>>>>> the >>>>>>>>>>>> build magic is >>>>>>>>>>>> contained in the top-level part of this change >>>>>>>>>>>> which >>>>>>>>>>>> is >>>>>>>>>>>> separately reviewed >>>>>>>>>>>> at >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> CompileLaunchers.gmk >>>>>>>>>>>> >>>>>>>>>>>> Remove mapfile from build instructions of >>>>>>>>>>>> BUILD_UNPACKEXE: >>>>>>>>>>>> >>>>>>>>>>>> CFLAGS_macosx:=-fPIC, \ >>>>>>>>>>>> - >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ >>>>>>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ >>>>>>>>>>>> >>>>>>>>>>>> I think it makes no sense to use a version >>>>>>>>>>>> script >>>>>>>>>>>> file >>>>>>>>>>>> for an executable >>>>>>>>>>>> and older linkers (e.g. on SLES 10) complain >>>>>>>>>>>> with: >>>>>>>>>>>> "*Invalid version tag >>>>>>>>>>>> `SUNWprivate_1.1'. Only anonymous version tag is >>>>>>>>>>>> allowed >>>>>>>>>>>> in executable.*" >>>>>>>>>>>> The GNU ld >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> manualstates: >>>>>>>>>>>> "*Version scripts are only meaningful when >>>>>>>>>>>> creating >>>>>>>>>>>> shared >>>>>>>>>>>> libraries.*" >>>>>>>>>>>> Morover unpack200 was the only executable which >>>>>>>>>>>> used >>>>>>>>>>>> a >>>>>>>>>>>> version script file. >>>>>>>>>>>> >>>>>>>>>>>> Unpackexe has some weirdness and this isn't >>>>>>>>>>>> surprising >>>>>>>>>>>> me. >>>>>>>>>>>> Would be good if someone with more historic knowledge >>>>>>>>>>>> could >>>>>>>>>>>> fill in on the reason for this. Someone apparently >>>>>>>>>>>> went >>>>>>>>>>>> through the trouble of creating a special mapfile for >>>>>>>>>>>> this >>>>>>>>>>>> executable. Also, if not using it, should it be >>>>>>>>>>>> removed? >>>>>>>>>>>> >>>>>>>>>>>> I looked closer at this. These mapfiles were explicitly >>>>>>>>>>>> added in >>>>>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it >>>>>>>>>>>> was >>>>>>>>>>>> noted >>>>>>>>>>>> that it broke builds for architectures that didn't have >>>>>>>>>>>> mapfiles >>>>>>>>>>>> defined. If you look at the launchers, the mapfile is >>>>>>>>>>>> only >>>>>>>>>>>> set >>>>>>>>>>>> if >>>>>>>>>>>> the arch specific one exists. I think a safer change here >>>>>>>>>>>> would >>>>>>>>>>>> be >>>>>>>>>>>> to make the mapfile conditional on platform or arch for >>>>>>>>>>>> unpackexe. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> I still do not fully understand why we need map-files for >>>>>>>>>>>> executables, but I also understand that you don't want to change >>>>>>>>>>>> the >>>>>>>>>>>> current setup. >>>>>>>>>>>> So I went the hard (and hopefully right:) way and implemented a >>>>>>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on >>>>>>>>>>>> SLES >>>>>>>>>>>> 10) which complain with: "Invalid version tag `SUNWprivate_1.1' >>>>>>>>>>>> during the configure step (see top-level change). Unfortunately >>>>>>>>>>>> we >>>>>>>>>>>> still have quite a lot of these systems so we really need the >>>>>>>>>>>> build with that buggy ld. >>>>>>>>>>>> >>>>>>>>>>>> I've therefore added map files with anonymous version tags for >>>>>>>>>>>> these buggy linkers which are only used if the buggy linker was >>>>>>>>>>>> detected during the configure step (i.e. if >>>>>>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 specific >>>>>>>>>>>> problem but a occurs on all SuSE 10 platforms. >>>>>>>>>>>> >>>>>>>>>>>> And you've been right. I also had to add the arch specific map >>>>>>>>>>>> files for ppc64 in order to use them for the other launchers. >>>>>>>>>>>> >>>>>>>>>>>> Kumar, you made the change referred to here, do you have >>>>>>>>>>>> anything >>>>>>>>>>>> to add? >>>>>>>>>>>> >>>>>>>>>>>> /Erik >>>>>>>>>>>> >>>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>>>> >>>>>>>>>>>> default: all >>>>>>>>>>>> >>>>>>>>>>>> CompileNativeLibraries.gmk >>>>>>>>>>>> >>>>>>>>>>>> Only use $(OPENWIN_LIB) for linking >>>>>>>>>>>> LIBSPLASHSCREEN >>>>>>>>>>>> on >>>>>>>>>>>> Solaris! The old >>>>>>>>>>>> code worked only accidentally when the >>>>>>>>>>>> X-libraries >>>>>>>>>>>> are >>>>>>>>>>>> in >>>>>>>>>>>> the default >>>>>>>>>>>> linker path anyway. The right solution is to use >>>>>>>>>>>> $(X_LIBS) >>>>>>>>>>>> if not on >>>>>>>>>>>> Windows or Solaris. >>>>>>>>>>>> >>>>>>>>>>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on >>>>>>>>>>>> PPC64. >>>>>>>>>>>> The value of >>>>>>>>>>>> X_ARCHisn't actually used on the PPC >>>>>>>>>>>> architectures, >>>>>>>>>>>> but >>>>>>>>>>>> there's a >>>>>>>>>>>> check to verify >>>>>>>>>>>> that it is set. >>>>>>>>>>>> >>>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>>>> >>>>>>>>>>>> default: all >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Otherwise looks good. >>>>>>>>>>>> >>>>>>>>>>>> /Erik >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>> >> > From volker.simonis at gmail.com Tue Jul 2 08:54:25 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 2 Jul 2013 10:54:25 +0200 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> <51D24D95.7050207@oracle.com> <51D27E30.2010002@oracle.com> <51D287B2.7080201@oracle.com> Message-ID: Ah, now I got it! The problem is with your closed sources which also have their own closed, autoconf-generated config file which has to be recreated after the OpenJDK autoconf-generated configure files changes. The warning "Warning: The generated configure file contains changes not present in the custom generated file." from 'common/autoconf/configure:' actually checks exactly that: if test -e $conf_custom_script_dir/generated-configure.sh; then # Test if open configure is newer than custom configure, if so, custom needs to # be regenerated. This test is required to ensure consistency with custom source. conf_open_configure_timestamp=`grep DATE_WHEN_GENERATED= $conf_script_dir/generated-configure.sh | cut -d"=" -f 2` conf_custom_configure_timestamp=`grep DATE_WHEN_GENERATED= $conf_custom_script_dir/generated-configure.sh | cut -d"=" -f 2` if test $conf_open_configure_timestamp -gt $conf_custom_configure_timestamp; then echo "Warning: The generated configure file contains changes not present in the custom generated file." run_autogen_or_fail fi fi I obviously can not fix that:) But if you've already done a successful build on any other platform, you can just copy the generated '$conf_custom_script_dir/generated-configure.sh' from that build into you workspace and that should do the job! Very nasty Closedsource/JPRT problems:( When will we finally overcome this mess... Regards, Volker On Tue, Jul 2, 2013 at 10:42 AM, Volker Simonis wrote: > On Tue, Jul 2, 2013 at 9:56 AM, Vladimir Kozlov > wrote: >> JPRT uses own target to build forest: >> >> jprt_build_product: sanity all_product_build >> >> http://hg.openjdk.java.net/ppc-aix-port/stage/file/c156084add48/make/jprt.gmk >> >> That is why 'make sanity' is called I think. >> >> Note the next warning was present in JPRT logs on all platforms: >> >> Warning: The generated configure file contains changes not present in the >> custom generated file. >> >> I verified that submitted source common/autoconf/generated-configure.sh is >> matching file in stage repo plus changes from patch. >> >> Hmm, may be the problem is next change in generated-configure.sh: >> >> -DATE_WHEN_GENERATED=1371547824 >> +DATE_WHEN_GENERATED=1372238067 >> >> It is date when Volker generated generated-configure.sh but the date of >> changed .m4 files is when I applied patch which is later. It looks like I >> need to regenerate generated-configure.sh file myself as Erik said. I will >> give it a try tomorrow. >> > > I doubt that that's the only reason, because I did exactly the same > yesterday on MacOS without these problems: > - clone jdk8/jdk8 > - import the patches into the base and jdk repositroy > - configure > - make > > Is there a way I can simulate a JPRT build? > If I just call 'make jprt_build_product' in the build directory where > I have previously called 'configure' it fails because it wants to call > configure again and doesn't find it. > So from which directory am I supposed to start a JPRT build and which > parameters should I pass to it? > >> Vladimir >> >> >> On 7/2/13 12:31 AM, Volker Simonis wrote: >>> >>> Hi Erik, >>> >>> thank you for looking into this. >>> >>> On Tue, Jul 2, 2013 at 9:16 AM, Erik Joelsson >>> wrote: >>>> >>>> This looks like you have applied a change to configure input files (*.m4) >>>> and haven't regenerated configure locally afterwards. The JPRT machines >>>> don't have autoconf setup so they can't do it. In this case it looks like >>>> one of them, probably the mac, has a faulty version of autoconf that gets >>>> picked up. I have seen this happen before on mac. >>>> >>> >>> Actually, that was my guess as well. On the other hand that's still >>> strange, because my patch also contains an updated >>> 'common/autoconf/generated- >>> configure.sh' and it works on the other platforms (and also locally >>> for me on MacOS X) without regenerating it. I just saw that the mail I >>> wrote yesterday wasn't send to the lists so I quote my assumptions >>> here: >>> >>> ... >>> From your logs I only see that the make process does not find any >>> configuration, but the configuration should have been created by >>> running configure. Then it tries to call configure but doesn't succeed >>> because it says "The generated configure file contains changes not >>> present in the custom generated file." That's also strange because my >>> changesets also patch 'common/autoconf/generated- >>> configure.sh' so it should not be re-generated. And finally the build >>> fails because there's not autoconf on Windows and probably because the >>> autoconf on Mac is too old (the checked-in file is generated by >>> autoconf 2.8). >>> >>> I've just synced jdk8/jdk8 and applied the two patches. I could build >>> without any problems on MacOS X 10.8 with the following command line. >>> >>> sh /usr/work/d046063/OpenJDK/ppc-aix-port/stage/configure >>> --with-boot-jdk=/darwinintel64/output/sapjvm_7 >>> --with-target-bits=64 --with-debug-level=release >>> >>> make images LOG=debug >>> >>> Attached you can find the output I get from running configure. >>> >>> Could you please retry one more time? If you still have problems, can >>> you please run configure by hand and post the output. >>> >>> PS: I also saw from your logs that '/usr/bin/make sanity' is called. >>> This also seems strange to me because I think there aren't any sanity >>> targets any more in the new build system. Maybe you have a mismatch >>> between old and new build system? >>> ... >>> >>> Erik, could you please try this locally on Mac or Windows and post you >>> findings. Alternatively, could you please explain post the complete >>> JPRT output and explain what JPRT is trying to do. From Vladimir's log >>> snippets it's hard for me t understand the whole picture. >>> >>> Thank you and best regards, >>> Volker >>> >>>> The fix is to execute "bash common/autoconf/autogen.sh" locally and then >>>> resubmit to jprt. You need to have autoconf version 2.67 or newer >>>> installed >>>> for it to work. >>>> >>>> /Erik >>>> >>>> >>>> On 2013-07-02 05:48, Vladimir Kozlov wrote: >>>>> >>>>> >>>>> Need help from JDK build experts. >>>>> >>>>> I applied next 2 changesets: >>>>> >>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ >>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>> >>>>> and got JPRT build problems (-control build) only on MacOS and Win64: >>>>> >>>>> >>>>> >>>>> http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> macosx_x64_10.7-product (details from log file) >>>>> >>>>> ... >>>>> >>>>> Warning: The generated configure file contains changes not present in >>>>> the >>>>> custom generated file. >>>>> Running autogen.sh to correct the situation >>>>> Autoconf found: /usr/bin/autoconf >>>>> Autoconf-2.67 found: >>>>> Generating generated-configure.sh with /usr/bin/autoconf >>>>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >>>>> autom4te: /usr/bin/gm4 failed with exit status: 1 >>>>> Generating custom generated-configure.sh >>>>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > >>>>> autom4te: /usr/bin/gm4 failed with exit status: 1 >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> windows_x64_5.2-fastdebug (details from log file) >>>>> >>>>> ... >>>>> >>>>> Warning: The generated configure file contains changes not present in >>>>> the >>>>> custom generated file. >>>>> Error: Cannot continue >>>>> Cannot locate autoconf, unable to correct situation. >>>>> Please install autoconf and run 'bash autogen.sh' to update the >>>>> generated >>>>> files. >>>>> make: *** [bridge2configure] Error 1 >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> >>>>> Without these changes the output is: >>>>> >>>>> Running custom generated-configure.sh >>>>> configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. >>>>> configure: configure script generated at timestamp 1371547939. >>>>> >>>>> Thanks, >>>>> Vladimir >>>>> >>>>> On 6/28/13 12:04 AM, Volker Simonis wrote: >>>>>> >>>>>> >>>>>> Ok, that's fine. >>>>>> >>>>>> Could you please let me know when you've verified these changes. I >>>>>> will then push them to the staging repository. >>>>>> >>>>>> >>>>>> Regards, >>>>>> Volker >>>>>> >>>>>> >>>>>> On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> On 6/27/13 10:16 AM, Iris Clark wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Hi, Volker. >>>>>>>> >>>>>>>> I think that the right thing for this change [1] is for you to push >>>>>>>> into >>>>>>>> ppc-aix-port/stage once you get the necessary reviews (presumably >>>>>>>> Erik >>>>>>>> and >>>>>>>> possibly Alan). While your changeset contains some general purpose >>>>>>>> updates, >>>>>>>> it also contains PPC/AIX-specific files which can't be added to a JDK >>>>>>>> release repository until stage is pushed into the a JDK release. >>>>>>>> >>>>>>>> The recommendation to push to stage of course assumes that Vladimir >>>>>>>> doesn't think that this will adversely affect the Hotspot work >>>>>>>> already >>>>>>>> being >>>>>>>> pushed to stage. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> This should not affect Hotspot in stage repo. Me or Albert will do >>>>>>> JPRT >>>>>>> bootstrap control build of jdk with this changes to make sure it >>>>>>> works. >>>>>>> After that Volker can push it into stage. >>>>>>> >>>>>>> When I talked about pushing *general* changes into main sources I >>>>>>> meant >>>>>>> changes with no ppc64 specific code. The example of such changes was >>>>>>> recent >>>>>>> Goetz's fix for '8017531: 8010460 changes broke >>>>>>> bytecodeInterpreter.cpp'. >>>>>>> >>>>>>> Thanks, >>>>>>> Vladimir >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> iris >>>>>>>> >>>>>>>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Volker Simonis [mailto:volker.simonis at gmail.com] >>>>>>>> Sent: Thursday, June 27, 2013 9:23 AM >>>>>>>> To: Erik Joelsson >>>>>>>> Cc: Kumar Srinivasan; build-dev; ppc-aix-port-dev at openjdk.java.net; >>>>>>>> Alan >>>>>>>> Bateman >>>>>>>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) >>>>>>>> >>>>>>>> Hi Erik, >>>>>>>> >>>>>>>> we have no polices which are carved in stone:) It's all done >>>>>>>> informally >>>>>>>> and by common sense. >>>>>>>> >>>>>>>> The main reason for the ppc-aix-port/stage repository is to have a >>>>>>>> sandbox >>>>>>>> for in-depth review and testing of changes we had to make in shared >>>>>>>> code >>>>>>>> before pushing them to the main repository (and this especially >>>>>>>> applies >>>>>>>> to >>>>>>>> hotspot changes). If you feel comfortable with the current changes >>>>>>>> and >>>>>>>> don't >>>>>>>> think that they will break anything (e.g. by running tests build on >>>>>>>> your >>>>>>>> supported platforms including the closed source ones) I'd really >>>>>>>> appreciate >>>>>>>> if you could push them to the build repository. >>>>>>>> >>>>>>>> Otherwise I'll push them to the staging repository and you'll get >>>>>>>> them >>>>>>>> once we're finished with the integration of the port. >>>>>>>> >>>>>>>> Thank you and best regards, >>>>>>>> Volker >>>>>>>> >>>>>>>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson >>>>>>>> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2013-06-27 13:00, Volker Simonis wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson >>>>>>>>> >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hello Volker, >>>>>>>>>> >>>>>>>>>> I wasn't aware of this project until now. From what I (now) >>>>>>>>>> understand, generic patches can go into jdk8 repos, but port >>>>>>>>>> specific >>>>>>>>>> things need to go to staging and go in with the rest later. These >>>>>>>>>> changes contain a couple of port specific things so as it looks now >>>>>>>>>> they would need to go through staging. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Yes, that's the general approach. But I'd argue that for the most >>>>>>>>> part >>>>>>>>> this changes are generic (enable CPP-interpreter, enable CORE build, >>>>>>>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix >>>>>>>>> typos) >>>>>>>>> with only very few PPC64 specific parts (map-files and a few >>>>>>>>> defines). >>>>>>>>> The problem we want to avoid is that some of our fixes go into the >>>>>>>>> main repositories in parallel which would result in merging pain >>>>>>>>> when >>>>>>>>> integrating the staging into the main repository. >>>>>>>>> >>>>>>>>> So if you think you don't need any of the general fixes any time >>>>>>>>> soon, >>>>>>>>> I'll push the changes into the staging repository. Otherwise I think >>>>>>>>> it would be better to push them right into the main repositories. >>>>>>>>> >>>>>>>>> Several of the general fixes in there are good and I don't want to >>>>>>>>> hinder those getting in. I also don't want to break policies I'm not >>>>>>>>> familiar with. >>>>>>>>> >>>>>>>>> /Erik >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Volker >>>>>>>>> >>>>>>>>>> >>>>>>>>>> /Erik >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 2013-06-27 12:03, Volker Simonis wrote: >>>>>>>>>> >>>>>>>>>> Hi Erik, >>>>>>>>>> >>>>>>>>>> as Vladimir explained, we have a special staging repository for our >>>>>>>>>> PPC64/AIX port: >>>>>>>>>> >>>>>>>>>> I would be happy if you could push the changes right into the >>>>>>>>>> build-infra repositories and we will then get them into our staging >>>>>>>>>> repository via jdk8/jdk8. >>>>>>>>>> >>>>>>>>>> Otherwise I'll have to push them to our staging repository and >>>>>>>>>> later >>>>>>>>>> when the whole port is completed in the staging repo they will be >>>>>>>>>> bulk-integrated into jdk8. >>>>>>>>>> >>>>>>>>>> What do you think? >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Volker >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Erik, >>>>>>>>>>> >>>>>>>>>>> We have special staging forest for PPC64/AIX port: >>>>>>>>>>> >>>>>>>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage >>>>>>>>>>> >>>>>>>>>>> We collect Hotspot and JDK changes there for testing before >>>>>>>>>>> pushing >>>>>>>>>>> into main sources in a future. But some general fixes we push >>>>>>>>>>> directly into our main sources. >>>>>>>>>>> If you think these build changes are acceptable for main, please, >>>>>>>>>>> ask someone sponsor these changes. >>>>>>>>>>> >>>>>>>>>>> Alan is our official contact for PPC64/AIX project. I CC him. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Vladimir >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Hello, >>>>>>>>>>>> >>>>>>>>>>>> If you by staging area mean the build-infra forest, that's more >>>>>>>>>>>> or >>>>>>>>>>>> less dead now. >>>>>>>>>>>> >>>>>>>>>>>> I think these changes look good now (both top level and jdk). It >>>>>>>>>>>> should be fine to push this to jdk8/build. >>>>>>>>>>>> >>>>>>>>>>>> /Erik >>>>>>>>>>>> >>>>>>>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Erik, >>>>>>>>>>>>> >>>>>>>>>>>>> thank you for looking at this. I've prepared a new webrev at: >>>>>>>>>>>>> >>>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> What do you think, do you want to push this directly into the >>>>>>>>>>>>> build repositories or should I push it into the staging >>>>>>>>>>>>> repository >>>>>>>>>>>>> first? >>>>>>>>>>>>> >>>>>>>>>>>>> Please see my further comments inline. >>>>>>>>>>>>> >>>>>>>>>>>>> Thank you and best regards, >>>>>>>>>>>>> Volker >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson >>>>>>>>>>>>> > >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hello Volker, >>>>>>>>>>>>> >>>>>>>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> could somebody please review the following change >>>>>>>>>>>>> and >>>>>>>>>>>>> create an appropriate >>>>>>>>>>>>> Bug ID for it: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> < http://cr.openjdk.java.net/%7Esimonis/webrevs/linux_ppc_build_jdk >>>>>>>>>>>>> /> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> The patch contains two little changes which are >>>>>>>>>>>>> required >>>>>>>>>>>>> to build the class >>>>>>>>>>>>> library part of the OpenJDK on Linux/PPC64. Most >>>>>>>>>>>>> of >>>>>>>>>>>>> the >>>>>>>>>>>>> build magic is >>>>>>>>>>>>> contained in the top-level part of this change >>>>>>>>>>>>> which >>>>>>>>>>>>> is >>>>>>>>>>>>> separately reviewed >>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> < http://cr.openjdk.java.net/%7Esimonis/webrevs/linux_ppc_build_top >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> CompileLaunchers.gmk >>>>>>>>>>>>> >>>>>>>>>>>>> Remove mapfile from build instructions of >>>>>>>>>>>>> BUILD_UNPACKEXE: >>>>>>>>>>>>> >>>>>>>>>>>>> CFLAGS_macosx:=-fPIC, \ >>>>>>>>>>>>> - >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ >>>>>>>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ >>>>>>>>>>>>> >>>>>>>>>>>>> I think it makes no sense to use a version >>>>>>>>>>>>> script >>>>>>>>>>>>> file >>>>>>>>>>>>> for an executable >>>>>>>>>>>>> and older linkers (e.g. on SLES 10) complain >>>>>>>>>>>>> with: >>>>>>>>>>>>> "*Invalid version tag >>>>>>>>>>>>> `SUNWprivate_1.1'. Only anonymous version tag is >>>>>>>>>>>>> allowed >>>>>>>>>>>>> in executable.*" >>>>>>>>>>>>> The GNU ld >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> manual< http://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_25.html>states: >>>>>>>>>>>>> "*Version scripts are only meaningful when >>>>>>>>>>>>> creating >>>>>>>>>>>>> shared >>>>>>>>>>>>> libraries.*" >>>>>>>>>>>>> Morover unpack200 was the only executable which >>>>>>>>>>>>> used >>>>>>>>>>>>> a >>>>>>>>>>>>> version script file. >>>>>>>>>>>>> >>>>>>>>>>>>> Unpackexe has some weirdness and this isn't >>>>>>>>>>>>> surprising >>>>>>>>>>>>> me. >>>>>>>>>>>>> Would be good if someone with more historic knowledge >>>>>>>>>>>>> could >>>>>>>>>>>>> fill in on the reason for this. Someone apparently >>>>>>>>>>>>> went >>>>>>>>>>>>> through the trouble of creating a special mapfile for >>>>>>>>>>>>> this >>>>>>>>>>>>> executable. Also, if not using it, should it be >>>>>>>>>>>>> removed? >>>>>>>>>>>>> >>>>>>>>>>>>> I looked closer at this. These mapfiles were explicitly >>>>>>>>>>>>> added in >>>>>>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it >>>>>>>>>>>>> was >>>>>>>>>>>>> noted >>>>>>>>>>>>> that it broke builds for architectures that didn't have >>>>>>>>>>>>> mapfiles >>>>>>>>>>>>> defined. If you look at the launchers, the mapfile is >>>>>>>>>>>>> only >>>>>>>>>>>>> set >>>>>>>>>>>>> if >>>>>>>>>>>>> the arch specific one exists. I think a safer change here >>>>>>>>>>>>> would >>>>>>>>>>>>> be >>>>>>>>>>>>> to make the mapfile conditional on platform or arch for >>>>>>>>>>>>> unpackexe. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> I still do not fully understand why we need map-files for >>>>>>>>>>>>> executables, but I also understand that you don't want to change >>>>>>>>>>>>> the >>>>>>>>>>>>> current setup. >>>>>>>>>>>>> So I went the hard (and hopefully right:) way and implemented a >>>>>>>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on >>>>>>>>>>>>> SLES >>>>>>>>>>>>> 10) which complain with: "Invalid version tag `SUNWprivate_1.1' >>>>>>>>>>>>> during the configure step (see top-level change). Unfortunately >>>>>>>>>>>>> we >>>>>>>>>>>>> still have quite a lot of these systems so we really need the >>>>>>>>>>>>> build with that buggy ld. >>>>>>>>>>>>> >>>>>>>>>>>>> I've therefore added map files with anonymous version tags for >>>>>>>>>>>>> these buggy linkers which are only used if the buggy linker was >>>>>>>>>>>>> detected during the configure step (i.e. if >>>>>>>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 specific >>>>>>>>>>>>> problem but a occurs on all SuSE 10 platforms. >>>>>>>>>>>>> >>>>>>>>>>>>> And you've been right. I also had to add the arch specific map >>>>>>>>>>>>> files for ppc64 in order to use them for the other launchers. >>>>>>>>>>>>> >>>>>>>>>>>>> Kumar, you made the change referred to here, do you have >>>>>>>>>>>>> anything >>>>>>>>>>>>> to add? >>>>>>>>>>>>> >>>>>>>>>>>>> /Erik >>>>>>>>>>>>> >>>>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>>>>> >>>>>>>>>>>>> default: all >>>>>>>>>>>>> >>>>>>>>>>>>> CompileNativeLibraries.gmk >>>>>>>>>>>>> >>>>>>>>>>>>> Only use $(OPENWIN_LIB) for linking >>>>>>>>>>>>> LIBSPLASHSCREEN >>>>>>>>>>>>> on >>>>>>>>>>>>> Solaris! The old >>>>>>>>>>>>> code worked only accidentally when the >>>>>>>>>>>>> X-libraries >>>>>>>>>>>>> are >>>>>>>>>>>>> in >>>>>>>>>>>>> the default >>>>>>>>>>>>> linker path anyway. The right solution is to use >>>>>>>>>>>>> $(X_LIBS) >>>>>>>>>>>>> if not on >>>>>>>>>>>>> Windows or Solaris. >>>>>>>>>>>>> >>>>>>>>>>>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on >>>>>>>>>>>>> PPC64. >>>>>>>>>>>>> The value of >>>>>>>>>>>>> X_ARCHisn't actually used on the PPC >>>>>>>>>>>>> architectures, >>>>>>>>>>>>> but >>>>>>>>>>>>> there's a >>>>>>>>>>>>> check to verify >>>>>>>>>>>>> that it is set. >>>>>>>>>>>>> >>>>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') >>>>>>>>>>>>> >>>>>>>>>>>>> default: all >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Otherwise looks good. >>>>>>>>>>>>> >>>>>>>>>>>>> /Erik >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>> >>> >> From erik.joelsson at oracle.com Tue Jul 2 08:54:52 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 02 Jul 2013 10:54:52 +0200 Subject: RFR: 8019537: jdk8-build prebuild fails in source bundle generation, The path of TOOLS_DIR ... is not found Message-ID: <51D2955C.7000307@oracle.com> Please review this fix for the --with-tools-dir configure parameter. In "8017047: Can't use --with-java-devtools and --with-devkit at the same time", I carelessly added BASIC_FIXUP_PATH to both --with-tools-dir and --with-devkit, with the intention of adding support for relative paths. This doesn't work for --with-tools-dir however, since this parameter is supposed to handle a colon separated path string, containing multiple paths. This fix removes that call, restoring the old functionality of --with-tools-dir. http://cr.openjdk.java.net/~erikj/8019537/webrev.root.01/ /Erik From tim.bell at oracle.com Tue Jul 2 12:10:25 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 02 Jul 2013 05:10:25 -0700 Subject: RFR: 8019537: jdk8-build prebuild fails in source bundle generation, The path of TOOLS_DIR ... is not found In-Reply-To: <51D2955C.7000307@oracle.com> References: <51D2955C.7000307@oracle.com> Message-ID: <51D2C331.5090404@oracle.com> Hi Erik: > Please review this fix for the --with-tools-dir configure parameter. > In "8017047: Can't use --with-java-devtools and --with-devkit at the > same time", I carelessly added BASIC_FIXUP_PATH to both > --with-tools-dir and --with-devkit, with the intention of adding > support for relative paths. This doesn't work for --with-tools-dir > however, since this parameter is supposed to handle a colon separated > path string, containing multiple paths. This fix removes that call, > restoring the old functionality of --with-tools-dir. > > http://cr.openjdk.java.net/~erikj/8019537/webrev.root.01 Looks good to me. Tim From tao.mao at oracle.com Tue Jul 2 15:10:24 2013 From: tao.mao at oracle.com (Tao Mao) Date: Tue, 02 Jul 2013 08:10:24 -0700 Subject: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit In-Reply-To: <51D1E400.6020100@oracle.com> References: <51D1E400.6020100@oracle.com> Message-ID: <51D2ED60.9000403@oracle.com> The format of passing cxxflag to a specific file is different in hsx24 than in hsx25. I've changed the setting accordingly in order to pass through the compilation. Please review the new webrev below and ignore webrev.00. hsx24 webrev: http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ (original) hsx25 webrev: http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ Test: Builds were tested on Linux-i586, Solaris-i586, and Solaris-sparc. Builds were successful and they all passed test of the gc-log size limit of 2G. Passed JPRT. Thanks. Tao On 7/1/13 1:18 PM, Tao Mao wrote: > The hsx25 fix has been pushed already. Then I got the > 7u40-critical-approved. > > When I tried backporting to hsx24, it didn't apply to the hsx24 repo > cleanly. Thus, I made the patch manually (copy-and-paste style) and > now need some quick reviews to get it in since it's 7u40 related P3 CR. > > hsx24 webrev: > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ > > (original) hsx25 webrev: > http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ > > Thanks. > Tao From david.katleman at oracle.com Tue Jul 2 16:58:54 2013 From: david.katleman at oracle.com (David (Oracle) Katleman) Date: Tue, 2 Jul 2013 09:58:54 -0700 Subject: RFR: 8019537: jdk8-build prebuild fails in source bundle generation, The path of TOOLS_DIR ... is not found In-Reply-To: <51D2955C.7000307@oracle.com> References: <51D2955C.7000307@oracle.com> Message-ID: On Jul 2, 2013, at 1:54 AM, Erik Joelsson wrote: > Please review this fix for the --with-tools-dir configure parameter. In "8017047: Can't use --with-java-devtools and --with-devkit at the same time", I carelessly added BASIC_FIXUP_PATH to both --with-tools-dir and --with-devkit, with the intention of adding support for relative paths. This doesn't work for --with-tools-dir however, since this parameter is supposed to handle a colon separated path string, containing multiple paths. This fix removes that call, restoring the old functionality of --with-tools-dir. > > http://cr.openjdk.java.net/~erikj/8019537/webrev.root.01/ Fix looks correct, approved. Let me know when you've integrated and I'll restart the build forest build. Thanks Dave From erik.joelsson at oracle.com Tue Jul 2 18:24:47 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Tue, 02 Jul 2013 18:24:47 +0000 Subject: hg: jdk8/build: 8019537: jdk8-build prebuild fails in source bundle generation, The path of TOOLS_DIR ... is not found Message-ID: <20130702182448.5813C48711@hg.openjdk.java.net> Changeset: b2b87e9e8683 Author: erikj Date: 2013-07-02 15:07 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/b2b87e9e8683 8019537: jdk8-build prebuild fails in source bundle generation, The path of TOOLS_DIR ... is not found Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh From John.Coomes at oracle.com Tue Jul 2 20:28:41 2013 From: John.Coomes at oracle.com (John Coomes) Date: Tue, 2 Jul 2013 13:28:41 -0700 Subject: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit In-Reply-To: <51D1E400.6020100@oracle.com> References: <51D1E400.6020100@oracle.com> Message-ID: <20947.14329.880601.703384@oracle.com> Tao Mao (tao.mao at oracle.com) wrote: > The hsx25 fix has been pushed already. Then I got the > 7u40-critical-approved. > > When I tried backporting to hsx24, it didn't apply to the hsx24 repo > cleanly. Thus, I made the patch manually (copy-and-paste style) and now > need some quick reviews to get it in since it's 7u40 related P3 CR. > > hsx24 webrev: > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ > > (original) hsx25 webrev: > http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ This looks good to me. -John From daniel.daugherty at oracle.com Tue Jul 2 20:32:18 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 02 Jul 2013 14:32:18 -0600 Subject: Fwd: Re: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit In-Reply-To: <51D284DB.5080107@oracle.com> References: <51D26DBA.8010309@oracle.com> <51D284DB.5080107@oracle.com> Message-ID: <51D338D2.9020609@oracle.com> Adding hotspot-runtime-dev at openjdk.java.net to this thread... > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ make/linux/makefiles/vm.make No comments. make/solaris/makefiles/vm.make No comments. src/os/solaris/vm/os_solaris.inline.hpp No comments. Also compared the two patch files: 7122222GCLogLimitedTo2GFor32Bit_hsx24.patch 7122222GCLogLimitedTo2GFor32Bit.patch In HSX-25, the Makefile construct looks like: CXXFLAGS/ostream.o += -D_FILE_OFFSET_BITS=64 In HSX-24, the Makefile construct looks like: ostream.o: CXXFLAGS += -D_FILE_OFFSET_BITS=64 which threw me for a loop for a minute... I realized that your construct matches the existing rules for vm_version.o in each release so I think the HSX-24 backport is good. Hopefully, you double checked builds logs on both Linux and Solaris and made sure that '-D_FILE_OFFSET_BITS=64' is only passed where you expect it. Thumbs up! Dan > -------- Original Message -------- > Subject: Re: hsx24 backport: Request for review: 7122222: GC log is > limited to 2G for 32-bit > Date: Mon, 01 Jul 2013 23:05:46 -0700 > From: Tao Mao > Organization: Oracle Corporation > To: hotspot-gc-dev at openjdk.java.net > , build-dev at openjdk.java.net > > > > The format of passing cxxflag to a specific file is different in hsx24 > than in hsx25. I've changed the setting accordingly in order to pass > through the compilation. > > Please review the new webrev below and ignore webrev.00. > > hsx24 webrev: > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ > > (original) hsx25 webrev: > http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ > > Test: > Builds were tested on Linux-i586, Solaris-i586, and Solaris-sparc. > Builds were successful and they all passed test of the gc-log size limit > of 2G. > > Thanks. > Tao > > On 7/1/13 1:18 PM, Tao Mao wrote: > > The hsx25 fix has been pushed already. Then I got the > > 7u40-critical-approved. > > > > When I tried backporting to hsx24, it didn't apply to the hsx24 repo > > cleanly. Thus, I made the patch manually (copy-and-paste style) and > > now need some quick reviews to get it in since it's 7u40 related P3 CR. > > > > hsx24 webrev: > >http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ > > > > (original) hsx25 webrev: > >http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ > > > > Thanks. > > Tao > > From tao.mao at oracle.com Tue Jul 2 21:09:13 2013 From: tao.mao at oracle.com (Tao Mao) Date: Tue, 02 Jul 2013 14:09:13 -0700 Subject: Fwd: Re: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit In-Reply-To: <51D338D2.9020609@oracle.com> References: <51D26DBA.8010309@oracle.com> <51D284DB.5080107@oracle.com> <51D338D2.9020609@oracle.com> Message-ID: <51D34179.7000300@oracle.com> Thank you for review, Dan. Tao On 7/2/13 1:32 PM, Daniel D. Daugherty wrote: > Adding hotspot-runtime-dev at openjdk.java.net to this thread... > > > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ > > make/linux/makefiles/vm.make > No comments. > > make/solaris/makefiles/vm.make > No comments. > > src/os/solaris/vm/os_solaris.inline.hpp > No comments. > > Also compared the two patch files: > 7122222GCLogLimitedTo2GFor32Bit_hsx24.patch > 7122222GCLogLimitedTo2GFor32Bit.patch > > In HSX-25, the Makefile construct looks like: > > CXXFLAGS/ostream.o += -D_FILE_OFFSET_BITS=64 > > In HSX-24, the Makefile construct looks like: > > ostream.o: CXXFLAGS += -D_FILE_OFFSET_BITS=64 > > which threw me for a loop for a minute... I realized that > your construct matches the existing rules for vm_version.o > in each release so I think the HSX-24 backport is good. I should've mentioned the point that I just would like to keep consistency with the existing way of passing cxxflag to vm_version.o in order to make the changeset simple to come up. > > Hopefully, you double checked builds logs on both Linux > and Solaris and made sure that '-D_FILE_OFFSET_BITS=64' > is only passed where you expect it. Yes, it is only passed "-D_FILE_OFFSET_BITS=64" to ostream.o As I mentioned, the changeset passed JPRT. Also, I manually tested whether the change would solve the CR's problem as expected. It's doing its right job on Linux-i586, Solaris-i586 and Solaris-sparc. > > Thumbs up! > > Dan > > >> -------- Original Message -------- >> Subject: Re: hsx24 backport: Request for review: 7122222: GC log is >> limited to 2G for 32-bit >> Date: Mon, 01 Jul 2013 23:05:46 -0700 >> From: Tao Mao >> Organization: Oracle Corporation >> To: hotspot-gc-dev at openjdk.java.net >> , build-dev at openjdk.java.net >> >> >> >> The format of passing cxxflag to a specific file is different in hsx24 >> than in hsx25. I've changed the setting accordingly in order to pass >> through the compilation. >> >> Please review the new webrev below and ignore webrev.00. >> >> hsx24 webrev: >> http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ >> >> (original) hsx25 webrev: >> http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ >> >> Test: >> Builds were tested on Linux-i586, Solaris-i586, and Solaris-sparc. >> Builds were successful and they all passed test of the gc-log size limit >> of 2G. >> >> Thanks. >> Tao >> >> On 7/1/13 1:18 PM, Tao Mao wrote: >> > The hsx25 fix has been pushed already. Then I got the >> > 7u40-critical-approved. >> > >> > When I tried backporting to hsx24, it didn't apply to the hsx24 repo >> > cleanly. Thus, I made the patch manually (copy-and-paste style) and >> > now need some quick reviews to get it in since it's 7u40 related P3 CR. >> > >> > hsx24 webrev: >> > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ >> > >> > (original) hsx25 webrev: >> > http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ >> > >> > Thanks. >> > Tao >> >> > From tim.bell at oracle.com Tue Jul 2 22:41:07 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 02 Jul 2013 15:41:07 -0700 Subject: Fwd: Re: hsx24 backport: Request for review: 7122222: GC log is limited to 2G for 32-bit In-Reply-To: <51D34179.7000300@oracle.com> References: <51D26DBA.8010309@oracle.com> <51D284DB.5080107@oracle.com> <51D338D2.9020609@oracle.com> <51D34179.7000300@oracle.com> Message-ID: <51D35703.7080605@oracle.com> Looks good to me as well. Tim On 07/ 2/13 02:09 PM, Tao Mao wrote: > Thank you for review, Dan. > > Tao > > On 7/2/13 1:32 PM, Daniel D. Daugherty wrote: >> Adding hotspot-runtime-dev at openjdk.java.net to this thread... >> >> > http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ >> >> make/linux/makefiles/vm.make >> No comments. >> >> make/solaris/makefiles/vm.make >> No comments. >> >> src/os/solaris/vm/os_solaris.inline.hpp >> No comments. >> >> Also compared the two patch files: >> 7122222GCLogLimitedTo2GFor32Bit_hsx24.patch >> 7122222GCLogLimitedTo2GFor32Bit.patch >> >> In HSX-25, the Makefile construct looks like: >> >> CXXFLAGS/ostream.o += -D_FILE_OFFSET_BITS=64 >> >> In HSX-24, the Makefile construct looks like: >> >> ostream.o: CXXFLAGS += -D_FILE_OFFSET_BITS=64 >> >> which threw me for a loop for a minute... I realized that >> your construct matches the existing rules for vm_version.o >> in each release so I think the HSX-24 backport is good. > I should've mentioned the point that I just would like to keep > consistency with the existing way of passing cxxflag to vm_version.o > in order to make the changeset simple to come up. >> >> Hopefully, you double checked builds logs on both Linux >> and Solaris and made sure that '-D_FILE_OFFSET_BITS=64' >> is only passed where you expect it. > Yes, it is only passed "-D_FILE_OFFSET_BITS=64" to ostream.o > > As I mentioned, the changeset passed JPRT. > > Also, I manually tested whether the change would solve the CR's > problem as expected. It's doing its right job on Linux-i586, > Solaris-i586 and Solaris-sparc. >> >> Thumbs up! >> >> Dan >> >> >>> -------- Original Message -------- >>> Subject: Re: hsx24 backport: Request for review: 7122222: GC log is >>> limited to 2G for 32-bit >>> Date: Mon, 01 Jul 2013 23:05:46 -0700 >>> From: Tao Mao >>> Organization: Oracle Corporation >>> To: hotspot-gc-dev at openjdk.java.net >>> , build-dev at openjdk.java.net >>> >>> >>> >>> The format of passing cxxflag to a specific file is different in hsx24 >>> than in hsx25. I've changed the setting accordingly in order to pass >>> through the compilation. >>> >>> Please review the new webrev below and ignore webrev.00. >>> >>> hsx24 webrev: >>> http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.01/ >>> >>> (original) hsx25 webrev: >>> http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ >>> >>> Test: >>> Builds were tested on Linux-i586, Solaris-i586, and Solaris-sparc. >>> Builds were successful and they all passed test of the gc-log size limit >>> of 2G. >>> >>> Thanks. >>> Tao >>> >>> On 7/1/13 1:18 PM, Tao Mao wrote: >>> > The hsx25 fix has been pushed already. Then I got the >>> > 7u40-critical-approved. >>> > >>> > When I tried backporting to hsx24, it didn't apply to the hsx24 repo >>> > cleanly. Thus, I made the patch manually (copy-and-paste style) and >>> > now need some quick reviews to get it in since it's 7u40 related P3 CR. >>> > >>> > hsx24 webrev: >>> >http://cr.openjdk.java.net/~tamao/7122222_hsx24/webrev.00/ >>> > >>> > (original) hsx25 webrev: >>> >http://cr.openjdk.java.net/~tamao/7122222/webrev.00/ >>> > >>> > Thanks. >>> > Tao >>> >>> >> From david.katleman at oracle.com Tue Jul 2 22:57:16 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 22:57:16 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b96 for changeset 3357c2776431 Message-ID: <20130702225717.86C114872C@hg.openjdk.java.net> Changeset: 469995a8e974 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/469995a8e974 Added tag jdk8-b96 for changeset 3357c2776431 ! .hgtags From david.katleman at oracle.com Tue Jul 2 22:57:51 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 22:57:51 +0000 Subject: hg: jdk8/build/hotspot: 26 new changesets Message-ID: <20130702225844.26B874872D@hg.openjdk.java.net> Changeset: b6d1e42655cd Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b6d1e42655cd Added tag jdk8-b96 for changeset e6a4b8c71fa6 ! .hgtags Changeset: fc8a1a5de78e Author: amurillo Date: 2013-06-21 00:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fc8a1a5de78e 8017253: new hotspot build - hs25-b39 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 91acb82a8b7a Author: dholmes Date: 2013-06-19 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/91acb82a8b7a 8014326: [OSX] All libjvm symbols are exported Summary: Add support for a MacOS X compatible form of the libjvm mapfile. Reviewed-by: dcubed, rdurbin, coleenp ! make/bsd/makefiles/build_vm_def.sh ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product Changeset: b9f4c4ec0f50 Author: iklam Date: 2013-06-19 20:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b9f4c4ec0f50 8008964: NPG: Memory regression: Thread::_metadata_handles uses 1 KB per thread. Summary: Reduce default size of Thread::_metadata_handles from 300 to 30 Reviewed-by: coleenp, sspitsyn ! src/share/vm/runtime/thread.cpp Changeset: b3cd8b58b798 Author: mgronlun Date: 2013-06-20 11:53 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b3cd8b58b798 8016735: Remove superfluous EnableInvokeDynamic warning from UnlockDiagnosticVMOptions check Reviewed-by: sla, dholmes ! src/share/vm/runtime/globals.cpp Changeset: 9ba41a4a71ff Author: coleenp Date: 2013-06-21 10:50 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9ba41a4a71ff 8004124: Handle and/or warn about SI_KERNEL Summary: Detect this crash in the signal handler and give a fatal error message instead of making us chase down bugs that don't reproduce Reviewed-by: kvn, mgerdin, dholmes ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: bed34a7a3b9b Author: coleenp Date: 2013-06-21 10:57 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bed34a7a3b9b 8017177: more explicit code location information in hs_err crash log Summary: Add code pc location for compiled code Reviewed-by: kvn, coleenp Contributed-by: doug.simon at oracle.com ! src/share/vm/runtime/frame.cpp Changeset: bb6c7f2f10fd Author: dcubed Date: 2013-06-21 08:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bb6c7f2f10fd Merge Changeset: b7bc7c94b4b5 Author: dcubed Date: 2013-06-21 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b7bc7c94b4b5 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp Changeset: d9eed26d638a Author: iklam Date: 2013-06-23 22:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d9eed26d638a 8009575: Reduce Symbol::_refcount from 4 bytes to 2 bytes Summary: Added Atomic::inc(short*) to support this change. Reviewed-by: coleenp, dcubed, dholmes, minqi ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: e0c9a1d29eb4 Author: coleenp Date: 2013-06-24 18:55 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e0c9a1d29eb4 8016325: JVM hangs verifying system dictionary Summary: Minimize redundant verifications of Klasses. Reviewed-by: hseigel, jmasa ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/code/debugInfo.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/shark/sharkBuilder.cpp Changeset: 01e10b366055 Author: sla Date: 2013-06-25 14:11 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/01e10b366055 8017561: Build errors caused by missing .PHONY Reviewed-by: stefank, brutisso ! make/excludeSrc.make Changeset: feae15578b2f Author: tamao Date: 2013-06-07 09:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/feae15578b2f 7122222: GC log is limited to 2G for 32-bit Summary: Enable large file support for generated 32-bit ostream.o on Linux and Solaris (as only the two need this) by setting -D_FILE_OFFSET_BITS=64 in compilation Reviewed-by: tbell, mgerdin, dcubed Contributed-by: tamao ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make ! src/os/solaris/vm/os_solaris.inline.hpp Changeset: df7e1c0e3dc1 Author: jmasa Date: 2013-06-25 09:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/df7e1c0e3dc1 8014546: MetaspaceAux print_metaspace_change() should print "used" after GC not capacity Reviewed-by: johnc, tschatzl ! src/share/vm/memory/metaspace.cpp Changeset: f99cd6e20ab1 Author: jmasa Date: 2013-06-25 15:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f99cd6e20ab1 8014851: UseAdaptiveGCBoundary is broken Reviewed-by: tschatzl, brutisso ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp + test/gc/parallelScavenge/AdaptiveGCBoundary.java Changeset: 71963b3f802a Author: ehelin Date: 2013-06-26 16:58 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/71963b3f802a 8013590: NPG: Add a memory pool MXBean for Metaspace Reviewed-by: jmasa, mgerdin ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryService.cpp ! src/share/vm/services/memoryService.hpp + test/gc/metaspace/TestMetaspaceMemoryPool.java Changeset: f8972b867ded Author: ehelin Date: 2013-06-27 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f8972b867ded Merge Changeset: 7875ea94bea5 Author: goetz Date: 2013-06-24 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7875ea94bea5 8017308: Remove unused breakpoint relocation type Summary: remove unused breakpoint relocation type Reviewed-by: kvn ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/zero/vm/relocInfo_zero.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/relocInfo.hpp Changeset: cc63bcb47cce Author: twisti Date: 2013-06-24 17:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cc63bcb47cce 8017538: Clang support broke slowdebug build for i586 Reviewed-by: kvn ! make/linux/makefiles/gcc.make Changeset: a023da4ffc15 Author: twisti Date: 2013-06-24 18:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a023da4ffc15 Merge Changeset: 3aa636f2a743 Author: adlertz Date: 2013-06-25 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3aa636f2a743 8017243: 8001345 is incomplete Summary: Replaces unused decodeN at MemBarAcquire with its corresponding loadN if loadN is used at more than one place. Reviewed-by: kvn, twisti ! src/share/vm/opto/memnode.cpp Changeset: 9347cae673f0 Author: adlertz Date: 2013-06-26 00:40 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9347cae673f0 8017510: Add a regression test for 8005956 Summary: Regression test for 8005956 Reviewed-by: kvn, twisti + test/compiler/8005956/PolynomialRoot.java Changeset: 6a0ead6dc6db Author: goetz Date: 2013-06-24 16:11 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6a0ead6dc6db 8017531: 8010460 changes broke bytecodeInterpreter.cpp Summary: Replace _indy by _jsr292 and also fix VERIFY_OOP macros. Reviewed-by: kvn ! src/share/vm/interpreter/bytecodeInterpreter.cpp Changeset: be0600ec1102 Author: kvn Date: 2013-06-27 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/be0600ec1102 Merge Changeset: 2b9380b0bf0b Author: amurillo Date: 2013-06-28 02:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2b9380b0bf0b Merge ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp Changeset: d197d377ab2e Author: amurillo Date: 2013-06-28 02:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d197d377ab2e Added tag hs25-b39 for changeset 2b9380b0bf0b ! .hgtags From david.katleman at oracle.com Tue Jul 2 23:00:16 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 23:00:16 +0000 Subject: hg: jdk8/build/jaxp: 2 new changesets Message-ID: <20130702230021.BE0ED4872E@hg.openjdk.java.net> Changeset: 403f882ecc94 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/403f882ecc94 Added tag jdk8-b96 for changeset 6121efd29923 ! .hgtags Changeset: 6c830db28d21 Author: katleman Date: 2013-07-02 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/6c830db28d21 Merge From david.katleman at oracle.com Tue Jul 2 23:00:26 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 23:00:26 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b96 for changeset 690d34b326bc Message-ID: <20130702230030.07AB84872F@hg.openjdk.java.net> Changeset: dcde7f049111 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/dcde7f049111 Added tag jdk8-b96 for changeset 690d34b326bc ! .hgtags From david.katleman at oracle.com Tue Jul 2 23:00:39 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 23:00:39 +0000 Subject: hg: jdk8/build/jdk: 3 new changesets Message-ID: <20130702230145.F410E48730@hg.openjdk.java.net> Changeset: 2f1386fc2079 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2f1386fc2079 Added tag jdk8-b96 for changeset 4a5d3cf2b3af ! .hgtags Changeset: 8339c83b16c6 Author: ehelin Date: 2013-07-02 13:06 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8339c83b16c6 8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration Reviewed-by: erikj, alanb ! test/ProblemList.txt Changeset: 978a95239044 Author: katleman Date: 2013-07-02 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/978a95239044 Merge From david.katleman at oracle.com Tue Jul 2 23:02:53 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 23:02:53 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b96 for changeset 988aef3a8c3a Message-ID: <20130702230258.E7ABB48733@hg.openjdk.java.net> Changeset: 6a11a81a8824 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6a11a81a8824 Added tag jdk8-b96 for changeset 988aef3a8c3a ! .hgtags From david.katleman at oracle.com Tue Jul 2 23:03:03 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 23:03:03 +0000 Subject: hg: jdk8/build/nashorn: Added tag jdk8-b96 for changeset d6bd440ac5b9 Message-ID: <20130702230305.6C03448734@hg.openjdk.java.net> Changeset: 1bf1d6ce3042 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/1bf1d6ce3042 Added tag jdk8-b96 for changeset d6bd440ac5b9 ! .hgtags From david.katleman at oracle.com Tue Jul 2 22:57:12 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 02 Jul 2013 22:57:12 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20130702225713.1266D4872A@hg.openjdk.java.net> Changeset: 4c363b94ea2a Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/4c363b94ea2a Added tag jdk8-b96 for changeset c156084add48 ! .hgtags Changeset: a1c1e8bf71f3 Author: katleman Date: 2013-07-02 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/a1c1e8bf71f3 Merge From vladimir.kozlov at oracle.com Wed Jul 3 00:37:12 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 02 Jul 2013 17:37:12 -0700 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> <51CB0F42.5020604@oracle.com> <51CB1C80.9090305@oracle.com> <51CC10E7.5000903@oracle.com> <51CC274E.7050401@oracle.com> <4f66ed63-fb17-429e-893c-ea1497cbc6b6@default> <51CC77CF.9010108@oracle.com> <51D24D95.7050207@oracle.com> <51D27E30.2010002@oracle.com> <51D287B2.7080201@oracle.com> Message-ID: <51D37238.2040509@oracle.com> Running autogen.sh in top directory updates both files: $ bash common/autoconf/autogen.sh Autoconf found: /usr/local/bin/autoconf Autoconf-2.67 found: Generating generated-configure.sh with /usr/local/bin/autoconf Generating custom generated-configure.sh Test builds are running (and already passed on MacOS and Linux) so I think the problem is solved. Thank you, Erik and Volker. I will push (since we need to push closed part too) changesets into ppc-aix-port/stage repository with Erik as reviewer. Thanks, Vladimir On 7/2/13 1:54 AM, Volker Simonis wrote: > Ah, now I got it! > > The problem is with your closed sources which also have their own > closed, autoconf-generated config file which has to be recreated after > the OpenJDK autoconf-generated configure files changes. > > The warning "Warning: The generated configure file contains changes not > present in the custom generated file." from 'common/autoconf/configure:' > actually checks exactly that: > > if test -e $conf_custom_script_dir/generated-configure.sh; then > # Test if open configure is newer than custom configure, if so, > custom needs to > # be regenerated. This test is required to ensure consistency with > custom source. > conf_open_configure_timestamp=`grep DATE_WHEN_GENERATED= > $conf_script_dir/generated-configure.sh | cut -d"=" -f 2` > conf_custom_configure_timestamp=`grep DATE_WHEN_GENERATED= > $conf_custom_script_dir/generated-configure.sh | cut -d"=" -f 2` > if test $conf_open_configure_timestamp -gt > $conf_custom_configure_timestamp; then > echo "Warning: The generated configure file contains changes not > present in the custom generated file." > run_autogen_or_fail > fi > fi > > I obviously can not fix that:) > > But if you've already done a successful build on any other platform, you > can just copy the generated > '$conf_custom_script_dir/generated-configure.sh' from that build into > you workspace and that should do the job! > > Very nasty Closedsource/JPRT problems:( When will we finally overcome > this mess... > > Regards, > Volker > > On Tue, Jul 2, 2013 at 10:42 AM, Volker Simonis > > wrote: > > On Tue, Jul 2, 2013 at 9:56 AM, Vladimir Kozlov > > > wrote: > >> JPRT uses own target to build forest: > >> > >> jprt_build_product: sanity all_product_build > >> > >> > http://hg.openjdk.java.net/ppc-aix-port/stage/file/c156084add48/make/jprt.gmk > >> > >> That is why 'make sanity' is called I think. > >> > >> Note the next warning was present in JPRT logs on all platforms: > >> > >> Warning: The generated configure file contains changes not present > in the > >> custom generated file. > >> > >> I verified that submitted source > common/autoconf/generated-configure.sh is > >> matching file in stage repo plus changes from patch. > >> > >> Hmm, may be the problem is next change in generated-configure.sh: > >> > >> -DATE_WHEN_GENERATED=1371547824 > >> +DATE_WHEN_GENERATED=1372238067 > >> > >> It is date when Volker generated generated-configure.sh but the date of > >> changed .m4 files is when I applied patch which is later. It looks > like I > >> need to regenerate generated-configure.sh file myself as Erik said. > I will > >> give it a try tomorrow. > >> > > > > I doubt that that's the only reason, because I did exactly the same > > yesterday on MacOS without these problems: > > - clone jdk8/jdk8 > > - import the patches into the base and jdk repositroy > > - configure > > - make > > > > Is there a way I can simulate a JPRT build? > > If I just call 'make jprt_build_product' in the build directory where > > I have previously called 'configure' it fails because it wants to call > > configure again and doesn't find it. > > So from which directory am I supposed to start a JPRT build and which > > parameters should I pass to it? > > > >> Vladimir > >> > >> > >> On 7/2/13 12:31 AM, Volker Simonis wrote: > >>> > >>> Hi Erik, > >>> > >>> thank you for looking into this. > >>> > >>> On Tue, Jul 2, 2013 at 9:16 AM, Erik Joelsson > > > >>> wrote: > >>>> > >>>> This looks like you have applied a change to configure input files > (*.m4) > >>>> and haven't regenerated configure locally afterwards. The JPRT > machines > >>>> don't have autoconf setup so they can't do it. In this case it > looks like > >>>> one of them, probably the mac, has a faulty version of autoconf > that gets > >>>> picked up. I have seen this happen before on mac. > >>>> > >>> > >>> Actually, that was my guess as well. On the other hand that's still > >>> strange, because my patch also contains an updated > >>> 'common/autoconf/generated- > >>> configure.sh' and it works on the other platforms (and also locally > >>> for me on MacOS X) without regenerating it. I just saw that the mail I > >>> wrote yesterday wasn't send to the lists so I quote my assumptions > >>> here: > >>> > >>> ... > >>> From your logs I only see that the make process does not find any > >>> configuration, but the configuration should have been created by > >>> running configure. Then it tries to call configure but doesn't succeed > >>> because it says "The generated configure file contains changes not > >>> present in the custom generated file." That's also strange because my > >>> changesets also patch 'common/autoconf/generated- > >>> configure.sh' so it should not be re-generated. And finally the build > >>> fails because there's not autoconf on Windows and probably because the > >>> autoconf on Mac is too old (the checked-in file is generated by > >>> autoconf 2.8). > >>> > >>> I've just synced jdk8/jdk8 and applied the two patches. I could build > >>> without any problems on MacOS X 10.8 with the following command line. > >>> > >>> sh /usr/work/d046063/OpenJDK/ppc-aix-port/stage/configure > >>> --with-boot-jdk=/darwinintel64/output/sapjvm_7 > >>> --with-target-bits=64 --with-debug-level=release > >>> > >>> make images LOG=debug > >>> > >>> Attached you can find the output I get from running configure. > >>> > >>> Could you please retry one more time? If you still have problems, can > >>> you please run configure by hand and post the output. > >>> > >>> PS: I also saw from your logs that '/usr/bin/make sanity' is called. > >>> This also seems strange to me because I think there aren't any sanity > >>> targets any more in the new build system. Maybe you have a mismatch > >>> between old and new build system? > >>> ... > >>> > >>> Erik, could you please try this locally on Mac or Windows and post you > >>> findings. Alternatively, could you please explain post the complete > >>> JPRT output and explain what JPRT is trying to do. From Vladimir's log > >>> snippets it's hard for me t understand the whole picture. > >>> > >>> Thank you and best regards, > >>> Volker > >>> > >>>> The fix is to execute "bash common/autoconf/autogen.sh" locally > and then > >>>> resubmit to jprt. You need to have autoconf version 2.67 or newer > >>>> installed > >>>> for it to work. > >>>> > >>>> /Erik > >>>> > >>>> > >>>> On 2013-07-02 05:48, Vladimir Kozlov wrote: > >>>>> > >>>>> > >>>>> Need help from JDK build experts. > >>>>> > >>>>> I applied next 2 changesets: > >>>>> > >>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel/ > >>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ > >>>>> > >>>>> and got JPRT build problems (-control build) only on MacOS and Win64: > >>>>> > >>>>> > >>>>> > >>>>> > http://bus2001067.us.oracle.com/archives/2013/06/2013-06-28-213927.vkozlov.ppc64_jdk_build_test/ > >>>>> > >>>>> > >>>>> > >>>>> > ------------------------------------------------------------------------------ > >>>>> macosx_x64_10.7-product (details from log file) > >>>>> > >>>>> ... > >>>>> > >>>>> Warning: The generated configure file contains changes not present in > >>>>> the > >>>>> custom generated file. > >>>>> Running autogen.sh to correct the situation > >>>>> Autoconf found: /usr/bin/autoconf > >>>>> Autoconf-2.67 found: > >>>>> Generating generated-configure.sh with /usr/bin/autoconf > >>>>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > > >>>>> autom4te: /usr/bin/gm4 failed with exit status: 1 > >>>>> Generating custom generated-configure.sh > >>>>> /usr/bin/gm4:stdin:187: bad expression in eval: 32 > > >>>>> autom4te: /usr/bin/gm4 failed with exit status: 1 > >>>>> > >>>>> > >>>>> > >>>>> > ------------------------------------------------------------------------------ > >>>>> windows_x64_5.2-fastdebug (details from log file) > >>>>> > >>>>> ... > >>>>> > >>>>> Warning: The generated configure file contains changes not present in > >>>>> the > >>>>> custom generated file. > >>>>> Error: Cannot continue > >>>>> Cannot locate autoconf, unable to correct situation. > >>>>> Please install autoconf and run 'bash autogen.sh' to update the > >>>>> generated > >>>>> files. > >>>>> make: *** [bridge2configure] Error 1 > >>>>> > >>>>> > >>>>> > >>>>> > ------------------------------------------------------------------------------ > >>>>> > >>>>> Without these changes the output is: > >>>>> > >>>>> Running custom generated-configure.sh > >>>>> configure: Configuration created at Thu Jun 27 16:32:25 EDT 2013. > >>>>> configure: configure script generated at timestamp 1371547939. > >>>>> > >>>>> Thanks, > >>>>> Vladimir > >>>>> > >>>>> On 6/28/13 12:04 AM, Volker Simonis wrote: > >>>>>> > >>>>>> > >>>>>> Ok, that's fine. > >>>>>> > >>>>>> Could you please let me know when you've verified these changes. I > >>>>>> will then push them to the staging repository. > >>>>>> > >>>>>> > >>>>>> Regards, > >>>>>> Volker > >>>>>> > >>>>>> > >>>>>> On Thu, Jun 27, 2013 at 7:35 PM, Vladimir Kozlov > >>>>>> > > wrote: > >>>>>>> > >>>>>>> > >>>>>>> On 6/27/13 10:16 AM, Iris Clark wrote: > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> Hi, Volker. > >>>>>>>> > >>>>>>>> I think that the right thing for this change [1] is for you to > push > >>>>>>>> into > >>>>>>>> ppc-aix-port/stage once you get the necessary reviews (presumably > >>>>>>>> Erik > >>>>>>>> and > >>>>>>>> possibly Alan). While your changeset contains some general > purpose > >>>>>>>> updates, > >>>>>>>> it also contains PPC/AIX-specific files which can't be added > to a JDK > >>>>>>>> release repository until stage is pushed into the a JDK release. > >>>>>>>> > >>>>>>>> The recommendation to push to stage of course assumes that > Vladimir > >>>>>>>> doesn't think that this will adversely affect the Hotspot work > >>>>>>>> already > >>>>>>>> being > >>>>>>>> pushed to stage. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> This should not affect Hotspot in stage repo. Me or Albert will do > >>>>>>> JPRT > >>>>>>> bootstrap control build of jdk with this changes to make sure it > >>>>>>> works. > >>>>>>> After that Volker can push it into stage. > >>>>>>> > >>>>>>> When I talked about pushing *general* changes into main sources I > >>>>>>> meant > >>>>>>> changes with no ppc64 specific code. The example of such > changes was > >>>>>>> recent > >>>>>>> Goetz's fix for '8017531: 8010460 changes broke > >>>>>>> bytecodeInterpreter.cpp'. > >>>>>>> > >>>>>>> Thanks, > >>>>>>> Vladimir > >>>>>>> > >>>>>>> > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> iris > >>>>>>>> > >>>>>>>> [1]: http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ > >>>>>>>> > >>>>>>>> -----Original Message----- > >>>>>>>> From: Volker Simonis [mailto:volker.simonis at gmail.com > ] > >>>>>>>> Sent: Thursday, June 27, 2013 9:23 AM > >>>>>>>> To: Erik Joelsson > >>>>>>>> Cc: Kumar Srinivasan; build-dev; > ppc-aix-port-dev at openjdk.java.net > ; > >>>>>>>> Alan > >>>>>>>> Bateman > >>>>>>>> Subject: Re: RFR (XS): Enable new build on Linux/PPC64 (jdk part) > >>>>>>>> > >>>>>>>> Hi Erik, > >>>>>>>> > >>>>>>>> we have no polices which are carved in stone:) It's all done > >>>>>>>> informally > >>>>>>>> and by common sense. > >>>>>>>> > >>>>>>>> The main reason for the ppc-aix-port/stage repository is to have a > >>>>>>>> sandbox > >>>>>>>> for in-depth review and testing of changes we had to make in > shared > >>>>>>>> code > >>>>>>>> before pushing them to the main repository (and this especially > >>>>>>>> applies > >>>>>>>> to > >>>>>>>> hotspot changes). If you feel comfortable with the current changes > >>>>>>>> and > >>>>>>>> don't > >>>>>>>> think that they will break anything (e.g. by running tests > build on > >>>>>>>> your > >>>>>>>> supported platforms including the closed source ones) I'd really > >>>>>>>> appreciate > >>>>>>>> if you could push them to the build repository. > >>>>>>>> > >>>>>>>> Otherwise I'll push them to the staging repository and you'll get > >>>>>>>> them > >>>>>>>> once we're finished with the integration of the port. > >>>>>>>> > >>>>>>>> Thank you and best regards, > >>>>>>>> Volker > >>>>>>>> > >>>>>>>> On Thu, Jun 27, 2013 at 1:51 PM, Erik Joelsson > >>>>>>>> > > >>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> On 2013-06-27 13:00, Volker Simonis wrote: > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> On Thu, Jun 27, 2013 at 12:16 PM, Erik Joelsson > >>>>>>>>> > > >>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> Hello Volker, > >>>>>>>>>> > >>>>>>>>>> I wasn't aware of this project until now. From what I (now) > >>>>>>>>>> understand, generic patches can go into jdk8 repos, but port > >>>>>>>>>> specific > >>>>>>>>>> things need to go to staging and go in with the rest later. > These > >>>>>>>>>> changes contain a couple of port specific things so as it > looks now > >>>>>>>>>> they would need to go through staging. > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>> Yes, that's the general approach. But I'd argue that for the most > >>>>>>>>> part > >>>>>>>>> this changes are generic (enable CPP-interpreter, enable CORE > build, > >>>>>>>>> fix for broken ld on SuSE, replacing OPENWIN_LIB by X_LIB, fix > >>>>>>>>> typos) > >>>>>>>>> with only very few PPC64 specific parts (map-files and a few > >>>>>>>>> defines). > >>>>>>>>> The problem we want to avoid is that some of our fixes go > into the > >>>>>>>>> main repositories in parallel which would result in merging pain > >>>>>>>>> when > >>>>>>>>> integrating the staging into the main repository. > >>>>>>>>> > >>>>>>>>> So if you think you don't need any of the general fixes any time > >>>>>>>>> soon, > >>>>>>>>> I'll push the changes into the staging repository. Otherwise > I think > >>>>>>>>> it would be better to push them right into the main repositories. > >>>>>>>>> > >>>>>>>>> Several of the general fixes in there are good and I don't > want to > >>>>>>>>> hinder those getting in. I also don't want to break policies > I'm not > >>>>>>>>> familiar with. > >>>>>>>>> > >>>>>>>>> /Erik > >>>>>>>>> > >>>>>>>>> Thanks, > >>>>>>>>> Volker > >>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> /Erik > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On 2013-06-27 12:03, Volker Simonis wrote: > >>>>>>>>>> > >>>>>>>>>> Hi Erik, > >>>>>>>>>> > >>>>>>>>>> as Vladimir explained, we have a special staging repository > for our > >>>>>>>>>> PPC64/AIX port: > >>>>>>>>>> > >>>>>>>>>> I would be happy if you could push the changes right into the > >>>>>>>>>> build-infra repositories and we will then get them into our > staging > >>>>>>>>>> repository via jdk8/jdk8. > >>>>>>>>>> > >>>>>>>>>> Otherwise I'll have to push them to our staging repository and > >>>>>>>>>> later > >>>>>>>>>> when the whole port is completed in the staging repo they > will be > >>>>>>>>>> bulk-integrated into jdk8. > >>>>>>>>>> > >>>>>>>>>> What do you think? > >>>>>>>>>> > >>>>>>>>>> Regards, > >>>>>>>>>> Volker > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Wed, Jun 26, 2013 at 6:53 PM, Vladimir Kozlov > >>>>>>>>>> > wrote: > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> Erik, > >>>>>>>>>>> > >>>>>>>>>>> We have special staging forest for PPC64/AIX port: > >>>>>>>>>>> > >>>>>>>>>>> http://hg.openjdk.java.net/ppc-aix-port/stage > >>>>>>>>>>> > >>>>>>>>>>> We collect Hotspot and JDK changes there for testing before > >>>>>>>>>>> pushing > >>>>>>>>>>> into main sources in a future. But some general fixes we push > >>>>>>>>>>> directly into our main sources. > >>>>>>>>>>> If you think these build changes are acceptable for main, > please, > >>>>>>>>>>> ask someone sponsor these changes. > >>>>>>>>>>> > >>>>>>>>>>> Alan is our official contact for PPC64/AIX project. I CC him. > >>>>>>>>>>> > >>>>>>>>>>> Thanks, > >>>>>>>>>>> Vladimir > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> On 6/26/13 8:56 AM, Erik Joelsson wrote: > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> Hello, > >>>>>>>>>>>> > >>>>>>>>>>>> If you by staging area mean the build-infra forest, that's > more > >>>>>>>>>>>> or > >>>>>>>>>>>> less dead now. > >>>>>>>>>>>> > >>>>>>>>>>>> I think these changes look good now (both top level and > jdk). It > >>>>>>>>>>>> should be fine to push this to jdk8/build. > >>>>>>>>>>>> > >>>>>>>>>>>> /Erik > >>>>>>>>>>>> > >>>>>>>>>>>> On 2013-06-26 17:28, Volker Simonis wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> Hi Erik, > >>>>>>>>>>>>> > >>>>>>>>>>>>> thank you for looking at this. I've prepared a new webrev at: > >>>>>>>>>>>>> > >>>>>>>>>>>>> http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> What do you think, do you want to push this directly into the > >>>>>>>>>>>>> build repositories or should I push it into the staging > >>>>>>>>>>>>> repository > >>>>>>>>>>>>> first? > >>>>>>>>>>>>> > >>>>>>>>>>>>> Please see my further comments inline. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Thank you and best regards, > >>>>>>>>>>>>> Volker > >>>>>>>>>>>>> > >>>>>>>>>>>>> On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson > >>>>>>>>>>>>> >> > >>>>>>>>>>>>> wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> On 2013-06-25 12:27, Erik Joelsson wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>> Hello Volker, > >>>>>>>>>>>>> > >>>>>>>>>>>>> On 2013-06-24 19:23, Volker Simonis wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>> Hi, > >>>>>>>>>>>>> > >>>>>>>>>>>>> could somebody please review the following > change > >>>>>>>>>>>>> and > >>>>>>>>>>>>> create an appropriate > >>>>>>>>>>>>> Bug ID for it: > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_jdk/ > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> /> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> The patch contains two little changes > which are > >>>>>>>>>>>>> required > >>>>>>>>>>>>> to build the class > >>>>>>>>>>>>> library part of the OpenJDK on > Linux/PPC64. Most > >>>>>>>>>>>>> of > >>>>>>>>>>>>> the > >>>>>>>>>>>>> build magic is > >>>>>>>>>>>>> contained in the top-level part of this change > >>>>>>>>>>>>> which > >>>>>>>>>>>>> is > >>>>>>>>>>>>> separately reviewed > >>>>>>>>>>>>> at > >>>>>>>>>>>>> > >>>>>>>>>>>>> > http://cr.openjdk.java.net/~simonis/webrevs/linux_ppc_build_top > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> CompileLaunchers.gmk > >>>>>>>>>>>>> > >>>>>>>>>>>>> Remove mapfile from build instructions of > >>>>>>>>>>>>> BUILD_UNPACKEXE: > >>>>>>>>>>>>> > >>>>>>>>>>>>> CFLAGS_macosx:=-fPIC, \ > >>>>>>>>>>>>> - > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > MAPFILE:=$(JDK_TOPDIR)/makefiles/mapfiles/libunpack/mapfile-vers-unpack200,\ > >>>>>>>>>>>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),\ > >>>>>>>>>>>>> > >>>>>>>>>>>>> I think it makes no sense to use a version > >>>>>>>>>>>>> script > >>>>>>>>>>>>> file > >>>>>>>>>>>>> for an executable > >>>>>>>>>>>>> and older linkers (e.g. on SLES 10) complain > >>>>>>>>>>>>> with: > >>>>>>>>>>>>> "*Invalid version tag > >>>>>>>>>>>>> `SUNWprivate_1.1'. Only anonymous version > tag is > >>>>>>>>>>>>> allowed > >>>>>>>>>>>>> in executable.*" > >>>>>>>>>>>>> The GNU ld > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> > manualstates: > >>>>>>>>>>>>> "*Version scripts are only meaningful when > >>>>>>>>>>>>> creating > >>>>>>>>>>>>> shared > >>>>>>>>>>>>> libraries.*" > >>>>>>>>>>>>> Morover unpack200 was the only executable > which > >>>>>>>>>>>>> used > >>>>>>>>>>>>> a > >>>>>>>>>>>>> version script file. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Unpackexe has some weirdness and this isn't > >>>>>>>>>>>>> surprising > >>>>>>>>>>>>> me. > >>>>>>>>>>>>> Would be good if someone with more historic > knowledge > >>>>>>>>>>>>> could > >>>>>>>>>>>>> fill in on the reason for this. Someone apparently > >>>>>>>>>>>>> went > >>>>>>>>>>>>> through the trouble of creating a special > mapfile for > >>>>>>>>>>>>> this > >>>>>>>>>>>>> executable. Also, if not using it, should it be > >>>>>>>>>>>>> removed? > >>>>>>>>>>>>> > >>>>>>>>>>>>> I looked closer at this. These mapfiles were > explicitly > >>>>>>>>>>>>> added in > >>>>>>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=7033954, but it > >>>>>>>>>>>>> was > >>>>>>>>>>>>> noted > >>>>>>>>>>>>> that it broke builds for architectures that didn't > have > >>>>>>>>>>>>> mapfiles > >>>>>>>>>>>>> defined. If you look at the launchers, the mapfile is > >>>>>>>>>>>>> only > >>>>>>>>>>>>> set > >>>>>>>>>>>>> if > >>>>>>>>>>>>> the arch specific one exists. I think a safer > change here > >>>>>>>>>>>>> would > >>>>>>>>>>>>> be > >>>>>>>>>>>>> to make the mapfile conditional on platform or > arch for > >>>>>>>>>>>>> unpackexe. > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> I still do not fully understand why we need map-files for > >>>>>>>>>>>>> executables, but I also understand that you don't want to > change > >>>>>>>>>>>>> the > >>>>>>>>>>>>> current setup. > >>>>>>>>>>>>> So I went the hard (and hopefully right:) way and > implemented a > >>>>>>>>>>>>> detection of the buggy linkers on older SuSE distros (e.g. on > >>>>>>>>>>>>> SLES > >>>>>>>>>>>>> 10) which complain with: "Invalid version tag > `SUNWprivate_1.1' > >>>>>>>>>>>>> during the configure step (see top-level change). > Unfortunately > >>>>>>>>>>>>> we > >>>>>>>>>>>>> still have quite a lot of these systems so we really need the > >>>>>>>>>>>>> build with that buggy ld. > >>>>>>>>>>>>> > >>>>>>>>>>>>> I've therefore added map files with anonymous version > tags for > >>>>>>>>>>>>> these buggy linkers which are only used if the buggy > linker was > >>>>>>>>>>>>> detected during the configure step (i.e. if > >>>>>>>>>>>>> USING_BROKEN_SUSE_LD=yes). Notice that this is no PPC64 > specific > >>>>>>>>>>>>> problem but a occurs on all SuSE 10 platforms. > >>>>>>>>>>>>> > >>>>>>>>>>>>> And you've been right. I also had to add the arch > specific map > >>>>>>>>>>>>> files for ppc64 in order to use them for the other launchers. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Kumar, you made the change referred to here, do > you have > >>>>>>>>>>>>> anything > >>>>>>>>>>>>> to add? > >>>>>>>>>>>>> > >>>>>>>>>>>>> /Erik > >>>>>>>>>>>>> > >>>>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') > >>>>>>>>>>>>> > >>>>>>>>>>>>> default: all > >>>>>>>>>>>>> > >>>>>>>>>>>>> CompileNativeLibraries.gmk > >>>>>>>>>>>>> > >>>>>>>>>>>>> Only use $(OPENWIN_LIB) for linking > >>>>>>>>>>>>> LIBSPLASHSCREEN > >>>>>>>>>>>>> on > >>>>>>>>>>>>> Solaris! The old > >>>>>>>>>>>>> code worked only accidentally when the > >>>>>>>>>>>>> X-libraries > >>>>>>>>>>>>> are > >>>>>>>>>>>>> in > >>>>>>>>>>>>> the default > >>>>>>>>>>>>> linker path anyway. The right solution is > to use > >>>>>>>>>>>>> $(X_LIBS) > >>>>>>>>>>>>> if not on > >>>>>>>>>>>>> Windows or Solaris. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Append -DX_ARCH=X_PPC64 to > LIBJSOUND_CFLAGS on > >>>>>>>>>>>>> PPC64. > >>>>>>>>>>>>> The value of > >>>>>>>>>>>>> X_ARCHisn't actually used on the PPC > >>>>>>>>>>>>> architectures, > >>>>>>>>>>>>> but > >>>>>>>>>>>>> there's a > >>>>>>>>>>>>> check to verify > >>>>>>>>>>>>> that it is set. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Fix typo (replace 'defalt: all' by 'default') > >>>>>>>>>>>>> > >>>>>>>>>>>>> default: all > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> Otherwise looks good. > >>>>>>>>>>>>> > >>>>>>>>>>>>> /Erik > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>> > >>> > >> From michael.x.mcmahon at oracle.com Wed Jul 3 13:19:33 2013 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Wed, 03 Jul 2013 14:19:33 +0100 Subject: building jdk 8 with Java FX Message-ID: <51D424E5.8010805@oracle.com> I ran configure with --with-javafx-zip-dir=/java/re/javafx/jdk-cobundle/8, but I don't see any Java FX artifacts in the resulting build. What am I doing wrong? Thanks! Michael From erik.joelsson at oracle.com Wed Jul 3 13:43:46 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 03 Jul 2013 15:43:46 +0200 Subject: building jdk 8 with Java FX In-Reply-To: <51D424E5.8010805@oracle.com> References: <51D424E5.8010805@oracle.com> Message-ID: <51D42A92.4010909@oracle.com> Which make target did you build? Javafx is imported in install, so you would need to run either "make all" or "make installer" /Erik On 2013-07-03 15:19, Michael McMahon wrote: > I ran configure with > --with-javafx-zip-dir=/java/re/javafx/jdk-cobundle/8, but I don't see > any Java FX artifacts in the resulting build. > > What am I doing wrong? > > Thanks! > Michael From michael.x.mcmahon at oracle.com Wed Jul 3 14:00:01 2013 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Wed, 03 Jul 2013 15:00:01 +0100 Subject: building jdk 8 with Java FX In-Reply-To: <51D42A92.4010909@oracle.com> References: <51D424E5.8010805@oracle.com> <51D42A92.4010909@oracle.com> Message-ID: <51D42E61.4090504@oracle.com> Erik I made "images", but I don't see anything with "all" either. Is the directory below correct? Or should I leave out the /8 ? Thanks Michael On 03/07/13 14:43, Erik Joelsson wrote: > Which make target did you build? Javafx is imported in install, so you > would need to run either "make all" or "make installer" > > /Erik > > On 2013-07-03 15:19, Michael McMahon wrote: >> I ran configure with >> --with-javafx-zip-dir=/java/re/javafx/jdk-cobundle/8, but I don't see >> any Java FX artifacts in the resulting build. >> >> What am I doing wrong? >> >> Thanks! >> Michael From steven.loomis at oracle.com Wed Jul 3 19:19:57 2013 From: steven.loomis at oracle.com (Steven R. Loomis) Date: Wed, 03 Jul 2013 12:19:57 -0700 Subject: [OpenJDK 2D-Dev] Add optional support for using the system libicu In-Reply-To: <51C8E32F.5090908@oracle.com> References: <51AE5C60.1080303@redhat.com> <51AF0300.80808@oracle.com> <51AF7D19.7010105@oracle.com> <51C8C4C7.6040104@redhat.com> <51C8E32F.5090908@oracle.com> Message-ID: <51D4795D.9050908@oracle.com> Omair, I didn't hear back from you on this list, but I will reply here with more details. See diffs below. I would be very suspicious of how this could run without crashing, if the tests I mentioned were run (anything with 'kerning' in its name, using a font that actually uses kerning pairs). JDK pre-swaps the kerning pairs, but ICU re-swaps them every time a pair is hit. getKerningAdjustment is a hook that has to do with JDK's transform matrix. It could probably be implemented as a no-op getKerningAdjustment(LEPoint &adjustment)const{}; in the base class. Steven ---- * < ICU (trunk) LEFontInstance.h * > JDK (2d/8) LEFontInstance.h 159,162d183 < * Note that implementing this function does not allow for range checking. < * Subclasses that desire the safety of range checking must implement the < * variation which has a length parameter. < * 182,183d202 < * Note that range checking can only be accomplished if this function is < * implemented in subclasses. 192a212,214 > virtual void *getKernPairs() const = 0; > virtual void setKernPairs(void *pairs) const = 0; > 306a329,330 > virtual void getKerningAdjustment(LEPoint &adjustment) const = 0; On 6/24/13 5:24 p.m., Steven R. Loomis wrote: > Omair, > I'm sorry I did not see this before. I probably would not have > noticed it except I happened to notice this reply. > > I'm responsible for maintaining the version of ICU in JDK, and also > (read: main day job) IBM's lead for ICU for C/C++. ( But I speak for > myself here, of course. ) > > I think this patch is certainly a good direction (especially with > regards HarfBuzz - I wrote that recommendation you cite), at least > longer term, however, I have quite a number of concerns with this patch. > > ? The big one - is that the ICU and JDK versions of the LE are > divergent, so much so that, to put it mildly, I am a little surprised > that this patch builds at all. > Now, I would like - love - for enough upstream changes to ICU to > happen so that the APIs are compatible enough for this change to be > possible. But we aren't there yet. > ? ? and when we are there, it won't be compatible with any shipping > ICU, so you will need to wait until the future ICU is picked up. > > ? You mentioned the issues about which version of the headers to > compile against. You MUST compile against the same version of the > headers you are linking against. Period. This is C++, not Java or > even C. The vtable expected in the ICU version versus the JDK version > of the LE are different, have different parentage. > > ? As to tests, I would start with everything in > jdk/test/java/awt/font/TextLayout > > ( NB Phil- I had started a port of ICU's letest.xml conformance test > to the JDK- this would be helpful in making sure we get the same > results.) > > > I'm sorry I didn't see this earlier. I don't always monitor this > address or even 2d-dev as closely as I could. > > Regards, > Steven > > ( If you don't get a response from me, you can always ping me at > srl at icu-project.org ? ) > > On 6/24/13 3:14 p.m., Omair Majid wrote: >> Hi Phil, >> >> Updated webrev: >> http://cr.openjdk.java.net/~omajid/webrevs/system-icu/01/ >> >> It's still against jdk8/build and missing support for the old build >> system. >> >> On 06/05/2013 02:02 PM, Phil Race wrote: >>> Since this entirely affects a 2D component, please include 2d-dev in >>> this discussion. >>> I would have been 'surprised' to see this change if I hadn't just >>> spotted this thread. >> Mea culpa. I pushed a few similar system-library patches using this >> identical process and no one corrected me. So I assumed this was right. >> For the future, I will ensure the relevant groups are CC'd. >> >>> And I believe this change should be integrated via the 2D forest. >> Okay. Are there any guidelines for this? It's not obvious to me when a >> change is more appropriate for build vs 2D. >> >>> I am not sure what, if any, runtime problems might occur from using a >>> different >>> version. We've generally been able to swap in newer versions of ICU >>> without >>> much trouble, but I recommend to run appropriate tests before >>> shipping .. >> Thanks for the suggestions. Do you have any particular tests in mind? >> >> For some background, the goal with this change is two fold: >> >> 1. Gain benefits from system-installed libraries. This is one library >> where OpenJDK does not lag behind in security updates, but in some other >> cases, embedded libraries can lag behind. It also makes it easier to use >> the distributions preferred policies (hardening flags on libraries and >> so on). >> >> 2. Make it easier to switch to HarfBuzz at some later point. ICU itself >> strongly recommends switching [1]. Through ice-le-hb [2], only a >> recompile should be needed to switch (hopefully). >> >>> Note that JDK8 in fact has a very "current" ICU with some security >>> fixes. >>> So I would not recommend using the native lib on a system with an older >>> ICU. >> Thanks for pointing it out. I see that ICU recently released a security >> update [1] too, but probably many distributions will not have this >> up-to-date version (my current distro, a little out-of-date, does not >> :( ). >> >> Thanks, >> Omair >> >> [1] http://site.icu-project.org/download/51 >> [2] https://github.com/behdad/icu-le-hb >> > From erik.joelsson at oracle.com Thu Jul 4 07:15:31 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 04 Jul 2013 09:15:31 +0200 Subject: Build bundle with debug enabled In-Reply-To: <1372909049.51745.YahooMailNeo@web142505.mail.bf1.yahoo.com> References: <1372303930.43263.YahooMailNeo@web142503.mail.bf1.yahoo.com> <1372909049.51745.YahooMailNeo@web142505.mail.bf1.yahoo.com> Message-ID: <51D52113.5010405@oracle.com> Forwarding to build-dev as build-infra-dev is more or less dead. (It was used for the build-infra project, which is now more or less done.) I do not know of any such binaries being available. /Erik On 2013-07-04 05:37, Mahesh Pujari wrote: > Hi, > Can any one please let me know if we have debug enabled bundle for debugging hotspot/VM. > > thanks and regards, > Mahesh Pujari > > > > ________________________________ > From: Mahesh Pujari > To: "build-infra-dev at openjdk.java.net" > Sent: Thursday, June 27, 2013 9:02 AM > Subject: Build bundle with debug enabled > > > Hi, > Do we have bundle of OpenJDK-8 build with debug enabled (have debug symbols for hotspot/VM), so that we can debug the hotspot without building it locally. If it exists could any one please direct to me the location. > > thanks and regards, > Mahesh Pujari From david.holmes at oracle.com Fri Jul 5 05:51:41 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 05 Jul 2013 15:51:41 +1000 Subject: RFR (S): Enable new build on Linux/PPC64 (top-level part) In-Reply-To: References: <51C96F37.9060808@oracle.com> Message-ID: <51D65EED.4020300@oracle.com> Hi Volker, This seems okay to me. The CFLAGS -m64 bit seems unfortunately messy for you, but I don't think we've encountered a 64-bit platform where the compiler builds 32-bit by default. :( Hopefully this can be cleaned up. Just in case it hasn't been noticed, please note that INCLUDE_SA only controls whether or not sa-jdi.jar gets copied into the final image. It doesn't get passed through to the hotspot build to control whether the SA is indeed built or not. (In fact hotspot doesn't have a single variable to control this as the sa-jdi.jar can be built even if there is no native support built via saproc :( ). David On 27/06/2013 1:28 AM, Volker Simonis wrote: > Hi Erik, > > thanks for the BugID! > > Here's the new webrev: > > http://cr.openjdk.java.net/~simonis/webrevs/8017568_toplevel > > I've added a detection for buggy linkers on older SuSE distros (e.g. on > SLES 10) which complains with: "Invalid version tag `SUNWprivate_1.1'. Only > anonymous version tag is allowed in executable." if feeded with a version > script which contains named tags. If detected this will be exported as > USING_BROKEN_SUSE_LD=yes > for the jdk build. > > What do you think, do you want to push this directly into the build > repositories or should I push it into the staging repository first? > > Please see further comments inline. > > Thank you and best regards, > Volker > > On Tue, Jun 25, 2013 at 12:21 PM, Erik Joelsson wrote: > >> Hello Volker, >> >> >> On 2013-06-24 19:23, Volker Simonis wrote: >> >>> Hi, >>> >>> could somebody please review the following change and create an >>> appropriate >>> Bug ID for it: >>> >>> Created 8017568: Enable new build on Linux/PPC64 >> You can use it for both root and jdk changes. >> >>> http://cr.openjdk.java.net/~**simonis/webrevs/linux_ppc_**build_top/ >>> >>> The change will enable to build the PowerPC/AIX port on Linux/PPC64 with >>> the new build system using an interpreter only VM using the C++ >>> interpreter. Therefore it introduces a new JVM variant called "core" which >>> enables an interpreter only build and a new configure option called >>> "--with-jvm-interpreter" which can be used to choose either the default >>> "template" interpreter or the "C++" interpreter. >>> >>> Notice that this 'core' build currently only works on Linux/PPC64 and it >>> is >>> used for the PowerPC/AIX porting project to bootstrap its build. (See >>> 8016476: >>> PPC64 (part 1): reenable CORE >>> build >>>> for >>> >>> the corresponding HotSpot change). >>> >>> Once we have all the required patches in the HotSpot repository (and the >>> small JDK changes from >>> http://cr.openjdk.java.net/~**simonis/webrevs/linux_ppc_**build_jdk), >>> building >>> on newer Linux distros like Fedora 17 will be as easy as: >>> >>> sh /priv/openjdk/OpenJDK/ppc-aix-**port/jdk8/configure >>> --with-boot-jdk=/priv/openjdk/**OpenJDK/openjdk1.7.0-ppc-aix-**port-b03 >>> --with-jvm-variants=core --with-jvm-interpreter=cpp >>> --with-debug-level=slowdebug >>> >>> make images LOG=debug >>> >>> On older releases like SLES 10 you'll have to use something like: >>> >>> sh /priv/openjdk/OpenJDK/ppc-aix-**port/jdk8/configure --with-boot-jdk= >>> /priv/openjdk/OpenJDK/**openjdk1.7.0-ppc-aix-port-b03-** >>> -with-jvm-variants=core >>> --with-jvm-interpreter=cpp--**with-debug-level=release >>> --with-extra-cflags=-m64 >>> --with-extra-cxxflags=-m64 --with-extra-ldflags='-m64 -L/lib64' >>> --x-libraries=/usr/X11R6/lib64 --x-includes=/usr/X11R6/**include >>> CFLAGS=-m64 >>> CXXFLAGS=-m64 >>> >>> make images LOG=debug >>> >>> The extra options and flags are mainly necessary because the GCC on the >>> latter platform produces 32-bit binaries by default. Notice that the >>> environment variables "CFLAGS=-m64 CXXFLAGS=-m64" are necessary for the >>> configure script itself to detect the correct 64-bit platform while the >>> configure options like "--with-extra-cflags" are needed in order to select >>> the right flags for the build. >>> >> This should be addressed I think. I'm not happy with the current handling >> of CFLAGS*, CXXFLAGS* and LDFLAGS*. But not in this patch. >> > > Yes, I didn't change anything here, I just wanted to explain the command > line and why both, "--with-extra-cflags" and CFLAGS are necessary. > > Following some more detailed descriptions of the change: >>> common/autoconf/boot-jdk.m4 >>> >>> Linux/PPC64 needs a slightly bigger heap for the huge JDK batch. Treat it >>> like MacOS which uses '-Xmx1600M'. >>> common/autoconf/configure.ac >>> common/autoconf/hotspot-spec.**gmk.in >>> common/autoconf/jdk-options.m4 >>> >>> Add --with-interpreter option to configure which can be used th choose one >>> of the 'template' or the 'C++' interpreter. Default is the 'template' >>> interpreter. >>> common/autoconf/jdk-options.m4 >>> common/autoconf/spec.gmk.in >>> make/hotspot-rules.gmk >>> >>> Add JVM variant 'core' to configure which can be used th choose the >>> HotSpot >>> 'core' (i.e. 'interpreter only') build. Notice that this 'core' build >>> currently only works on Linux/PPC64 and it is used for the PowerPC/AIX >>> porting project to bootstrap its build. (See 8016476: PPC64 (part 1): >>> reenable CORE build>> id=8016476 >>>> for >>> >>> the corresponding HotSpot change). >>> >>> We currently also don't build the serviceability agent on PPC64. >>> common/autoconf/libraries.m4 >>> >>> Older Linuxes (e.g. SLES 10) may still have the X11R6 directory but also a >>> symlink from /usr/include/X11 to ../X11R6/include/X11 so we need to check >>> for the X11R6 directory AFTER we checked for /usr/include/X11 >>> Thank you and best regards, >>> >> Note that this last part won't apply cleanly after some recent changes. >> >> > The good news here is that the recent change which broke my patch also > fixed my problem, so this part isn't necessary any more! > > >> Why change make/hotspot-rules.gmk? It's only used in the old build. >> Otherwise this all looks good to me from a build perspective. >> > > You're right, that was an leftover in the patch from the old build system. > I've removed it. > > >> /Erik >> From david.holmes at oracle.com Fri Jul 5 06:11:04 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 05 Jul 2013 16:11:04 +1000 Subject: RFR (XS): Enable new build on Linux/PPC64 (jdk part) In-Reply-To: References: <51C970A7.4080601@oracle.com> <51C973EC.8020204@oracle.com> Message-ID: <51D66378.6000109@oracle.com> Just a minor note already mentioned in another review. I'm seeing a number of new files that were obviously copied from existing files but the copyright information has not been updated. I know some files have been in the aix-port repo for a while but not, I think, since 2004 :) David On 27/06/2013 1:28 AM, Volker Simonis wrote: > Hi Erik, > > thank you for looking at this. I've prepared a new webrev at: > > http://cr.openjdk.java.net/~simonis/webrevs/8017568_jdk/ > > What do you think, do you want to push this directly into the build > repositories or should I push it into the staging repository first? > > Please see my further comments inline. > > Thank you and best regards, > Volker > > On Tue, Jun 25, 2013 at 12:41 PM, Erik Joelsson wrote: > >> >> On 2013-06-25 12:27, Erik Joelsson wrote: >> >>> Hello Volker, >>> >>> On 2013-06-24 19:23, Volker Simonis wrote: >>> >>>> Hi, >>>> >>>> could somebody please review the following change and create an >>>> appropriate >>>> Bug ID for it: >>>> >>>> http://cr.openjdk.java.net/~**simonis/webrevs/linux_ppc_**build_jdk/ >>>> >>>> The patch contains two little changes which are required to build the >>>> class >>>> library part of the OpenJDK on Linux/PPC64. Most of the build magic is >>>> contained in the top-level part of this change which is separately >>>> reviewed >>>> at http://cr.openjdk.java.net/~**simonis/webrevs/linux_ppc_**build_top >>>> CompileLaunchers.gmk >>>> >>>> Remove mapfile from build instructions of BUILD_UNPACKEXE: >>>> >>>> CFLAGS_macosx:=-fPIC, \ >>>> - MAPFILE:=$(JDK_TOPDIR)/**makefiles/mapfiles/libunpack/** >>>> mapfile-vers-unpack200,\ >>>> LDFLAGS:=$(UNPACKEXE_ZIPOBJS),**\ >>>> >>>> I think it makes no sense to use a version script file for an >>>> executable >>>> and older linkers (e.g. on SLES 10) complain with: "*Invalid version tag >>>> `SUNWprivate_1.1'. Only anonymous version tag is allowed in executable.*" >>>> The GNU ld manual>>> node/ld_25.html >>>>> states: >>>> "*Version scripts are only meaningful when creating shared libraries.*" >>>> Morover unpack200 was the only executable which used a version script >>>> file. >>>> >>>> Unpackexe has some weirdness and this isn't surprising me. Would be >>> good if someone with more historic knowledge could fill in on the reason >>> for this. Someone apparently went through the trouble of creating a special >>> mapfile for this executable. Also, if not using it, should it be removed? >>> >> I looked closer at this. These mapfiles were explicitly added in >> http://bugs.sun.com/view_bug.**do?bug_id=7033954, >> but it was noted that it broke builds for architectures that didn't have >> mapfiles defined. If you look at the launchers, the mapfile is only set if >> the arch specific one exists. I think a safer change here would be to make >> the mapfile conditional on platform or arch for unpackexe. >> >> > I still do not fully understand why we need map-files for executables, but > I also understand that you don't want to change the current setup. So I > went the hard (and hopefully right:) way and implemented a detection of the > buggy linkers on older SuSE distros (e.g. on SLES 10) which complain with: > "Invalid version tag `SUNWprivate_1.1' during the configure step (see > top-level change). Unfortunately we still have quite a lot of these systems > so we really need the build with that buggy ld. > > I've therefore added map files with anonymous version tags for these buggy > linkers which are only used if the buggy linker was detected during the > configure step (i.e. if USING_BROKEN_SUSE_LD=yes). Notice that this is no > PPC64 specific problem but a occurs on all SuSE 10 platforms. > > And you've been right. I also had to add the arch specific map files for > ppc64 in order to use them for the other launchers. > > >> Kumar, you made the change referred to here, do you have anything to add? >> >> /Erik >> >> Fix typo (replace 'defalt: all' by 'default') >>>> >>>> default: all >>>> >>>> CompileNativeLibraries.gmk >>>> >>>> Only use $(OPENWIN_LIB) for linking LIBSPLASHSCREEN on Solaris! The old >>>> code worked only accidentally when the X-libraries are in the default >>>> linker path anyway. The right solution is to use $(X_LIBS) if not on >>>> Windows or Solaris. >>>> >>>> Append -DX_ARCH=X_PPC64 to LIBJSOUND_CFLAGS on PPC64. The value of >>>> X_ARCHisn't actually used on the PPC architectures, but there's a >>>> check to verify >>>> that it is set. >>>> >>>> Fix typo (replace 'defalt: all' by 'default') >>>> >>>> default: all >>>> >>>> >>>> Otherwise looks good. >>> >>> /Erik >>> >>> From tim.bell at oracle.com Fri Jul 5 21:36:45 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 05 Jul 2013 14:36:45 -0700 Subject: Review request (extra small) for 8012925 Missing return value in jdk/src/macosx/native/sun/awt/AWTEvent.m Message-ID: <51D73C6D.5090807@oracle.com> Hello everyone Unfortunately there is no public link for 8012925 This is a one-line change in jdk/src/macosx/native/sun/awt/AWTEvent.m to return a value (0) instead of returning nothing. Returning 0 is consistent with the code at line 418 in the same method: http://cr.openjdk.java.net/~tbell/8012925/webrev.00/ I came across this during my work on 8019470: http://bugs.sun.com/view_bug.do?bug_id=8019470 When building with clang on MacOS, I get a fatal error over this 'warning', so I needed to fix it before I could continue working. Thanks in advance- Tim From david.katleman at oracle.com Fri Jul 5 22:01:57 2013 From: david.katleman at oracle.com (David Katleman) Date: Fri, 05 Jul 2013 15:01:57 -0700 Subject: Review request (extra small) for 8012925 Missing return value in jdk/src/macosx/native/sun/awt/AWTEvent.m In-Reply-To: <51D73C6D.5090807@oracle.com> References: <51D73C6D.5090807@oracle.com> Message-ID: <51D74255.7080909@oracle.com> Change looks correct. Approved. Dave On 7/5/2013 2:36 PM, Tim Bell wrote: > Hello everyone > > Unfortunately there is no public link for 8012925 > > This is a one-line change in jdk/src/macosx/native/sun/awt/AWTEvent.m > to return a value (0) instead of returning nothing. Returning 0 is > consistent with the code at line 418 in the same method: > > http://cr.openjdk.java.net/~tbell/8012925/webrev.00/ > > I came across this during my work on 8019470: > http://bugs.sun.com/view_bug.do?bug_id=8019470 > > When building with clang on MacOS, I get a fatal error over this > 'warning', so I needed to fix it before I could continue working. > > Thanks in advance- > > Tim > From leonid.romanov at oracle.com Fri Jul 5 22:52:18 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Sat, 06 Jul 2013 02:52:18 +0400 Subject: Review request (extra small) for 8012925 Missing return value in jdk/src/macosx/native/sun/awt/AWTEvent.m In-Reply-To: <51D73C6D.5090807@oracle.com> References: <51D73C6D.5090807@oracle.com> Message-ID: <51D74E22.8080307@oracle.com> Looks OK. On 7/6/2013 1:36, Tim Bell wrote: > Hello everyone > > Unfortunately there is no public link for 8012925 > > This is a one-line change in jdk/src/macosx/native/sun/awt/AWTEvent.m > to return a value (0) instead of returning nothing. Returning 0 is > consistent with the code at line 418 in the same method: > > http://cr.openjdk.java.net/~tbell/8012925/webrev.00/ > > I came across this during my work on 8019470: > http://bugs.sun.com/view_bug.do?bug_id=8019470 > > When building with clang on MacOS, I get a fatal error over this > 'warning', so I needed to fix it before I could continue working. > > Thanks in advance- > > Tim > From aph at redhat.com Mon Jul 8 11:24:35 2013 From: aph at redhat.com (Andrew Haley) Date: Mon, 08 Jul 2013 12:24:35 +0100 Subject: Thank you for the new JDK build system Message-ID: <51DAA173.7010400@redhat.com> Wow. Just wow. I think I owe you a beer. All of you. Cross-compiling linux-aarch64-normal-client-slowdebug: ----- Build times ------- Start 2013-07-08 12:17:20 End 2013-07-08 12:20:09 00:00:11 corba 00:00:06 demos 00:00:29 hotspot 00:00:09 images 00:00:09 jaxp 00:00:11 jaxws 00:01:09 jdk 00:00:17 langtools 00:00:08 nashorn 00:02:49 TOTAL ------------------------- Finished building OpenJDK for target 'images' Regards, Andrew. From jonathan.gibbons at oracle.com Mon Jul 8 12:09:19 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 08 Jul 2013 13:09:19 +0100 Subject: Thank you for the new JDK build system In-Reply-To: <51DAA173.7010400@redhat.com> References: <51DAA173.7010400@redhat.com> Message-ID: <51DAABEF.8090204@oracle.com> On 07/08/2013 12:24 PM, Andrew Haley wrote: > Wow. Just wow. > > I think I owe you a beer. All of you. > > Cross-compiling linux-aarch64-normal-client-slowdebug: > > ----- Build times ------- > Start 2013-07-08 12:17:20 > End 2013-07-08 12:20:09 > 00:00:11 corba > 00:00:06 demos > 00:00:29 hotspot > 00:00:09 images > 00:00:09 jaxp > 00:00:11 jaxws > 00:01:09 jdk > 00:00:17 langtools > 00:00:08 nashorn > 00:02:49 TOTAL > ------------------------- > Finished building OpenJDK for target 'images' > > Regards, > Andrew. Yes, fun, isn't it! -- Jon From tim.bell at oracle.com Mon Jul 8 16:49:40 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Mon, 08 Jul 2013 16:49:40 +0000 Subject: hg: jdk8/build/jdk: 8012925: [parfait] Missing return value in jdk/src/macosx/native/sun/awt/AWTEvent.m Message-ID: <20130708165003.1E4C3488A9@hg.openjdk.java.net> Changeset: 2c26ccf0a85b Author: tbell Date: 2013-07-08 07:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2c26ccf0a85b 8012925: [parfait] Missing return value in jdk/src/macosx/native/sun/awt/AWTEvent.m Reviewed-by: katleman, leonidr Contributed-by: petr.pchelko at oracle.com ! src/macosx/native/sun/awt/AWTEvent.m From tim.bell at oracle.com Mon Jul 8 19:03:36 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 08 Jul 2013 12:03:36 -0700 Subject: Request for review and approval to fix 8012366 in 7update Message-ID: <51DB0D08.4000608@oracle.com> All- My fix for 8007815 [1] did not handle the case of an OpenJDK build that does not have the closed source trees. If a user tries to build that far, the build will fail with "cd: can't cd to ./install/make/installer/binaries/linux" This is a request for review and approval to fix 8012366 in 7u. These changes will not throw a build error if the closed directories do not exist. Makefile changes only; no product code has been modified: Link to the bug report: http://bugs.sun.com/view_bug.do?bug_id=8012366 webrev of the Makefile changes: http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ Thanks in advance- Tim [1] There is no external link for 8007815, sorry. These changes had to do with building and packaging in the install tree. From kellyohair at gmail.com Mon Jul 8 19:10:28 2013 From: kellyohair at gmail.com (Kelly O'Hair) Date: Mon, 8 Jul 2013 12:10:28 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DB0D08.4000608@oracle.com> References: <51DB0D08.4000608@oracle.com> Message-ID: How did BUILD_INSTALL ever become true on an OpenJDK build? -kto On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: > All- > > My fix for 8007815 [1] did not handle the case of an OpenJDK build that does not have the closed source trees. If a user tries to build that far, the build will fail with "cd: can't cd to ./install/make/installer/binaries/linux" > > This is a request for review and approval to fix 8012366 in 7u. These changes will not throw a build error if the closed directories do not exist. Makefile changes only; no product code has been modified: > > Link to the bug report: > > http://bugs.sun.com/view_bug.do?bug_id=8012366 > > webrev of the Makefile changes: > > http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ > > Thanks in advance- > > Tim > [1] There is no external link for 8007815, sorry. These changes had to do with building and packaging in the install tree. > From david.katleman at oracle.com Mon Jul 8 21:34:18 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 21:34:18 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b97 for changeset 469995a8e974 Message-ID: <20130708213419.BEEBD488B7@hg.openjdk.java.net> Changeset: 3370fb6146e4 Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/3370fb6146e4 Added tag jdk8-b97 for changeset 469995a8e974 ! .hgtags From david.katleman at oracle.com Mon Jul 8 21:34:12 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 21:34:12 +0000 Subject: hg: jdk8/build: Added tag jdk8-b97 for changeset a1c1e8bf71f3 Message-ID: <20130708213412.8CCAB488B6@hg.openjdk.java.net> Changeset: 99ad803f8c4e Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/99ad803f8c4e Added tag jdk8-b97 for changeset a1c1e8bf71f3 ! .hgtags From david.katleman at oracle.com Mon Jul 8 21:35:08 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 21:35:08 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b97 for changeset d197d377ab2e Message-ID: <20130708213512.59C13488B8@hg.openjdk.java.net> Changeset: 2bfa00fac03f Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2bfa00fac03f Added tag jdk8-b97 for changeset d197d377ab2e ! .hgtags From david.katleman at oracle.com Mon Jul 8 21:37:07 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 21:37:07 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b97 for changeset dcde7f049111 Message-ID: <20130708213711.7CE55488BC@hg.openjdk.java.net> Changeset: b1fb4612a2ca Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b1fb4612a2ca Added tag jdk8-b97 for changeset dcde7f049111 ! .hgtags From david.katleman at oracle.com Mon Jul 8 21:36:55 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 21:36:55 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b97 for changeset 6c830db28d21 Message-ID: <20130708213659.4C3BC488BA@hg.openjdk.java.net> Changeset: 15e5bb51bc0c Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/15e5bb51bc0c Added tag jdk8-b97 for changeset 6c830db28d21 ! .hgtags From david.katleman at oracle.com Mon Jul 8 21:40:26 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 21:40:26 +0000 Subject: hg: jdk8/build/jdk: 85 new changesets Message-ID: <20130708215853.ACABF488C1@hg.openjdk.java.net> Changeset: 4b21dcfdcc3b Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b21dcfdcc3b Added tag jdk8-b97 for changeset 978a95239044 ! .hgtags Changeset: 5cfcd545ce4a Author: vadim Date: 2013-06-26 13:49 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5cfcd545ce4a 8016254: several sun/java2d/OpenGL tests failed with SIGFPE Reviewed-by: prr, bae ! src/share/native/sun/java2d/opengl/OGLContext.c Changeset: 3ffa38871143 Author: lana Date: 2013-06-28 19:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3ffa38871143 Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java - src/share/classes/sun/misc/FDBigInt.java - src/share/classes/sun/misc/Hashing.java - src/solaris/classes/sun/awt/X11/XIconInfo.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png - test/java/lang/invoke/7196190/MHProxyTest.java - test/sun/misc/Hashing.java Changeset: 6dda4a069a83 Author: prr Date: 2013-07-01 12:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6dda4a069a83 8015144: Performance regression in ICU OpenType Layout library Reviewed-by: srl, jgodinez ! make/sun/font/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/native/sun/font/layout/GlyphIterator.cpp ! src/share/native/sun/font/layout/GlyphIterator.h ! src/share/native/sun/font/layout/LETableReference.h ! src/share/native/sun/font/layout/OpenTypeUtilities.cpp Changeset: 6d2b5ec2ec79 Author: prr Date: 2013-07-02 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6d2b5ec2ec79 8019692: JDK build CC_OPT_HIGHEST setting isn't valid for Sun C++ compiler Reviewed-by: jgodinez ! make/sun/font/Makefile ! makefiles/CompileNativeLibraries.gmk Changeset: 1c607ebfc180 Author: leonidr Date: 2013-06-20 18:50 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1c607ebfc180 8014264: The applet pathguy_TimeDead throws java.lang.NullPointerException in java console once click drop-down check box. Reviewed-by: art, anthony, serb ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java Changeset: b7b95b7ab2cb Author: malenkov Date: 2013-06-21 17:13 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b7b95b7ab2cb 8016545: java.beans.XMLEncoder.writeObject output is wrong Reviewed-by: alexsch ! src/share/classes/java/beans/XMLEncoder.java + test/java/beans/XMLEncoder/Test8016545.java Changeset: eed321190272 Author: alitvinov Date: 2013-06-21 21:30 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eed321190272 8007642: Media Names on Java Print Do Not Match the Printer?s and Confuse Users Reviewed-by: prr, jgodinez ! src/windows/classes/sun/print/Win32PrintService.java Changeset: e5bac76282f7 Author: pchelko Date: 2013-06-27 13:56 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e5bac76282f7 8019236: [macosx] Add javadoc to the handleWindowFocusEvent in CEmbeddedFrame Reviewed-by: serb, ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: 72f167edf630 Author: dmarkov Date: 2013-06-28 18:32 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/72f167edf630 8016534: javax/swing/text/View/8014863/bug8014863.java failed Reviewed-by: alexp, alexsch ! test/javax/swing/text/View/8014863/bug8014863.java Changeset: 228ec4b9111a Author: lana Date: 2013-06-28 18:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/228ec4b9111a Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java - src/share/classes/sun/misc/FDBigInt.java - src/share/classes/sun/misc/Hashing.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java - src/solaris/classes/sun/awt/X11/XIconInfo.java ! src/solaris/classes/sun/awt/X11/XListPeer.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png ! src/windows/classes/sun/print/Win32PrintService.java - test/java/lang/invoke/7196190/MHProxyTest.java - test/sun/misc/Hashing.java Changeset: 6fc558b41d8e Author: lana Date: 2013-07-02 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6fc558b41d8e Merge Changeset: 656ea2349aa5 Author: psandoz Date: 2013-06-20 10:45 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/656ea2349aa5 8016308: Updates to j.u.stream.Node/Nodes Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/SliceOps.java ! test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java ! test/java/util/stream/boottest/java/util/stream/IntNodeTest.java ! test/java/util/stream/boottest/java/util/stream/LongNodeTest.java Changeset: 85524d9839dc Author: psandoz Date: 2013-06-20 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/85524d9839dc 8016324: filter/flatMap pipeline sinks should pass size information to downstream sink Reviewed-by: chegar, mduigou Contributed-by: Brian Goetz ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/ReferencePipeline.java Changeset: f758d7c24396 Author: psandoz Date: 2013-06-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f758d7c24396 8016455: Sync stream tests from lambda to tl Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java ! test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/bootlib/java/util/stream/LoggingTestCase.java ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java ! test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java ! test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java ! test/java/util/stream/boottest/java/util/stream/IntNodeTest.java ! test/java/util/stream/boottest/java/util/stream/LongNodeTest.java ! test/java/util/stream/boottest/java/util/stream/NodeTest.java ! test/java/util/stream/boottest/java/util/stream/UnorderedTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java Changeset: 562f5cf13a9c Author: psandoz Date: 2013-06-20 11:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/562f5cf13a9c 8016139: PrimitiveIterator.forEachRemaining Reviewed-by: alanb ! src/share/classes/java/util/PrimitiveIterator.java Changeset: a44bd993ce93 Author: xuelei Date: 2013-06-20 07:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a44bd993ce93 8017157: catch more exception in test RejectClientRenego Reviewed-by: vinnie ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectClientRenego.java Changeset: 49b78ec058fb Author: mduigou Date: 2013-06-20 07:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/49b78ec058fb 8017088: Map/HashMap.compute() incorrect with key mapping to null value Reviewed-by: dl, dholmes, plevart ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Map.java ! test/java/util/Map/Defaults.java Changeset: 9fa37bd38d4b Author: mduigou Date: 2013-06-20 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9fa37bd38d4b Merge Changeset: bf2bacf934d1 Author: chegar Date: 2013-06-20 18:53 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bf2bacf934d1 8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx) Reviewed-by: alanb, chegar Contributed-by: John Zavgren , Chris Hegarty ! src/solaris/native/java/net/PlainDatagramSocketImpl.c + test/java/net/MulticastSocket/Promiscuous.java Changeset: cd06fc069152 Author: alanb Date: 2013-06-20 19:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd06fc069152 8014377: (dc) DatagramChannel should set IP_MULTICAST_ALL=0 (lnx) Reviewed-by: chegar, jzavgren ! src/solaris/native/sun/nio/ch/Net.c + test/java/nio/channels/DatagramChannel/Promiscuous.java Changeset: 4503e04141f7 Author: weijun Date: 2013-06-21 18:26 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4503e04141f7 8001326: Improve Kerberos caching Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/AcceptSecContextToken.java ! src/share/classes/sun/security/krb5/EncryptionKey.java ! src/share/classes/sun/security/krb5/KrbApRep.java ! src/share/classes/sun/security/krb5/KrbApReq.java + src/share/classes/sun/security/krb5/internal/ReplayCache.java + src/share/classes/sun/security/krb5/internal/rcache/AuthList.java ! src/share/classes/sun/security/krb5/internal/rcache/AuthTime.java + src/share/classes/sun/security/krb5/internal/rcache/AuthTimeWithHash.java - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java + src/share/classes/sun/security/krb5/internal/rcache/DflCache.java + src/share/classes/sun/security/krb5/internal/rcache/MemoryCache.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java + test/java/security/testlibrary/Proc.java ! test/sun/security/krb5/auto/AcceptorSubKey.java + test/sun/security/krb5/auto/BasicProc.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/NoneReplayCacheTest.java - test/sun/security/krb5/auto/ReplayCache.java + test/sun/security/krb5/auto/ReplayCacheExpunge.java + test/sun/security/krb5/auto/ReplayCachePrecise.java + test/sun/security/krb5/auto/ReplayCacheTest.java + test/sun/security/krb5/auto/ReplayCacheTestProc.java ! test/sun/security/krb5/ccache/EmptyCC.java Changeset: a88f6f4d279f Author: bpb Date: 2013-06-21 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a88f6f4d279f 7192954: Fix Float.parseFloat to round correctly and preserve monotonicity. 4396272: Parsing doubles fails to follow IEEE for largest decimal that should yield 0 7039391: Use Math.ulp in FloatingDecimal Summary: Correct rounding and monotonicity problems in floats and doubles Reviewed-by: bpb, martin Contributed-by: Dmitry Nadezhin , Louis Wasserman ! src/share/classes/sun/misc/FDBigInteger.java ! src/share/classes/sun/misc/FloatingDecimal.java ! test/java/lang/Double/ParseDouble.java ! test/java/lang/Float/ParseFloat.java ! test/sun/misc/FloatingDecimal/TestFDBigInteger.java Changeset: 814759462705 Author: bpb Date: 2013-06-21 11:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/814759462705 7131192: BigInteger.doubleValue() is depressingly slow Summary: In doubleValue() and floatValue() replace converting to String and parsing to Double or Float with direct conversion into IEEE 754 bits. Reviewed-by: bpb, drchase, martin Contributed-by: Louis Wasserman ! src/share/classes/java/math/BigInteger.java + test/java/math/BigInteger/PrimitiveConversionTests.java Changeset: 8b84d557570c Author: naoto Date: 2013-06-21 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b84d557570c 6863624: java/util/Currency/PropertiesTest.sh writable check is incorrect Reviewed-by: alanb ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: cb3f3a05eee3 Author: chegar Date: 2013-06-22 08:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cb3f3a05eee3 8017271: Crash may occur in java.net.DualStackPlainSocketImpl::initIDs due to unchecked values returned from JNI functions Reviewed-by: alanb, khazra ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/windows/native/java/net/DualStackPlainSocketImpl.c Changeset: fd050ba1cf72 Author: arieber Date: 2013-06-22 08:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fd050ba1cf72 7157360: HttpURLConnection: HTTP method DELETE doesn't support output Reviewed-by: chegar ! src/share/classes/sun/net/www/http/PosterOutputStream.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/http/HttpURLConnection/PostOnDelete.java Changeset: 1bf060029a5d Author: weijun Date: 2013-06-24 16:25 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1bf060029a5d 8017453: ReplayCache tests fail on multiple platforms Reviewed-by: xuelei ! test/sun/security/krb5/auto/ReplayCacheExpunge.java ! test/sun/security/krb5/auto/ReplayCacheTestProc.java Changeset: 5f80b8cee601 Author: alanb Date: 2013-06-24 11:26 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5f80b8cee601 8017477: Remove TimeZone.DisplayNames, no longer used Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java Changeset: bb2e67628dc0 Author: naoto Date: 2013-06-24 16:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb2e67628dc0 8017468: typo in javadoc: " ResourceBunlde " Reviewed-by: okutsu ! src/share/classes/java/util/spi/LocaleServiceProvider.java Changeset: eabcb85fcabc Author: bpb Date: 2013-06-24 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eabcb85fcabc 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: iris, darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formatter.java ! src/share/classes/sun/misc/FloatingDecimal.java ! test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/Basic.java ! test/java/util/Formatter/BasicBigDecimal.java ! test/java/util/Formatter/BasicDouble.java ! test/java/util/Formatter/BasicDoubleObject.java ! test/java/util/Formatter/BasicFloat.java ! test/java/util/Formatter/BasicFloatObject.java Changeset: 82e7682c17e2 Author: darcy Date: 2013-06-24 23:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/82e7682c17e2 8017550: Fix doclint issues in java.lang and subpackages Reviewed-by: alanb, chegar ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/lang/SuppressWarnings.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/annotation/Annotation.java ! src/share/classes/java/lang/annotation/Repeatable.java ! src/share/classes/java/lang/annotation/Retention.java ! src/share/classes/java/lang/annotation/Target.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/java/lang/reflect/TypeVariable.java Changeset: 4a4d910e1504 Author: alanb Date: 2013-06-25 13:53 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a4d910e1504 8017570: jfr.jar should not be in compact3 (for now) Reviewed-by: erikj ! makefiles/profile-includes.txt Changeset: 01fcca3d2b8c Author: bpb Date: 2013-06-20 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/01fcca3d2b8c 4641897: Faster string conversion of large integers Summary: Accelerate conversion to string by means of Schoenhage recursive base conversion. Reviewed-by: bpb, alanb Contributed-by: Alan Eliasen ! src/share/classes/java/math/BigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java Changeset: 89631a384ee6 Author: weijun Date: 2013-06-25 21:51 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/89631a384ee6 8016051: Possible ClassCastException in KdcComm Reviewed-by: weijun Contributed-by: Artem Smotrakov ! src/share/classes/sun/security/krb5/KdcComm.java Changeset: ac61efd8c593 Author: shade Date: 2013-06-25 20:06 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac61efd8c593 8014233: java.lang.Thread should have @Contended on TLR fields Summary: add the @Contended over three TLR fields. Reviewed-by: psandoz, chegar, dholmes, dl ! src/share/classes/java/lang/Thread.java Changeset: 757290440a2f Author: juh Date: 2013-06-25 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/757290440a2f 8017325: Cleanup of the javadoc tag in java.security.cert Summary: Convert javadoc ... and ... tags to {@code ...} Reviewed-by: darcy ! src/share/classes/java/security/cert/CRLException.java ! src/share/classes/java/security/cert/CRLSelector.java ! src/share/classes/java/security/cert/CertPath.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathBuilderException.java ! src/share/classes/java/security/cert/CertPathBuilderResult.java ! src/share/classes/java/security/cert/CertPathBuilderSpi.java ! src/share/classes/java/security/cert/CertPathParameters.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertPathValidatorException.java ! src/share/classes/java/security/cert/CertPathValidatorResult.java ! src/share/classes/java/security/cert/CertPathValidatorSpi.java ! src/share/classes/java/security/cert/CertSelector.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/java/security/cert/CertStoreException.java ! src/share/classes/java/security/cert/CertStoreParameters.java ! src/share/classes/java/security/cert/CertStoreSpi.java ! src/share/classes/java/security/cert/Certificate.java ! src/share/classes/java/security/cert/CertificateEncodingException.java ! src/share/classes/java/security/cert/CertificateException.java ! src/share/classes/java/security/cert/CertificateExpiredException.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/CertificateFactorySpi.java ! src/share/classes/java/security/cert/CertificateNotYetValidException.java ! src/share/classes/java/security/cert/CertificateParsingException.java ! src/share/classes/java/security/cert/CertificateRevokedException.java ! src/share/classes/java/security/cert/CollectionCertStoreParameters.java ! src/share/classes/java/security/cert/Extension.java ! src/share/classes/java/security/cert/LDAPCertStoreParameters.java ! src/share/classes/java/security/cert/PKIXBuilderParameters.java ! src/share/classes/java/security/cert/PKIXCertPathBuilderResult.java ! src/share/classes/java/security/cert/PKIXCertPathChecker.java ! src/share/classes/java/security/cert/PKIXCertPathValidatorResult.java ! src/share/classes/java/security/cert/PKIXParameters.java ! src/share/classes/java/security/cert/PKIXReason.java ! src/share/classes/java/security/cert/PolicyNode.java ! src/share/classes/java/security/cert/PolicyQualifierInfo.java ! src/share/classes/java/security/cert/TrustAnchor.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509CRLEntry.java ! src/share/classes/java/security/cert/X509CRLSelector.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/security/cert/X509Certificate.java ! src/share/classes/java/security/cert/X509Extension.java Changeset: 3700bb58c9a2 Author: juh Date: 2013-06-25 14:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3700bb58c9a2 8017326: Cleanup of the javadoc tag in java.security.spec Summary: Convert javadoc and tags to {@code ...} Reviewed-by: darcy ! src/share/classes/java/security/spec/DSAGenParameterSpec.java ! src/share/classes/java/security/spec/DSAParameterSpec.java ! src/share/classes/java/security/spec/DSAPrivateKeySpec.java ! src/share/classes/java/security/spec/DSAPublicKeySpec.java ! src/share/classes/java/security/spec/ECFieldF2m.java ! src/share/classes/java/security/spec/ECFieldFp.java ! src/share/classes/java/security/spec/ECGenParameterSpec.java ! src/share/classes/java/security/spec/ECParameterSpec.java ! src/share/classes/java/security/spec/ECPoint.java ! src/share/classes/java/security/spec/ECPrivateKeySpec.java ! src/share/classes/java/security/spec/ECPublicKeySpec.java ! src/share/classes/java/security/spec/EllipticCurve.java ! src/share/classes/java/security/spec/EncodedKeySpec.java ! src/share/classes/java/security/spec/InvalidKeySpecException.java ! src/share/classes/java/security/spec/KeySpec.java ! src/share/classes/java/security/spec/MGF1ParameterSpec.java ! src/share/classes/java/security/spec/PKCS8EncodedKeySpec.java ! src/share/classes/java/security/spec/PSSParameterSpec.java ! src/share/classes/java/security/spec/RSAKeyGenParameterSpec.java ! src/share/classes/java/security/spec/RSAMultiPrimePrivateCrtKeySpec.java ! src/share/classes/java/security/spec/RSAOtherPrimeInfo.java ! src/share/classes/java/security/spec/RSAPrivateCrtKeySpec.java ! src/share/classes/java/security/spec/X509EncodedKeySpec.java Changeset: 510035b7bbbb Author: yhuang Date: 2013-06-25 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/510035b7bbbb 8013836: getFirstDayOfWeek reports wrong day for pt-BR locale Reviewed-by: naoto + src/share/classes/sun/util/resources/pt/CalendarData_pt_BR.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 0822bcddbd4f Author: xuelei Date: 2013-06-26 06:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0822bcddbd4f 8017049: rename property jdk.tls.rejectClientInitializedRenego Reviewed-by: vinnie, wetmore, mullan ! src/share/classes/sun/security/ssl/Handshaker.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NoImpactServerRenego.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectClientRenego.java Changeset: e83cdd58f1cf Author: chegar Date: 2013-06-26 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e83cdd58f1cf 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum) Reviewed-by: chegar, alanb, psandoz Contributed-by: Doug Lea
, Tristan Yan , Chris Hegarty + src/share/classes/java/util/ArrayPrefixHelpers.java ! src/share/classes/java/util/Arrays.java + test/java/util/Arrays/ParallelPrefix.java Changeset: 71059bca036a Author: rfield Date: 2013-06-26 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/71059bca036a 8016761: Lambda metafactory - incorrect type conversion of constructor method handle Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaConstructorMethodHandleUnbox.java Changeset: 336e5a862013 Author: naoto Date: 2013-06-26 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/336e5a862013 8017322: java/util/Currency/PropertiesTest.sh should run exclusively Reviewed-by: alanb ! test/TEST.ROOT Changeset: 1fda8fa7ae97 Author: darcy Date: 2013-06-26 13:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1fda8fa7ae97 7018139: Fix HTML accessibility and doclint issues in java.math Reviewed-by: lancea, bpb ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/RoundingMode.java Changeset: a5aa57eb85b6 Author: darcy Date: 2013-06-26 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a5aa57eb85b6 8019223: Fix doclint warnings in java.rmi.server Reviewed-by: smarks ! src/share/classes/java/rmi/server/RMIClassLoader.java Changeset: ac65905883a7 Author: darcy Date: 2013-06-26 22:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac65905883a7 8019228: Fix doclint issues in java.util.zip Reviewed-by: sherman, mchung ! src/share/classes/java/util/zip/Deflater.java ! src/share/classes/java/util/zip/Inflater.java Changeset: 370e7beff8a0 Author: wetmore Date: 2013-06-27 10:19 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/370e7beff8a0 8019227: JDK-8010325 broke the old build Reviewed-by: alanb, chegar ! make/java/java/FILES_java.gmk Changeset: 4e69a7dfbeac Author: chegar Date: 2013-06-27 10:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4e69a7dfbeac Merge Changeset: 1c31082f0a51 Author: darcy Date: 2013-06-27 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1c31082f0a51 8019304: Fix doclint issues in java.util.prefs Reviewed-by: lancea ! src/share/classes/java/util/prefs/AbstractPreferences.java ! src/share/classes/java/util/prefs/PreferencesFactory.java Changeset: b9ba04dc210f Author: lancea Date: 2013-06-27 15:07 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b9ba04dc210f 8017471: Fix JDBC -Xdoclint public errors Reviewed-by: darcy ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/NClob.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Wrapper.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/RowSetWarning.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java Changeset: b8f16cb2d95b Author: darcy Date: 2013-06-27 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b8f16cb2d95b 8019315: Fix doclint issues in java.util.logging Reviewed-by: lancea ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java Changeset: 6729f7ef94cd Author: smarks Date: 2013-06-27 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6729f7ef94cd 8019224: add exception chaining to RMI CGIHandler Reviewed-by: darcy ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java Changeset: 1099fe14fb65 Author: darcy Date: 2013-06-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1099fe14fb65 8019320: Fix doclint issues in javax.script Reviewed-by: lancea ! src/share/classes/javax/script/Invocable.java ! src/share/classes/javax/script/ScriptContext.java ! src/share/classes/javax/script/ScriptEngineFactory.java ! src/share/classes/javax/script/SimpleScriptContext.java Changeset: e34e3ddb3cd8 Author: naoto Date: 2013-06-27 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e34e3ddb3cd8 6609431: (rb) ResourceBundle.getString() returns incorrect value Reviewed-by: okutsu, sherman ! src/share/classes/java/util/Properties.java + test/java/util/Properties/Bug6609431.java + test/java/util/Properties/Bug6609431.properties Changeset: 29bbbb136bc5 Author: darcy Date: 2013-06-27 19:02 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/29bbbb136bc5 8019357: Fix doclint warnings in java.lang.invoke Reviewed-by: jrose ! src/share/classes/java/lang/invoke/LambdaConversionException.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SerializedLambda.java ! src/share/classes/java/lang/invoke/package-info.java Changeset: 60d1994f63f7 Author: xuelei Date: 2013-06-27 19:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/60d1994f63f7 8019359: To comment why not use no_renegotiation to reject client initiated renegotiation Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/ServerHandshaker.java Changeset: c1df54fd19b2 Author: henryjen Date: 2013-06-11 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c1df54fd19b2 8009736: Comparator API cleanup Reviewed-by: psandoz, briangoetz, mduigou, plevart ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Comparator.java ! src/share/classes/java/util/Comparators.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/SortedOps.java ! test/java/nio/file/Files/StreamTest.java ! test/java/util/Collection/ListDefaults.java + test/java/util/Comparator/BasicTest.java + test/java/util/Comparator/TypeTest.java - test/java/util/Comparators/BasicTest.java + test/java/util/Map/EntryComparators.java + test/java/util/function/BinaryOperator/BasicTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java ! test/sun/misc/JavaLangAccess/NewUnsafeString.java Changeset: 28b71c97a72d Author: psandoz Date: 2013-06-28 10:29 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/28b71c97a72d 8012987: Optimizations for Stream.limit/substream Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/AbstractTask.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/ForEachOps.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/PipelineHelper.java ! src/share/classes/java/util/stream/SliceOps.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java ! test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java + test/java/util/stream/boottest/java/util/stream/SliceSpliteratorTest.java ! test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java Changeset: 19a6d2d701d9 Author: sla Date: 2013-06-26 19:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/19a6d2d701d9 8019155: Update makefiles with correct jfr packages Reviewed-by: mgronlun, erikj ! make/common/Release.gmk ! makefiles/CreateJars.gmk Changeset: 04378a645944 Author: alanb Date: 2013-06-28 16:10 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/04378a645944 8019380: doclint warnings in java.nio, java.nio.file.**, java.nio.channels.** Reviewed-by: chegar ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/MappedByteBuffer.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/AsynchronousByteChannel.java ! src/share/classes/java/nio/channels/AsynchronousChannel.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/FileLock.java ! src/share/classes/java/nio/channels/MulticastChannel.java ! src/share/classes/java/nio/channels/NetworkChannel.java ! src/share/classes/java/nio/channels/Pipe.java ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/SelectionKey.java ! src/share/classes/java/nio/channels/Selector.java ! src/share/classes/java/nio/channels/ServerSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelector.java ! src/share/classes/java/nio/channels/spi/AsynchronousChannelProvider.java ! src/share/classes/java/nio/channels/spi/SelectorProvider.java ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/charset/CoderResult.java ! src/share/classes/java/nio/charset/spi/CharsetProvider.java ! src/share/classes/java/nio/file/FileStore.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/FileSystems.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java ! src/share/classes/java/nio/file/WatchEvent.java ! src/share/classes/java/nio/file/WatchService.java ! src/share/classes/java/nio/file/attribute/AclEntry.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/AttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java ! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileAttribute.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/java/sql/SQLInput.java Changeset: 1919c226b427 Author: dl Date: 2013-06-28 12:10 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1919c226b427 8017739: ReentrantReadWriteLock is confused by the Threads with reused IDs Reviewed-by: chegar ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java Changeset: 0e24065a75db Author: dl Date: 2013-06-28 12:12 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0e24065a75db 8019377: Sync j.u.c locks and atomic from 166 to tl Reviewed-by: chegar ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicMarkableReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java ! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java ! src/share/classes/java/util/concurrent/atomic/DoubleAdder.java ! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java ! src/share/classes/java/util/concurrent/atomic/Striped64.java ! src/share/classes/java/util/concurrent/atomic/package-info.java ! src/share/classes/java/util/concurrent/locks/AbstractOwnableSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! src/share/classes/java/util/concurrent/locks/Lock.java ! src/share/classes/java/util/concurrent/locks/LockSupport.java ! src/share/classes/java/util/concurrent/locks/ReadWriteLock.java ! src/share/classes/java/util/concurrent/locks/ReentrantLock.java ! src/share/classes/java/util/concurrent/locks/StampedLock.java Changeset: ff0242ed08db Author: jzavgren Date: 2013-06-28 16:38 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ff0242ed08db 8015799: HttpURLConnection.getHeaderFields() throws IllegalArgumentException Reviewed-by: chegar, dsamersoff, khazra ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/CookieHandler/EmptyCookieHeader.java Changeset: 52b4527d3fc7 Author: chegar Date: 2013-06-28 16:39 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/52b4527d3fc7 Merge Changeset: 389f59e6288f Author: juh Date: 2013-06-28 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/389f59e6288f 8019360: Cleanup of the javadoc tag in java.security.* Summary: Convert to {@code ...} tags. convert package.html to package-info.java. Reviewed-by: darcy ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessControlException.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/AlgorithmParameterGeneratorSpi.java ! src/share/classes/java/security/AlgorithmParameters.java ! src/share/classes/java/security/AlgorithmParametersSpi.java ! src/share/classes/java/security/AllPermission.java ! src/share/classes/java/security/AuthProvider.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/Certificate.java ! src/share/classes/java/security/CodeSigner.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/DigestException.java ! src/share/classes/java/security/DigestInputStream.java ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/java/security/DomainCombiner.java ! src/share/classes/java/security/GeneralSecurityException.java ! src/share/classes/java/security/Guard.java ! src/share/classes/java/security/GuardedObject.java ! src/share/classes/java/security/Identity.java ! src/share/classes/java/security/IdentityScope.java ! src/share/classes/java/security/InvalidAlgorithmParameterException.java ! src/share/classes/java/security/InvalidKeyException.java ! src/share/classes/java/security/Key.java ! src/share/classes/java/security/KeyException.java ! src/share/classes/java/security/KeyFactory.java ! src/share/classes/java/security/KeyFactorySpi.java ! src/share/classes/java/security/KeyManagementException.java ! src/share/classes/java/security/KeyPair.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyPairGeneratorSpi.java ! src/share/classes/java/security/KeyRep.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/KeyStoreException.java ! src/share/classes/java/security/KeyStoreSpi.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/MessageDigestSpi.java ! src/share/classes/java/security/NoSuchAlgorithmException.java ! src/share/classes/java/security/Permission.java ! src/share/classes/java/security/PermissionCollection.java ! src/share/classes/java/security/Permissions.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/PolicySpi.java ! src/share/classes/java/security/PrivilegedAction.java ! src/share/classes/java/security/PrivilegedActionException.java ! src/share/classes/java/security/PrivilegedExceptionAction.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/ProviderException.java ! src/share/classes/java/security/PublicKey.java ! src/share/classes/java/security/SecureClassLoader.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/SecureRandomSpi.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/SecurityPermission.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/SignatureException.java ! src/share/classes/java/security/SignatureSpi.java ! src/share/classes/java/security/SignedObject.java ! src/share/classes/java/security/Signer.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/acl/Acl.java ! src/share/classes/java/security/acl/AclEntry.java ! src/share/classes/java/security/acl/Group.java ! src/share/classes/java/security/acl/Owner.java + src/share/classes/java/security/acl/package-info.java - src/share/classes/java/security/acl/package.html + src/share/classes/java/security/cert/package-info.java - src/share/classes/java/security/cert/package.html ! src/share/classes/java/security/interfaces/DSAKeyPairGenerator.java ! src/share/classes/java/security/interfaces/DSAParams.java ! src/share/classes/java/security/interfaces/DSAPrivateKey.java ! src/share/classes/java/security/interfaces/DSAPublicKey.java + src/share/classes/java/security/interfaces/package-info.java - src/share/classes/java/security/interfaces/package.html + src/share/classes/java/security/package-info.java - src/share/classes/java/security/package.html + src/share/classes/java/security/spec/package-info.java - src/share/classes/java/security/spec/package.html Changeset: 9d175c6cb527 Author: darcy Date: 2013-06-28 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9d175c6cb527 8019407: Fix doclint issues in javax.naming.* Reviewed-by: lancea ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/CompoundName.java ! src/share/classes/javax/naming/Context.java ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/RefAddr.java ! src/share/classes/javax/naming/ReferralException.java ! src/share/classes/javax/naming/directory/DirContext.java ! src/share/classes/javax/naming/event/EventContext.java ! src/share/classes/javax/naming/ldap/ControlFactory.java ! src/share/classes/javax/naming/ldap/InitialLdapContext.java ! src/share/classes/javax/naming/ldap/LdapContext.java Changeset: 389b8739a74e Author: alanb Date: 2013-06-28 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/389b8739a74e 8019384: jps and jcmd tests fail when there is a process started with a .war file Reviewed-by: dcubed, sla, mchung ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk ! test/sun/tools/jps/jps_Output1.awk Changeset: b4d36f3717b8 Author: lana Date: 2013-06-28 19:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b4d36f3717b8 Merge Changeset: a4eb59bffb60 Author: lancea Date: 2013-06-29 06:12 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a4eb59bffb60 8019286: Fix javadoc typo in ResultSet.next Reviewed-by: darcy, mchung ! src/share/classes/java/sql/ResultSet.java Changeset: bf650fee4983 Author: darcy Date: 2013-06-30 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bf650fee4983 8019466: Fix doclint issues in java.util.function Reviewed-by: briangoetz ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/UnaryOperator.java Changeset: 9eaeb1a0aa46 Author: darcy Date: 2013-06-30 17:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9eaeb1a0aa46 8019467: Fix doclint issues in java.util.jar.Pack200 Reviewed-by: lancea, ksrini ! src/share/classes/java/util/jar/Pack200.java Changeset: 3aa541b50a64 Author: dfuchs Date: 2013-07-01 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3aa541b50a64 8014045: test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Summary: this test was failing because it didn't take into account the fact that Loggers could be garbage collected. Reviewed-by: mchung ! test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java Changeset: dfb37cc30a67 Author: vinnie Date: 2013-07-01 14:39 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dfb37cc30a67 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! test/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java Changeset: c8cf01de8fa8 Author: bpb Date: 2013-07-01 11:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c8cf01de8fa8 8017540: Improve multi-threaded contention behavior of radix conversion cache Summary: Replace array of ArrayList of BigIntegers with a volatile two-dimensional BigInteger array eliminate the synchronization of getRadixConversionCache() Reviewed-by: plevart, shade, bpb, alanb Contributed-by: Peter Levart , Dmitry Nadezhin , Aleksey Shipilev ! src/share/classes/java/math/BigInteger.java Changeset: 3736ad2636aa Author: darcy Date: 2013-07-01 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3736ad2636aa 8019527: Fix doclint issues in java.lang.instrument Reviewed-by: lancea, alanb ! src/share/classes/java/lang/instrument/Instrumentation.java Changeset: 8e5376324e4b Author: darcy Date: 2013-07-01 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8e5376324e4b 8019529: Fix doclint issues in java.util.spi Reviewed-by: lancea ! src/share/classes/java/util/spi/LocaleServiceProvider.java Changeset: 5427f7316633 Author: darcy Date: 2013-07-01 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5427f7316633 8019535: Fix doclint issues in java.time.format Reviewed-by: lancea, rriggs ! src/share/classes/java/time/format/DateTimeFormatter.java Changeset: 17f44b2dde41 Author: juh Date: 2013-07-01 17:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/17f44b2dde41 8019539: Fix doclint errors in java.security and its subpackages Reviewed-by: darcy ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509CRLEntry.java ! src/share/classes/java/security/cert/X509Certificate.java Changeset: 020f023f87d1 Author: dfuchs Date: 2013-07-02 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/020f023f87d1 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Summary: This patch makes sure that LoggerContext instances created for applets have a root and global logger. Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java ! test/java/util/logging/LogManagerInstanceTest.java + test/java/util/logging/TestAppletLoggerContext.java Changeset: b1fffbbdf58c Author: ksrini Date: 2013-07-02 05:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b1fffbbdf58c 8017463: [TEST_BUG] 2 tests from tools/pack200/ remain about 1 GB of data in work directory after execution Reviewed-by: mchung ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/BandIntegrity.java ! test/tools/pack200/CommandLineTests.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Pack200Props.java ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/PackageVersionTest.java ! test/tools/pack200/RepackTest.java ! test/tools/pack200/T7007157.java ! test/tools/pack200/TestExceptions.java ! test/tools/pack200/TimeStamp.java ! test/tools/pack200/UnpackerMemoryTest.java ! test/tools/pack200/Utils.java ! test/tools/pack200/typeannos/TestTypeAnnotations.java Changeset: 70bff2d12af0 Author: dfuchs Date: 2013-07-02 19:47 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/70bff2d12af0 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration Summary: Due to subtle synchronization issues between LogManager & Logger class initialization the global logger doesn't have its 'manager' field initialized until the LogManager is initialized. This fix will ensure that the global logger has its 'manager' field set when getGlobal() is called. Reviewed-by: mchung, plevart ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/Logger/getGlobal/TestGetGlobal.java + test/java/util/logging/Logger/getGlobal/TestGetGlobalByName.java + test/java/util/logging/Logger/getGlobal/TestGetGlobalConcurrent.java + test/java/util/logging/Logger/getGlobal/logging.properties + test/java/util/logging/Logger/getGlobal/policy + test/java/util/logging/Logger/getGlobal/testgetglobal/BadLogManagerImpl.java + test/java/util/logging/Logger/getGlobal/testgetglobal/DummyLogManagerImpl.java + test/java/util/logging/Logger/getGlobal/testgetglobal/HandlerImpl.java + test/java/util/logging/Logger/getGlobal/testgetglobal/LogManagerImpl1.java + test/java/util/logging/Logger/getGlobal/testgetglobal/LogManagerImpl2.java + test/java/util/logging/Logger/getGlobal/testgetglobal/LogManagerImpl3.java Changeset: 11c074904fce Author: lana Date: 2013-07-02 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/11c074904fce Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: 974b94f944ce Author: lana Date: 2013-07-03 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/974b94f944ce Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: f2342dedf04a Author: lana Date: 2013-07-05 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f2342dedf04a Merge Changeset: c4908732fef5 Author: katleman Date: 2013-07-08 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c4908732fef5 Merge From david.katleman at oracle.com Mon Jul 8 22:04:13 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 22:04:13 +0000 Subject: hg: jdk8/build/nashorn: 33 new changesets Message-ID: <20130708220439.B7052488C4@hg.openjdk.java.net> Changeset: da63a99481da Author: cl Date: 2013-07-04 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/da63a99481da Added tag jdk8-b97 for changeset 1bf1d6ce3042 ! .hgtags Changeset: 6a75a505301f Author: sundar Date: 2013-06-18 18:43 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/6a75a505301f 8012698: [nashorn] tests fail to run with agentvm or samevm Reviewed-by: hannesw, jlaskey ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java Changeset: 7276d66b7118 Author: jlaskey Date: 2013-06-19 09:10 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/7276d66b7118 8010697: DeletedArrayFilter seems to leak memory Reviewed-by: hannesw, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java + test/script/basic/JDK-8010697.js + test/script/basic/JDK-8010697.js.EXPECTED Changeset: c7c9222cfe69 Author: sundar Date: 2013-06-19 21:07 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/c7c9222cfe69 8015347: Parsing issue with decodeURIComponent Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/URIUtils.java + test/script/basic/JDK-8015347.js Changeset: ac404bf3f8c8 Author: sundar Date: 2013-06-20 13:45 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ac404bf3f8c8 8017046: Cannot assign undefined to a function argument if the function uses arguments object Reviewed-by: hannesw ! src/jdk/nashorn/internal/objects/NativeArguments.java + test/script/basic/JDK-8017046.js Changeset: c7672e621b14 Author: sundar Date: 2013-06-20 17:34 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/c7672e621b14 Merge Changeset: 8e03121cc286 Author: sundar Date: 2013-06-21 16:55 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/8e03121cc286 8017260: adjust lookup code in objects.* classes Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java Changeset: b4e2bccf9598 Author: sundar Date: 2013-06-21 17:33 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/b4e2bccf9598 Merge Changeset: c30beaf3c42a Author: jlaskey Date: 2013-06-21 14:34 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/c30beaf3c42a 8010732: BigDecimal, BigInteger and Long handling in nashorn Reviewed-by: sundar Contributed-by: james.laskey at oracle.com + test/script/basic/JDK-8010732.js + test/script/basic/JDK-8010732.js.EXPECTED Changeset: 2ded2fc08c94 Author: jlaskey Date: 2013-06-22 10:12 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/2ded2fc08c94 8017448: JDK-8010732.js.EXPECTED truncated Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! test/script/basic/JDK-8010732.js.EXPECTED Changeset: 51a5ee93d6bc Author: sundar Date: 2013-06-24 19:06 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/51a5ee93d6bc 8015959: Can't call foreign constructor Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java + test/script/basic/JDK-8015959.js + test/script/basic/JDK-8015959.js.EXPECTED Changeset: 26a345c26e62 Author: sundar Date: 2013-06-25 17:31 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/26a345c26e62 8015969: Needs to enforce and document that global "context" and "engine" can't be modified when running via jsr223 Reviewed-by: hannesw, jlaskey ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java + test/script/basic/JDK-8015969.js Changeset: 39e17373d8df Author: sundar Date: 2013-06-26 16:36 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/39e17373d8df 8017950: error.stack should be a string rather than an array Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! test/script/basic/JDK-8012164.js ! test/script/basic/JDK-8012164.js.EXPECTED + test/script/basic/JDK-8017950.js + test/script/basic/JDK-8017950.js.EXPECTED ! test/script/basic/NASHORN-109.js ! test/script/basic/NASHORN-296.js ! test/script/basic/errorstack.js Changeset: 682889823712 Author: jlaskey Date: 2013-06-26 08:36 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/682889823712 8008458: Strict functions dont share property map Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java Changeset: 80c66d3fd872 Author: hannesw Date: 2013-06-26 15:40 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/80c66d3fd872 8019157: Avoid calling ScriptObject.setProto() if possible Reviewed-by: jlaskey, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/FunctionScope.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/scripts/JO.java Changeset: 635098f9f45e Author: sundar Date: 2013-06-26 19:42 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/635098f9f45e 8014781: support Error.captureStackTrace Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/objects/NativeError.java + test/script/basic/JDK-8014781.js + test/script/basic/JDK-8014781.js.EXPECTED Changeset: d1886ad46f0c Author: jlaskey Date: 2013-06-26 12:38 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d1886ad46f0c 8019175: Simplify ScriptObject.modifyOwnProperty Reviewed-by: hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java Changeset: f9c855b828fe Author: sundar Date: 2013-06-27 13:24 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/f9c855b828fe 8019226: line number not generated for first statement if it is on the same function declaration line Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8019226.js + test/script/basic/JDK-8019226.js.EXPECTED Changeset: 5ec4762d9df0 Author: sundar Date: 2013-06-27 13:47 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/5ec4762d9df0 Merge Changeset: 90864d892593 Author: lana Date: 2013-06-28 19:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/90864d892593 Merge Changeset: 218c2833c344 Author: sundar Date: 2013-06-28 19:36 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/218c2833c344 8019365: Error stack format Reviewed-by: hannesw ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/objects/NativeError.java ! test/script/basic/JDK-8014781.js.EXPECTED ! test/script/basic/JDK-8017950.js.EXPECTED ! test/script/basic/JDK-8019226.js ! test/script/basic/JDK-8019226.js.EXPECTED Changeset: 02588d68399d Author: sundar Date: 2013-07-01 12:38 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/02588d68399d 8019473: Parser issues related to functions and blocks Reviewed-by: lagergren ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8019473.js Changeset: 10c7a1e9e24f Author: sundar Date: 2013-07-01 14:15 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/10c7a1e9e24f 8019478: Object.prototype.toString.call(/a/.exec("a")) === "[object Array]" should be true Reviewed-by: hannesw ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java + test/script/basic/JDK-8019478.js Changeset: 47099609a48b Author: sundar Date: 2013-07-01 17:21 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/47099609a48b 8019482: Number("0x0.0p0") should evaluate to NaN Reviewed-by: lagergren ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8019482.js Changeset: ab3ea5b3e507 Author: sundar Date: 2013-07-01 19:52 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ab3ea5b3e507 8019488: switch on literals result in NoSuchMethodError or VerifyError Reviewed-by: hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8019488.js Changeset: 9165138b427c Author: sundar Date: 2013-07-01 23:36 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/9165138b427c 8019508: Comma handling in object literal parsing is wrong Reviewed-by: hannesw ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8019508.js + test/script/basic/JDK-8019508.js.EXPECTED Changeset: 5f9abeb0bb50 Author: jlaskey Date: 2013-07-02 07:45 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/5f9abeb0bb50 8019580: Build Script Change for Nashorn promotion testing Reviewed-by: jlaskey Contributed-by: eugene.drobitko at oracle.com ! make/build.xml Changeset: a7b82e333c31 Author: lagergren Date: 2013-07-02 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/a7b82e333c31 8016667: Wrong bytecode when testing/setting due to null check shortcut checking against primitive too Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8016667.js Changeset: 74049fe3ba46 Author: sundar Date: 2013-07-02 18:00 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/74049fe3ba46 8019553: NPE on illegal l-value for increment and decrement Reviewed-by: jlaskey, attila, lagergren ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8019553.js + test/script/basic/JDK-8019553.js.EXPECTED ! test/script/basic/NASHORN-51.js ! test/script/basic/NASHORN-51.js.EXPECTED ! test/script/error/NASHORN-57.js.EXPECTED Changeset: 9396e42bae4f Author: lagergren Date: 2013-07-02 14:50 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/9396e42bae4f 8017082: Long array literals were slightly broken Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/LiteralNode.java + test/script/basic/JDK-8017082.js Changeset: 69ec02d12a31 Author: lagergren Date: 2013-07-02 15:01 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/69ec02d12a31 Merge Changeset: 16c4535abcf8 Author: sundar Date: 2013-07-02 18:39 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/16c4535abcf8 Merge Changeset: 542b7803f038 Author: lana Date: 2013-07-05 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/542b7803f038 Merge From david.katleman at oracle.com Mon Jul 8 22:02:26 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Mon, 08 Jul 2013 22:02:26 +0000 Subject: hg: jdk8/build/langtools: 32 new changesets Message-ID: <20130708220359.106E4488C3@hg.openjdk.java.net> Changeset: 2364e94ae67b Author: cl Date: 2013-07-04 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2364e94ae67b Added tag jdk8-b97 for changeset 6a11a81a8824 ! .hgtags Changeset: 6debfa63a4a1 Author: vromero Date: 2013-06-20 08:45 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6debfa63a4a1 8016613: javac should avoid source 8 only analysis when compiling for source 7 Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java Changeset: e9ebff1840e5 Author: emc Date: 2013-06-20 19:01 -0400 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e9ebff1840e5 8007546: ClassCastException on JSR308 tests 8015993: jck-compiler tests are failed with java.lang.ClassCastException Summary: Fix ClassCastExceptions arising from addition of AnnotatedType. Reviewed-by: jjg, abuckley ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java Changeset: bf020de5a6db Author: emc Date: 2013-06-24 22:03 -0400 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bf020de5a6db 8012722: Single comma in array initializer should parse Summary: Annotations of the form @Foo({,}) should parse Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/SingleCommaAnnotationValue.java + test/tools/javac/parser/SingleCommaAnnotationValueFail.java + test/tools/javac/parser/SingleCommaAnnotationValueFail.out Changeset: 831467c4c6a7 Author: vromero Date: 2013-06-25 16:12 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/831467c4c6a7 8017104: javac should have a class for primitive types that inherits from Type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java Changeset: aceae9ceebbe Author: kizune Date: 2013-06-25 20:08 +0400 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/aceae9ceebbe 8006973: jtreg test fails: test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java Reviewed-by: ksrini ! test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java Changeset: c2d9303c3477 Author: ksrini Date: 2013-06-26 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c2d9303c3477 8016908: TEST_BUG: removing non-ascii characters causes tests to fail Reviewed-by: jjg, vromero ! test/tools/javac/api/6437999/T6437999.java - test/tools/javac/api/6437999/Utf8.java ! test/tools/javac/api/T6306137.java Changeset: 3b2e10524627 Author: jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by: matherey.nunez at oracle.com ! test/tools/javac/literals/UnderscoreLiterals.java Changeset: 4fe5aab73bb2 Author: bpatel Date: 2013-06-26 20:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/4fe5aab73bb2 8007338: Method grouping tab line-folding Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: 27bd6a2302f6 Author: bpatel Date: 2013-06-26 20:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/27bd6a2302f6 8014017: extra space in javadoc class heading Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java Changeset: 36e8bc1907a2 Author: bpatel Date: 2013-06-26 20:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/36e8bc1907a2 8013738: Two javadoc tests have bug 0000000 Reviewed-by: jjg ! test/com/sun/javadoc/testNestedInlineTag/TestNestedInlineTag.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java Changeset: c674b396827c Author: emc Date: 2013-06-27 00:37 -0400 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c674b396827c 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters Summary: The compiler does not account fr extra parameters due to inner this parameters Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java + test/tools/javac/limits/NestedClassConstructorArgs.java + test/tools/javac/limits/NestedClassMethodArgs.java - test/tools/javac/limits/NumArgs1.java - test/tools/javac/limits/NumArgs2.java - test/tools/javac/limits/NumArgs3.java - test/tools/javac/limits/NumArgs4.java + test/tools/javac/limits/NumArgsTest.java + test/tools/javac/limits/StaticNestedClassConstructorArgs.java + test/tools/javac/limits/TopLevelClassConstructorArgs.java + test/tools/javac/limits/TopLevelClassMethodArgs.java + test/tools/javac/limits/TopLevelClassStaticMethodArgs.java Changeset: dcc6a52bf363 Author: erikj Date: 2013-06-27 10:35 +0200 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/dcc6a52bf363 8014513: Sjavac doesn't detect 32-bit jvm properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java Changeset: a47e28759666 Author: vromero Date: 2013-06-27 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a47e28759666 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javah/JavahTask.java Changeset: 8e3d391c88c6 Author: vromero Date: 2013-06-27 09:54 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8e3d391c88c6 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory) Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java Changeset: e42c27026290 Author: vromero Date: 2013-06-27 16:04 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e42c27026290 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes ) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/T8016099/UncheckedWarningRegressionTest.java + test/tools/javac/T8016099/UncheckedWarningRegressionTest.out Changeset: d137ce373c4c Author: vromero Date: 2013-06-27 16:06 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d137ce373c4c 7008643: inlined finally clauses confuse debuggers Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T7008643/InlinedFinallyConfuseDebuggersTest.java Changeset: 26437287529d Author: janvalenta Date: 2013-06-27 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/26437287529d 8015720: since tag isn't copied while generating JavaFX documentation Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! test/com/sun/javadoc/testJavaFX/C.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 065f8cb7bd89 Author: darcy Date: 2013-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/065f8cb7bd89 8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion Reviewed-by: jjg ! src/share/classes/javax/lang/model/SourceVersion.java Changeset: 97e798c06804 Author: ksrini Date: 2013-06-27 12:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/97e798c06804 7080001: Need to bump version numbers in build.properties for 8 Reviewed-by: jjg ! make/build.properties Changeset: 5c548a8542b8 Author: emc Date: 2013-06-27 17:45 -0400 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5c548a8542b8 8013357: javac accepts erroneous binary comparison operations Summary: javac does not report type errors on illegal Object == primitive comparisons Reviewed-by: abuckley, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! test/tools/javac/lambda/LambdaConv01.java ! test/tools/javac/lambda/LambdaExpr15.java ! test/tools/javac/lambda/typeInference/InferenceTest2b.java + test/tools/javac/types/TestComparisons.java Changeset: 6101e52ce9e3 Author: emc Date: 2013-06-28 06:54 -0400 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6101e52ce9e3 8016760: Failure of regression test langtools/tools/javac/T6725036.java Summary: Marking the failing test @ignore; the proposed change for 8015666 addresses the underlying issue Reviewed-by: jjg ! test/tools/javac/T6725036.java Changeset: bb06c412d079 Author: vromero Date: 2013-06-28 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bb06c412d079 6473148: TreePath.iterator() should document the iteration order Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/TreePath.java Changeset: bdd699d7378d Author: vromero Date: 2013-06-28 14:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bdd699d7378d 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: 66147d50d8d6 Author: lana Date: 2013-06-28 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/66147d50d8d6 Merge Changeset: 891c5ecb8306 Author: vromero Date: 2013-06-29 20:12 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/891c5ecb8306 6983646: javap should identify why a DefaultAttribute is being used Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/DefaultAttribute.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: f559ef7568ce Author: mcimadamore Date: 2013-07-01 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f559ef7568ce 7034798: Ambiguity error for abstract method call is too eager Summary: Javac should wait and see if ambiguous methods can be reconciled at the end of an overload resolution round Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/tests/AbstractMerge.java ! test/tools/javac/resolve/tests/InnerOverOuter.java Changeset: 1908e86ee49a Author: darcy Date: 2013-07-01 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1908e86ee49a 7162089: Add support for repeating annotations to javax.annotation.processing Reviewed-by: abuckley, jjg, jfranck ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/javax/annotation/processing/AbstractProcessor.java ! src/share/classes/javax/annotation/processing/Processor.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java + test/tools/javac/processing/environment/round/TpAnno.java + test/tools/javac/processing/environment/round/TypeParameterAnnotations.java Changeset: 27a2e8c78bd0 Author: vromero Date: 2013-07-02 10:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/27a2e8c78bd0 8019397: javap does not show SourceDebugExtension properly Reviewed-by: jjg Contributed-by: dmytro_sheyko at hotmail.com ! src/share/classes/com/sun/tools/classfile/SourceDebugExtension_attribute.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: 565341d436e2 Author: ksrini Date: 2013-07-01 16:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/565341d436e2 8019460: tests in changeset do not have @bug tag Reviewed-by: darcy ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAnotherAuxiliary.java ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAnotherAuxiliary.out ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAuxiliary.java ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAuxiliary1.out ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAuxiliary2.out ! test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java Changeset: 3b4f92a3797f Author: vromero Date: 2013-07-02 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3b4f92a3797f 6326693: variable x might already have been assigned, when assignment is in catch block Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/T6326693/FinalVariableAssignedToInCatchBlockTest.java + test/tools/javac/T6326693/FinalVariableAssignedToInCatchBlockTest.out Changeset: ce5a90df517b Author: lana Date: 2013-07-05 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ce5a90df517b Merge From dan.xu at oracle.com Tue Jul 9 05:46:53 2013 From: dan.xu at oracle.com (Dan Xu) Date: Mon, 08 Jul 2013 22:46:53 -0700 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> Message-ID: <51DBA3CD.9020605@oracle.com> Adding build-dev mailing list. On 07/08/2013 09:54 PM, Yasu wrote: > Sorry, I forgot to attach a patch: > > ------ > > diff -r 52454985425d makefiles/CompileNativeLibraries.gmk > --- a/makefiles/CompileNativeLibraries.gmk Mon Jul 08 19:24:22 2013 -0700 > +++ b/makefiles/CompileNativeLibraries.gmk Tue Jul 09 13:41:12 2013 +0900 > @@ -1987,7 +1987,7 @@ > > ifneq ($(OPENJDK_TARGET_OS),macosx) > > - SCTP_WERROR := -Werror > + SCTP_WERROR := -Werror -Wno-error=unused-parameter > ifeq ($(OPENJDK_TARGET_CPU_ARCH), ppc) > SCTP_WERROR := > endif From mfbutner at ucdavis.edu Tue Jul 9 05:59:55 2013 From: mfbutner at ucdavis.edu (Matthew Butner) Date: Mon, 8 Jul 2013 22:59:55 -0700 Subject: Help with using jtreg to verify build needed Message-ID: Not sure if this is the right place to ask or not, and if it isn't, please direct me to the correct forum but I have been trying all day to use jtreg to test my jdk 1.8 build with no success. Here is my problem: I am running ubuntu and have used the apt center to install jtreg. This means that jtreg and jtdiff are installed under /usr/bin. When I run the configure script it does not automatically detect jtreg and when I try running it with the --with-jtreg=/usr/bin/jtreg or /usr/bin it fails because it is trying to find the executable inside subdirectories that do not exist because I did not install jtreg from source. I tried to work around this by modifying line 16463 JTREGEXE="$JT_HOME/win32/bin/jtreg" to JTREGEXE="$JT_HOME/jtreg" which made it detect jtreg but the command in the readme *cd test && make PRODUCT_HOME=`pwd`/../build/*/images/j2sdk-image all *still fails because it is still trying to look in /usr/bin/win32/bin/jtreg and win32/bin/jtreg does not exist. Any help would be greatly welcome but if possible I don't want to have to install jtreg from source as that is a whole other can of worms. Thank you, Matthew From erik.joelsson at oracle.com Tue Jul 9 07:40:44 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 09 Jul 2013 09:40:44 +0200 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <51DBA3CD.9020605@oracle.com> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> Message-ID: <51DBBE7C.6070801@oracle.com> I would like to see a comment explaining why the option was needed. Is this a bug in gcc or has the checking just become better? /Erik On 2013-07-09 07:46, Dan Xu wrote: > Adding build-dev mailing list. > > > On 07/08/2013 09:54 PM, Yasu wrote: >> Sorry, I forgot to attach a patch: >> >> ------ >> >> diff -r 52454985425d makefiles/CompileNativeLibraries.gmk >> --- a/makefiles/CompileNativeLibraries.gmk Mon Jul 08 19:24:22 2013 -0700 >> +++ b/makefiles/CompileNativeLibraries.gmk Tue Jul 09 13:41:12 2013 +0900 >> @@ -1987,7 +1987,7 @@ >> >> ifneq ($(OPENJDK_TARGET_OS),macosx) >> >> - SCTP_WERROR := -Werror >> + SCTP_WERROR := -Werror -Wno-error=unused-parameter >> ifeq ($(OPENJDK_TARGET_CPU_ARCH), ppc) >> SCTP_WERROR := >> endif From jonathan.gibbons at oracle.com Tue Jul 9 07:58:41 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 09 Jul 2013 08:58:41 +0100 Subject: Help with using jtreg to verify build needed In-Reply-To: References: Message-ID: <51DBC2B1.9040008@oracle.com> Matthew, I don't know how up to date the Ubuntu version of jtreg is. You may need a newer version of jtreg anyway. One workaround for you would be to create a directory containing the right files in the right locations. At a minimum you need win32/bin/jtreg lib/jtreg.jar lib/jtharness.jar -- Jon On 07/09/2013 06:59 AM, Matthew Butner wrote: > Not sure if this is the right place to ask or not, and if it isn't, please > direct me to the correct forum but I have been trying all day to use jtreg > to test my jdk 1.8 build with no success. > > Here is my problem: > I am running ubuntu and have used the apt center to install jtreg. This > means that jtreg and jtdiff are installed under /usr/bin. When I run the > configure script it does not automatically detect jtreg and when I try > running it with the --with-jtreg=/usr/bin/jtreg or /usr/bin it fails > because it is trying to find the executable inside subdirectories that do > not exist because I did not install jtreg from source. > > I tried to work around this by modifying line 16463 > JTREGEXE="$JT_HOME/win32/bin/jtreg" > to > JTREGEXE="$JT_HOME/jtreg" > > which made it detect jtreg but the command in the readme > *cd test && make PRODUCT_HOME=`pwd`/../build/*/images/j2sdk-image all > > *still fails because it is still trying to look in > /usr/bin/win32/bin/jtreg > > and win32/bin/jtreg does not exist. > > Any help would be greatly welcome but if possible I don't want to have to > install jtreg from source as that is a whole other can of worms. > > Thank you, > Matthew From heliofrota at gmail.com Tue Jul 9 10:41:29 2013 From: heliofrota at gmail.com (Helio Frota) Date: Tue, 9 Jul 2013 07:41:29 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <51DBBE7C.6070801@oracle.com> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> Message-ID: Hi great all, This is my first mail here, i'm Jug Leader of CEJUG and OpenJDK Adoptor. I did the build of OpenJDK with GCC 4.8.1 Please look: http://www.heliofrota.com/blog/2013/06/25/building-openjdk8-plus-gcc-4-dot-8-1-plus-manjaro-gnu-linux-x86/ And here all discussion on Adopt OpenJDK mailing list: https://groups.google.com/d/msg/adopt-openjdk/-6CQLEclN-Q/NkrCc96WeM8J I will try with fedora 19 soon. Thanks. 2013/7/9 Erik Joelsson > I would like to see a comment explaining why the option was needed. Is > this a bug in gcc or has the checking just become better? > > /Erik > > On 2013-07-09 07:46, Dan Xu wrote: > > Adding build-dev mailing list. > > > > > > On 07/08/2013 09:54 PM, Yasu wrote: > >> Sorry, I forgot to attach a patch: > >> > >> ------ > >> > >> diff -r 52454985425d makefiles/CompileNativeLibraries.gmk > >> --- a/makefiles/CompileNativeLibraries.gmk Mon Jul 08 19:24:22 2013 > -0700 > >> +++ b/makefiles/CompileNativeLibraries.gmk Tue Jul 09 13:41:12 2013 > +0900 > >> @@ -1987,7 +1987,7 @@ > >> > >> ifneq ($(OPENJDK_TARGET_OS),macosx) > >> > >> - SCTP_WERROR := -Werror > >> + SCTP_WERROR := -Werror -Wno-error=unused-parameter > >> ifeq ($(OPENJDK_TARGET_CPU_ARCH), ppc) > >> SCTP_WERROR := > >> endif > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From yasu at ysfactory.dip.jp Tue Jul 9 11:11:17 2013 From: yasu at ysfactory.dip.jp (Yasu) Date: Tue, 9 Jul 2013 20:11:17 +0900 Subject: Build error with GCC4.8 on Fedora19 Message-ID: <20130709111120.D78664E58EE@msgw008-04.ocn.ad.jp> Hi Erik, I posted email as following: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/018790.html --- Hi, I tried to build JDK8 with GCC4.8 on Fedora19. However, build process has been failed as following: ------ /usr/src/OpenJDK/tl/jdk/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c: In function ?Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0?: /usr/src/OpenJDK/tl/jdk/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c:1071:68: warning: unused parameter ?this? [-Wunused-parameter] Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0(JNIEnv* env, jclass this, ^ gmake[1]: *** [libs-only] Error 2 make: *** [jdk-only] Error 2 ------ I guess this issue is caused by -Werror. So I've made a patch and it seems to work fine. Could you push this patch? Thanks, Yasumasa Suenaga --- I think that this is GCC spec. This option is described in manpage of gcc as following: --- -Wunused All the above -Wunused options combined. In order to get a warning about an unused function parameter, you must either specify -Wextra -Wunused (note that -Wall implies -Wunused), or separately specify -Wunused-parameter. --- Thanks, Yasumasa From yasu at ysfactory.dip.jp Tue Jul 9 11:15:43 2013 From: yasu at ysfactory.dip.jp (Yasu) Date: Tue, 9 Jul 2013 20:15:43 +0900 Subject: Build error with GCC4.8 on Fedora19 Message-ID: <20130709111545.57D434D596E@msgw007-03.ocn.ad.jp> Hi Helio, I've read your article. Can you try to build class library? I encountered this issue on building SCTP module. Thanks, Yasumasa From heliofrota at gmail.com Tue Jul 9 11:29:22 2013 From: heliofrota at gmail.com (Helio Frota) Date: Tue, 9 Jul 2013 08:29:22 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <20130709111545.57D434D596E@msgw007-03.ocn.ad.jp> References: <20130709111545.57D434D596E@msgw007-03.ocn.ad.jp> Message-ID: Hi Yasu, Can you try to build class library? Yes i will try. Thanks, 2013/7/9 Yasu > Hi Helio, > > I've read your article. > Can you try to build class library? > I encountered this issue on building SCTP module. > > > Thanks, > > Yasumasa > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From aph at redhat.com Tue Jul 9 11:40:27 2013 From: aph at redhat.com (Andrew Haley) Date: Tue, 09 Jul 2013 12:40:27 +0100 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <20130709111120.D78664E58EE@msgw008-04.ocn.ad.jp> References: <20130709111120.D78664E58EE@msgw008-04.ocn.ad.jp> Message-ID: <51DBF6AB.5070308@redhat.com> On 07/09/2013 12:11 PM, Yasu wrote: > Hi Erik, > > I posted email as following: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/018790.html > --- > Hi, > > I tried to build JDK8 with GCC4.8 on Fedora19. > However, build process has been failed as following: > > ------ > /usr/src/OpenJDK/tl/jdk/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c: In function ?Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0?: > /usr/src/OpenJDK/tl/jdk/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c:1071:68: warning: unused parameter ?this? [-Wunused-parameter] > Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0(JNIEnv* env, jclass this, > ^ > gmake[1]: *** [libs-only] Error 2 > make: *** [jdk-only] Error 2 > ------ > > I guess this issue is caused by -Werror. Better to fix the code: --- a/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Tue Jul 02 15:08:32 2013 +0100 +++ b/src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Tue Jul 09 12:39:35 2013 +0100 @@ -1039,7 +1039,7 @@ } JNIEXPORT jint JNICALL -Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0(JNIEnv* env, jclass this, +Java_sun_nio_fs_UnixNativeDispatcher_getgrnam0(JNIEnv* env, jclass, jlong nameAddress) { jint gid = -1; Andrew. From tim.bell at oracle.com Tue Jul 9 12:19:19 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 09 Jul 2013 05:19:19 -0700 Subject: RFR 8009315 "F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)" Message-ID: <51DBFFC7.2060508@oracle.com> Hello Here is the bug report: http://bugs.sun.com/view_bug.do?bug_id=8009315 With Visual Studio 2010 this is an issue only for users who install F#. With VS 2012, F# is always installed and this becomes a stopper issue for all Windows users trying to build. I'd like to get this small fix out of the way. http://cr.openjdk.java.net/~tbell/8009315/webrev.00/ Thanks in advance- Tim From erik.joelsson at oracle.com Tue Jul 9 13:08:10 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 09 Jul 2013 15:08:10 +0200 Subject: RFR 8009315 "F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)" In-Reply-To: <51DBFFC7.2060508@oracle.com> References: <51DBFFC7.2060508@oracle.com> Message-ID: <51DC0B3A.3000300@oracle.com> This patch isn't working for me. On my setup, the F# path ends up first and the regexp is expecting to find an initial colon: 's/:.*#[^:]*:/:/'. My own workaround for this problem looks like this: diff -r 50d2bde060f2 common/autoconf/toolchain_windows.m4 --- a/common/autoconf/toolchain_windows.m4 +++ b/common/autoconf/toolchain_windows.m4 @@ -208,6 +208,8 @@ # Remove any trailing \ from INCLUDE and LIB to avoid trouble in spec.gmk . VS_INCLUDE=`$ECHO "$INCLUDE" | $SED 's/\\\\$//'` VS_LIB=`$ECHO "$LIB" | $SED 's/\\\\$//'` + # Remove any paths containing # (typically F#) as that messes up make + PATH=`$ECHO "$PATH" | $SED 's/[[^:#]]*#[^:]*://g'` VS_PATH="$PATH" AC_SUBST(VS_INCLUDE) AC_SUBST(VS_LIB) It looks for strings not containing : or #, followed by a #, then no : followed by a :. The double brackets seemed necessary as m4 would eat them otherwise. /Erik On 2013-07-09 14:19, Tim Bell wrote: > Hello > > Here is the bug report: > http://bugs.sun.com/view_bug.do?bug_id=8009315 > > With Visual Studio 2010 this is an issue only for users who install F#. > > With VS 2012, F# is always installed and this becomes a stopper issue > for all Windows users trying to build. > > I'd like to get this small fix out of the way. > > http://cr.openjdk.java.net/~tbell/8009315/webrev.00/ > > Thanks in advance- > > Tim > From tim.bell at oracle.com Tue Jul 9 13:28:00 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 09 Jul 2013 06:28:00 -0700 Subject: RFR 8009315 "F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)" In-Reply-To: <51DC0B3A.3000300@oracle.com> References: <51DBFFC7.2060508@oracle.com> <51DC0B3A.3000300@oracle.com> Message-ID: <51DC0FE0.2020501@oracle.com> Erik - > It looks for strings not containing : or #, followed by a #, then no : > followed by a :. The double brackets seemed necessary as m4 would eat > them otherwise. I'll take your version with thanks! Updated webrev: http://cr.openjdk.java.net/~tbell/8009315/webrev.01/ Tim On 07/ 9/13 06:08 AM, Erik Joelsson wrote: > This patch isn't working for me. On my setup, the F# path ends up > first and the regexp is expecting to find an initial colon: > 's/:.*#[^:]*:/:/'. My own workaround for this problem looks like this: > > diff -r 50d2bde060f2 common/autoconf/toolchain_windows.m4 > --- a/common/autoconf/toolchain_windows.m4 > +++ b/common/autoconf/toolchain_windows.m4 > @@ -208,6 +208,8 @@ > # Remove any trailing \ from INCLUDE and LIB to avoid trouble > in spec.gmk > . > VS_INCLUDE=`$ECHO "$INCLUDE" | $SED 's/\\\\$//'` > VS_LIB=`$ECHO "$LIB" | $SED 's/\\\\$//'` > + # Remove any paths containing # (typically F#) as that messes up make > + PATH=`$ECHO "$PATH" | $SED 's/[[^:#]]*#[^:]*://g'` > VS_PATH="$PATH" > AC_SUBST(VS_INCLUDE) > AC_SUBST(VS_LIB) > > It looks for strings not containing : or #, followed by a #, then no : > followed by a :. The double brackets seemed necessary as m4 would eat > them otherwise. > > /Erik > > On 2013-07-09 14:19, Tim Bell wrote: >> Hello >> >> Here is the bug report: >> http://bugs.sun.com/view_bug.do?bug_id=8009315 >> >> With Visual Studio 2010 this is an issue only for users who install F#. >> >> With VS 2012, F# is always installed and this becomes a stopper issue >> for all Windows users trying to build. >> >> I'd like to get this small fix out of the way. >> >> http://cr.openjdk.java.net/~tbell/8009315/webrev.00/ >> >> Thanks in advance- >> >> Tim >> From erik.joelsson at oracle.com Tue Jul 9 13:49:33 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 09 Jul 2013 15:49:33 +0200 Subject: RFR 8009315 "F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)" In-Reply-To: <51DC0FE0.2020501@oracle.com> References: <51DBFFC7.2060508@oracle.com> <51DC0B3A.3000300@oracle.com> <51DC0FE0.2020501@oracle.com> Message-ID: <51DC14ED.8080400@oracle.com> Applied and tested and works for me. Approved. /Erik On 2013-07-09 15:28, Tim Bell wrote: > Erik - > >> It looks for strings not containing : or #, followed by a #, then no >> : followed by a :. The double brackets seemed necessary as m4 would >> eat them otherwise. > > I'll take your version with thanks! > > Updated webrev: > > http://cr.openjdk.java.net/~tbell/8009315/webrev.01/ > > Tim > > > On 07/ 9/13 06:08 AM, Erik Joelsson wrote: >> This patch isn't working for me. On my setup, the F# path ends up >> first and the regexp is expecting to find an initial colon: >> 's/:.*#[^:]*:/:/'. My own workaround for this problem looks like this: >> >> diff -r 50d2bde060f2 common/autoconf/toolchain_windows.m4 >> --- a/common/autoconf/toolchain_windows.m4 >> +++ b/common/autoconf/toolchain_windows.m4 >> @@ -208,6 +208,8 @@ >> # Remove any trailing \ from INCLUDE and LIB to avoid trouble >> in spec.gmk >> . >> VS_INCLUDE=`$ECHO "$INCLUDE" | $SED 's/\\\\$//'` >> VS_LIB=`$ECHO "$LIB" | $SED 's/\\\\$//'` >> + # Remove any paths containing # (typically F#) as that messes up make >> + PATH=`$ECHO "$PATH" | $SED 's/[[^:#]]*#[^:]*://g'` >> VS_PATH="$PATH" >> AC_SUBST(VS_INCLUDE) >> AC_SUBST(VS_LIB) >> >> It looks for strings not containing : or #, followed by a #, then no >> : followed by a :. The double brackets seemed necessary as m4 would >> eat them otherwise. >> >> /Erik >> >> On 2013-07-09 14:19, Tim Bell wrote: >>> Hello >>> >>> Here is the bug report: >>> http://bugs.sun.com/view_bug.do?bug_id=8009315 >>> >>> With Visual Studio 2010 this is an issue only for users who install F#. >>> >>> With VS 2012, F# is always installed and this becomes a stopper >>> issue for all Windows users trying to build. >>> >>> I'd like to get this small fix out of the way. >>> >>> http://cr.openjdk.java.net/~tbell/8009315/webrev.00/ >>> >>> Thanks in advance- >>> >>> Tim >>> > From tim.bell at oracle.com Tue Jul 9 15:02:24 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 09 Jul 2013 08:02:24 -0700 Subject: RFR 8009315 "F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...)" In-Reply-To: <51DC14ED.8080400@oracle.com> References: <51DBFFC7.2060508@oracle.com> <51DC0B3A.3000300@oracle.com> <51DC0FE0.2020501@oracle.com> <51DC14ED.8080400@oracle.com> Message-ID: <51DC2600.5040503@oracle.com> Erik: Thank you. Tim > Applied and tested and works for me. Approved. > > /Erik > > On 2013-07-09 15:28, Tim Bell wrote: >> Erik - >> >>> It looks for strings not containing : or #, followed by a #, then no >>> : followed by a :. The double brackets seemed necessary as m4 would >>> eat them otherwise. >> >> I'll take your version with thanks! >> >> Updated webrev: >> >> http://cr.openjdk.java.net/~tbell/8009315/webrev.01/ >> >> Tim >> >> >> On 07/ 9/13 06:08 AM, Erik Joelsson wrote: >>> This patch isn't working for me. On my setup, the F# path ends up >>> first and the regexp is expecting to find an initial colon: >>> 's/:.*#[^:]*:/:/'. My own workaround for this problem looks like this: >>> >>> diff -r 50d2bde060f2 common/autoconf/toolchain_windows.m4 >>> --- a/common/autoconf/toolchain_windows.m4 >>> +++ b/common/autoconf/toolchain_windows.m4 >>> @@ -208,6 +208,8 @@ >>> # Remove any trailing \ from INCLUDE and LIB to avoid trouble >>> in spec.gmk >>> . >>> VS_INCLUDE=`$ECHO "$INCLUDE" | $SED 's/\\\\$//'` >>> VS_LIB=`$ECHO "$LIB" | $SED 's/\\\\$//'` >>> + # Remove any paths containing # (typically F#) as that messes up make >>> + PATH=`$ECHO "$PATH" | $SED 's/[[^:#]]*#[^:]*://g'` >>> VS_PATH="$PATH" >>> AC_SUBST(VS_INCLUDE) >>> AC_SUBST(VS_LIB) >>> >>> It looks for strings not containing : or #, followed by a #, then no >>> : followed by a :. The double brackets seemed necessary as m4 would >>> eat them otherwise. >>> >>> /Erik >>> >>> On 2013-07-09 14:19, Tim Bell wrote: >>>> Hello >>>> >>>> Here is the bug report: >>>> http://bugs.sun.com/view_bug.do?bug_id=8009315 >>>> >>>> With Visual Studio 2010 this is an issue only for users who install >>>> F#. >>>> >>>> With VS 2012, F# is always installed and this becomes a stopper >>>> issue for all Windows users trying to build. >>>> >>>> I'd like to get this small fix out of the way. >>>> >>>> http://cr.openjdk.java.net/~tbell/8009315/webrev.00/ >>>> >>>> Thanks in advance- >>>> >>>> Tim >>>> >> From david.katleman at oracle.com Tue Jul 9 21:53:46 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 09 Jul 2013 21:53:46 +0000 Subject: hg: jdk8/build/hotspot: 36 new changesets Message-ID: <20130709215503.4744E4891C@hg.openjdk.java.net> Changeset: 8c4424890028 Author: amurillo Date: 2013-06-28 02:33 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8c4424890028 8019302: new hotspot build - hs25-b40 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8cff1de240de Author: zgu Date: 2013-06-25 17:22 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8cff1de240de 8017478: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Fixed possible NULL pointer that caused SIGSEGV Reviewed-by: coleenp, acorn, ctornqvi ! src/share/vm/services/memReporter.cpp Changeset: c14867f95c60 Author: zgu Date: 2013-06-25 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c14867f95c60 Merge Changeset: 38ea2efa32a7 Author: kevinw Date: 2013-06-26 00:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/38ea2efa32a7 8010278: SA: provide mechanism for using an alternative SA debugger back-end. Reviewed-by: sla, dsamersoff ! agent/src/share/classes/sun/jvm/hotspot/CLHSDB.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxOopHandle.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/tools/ClassLoaderStats.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FinalizerInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FlagDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JSnap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/ObjectHistogram.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/StackTrace.java ! agent/src/share/classes/sun/jvm/hotspot/tools/SysPropsDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/JSDB.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java Changeset: 8eb40545e209 Author: kevinw Date: 2013-06-26 11:00 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8eb40545e209 Merge Changeset: 221df7e37535 Author: iklam Date: 2013-06-27 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/221df7e37535 8016075: Win32 crash with CDS enabled and small heap size Summary: Fixed MetaspaceShared::is_in_shared_space Reviewed-by: coleenp, hseigel ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: e0fe0c9a88da Author: nloodin Date: 2013-06-28 14:05 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e0fe0c9a88da Merge Changeset: bb4f2b27e824 Author: dcubed Date: 2013-06-29 11:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bb4f2b27e824 Merge Changeset: 97c5acae48be Author: hseigel Date: 2013-06-30 09:59 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/97c5acae48be 7007040: Check of capacity paramenters in JNI_PushLocalFrame is wrong Summary: changed AND to OR Reviewed-by: coleenp, hseigel Contributed-by: lois.foltan at oracle.com ! src/share/vm/prims/jni.cpp Changeset: 068b406e307f Author: fparain Date: 2013-07-01 09:13 +0000 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/068b406e307f 7060111: race condition in VMError::report_and_die() Reviewed-by: zgu, coleenp Contributed-by: volker.simonis at gmail.com ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp Changeset: acfa2cc19146 Author: rbackman Date: 2013-06-12 09:49 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/acfa2cc19146 8016444: Duplicate zombie check in safe_for_sender Reviewed-by: dholmes, sla ! src/cpu/sparc/vm/frame_sparc.cpp ! src/share/vm/memory/referenceProcessorStats.hpp Changeset: 993dfb57c575 Author: egahlin Date: 2013-06-26 17:02 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/993dfb57c575 8016331: Minor issues in event tracing metadata Reviewed-by: stefank, brutisso, mgronlun ! src/share/vm/trace/trace.xml Changeset: 7f11c12d7a90 Author: sspitsyn Date: 2013-07-01 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7f11c12d7a90 8009204: [dtrace] signatures returned by Java 7 jstack() are corrupted on Solaris Summary: The fix is basically a backport of JDK-7019165 (pstack issue) to jhelper.d. Reviewed-by: coleenp, sspitsyn Contributed-by: tomas.hurka at oracle.com ! src/os/solaris/dtrace/jhelper.d Changeset: de2d15ce3d4a Author: coleenp Date: 2013-07-02 08:42 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/de2d15ce3d4a 8015391: NPG: With -XX:+UseCompressedKlassPointers OOME due to exhausted metadata space could occur when metaspace is almost empty Summary: Allocate medium chunks for class metaspace when class loader has lots of classes Reviewed-by: mgerdin, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: cedf20e2a655 Author: coleenp Date: 2013-07-02 16:54 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cedf20e2a655 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c92b74c62d97 Author: brutisso Date: 2013-06-27 09:59 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c92b74c62d97 8017483: G1 tests fail with native OOME on Solaris x86 after HeapBaseMinAddress has been increased Summary: Set HeapBaseMinAddress as default rather than ergo Reviewed-by: stefank, jmasa, kvn ! src/share/vm/runtime/arguments.cpp Changeset: 3ea89789ba39 Author: ehelin Date: 2013-06-28 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3ea89789ba39 Merge Changeset: b30744960351 Author: brutisso Date: 2013-06-30 21:42 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b30744960351 8014022: G1: Non Java threads should lock the shared SATB queue lock without safepoint checks. Reviewed-by: tschatzl, brutisso, jmasa, ysr Contributed-by: per.liden at oracle.com ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp Changeset: 5ea20b3bd249 Author: johnc Date: 2013-07-01 09:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5ea20b3bd249 8017070: G1: assert(_card_counts[card_num] <= G1ConcRSHotCardLimit) failed Summary: The assert is invalid when a card is being refined by two different threads and its count crosses the hot threshold - the refinement count will be updated once by each thread triggering the assert. Remove the assert and update the count using a bounded expression. Reviewed-by: jmasa, tamao, brutisso ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp Changeset: 6e3634222155 Author: tamao Date: 2013-06-28 20:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6e3634222155 8017611: Auto corrector for mistyped vm options Summary: The auto corrector for mistyped vm options fuzzy-matches existing flags based on string similarity (Dice's coefficient). Reviewed-by: kvn, dsamersoff, hseigel, johnc ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp + test/gc/arguments/TestUnrecognizedVMOptionsHandling.java Changeset: 536976a22f5f Author: tamao Date: 2013-07-03 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/536976a22f5f Merge Changeset: 70bea4a43c6d Author: tamao Date: 2013-07-03 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/70bea4a43c6d Merge Changeset: ac7193063af8 Author: jiangli Date: 2013-07-01 19:44 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ac7193063af8 8006023: Embedded Builds fail management test because of requirement for UsePerfData being enabled. Summary: Added -XX:+UsePerfData to Test7196045.java. Reviewed-by: dholmes, collins ! test/runtime/7196045/Test7196045.java Changeset: 94aa8de029c5 Author: clucasius Date: 2013-07-03 22:36 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/94aa8de029c5 Merge Changeset: fea6a49c2762 Author: bdelsart Date: 2013-07-04 01:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fea6a49c2762 Merge Changeset: f765bfec8f07 Author: kvn Date: 2013-07-01 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f765bfec8f07 8006629: NEED_TEST: need test for JDK-8001071 Summary: added regression test Reviewed-by: kvn, coleenp Contributed-by: Filipp Zhinkin + test/runtime/8001071/Test8001071.java + test/runtime/8001071/Test8001071.sh Changeset: a023ec3452c7 Author: simonis Date: 2013-07-01 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a023ec3452c7 8019382: PPC64: Fix bytecodeInterpreter to compile with '-Wunused-value' Summary: cast the offending expressions to (void) Reviewed-by: kvn, coleenp ! src/share/vm/interpreter/bytecodeInterpreter.cpp Changeset: 2b3fe74309b6 Author: kvn Date: 2013-07-02 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2b3fe74309b6 8019247: SIGSEGV in compiled method c8e.e.t_.getArray(Ljava/lang/Class;)[Ljava/lang/Object Summary: Undo recent changes (and add more comments) in Ideal_allocation(). Reviewed-by: roland ! src/share/vm/opto/graphKit.cpp Changeset: 738e04fb1232 Author: anoll Date: 2013-07-02 07:51 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/738e04fb1232 8014972: Crash with specific values for -XX:InitialCodeCacheSize=500K -XX:ReservedCodeCacheSize=500k Summary: Introduce a minimum code cache size that guarantees that the VM can startup. Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_globals_sparc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c1_globals_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/zero/vm/shark_globals_zero.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: b800986664f4 Author: drchase Date: 2013-07-02 20:42 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b800986664f4 7088419: Use x86 Hardware CRC32 Instruction with java.util.zip.CRC32 Summary: add intrinsics using new instruction to interpreter, C1, C2, for suitable x86; add test Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interpreterGenerator_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp + src/cpu/x86/vm/stubRoutines_x86.cpp + src/cpu/x86/vm/stubRoutines_x86.hpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7088419/CRCTest.java Changeset: c1bd7b5bdc70 Author: twisti Date: 2013-07-02 20:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c1bd7b5bdc70 8017571: JSR292: JVM crashing on assert "cast to instanceKlass" while producing MethodHandle for array methods with MethodHandle.findVirtual Reviewed-by: kvn ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/reflection.cpp Changeset: bed0eddd82cd Author: twisti Date: 2013-07-02 22:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bed0eddd82cd Merge Changeset: 8b789ce47503 Author: roland Date: 2013-07-04 01:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8b789ce47503 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: fece0ee013fc Author: roland Date: 2013-07-04 03:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fece0ee013fc Merge Changeset: c9dd82da51ed Author: amurillo Date: 2013-07-04 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c9dd82da51ed Merge Changeset: 30b5b75c42ac Author: amurillo Date: 2013-07-04 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/30b5b75c42ac Added tag hs25-b40 for changeset c9dd82da51ed ! .hgtags From peter.brunet at oracle.com Tue Jul 9 22:01:10 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Tue, 09 Jul 2013 17:01:10 -0500 Subject: How to debug assert failure in awt.dll? Message-ID: <51DC8826.8090604@oracle.com> Using code cloned from yesterday, I built the jdk portion of the 7u-dev forest using the debug target and the 7u45 import and am getting an assert failure in Hashtable.cpp when accessibility is enabled. This is a 32 bit build using a 32 bit import. Letting the execution transition into the debugger stops pointing at awt.dll. How do I debug this? Assuming having debug symbols would help, I set the Visual Studio debugger symbols dialog to point at either of these two directories but the debugger fails to find the symbols: jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. Pete From tim.bell at oracle.com Wed Jul 10 01:17:32 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 10 Jul 2013 01:17:32 +0000 Subject: hg: jdk8/build: 8009315: F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...) Message-ID: <20130710011732.7F8FA48923@hg.openjdk.java.net> Changeset: 0d0c983a817b Author: tbell Date: 2013-07-09 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/0d0c983a817b 8009315: F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...) Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 From anthony.petrov at oracle.com Wed Jul 10 07:59:04 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 10 Jul 2013 11:59:04 +0400 Subject: How to debug assert failure in awt.dll? In-Reply-To: <51DC8826.8090604@oracle.com> References: <51DC8826.8090604@oracle.com> Message-ID: <51DD1448.1050403@oracle.com> This is a known issue http://bugs.sun.com/view_bug.do?bug_id=8013849 Looks like it's unrelated to a11y and affects any apps with input boxes. I'm not an expert in debugging with VS, but I suppose it wants the .pdb file for the awt.dll. Try locating this file in the build/ directory and point the VS debugger to it. You should also point VS to the sources directory (which is jdk/src/windows/native/sun/windows/). -- best regards, Anthony On 07/10/2013 02:01 AM, Pete Brunet wrote: > Using code cloned from yesterday, I built the jdk portion of the 7u-dev > forest using the debug target and the 7u45 import and am getting an > assert failure in Hashtable.cpp when accessibility is enabled. This is > a 32 bit build using a 32 bit import. > > Letting the execution transition into the debugger stops pointing at > awt.dll. > > How do I debug this? Assuming having debug symbols would help, I set > the Visual Studio debugger symbols dialog to point at either of these > two directories but the debugger fails to find the symbols: > jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. > > Pete > From denis.fokin at gmail.com Wed Jul 10 09:15:53 2013 From: denis.fokin at gmail.com (Denis Fokin) Date: Wed, 10 Jul 2013 13:15:53 +0400 Subject: How to debug assert failure in awt.dll? In-Reply-To: <51DC8826.8090604@oracle.com> References: <51DC8826.8090604@oracle.com> Message-ID: Hi Pete, As a dirty hack, you can just comment out ret = MessageBoxA(NULL, assertMsg, "AWT Assertion Failure", MB_YESNO|MB_ICONSTOP|MB_TASKMODAL); // if clicked Yes, break into the debugger if ( ret == IDYES ) { # if defined(_M_IX86) _asm { int 3 }; # else DebugBreak(); # endif } // otherwise, try to continue execution from jdk/src/windows/native/sun/windows/awt_Debug.cpp this prevents showing the MessageBox and breaking into the debugger. Thank you, Denis. On Jul 10, 2013, at 2:01 AM, Pete Brunet wrote: > Using code cloned from yesterday, I built the jdk portion of the 7u-dev > forest using the debug target and the 7u45 import and am getting an > assert failure in Hashtable.cpp when accessibility is enabled. This is > a 32 bit build using a 32 bit import. > > Letting the execution transition into the debugger stops pointing at > awt.dll. > > How do I debug this? Assuming having debug symbols would help, I set > the Visual Studio debugger symbols dialog to point at either of these > two directories but the debugger fails to find the symbols: > jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. > > Pete From peter.brunet at oracle.com Wed Jul 10 13:57:01 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 10 Jul 2013 08:57:01 -0500 Subject: How to debug assert failure in awt.dll? In-Reply-To: <51DD1448.1050403@oracle.com> References: <51DC8826.8090604@oracle.com> <51DD1448.1050403@oracle.com> Message-ID: <51DD682D.6040907@oracle.com> On 7/10/13 2:59 AM, Anthony Petrov wrote: > This is a known issue http://bugs.sun.com/view_bug.do?bug_id=8013849 > Looks like it's unrelated to a11y and affects any apps with input boxes. Thanks Anthony, You are right; it is not a11y related. Is there a bug I can edit? I'll add more info: - it fails on 7udev - it fails in SwingSet2 in the combo box demo when focus is on the ComboBox Demo tab and the tab key is pressed to change focus into the first non-edit combo box. > > I'm not an expert in debugging with VS, but I suppose it wants the > .pdb file for the awt.dll. Try locating this file in the build/ > directory and point the VS debugger to it. You should also point VS to > the sources directory (which is jdk/src/windows/native/sun/windows/). I tried that (see below) with no luck. > > -- > best regards, > Anthony > > On 07/10/2013 02:01 AM, Pete Brunet wrote: >> Using code cloned from yesterday, I built the jdk portion of the 7u-dev >> forest using the debug target and the 7u45 import and am getting an >> assert failure in Hashtable.cpp when accessibility is enabled. This is >> a 32 bit build using a 32 bit import. >> >> Letting the execution transition into the debugger stops pointing at >> awt.dll. >> >> How do I debug this? Assuming having debug symbols would help, I set >> the Visual Studio debugger symbols dialog to point at either of these >> two directories but the debugger fails to find the symbols: >> jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. >> >> Pete >> From peter.brunet at oracle.com Wed Jul 10 14:02:28 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 10 Jul 2013 09:02:28 -0500 Subject: How to debug assert failure in awt.dll? In-Reply-To: <51DD682D.6040907@oracle.com> References: <51DC8826.8090604@oracle.com> <51DD1448.1050403@oracle.com> <51DD682D.6040907@oracle.com> Message-ID: <51DD6974.30602@oracle.com> On 7/10/13 8:57 AM, Pete Brunet wrote: > On 7/10/13 2:59 AM, Anthony Petrov wrote: >> This is a known issue http://bugs.sun.com/view_bug.do?bug_id=8013849 >> Looks like it's unrelated to a11y and affects any apps with input boxes. > Thanks Anthony, You are right; it is not a11y related. Is there a bug I > can edit? I'll add more info: > - it fails on 7udev > - it fails in SwingSet2 in the combo box demo when focus is on the > ComboBox Demo tab and the tab key is pressed to change focus into the > first non-edit combo box. It turns out I get that failure whenever pressing the tab key. I didn't extensively test but I got it when tabbing to several different controls. >> I'm not an expert in debugging with VS, but I suppose it wants the >> .pdb file for the awt.dll. Try locating this file in the build/ >> directory and point the VS debugger to it. You should also point VS to >> the sources directory (which is jdk/src/windows/native/sun/windows/). > I tried that (see below) with no luck. >> -- >> best regards, >> Anthony >> >> On 07/10/2013 02:01 AM, Pete Brunet wrote: >>> Using code cloned from yesterday, I built the jdk portion of the 7u-dev >>> forest using the debug target and the 7u45 import and am getting an >>> assert failure in Hashtable.cpp when accessibility is enabled. This is >>> a 32 bit build using a 32 bit import. >>> >>> Letting the execution transition into the debugger stops pointing at >>> awt.dll. >>> >>> How do I debug this? Assuming having debug symbols would help, I set >>> the Visual Studio debugger symbols dialog to point at either of these >>> two directories but the debugger fails to find the symbols: >>> jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. >>> >>> Pete >>> From anthony.petrov at oracle.com Wed Jul 10 14:20:00 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 10 Jul 2013 18:20:00 +0400 Subject: How to debug assert failure in awt.dll? In-Reply-To: <51DD6974.30602@oracle.com> References: <51DC8826.8090604@oracle.com> <51DD1448.1050403@oracle.com> <51DD682D.6040907@oracle.com> <51DD6974.30602@oracle.com> Message-ID: <51DD6D90.5040103@oracle.com> On 07/10/2013 06:02 PM, Pete Brunet wrote: > On 7/10/13 8:57 AM, Pete Brunet wrote: >> On 7/10/13 2:59 AM, Anthony Petrov wrote: >>> This is a known issue http://bugs.sun.com/view_bug.do?bug_id=8013849 >>> Looks like it's unrelated to a11y and affects any apps with input boxes. >> Thanks Anthony, You are right; it is not a11y related. Is there a bug I >> can edit? I'll add more info: Just open up the bug in JBS, and you'll be able to edit it. I don't post a JBS link here on the public mailing list because the JBS isn't public yet. >> - it fails on 7udev >> - it fails in SwingSet2 in the combo box demo when focus is on the >> ComboBox Demo tab and the tab key is pressed to change focus into the >> first non-edit combo box. > It turns out I get that failure whenever pressing the tab key. I didn't > extensively test but I got it when tabbing to several different controls. >>> I'm not an expert in debugging with VS, but I suppose it wants the >>> .pdb file for the awt.dll. Try locating this file in the build/ >>> directory and point the VS debugger to it. You should also point VS to >>> the sources directory (which is jdk/src/windows/native/sun/windows/). >> I tried that (see below) with no luck. Perhaps VS needs some more debugging files. Did you try to attach to the java.exe process from the VS debugger before you're hitting the breakpoint? Anyway, I'm also CC'ing Alexey who could provide some more tips on debugging with VS. -- best regards, Anthony >>> -- >>> best regards, >>> Anthony >>> >>> On 07/10/2013 02:01 AM, Pete Brunet wrote: >>>> Using code cloned from yesterday, I built the jdk portion of the 7u-dev >>>> forest using the debug target and the 7u45 import and am getting an >>>> assert failure in Hashtable.cpp when accessibility is enabled. This is >>>> a 32 bit build using a 32 bit import. >>>> >>>> Letting the execution transition into the debugger stops pointing at >>>> awt.dll. >>>> >>>> How do I debug this? Assuming having debug symbols would help, I set >>>> the Visual Studio debugger symbols dialog to point at either of these >>>> two directories but the debugger fails to find the symbols: >>>> jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. >>>> >>>> Pete >>>> > From peter.brunet at oracle.com Wed Jul 10 15:03:44 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 10 Jul 2013 10:03:44 -0500 Subject: How to debug assert failure in awt.dll? In-Reply-To: References: <51DC8826.8090604@oracle.com> Message-ID: <51DD77D0.8010706@oracle.com> Thanks Denis, I will try a different dirty hack :-) I changed the DASSERT in Hashtable.cpp to if (value == NULL) return NULL; That seems to work. Pete On 7/10/13 4:15 AM, Denis Fokin wrote: > Hi Pete, > > As a dirty hack, you can just comment out > > ret = MessageBoxA(NULL, assertMsg, "AWT Assertion Failure", > MB_YESNO|MB_ICONSTOP|MB_TASKMODAL); > > // if clicked Yes, break into the debugger > if ( ret == IDYES ) { > # if defined(_M_IX86) > _asm { int 3 }; > # else > DebugBreak(); > # endif > } > // otherwise, try to continue execution > > from jdk/src/windows/native/sun/windows/awt_Debug.cpp > > this prevents showing the MessageBox and breaking into the debugger. > > Thank you, > Denis. > > > On Jul 10, 2013, at 2:01 AM, Pete Brunet wrote: > >> Using code cloned from yesterday, I built the jdk portion of the 7u-dev >> forest using the debug target and the 7u45 import and am getting an >> assert failure in Hashtable.cpp when accessibility is enabled. This is >> a 32 bit build using a 32 bit import. >> >> Letting the execution transition into the debugger stops pointing at >> awt.dll. >> >> How do I debug this? Assuming having debug symbols would help, I set >> the Visual Studio debugger symbols dialog to point at either of these >> two directories but the debugger fails to find the symbols: >> jdk7u-dev\jdk\build\windows-i586\tmp\sun\sun.awt\awt\obj_g or obj_gO. >> >> Pete From joe.darcy at oracle.com Wed Jul 10 17:38:19 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 10 Jul 2013 10:38:19 -0700 Subject: Looking ahead: how to enable doclint checking when building java.* and javax.* Message-ID: <51DD9C0B.40908@oracle.com> Hello, Over on core-libs-dev, there has been a sequence of bug fixes to cleanup doclint warnings and errors in the java.* and javax.* areas in JDK 8. A few weeks ago, there were over 2,000 doclint issues; currently there are about 850 remaining and we're making good progress slogging through the rest. Looking ahead a few weeks when we may have the happy situation of zero doclint issues in JDK 8, I wanted to ask on build-dev how doclint warnings and errors can be enabled via the makefiles when building the java.* and javax.* sources and how doclint issues can be made fatal. (Making doclint issues fatal will help discourage them from creeping back in ;-) Thanks, -Joe From tim.bell at oracle.com Wed Jul 10 19:37:58 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 10 Jul 2013 12:37:58 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: References: <51DB0D08.4000608@oracle.com> Message-ID: <51DDB816.5030408@oracle.com> Hi Kelly > How did BUILD_INSTALL ever become true on an OpenJDK build? From the 'generic_debug_build' rule in the top level 7update Makefile [1] generic_debug_build: $(MAKE) \ ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ DEBUG_NAME=$(DEBUG_NAME) \ GENERATE_DOCS=false \ BUILD_INSTALL_BUNDLES=true \ CREATE_DEBUGINFO_BUNDLES=false \ $(BOOT_CYCLE_DEBUG_SETTINGS) \ generic_build_repo_series I will be reopening 8012366 and putting it forward again for approval. Tim [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile > -kto > > On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: > >> All- >> >> My fix for 8007815 [1] did not handle the case of an OpenJDK build that does not have the closed source trees. If a user tries to build that far, the build will fail with "cd: can't cd to ./install/make/installer/binaries/linux" >> >> This is a request for review and approval to fix 8012366 in 7u. These changes will not throw a build error if the closed directories do not exist. Makefile changes only; no product code has been modified: >> >> Link to the bug report: >> >> http://bugs.sun.com/view_bug.do?bug_id=8012366 >> >> webrev of the Makefile changes: >> >> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >> >> Thanks in advance- >> >> Tim >> [1] There is no external link for 8007815, sorry. These changes had to do with building and packaging in the install tree. >> From david.katleman at oracle.com Wed Jul 10 20:07:23 2013 From: david.katleman at oracle.com (David Katleman) Date: Wed, 10 Jul 2013 13:07:23 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DDB816.5030408@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> Message-ID: <51DDBEFB.7020902@oracle.com> On 7/10/2013 12:37 PM, Tim Bell wrote: > Hi Kelly > >> How did BUILD_INSTALL ever become true on an OpenJDK build? There is only one place that the build itself sets BUILD_INSTALL to true and that's upon detection of install/make/Makefile, in make/Defs-internal.gmk: If you have a full forest (or heck, just install/make/Makefile) BUILD_INSTALL will be set to true > INSTALL_SRC_AVAILABLE := $(call MkExists,$(INSTALL_TOPDIR)/make/Makefile) > ifndef BUILD_INSTALL > ifdef DEV_ONLY > BUILD_INSTALL := false > else > BUILD_INSTALL := $(INSTALL_SRC_AVAILABLE) > endif > endif Anything else BUILD_INSTALL=true being passed in at the start of the build, by a script or user. Is there a log of the build with this problem? Thanks Dave > > From the 'generic_debug_build' rule in the top level 7update Makefile [1] > > generic_debug_build: > $(MAKE) \ > ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ > DEBUG_NAME=$(DEBUG_NAME) \ > GENERATE_DOCS=false \ > BUILD_INSTALL_BUNDLES=true \ > CREATE_DEBUGINFO_BUNDLES=false \ > $(BOOT_CYCLE_DEBUG_SETTINGS) \ > generic_build_repo_series > > > I will be reopening 8012366 and putting it forward again for approval. > > Tim > > [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile > > >> -kto >> >> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >> >>> All- >>> >>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>> that does not have the closed source trees. If a user tries to >>> build that far, the build will fail with "cd: can't cd to >>> ./install/make/installer/binaries/linux" >>> >>> This is a request for review and approval to fix 8012366 in 7u. >>> These changes will not throw a build error if the closed directories >>> do not exist. Makefile changes only; no product code has been >>> modified: >>> >>> Link to the bug report: >>> >>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>> >>> webrev of the Makefile changes: >>> >>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>> >>> Thanks in advance- >>> >>> Tim >>> [1] There is no external link for 8007815, sorry. These changes >>> had to do with building and packaging in the install tree. >>> > From tim.bell at oracle.com Wed Jul 10 20:47:18 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 10 Jul 2013 13:47:18 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DDB816.5030408@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> Message-ID: <51DDC856.3040605@oracle.com> On 07/10/13 12:37 PM, Tim Bell wrote: > Hi Kelly > >> How did BUILD_INSTALL ever become true on an OpenJDK build? > > From the 'generic_debug_build' rule in the top level 7update Makefile [1] > > generic_debug_build: > $(MAKE) \ > ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ > DEBUG_NAME=$(DEBUG_NAME) \ > GENERATE_DOCS=false \ > BUILD_INSTALL_BUNDLES=true \ > CREATE_DEBUGINFO_BUNDLES=false \ > $(BOOT_CYCLE_DEBUG_SETTINGS) \ > generic_build_repo_series After giving this more study, let me modify what I wrote a bit - generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes the 'install-binaries-jdk-debug' rule in the same Makefile to also run. This dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not checked. Here is a revised fix and webrev: http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ Tim > [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile [2] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk > >> -kto >> >> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >> >>> All- >>> >>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>> that does not have the closed source trees. If a user tries to >>> build that far, the build will fail with "cd: can't cd to >>> ./install/make/installer/binaries/linux" >>> >>> This is a request for review and approval to fix 8012366 in 7u. >>> These changes will not throw a build error if the closed directories >>> do not exist. Makefile changes only; no product code has been >>> modified: >>> >>> Link to the bug report: >>> >>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>> >>> webrev of the Makefile changes: >>> >>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>> >>> Thanks in advance- >>> >>> Tim >>> [1] There is no external link for 8007815, sorry. These changes >>> had to do with building and packaging in the install tree. >>> > From jonathan.gibbons at oracle.com Wed Jul 10 21:13:51 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 10 Jul 2013 22:13:51 +0100 Subject: Looking ahead: how to enable doclint checking when building java.* and javax.* In-Reply-To: <51DD9C0B.40908@oracle.com> References: <51DD9C0B.40908@oracle.com> Message-ID: <51DDCE8F.2050501@oracle.com> On 07/10/2013 06:38 PM, Joe Darcy wrote: > Hello, > > Over on core-libs-dev, there has been a sequence of bug fixes to > cleanup doclint warnings and errors in the java.* and javax.* areas > in JDK 8. A few weeks ago, there were over 2,000 doclint issues; > currently there are about 850 remaining and we're making good progress > slogging through the rest. > > Looking ahead a few weeks when we may have the happy situation of zero > doclint issues in JDK 8, I wanted to ask on build-dev how doclint > warnings and errors can be enabled via the makefiles when building the > java.* and javax.* sources and how doclint issues can be made fatal. > (Making doclint issues fatal will help discourage them from creeping > back in ;-) > > Thanks, > > -Joe javac has a -Xdoclint option, similar to -Xlint that can enable warnings at compile time. The hope is that engineers will enable that in their compilation environment and fix doc comment errors at the same time as their compilation errors. -- Jon From joe.darcy at oracle.com Wed Jul 10 22:32:17 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 10 Jul 2013 15:32:17 -0700 Subject: Looking ahead: how to enable doclint checking when building java.* and javax.* In-Reply-To: <51DDCE8F.2050501@oracle.com> References: <51DD9C0B.40908@oracle.com> <51DDCE8F.2050501@oracle.com> Message-ID: <51DDE0F1.6080203@oracle.com> On 07/10/2013 02:13 PM, Jonathan Gibbons wrote: > On 07/10/2013 06:38 PM, Joe Darcy wrote: >> Hello, >> >> Over on core-libs-dev, there has been a sequence of bug fixes to >> cleanup doclint warnings and errors in the java.* and javax.* areas >> in JDK 8. A few weeks ago, there were over 2,000 doclint issues; >> currently there are about 850 remaining and we're making good >> progress slogging through the rest. >> >> Looking ahead a few weeks when we may have the happy situation of >> zero doclint issues in JDK 8, I wanted to ask on build-dev how >> doclint warnings and errors can be enabled via the makefiles when >> building the java.* and javax.* sources and how doclint issues can be >> made fatal. (Making doclint issues fatal will help discourage them >> from creeping back in ;-) >> >> Thanks, >> >> -Joe > > javac has a -Xdoclint option, similar to -Xlint that can enable > warnings at compile time. The hope is that engineers will enable that > in their compilation environment and fix doc comment errors at the > same time as their compilation errors. > > Right; personally, I usually run doclint through javac vs. javadoc. Just to be clear, once we get doclint-clean, the functionality I'd like to see in the JDK build of the java[x].* classes is: * doclint gets run as part of compiling these types * doclint errors are fatal * doclint warnings are fatal too -Joe From david.holmes at oracle.com Thu Jul 11 05:30:56 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 11 Jul 2013 15:30:56 +1000 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DDC856.3040605@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> Message-ID: <51DE4310.90109@oracle.com> Tim, On 11/07/2013 6:47 AM, Tim Bell wrote: > On 07/10/13 12:37 PM, Tim Bell wrote: >> Hi Kelly >> >>> How did BUILD_INSTALL ever become true on an OpenJDK build? >> >> From the 'generic_debug_build' rule in the top level 7update Makefile [1] >> >> generic_debug_build: >> $(MAKE) \ >> ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ >> DEBUG_NAME=$(DEBUG_NAME) \ >> GENERATE_DOCS=false \ >> BUILD_INSTALL_BUNDLES=true \ >> CREATE_DEBUGINFO_BUNDLES=false \ >> $(BOOT_CYCLE_DEBUG_SETTINGS) \ >> generic_build_repo_series > > > After giving this more study, let me modify what I wrote a bit - > generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes the > 'install-binaries-jdk-debug' rule in the same Makefile to also run. This > dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not > checked. > > Here is a revised fix and webrev: > > http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ Does this also need to check for OPENJDK in case you are doing an OPENJDK build with a full forest present? Or is this logic already by-passed for OPENJDK builds? David > Tim > >> [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile > > [2] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk > > > >> >>> -kto >>> >>> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >>> >>>> All- >>>> >>>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>>> that does not have the closed source trees. If a user tries to >>>> build that far, the build will fail with "cd: can't cd to >>>> ./install/make/installer/binaries/linux" >>>> >>>> This is a request for review and approval to fix 8012366 in 7u. >>>> These changes will not throw a build error if the closed directories >>>> do not exist. Makefile changes only; no product code has been >>>> modified: >>>> >>>> Link to the bug report: >>>> >>>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>>> >>>> webrev of the Makefile changes: >>>> >>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>>> >>>> Thanks in advance- >>>> >>>> Tim >>>> [1] There is no external link for 8007815, sorry. These changes >>>> had to do with building and packaging in the install tree. >>>> >> > From erik.joelsson at oracle.com Thu Jul 11 08:09:04 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 11 Jul 2013 10:09:04 +0200 Subject: Looking ahead: how to enable doclint checking when building java.* and javax.* In-Reply-To: <51DDE0F1.6080203@oracle.com> References: <51DD9C0B.40908@oracle.com> <51DDCE8F.2050501@oracle.com> <51DDE0F1.6080203@oracle.com> Message-ID: <51DE6820.1060704@oracle.com> On 2013-07-11 00:32, Joe Darcy wrote: > On 07/10/2013 02:13 PM, Jonathan Gibbons wrote: >> On 07/10/2013 06:38 PM, Joe Darcy wrote: >>> Hello, >>> >>> Over on core-libs-dev, there has been a sequence of bug fixes to >>> cleanup doclint warnings and errors in the java.* and javax.* areas >>> in JDK 8. A few weeks ago, there were over 2,000 doclint issues; >>> currently there are about 850 remaining and we're making good >>> progress slogging through the rest. >>> >>> Looking ahead a few weeks when we may have the happy situation of >>> zero doclint issues in JDK 8, I wanted to ask on build-dev how >>> doclint warnings and errors can be enabled via the makefiles when >>> building the java.* and javax.* sources and how doclint issues can >>> be made fatal. (Making doclint issues fatal will help discourage >>> them from creeping back in ;-) >>> >>> Thanks, >>> >>> -Joe >> >> javac has a -Xdoclint option, similar to -Xlint that can enable >> warnings at compile time. The hope is that engineers will enable >> that in their compilation environment and fix doc comment errors at >> the same time as their compilation errors. >> >> > > Right; personally, I usually run doclint through javac vs. javadoc. > > Just to be clear, once we get doclint-clean, the functionality I'd > like to see in the JDK build of the java[x].* classes is: > > * doclint gets run as part of compiling these types > * doclint errors are fatal > * doclint warnings are fatal too The new build compiles all (or at least most) java classes in one go. This is good for speed, but loses on flexibility. I do not know of a way to apply different sets of warnings to subsets of the sources being compiled. The way this was handled in the old build, compiling subsets of the source at a time, gave a bit more flexibility, but instead lost on reliability as implicit compilation made it very hard to reliably know which code was actually compiled with which set of warnings. I believe Fredrik had future plans for sjavac to handle different sets of compiler options for different subsets of source code, which could be used to solve this problem. But that's not implemented (yet). /Erik From erik.joelsson at oracle.com Thu Jul 11 08:19:50 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 11 Jul 2013 10:19:50 +0200 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DE4310.90109@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> Message-ID: <51DE6AA6.1000706@oracle.com> On 2013-07-11 07:30, David Holmes wrote: > Tim, > > On 11/07/2013 6:47 AM, Tim Bell wrote: >> On 07/10/13 12:37 PM, Tim Bell wrote: >>> Hi Kelly >>> >>>> How did BUILD_INSTALL ever become true on an OpenJDK build? >>> >>> From the 'generic_debug_build' rule in the top level 7update >>> Makefile [1] >>> >>> generic_debug_build: >>> $(MAKE) \ >>> ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ >>> DEBUG_NAME=$(DEBUG_NAME) \ >>> GENERATE_DOCS=false \ >>> BUILD_INSTALL_BUNDLES=true \ >>> CREATE_DEBUGINFO_BUNDLES=false \ >>> $(BOOT_CYCLE_DEBUG_SETTINGS) \ >>> generic_build_repo_series >> >> >> After giving this more study, let me modify what I wrote a bit - >> generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes the >> 'install-binaries-jdk-debug' rule in the same Makefile to also run. This >> dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not >> checked. >> >> Here is a revised fix and webrev: >> >> http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ > > Does this also need to check for OPENJDK in case you are doing an > OPENJDK build with a full forest present? Or is this logic already > by-passed for OPENJDK builds? > Setting OPENJDK=true on the command line will force BUILD_INSTALL=false, even if the source is available, and INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested an OPENJDK build with the full forest available, I would not expect the build to head down into the install repo, even for debug bundles. For this reason I think the check should be against BUILD_INSTALL instead of INSTALL_SRC_AVAILABLE. /Erik > David > >> Tim >> >>> [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile >> >> [2] >> http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk >> >> >> >>> >>>> -kto >>>> >>>> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >>>> >>>>> All- >>>>> >>>>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>>>> that does not have the closed source trees. If a user tries to >>>>> build that far, the build will fail with "cd: can't cd to >>>>> ./install/make/installer/binaries/linux" >>>>> >>>>> This is a request for review and approval to fix 8012366 in 7u. >>>>> These changes will not throw a build error if the closed directories >>>>> do not exist. Makefile changes only; no product code has been >>>>> modified: >>>>> >>>>> Link to the bug report: >>>>> >>>>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>>>> >>>>> webrev of the Makefile changes: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>>>> >>>>> Thanks in advance- >>>>> >>>>> Tim >>>>> [1] There is no external link for 8007815, sorry. These changes >>>>> had to do with building and packaging in the install tree. >>>>> >>> >> From jonathan.gibbons at oracle.com Thu Jul 11 10:13:30 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 11 Jul 2013 11:13:30 +0100 Subject: Looking ahead: how to enable doclint checking when building java.* and javax.* In-Reply-To: <51DE6820.1060704@oracle.com> References: <51DD9C0B.40908@oracle.com> <51DDCE8F.2050501@oracle.com> <51DDE0F1.6080203@oracle.com> <51DE6820.1060704@oracle.com> Message-ID: <51DE854A.90000@oracle.com> On 07/11/2013 09:09 AM, Erik Joelsson wrote: > > > On 2013-07-11 00:32, Joe Darcy wrote: >> On 07/10/2013 02:13 PM, Jonathan Gibbons wrote: >>> On 07/10/2013 06:38 PM, Joe Darcy wrote: >>>> Hello, >>>> >>>> Over on core-libs-dev, there has been a sequence of bug fixes to >>>> cleanup doclint warnings and errors in the java.* and javax.* >>>> areas in JDK 8. A few weeks ago, there were over 2,000 doclint >>>> issues; currently there are about 850 remaining and we're making >>>> good progress slogging through the rest. >>>> >>>> Looking ahead a few weeks when we may have the happy situation of >>>> zero doclint issues in JDK 8, I wanted to ask on build-dev how >>>> doclint warnings and errors can be enabled via the makefiles when >>>> building the java.* and javax.* sources and how doclint issues can >>>> be made fatal. (Making doclint issues fatal will help discourage >>>> them from creeping back in ;-) >>>> >>>> Thanks, >>>> >>>> -Joe >>> >>> javac has a -Xdoclint option, similar to -Xlint that can enable >>> warnings at compile time. The hope is that engineers will enable >>> that in their compilation environment and fix doc comment errors at >>> the same time as their compilation errors. >>> >>> >> >> Right; personally, I usually run doclint through javac vs. javadoc. >> >> Just to be clear, once we get doclint-clean, the functionality I'd >> like to see in the JDK build of the java[x].* classes is: >> >> * doclint gets run as part of compiling these types >> * doclint errors are fatal >> * doclint warnings are fatal too > The new build compiles all (or at least most) java classes in one go. > This is good for speed, but loses on flexibility. I do not know of a > way to apply different sets of warnings to subsets of the sources > being compiled. The way this was handled in the old build, compiling > subsets of the source at a time, gave a bit more flexibility, but > instead lost on reliability as implicit compilation made it very hard > to reliably know which code was actually compiled with which set of > warnings. > > I believe Fredrik had future plans for sjavac to handle different sets > of compiler options for different subsets of source code, which could > be used to solve this problem. But that's not implemented (yet). > > /Erik Just FYI, currently you can't make doclint warnings fatal without making all warnings fatal. That's mostly OK since most javac warnings are opt-in by default, but there are some warnings that are always enabled. So we would need to make sure that those warnings are kept under control. We might want to be selective about some of the doclint warnings to begin with, since some of the warnings require fixing by fixing the stylesheet (such as adding a new style). But right now we are making good progress on fixing up comments and understanding the issues that still need to be addressed. -- Jon -- Jon From Thomas.Salter at unisys.com Thu Jul 11 18:51:50 2013 From: Thomas.Salter at unisys.com (Salter, Thomas A) Date: Thu, 11 Jul 2013 13:51:50 -0500 Subject: MinGW/MSYS Message-ID: <63D5DCACD1E9E34C89C8203C64F521C301367D4B6101@USEA-EXCH7.na.uis.unisys.com> Is MinGW/MSYS supposed to be supported now? Is a particular version required? I've gotten builds to work with cygwin and wanted to try MinGW/MSYS. It ails almost immediately because it can't find cpio. It acts as though the uname result isn't recognized. I'm running on a 64-bit Windows 7 system. The complete config.log is attached, but the part that I think matters is here: hostname = USTR-SALTERTA-1 uname -m = i686 uname -r = 1.0.17(0.48/3/2) uname -s = MINGW32_NT-6.1 uname -v = 2011-04-24 23:39 ... configure:4413: found /usr/bin/cp configure:4425: result: /usr/bin/cp configure:4454: checking for cpio configure:4487: result: no configure:4502: Could not find cpio! configure:4504: error: Cannot continue ? Tom Salter? |? Software Engineer? |? Java & Middleware Development Unisys? |? 2476 Swedesford Road? |? Malvern, PA? 19355?? |? 610-648-2568 | ?N385-2568 From david.katleman at oracle.com Thu Jul 11 21:03:46 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:03:46 +0000 Subject: hg: jdk8/build/jdk: 8020414: JDK8 b98 source with GPL header errors Message-ID: <20130711210411.566D9489F7@hg.openjdk.java.net> Changeset: 56bc019a0525 Author: katleman Date: 2013-07-11 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/56bc019a0525 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/sun/security/krb5/auto/NoneReplayCacheTest.java From david.katleman at oracle.com Thu Jul 11 21:08:17 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:08:17 +0000 Subject: hg: jdk8/build/hotspot: 8020414: JDK8 b98 source with GPL header errors Message-ID: <20130711210822.8C9ED489F8@hg.openjdk.java.net> Changeset: dc8afa03e5c9 Author: katleman Date: 2013-07-11 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dc8afa03e5c9 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/runtime/8001071/Test8001071.sh From david.katleman at oracle.com Thu Jul 11 21:36:14 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:36:14 +0000 Subject: hg: jdk8/build/hotspot: 2 new changesets Message-ID: <20130711213618.58A16489FC@hg.openjdk.java.net> Changeset: 1a3390aa8326 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a3390aa8326 Added tag jdk8-b98 for changeset 30b5b75c42ac ! .hgtags Changeset: 1c474723a324 Author: katleman Date: 2013-07-11 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1c474723a324 Merge From david.katleman at oracle.com Thu Jul 11 21:35:30 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:35:30 +0000 Subject: hg: jdk8/build: Added tag jdk8-b98 for changeset 0d0c983a817b Message-ID: <20130711213530.32F53489FA@hg.openjdk.java.net> Changeset: 59dc9da81379 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/59dc9da81379 Added tag jdk8-b98 for changeset 0d0c983a817b ! .hgtags From david.katleman at oracle.com Thu Jul 11 21:35:33 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:35:33 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b98 for changeset 3370fb6146e4 Message-ID: <20130711213534.5E98D489FB@hg.openjdk.java.net> Changeset: 3f67804ab613 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/3f67804ab613 Added tag jdk8-b98 for changeset 3370fb6146e4 ! .hgtags From david.katleman at oracle.com Thu Jul 11 21:38:09 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:38:09 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20130711213832.AAEDB489FF@hg.openjdk.java.net> Changeset: 758c21301545 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/758c21301545 Added tag jdk8-b98 for changeset c4908732fef5 ! .hgtags Changeset: 030d1ca7432f Author: katleman Date: 2013-07-11 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/030d1ca7432f Merge From david.katleman at oracle.com Thu Jul 11 21:37:57 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:37:57 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b98 for changeset b1fb4612a2ca Message-ID: <20130711213801.13DF3489FE@hg.openjdk.java.net> Changeset: 8ef83d4b23c9 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/8ef83d4b23c9 Added tag jdk8-b98 for changeset b1fb4612a2ca ! .hgtags From david.katleman at oracle.com Thu Jul 11 21:37:49 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:37:49 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b98 for changeset 15e5bb51bc0c Message-ID: <20130711213752.E353A489FD@hg.openjdk.java.net> Changeset: adf49c3ef83c Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/adf49c3ef83c Added tag jdk8-b98 for changeset 15e5bb51bc0c ! .hgtags From david.katleman at oracle.com Thu Jul 11 21:39:47 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:39:47 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b98 for changeset ce5a90df517b Message-ID: <20130711213953.0D5EE48A00@hg.openjdk.java.net> Changeset: bdeef606be8e Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bdeef606be8e Added tag jdk8-b98 for changeset ce5a90df517b ! .hgtags From david.katleman at oracle.com Thu Jul 11 21:40:01 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 11 Jul 2013 21:40:01 +0000 Subject: hg: jdk8/build/nashorn: Added tag jdk8-b98 for changeset 542b7803f038 Message-ID: <20130711214003.64BD148A01@hg.openjdk.java.net> Changeset: 10a1ab9e20a4 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/10a1ab9e20a4 Added tag jdk8-b98 for changeset 542b7803f038 ! .hgtags From tim.bell at oracle.com Thu Jul 11 22:08:11 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 11 Jul 2013 15:08:11 -0700 Subject: MinGW/MSYS In-Reply-To: <63D5DCACD1E9E34C89C8203C64F521C301367D4B6101@USEA-EXCH7.na.uis.unisys.com> References: <63D5DCACD1E9E34C89C8203C64F521C301367D4B6101@USEA-EXCH7.na.uis.unisys.com> Message-ID: <51DF2CCB.4000505@oracle.com> On 07/11/13 11:51 AM, Salter, Thomas A wrote: > Is MinGW/MSYS supposed to be supported now? Is a particular version required? The only version I could find was this: $ /usr/bin/msysinfo | head reports: > msysinfo-1.3: Send this to the MSYS support list: > > MSYS 1.0.17(0.48/3/2) 2011-04-24 23:39 i686 unknown; targ=MINGW32 > GNU bash, version 3.1.17(1)-release (i686-pc-msys); ENV=.profile > GNU Make 3.81This program built for i686-pc-msys; MAKE_MODE=unix That was about 12 months ago. I admit I stopped looking after that. Looks like uname matches what you posted below: $ uname -r 1.0.17(0.48/3/2) $ uname -m i686 $ uname -r 1.0.17(0.48/3/2) $ uname -s MINGW32_NT-6.1 $ uname -v 2011-04-24 23:39 > I've gotten builds to work with cygwin and wanted to try MinGW/MSYS. It ails almost immediately because it can't find cpio. It acts as though the uname result isn't recognized. MSYS was working for OpenJDK8 builds. I could not find cpio for MinGW/MSYS, so I implemented a workaround using back-to-back tar. That could have bitrotted, so I'll have to do a test build to verify. > I'm running on a 64-bit Windows 7 system. > > The complete config.log is attached, but the part that I think matters is here: > > hostname = USTR-SALTERTA-1 > uname -m = i686 > uname -r = 1.0.17(0.48/3/2) > uname -s = MINGW32_NT-6.1 > uname -v = 2011-04-24 23:39 > > ... > > configure:4413: found /usr/bin/cp > configure:4425: result: /usr/bin/cp > configure:4454: checking for cpio > configure:4487: result: no > configure:4502: Could not find cpio! > configure:4504: error: Cannot continue If using MSYS, we shouldn't require cpio in the sanity check. I'll try a test fix later today and send a patch if it works. Tim From tim.bell at oracle.com Fri Jul 12 05:22:13 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 11 Jul 2013 22:22:13 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DE6AA6.1000706@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> <51DE6AA6.1000706@oracle.com> Message-ID: <51DF9285.4050003@oracle.com> David, Erik - Thanks for the feedback: > Does this also need to check for OPENJDK in case you are doing an > OPENJDK build with a full forest present? Or is this logic already > by-passed for OPENJDK builds? > David > Setting OPENJDK=true on the command line will force > BUILD_INSTALL=false, even if the source is available, and > INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested an > OPENJDK build with the full forest available, I would not expect the > build to head down into the install repo, even for debug bundles. For > this reason I think the check should be against BUILD_INSTALL instead > of INSTALL_SRC_AVAILABLE. > > /Erik The revised change looks for BUILD_INSTALL instead, which I believe handles both points. The webrev is here: http://cr.openjdk.java.net/~tbell/8012366/webrev.02/ Tim On 07/11/13 01:19 AM, Erik Joelsson wrote: > On 2013-07-11 07:30, David Holmes wrote: >> Tim, >> >> On 11/07/2013 6:47 AM, Tim Bell wrote: >>> On 07/10/13 12:37 PM, Tim Bell wrote: >>>> Hi Kelly >>>> >>>>> How did BUILD_INSTALL ever become true on an OpenJDK build? >>>> >>>> From the 'generic_debug_build' rule in the top level 7update >>>> Makefile [1] >>>> >>>> generic_debug_build: >>>> $(MAKE) \ >>>> ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ >>>> DEBUG_NAME=$(DEBUG_NAME) \ >>>> GENERATE_DOCS=false \ >>>> BUILD_INSTALL_BUNDLES=true \ >>>> CREATE_DEBUGINFO_BUNDLES=false \ >>>> $(BOOT_CYCLE_DEBUG_SETTINGS) \ >>>> generic_build_repo_series >>> >>> >>> After giving this more study, let me modify what I wrote a bit - >>> generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes the >>> 'install-binaries-jdk-debug' rule in the same Makefile to also run. >>> This >>> dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not >>> checked. >>> >>> Here is a revised fix and webrev: >>> >>> http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ >> >> Does this also need to check for OPENJDK in case you are doing an >> OPENJDK build with a full forest present? Or is this logic already >> by-passed for OPENJDK builds? >> > Setting OPENJDK=true on the command line will force > BUILD_INSTALL=false, even if the source is available, and > INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested an > OPENJDK build with the full forest available, I would not expect the > build to head down into the install repo, even for debug bundles. For > this reason I think the check should be against BUILD_INSTALL instead > of INSTALL_SRC_AVAILABLE. > > /Erik > >> David >> >>> Tim >>> >>>> [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile >>> >>> [2] >>> http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk >>> >>> >>> >>>> >>>>> -kto >>>>> >>>>> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >>>>> >>>>>> All- >>>>>> >>>>>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>>>>> that does not have the closed source trees. If a user tries to >>>>>> build that far, the build will fail with "cd: can't cd to >>>>>> ./install/make/installer/binaries/linux" >>>>>> >>>>>> This is a request for review and approval to fix 8012366 in 7u. >>>>>> These changes will not throw a build error if the closed directories >>>>>> do not exist. Makefile changes only; no product code has been >>>>>> modified: >>>>>> >>>>>> Link to the bug report: >>>>>> >>>>>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>>>>> >>>>>> webrev of the Makefile changes: >>>>>> >>>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>>>>> >>>>>> Thanks in advance- >>>>>> >>>>>> Tim >>>>>> [1] There is no external link for 8007815, sorry. These changes >>>>>> had to do with building and packaging in the install tree. >>>>>> >>>> >>> From erik.joelsson at oracle.com Fri Jul 12 06:57:35 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 12 Jul 2013 08:57:35 +0200 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DF9285.4050003@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> <51DE6AA6.1000706@oracle.com> <51DF9285.4050003@oracle.com> Message-ID: <51DFA8DF.1020801@oracle.com> Looks good to me though I'm not a jdk7 reviewer. /Erik On 2013-07-12 07:22, Tim Bell wrote: > David, Erik - > > Thanks for the feedback: > >> Does this also need to check for OPENJDK in case you are doing an >> OPENJDK build with a full forest present? Or is this logic already >> by-passed for OPENJDK builds? David > > >> Setting OPENJDK=true on the command line will force >> BUILD_INSTALL=false, even if the source is available, and >> INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested >> an OPENJDK build with the full forest available, I would not expect >> the build to head down into the install repo, even for debug bundles. >> For this reason I think the check should be against BUILD_INSTALL >> instead of INSTALL_SRC_AVAILABLE. >> >> /Erik > > The revised change looks for BUILD_INSTALL instead, which I believe > handles both points. The webrev is here: > > http://cr.openjdk.java.net/~tbell/8012366/webrev.02/ > > Tim > > > > On 07/11/13 01:19 AM, Erik Joelsson wrote: >> On 2013-07-11 07:30, David Holmes wrote: >>> Tim, >>> >>> On 11/07/2013 6:47 AM, Tim Bell wrote: >>>> On 07/10/13 12:37 PM, Tim Bell wrote: >>>>> Hi Kelly >>>>> >>>>>> How did BUILD_INSTALL ever become true on an OpenJDK build? >>>>> >>>>> From the 'generic_debug_build' rule in the top level 7update >>>>> Makefile [1] >>>>> >>>>> generic_debug_build: >>>>> $(MAKE) \ >>>>> ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ >>>>> DEBUG_NAME=$(DEBUG_NAME) \ >>>>> GENERATE_DOCS=false \ >>>>> BUILD_INSTALL_BUNDLES=true \ >>>>> CREATE_DEBUGINFO_BUNDLES=false \ >>>>> $(BOOT_CYCLE_DEBUG_SETTINGS) \ >>>>> generic_build_repo_series >>>> >>>> >>>> After giving this more study, let me modify what I wrote a bit - >>>> generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes >>>> the >>>> 'install-binaries-jdk-debug' rule in the same Makefile to also run. >>>> This >>>> dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not >>>> checked. >>>> >>>> Here is a revised fix and webrev: >>>> >>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ >>> >>> Does this also need to check for OPENJDK in case you are doing an >>> OPENJDK build with a full forest present? Or is this logic already >>> by-passed for OPENJDK builds? >>> >> Setting OPENJDK=true on the command line will force >> BUILD_INSTALL=false, even if the source is available, and >> INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested >> an OPENJDK build with the full forest available, I would not expect >> the build to head down into the install repo, even for debug bundles. >> For this reason I think the check should be against BUILD_INSTALL >> instead of INSTALL_SRC_AVAILABLE. >> >> /Erik >> >>> David >>> >>>> Tim >>>> >>>>> [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile >>>> >>>> [2] >>>> http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk >>>> >>>> >>>> >>>>> >>>>>> -kto >>>>>> >>>>>> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >>>>>> >>>>>>> All- >>>>>>> >>>>>>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>>>>>> that does not have the closed source trees. If a user tries to >>>>>>> build that far, the build will fail with "cd: can't cd to >>>>>>> ./install/make/installer/binaries/linux" >>>>>>> >>>>>>> This is a request for review and approval to fix 8012366 in 7u. >>>>>>> These changes will not throw a build error if the closed >>>>>>> directories >>>>>>> do not exist. Makefile changes only; no product code has been >>>>>>> modified: >>>>>>> >>>>>>> Link to the bug report: >>>>>>> >>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>>>>>> >>>>>>> webrev of the Makefile changes: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>>>>>> >>>>>>> Thanks in advance- >>>>>>> >>>>>>> Tim >>>>>>> [1] There is no external link for 8007815, sorry. These changes >>>>>>> had to do with building and packaging in the install tree. >>>>>>> >>>>> >>>> > From david.holmes at oracle.com Fri Jul 12 07:02:52 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 12 Jul 2013 17:02:52 +1000 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DFA8DF.1020801@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> <51DE6AA6.1000706@oracle.com> <51DF9285.4050003@oracle.com> <51DFA8DF.1020801@oracle.com> Message-ID: <51DFAA1C.90402@oracle.com> On 12/07/2013 4:57 PM, Erik Joelsson wrote: > Looks good to me though I'm not a jdk7 reviewer. I am :) Tim I think this is okay. Certainly it only makes sense to build install bundles if building install. I just wonder why building install bundles has to appear at this top-level anyway. But that's a different issue. David ----- > /Erik > > On 2013-07-12 07:22, Tim Bell wrote: >> David, Erik - >> >> Thanks for the feedback: >> >>> Does this also need to check for OPENJDK in case you are doing an >>> OPENJDK build with a full forest present? Or is this logic already >>> by-passed for OPENJDK builds? David >> >> >>> Setting OPENJDK=true on the command line will force >>> BUILD_INSTALL=false, even if the source is available, and >>> INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested >>> an OPENJDK build with the full forest available, I would not expect >>> the build to head down into the install repo, even for debug bundles. >>> For this reason I think the check should be against BUILD_INSTALL >>> instead of INSTALL_SRC_AVAILABLE. >>> >>> /Erik >> >> The revised change looks for BUILD_INSTALL instead, which I believe >> handles both points. The webrev is here: >> >> http://cr.openjdk.java.net/~tbell/8012366/webrev.02/ >> >> Tim >> >> >> >> On 07/11/13 01:19 AM, Erik Joelsson wrote: >>> On 2013-07-11 07:30, David Holmes wrote: >>>> Tim, >>>> >>>> On 11/07/2013 6:47 AM, Tim Bell wrote: >>>>> On 07/10/13 12:37 PM, Tim Bell wrote: >>>>>> Hi Kelly >>>>>> >>>>>>> How did BUILD_INSTALL ever become true on an OpenJDK build? >>>>>> >>>>>> From the 'generic_debug_build' rule in the top level 7update >>>>>> Makefile [1] >>>>>> >>>>>> generic_debug_build: >>>>>> $(MAKE) \ >>>>>> ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ >>>>>> DEBUG_NAME=$(DEBUG_NAME) \ >>>>>> GENERATE_DOCS=false \ >>>>>> BUILD_INSTALL_BUNDLES=true \ >>>>>> CREATE_DEBUGINFO_BUNDLES=false \ >>>>>> $(BOOT_CYCLE_DEBUG_SETTINGS) \ >>>>>> generic_build_repo_series >>>>> >>>>> >>>>> After giving this more study, let me modify what I wrote a bit - >>>>> generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes >>>>> the >>>>> 'install-binaries-jdk-debug' rule in the same Makefile to also run. >>>>> This >>>>> dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not >>>>> checked. >>>>> >>>>> Here is a revised fix and webrev: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ >>>> >>>> Does this also need to check for OPENJDK in case you are doing an >>>> OPENJDK build with a full forest present? Or is this logic already >>>> by-passed for OPENJDK builds? >>>> >>> Setting OPENJDK=true on the command line will force >>> BUILD_INSTALL=false, even if the source is available, and >>> INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested >>> an OPENJDK build with the full forest available, I would not expect >>> the build to head down into the install repo, even for debug bundles. >>> For this reason I think the check should be against BUILD_INSTALL >>> instead of INSTALL_SRC_AVAILABLE. >>> >>> /Erik >>> >>>> David >>>> >>>>> Tim >>>>> >>>>>> [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile >>>>> >>>>> [2] >>>>> http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk >>>>> >>>>> >>>>> >>>>>> >>>>>>> -kto >>>>>>> >>>>>>> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >>>>>>> >>>>>>>> All- >>>>>>>> >>>>>>>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>>>>>>> that does not have the closed source trees. If a user tries to >>>>>>>> build that far, the build will fail with "cd: can't cd to >>>>>>>> ./install/make/installer/binaries/linux" >>>>>>>> >>>>>>>> This is a request for review and approval to fix 8012366 in 7u. >>>>>>>> These changes will not throw a build error if the closed >>>>>>>> directories >>>>>>>> do not exist. Makefile changes only; no product code has been >>>>>>>> modified: >>>>>>>> >>>>>>>> Link to the bug report: >>>>>>>> >>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>>>>>>> >>>>>>>> webrev of the Makefile changes: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>>>>>>> >>>>>>>> Thanks in advance- >>>>>>>> >>>>>>>> Tim >>>>>>>> [1] There is no external link for 8007815, sorry. These changes >>>>>>>> had to do with building and packaging in the install tree. >>>>>>>> >>>>>> >>>>> >> From jin.phd at gmail.com Fri Jul 12 08:14:06 2013 From: jin.phd at gmail.com (Jin Mingjian) Date: Fri, 12 Jul 2013 16:14:06 +0800 Subject: fail to build profiles in my system Message-ID: Hi, build team, very thanks for the great new build system. I always succeed to build whole by "make all". But fail to build profiles by "make profiles". This command used to work in the initial weeks after the profile works into the hg repo. I am using an arch based custom linux. So, I do not expect it is always perfectly well in my system. But it is very appreciated if some one could give some suggestions to digg this problem further! Does profiles building need some pre-reuqirenments? or could some broken binary(like zip) in my system cause this error? very thanks. best regards, Jin Mingjian =============== the terminal out is like this: > make profiles Building OpenJDK for target 'profiles' in configuration 'linux-x86_64-normal-server-release' ## Starting langtools ## Finished langtools (build time 00:00:00) ## Starting hotspot ## Finished hotspot (build time 00:00:00) ## Starting corba ## Finished corba (build time 00:00:00) ## Starting jaxp ## Finished jaxp (build time 00:00:00) ## Starting jaxws ## Finished jaxws (build time 00:00:00) ## Starting jdk ## Finished jdk (build time 00:00:01) ## Starting profiles make[2]: *** No rule to make target `/ming/build/openjdk-lambda/lambda/build/linux-x86_64-normal-server-release/images/beanless/java/util/jar/Pack200\$Packer.class', needed by `/ming/build/openjdk-lambda/lambda/build/linux-x86_64-normal-server-release/images/libprofile_1/rt.jar'. Stop. make[2]: *** Waiting for unfinished jobs.... Removed method addPropertyChangeListener(java.beans.PropertyChangeListener) from java/util/logging/LogManager Removed method removePropertyChangeListener(java.beans.PropertyChangeListener) from java/util/logging/LogManager make[1]: *** [profile_1] Error 2 make: *** [profiles-only] Error 2 From david.holmes at oracle.com Fri Jul 12 11:07:56 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 12 Jul 2013 21:07:56 +1000 Subject: fail to build profiles in my system In-Reply-To: References: Message-ID: <51DFE38C.70403@oracle.com> Hi Jin, Try "make images profiles" as a workaround. I suspect there is a missing dependency. David On 12/07/2013 6:14 PM, Jin Mingjian wrote: > Hi, build team, > > very thanks for the great new build system. I always succeed to build whole > by "make all". But fail to build profiles by "make profiles". This command > used to work in the initial weeks after the profile works into the hg repo. > > I am using an arch based custom linux. So, I do not expect it is always > perfectly well in my system. But it is very appreciated if some one could > give some suggestions to digg this problem further! Does profiles building > need some pre-reuqirenments? or could some broken binary(like zip) in my > system cause this error? very thanks. > > best regards, > Jin Mingjian > > > =============== > the terminal out is like this: > >> make profiles > Building OpenJDK for target 'profiles' in configuration > 'linux-x86_64-normal-server-release' > > ## Starting langtools > ## Finished langtools (build time 00:00:00) > > ## Starting hotspot > ## Finished hotspot (build time 00:00:00) > > ## Starting corba > ## Finished corba (build time 00:00:00) > > ## Starting jaxp > ## Finished jaxp (build time 00:00:00) > > ## Starting jaxws > ## Finished jaxws (build time 00:00:00) > > ## Starting jdk > ## Finished jdk (build time 00:00:01) > > ## Starting profiles > make[2]: *** No rule to make target > `/ming/build/openjdk-lambda/lambda/build/linux-x86_64-normal-server-release/images/beanless/java/util/jar/Pack200\$Packer.class', > needed by > `/ming/build/openjdk-lambda/lambda/build/linux-x86_64-normal-server-release/images/libprofile_1/rt.jar'. > Stop. > make[2]: *** Waiting for unfinished jobs.... > Removed method addPropertyChangeListener(java.beans.PropertyChangeListener) > from java/util/logging/LogManager > Removed method > removePropertyChangeListener(java.beans.PropertyChangeListener) from > java/util/logging/LogManager > make[1]: *** [profile_1] Error 2 > make: *** [profiles-only] Error 2 > From dalibor.topic at oracle.com Fri Jul 12 15:25:48 2013 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 12 Jul 2013 17:25:48 +0200 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DFA8DF.1020801@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> <51DE6AA6.1000706@oracle.com> <51DF9285.4050003@oracle.com> <51DFA8DF.1020801@oracle.com> Message-ID: <51E01FFC.7070104@oracle.com> On 7/12/13 8:57 AM, Erik Joelsson wrote: > Looks good to me though I'm not a jdk7 reviewer. Looks good to me, too. Local OpenJDK build on OS X and an OpenJDK linux build on JPRT both passed. Please send in a fresh phase 2 approval request to the jdk7u-dev list. cheers, dalibor topic > /Erik > > On 2013-07-12 07:22, Tim Bell wrote: >> David, Erik - >> >> Thanks for the feedback: >> >>> Does this also need to check for OPENJDK in case you are doing an OPENJDK build with a full forest present? Or is this logic already by-passed for OPENJDK builds? David >> >> >>> Setting OPENJDK=true on the command line will force BUILD_INSTALL=false, even if the source is available, and INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested an OPENJDK build with the full forest available, I would not expect the build to head down into the install repo, even for debug bundles. For this reason I think the check should be against BUILD_INSTALL instead of INSTALL_SRC_AVAILABLE. >>> >>> /Erik >> >> The revised change looks for BUILD_INSTALL instead, which I believe handles both points. The webrev is here: >> >> http://cr.openjdk.java.net/~tbell/8012366/webrev.02/ >> >> Tim >> >> >> >> On 07/11/13 01:19 AM, Erik Joelsson wrote: >>> On 2013-07-11 07:30, David Holmes wrote: >>>> Tim, >>>> >>>> On 11/07/2013 6:47 AM, Tim Bell wrote: >>>>> On 07/10/13 12:37 PM, Tim Bell wrote: >>>>>> Hi Kelly >>>>>> >>>>>>> How did BUILD_INSTALL ever become true on an OpenJDK build? >>>>>> >>>>>> From the 'generic_debug_build' rule in the top level 7update Makefile [1] >>>>>> >>>>>> generic_debug_build: >>>>>> $(MAKE) \ >>>>>> ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_OUTPUTDIR) \ >>>>>> DEBUG_NAME=$(DEBUG_NAME) \ >>>>>> GENERATE_DOCS=false \ >>>>>> BUILD_INSTALL_BUNDLES=true \ >>>>>> CREATE_DEBUGINFO_BUNDLES=false \ >>>>>> $(BOOT_CYCLE_DEBUG_SETTINGS) \ >>>>>> generic_build_repo_series >>>>> >>>>> >>>>> After giving this more study, let me modify what I wrote a bit - >>>>> generic_debug_build sets "BUILD_INSTALL_BUNDLES=true", which causes the >>>>> 'install-binaries-jdk-debug' rule in the same Makefile to also run. This >>>>> dives into install-rules.gmk [2] in a place where BUILD_INSTALL is not >>>>> checked. >>>>> >>>>> Here is a revised fix and webrev: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.01/ >>>> >>>> Does this also need to check for OPENJDK in case you are doing an OPENJDK build with a full forest present? Or is this logic already by-passed for OPENJDK builds? >>>> >>> Setting OPENJDK=true on the command line will force BUILD_INSTALL=false, even if the source is available, and INSTALL_SRC_AVAILABLE will still be true. As a user, if I requested an OPENJDK build with the full forest available, I would not expect the build to head down into the install repo, even for debug bundles. For this reason I think the check should be against BUILD_INSTALL instead of INSTALL_SRC_AVAILABLE. >>> >>> /Erik >>> >>>> David >>>> >>>>> Tim >>>>> >>>>>> [1] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/Makefile >>>>> >>>>> [2] http://hg.openjdk.java.net/jdk7u/jdk7u/file/tip/make/install-rules.gmk >>>>> >>>>> >>>>> >>>>>> >>>>>>> -kto >>>>>>> >>>>>>> On Jul 8, 2013, at 12:03 PM, Tim Bell wrote: >>>>>>> >>>>>>>> All- >>>>>>>> >>>>>>>> My fix for 8007815 [1] did not handle the case of an OpenJDK build >>>>>>>> that does not have the closed source trees. If a user tries to >>>>>>>> build that far, the build will fail with "cd: can't cd to >>>>>>>> ./install/make/installer/binaries/linux" >>>>>>>> >>>>>>>> This is a request for review and approval to fix 8012366 in 7u. >>>>>>>> These changes will not throw a build error if the closed directories >>>>>>>> do not exist. Makefile changes only; no product code has been >>>>>>>> modified: >>>>>>>> >>>>>>>> Link to the bug report: >>>>>>>> >>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8012366 >>>>>>>> >>>>>>>> webrev of the Makefile changes: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~tbell/8012366/webrev.00/ >>>>>>>> >>>>>>>> Thanks in advance- >>>>>>>> >>>>>>>> Tim >>>>>>>> [1] There is no external link for 8007815, sorry. These changes >>>>>>>> had to do with building and packaging in the install tree. >>>>>>>> >>>>>> >>>>> >> -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From tim.bell at oracle.com Fri Jul 12 17:39:52 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 12 Jul 2013 10:39:52 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51E01FFC.7070104@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> <51DE6AA6.1000706@oracle.com> <51DF9285.4050003@oracle.com> <51DFA8DF.1020801@oracle.com> <51E01FFC.7070104@oracle.com> Message-ID: <51E03F68.6080902@oracle.com> Dalibor: > Looks good to me, too. Local OpenJDK build on OS X and an OpenJDK linux build on JPRT both passed. Thanks very much for the review and the extra testing. As an added data point to help justify this fix, we just got email from our third internal user who ran into this bug last night. > Please send in a fresh phase 2 approval request to the jdk7u-dev list. Will do. Tim From tim.bell at oracle.com Fri Jul 12 17:50:48 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 12 Jul 2013 10:50:48 -0700 Subject: Request for review and approval to fix 8012366 in 7update In-Reply-To: <51DFAA1C.90402@oracle.com> References: <51DB0D08.4000608@oracle.com> <51DDB816.5030408@oracle.com> <51DDC856.3040605@oracle.com> <51DE4310.90109@oracle.com> <51DE6AA6.1000706@oracle.com> <51DF9285.4050003@oracle.com> <51DFA8DF.1020801@oracle.com> <51DFAA1C.90402@oracle.com> Message-ID: <51E041F8.7090707@oracle.com> On 07/12/13 12:02 AM, David Holmes wrote: > I am :) > > Tim I think this is okay. Certainly it only makes sense to build > install bundles if building install. Good. Thanks for the review. > I just wonder why building install bundles has to appear at this > top-level anyway. But that's a different issue. Perhaps we can do better for JDK8. The short version of the story is that Release Engineering requested this fix so they could run the product and debug builds in parallel rather than sequentially. The legacy bundle creating code in the closed install tree assumed that both product and debug builds had been done on the same system, and that all bits were available to create bundles at the end. We had to restructure that logic, and the change in OpenJDK Makefiles was an unfortunate side effect. Tim From jin.phd at gmail.com Sat Jul 13 03:53:46 2013 From: jin.phd at gmail.com (Jin Mingjian) Date: Sat, 13 Jul 2013 11:53:46 +0800 Subject: fail to build profiles in my system In-Reply-To: <51DFE38C.70403@oracle.com> References: <51DFE38C.70403@oracle.com> Message-ID: David, very thanks for your reply. "make images profiles" still yeilded the same "No rule to make target" error. I also suspect some tool(s) has meet some problem when extracting the classes. I will continue to care this problem in my spare:) I will let you know when it's gone or the reason found. thanks again! Jin On Fri, Jul 12, 2013 at 7:07 PM, David Holmes wrote: > Hi Jin, > > Try "make images profiles" as a workaround. > > I suspect there is a missing dependency. > > David > > > On 12/07/2013 6:14 PM, Jin Mingjian wrote: > >> Hi, build team, >> >> very thanks for the great new build system. I always succeed to build >> whole >> by "make all". But fail to build profiles by "make profiles". This >> command >> used to work in the initial weeks after the profile works into the hg >> repo. >> >> I am using an arch based custom linux. So, I do not expect it is always >> perfectly well in my system. But it is very appreciated if some one could >> give some suggestions to digg this problem further! Does profiles building >> need some pre-reuqirenments? or could some broken binary(like zip) in my >> system cause this error? very thanks. >> >> best regards, >> Jin Mingjian >> >> >> =============== >> the terminal out is like this: >> >> make profiles >>> >> Building OpenJDK for target 'profiles' in configuration >> 'linux-x86_64-normal-server-**release' >> >> ## Starting langtools >> ## Finished langtools (build time 00:00:00) >> >> ## Starting hotspot >> ## Finished hotspot (build time 00:00:00) >> >> ## Starting corba >> ## Finished corba (build time 00:00:00) >> >> ## Starting jaxp >> ## Finished jaxp (build time 00:00:00) >> >> ## Starting jaxws >> ## Finished jaxws (build time 00:00:00) >> >> ## Starting jdk >> ## Finished jdk (build time 00:00:01) >> >> ## Starting profiles >> make[2]: *** No rule to make target >> `/ming/build/openjdk-lambda/**lambda/build/linux-x86_64-** >> normal-server-release/images/**beanless/java/util/jar/** >> Pack200\$Packer.class', >> needed by >> `/ming/build/openjdk-lambda/**lambda/build/linux-x86_64-** >> normal-server-release/images/**libprofile_1/rt.jar'. >> Stop. >> make[2]: *** Waiting for unfinished jobs.... >> Removed method addPropertyChangeListener(**java.beans.** >> PropertyChangeListener) >> from java/util/logging/LogManager >> Removed method >> removePropertyChangeListener(**java.beans.**PropertyChangeListener) from >> java/util/logging/LogManager >> make[1]: *** [profile_1] Error 2 >> make: *** [profiles-only] Error 2 >> >> From tim.bell at oracle.com Sat Jul 13 11:51:11 2013 From: tim.bell at oracle.com (Tim Bell) Date: Sat, 13 Jul 2013 04:51:11 -0700 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51AC9CFC.70503@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> Message-ID: <51E13F2F.7070104@oracle.com> Hello everyone- Many thanks for the early feedback on this JDK8 hotspot + VS2012 project. A revised webrev is here: http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ These changes build and pass all of the standard 119 tests (as listed in the jprt.properties file - see below) when using VS2012 and also using VS2010. Thanks in advance for any feedback- Tim *** Build targets: windows_i586_5.1-product with attributes compiler=VS2010 (or i586_6.1 VS2012) windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or i586_6.1 VS2012) windows_x64_5.2-product with attributes compiler=VS2010 (or i586_6.1 VS2012) windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or i586_6.1 VS2012) *** Test targets: windows_i586-product-c1-jvm98 windows_i586-product-c2-jvm98 windows_i586-fastdebug-c1-jvm98 windows_i586-fastdebug-c2-jvm98 windows_i586-product-c2-jvm98_nontiered windows_i586-fastdebug-c2-jvm98_nontiered windows_i586-product-c1-scimark windows_i586-product-c2-scimark windows_i586-fastdebug-c1-scimark windows_i586-fastdebug-c2-scimark windows_i586-product-c1-runThese windows_i586-product-c2-runThese windows_i586-product-c1-runThese_Xcomp windows_i586-product-c2-runThese_Xcomp windows_i586-fastdebug-c1-runThese_Xshare windows_i586-product-c1-GCBasher_SerialGC windows_i586-product-c2-GCBasher_SerialGC windows_i586-fastdebug-c1-GCBasher_SerialGC windows_i586-fastdebug-c2-GCBasher_SerialGC windows_i586-product-c1-GCBasher_ParallelGC windows_i586-product-c2-GCBasher_ParallelGC windows_i586-fastdebug-c1-GCBasher_ParallelGC windows_i586-fastdebug-c2-GCBasher_ParallelGC windows_i586-product-c1-GCBasher_ParNewGC windows_i586-product-c2-GCBasher_ParNewGC windows_i586-fastdebug-c1-GCBasher_ParNewGC windows_i586-fastdebug-c2-GCBasher_ParNewGC windows_i586-product-c1-GCBasher_CMS windows_i586-product-c2-GCBasher_CMS windows_i586-fastdebug-c1-GCBasher_CMS windows_i586-fastdebug-c2-GCBasher_CMS windows_i586-product-c1-GCBasher_G1 windows_i586-product-c2-GCBasher_G1 windows_i586-fastdebug-c1-GCBasher_G1 windows_i586-fastdebug-c2-GCBasher_G1 windows_i586-product-c1-GCBasher_ParOldGC windows_i586-product-c2-GCBasher_ParOldGC windows_i586-fastdebug-c1-GCBasher_ParOldGC windows_i586-fastdebug-c2-GCBasher_ParOldGC windows_i586-product-c1-GCOld_SerialGC windows_i586-product-c2-GCOld_SerialGC windows_i586-product-c1-GCOld_ParallelGC windows_i586-product-c2-GCOld_ParallelGC windows_i586-product-c1-GCOld_ParNewGC windows_i586-product-c2-GCOld_ParNewGC windows_i586-product-c1-GCOld_CMS windows_i586-product-c2-GCOld_CMS windows_i586-product-c1-GCOld_G1 windows_i586-product-c2-GCOld_G1 windows_i586-product-c1-GCOld_ParOldGC windows_i586-product-c2-GCOld_ParOldGC windows_i586-product-c1-jbb_default windows_i586-product-c2-jbb_default windows_i586-fastdebug-c1-jbb_default windows_i586-fastdebug-c2-jbb_default windows_i586-product-c2-jbb_default_nontiered windows_i586-fastdebug-c2-jbb_default_nontiered windows_i586-product-c1-jbb_ParallelGC windows_i586-product-c2-jbb_ParallelGC windows_i586-product-c1-jbb_CMS windows_i586-product-c2-jbb_CMS windows_i586-product-c1-jbb_G1 windows_i586-product-c2-jbb_G1 windows_i586-product-c1-jbb_ParOldGC windows_i586-product-c2-jbb_ParOldGC windows_x64-product-c2-jvm98 windows_x64-fastdebug-c2-jvm98 windows_x64-product-c2-jvm98_nontiered windows_x64-fastdebug-c2-jvm98_nontiered windows_x64-product-c2-scimark windows_x64-fastdebug-c2-scimark windows_x64-product-c2-runThese windows_x64-product-c2-runThese_Xcomp windows_x64-product-c2-GCBasher_SerialGC windows_x64-fastdebug-c2-GCBasher_SerialGC windows_x64-product-c2-GCBasher_ParallelGC windows_x64-fastdebug-c2-GCBasher_ParallelGC windows_x64-product-c2-GCBasher_ParNewGC windows_x64-fastdebug-c2-GCBasher_ParNewGC windows_x64-product-c2-GCBasher_CMS windows_x64-fastdebug-c2-GCBasher_CMS windows_x64-product-c2-GCBasher_G1 windows_x64-fastdebug-c2-GCBasher_G1 windows_x64-product-c2-GCBasher_ParOldGC windows_x64-fastdebug-c2-GCBasher_ParOldGC windows_x64-product-c2-GCOld_SerialGC windows_x64-fastdebug-c2-GCOld_SerialGC windows_x64-product-c2-GCOld_ParallelGC windows_x64-fastdebug-c2-GCOld_ParallelGC windows_x64-product-c2-GCOld_ParNewGC windows_x64-fastdebug-c2-GCOld_ParNewGC windows_x64-product-c2-GCOld_CMS windows_x64-fastdebug-c2-GCOld_CMS windows_x64-product-c2-GCOld_G1 windows_x64-fastdebug-c2-GCOld_G1 windows_x64-product-c2-GCOld_ParOldGC windows_x64-fastdebug-c2-GCOld_ParOldGC windows_x64-product-c2-jbb_default windows_x64-fastdebug-c2-jbb_default windows_x64-product-c2-jbb_default_nontiered windows_x64-fastdebug-c2-jbb_default_nontiered windows_x64-product-c2-jbb_CMS windows_x64-product-c2-jbb_ParallelGC windows_x64-product-c2-jbb_G1 windows_x64-product-c2-jbb_ParOldGC windows_i586-fastdebug-c1-clienttest windows_i586-product-c1-clienttest windows_i586-fastdebug-c2-servertest windows_i586-product-c2-servertest windows_x64-fastdebug-c2-servertest windows_x64-product-c2-servertest windows_i586-fastdebug-c2-internalvmtests windows_x64-fastdebug-c2-internalvmtests windows_i586-product-c2-wbapitest windows_i586-fastdebug-c2-wbapitest windows_x64-product-c2-wbapitest windows_x64-fastdebug-c2-wbapitest windows_i586-product-c1-wbapitest windows_i586-fastdebug-c1-wbapitest On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: > On 6/1/13 11:02 AM, Tim Bell wrote: >> 8015759: hotspot changes needed to compile with Visual Studio 2012 >> >> The bug report will be visible in a few days here: >> http://bugs.sun.com/view_bug.do?bug_id=8015759 >> >> Minor Makefile changes and one source file was touched to compile >> with Visual Studio 2012. These changes also compile under >> Visual Studio 2010 with no problem so we can upgrade gracefully. >> Tested by building the forest with both compilers. >> >> % hg status >> M make/windows/makefiles/compile.make > > same question about the STATIC_CPPLIB stuff as David H. > > >> M make/windows/makefiles/sanity.make > > No comments. > > >> M make/windows/makefiles/vm.make > > Same question about the new 'ifdef DEVELOP' change as David H. > > Sanity check: The patch shows this change: > > # Special case files not using precompiled header files. > > -c1_RInfo_$(Platform_arch).obj: > $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp > +c1_RInfo_$(Platform_arch).obj: > $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp > $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c > $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp > > But I don't see a change. And this diff doesn't show up in the > other views. Oh wait, there's a blank at the end of the '+' > line... > >> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp > > No comments. > > Dan > > >> >> webrev and patch file are here: >> >> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >> >> >> Thanks to Anthony Petrov who provided the initial set of patches for >> this work. >> >> I believe this should go in via the hotspot-rt forest (let me know if >> that is not correct), in which case I will need a sponsor from that >> team to push the change. >> >> Thanks in advance- >> Tim >> >> > From david.holmes at oracle.com Mon Jul 15 04:00:50 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 15 Jul 2013 14:00:50 +1000 Subject: fail to build profiles in my system In-Reply-To: References: <51DFE38C.70403@oracle.com> Message-ID: <51E373F2.1000203@oracle.com> On 13/07/2013 1:53 PM, Jin Mingjian wrote: > David, very thanks for your reply. "make images profiles" still yeilded the > same "No rule to make target" error. I also suspect some tool(s) has meet > some problem when extracting the classes. I will continue to care this > problem in my spare:) I will let you know when it's gone or the reason > found. Yeah I couldn't reproduce this on a clean build so there's something else amiss here. David > thanks again! > Jin > > > On Fri, Jul 12, 2013 at 7:07 PM, David Holmes wrote: > >> Hi Jin, >> >> Try "make images profiles" as a workaround. >> >> I suspect there is a missing dependency. >> >> David >> >> >> On 12/07/2013 6:14 PM, Jin Mingjian wrote: >> >>> Hi, build team, >>> >>> very thanks for the great new build system. I always succeed to build >>> whole >>> by "make all". But fail to build profiles by "make profiles". This >>> command >>> used to work in the initial weeks after the profile works into the hg >>> repo. >>> >>> I am using an arch based custom linux. So, I do not expect it is always >>> perfectly well in my system. But it is very appreciated if some one could >>> give some suggestions to digg this problem further! Does profiles building >>> need some pre-reuqirenments? or could some broken binary(like zip) in my >>> system cause this error? very thanks. >>> >>> best regards, >>> Jin Mingjian >>> >>> >>> =============== >>> the terminal out is like this: >>> >>> make profiles >>>> >>> Building OpenJDK for target 'profiles' in configuration >>> 'linux-x86_64-normal-server-**release' >>> >>> ## Starting langtools >>> ## Finished langtools (build time 00:00:00) >>> >>> ## Starting hotspot >>> ## Finished hotspot (build time 00:00:00) >>> >>> ## Starting corba >>> ## Finished corba (build time 00:00:00) >>> >>> ## Starting jaxp >>> ## Finished jaxp (build time 00:00:00) >>> >>> ## Starting jaxws >>> ## Finished jaxws (build time 00:00:00) >>> >>> ## Starting jdk >>> ## Finished jdk (build time 00:00:01) >>> >>> ## Starting profiles >>> make[2]: *** No rule to make target >>> `/ming/build/openjdk-lambda/**lambda/build/linux-x86_64-** >>> normal-server-release/images/**beanless/java/util/jar/** >>> Pack200\$Packer.class', >>> needed by >>> `/ming/build/openjdk-lambda/**lambda/build/linux-x86_64-** >>> normal-server-release/images/**libprofile_1/rt.jar'. >>> Stop. >>> make[2]: *** Waiting for unfinished jobs.... >>> Removed method addPropertyChangeListener(**java.beans.** >>> PropertyChangeListener) >>> from java/util/logging/LogManager >>> Removed method >>> removePropertyChangeListener(**java.beans.**PropertyChangeListener) from >>> java/util/logging/LogManager >>> make[1]: *** [profile_1] Error 2 >>> make: *** [profiles-only] Error 2 >>> >>> From david.holmes at oracle.com Mon Jul 15 04:20:12 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 15 Jul 2013 14:20:12 +1000 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E13F2F.7070104@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> Message-ID: <51E3787C.4040802@oracle.com> Hi Tim, This looks okay to me. Only concern is that we may want to separate out the make/jprt.properties change, otherwise we can't push this until the switch to the new compilers has been officially approved. It may be easier to put the vs2012 support in place first and make the switch itself later. David On 13/07/2013 9:51 PM, Tim Bell wrote: > Hello everyone- > > Many thanks for the early feedback on this JDK8 hotspot + VS2012 project. > > A revised webrev is here: > > http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ > > These changes build and pass all of the standard 119 tests (as listed in > the jprt.properties file - see below) when using VS2012 and also using > VS2010. > > Thanks in advance for any feedback- > > Tim > > *** Build targets: > windows_i586_5.1-product with attributes compiler=VS2010 (or i586_6.1 > VS2012) > windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or > i586_6.1 VS2012) > windows_x64_5.2-product with attributes compiler=VS2010 (or i586_6.1 > VS2012) > windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or > i586_6.1 VS2012) > > *** Test targets: > windows_i586-product-c1-jvm98 > windows_i586-product-c2-jvm98 > windows_i586-fastdebug-c1-jvm98 > windows_i586-fastdebug-c2-jvm98 > windows_i586-product-c2-jvm98_nontiered > windows_i586-fastdebug-c2-jvm98_nontiered > windows_i586-product-c1-scimark > windows_i586-product-c2-scimark > windows_i586-fastdebug-c1-scimark > windows_i586-fastdebug-c2-scimark > windows_i586-product-c1-runThese > windows_i586-product-c2-runThese > windows_i586-product-c1-runThese_Xcomp > windows_i586-product-c2-runThese_Xcomp > windows_i586-fastdebug-c1-runThese_Xshare > windows_i586-product-c1-GCBasher_SerialGC > windows_i586-product-c2-GCBasher_SerialGC > windows_i586-fastdebug-c1-GCBasher_SerialGC > windows_i586-fastdebug-c2-GCBasher_SerialGC > windows_i586-product-c1-GCBasher_ParallelGC > windows_i586-product-c2-GCBasher_ParallelGC > windows_i586-fastdebug-c1-GCBasher_ParallelGC > windows_i586-fastdebug-c2-GCBasher_ParallelGC > windows_i586-product-c1-GCBasher_ParNewGC > windows_i586-product-c2-GCBasher_ParNewGC > windows_i586-fastdebug-c1-GCBasher_ParNewGC > windows_i586-fastdebug-c2-GCBasher_ParNewGC > windows_i586-product-c1-GCBasher_CMS > windows_i586-product-c2-GCBasher_CMS > windows_i586-fastdebug-c1-GCBasher_CMS > windows_i586-fastdebug-c2-GCBasher_CMS > windows_i586-product-c1-GCBasher_G1 > windows_i586-product-c2-GCBasher_G1 > windows_i586-fastdebug-c1-GCBasher_G1 > windows_i586-fastdebug-c2-GCBasher_G1 > windows_i586-product-c1-GCBasher_ParOldGC > windows_i586-product-c2-GCBasher_ParOldGC > windows_i586-fastdebug-c1-GCBasher_ParOldGC > windows_i586-fastdebug-c2-GCBasher_ParOldGC > windows_i586-product-c1-GCOld_SerialGC > windows_i586-product-c2-GCOld_SerialGC > windows_i586-product-c1-GCOld_ParallelGC > windows_i586-product-c2-GCOld_ParallelGC > windows_i586-product-c1-GCOld_ParNewGC > windows_i586-product-c2-GCOld_ParNewGC > windows_i586-product-c1-GCOld_CMS > windows_i586-product-c2-GCOld_CMS > windows_i586-product-c1-GCOld_G1 > windows_i586-product-c2-GCOld_G1 > windows_i586-product-c1-GCOld_ParOldGC > windows_i586-product-c2-GCOld_ParOldGC > windows_i586-product-c1-jbb_default > windows_i586-product-c2-jbb_default > windows_i586-fastdebug-c1-jbb_default > windows_i586-fastdebug-c2-jbb_default > windows_i586-product-c2-jbb_default_nontiered > windows_i586-fastdebug-c2-jbb_default_nontiered > windows_i586-product-c1-jbb_ParallelGC > windows_i586-product-c2-jbb_ParallelGC > windows_i586-product-c1-jbb_CMS > windows_i586-product-c2-jbb_CMS > windows_i586-product-c1-jbb_G1 > windows_i586-product-c2-jbb_G1 > windows_i586-product-c1-jbb_ParOldGC > windows_i586-product-c2-jbb_ParOldGC > windows_x64-product-c2-jvm98 > windows_x64-fastdebug-c2-jvm98 > windows_x64-product-c2-jvm98_nontiered > windows_x64-fastdebug-c2-jvm98_nontiered > windows_x64-product-c2-scimark > windows_x64-fastdebug-c2-scimark > windows_x64-product-c2-runThese > windows_x64-product-c2-runThese_Xcomp > windows_x64-product-c2-GCBasher_SerialGC > windows_x64-fastdebug-c2-GCBasher_SerialGC > windows_x64-product-c2-GCBasher_ParallelGC > windows_x64-fastdebug-c2-GCBasher_ParallelGC > windows_x64-product-c2-GCBasher_ParNewGC > windows_x64-fastdebug-c2-GCBasher_ParNewGC > windows_x64-product-c2-GCBasher_CMS > windows_x64-fastdebug-c2-GCBasher_CMS > windows_x64-product-c2-GCBasher_G1 > windows_x64-fastdebug-c2-GCBasher_G1 > windows_x64-product-c2-GCBasher_ParOldGC > windows_x64-fastdebug-c2-GCBasher_ParOldGC > windows_x64-product-c2-GCOld_SerialGC > windows_x64-fastdebug-c2-GCOld_SerialGC > windows_x64-product-c2-GCOld_ParallelGC > windows_x64-fastdebug-c2-GCOld_ParallelGC > windows_x64-product-c2-GCOld_ParNewGC > windows_x64-fastdebug-c2-GCOld_ParNewGC > windows_x64-product-c2-GCOld_CMS > windows_x64-fastdebug-c2-GCOld_CMS > windows_x64-product-c2-GCOld_G1 > windows_x64-fastdebug-c2-GCOld_G1 > windows_x64-product-c2-GCOld_ParOldGC > windows_x64-fastdebug-c2-GCOld_ParOldGC > windows_x64-product-c2-jbb_default > windows_x64-fastdebug-c2-jbb_default > windows_x64-product-c2-jbb_default_nontiered > windows_x64-fastdebug-c2-jbb_default_nontiered > windows_x64-product-c2-jbb_CMS > windows_x64-product-c2-jbb_ParallelGC > windows_x64-product-c2-jbb_G1 > windows_x64-product-c2-jbb_ParOldGC > windows_i586-fastdebug-c1-clienttest > windows_i586-product-c1-clienttest > windows_i586-fastdebug-c2-servertest > windows_i586-product-c2-servertest > windows_x64-fastdebug-c2-servertest > windows_x64-product-c2-servertest > windows_i586-fastdebug-c2-internalvmtests > windows_x64-fastdebug-c2-internalvmtests > windows_i586-product-c2-wbapitest > windows_i586-fastdebug-c2-wbapitest > windows_x64-product-c2-wbapitest > windows_x64-fastdebug-c2-wbapitest > windows_i586-product-c1-wbapitest > windows_i586-fastdebug-c1-wbapitest > > > On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >> On 6/1/13 11:02 AM, Tim Bell wrote: >>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>> >>> The bug report will be visible in a few days here: >>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>> >>> Minor Makefile changes and one source file was touched to compile >>> with Visual Studio 2012. These changes also compile under >>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>> Tested by building the forest with both compilers. >>> >>> % hg status >>> M make/windows/makefiles/compile.make >> >> same question about the STATIC_CPPLIB stuff as David H. >> >> >>> M make/windows/makefiles/sanity.make >> >> No comments. >> >> >>> M make/windows/makefiles/vm.make >> >> Same question about the new 'ifdef DEVELOP' change as David H. >> >> Sanity check: The patch shows this change: >> >> # Special case files not using precompiled header files. >> >> -c1_RInfo_$(Platform_arch).obj: >> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >> +c1_RInfo_$(Platform_arch).obj: >> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >> >> But I don't see a change. And this diff doesn't show up in the >> other views. Oh wait, there's a blank at the end of the '+' >> line... >> >>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >> >> No comments. >> >> Dan >> >> >>> >>> webrev and patch file are here: >>> >>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>> >>> >>> Thanks to Anthony Petrov who provided the initial set of patches for >>> this work. >>> >>> I believe this should go in via the hotspot-rt forest (let me know if >>> that is not correct), in which case I will need a sponsor from that >>> team to push the change. >>> >>> Thanks in advance- >>> Tim >>> >>> >> > From anthony.petrov at oracle.com Mon Jul 15 12:12:02 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 15 Jul 2013 16:12:02 +0400 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E13F2F.7070104@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> Message-ID: <51E3E712.5090707@oracle.com> Hi Tim, The fix looks good to me. -- best regards, Anthony On 07/13/13 15:51, Tim Bell wrote: > Hello everyone- > > Many thanks for the early feedback on this JDK8 hotspot + VS2012 project. > > A revised webrev is here: > > http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ > > These changes build and pass all of the standard 119 tests (as listed in > the jprt.properties file - see below) when using VS2012 and also using > VS2010. > > Thanks in advance for any feedback- > > Tim > > *** Build targets: > windows_i586_5.1-product with attributes compiler=VS2010 (or i586_6.1 > VS2012) > windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or i586_6.1 > VS2012) > windows_x64_5.2-product with attributes compiler=VS2010 (or i586_6.1 > VS2012) > windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or i586_6.1 > VS2012) > > *** Test targets: > windows_i586-product-c1-jvm98 > windows_i586-product-c2-jvm98 > windows_i586-fastdebug-c1-jvm98 > windows_i586-fastdebug-c2-jvm98 > windows_i586-product-c2-jvm98_nontiered > windows_i586-fastdebug-c2-jvm98_nontiered > windows_i586-product-c1-scimark > windows_i586-product-c2-scimark > windows_i586-fastdebug-c1-scimark > windows_i586-fastdebug-c2-scimark > windows_i586-product-c1-runThese > windows_i586-product-c2-runThese > windows_i586-product-c1-runThese_Xcomp > windows_i586-product-c2-runThese_Xcomp > windows_i586-fastdebug-c1-runThese_Xshare > windows_i586-product-c1-GCBasher_SerialGC > windows_i586-product-c2-GCBasher_SerialGC > windows_i586-fastdebug-c1-GCBasher_SerialGC > windows_i586-fastdebug-c2-GCBasher_SerialGC > windows_i586-product-c1-GCBasher_ParallelGC > windows_i586-product-c2-GCBasher_ParallelGC > windows_i586-fastdebug-c1-GCBasher_ParallelGC > windows_i586-fastdebug-c2-GCBasher_ParallelGC > windows_i586-product-c1-GCBasher_ParNewGC > windows_i586-product-c2-GCBasher_ParNewGC > windows_i586-fastdebug-c1-GCBasher_ParNewGC > windows_i586-fastdebug-c2-GCBasher_ParNewGC > windows_i586-product-c1-GCBasher_CMS > windows_i586-product-c2-GCBasher_CMS > windows_i586-fastdebug-c1-GCBasher_CMS > windows_i586-fastdebug-c2-GCBasher_CMS > windows_i586-product-c1-GCBasher_G1 > windows_i586-product-c2-GCBasher_G1 > windows_i586-fastdebug-c1-GCBasher_G1 > windows_i586-fastdebug-c2-GCBasher_G1 > windows_i586-product-c1-GCBasher_ParOldGC > windows_i586-product-c2-GCBasher_ParOldGC > windows_i586-fastdebug-c1-GCBasher_ParOldGC > windows_i586-fastdebug-c2-GCBasher_ParOldGC > windows_i586-product-c1-GCOld_SerialGC > windows_i586-product-c2-GCOld_SerialGC > windows_i586-product-c1-GCOld_ParallelGC > windows_i586-product-c2-GCOld_ParallelGC > windows_i586-product-c1-GCOld_ParNewGC > windows_i586-product-c2-GCOld_ParNewGC > windows_i586-product-c1-GCOld_CMS > windows_i586-product-c2-GCOld_CMS > windows_i586-product-c1-GCOld_G1 > windows_i586-product-c2-GCOld_G1 > windows_i586-product-c1-GCOld_ParOldGC > windows_i586-product-c2-GCOld_ParOldGC > windows_i586-product-c1-jbb_default > windows_i586-product-c2-jbb_default > windows_i586-fastdebug-c1-jbb_default > windows_i586-fastdebug-c2-jbb_default > windows_i586-product-c2-jbb_default_nontiered > windows_i586-fastdebug-c2-jbb_default_nontiered > windows_i586-product-c1-jbb_ParallelGC > windows_i586-product-c2-jbb_ParallelGC > windows_i586-product-c1-jbb_CMS > windows_i586-product-c2-jbb_CMS > windows_i586-product-c1-jbb_G1 > windows_i586-product-c2-jbb_G1 > windows_i586-product-c1-jbb_ParOldGC > windows_i586-product-c2-jbb_ParOldGC > windows_x64-product-c2-jvm98 > windows_x64-fastdebug-c2-jvm98 > windows_x64-product-c2-jvm98_nontiered > windows_x64-fastdebug-c2-jvm98_nontiered > windows_x64-product-c2-scimark > windows_x64-fastdebug-c2-scimark > windows_x64-product-c2-runThese > windows_x64-product-c2-runThese_Xcomp > windows_x64-product-c2-GCBasher_SerialGC > windows_x64-fastdebug-c2-GCBasher_SerialGC > windows_x64-product-c2-GCBasher_ParallelGC > windows_x64-fastdebug-c2-GCBasher_ParallelGC > windows_x64-product-c2-GCBasher_ParNewGC > windows_x64-fastdebug-c2-GCBasher_ParNewGC > windows_x64-product-c2-GCBasher_CMS > windows_x64-fastdebug-c2-GCBasher_CMS > windows_x64-product-c2-GCBasher_G1 > windows_x64-fastdebug-c2-GCBasher_G1 > windows_x64-product-c2-GCBasher_ParOldGC > windows_x64-fastdebug-c2-GCBasher_ParOldGC > windows_x64-product-c2-GCOld_SerialGC > windows_x64-fastdebug-c2-GCOld_SerialGC > windows_x64-product-c2-GCOld_ParallelGC > windows_x64-fastdebug-c2-GCOld_ParallelGC > windows_x64-product-c2-GCOld_ParNewGC > windows_x64-fastdebug-c2-GCOld_ParNewGC > windows_x64-product-c2-GCOld_CMS > windows_x64-fastdebug-c2-GCOld_CMS > windows_x64-product-c2-GCOld_G1 > windows_x64-fastdebug-c2-GCOld_G1 > windows_x64-product-c2-GCOld_ParOldGC > windows_x64-fastdebug-c2-GCOld_ParOldGC > windows_x64-product-c2-jbb_default > windows_x64-fastdebug-c2-jbb_default > windows_x64-product-c2-jbb_default_nontiered > windows_x64-fastdebug-c2-jbb_default_nontiered > windows_x64-product-c2-jbb_CMS > windows_x64-product-c2-jbb_ParallelGC > windows_x64-product-c2-jbb_G1 > windows_x64-product-c2-jbb_ParOldGC > windows_i586-fastdebug-c1-clienttest > windows_i586-product-c1-clienttest > windows_i586-fastdebug-c2-servertest > windows_i586-product-c2-servertest > windows_x64-fastdebug-c2-servertest > windows_x64-product-c2-servertest > windows_i586-fastdebug-c2-internalvmtests > windows_x64-fastdebug-c2-internalvmtests > windows_i586-product-c2-wbapitest > windows_i586-fastdebug-c2-wbapitest > windows_x64-product-c2-wbapitest > windows_x64-fastdebug-c2-wbapitest > windows_i586-product-c1-wbapitest > windows_i586-fastdebug-c1-wbapitest > > > On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >> On 6/1/13 11:02 AM, Tim Bell wrote: >>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>> >>> The bug report will be visible in a few days here: >>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>> >>> Minor Makefile changes and one source file was touched to compile >>> with Visual Studio 2012. These changes also compile under >>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>> Tested by building the forest with both compilers. >>> >>> % hg status >>> M make/windows/makefiles/compile.make >> >> same question about the STATIC_CPPLIB stuff as David H. >> >> >>> M make/windows/makefiles/sanity.make >> >> No comments. >> >> >>> M make/windows/makefiles/vm.make >> >> Same question about the new 'ifdef DEVELOP' change as David H. >> >> Sanity check: The patch shows this change: >> >> # Special case files not using precompiled header files. >> >> -c1_RInfo_$(Platform_arch).obj: >> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >> +c1_RInfo_$(Platform_arch).obj: >> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >> >> But I don't see a change. And this diff doesn't show up in the >> other views. Oh wait, there's a blank at the end of the '+' >> line... >> >>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >> >> No comments. >> >> Dan >> >> >>> >>> webrev and patch file are here: >>> >>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>> >>> >>> Thanks to Anthony Petrov who provided the initial set of patches for >>> this work. >>> >>> I believe this should go in via the hotspot-rt forest (let me know if >>> that is not correct), in which case I will need a sponsor from that >>> team to push the change. >>> >>> Thanks in advance- >>> Tim >>> >>> >> > From tim.bell at oracle.com Mon Jul 15 12:29:04 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 15 Jul 2013 05:29:04 -0700 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E3787C.4040802@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> <51E3787C.4040802@oracle.com> Message-ID: <51E3EB10.1030508@oracle.com> David, Anthony : Thank you for the review. David wrote: > Only concern is that we may want to separate out the > make/jprt.properties change, otherwise we can't push this until the > switch to the new compilers has been officially approved. It may be > easier to put the vs2012 support in place first and make the switch > itself later. I completely agree - separate out the make/jprt.properties change. Could I get a sponsor to push the changes to the other four files to hotspot-runtime ASAP? Tim On 07/14/13 09:20 PM, David Holmes wrote: > Hi Tim, > > This looks okay to me. > > Only concern is that we may want to separate out the > make/jprt.properties change, otherwise we can't push this until the > switch to the new compilers has been officially approved. It may be > easier to put the vs2012 support in place first and make the switch > itself later. > > David > > On 13/07/2013 9:51 PM, Tim Bell wrote: >> Hello everyone- >> >> Many thanks for the early feedback on this JDK8 hotspot + VS2012 >> project. >> >> A revised webrev is here: >> >> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ >> >> These changes build and pass all of the standard 119 tests (as listed in >> the jprt.properties file - see below) when using VS2012 and also using >> VS2010. >> >> Thanks in advance for any feedback- >> >> Tim >> >> *** Build targets: >> windows_i586_5.1-product with attributes compiler=VS2010 (or i586_6.1 >> VS2012) >> windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or >> i586_6.1 VS2012) >> windows_x64_5.2-product with attributes compiler=VS2010 (or i586_6.1 >> VS2012) >> windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or >> i586_6.1 VS2012) >> >> *** Test targets: >> windows_i586-product-c1-jvm98 >> windows_i586-product-c2-jvm98 >> windows_i586-fastdebug-c1-jvm98 >> windows_i586-fastdebug-c2-jvm98 >> windows_i586-product-c2-jvm98_nontiered >> windows_i586-fastdebug-c2-jvm98_nontiered >> windows_i586-product-c1-scimark >> windows_i586-product-c2-scimark >> windows_i586-fastdebug-c1-scimark >> windows_i586-fastdebug-c2-scimark >> windows_i586-product-c1-runThese >> windows_i586-product-c2-runThese >> windows_i586-product-c1-runThese_Xcomp >> windows_i586-product-c2-runThese_Xcomp >> windows_i586-fastdebug-c1-runThese_Xshare >> windows_i586-product-c1-GCBasher_SerialGC >> windows_i586-product-c2-GCBasher_SerialGC >> windows_i586-fastdebug-c1-GCBasher_SerialGC >> windows_i586-fastdebug-c2-GCBasher_SerialGC >> windows_i586-product-c1-GCBasher_ParallelGC >> windows_i586-product-c2-GCBasher_ParallelGC >> windows_i586-fastdebug-c1-GCBasher_ParallelGC >> windows_i586-fastdebug-c2-GCBasher_ParallelGC >> windows_i586-product-c1-GCBasher_ParNewGC >> windows_i586-product-c2-GCBasher_ParNewGC >> windows_i586-fastdebug-c1-GCBasher_ParNewGC >> windows_i586-fastdebug-c2-GCBasher_ParNewGC >> windows_i586-product-c1-GCBasher_CMS >> windows_i586-product-c2-GCBasher_CMS >> windows_i586-fastdebug-c1-GCBasher_CMS >> windows_i586-fastdebug-c2-GCBasher_CMS >> windows_i586-product-c1-GCBasher_G1 >> windows_i586-product-c2-GCBasher_G1 >> windows_i586-fastdebug-c1-GCBasher_G1 >> windows_i586-fastdebug-c2-GCBasher_G1 >> windows_i586-product-c1-GCBasher_ParOldGC >> windows_i586-product-c2-GCBasher_ParOldGC >> windows_i586-fastdebug-c1-GCBasher_ParOldGC >> windows_i586-fastdebug-c2-GCBasher_ParOldGC >> windows_i586-product-c1-GCOld_SerialGC >> windows_i586-product-c2-GCOld_SerialGC >> windows_i586-product-c1-GCOld_ParallelGC >> windows_i586-product-c2-GCOld_ParallelGC >> windows_i586-product-c1-GCOld_ParNewGC >> windows_i586-product-c2-GCOld_ParNewGC >> windows_i586-product-c1-GCOld_CMS >> windows_i586-product-c2-GCOld_CMS >> windows_i586-product-c1-GCOld_G1 >> windows_i586-product-c2-GCOld_G1 >> windows_i586-product-c1-GCOld_ParOldGC >> windows_i586-product-c2-GCOld_ParOldGC >> windows_i586-product-c1-jbb_default >> windows_i586-product-c2-jbb_default >> windows_i586-fastdebug-c1-jbb_default >> windows_i586-fastdebug-c2-jbb_default >> windows_i586-product-c2-jbb_default_nontiered >> windows_i586-fastdebug-c2-jbb_default_nontiered >> windows_i586-product-c1-jbb_ParallelGC >> windows_i586-product-c2-jbb_ParallelGC >> windows_i586-product-c1-jbb_CMS >> windows_i586-product-c2-jbb_CMS >> windows_i586-product-c1-jbb_G1 >> windows_i586-product-c2-jbb_G1 >> windows_i586-product-c1-jbb_ParOldGC >> windows_i586-product-c2-jbb_ParOldGC >> windows_x64-product-c2-jvm98 >> windows_x64-fastdebug-c2-jvm98 >> windows_x64-product-c2-jvm98_nontiered >> windows_x64-fastdebug-c2-jvm98_nontiered >> windows_x64-product-c2-scimark >> windows_x64-fastdebug-c2-scimark >> windows_x64-product-c2-runThese >> windows_x64-product-c2-runThese_Xcomp >> windows_x64-product-c2-GCBasher_SerialGC >> windows_x64-fastdebug-c2-GCBasher_SerialGC >> windows_x64-product-c2-GCBasher_ParallelGC >> windows_x64-fastdebug-c2-GCBasher_ParallelGC >> windows_x64-product-c2-GCBasher_ParNewGC >> windows_x64-fastdebug-c2-GCBasher_ParNewGC >> windows_x64-product-c2-GCBasher_CMS >> windows_x64-fastdebug-c2-GCBasher_CMS >> windows_x64-product-c2-GCBasher_G1 >> windows_x64-fastdebug-c2-GCBasher_G1 >> windows_x64-product-c2-GCBasher_ParOldGC >> windows_x64-fastdebug-c2-GCBasher_ParOldGC >> windows_x64-product-c2-GCOld_SerialGC >> windows_x64-fastdebug-c2-GCOld_SerialGC >> windows_x64-product-c2-GCOld_ParallelGC >> windows_x64-fastdebug-c2-GCOld_ParallelGC >> windows_x64-product-c2-GCOld_ParNewGC >> windows_x64-fastdebug-c2-GCOld_ParNewGC >> windows_x64-product-c2-GCOld_CMS >> windows_x64-fastdebug-c2-GCOld_CMS >> windows_x64-product-c2-GCOld_G1 >> windows_x64-fastdebug-c2-GCOld_G1 >> windows_x64-product-c2-GCOld_ParOldGC >> windows_x64-fastdebug-c2-GCOld_ParOldGC >> windows_x64-product-c2-jbb_default >> windows_x64-fastdebug-c2-jbb_default >> windows_x64-product-c2-jbb_default_nontiered >> windows_x64-fastdebug-c2-jbb_default_nontiered >> windows_x64-product-c2-jbb_CMS >> windows_x64-product-c2-jbb_ParallelGC >> windows_x64-product-c2-jbb_G1 >> windows_x64-product-c2-jbb_ParOldGC >> windows_i586-fastdebug-c1-clienttest >> windows_i586-product-c1-clienttest >> windows_i586-fastdebug-c2-servertest >> windows_i586-product-c2-servertest >> windows_x64-fastdebug-c2-servertest >> windows_x64-product-c2-servertest >> windows_i586-fastdebug-c2-internalvmtests >> windows_x64-fastdebug-c2-internalvmtests >> windows_i586-product-c2-wbapitest >> windows_i586-fastdebug-c2-wbapitest >> windows_x64-product-c2-wbapitest >> windows_x64-fastdebug-c2-wbapitest >> windows_i586-product-c1-wbapitest >> windows_i586-fastdebug-c1-wbapitest >> >> >> On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >>> On 6/1/13 11:02 AM, Tim Bell wrote: >>>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>>> >>>> The bug report will be visible in a few days here: >>>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>>> >>>> Minor Makefile changes and one source file was touched to compile >>>> with Visual Studio 2012. These changes also compile under >>>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>>> Tested by building the forest with both compilers. >>>> >>>> % hg status >>>> M make/windows/makefiles/compile.make >>> >>> same question about the STATIC_CPPLIB stuff as David H. >>> >>> >>>> M make/windows/makefiles/sanity.make >>> >>> No comments. >>> >>> >>>> M make/windows/makefiles/vm.make >>> >>> Same question about the new 'ifdef DEVELOP' change as David H. >>> >>> Sanity check: The patch shows this change: >>> >>> # Special case files not using precompiled header files. >>> >>> -c1_RInfo_$(Platform_arch).obj: >>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>> +c1_RInfo_$(Platform_arch).obj: >>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>> >>> But I don't see a change. And this diff doesn't show up in the >>> other views. Oh wait, there's a blank at the end of the '+' >>> line... >>> >>>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >>> >>> No comments. >>> >>> Dan >>> >>> >>>> >>>> webrev and patch file are here: >>>> >>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>>> >>>> >>>> >>>> Thanks to Anthony Petrov who provided the initial set of patches for >>>> this work. >>>> >>>> I believe this should go in via the hotspot-rt forest (let me know if >>>> that is not correct), in which case I will need a sponsor from that >>>> team to push the change. >>>> >>>> Thanks in advance- >>>> Tim >>>> >>>> >>> >> From david.holmes at oracle.com Tue Jul 16 01:04:35 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 16 Jul 2013 11:04:35 +1000 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E3EB10.1030508@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> <51E3787C.4040802@oracle.com> <51E3EB10.1030508@oracle.com> Message-ID: <51E49C23.7010504@oracle.com> On 15/07/2013 10:29 PM, Tim Bell wrote: > David, Anthony : > > Thank you for the review. > > David wrote: > >> Only concern is that we may want to separate out the >> make/jprt.properties change, otherwise we can't push this until the >> switch to the new compilers has been officially approved. It may be >> easier to put the vs2012 support in place first and make the switch >> itself later. > > I completely agree - separate out the make/jprt.properties change. Could > I get a sponsor to push the changes to the other four files to > hotspot-runtime ASAP? I will sponsor it for you. I'll use the existing patch and revert the jprt change. Thanks, David > > Tim > > > On 07/14/13 09:20 PM, David Holmes wrote: >> Hi Tim, >> >> This looks okay to me. >> >> Only concern is that we may want to separate out the >> make/jprt.properties change, otherwise we can't push this until the >> switch to the new compilers has been officially approved. It may be >> easier to put the vs2012 support in place first and make the switch >> itself later. >> >> David >> >> On 13/07/2013 9:51 PM, Tim Bell wrote: >>> Hello everyone- >>> >>> Many thanks for the early feedback on this JDK8 hotspot + VS2012 >>> project. >>> >>> A revised webrev is here: >>> >>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ >>> >>> These changes build and pass all of the standard 119 tests (as listed in >>> the jprt.properties file - see below) when using VS2012 and also using >>> VS2010. >>> >>> Thanks in advance for any feedback- >>> >>> Tim >>> >>> *** Build targets: >>> windows_i586_5.1-product with attributes compiler=VS2010 (or i586_6.1 >>> VS2012) >>> windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or >>> i586_6.1 VS2012) >>> windows_x64_5.2-product with attributes compiler=VS2010 (or i586_6.1 >>> VS2012) >>> windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or >>> i586_6.1 VS2012) >>> >>> *** Test targets: >>> windows_i586-product-c1-jvm98 >>> windows_i586-product-c2-jvm98 >>> windows_i586-fastdebug-c1-jvm98 >>> windows_i586-fastdebug-c2-jvm98 >>> windows_i586-product-c2-jvm98_nontiered >>> windows_i586-fastdebug-c2-jvm98_nontiered >>> windows_i586-product-c1-scimark >>> windows_i586-product-c2-scimark >>> windows_i586-fastdebug-c1-scimark >>> windows_i586-fastdebug-c2-scimark >>> windows_i586-product-c1-runThese >>> windows_i586-product-c2-runThese >>> windows_i586-product-c1-runThese_Xcomp >>> windows_i586-product-c2-runThese_Xcomp >>> windows_i586-fastdebug-c1-runThese_Xshare >>> windows_i586-product-c1-GCBasher_SerialGC >>> windows_i586-product-c2-GCBasher_SerialGC >>> windows_i586-fastdebug-c1-GCBasher_SerialGC >>> windows_i586-fastdebug-c2-GCBasher_SerialGC >>> windows_i586-product-c1-GCBasher_ParallelGC >>> windows_i586-product-c2-GCBasher_ParallelGC >>> windows_i586-fastdebug-c1-GCBasher_ParallelGC >>> windows_i586-fastdebug-c2-GCBasher_ParallelGC >>> windows_i586-product-c1-GCBasher_ParNewGC >>> windows_i586-product-c2-GCBasher_ParNewGC >>> windows_i586-fastdebug-c1-GCBasher_ParNewGC >>> windows_i586-fastdebug-c2-GCBasher_ParNewGC >>> windows_i586-product-c1-GCBasher_CMS >>> windows_i586-product-c2-GCBasher_CMS >>> windows_i586-fastdebug-c1-GCBasher_CMS >>> windows_i586-fastdebug-c2-GCBasher_CMS >>> windows_i586-product-c1-GCBasher_G1 >>> windows_i586-product-c2-GCBasher_G1 >>> windows_i586-fastdebug-c1-GCBasher_G1 >>> windows_i586-fastdebug-c2-GCBasher_G1 >>> windows_i586-product-c1-GCBasher_ParOldGC >>> windows_i586-product-c2-GCBasher_ParOldGC >>> windows_i586-fastdebug-c1-GCBasher_ParOldGC >>> windows_i586-fastdebug-c2-GCBasher_ParOldGC >>> windows_i586-product-c1-GCOld_SerialGC >>> windows_i586-product-c2-GCOld_SerialGC >>> windows_i586-product-c1-GCOld_ParallelGC >>> windows_i586-product-c2-GCOld_ParallelGC >>> windows_i586-product-c1-GCOld_ParNewGC >>> windows_i586-product-c2-GCOld_ParNewGC >>> windows_i586-product-c1-GCOld_CMS >>> windows_i586-product-c2-GCOld_CMS >>> windows_i586-product-c1-GCOld_G1 >>> windows_i586-product-c2-GCOld_G1 >>> windows_i586-product-c1-GCOld_ParOldGC >>> windows_i586-product-c2-GCOld_ParOldGC >>> windows_i586-product-c1-jbb_default >>> windows_i586-product-c2-jbb_default >>> windows_i586-fastdebug-c1-jbb_default >>> windows_i586-fastdebug-c2-jbb_default >>> windows_i586-product-c2-jbb_default_nontiered >>> windows_i586-fastdebug-c2-jbb_default_nontiered >>> windows_i586-product-c1-jbb_ParallelGC >>> windows_i586-product-c2-jbb_ParallelGC >>> windows_i586-product-c1-jbb_CMS >>> windows_i586-product-c2-jbb_CMS >>> windows_i586-product-c1-jbb_G1 >>> windows_i586-product-c2-jbb_G1 >>> windows_i586-product-c1-jbb_ParOldGC >>> windows_i586-product-c2-jbb_ParOldGC >>> windows_x64-product-c2-jvm98 >>> windows_x64-fastdebug-c2-jvm98 >>> windows_x64-product-c2-jvm98_nontiered >>> windows_x64-fastdebug-c2-jvm98_nontiered >>> windows_x64-product-c2-scimark >>> windows_x64-fastdebug-c2-scimark >>> windows_x64-product-c2-runThese >>> windows_x64-product-c2-runThese_Xcomp >>> windows_x64-product-c2-GCBasher_SerialGC >>> windows_x64-fastdebug-c2-GCBasher_SerialGC >>> windows_x64-product-c2-GCBasher_ParallelGC >>> windows_x64-fastdebug-c2-GCBasher_ParallelGC >>> windows_x64-product-c2-GCBasher_ParNewGC >>> windows_x64-fastdebug-c2-GCBasher_ParNewGC >>> windows_x64-product-c2-GCBasher_CMS >>> windows_x64-fastdebug-c2-GCBasher_CMS >>> windows_x64-product-c2-GCBasher_G1 >>> windows_x64-fastdebug-c2-GCBasher_G1 >>> windows_x64-product-c2-GCBasher_ParOldGC >>> windows_x64-fastdebug-c2-GCBasher_ParOldGC >>> windows_x64-product-c2-GCOld_SerialGC >>> windows_x64-fastdebug-c2-GCOld_SerialGC >>> windows_x64-product-c2-GCOld_ParallelGC >>> windows_x64-fastdebug-c2-GCOld_ParallelGC >>> windows_x64-product-c2-GCOld_ParNewGC >>> windows_x64-fastdebug-c2-GCOld_ParNewGC >>> windows_x64-product-c2-GCOld_CMS >>> windows_x64-fastdebug-c2-GCOld_CMS >>> windows_x64-product-c2-GCOld_G1 >>> windows_x64-fastdebug-c2-GCOld_G1 >>> windows_x64-product-c2-GCOld_ParOldGC >>> windows_x64-fastdebug-c2-GCOld_ParOldGC >>> windows_x64-product-c2-jbb_default >>> windows_x64-fastdebug-c2-jbb_default >>> windows_x64-product-c2-jbb_default_nontiered >>> windows_x64-fastdebug-c2-jbb_default_nontiered >>> windows_x64-product-c2-jbb_CMS >>> windows_x64-product-c2-jbb_ParallelGC >>> windows_x64-product-c2-jbb_G1 >>> windows_x64-product-c2-jbb_ParOldGC >>> windows_i586-fastdebug-c1-clienttest >>> windows_i586-product-c1-clienttest >>> windows_i586-fastdebug-c2-servertest >>> windows_i586-product-c2-servertest >>> windows_x64-fastdebug-c2-servertest >>> windows_x64-product-c2-servertest >>> windows_i586-fastdebug-c2-internalvmtests >>> windows_x64-fastdebug-c2-internalvmtests >>> windows_i586-product-c2-wbapitest >>> windows_i586-fastdebug-c2-wbapitest >>> windows_x64-product-c2-wbapitest >>> windows_x64-fastdebug-c2-wbapitest >>> windows_i586-product-c1-wbapitest >>> windows_i586-fastdebug-c1-wbapitest >>> >>> >>> On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >>>> On 6/1/13 11:02 AM, Tim Bell wrote: >>>>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>>>> >>>>> The bug report will be visible in a few days here: >>>>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>>>> >>>>> Minor Makefile changes and one source file was touched to compile >>>>> with Visual Studio 2012. These changes also compile under >>>>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>>>> Tested by building the forest with both compilers. >>>>> >>>>> % hg status >>>>> M make/windows/makefiles/compile.make >>>> >>>> same question about the STATIC_CPPLIB stuff as David H. >>>> >>>> >>>>> M make/windows/makefiles/sanity.make >>>> >>>> No comments. >>>> >>>> >>>>> M make/windows/makefiles/vm.make >>>> >>>> Same question about the new 'ifdef DEVELOP' change as David H. >>>> >>>> Sanity check: The patch shows this change: >>>> >>>> # Special case files not using precompiled header files. >>>> >>>> -c1_RInfo_$(Platform_arch).obj: >>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>> +c1_RInfo_$(Platform_arch).obj: >>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>> >>>> But I don't see a change. And this diff doesn't show up in the >>>> other views. Oh wait, there's a blank at the end of the '+' >>>> line... >>>> >>>>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >>>> >>>> No comments. >>>> >>>> Dan >>>> >>>> >>>>> >>>>> webrev and patch file are here: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>>>> >>>>> >>>>> >>>>> Thanks to Anthony Petrov who provided the initial set of patches for >>>>> this work. >>>>> >>>>> I believe this should go in via the hotspot-rt forest (let me know if >>>>> that is not correct), in which case I will need a sponsor from that >>>>> team to push the change. >>>>> >>>>> Thanks in advance- >>>>> Tim >>>>> >>>>> >>>> >>> > From tim.bell at oracle.com Tue Jul 16 01:15:23 2013 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 15 Jul 2013 18:15:23 -0700 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E49C23.7010504@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> <51E3787C.4040802@oracle.com> <51E3EB10.1030508@oracle.com> <51E49C23.7010504@oracle.com> Message-ID: <51E49EAB.70201@oracle.com> On 07/15/13 06:04 PM, David Holmes wrote: > I will sponsor it for you. I'll use the existing patch and revert the > jprt change. > > Thanks, > David Thank you. I appreciate it. Tim From yumin.qi at oracle.com Tue Jul 16 01:52:43 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Mon, 15 Jul 2013 18:52:43 -0700 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E49C23.7010504@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> <51E3787C.4040802@oracle.com> <51E3EB10.1030508@oracle.com> <51E49C23.7010504@oracle.com> Message-ID: <51E4A76B.8050808@oracle.com> Hi, David The patch works fine when using build.bat to build hotspot on Windows, there is one issue with create.bat, which will fail to create project file for VS2012. I tried to work this around to create a VS2010 project, see URL: http://javaweb.us.oracle.com/~yqi/webrev/vs2012build/ The only two files: create.bat and rules.make changed for this purpose. The created project files, for i486, open with VS2012 OK, but amd-64 will hang, I have no time to check the detail why it hangs. This may be need addressed in a separate bug. I am OK with the current changes, it works fine for build. The failure is because we dont have set properly for the project setting, so it default to VC7, which is not right. Writing .vcproj file: D:\yqi\ws\8016538-build\build\vs-amd64\jvm.vcproj java.lang.NullPointerException at WinGammaPlatformVC7.writeConfiguration(WinGammaPlatformVC7.java:153) at WinGammaPlatformVC7.writeProjectFile(WinGammaPlatformVC7.java:62) at WinGammaPlatform.createVcproj(WinGammaPlatform.java:270) at ProjectCreator.main(ProjectCreator.java:93) NMAKE : fatal error U1077: 'd:\yqi\jdks\windows-i586\bin\java.EXE' : return code '0x1' Stop. Thanks Yumin On 7/15/2013 6:04 PM, David Holmes wrote: > On 15/07/2013 10:29 PM, Tim Bell wrote: >> David, Anthony : >> >> Thank you for the review. >> >> David wrote: >> >>> Only concern is that we may want to separate out the >>> make/jprt.properties change, otherwise we can't push this until the >>> switch to the new compilers has been officially approved. It may be >>> easier to put the vs2012 support in place first and make the switch >>> itself later. >> >> I completely agree - separate out the make/jprt.properties change. Could >> I get a sponsor to push the changes to the other four files to >> hotspot-runtime ASAP? > > I will sponsor it for you. I'll use the existing patch and revert the > jprt change. > > Thanks, > David > >> >> Tim >> >> >> On 07/14/13 09:20 PM, David Holmes wrote: >>> Hi Tim, >>> >>> This looks okay to me. >>> >>> Only concern is that we may want to separate out the >>> make/jprt.properties change, otherwise we can't push this until the >>> switch to the new compilers has been officially approved. It may be >>> easier to put the vs2012 support in place first and make the switch >>> itself later. >>> >>> David >>> >>> On 13/07/2013 9:51 PM, Tim Bell wrote: >>>> Hello everyone- >>>> >>>> Many thanks for the early feedback on this JDK8 hotspot + VS2012 >>>> project. >>>> >>>> A revised webrev is here: >>>> >>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ >>>> >>>> These changes build and pass all of the standard 119 tests (as >>>> listed in >>>> the jprt.properties file - see below) when using VS2012 and also using >>>> VS2010. >>>> >>>> Thanks in advance for any feedback- >>>> >>>> Tim >>>> >>>> *** Build targets: >>>> windows_i586_5.1-product with attributes compiler=VS2010 (or >>>> i586_6.1 >>>> VS2012) >>>> windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or >>>> i586_6.1 VS2012) >>>> windows_x64_5.2-product with attributes compiler=VS2010 (or >>>> i586_6.1 >>>> VS2012) >>>> windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or >>>> i586_6.1 VS2012) >>>> >>>> *** Test targets: >>>> windows_i586-product-c1-jvm98 >>>> windows_i586-product-c2-jvm98 >>>> windows_i586-fastdebug-c1-jvm98 >>>> windows_i586-fastdebug-c2-jvm98 >>>> windows_i586-product-c2-jvm98_nontiered >>>> windows_i586-fastdebug-c2-jvm98_nontiered >>>> windows_i586-product-c1-scimark >>>> windows_i586-product-c2-scimark >>>> windows_i586-fastdebug-c1-scimark >>>> windows_i586-fastdebug-c2-scimark >>>> windows_i586-product-c1-runThese >>>> windows_i586-product-c2-runThese >>>> windows_i586-product-c1-runThese_Xcomp >>>> windows_i586-product-c2-runThese_Xcomp >>>> windows_i586-fastdebug-c1-runThese_Xshare >>>> windows_i586-product-c1-GCBasher_SerialGC >>>> windows_i586-product-c2-GCBasher_SerialGC >>>> windows_i586-fastdebug-c1-GCBasher_SerialGC >>>> windows_i586-fastdebug-c2-GCBasher_SerialGC >>>> windows_i586-product-c1-GCBasher_ParallelGC >>>> windows_i586-product-c2-GCBasher_ParallelGC >>>> windows_i586-fastdebug-c1-GCBasher_ParallelGC >>>> windows_i586-fastdebug-c2-GCBasher_ParallelGC >>>> windows_i586-product-c1-GCBasher_ParNewGC >>>> windows_i586-product-c2-GCBasher_ParNewGC >>>> windows_i586-fastdebug-c1-GCBasher_ParNewGC >>>> windows_i586-fastdebug-c2-GCBasher_ParNewGC >>>> windows_i586-product-c1-GCBasher_CMS >>>> windows_i586-product-c2-GCBasher_CMS >>>> windows_i586-fastdebug-c1-GCBasher_CMS >>>> windows_i586-fastdebug-c2-GCBasher_CMS >>>> windows_i586-product-c1-GCBasher_G1 >>>> windows_i586-product-c2-GCBasher_G1 >>>> windows_i586-fastdebug-c1-GCBasher_G1 >>>> windows_i586-fastdebug-c2-GCBasher_G1 >>>> windows_i586-product-c1-GCBasher_ParOldGC >>>> windows_i586-product-c2-GCBasher_ParOldGC >>>> windows_i586-fastdebug-c1-GCBasher_ParOldGC >>>> windows_i586-fastdebug-c2-GCBasher_ParOldGC >>>> windows_i586-product-c1-GCOld_SerialGC >>>> windows_i586-product-c2-GCOld_SerialGC >>>> windows_i586-product-c1-GCOld_ParallelGC >>>> windows_i586-product-c2-GCOld_ParallelGC >>>> windows_i586-product-c1-GCOld_ParNewGC >>>> windows_i586-product-c2-GCOld_ParNewGC >>>> windows_i586-product-c1-GCOld_CMS >>>> windows_i586-product-c2-GCOld_CMS >>>> windows_i586-product-c1-GCOld_G1 >>>> windows_i586-product-c2-GCOld_G1 >>>> windows_i586-product-c1-GCOld_ParOldGC >>>> windows_i586-product-c2-GCOld_ParOldGC >>>> windows_i586-product-c1-jbb_default >>>> windows_i586-product-c2-jbb_default >>>> windows_i586-fastdebug-c1-jbb_default >>>> windows_i586-fastdebug-c2-jbb_default >>>> windows_i586-product-c2-jbb_default_nontiered >>>> windows_i586-fastdebug-c2-jbb_default_nontiered >>>> windows_i586-product-c1-jbb_ParallelGC >>>> windows_i586-product-c2-jbb_ParallelGC >>>> windows_i586-product-c1-jbb_CMS >>>> windows_i586-product-c2-jbb_CMS >>>> windows_i586-product-c1-jbb_G1 >>>> windows_i586-product-c2-jbb_G1 >>>> windows_i586-product-c1-jbb_ParOldGC >>>> windows_i586-product-c2-jbb_ParOldGC >>>> windows_x64-product-c2-jvm98 >>>> windows_x64-fastdebug-c2-jvm98 >>>> windows_x64-product-c2-jvm98_nontiered >>>> windows_x64-fastdebug-c2-jvm98_nontiered >>>> windows_x64-product-c2-scimark >>>> windows_x64-fastdebug-c2-scimark >>>> windows_x64-product-c2-runThese >>>> windows_x64-product-c2-runThese_Xcomp >>>> windows_x64-product-c2-GCBasher_SerialGC >>>> windows_x64-fastdebug-c2-GCBasher_SerialGC >>>> windows_x64-product-c2-GCBasher_ParallelGC >>>> windows_x64-fastdebug-c2-GCBasher_ParallelGC >>>> windows_x64-product-c2-GCBasher_ParNewGC >>>> windows_x64-fastdebug-c2-GCBasher_ParNewGC >>>> windows_x64-product-c2-GCBasher_CMS >>>> windows_x64-fastdebug-c2-GCBasher_CMS >>>> windows_x64-product-c2-GCBasher_G1 >>>> windows_x64-fastdebug-c2-GCBasher_G1 >>>> windows_x64-product-c2-GCBasher_ParOldGC >>>> windows_x64-fastdebug-c2-GCBasher_ParOldGC >>>> windows_x64-product-c2-GCOld_SerialGC >>>> windows_x64-fastdebug-c2-GCOld_SerialGC >>>> windows_x64-product-c2-GCOld_ParallelGC >>>> windows_x64-fastdebug-c2-GCOld_ParallelGC >>>> windows_x64-product-c2-GCOld_ParNewGC >>>> windows_x64-fastdebug-c2-GCOld_ParNewGC >>>> windows_x64-product-c2-GCOld_CMS >>>> windows_x64-fastdebug-c2-GCOld_CMS >>>> windows_x64-product-c2-GCOld_G1 >>>> windows_x64-fastdebug-c2-GCOld_G1 >>>> windows_x64-product-c2-GCOld_ParOldGC >>>> windows_x64-fastdebug-c2-GCOld_ParOldGC >>>> windows_x64-product-c2-jbb_default >>>> windows_x64-fastdebug-c2-jbb_default >>>> windows_x64-product-c2-jbb_default_nontiered >>>> windows_x64-fastdebug-c2-jbb_default_nontiered >>>> windows_x64-product-c2-jbb_CMS >>>> windows_x64-product-c2-jbb_ParallelGC >>>> windows_x64-product-c2-jbb_G1 >>>> windows_x64-product-c2-jbb_ParOldGC >>>> windows_i586-fastdebug-c1-clienttest >>>> windows_i586-product-c1-clienttest >>>> windows_i586-fastdebug-c2-servertest >>>> windows_i586-product-c2-servertest >>>> windows_x64-fastdebug-c2-servertest >>>> windows_x64-product-c2-servertest >>>> windows_i586-fastdebug-c2-internalvmtests >>>> windows_x64-fastdebug-c2-internalvmtests >>>> windows_i586-product-c2-wbapitest >>>> windows_i586-fastdebug-c2-wbapitest >>>> windows_x64-product-c2-wbapitest >>>> windows_x64-fastdebug-c2-wbapitest >>>> windows_i586-product-c1-wbapitest >>>> windows_i586-fastdebug-c1-wbapitest >>>> >>>> >>>> On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >>>>> On 6/1/13 11:02 AM, Tim Bell wrote: >>>>>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>>>>> >>>>>> The bug report will be visible in a few days here: >>>>>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>>>>> >>>>>> Minor Makefile changes and one source file was touched to compile >>>>>> with Visual Studio 2012. These changes also compile under >>>>>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>>>>> Tested by building the forest with both compilers. >>>>>> >>>>>> % hg status >>>>>> M make/windows/makefiles/compile.make >>>>> >>>>> same question about the STATIC_CPPLIB stuff as David H. >>>>> >>>>> >>>>>> M make/windows/makefiles/sanity.make >>>>> >>>>> No comments. >>>>> >>>>> >>>>>> M make/windows/makefiles/vm.make >>>>> >>>>> Same question about the new 'ifdef DEVELOP' change as David H. >>>>> >>>>> Sanity check: The patch shows this change: >>>>> >>>>> # Special case files not using precompiled header files. >>>>> >>>>> -c1_RInfo_$(Platform_arch).obj: >>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>> >>>>> +c1_RInfo_$(Platform_arch).obj: >>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>> >>>>> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>> >>>>> >>>>> But I don't see a change. And this diff doesn't show up in the >>>>> other views. Oh wait, there's a blank at the end of the '+' >>>>> line... >>>>> >>>>>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >>>>> >>>>> No comments. >>>>> >>>>> Dan >>>>> >>>>> >>>>>> >>>>>> webrev and patch file are here: >>>>>> >>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Thanks to Anthony Petrov who provided the initial set of patches for >>>>>> this work. >>>>>> >>>>>> I believe this should go in via the hotspot-rt forest (let me >>>>>> know if >>>>>> that is not correct), in which case I will need a sponsor from that >>>>>> team to push the change. >>>>>> >>>>>> Thanks in advance- >>>>>> Tim >>>>>> >>>>>> >>>>> >>>> >> From michael.x.mcmahon at oracle.com Tue Jul 16 12:20:24 2013 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Tue, 16 Jul 2013 13:20:24 +0100 Subject: autoconf problem Message-ID: <51E53A88.9060205@oracle.com> Hi, Since my latest sync of jdk8/cpu (today) I can't run configure. I get the following error: $ bash ./configure Warning: The generated configure file contains changes not present in the custom generated file. Cannot locate autoconf, unable to correct situation. Please install autoconf and run 'bash autogen.sh' to update the generated files. Error: Cannot continue mm72272 at mm72272-ThinkPad-T420:/export/repos/jdk8-cpu$ bash ./configure --help Warning: The generated configure file contains changes not present in the custom generated file. Cannot locate autoconf, unable to correct situation. Please install autoconf and run 'bash autogen.sh' to update the generated files. Error: Cannot continue Now, I don't have "autoconf" installed but before I try and continue by installing it, I'd like to understand more why this is happening. Any ideas? Thanks! Michael From dmitry.samersoff at oracle.com Tue Jul 16 12:43:15 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 16 Jul 2013 16:43:15 +0400 Subject: autoconf problem In-Reply-To: <51E53A88.9060205@oracle.com> References: <51E53A88.9060205@oracle.com> Message-ID: <51E53FE3.7010409@oracle.com> Michael, Try to get fresh workspace or at least run hg pull -u in the root directory. get_source.sh not always/doesn't update root folder. -Dmitry On 2013-07-16 16:20, Michael McMahon wrote: > Hi, > > Since my latest sync of jdk8/cpu (today) I can't run configure. I get > the following > error: > > $ bash ./configure > Warning: The generated configure file contains changes not present in > the custom generated file. > Cannot locate autoconf, unable to correct situation. > Please install autoconf and run 'bash autogen.sh' to update the > generated files. > Error: Cannot continue > mm72272 at mm72272-ThinkPad-T420:/export/repos/jdk8-cpu$ bash ./configure > --help > Warning: The generated configure file contains changes not present in > the custom generated file. > Cannot locate autoconf, unable to correct situation. > Please install autoconf and run 'bash autogen.sh' to update the > generated files. > Error: Cannot continue > > Now, I don't have "autoconf" installed but before I try and continue by > installing it, > I'd like to understand more why this is happening. Any ideas? > > Thanks! > Michael > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the source code. From tim.bell at oracle.com Tue Jul 16 13:02:42 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 16 Jul 2013 06:02:42 -0700 Subject: autoconf problem In-Reply-To: <51E53A88.9060205@oracle.com> References: <51E53A88.9060205@oracle.com> Message-ID: <51E54472.7010308@oracle.com> Hi Michael: > Since my latest sync of jdk8/cpu (today) I can't run configure. I get > the following > error: Looks like your merge touched some of the .m4 files (common/autoconf/basics.m4 and common/autoconf/build-performance.m4 to name two): Our standard guidance when this happens is to do your merge, and then run bash common/autoconf/autogen.sh to recreate the generated-configure.sh file(s). Lastly, commit them as part of your merge. If you have the closed repos, there will be two of them. Tim > $ bash ./configure > Warning: The generated configure file contains changes not present in > the custom generated file. > Cannot locate autoconf, unable to correct situation. > Please install autoconf and run 'bash autogen.sh' to update the > generated files. > Error: Cannot continue > mm72272 at mm72272-ThinkPad-T420:/export/repos/jdk8-cpu$ bash ./configure > --help > Warning: The generated configure file contains changes not present in > the custom generated file. > Cannot locate autoconf, unable to correct situation. > Please install autoconf and run 'bash autogen.sh' to update the > generated files. > Error: Cannot continue > > Now, I don't have "autoconf" installed but before I try and continue > by installing it, > I'd like to understand more why this is happening. Any ideas? > > Thanks! > Michael > From volker.simonis at gmail.com Tue Jul 16 13:42:07 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 16 Jul 2013 15:42:07 +0200 Subject: autoconf problem In-Reply-To: <51E54472.7010308@oracle.com> References: <51E53A88.9060205@oracle.com> <51E54472.7010308@oracle.com> Message-ID: On Tue, Jul 16, 2013 at 3:02 PM, Tim Bell wrote: > Hi Michael: > > >> Since my latest sync of jdk8/cpu (today) I can't run configure. I get the >> following >> error: > > > Looks like your merge touched some of the .m4 files > (common/autoconf/basics.m4 and common/autoconf/build-performance.m4 to name > two): > > Our standard guidance when this happens is to do your merge, and then run > > bash common/autoconf/autogen.sh > > to recreate the generated-configure.sh file(s). > That's right but you definitely need autoconf in order to do that (as indicated in the error). Notice that you don't necessarily need to run autoconf an the same system on which you want to run the generated configure script. If you have a shared workspace, you may for example install autoconf on a Linux machine and run autogeg.sh there. Afterwards you can run configure on any other system (i.e. Windows, Mac, Solaris..) Regards, Volker > Lastly, commit them as part of your merge. If you have the closed repos, > there will be two of them. > > Tim > > >> $ bash ./configure >> Warning: The generated configure file contains changes not present in the >> custom generated file. >> Cannot locate autoconf, unable to correct situation. >> Please install autoconf and run 'bash autogen.sh' to update the generated >> files. >> Error: Cannot continue >> mm72272 at mm72272-ThinkPad-T420:/export/repos/jdk8-cpu$ bash ./configure >> --help >> Warning: The generated configure file contains changes not present in the >> custom generated file. >> Cannot locate autoconf, unable to correct situation. >> Please install autoconf and run 'bash autogen.sh' to update the generated >> files. >> Error: Cannot continue >> >> Now, I don't have "autoconf" installed but before I try and continue by >> installing it, >> I'd like to understand more why this is happening. Any ideas? >> >> Thanks! >> Michael >> > From michael.x.mcmahon at oracle.com Tue Jul 16 14:30:44 2013 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Tue, 16 Jul 2013 15:30:44 +0100 Subject: autoconf problem In-Reply-To: References: <51E53A88.9060205@oracle.com> <51E54472.7010308@oracle.com> Message-ID: <51E55914.20002@oracle.com> On 16/07/13 14:42, Volker Simonis wrote: > On Tue, Jul 16, 2013 at 3:02 PM, Tim Bell wrote: >> Hi Michael: >> >> >>> Since my latest sync of jdk8/cpu (today) I can't run configure. I get the >>> following >>> error: >> >> Looks like your merge touched some of the .m4 files >> (common/autoconf/basics.m4 and common/autoconf/build-performance.m4 to name >> two): >> >> Our standard guidance when this happens is to do your merge, and then run >> >> bash common/autoconf/autogen.sh >> >> to recreate the generated-configure.sh file(s). >> > That's right but you definitely need autoconf in order to do that (as > indicated in the error). Okay. Thanks! > Notice that you don't necessarily need to run autoconf an the same > system on which you want to run the generated configure script. > If you have a shared workspace, you may for example install autoconf > on a Linux machine and run autogeg.sh there. Afterwards you can run > configure on any other system (i.e. Windows, Mac, Solaris..) > > Regards, > Volker > >> Lastly, commit them as part of your merge. If you have the closed repos, >> there will be two of them. >> >> Tim >> >> >>> $ bash ./configure >>> Warning: The generated configure file contains changes not present in the >>> custom generated file. >>> Cannot locate autoconf, unable to correct situation. >>> Please install autoconf and run 'bash autogen.sh' to update the generated >>> files. >>> Error: Cannot continue >>> mm72272 at mm72272-ThinkPad-T420:/export/repos/jdk8-cpu$ bash ./configure >>> --help >>> Warning: The generated configure file contains changes not present in the >>> custom generated file. >>> Cannot locate autoconf, unable to correct situation. >>> Please install autoconf and run 'bash autogen.sh' to update the generated >>> files. >>> Error: Cannot continue >>> >>> Now, I don't have "autoconf" installed but before I try and continue by >>> installing it, >>> I'd like to understand more why this is happening. Any ideas? >>> >>> Thanks! >>> Michael >>> From tim.bell at oracle.com Tue Jul 16 16:21:46 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 16 Jul 2013 09:21:46 -0700 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E4A76B.8050808@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> <51E3787C.4040802@oracle.com> <51E3EB10.1030508@oracle.com> <51E49C23.7010504@oracle.com> <51E4A76B.8050808@oracle.com> Message-ID: <51E5731A.9010505@oracle.com> Hi Yumin: Thanks for looking at this. > The patch works fine when using build.bat to build hotspot on Windows, > there is one issue with create.bat, which will fail to create project > file for VS2012. > I tried to work this around to create a VS2010 project, see URL: > http://javaweb.us.oracle.com/~yqi/webrev/vs2012build/ > > The only two files: create.bat and rules.make changed for this purpose. > > The created project files, for i486, open with VS2012 OK, but amd-64 > will hang, I have no time to check the detail why it hangs. > This may be need addressed in a separate bug. I am OK with the > current changes, it works fine for build. Please file a new bug against build.bat. In my experience, moving from VS2010 to VS2012 is a one-way trip. The project files have changed format considerably, so once you move forward you cannot go back on that source tree without reverting the changes. It has been a while, but I recall build.bat is doing some clever things that rely on the internal format of the VS files, and if so it will need to be updated. Tim > The failure is because we dont have set properly for the project > setting, so it default to VC7, which is not right. > > Writing .vcproj file: > D:\yqi\ws\8016538-build\build\vs-amd64\jvm.vcproj > java.lang.NullPointerException > at > WinGammaPlatformVC7.writeConfiguration(WinGammaPlatformVC7.java:153) > at > WinGammaPlatformVC7.writeProjectFile(WinGammaPlatformVC7.java:62) > at WinGammaPlatform.createVcproj(WinGammaPlatform.java:270) > at ProjectCreator.main(ProjectCreator.java:93) > NMAKE : fatal error U1077: 'd:\yqi\jdks\windows-i586\bin\java.EXE' : > return code '0x1' > Stop. > > > Thanks > Yumin > > > On 7/15/2013 6:04 PM, David Holmes wrote: >> On 15/07/2013 10:29 PM, Tim Bell wrote: >>> David, Anthony : >>> >>> Thank you for the review. >>> >>> David wrote: >>> >>>> Only concern is that we may want to separate out the >>>> make/jprt.properties change, otherwise we can't push this until the >>>> switch to the new compilers has been officially approved. It may be >>>> easier to put the vs2012 support in place first and make the switch >>>> itself later. >>> >>> I completely agree - separate out the make/jprt.properties change. >>> Could >>> I get a sponsor to push the changes to the other four files to >>> hotspot-runtime ASAP? >> >> I will sponsor it for you. I'll use the existing patch and revert the >> jprt change. >> >> Thanks, >> David >> >>> >>> Tim >>> >>> >>> On 07/14/13 09:20 PM, David Holmes wrote: >>>> Hi Tim, >>>> >>>> This looks okay to me. >>>> >>>> Only concern is that we may want to separate out the >>>> make/jprt.properties change, otherwise we can't push this until the >>>> switch to the new compilers has been officially approved. It may be >>>> easier to put the vs2012 support in place first and make the switch >>>> itself later. >>>> >>>> David >>>> >>>> On 13/07/2013 9:51 PM, Tim Bell wrote: >>>>> Hello everyone- >>>>> >>>>> Many thanks for the early feedback on this JDK8 hotspot + VS2012 >>>>> project. >>>>> >>>>> A revised webrev is here: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ >>>>> >>>>> These changes build and pass all of the standard 119 tests (as >>>>> listed in >>>>> the jprt.properties file - see below) when using VS2012 and also >>>>> using >>>>> VS2010. >>>>> >>>>> Thanks in advance for any feedback- >>>>> >>>>> Tim >>>>> >>>>> *** Build targets: >>>>> windows_i586_5.1-product with attributes compiler=VS2010 (or >>>>> i586_6.1 >>>>> VS2012) >>>>> windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or >>>>> i586_6.1 VS2012) >>>>> windows_x64_5.2-product with attributes compiler=VS2010 (or >>>>> i586_6.1 >>>>> VS2012) >>>>> windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or >>>>> i586_6.1 VS2012) >>>>> >>>>> *** Test targets: >>>>> windows_i586-product-c1-jvm98 >>>>> windows_i586-product-c2-jvm98 >>>>> windows_i586-fastdebug-c1-jvm98 >>>>> windows_i586-fastdebug-c2-jvm98 >>>>> windows_i586-product-c2-jvm98_nontiered >>>>> windows_i586-fastdebug-c2-jvm98_nontiered >>>>> windows_i586-product-c1-scimark >>>>> windows_i586-product-c2-scimark >>>>> windows_i586-fastdebug-c1-scimark >>>>> windows_i586-fastdebug-c2-scimark >>>>> windows_i586-product-c1-runThese >>>>> windows_i586-product-c2-runThese >>>>> windows_i586-product-c1-runThese_Xcomp >>>>> windows_i586-product-c2-runThese_Xcomp >>>>> windows_i586-fastdebug-c1-runThese_Xshare >>>>> windows_i586-product-c1-GCBasher_SerialGC >>>>> windows_i586-product-c2-GCBasher_SerialGC >>>>> windows_i586-fastdebug-c1-GCBasher_SerialGC >>>>> windows_i586-fastdebug-c2-GCBasher_SerialGC >>>>> windows_i586-product-c1-GCBasher_ParallelGC >>>>> windows_i586-product-c2-GCBasher_ParallelGC >>>>> windows_i586-fastdebug-c1-GCBasher_ParallelGC >>>>> windows_i586-fastdebug-c2-GCBasher_ParallelGC >>>>> windows_i586-product-c1-GCBasher_ParNewGC >>>>> windows_i586-product-c2-GCBasher_ParNewGC >>>>> windows_i586-fastdebug-c1-GCBasher_ParNewGC >>>>> windows_i586-fastdebug-c2-GCBasher_ParNewGC >>>>> windows_i586-product-c1-GCBasher_CMS >>>>> windows_i586-product-c2-GCBasher_CMS >>>>> windows_i586-fastdebug-c1-GCBasher_CMS >>>>> windows_i586-fastdebug-c2-GCBasher_CMS >>>>> windows_i586-product-c1-GCBasher_G1 >>>>> windows_i586-product-c2-GCBasher_G1 >>>>> windows_i586-fastdebug-c1-GCBasher_G1 >>>>> windows_i586-fastdebug-c2-GCBasher_G1 >>>>> windows_i586-product-c1-GCBasher_ParOldGC >>>>> windows_i586-product-c2-GCBasher_ParOldGC >>>>> windows_i586-fastdebug-c1-GCBasher_ParOldGC >>>>> windows_i586-fastdebug-c2-GCBasher_ParOldGC >>>>> windows_i586-product-c1-GCOld_SerialGC >>>>> windows_i586-product-c2-GCOld_SerialGC >>>>> windows_i586-product-c1-GCOld_ParallelGC >>>>> windows_i586-product-c2-GCOld_ParallelGC >>>>> windows_i586-product-c1-GCOld_ParNewGC >>>>> windows_i586-product-c2-GCOld_ParNewGC >>>>> windows_i586-product-c1-GCOld_CMS >>>>> windows_i586-product-c2-GCOld_CMS >>>>> windows_i586-product-c1-GCOld_G1 >>>>> windows_i586-product-c2-GCOld_G1 >>>>> windows_i586-product-c1-GCOld_ParOldGC >>>>> windows_i586-product-c2-GCOld_ParOldGC >>>>> windows_i586-product-c1-jbb_default >>>>> windows_i586-product-c2-jbb_default >>>>> windows_i586-fastdebug-c1-jbb_default >>>>> windows_i586-fastdebug-c2-jbb_default >>>>> windows_i586-product-c2-jbb_default_nontiered >>>>> windows_i586-fastdebug-c2-jbb_default_nontiered >>>>> windows_i586-product-c1-jbb_ParallelGC >>>>> windows_i586-product-c2-jbb_ParallelGC >>>>> windows_i586-product-c1-jbb_CMS >>>>> windows_i586-product-c2-jbb_CMS >>>>> windows_i586-product-c1-jbb_G1 >>>>> windows_i586-product-c2-jbb_G1 >>>>> windows_i586-product-c1-jbb_ParOldGC >>>>> windows_i586-product-c2-jbb_ParOldGC >>>>> windows_x64-product-c2-jvm98 >>>>> windows_x64-fastdebug-c2-jvm98 >>>>> windows_x64-product-c2-jvm98_nontiered >>>>> windows_x64-fastdebug-c2-jvm98_nontiered >>>>> windows_x64-product-c2-scimark >>>>> windows_x64-fastdebug-c2-scimark >>>>> windows_x64-product-c2-runThese >>>>> windows_x64-product-c2-runThese_Xcomp >>>>> windows_x64-product-c2-GCBasher_SerialGC >>>>> windows_x64-fastdebug-c2-GCBasher_SerialGC >>>>> windows_x64-product-c2-GCBasher_ParallelGC >>>>> windows_x64-fastdebug-c2-GCBasher_ParallelGC >>>>> windows_x64-product-c2-GCBasher_ParNewGC >>>>> windows_x64-fastdebug-c2-GCBasher_ParNewGC >>>>> windows_x64-product-c2-GCBasher_CMS >>>>> windows_x64-fastdebug-c2-GCBasher_CMS >>>>> windows_x64-product-c2-GCBasher_G1 >>>>> windows_x64-fastdebug-c2-GCBasher_G1 >>>>> windows_x64-product-c2-GCBasher_ParOldGC >>>>> windows_x64-fastdebug-c2-GCBasher_ParOldGC >>>>> windows_x64-product-c2-GCOld_SerialGC >>>>> windows_x64-fastdebug-c2-GCOld_SerialGC >>>>> windows_x64-product-c2-GCOld_ParallelGC >>>>> windows_x64-fastdebug-c2-GCOld_ParallelGC >>>>> windows_x64-product-c2-GCOld_ParNewGC >>>>> windows_x64-fastdebug-c2-GCOld_ParNewGC >>>>> windows_x64-product-c2-GCOld_CMS >>>>> windows_x64-fastdebug-c2-GCOld_CMS >>>>> windows_x64-product-c2-GCOld_G1 >>>>> windows_x64-fastdebug-c2-GCOld_G1 >>>>> windows_x64-product-c2-GCOld_ParOldGC >>>>> windows_x64-fastdebug-c2-GCOld_ParOldGC >>>>> windows_x64-product-c2-jbb_default >>>>> windows_x64-fastdebug-c2-jbb_default >>>>> windows_x64-product-c2-jbb_default_nontiered >>>>> windows_x64-fastdebug-c2-jbb_default_nontiered >>>>> windows_x64-product-c2-jbb_CMS >>>>> windows_x64-product-c2-jbb_ParallelGC >>>>> windows_x64-product-c2-jbb_G1 >>>>> windows_x64-product-c2-jbb_ParOldGC >>>>> windows_i586-fastdebug-c1-clienttest >>>>> windows_i586-product-c1-clienttest >>>>> windows_i586-fastdebug-c2-servertest >>>>> windows_i586-product-c2-servertest >>>>> windows_x64-fastdebug-c2-servertest >>>>> windows_x64-product-c2-servertest >>>>> windows_i586-fastdebug-c2-internalvmtests >>>>> windows_x64-fastdebug-c2-internalvmtests >>>>> windows_i586-product-c2-wbapitest >>>>> windows_i586-fastdebug-c2-wbapitest >>>>> windows_x64-product-c2-wbapitest >>>>> windows_x64-fastdebug-c2-wbapitest >>>>> windows_i586-product-c1-wbapitest >>>>> windows_i586-fastdebug-c1-wbapitest >>>>> >>>>> >>>>> On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >>>>>> On 6/1/13 11:02 AM, Tim Bell wrote: >>>>>>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>>>>>> >>>>>>> The bug report will be visible in a few days here: >>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>>>>>> >>>>>>> Minor Makefile changes and one source file was touched to compile >>>>>>> with Visual Studio 2012. These changes also compile under >>>>>>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>>>>>> Tested by building the forest with both compilers. >>>>>>> >>>>>>> % hg status >>>>>>> M make/windows/makefiles/compile.make >>>>>> >>>>>> same question about the STATIC_CPPLIB stuff as David H. >>>>>> >>>>>> >>>>>>> M make/windows/makefiles/sanity.make >>>>>> >>>>>> No comments. >>>>>> >>>>>> >>>>>>> M make/windows/makefiles/vm.make >>>>>> >>>>>> Same question about the new 'ifdef DEVELOP' change as David H. >>>>>> >>>>>> Sanity check: The patch shows this change: >>>>>> >>>>>> # Special case files not using precompiled header files. >>>>>> >>>>>> -c1_RInfo_$(Platform_arch).obj: >>>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>>> >>>>>> +c1_RInfo_$(Platform_arch).obj: >>>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>>> >>>>>> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >>>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>>> >>>>>> >>>>>> But I don't see a change. And this diff doesn't show up in the >>>>>> other views. Oh wait, there's a blank at the end of the '+' >>>>>> line... >>>>>> >>>>>>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >>>>>> >>>>>> No comments. >>>>>> >>>>>> Dan >>>>>> >>>>>> >>>>>>> >>>>>>> webrev and patch file are here: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Thanks to Anthony Petrov who provided the initial set of patches >>>>>>> for >>>>>>> this work. >>>>>>> >>>>>>> I believe this should go in via the hotspot-rt forest (let me >>>>>>> know if >>>>>>> that is not correct), in which case I will need a sponsor from that >>>>>>> team to push the change. >>>>>>> >>>>>>> Thanks in advance- >>>>>>> Tim >>>>>>> >>>>>>> >>>>>> >>>>> >>> > From yumin.qi at oracle.com Tue Jul 16 17:21:40 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 16 Jul 2013 10:21:40 -0700 Subject: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012 In-Reply-To: <51E5731A.9010505@oracle.com> References: <51AA2927.2030404@oracle.com> <51AC9CFC.70503@oracle.com> <51E13F2F.7070104@oracle.com> <51E3787C.4040802@oracle.com> <51E3EB10.1030508@oracle.com> <51E49C23.7010504@oracle.com> <51E4A76B.8050808@oracle.com> <51E5731A.9010505@oracle.com> Message-ID: <51E58124.1040005@oracle.com> Filed: https://jbs.oracle.com/bugs/browse/JDK-8020622 Thanks Yumin On 7/16/2013 9:21 AM, Tim Bell wrote: > Hi Yumin: > > Thanks for looking at this. > >> The patch works fine when using build.bat to build hotspot on >> Windows, there is one issue with create.bat, which will fail to >> create project file for VS2012. >> I tried to work this around to create a VS2010 project, see URL: >> http://javaweb.us.oracle.com/~yqi/webrev/vs2012build/ >> >> The only two files: create.bat and rules.make changed for this >> purpose. >> >> The created project files, for i486, open with VS2012 OK, but >> amd-64 will hang, I have no time to check the detail why it hangs. >> This may be need addressed in a separate bug. I am OK with the >> current changes, it works fine for build. > > Please file a new bug against build.bat. > > In my experience, moving from VS2010 to VS2012 is a one-way trip. The > project files have changed format considerably, so once you move > forward you cannot go back on that source tree without reverting the > changes. It has been a while, but I recall build.bat is doing some > clever things that rely on the internal format of the VS files, and if > so it will need to be updated. > > Tim > >> The failure is because we dont have set properly for the project >> setting, so it default to VC7, which is not right. >> >> Writing .vcproj file: >> D:\yqi\ws\8016538-build\build\vs-amd64\jvm.vcproj >> java.lang.NullPointerException >> at >> WinGammaPlatformVC7.writeConfiguration(WinGammaPlatformVC7.java:153) >> at >> WinGammaPlatformVC7.writeProjectFile(WinGammaPlatformVC7.java:62) >> at WinGammaPlatform.createVcproj(WinGammaPlatform.java:270) >> at ProjectCreator.main(ProjectCreator.java:93) >> NMAKE : fatal error U1077: 'd:\yqi\jdks\windows-i586\bin\java.EXE' : >> return code '0x1' >> Stop. >> >> >> Thanks >> Yumin >> >> >> On 7/15/2013 6:04 PM, David Holmes wrote: >>> On 15/07/2013 10:29 PM, Tim Bell wrote: >>>> David, Anthony : >>>> >>>> Thank you for the review. >>>> >>>> David wrote: >>>> >>>>> Only concern is that we may want to separate out the >>>>> make/jprt.properties change, otherwise we can't push this until the >>>>> switch to the new compilers has been officially approved. It may be >>>>> easier to put the vs2012 support in place first and make the switch >>>>> itself later. >>>> >>>> I completely agree - separate out the make/jprt.properties change. >>>> Could >>>> I get a sponsor to push the changes to the other four files to >>>> hotspot-runtime ASAP? >>> >>> I will sponsor it for you. I'll use the existing patch and revert >>> the jprt change. >>> >>> Thanks, >>> David >>> >>>> >>>> Tim >>>> >>>> >>>> On 07/14/13 09:20 PM, David Holmes wrote: >>>>> Hi Tim, >>>>> >>>>> This looks okay to me. >>>>> >>>>> Only concern is that we may want to separate out the >>>>> make/jprt.properties change, otherwise we can't push this until the >>>>> switch to the new compilers has been officially approved. It may be >>>>> easier to put the vs2012 support in place first and make the switch >>>>> itself later. >>>>> >>>>> David >>>>> >>>>> On 13/07/2013 9:51 PM, Tim Bell wrote: >>>>>> Hello everyone- >>>>>> >>>>>> Many thanks for the early feedback on this JDK8 hotspot + VS2012 >>>>>> project. >>>>>> >>>>>> A revised webrev is here: >>>>>> >>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ >>>>>> >>>>>> These changes build and pass all of the standard 119 tests (as >>>>>> listed in >>>>>> the jprt.properties file - see below) when using VS2012 and also >>>>>> using >>>>>> VS2010. >>>>>> >>>>>> Thanks in advance for any feedback- >>>>>> >>>>>> Tim >>>>>> >>>>>> *** Build targets: >>>>>> windows_i586_5.1-product with attributes compiler=VS2010 (or >>>>>> i586_6.1 >>>>>> VS2012) >>>>>> windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or >>>>>> i586_6.1 VS2012) >>>>>> windows_x64_5.2-product with attributes compiler=VS2010 (or >>>>>> i586_6.1 >>>>>> VS2012) >>>>>> windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or >>>>>> i586_6.1 VS2012) >>>>>> >>>>>> *** Test targets: >>>>>> windows_i586-product-c1-jvm98 >>>>>> windows_i586-product-c2-jvm98 >>>>>> windows_i586-fastdebug-c1-jvm98 >>>>>> windows_i586-fastdebug-c2-jvm98 >>>>>> windows_i586-product-c2-jvm98_nontiered >>>>>> windows_i586-fastdebug-c2-jvm98_nontiered >>>>>> windows_i586-product-c1-scimark >>>>>> windows_i586-product-c2-scimark >>>>>> windows_i586-fastdebug-c1-scimark >>>>>> windows_i586-fastdebug-c2-scimark >>>>>> windows_i586-product-c1-runThese >>>>>> windows_i586-product-c2-runThese >>>>>> windows_i586-product-c1-runThese_Xcomp >>>>>> windows_i586-product-c2-runThese_Xcomp >>>>>> windows_i586-fastdebug-c1-runThese_Xshare >>>>>> windows_i586-product-c1-GCBasher_SerialGC >>>>>> windows_i586-product-c2-GCBasher_SerialGC >>>>>> windows_i586-fastdebug-c1-GCBasher_SerialGC >>>>>> windows_i586-fastdebug-c2-GCBasher_SerialGC >>>>>> windows_i586-product-c1-GCBasher_ParallelGC >>>>>> windows_i586-product-c2-GCBasher_ParallelGC >>>>>> windows_i586-fastdebug-c1-GCBasher_ParallelGC >>>>>> windows_i586-fastdebug-c2-GCBasher_ParallelGC >>>>>> windows_i586-product-c1-GCBasher_ParNewGC >>>>>> windows_i586-product-c2-GCBasher_ParNewGC >>>>>> windows_i586-fastdebug-c1-GCBasher_ParNewGC >>>>>> windows_i586-fastdebug-c2-GCBasher_ParNewGC >>>>>> windows_i586-product-c1-GCBasher_CMS >>>>>> windows_i586-product-c2-GCBasher_CMS >>>>>> windows_i586-fastdebug-c1-GCBasher_CMS >>>>>> windows_i586-fastdebug-c2-GCBasher_CMS >>>>>> windows_i586-product-c1-GCBasher_G1 >>>>>> windows_i586-product-c2-GCBasher_G1 >>>>>> windows_i586-fastdebug-c1-GCBasher_G1 >>>>>> windows_i586-fastdebug-c2-GCBasher_G1 >>>>>> windows_i586-product-c1-GCBasher_ParOldGC >>>>>> windows_i586-product-c2-GCBasher_ParOldGC >>>>>> windows_i586-fastdebug-c1-GCBasher_ParOldGC >>>>>> windows_i586-fastdebug-c2-GCBasher_ParOldGC >>>>>> windows_i586-product-c1-GCOld_SerialGC >>>>>> windows_i586-product-c2-GCOld_SerialGC >>>>>> windows_i586-product-c1-GCOld_ParallelGC >>>>>> windows_i586-product-c2-GCOld_ParallelGC >>>>>> windows_i586-product-c1-GCOld_ParNewGC >>>>>> windows_i586-product-c2-GCOld_ParNewGC >>>>>> windows_i586-product-c1-GCOld_CMS >>>>>> windows_i586-product-c2-GCOld_CMS >>>>>> windows_i586-product-c1-GCOld_G1 >>>>>> windows_i586-product-c2-GCOld_G1 >>>>>> windows_i586-product-c1-GCOld_ParOldGC >>>>>> windows_i586-product-c2-GCOld_ParOldGC >>>>>> windows_i586-product-c1-jbb_default >>>>>> windows_i586-product-c2-jbb_default >>>>>> windows_i586-fastdebug-c1-jbb_default >>>>>> windows_i586-fastdebug-c2-jbb_default >>>>>> windows_i586-product-c2-jbb_default_nontiered >>>>>> windows_i586-fastdebug-c2-jbb_default_nontiered >>>>>> windows_i586-product-c1-jbb_ParallelGC >>>>>> windows_i586-product-c2-jbb_ParallelGC >>>>>> windows_i586-product-c1-jbb_CMS >>>>>> windows_i586-product-c2-jbb_CMS >>>>>> windows_i586-product-c1-jbb_G1 >>>>>> windows_i586-product-c2-jbb_G1 >>>>>> windows_i586-product-c1-jbb_ParOldGC >>>>>> windows_i586-product-c2-jbb_ParOldGC >>>>>> windows_x64-product-c2-jvm98 >>>>>> windows_x64-fastdebug-c2-jvm98 >>>>>> windows_x64-product-c2-jvm98_nontiered >>>>>> windows_x64-fastdebug-c2-jvm98_nontiered >>>>>> windows_x64-product-c2-scimark >>>>>> windows_x64-fastdebug-c2-scimark >>>>>> windows_x64-product-c2-runThese >>>>>> windows_x64-product-c2-runThese_Xcomp >>>>>> windows_x64-product-c2-GCBasher_SerialGC >>>>>> windows_x64-fastdebug-c2-GCBasher_SerialGC >>>>>> windows_x64-product-c2-GCBasher_ParallelGC >>>>>> windows_x64-fastdebug-c2-GCBasher_ParallelGC >>>>>> windows_x64-product-c2-GCBasher_ParNewGC >>>>>> windows_x64-fastdebug-c2-GCBasher_ParNewGC >>>>>> windows_x64-product-c2-GCBasher_CMS >>>>>> windows_x64-fastdebug-c2-GCBasher_CMS >>>>>> windows_x64-product-c2-GCBasher_G1 >>>>>> windows_x64-fastdebug-c2-GCBasher_G1 >>>>>> windows_x64-product-c2-GCBasher_ParOldGC >>>>>> windows_x64-fastdebug-c2-GCBasher_ParOldGC >>>>>> windows_x64-product-c2-GCOld_SerialGC >>>>>> windows_x64-fastdebug-c2-GCOld_SerialGC >>>>>> windows_x64-product-c2-GCOld_ParallelGC >>>>>> windows_x64-fastdebug-c2-GCOld_ParallelGC >>>>>> windows_x64-product-c2-GCOld_ParNewGC >>>>>> windows_x64-fastdebug-c2-GCOld_ParNewGC >>>>>> windows_x64-product-c2-GCOld_CMS >>>>>> windows_x64-fastdebug-c2-GCOld_CMS >>>>>> windows_x64-product-c2-GCOld_G1 >>>>>> windows_x64-fastdebug-c2-GCOld_G1 >>>>>> windows_x64-product-c2-GCOld_ParOldGC >>>>>> windows_x64-fastdebug-c2-GCOld_ParOldGC >>>>>> windows_x64-product-c2-jbb_default >>>>>> windows_x64-fastdebug-c2-jbb_default >>>>>> windows_x64-product-c2-jbb_default_nontiered >>>>>> windows_x64-fastdebug-c2-jbb_default_nontiered >>>>>> windows_x64-product-c2-jbb_CMS >>>>>> windows_x64-product-c2-jbb_ParallelGC >>>>>> windows_x64-product-c2-jbb_G1 >>>>>> windows_x64-product-c2-jbb_ParOldGC >>>>>> windows_i586-fastdebug-c1-clienttest >>>>>> windows_i586-product-c1-clienttest >>>>>> windows_i586-fastdebug-c2-servertest >>>>>> windows_i586-product-c2-servertest >>>>>> windows_x64-fastdebug-c2-servertest >>>>>> windows_x64-product-c2-servertest >>>>>> windows_i586-fastdebug-c2-internalvmtests >>>>>> windows_x64-fastdebug-c2-internalvmtests >>>>>> windows_i586-product-c2-wbapitest >>>>>> windows_i586-fastdebug-c2-wbapitest >>>>>> windows_x64-product-c2-wbapitest >>>>>> windows_x64-fastdebug-c2-wbapitest >>>>>> windows_i586-product-c1-wbapitest >>>>>> windows_i586-fastdebug-c1-wbapitest >>>>>> >>>>>> >>>>>> On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote: >>>>>>> On 6/1/13 11:02 AM, Tim Bell wrote: >>>>>>>> 8015759: hotspot changes needed to compile with Visual Studio 2012 >>>>>>>> >>>>>>>> The bug report will be visible in a few days here: >>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8015759 >>>>>>>> >>>>>>>> Minor Makefile changes and one source file was touched to compile >>>>>>>> with Visual Studio 2012. These changes also compile under >>>>>>>> Visual Studio 2010 with no problem so we can upgrade gracefully. >>>>>>>> Tested by building the forest with both compilers. >>>>>>>> >>>>>>>> % hg status >>>>>>>> M make/windows/makefiles/compile.make >>>>>>> >>>>>>> same question about the STATIC_CPPLIB stuff as David H. >>>>>>> >>>>>>> >>>>>>>> M make/windows/makefiles/sanity.make >>>>>>> >>>>>>> No comments. >>>>>>> >>>>>>> >>>>>>>> M make/windows/makefiles/vm.make >>>>>>> >>>>>>> Same question about the new 'ifdef DEVELOP' change as David H. >>>>>>> >>>>>>> Sanity check: The patch shows this change: >>>>>>> >>>>>>> # Special case files not using precompiled header files. >>>>>>> >>>>>>> -c1_RInfo_$(Platform_arch).obj: >>>>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>>>> >>>>>>> +c1_RInfo_$(Platform_arch).obj: >>>>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>>>> >>>>>>> $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c >>>>>>> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp >>>>>>> >>>>>>> >>>>>>> But I don't see a change. And this diff doesn't show up in the >>>>>>> other views. Oh wait, there's a blank at the end of the '+' >>>>>>> line... >>>>>>> >>>>>>>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp >>>>>>> >>>>>>> No comments. >>>>>>> >>>>>>> Dan >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> webrev and patch file are here: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/ >>>>>>>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks to Anthony Petrov who provided the initial set of >>>>>>>> patches for >>>>>>>> this work. >>>>>>>> >>>>>>>> I believe this should go in via the hotspot-rt forest (let me >>>>>>>> know if >>>>>>>> that is not correct), in which case I will need a sponsor from >>>>>>>> that >>>>>>>> team to push the change. >>>>>>>> >>>>>>>> Thanks in advance- >>>>>>>> Tim >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>> >> > From david.katleman at oracle.com Tue Jul 16 22:17:48 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 16 Jul 2013 22:17:48 +0000 Subject: hg: jdk8/build/hotspot: 33 new changesets Message-ID: <20130716221856.01BE648125@hg.openjdk.java.net> Changeset: ea4d24c1e0c6 Author: amurillo Date: 2013-07-04 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ea4d24c1e0c6 8019934: new hotspot build - hs25-b41 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f323bbb0e6c1 Author: coleenp Date: 2013-07-03 13:45 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f323bbb0e6c1 8019833: Wrong JNI error code for preexisting JVM Summary: Return the appropriate JNI error message (instead of the generic one) when the JVM is already started Reviewed-by: coleenp, hseigel Contributed-by: sylvestre at debian.org ! src/share/vm/prims/jni.cpp Changeset: 5f7a4367c787 Author: zgu Date: 2013-07-04 06:24 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5f7a4367c787 8016074: NMT: assertion failed: assert(thread->thread_state() == from) failed: coming from wrong thread state Summary: Uses os::NakedYield() on Solaris instead of os::yield_all() Reviewed-by: acorn, coleenp, hseigel ! src/share/vm/services/memTracker.hpp Changeset: a55aa67bce1a Author: zgu Date: 2013-07-04 04:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a55aa67bce1a Merge Changeset: 59b052799158 Author: dcubed Date: 2013-07-04 21:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/59b052799158 8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace Summary: Dl_info struct should only be used if dladdr() has returned non-zero (no errors) and always check the dladdr() return value; Dl_info.dli_sname and Dl_info.dli_saddr fields should only be used if non-NULL; update/improve runtime/6888954/vmerrors.sh test Reviewed-by: dsamersoff, zgu, hseigel, coleenp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/os/windows/vm/os_windows.inline.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! test/runtime/6888954/vmerrors.sh Changeset: 93e6dce53ba7 Author: fparain Date: 2013-07-05 08:26 +0000 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/93e6dce53ba7 8016465: The hs_err file gets wrong name Reviewed-by: dcubed, dholmes, rdurbin ! src/share/vm/utilities/vmError.cpp Changeset: cc5b7915104e Author: fparain Date: 2013-07-05 08:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cc5b7915104e Merge Changeset: cf9d71d3e474 Author: iklam Date: 2013-07-08 10:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cf9d71d3e474 8016903: Thread::_handle_area initial size too big Summary: Changed initial size to Chunk::tiny_size (216 bytes) Reviewed-by: coleenp, dholmes, sspitsyn ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/runtime/handles.hpp Changeset: 71180a6e5080 Author: jiangli Date: 2013-07-03 17:26 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/71180a6e5080 7133260: AllocationProfiler uses space in metadata and doesn't seem to do anything useful. Summary: Remove -Xaprof and Klass::_alloc_count & ArrayKlass::_alloc_size. Reviewed-by: stefank, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fa6929d0b0a9 Author: jiangli Date: 2013-07-08 14:21 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fa6929d0b0a9 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 3c7b4b7b2625 Author: jiangli Date: 2013-07-08 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3c7b4b7b2625 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: ba9dacff9c9d Author: hseigel Date: 2013-07-08 19:36 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ba9dacff9c9d 8014399: Remove JVM_SetProtectionDomain from hotspot Summary: JVM_SetProtectionDomain has been deprecated since 1.5 and is being removed Reviewed-by: coleenp, hseigel Contributed-by: eric.mccorkle at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 26037663c2a6 Author: hseigel Date: 2013-07-08 16:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26037663c2a6 Merge Changeset: e79a9f26ba2e Author: hseigel Date: 2013-07-08 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e79a9f26ba2e Merge Changeset: 72fce0b2d341 Author: zgu Date: 2013-07-09 13:18 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/72fce0b2d341 8011760: assert(delta != 0) failed: dup pointer in MemBaseline::malloc_sort_by_addr Summary: Some of qsort implementation on Linux x86 compares element to itself, which is mistakenly treated as duplicate pointer Reviewed-by: dcubed, acorn ! src/share/vm/services/memBaseline.cpp Changeset: 2839ce15e450 Author: zgu Date: 2013-07-09 19:56 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2839ce15e450 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: 50257d6f5aaa Author: acorn Date: 2013-07-09 14:02 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/50257d6f5aaa 8013635: VM should no longer create bridges for generic signatures. Summary: Requires: 8013789: Compiler bridges, 8015402: metafactory Reviewed-by: sspitsyn, coleenp, bharadwaj ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/runtime/globals.hpp Changeset: 22baec423e2f Author: acorn Date: 2013-07-09 22:48 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/22baec423e2f Merge Changeset: e50be1620201 Author: goetz Date: 2013-07-08 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e50be1620201 8020059: The flag introduced by 8014972 is not defined if Hotspot is built without a compiler (zero, ppc64 core build). Summary: define CodeCacheMinimumUseSpace flag for cppInterpeter build. Reviewed-by: kvn ! src/share/vm/runtime/globals.hpp Changeset: e554162ab094 Author: adlertz Date: 2013-07-09 17:20 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e554162ab094 8019625: Test compiler/8005956/PolynomialRoot.java timeouts on Solaris SPARCs Summary: Disable the test for SPARC and reduce the number of test iterations Reviewed-by: kvn ! test/compiler/8005956/PolynomialRoot.java Changeset: b42fe1a8e180 Author: drchase Date: 2013-07-09 08:56 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b42fe1a8e180 8017578: Hotspot compilation error with latest Studio compiler Summary: Make the destructor virtual (note more non-compiler hotspot errors occur downstream) Reviewed-by: kvn, twisti ! src/share/vm/adlc/forms.hpp Changeset: 7ac80525ece9 Author: anoll Date: 2013-07-09 11:48 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7ac80525ece9 8015635: Crash when specifying very large code cache size Summary: Limit the size of the code cache to at most 2G when arguments are checked; added regression test Reviewed-by: kvn, twisti ! src/share/vm/runtime/arguments.cpp + test/compiler/codecache/CheckUpperLimit.java Changeset: 5f533e38e7d5 Author: twisti Date: 2013-07-09 22:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5f533e38e7d5 Merge Changeset: dec841e0c9aa Author: anoll Date: 2013-07-10 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dec841e0c9aa 8016749: -XX:+UseISM fails an assert(obj->is_oop()) when running SPECjbb2005 Summary: Remove obsolete code that relates to ISM which was used only on Solaris 8. Reviewed-by: kvn, twisti ! src/os/solaris/vm/globals_solaris.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/share/vm/runtime/arguments.cpp Changeset: ec173c8f3739 Author: roland Date: 2013-07-11 01:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ec173c8f3739 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2cbc8f3011a0 Author: ehelin Date: 2013-06-05 09:44 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2cbc8f3011a0 8015972: Refactor the sending of the object count after GC event Reviewed-by: brutisso, pliden ! src/share/vm/gc_implementation/shared/gcTrace.cpp ! src/share/vm/gc_implementation/shared/gcTrace.hpp ! src/share/vm/gc_implementation/shared/gcTraceSend.cpp + src/share/vm/gc_implementation/shared/objectCountEventSender.cpp + src/share/vm/gc_implementation/shared/objectCountEventSender.hpp ! src/share/vm/memory/heapInspection.hpp - src/share/vm/memory/klassInfoClosure.hpp Changeset: 63cffb381adc Author: ehelin Date: 2013-06-12 15:50 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/63cffb381adc 8016170: GC id variable in gcTrace.cpp should use typedef GCId Reviewed-by: johnc, jwilhelm, jmasa ! src/share/vm/gc_implementation/shared/gcTrace.cpp Changeset: 6aa440bc1125 Author: ehelin Date: 2013-06-12 15:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6aa440bc1125 8015683: object_count_after_gc should have the same timestamp for all events Reviewed-by: mgerdin, stefank ! src/share/vm/gc_implementation/shared/gcTrace.cpp ! src/share/vm/gc_implementation/shared/objectCountEventSender.cpp ! src/share/vm/gc_implementation/shared/objectCountEventSender.hpp Changeset: 27c53c9f3a7e Author: ehelin Date: 2013-07-10 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/27c53c9f3a7e 8013939: Metaspace capacity not available Reviewed-by: tschatzl, mgerdin, stefank ! src/share/vm/gc_interface/collectedHeap.cpp Changeset: 0f631140d13b Author: tamao Date: 2013-07-11 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0f631140d13b Merge - src/share/vm/memory/klassInfoClosure.hpp Changeset: 2b9946e10587 Author: amurillo Date: 2013-07-12 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2b9946e10587 Merge - src/share/vm/memory/klassInfoClosure.hpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: ea979302bb70 Author: amurillo Date: 2013-07-12 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ea979302bb70 Added tag hs25-b41 for changeset 2b9946e10587 ! .hgtags Changeset: 81b6cb70717c Author: katleman Date: 2013-07-16 15:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/81b6cb70717c Merge From david.katleman at oracle.com Tue Jul 16 22:20:12 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 16 Jul 2013 22:20:12 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20130716222047.1FD2348126@hg.openjdk.java.net> Changeset: f83794805201 Author: mcimadamore Date: 2013-07-11 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f83794805201 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle 8020010: Move lambda bridge creation from metafactory and VM to compiler Summary: JDK/metafactory component of the bridge fix and and MethodType vs. MethodHandle changes. Reviewed-by: twisti, briangoetz, forax Contributed-by: robert.field at oracle.com ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/SerializedLambda.java Changeset: 6a099a36589b Author: katleman Date: 2013-07-16 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6a099a36589b Merge From david.katleman at oracle.com Tue Jul 16 22:21:04 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 16 Jul 2013 22:21:04 +0000 Subject: hg: jdk8/build/langtools: 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle; ... Message-ID: <20130716222110.3D0D548127@hg.openjdk.java.net> Changeset: 39ec5d8a691b Author: mcimadamore Date: 2013-07-11 14:07 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/39ec5d8a691b 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle 8020010: Move lambda bridge creation from metafactory and VM to compiler Summary: langtools/javac component of the bridge support and MethodType vs. MethodHandle changes. Reviewed-by: jjg, vromero, briangoetz, forax Contributed-by: robert.field at oracle.com ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/generics/bridges/Bridge.java + test/tools/javac/generics/bridges/BridgeHarness.java + test/tools/javac/generics/bridges/Bridges.java + test/tools/javac/generics/bridges/tests/TestBridgeWithDefault.java + test/tools/javac/generics/bridges/tests/TestClassAndInterfaceBridgeIdentical01.java + test/tools/javac/generics/bridges/tests/TestClassAndInterfaceBridgeIdentical02.java + test/tools/javac/generics/bridges/tests/TestNoBridgeInSiblingsSuper.java + test/tools/javac/generics/bridges/tests/TestNoDuplicateBridges01.java + test/tools/javac/generics/bridges/tests/TestNoDuplicateBridges02.java + test/tools/javac/lambda/bridge/TestMetafactoryBridges.java ! test/tools/javac/lambda/lambdaExpression/LambdaTest6.java ! test/tools/javac/lambda/methodReference/BridgeMethod.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java From jonathan.gibbons at oracle.com Wed Jul 17 00:06:36 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 16 Jul 2013 17:06:36 -0700 Subject: Fwd: Heads up: Integrating lambda-related changes into jdk8/jdk8 In-Reply-To: <51E5A20C.6030604@oracle.com> References: <51E5A20C.6030604@oracle.com> Message-ID: <51E5E00C.1040307@oracle.com> Build folk, Is there a way we could put a file in each repo containing the ids of the minimum required changeset of other repos? It would then surely be a simple consistency check to verify that all the repos involved in a build meet the minimum level of functionality. -- Jon -------- Original Message -------- Subject: Heads up: Integrating lambda-related changes into jdk8/jdk8 Date: Tue, 16 Jul 2013 13:42:04 -0600 From: Alejandro E Murillo Organization: Oracle Corporation To: jdk8-dev at openjdk.java.net Later today I plan to push the hs25-b41 snapshot into jdk8 master [1] , along with the fix for 8016281 . This push includes lambda-related changes that will create lambda-related incompatibilities with class files compiled with earlier JDK 8 versions. See [2] for more details. Once the changes have been integrated, the hotspot, langtools and jdk repos must match - i.e., either all must have these changes or not have any of them. A JDK with mismatched repos may build, but some lambda-related functionality might not work properly (again, see [2] for details of the symptoms). After we integrate, If you do pull, make sure to pull all: hotspot, langtools and jdk, and to build all [1] http://hg.openjdk.java.net/jdk8/jdk8/ [2] http://mail.openjdk.java.net/pipermail/lambda-dev/2013-July/010449.html Thanks -- Alejandro From maurizio.cimadamore at oracle.com Wed Jul 17 18:29:25 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 17 Jul 2013 18:29:25 +0000 Subject: hg: jdk8/build/langtools: 8013638: Few policy tests are failing in Lambda nightly Message-ID: <20130717182929.0223E48160@hg.openjdk.java.net> Changeset: 6d85acab769e Author: mcimadamore Date: 2013-07-17 19:28 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6d85acab769e 8013638: Few policy tests are failing in Lambda nightly Summary: BridgeHarness test is leaving files open Reviewed-by: ksrini ! test/tools/javac/generics/bridges/BridgeHarness.java From mike.duigou at oracle.com Thu Jul 18 00:13:27 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 17 Jul 2013 17:13:27 -0700 Subject: Help with using jtreg to verify build needed In-Reply-To: References: Message-ID: <26A11A2B-4E8A-4CB5-A68D-892C1213BB18@oracle.com> I have created JDK-8019481 to improve detection of jtreg located on the path. Jon's advice about getting a more recent version of jtreg than what ubuntu provides almost certainly applies as well. Mike On Jul 8 2013, at 22:59 , Matthew Butner wrote: > Not sure if this is the right place to ask or not, and if it isn't, please > direct me to the correct forum but I have been trying all day to use jtreg > to test my jdk 1.8 build with no success. > > Here is my problem: > I am running ubuntu and have used the apt center to install jtreg. This > means that jtreg and jtdiff are installed under /usr/bin. When I run the > configure script it does not automatically detect jtreg and when I try > running it with the --with-jtreg=/usr/bin/jtreg or /usr/bin it fails > because it is trying to find the executable inside subdirectories that do > not exist because I did not install jtreg from source. > > I tried to work around this by modifying line 16463 > JTREGEXE="$JT_HOME/win32/bin/jtreg" > to > JTREGEXE="$JT_HOME/jtreg" > > which made it detect jtreg but the command in the readme > *cd test && make PRODUCT_HOME=`pwd`/../build/*/images/j2sdk-image all > > *still fails because it is still trying to look in > /usr/bin/win32/bin/jtreg > > and win32/bin/jtreg does not exist. > > Any help would be greatly welcome but if possible I don't want to have to > install jtreg from source as that is a whole other can of worms. > > Thank you, > Matthew From mfbutner at ucdavis.edu Thu Jul 18 05:28:18 2013 From: mfbutner at ucdavis.edu (Matthew Butner) Date: Wed, 17 Jul 2013 22:28:18 -0700 Subject: Help with using jtreg to verify build needed In-Reply-To: <26A11A2B-4E8A-4CB5-A68D-892C1213BB18@oracle.com> References: <26A11A2B-4E8A-4CB5-A68D-892C1213BB18@oracle.com> Message-ID: Thanks for that, and I did have to get a newer version of jtreg. I was able to find a binary here http://download.java.net/openjdk/jtreg/ which saved me the trouble of having to build it from source. On Wed, Jul 17, 2013 at 5:13 PM, Mike Duigou wrote: > I have created JDK-8019481 to improve detection of jtreg located on the > path. > > Jon's advice about getting a more recent version of jtreg than what ubuntu > provides almost certainly applies as well. > > Mike > > On Jul 8 2013, at 22:59 , Matthew Butner wrote: > > > Not sure if this is the right place to ask or not, and if it isn't, > please > > direct me to the correct forum but I have been trying all day to use > jtreg > > to test my jdk 1.8 build with no success. > > > > Here is my problem: > > I am running ubuntu and have used the apt center to install jtreg. This > > means that jtreg and jtdiff are installed under /usr/bin. When I run the > > configure script it does not automatically detect jtreg and when I try > > running it with the --with-jtreg=/usr/bin/jtreg or /usr/bin it fails > > because it is trying to find the executable inside subdirectories that do > > not exist because I did not install jtreg from source. > > > > I tried to work around this by modifying line 16463 > > JTREGEXE="$JT_HOME/win32/bin/jtreg" > > to > > JTREGEXE="$JT_HOME/jtreg" > > > > which made it detect jtreg but the command in the readme > > *cd test && make PRODUCT_HOME=`pwd`/../build/*/images/j2sdk-image all > > > > *still fails because it is still trying to look in > > /usr/bin/win32/bin/jtreg > > > > and win32/bin/jtreg does not exist. > > > > Any help would be greatly welcome but if possible I don't want to have to > > install jtreg from source as that is a whole other can of worms. > > > > Thank you, > > Matthew > > From jonathan.gibbons at oracle.com Thu Jul 18 14:26:32 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 18 Jul 2013 07:26:32 -0700 Subject: Help with using jtreg to verify build needed In-Reply-To: References: <26A11A2B-4E8A-4CB5-A68D-892C1213BB18@oracle.com> Message-ID: <51E7FB18.5060407@oracle.com> Matthew, I would strongly recommend taking the trouble to build jtreg from the latest source. -- Jon On 07/17/2013 10:28 PM, Matthew Butner wrote: > Thanks for that, and I did have to get a newer version of jtreg. I was able > to find a binary here http://download.java.net/openjdk/jtreg/ which saved > me the trouble of having to build it from source. > > > On Wed, Jul 17, 2013 at 5:13 PM, Mike Duigou wrote: > >> I have created JDK-8019481 to improve detection of jtreg located on the >> path. >> >> Jon's advice about getting a more recent version of jtreg than what ubuntu >> provides almost certainly applies as well. >> >> Mike >> >> On Jul 8 2013, at 22:59 , Matthew Butner wrote: >> >>> Not sure if this is the right place to ask or not, and if it isn't, >> please >>> direct me to the correct forum but I have been trying all day to use >> jtreg >>> to test my jdk 1.8 build with no success. >>> >>> Here is my problem: >>> I am running ubuntu and have used the apt center to install jtreg. This >>> means that jtreg and jtdiff are installed under /usr/bin. When I run the >>> configure script it does not automatically detect jtreg and when I try >>> running it with the --with-jtreg=/usr/bin/jtreg or /usr/bin it fails >>> because it is trying to find the executable inside subdirectories that do >>> not exist because I did not install jtreg from source. >>> >>> I tried to work around this by modifying line 16463 >>> JTREGEXE="$JT_HOME/win32/bin/jtreg" >>> to >>> JTREGEXE="$JT_HOME/jtreg" >>> >>> which made it detect jtreg but the command in the readme >>> *cd test && make PRODUCT_HOME=`pwd`/../build/*/images/j2sdk-image all >>> >>> *still fails because it is still trying to look in >>> /usr/bin/win32/bin/jtreg >>> >>> and win32/bin/jtreg does not exist. >>> >>> Any help would be greatly welcome but if possible I don't want to have to >>> install jtreg from source as that is a whole other can of worms. >>> >>> Thank you, >>> Matthew >> From david.katleman at oracle.com Tue Jul 23 18:53:54 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 18:53:54 +0000 Subject: hg: jdk8/build: Added tag jdk8-b99 for changeset 59dc9da81379 Message-ID: <20130723185355.1EB9C482B1@hg.openjdk.java.net> Changeset: d2dcb110e9db Author: cl Date: 2013-07-18 03:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/d2dcb110e9db Added tag jdk8-b99 for changeset 59dc9da81379 ! .hgtags From david.katleman at oracle.com Tue Jul 23 18:53:59 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 18:53:59 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b99 for changeset 3f67804ab613 Message-ID: <20130723185359.E8ADA482B2@hg.openjdk.java.net> Changeset: 8d492f1dfd1b Author: cl Date: 2013-07-18 03:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/8d492f1dfd1b Added tag jdk8-b99 for changeset 3f67804ab613 ! .hgtags From david.katleman at oracle.com Tue Jul 23 18:54:21 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 18:54:21 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b99 for changeset 81b6cb70717c Message-ID: <20130723185423.18EDA482B3@hg.openjdk.java.net> Changeset: bb416ee2a79b Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bb416ee2a79b Added tag jdk8-b99 for changeset 81b6cb70717c ! .hgtags From david.katleman at oracle.com Tue Jul 23 18:55:21 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 18:55:21 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b99 for changeset 8ef83d4b23c9 Message-ID: <20130723185523.6C4B0482B5@hg.openjdk.java.net> Changeset: 4fd722afae5c Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/4fd722afae5c Added tag jdk8-b99 for changeset 8ef83d4b23c9 ! .hgtags From david.katleman at oracle.com Tue Jul 23 18:55:05 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 18:55:05 +0000 Subject: hg: jdk8/build/jaxp: 5 new changesets Message-ID: <20130723185516.846E3482B4@hg.openjdk.java.net> Changeset: 043da456d316 Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/043da456d316 Added tag jdk8-b99 for changeset adf49c3ef83c ! .hgtags Changeset: 3b071f506ab9 Author: joehw Date: 2013-07-09 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/3b071f506ab9 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown Summary: jaxp 1.5 feature update Reviewed-by: alanb, dfuchs, lancea ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java + src/com/sun/org/apache/xalan/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/DOMParser.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java + src/com/sun/org/apache/xerces/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: aabe15fc346f Author: joehw Date: 2013-07-12 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/aabe15fc346f 8020430: NullPointerException in xml sqe nightly result on 2013-07-12 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java Changeset: 74ec7b48e3be Author: lana Date: 2013-07-17 00:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/74ec7b48e3be Merge Changeset: 5d1974c1d7b9 Author: lana Date: 2013-07-22 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/5d1974c1d7b9 Merge From david.katleman at oracle.com Tue Jul 23 18:58:24 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 18:58:24 +0000 Subject: hg: jdk8/build/jdk: 86 new changesets Message-ID: <20130723191610.6E129482B7@hg.openjdk.java.net> Changeset: 9b6070690e50 Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9b6070690e50 Added tag jdk8-b99 for changeset 6a099a36589b ! .hgtags Changeset: cacfc77655c8 Author: serb Date: 2013-07-03 19:00 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cacfc77655c8 8004859: Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform Reviewed-by: prr, flar ! src/share/classes/sun/java2d/SunGraphics2D.java + test/java/awt/Graphics2D/Test8004859/Test8004859.java Changeset: 75844b444879 Author: jchen Date: 2013-07-03 10:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/75844b444879 8014497: [parfait] Potential null pointer dereference in jdk/src/share/native/sun/java2d/cmm/lcms/cmsgamma.c Reviewed-by: bae, prr ! src/share/native/sun/java2d/cmm/lcms/cmsopt.c Changeset: d32757b7060c Author: lana Date: 2013-07-05 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d32757b7060c Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: dead66347eca Author: jgodinez Date: 2013-07-10 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dead66347eca 8016737: After clicking on "Print UNCOLLATED" button, the print out come in order 'Page 1', 'Page 2', 'Page 1' Reviewed-by: jchen, prr ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: fabcccc003d2 Author: lana Date: 2013-07-17 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fabcccc003d2 Merge Changeset: f41758d12409 Author: alitvinov Date: 2013-07-04 16:06 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f41758d12409 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java ! src/solaris/native/sun/awt/awt_util.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c Changeset: 523815540788 Author: lana Date: 2013-07-05 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/523815540788 Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: b7cbad879d63 Author: leonidr Date: 2013-07-08 19:47 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b7cbad879d63 8019265: [macosx] apple.laf.useScreenMenuBar regression comparing with jdk6 Reviewed-by: anthony ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 7e291fc61cad Author: malenkov Date: 2013-07-09 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7e291fc61cad 6707231: Wrong read Method returned for boolen properties Reviewed-by: alexsch ! src/share/classes/java/beans/Introspector.java + test/java/beans/Introspector/Test6707231.java Changeset: e7ca6e259dc2 Author: serb Date: 2013-07-09 21:21 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e7ca6e259dc2 8019587: [macosx] Possibility to set the same frame for the different screens Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java + test/java/awt/GraphicsDevice/IncorrectDisplayModeExitFullscreen.java Changeset: 46826d248616 Author: pchelko Date: 2013-07-11 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/46826d248616 8020210: [macosx] JVM crashes in CWrapper$NSWindow.screen(long) Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/Window/MaximizeOffscreen/MaximizeOffscreenTest.java Changeset: c566daef4877 Author: leonidr Date: 2013-07-11 18:23 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c566daef4877 8020038: [macosx] Incorrect usage of invokeLater() and likes in callbacks called via JNI from AppKit thread Reviewed-by: art, anthony ! src/macosx/classes/com/apple/eawt/FullScreenHandler.java ! src/macosx/classes/com/apple/eawt/_AppEventHandler.java ! src/macosx/classes/com/apple/eawt/event/GestureHandler.java ! src/macosx/classes/com/apple/laf/ScreenMenu.java ! src/macosx/classes/sun/lwawt/macosx/CCheckboxMenuItem.java ! src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java Changeset: c3268a602a50 Author: raginip Date: 2013-07-12 14:46 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c3268a602a50 8009168: accessibility.properties syntax issue Reviewed-by: ptbrunet, mfang, alexsch ! src/share/classes/com/sun/accessibility/internal/resources/accessibility.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_de.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_es.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_fr.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_it.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ko.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_sv.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_TW.properties ! src/share/classes/javax/accessibility/AccessibleAction.java Changeset: f7ea38893138 Author: serb Date: 2013-07-12 21:33 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f7ea38893138 8020298: [macosx] Incorrect merge in the lwawt code Reviewed-by: art, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: d52fc9384765 Author: pchelko Date: 2013-07-15 12:06 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d52fc9384765 8020371: [macosx] applets with Drag and Drop fail with IllegalArgumentException Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/classes/sun/lwawt/macosx/CDropTarget.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 0967103c1b65 Author: malenkov Date: 2013-07-15 17:33 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0967103c1b65 8017492: Static field in HTML parser affects all applications Reviewed-by: art ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/Element.java + test/javax/swing/text/html/parser/Test8017492.java Changeset: 15ea601e707a Author: lana Date: 2013-07-17 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/15ea601e707a Merge Changeset: cf7202b32a34 Author: mchung Date: 2013-07-02 15:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf7202b32a34 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which) Reviewed-by: jrose, alanb, dfuchs ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/reflect/Member.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java + test/java/lang/invoke/TestPrivateMember.java Changeset: dfd7fb0ce54b Author: psandoz Date: 2013-07-03 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dfd7fb0ce54b 8011427: java.util.concurrent collection Spliterator implementations Reviewed-by: martin Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/BlockingDeque.java ! src/share/classes/java/util/concurrent/BlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/Delayed.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java Changeset: bb4ae17c98cf Author: psandoz Date: 2013-07-03 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb4ae17c98cf 8019481: Sync misc j.u.c classes from 166 to tl Reviewed-by: martin Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/BrokenBarrierException.java ! src/share/classes/java/util/concurrent/CountDownLatch.java ! src/share/classes/java/util/concurrent/CyclicBarrier.java ! src/share/classes/java/util/concurrent/Exchanger.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/TimeUnit.java ! src/share/classes/java/util/concurrent/TimeoutException.java ! src/share/classes/java/util/concurrent/package-info.java Changeset: bd6949f9dbb2 Author: twisti Date: 2013-07-03 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bd6949f9dbb2 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java + test/java/lang/invoke/TestCatchExceptionWithVarargs.java Changeset: 7532bb2d6476 Author: psandoz Date: 2013-07-03 21:19 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7532bb2d6476 8017329: 8b92-lambda regression: TreeSet("a", "b").stream().substream(1).parallel().iterator() is empty Reviewed-by: alanb ! src/share/classes/java/util/stream/SliceOps.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java Changeset: d5de500c99a3 Author: juh Date: 2013-07-03 12:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d5de500c99a3 8019772: Fix doclint issues in javax.crypto and javax.security subpackages Reviewed-by: darcy ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherInputStream.java ! src/share/classes/javax/crypto/ExemptionMechanism.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/NullCipher.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: e594ee7a7c2f Author: vinnie Date: 2013-07-02 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e594ee7a7c2f 7165807: Non optimized initialization of NSS crypto library leads to scalability issues Reviewed-by: mullan, valeriep ! make/sun/security/pkcs11/mapfile-vers ! makefiles/mapfiles/libj2pkcs11/mapfile-vers ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/share/native/sun/security/pkcs11/j2secmod.c ! src/solaris/native/sun/security/pkcs11/j2secmod_md.h ! src/windows/native/sun/security/pkcs11/j2secmod_md.h Changeset: cbee2e595600 Author: vinnie Date: 2013-07-03 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cbee2e595600 Merge Changeset: a49208237599 Author: bpb Date: 2013-07-03 13:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a49208237599 8019857: Fix doclint errors in java.util.Format* Summary: Fix doclint errors in java.util.Format*. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formattable.java ! src/share/classes/java/util/Formatter.java Changeset: a8f51c3341a5 Author: emc Date: 2013-07-03 19:47 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a8f51c3341a5 8016285: Add java.lang.reflect.Parameter.isNamePresent() Summary: Add isNamePresent method to parameter reflection library, which indicates whether or real parameter data is available Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Parameter.java ! test/java/lang/reflect/Parameter/WithParameters.java ! test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: 043b2eb76b0e Author: bpb Date: 2013-07-03 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/043b2eb76b0e 8019862: Fix doclint errors in java.lang.*. Summary: Fix doclint errors in java.lang.* Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/lang/CharSequence.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/ProcessBuilder.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadLocal.java Changeset: dd69273a0240 Author: alanb Date: 2013-07-04 14:38 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dd69273a0240 8019622: (sl) ServiceLoader.next incorrect when creation and usages are in different contexts Reviewed-by: mchung, ahgross, forax, psandoz ! src/share/classes/java/util/ServiceLoader.java Changeset: aa9fefb5d9c4 Author: alanb Date: 2013-07-04 20:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/aa9fefb5d9c4 8017231: Add StringJoiner.merge Reviewed-by: psandoz, alanb Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/StringJoiner.java + test/java/util/StringJoiner/MergeTest.java ! test/java/util/StringJoiner/StringJoinerTest.java Changeset: ed111451b77a Author: zhangshj Date: 2013-07-05 10:51 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ed111451b77a 8019381: HashMap.isEmpty is non-final, potential issues for get/remove Reviewed-by: chegar, mduigou ! src/share/classes/java/util/HashMap.java + test/java/util/HashMap/OverrideIsEmpty.java Changeset: 028ef97797c1 Author: mullan Date: 2013-07-05 15:54 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/028ef97797c1 8011547: Update XML Signature implementation to Apache Santuario 1.5.4 Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/Algorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/JCEMapper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/MessageDigestAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithmSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureDSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizationException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizerSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/InvalidCanonicalizerException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/AttrCompare.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/C14nHelper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11_OmitComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11_WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315Excl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315ExclOmitComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315ExclWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315OmitComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java + src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerPhysical.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/NameSpaceSymbTable.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/UtfHelpper.java + src/share/classes/com/sun/org/apache/xml/internal/security/encryption/AbstractSerializer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/AgreementMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherReference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherValue.java + src/share/classes/com/sun/org/apache/xml/internal/security/encryption/DocumentSerializer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedKey.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedType.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperties.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperty.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/ReferenceList.java + src/share/classes/com/sun/org/apache/xml/internal/security/encryption/Serializer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/Transforms.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherParameters.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLEncryptionException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/AlgorithmAlreadyRegisteredException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/Base64DecodingException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/XMLSecurityException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/XMLSecurityRuntimeException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/ContentHandlerAlreadyRegisteredException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyUtils.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/DEREncodedKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyInfoContent.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyInfoReference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyName.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/MgmtData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/PGPData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/RetrievalMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/SPKIData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/X509Data.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/DSAKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/KeyValueContent.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/RSAKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509CRL.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509Certificate.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509DataContent.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509Digest.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509IssuerSerial.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SubjectName.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/InvalidKeyResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverSpi.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/DEREncodedKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/DSAKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/EncryptedKeyResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/KeyInfoReferenceResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/PrivateKeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RSAKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RetrievalMethodResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/SecretKeyResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/SingleKeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509CertificateResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509DigestResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509IssuerSerialResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509SKIResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509SubjectNameResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/KeyStoreResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/SingleCertificateResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_en.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/InvalidDigestValueException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/InvalidSignatureValueException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Manifest.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/MissingResourceFailureException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/NodeFilter.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ObjectContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ReferenceNotInitializedException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperties.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperty.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignedInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInputDebugger.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceData.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceNodeSetData.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceOctetStreamData.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceSubTreeData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/InvalidTransformException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformParam.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformationException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transforms.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHere.java - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N11.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N11_WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NExclusive.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NExclusiveWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformEnvelopedSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath2Filter.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPointer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXSLT.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/InclusiveNamespaces.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPath2FilterContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPath2FilterContainer04.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathFilterCHGPContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/ClassLoaderUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Constants.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/DOMNamespaceContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/DigesterOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementChecker.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/HelperNodeList.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IgnoreAllErrorHandler.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/JDKXPathAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/JDKXPathFactory.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/JavaUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/Signature11ElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignatureElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignerOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncBufferedOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncByteArrayOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFactory.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XalanXPathAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XalanXPathFactory.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverAnonymous.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverFragment.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverLocalFilesystem.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverXPointer.java ! src/share/classes/org/jcp/xml/dsig/internal/DigesterOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/MacOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/SignerOutputStream.java + src/share/classes/org/jcp/xml/dsig/internal/dom/AbstractDOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheNodeSetData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMBase64Transform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14N11Method.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalizationMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java Changeset: e3208dbf6926 Author: mullan Date: 2013-07-05 16:30 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e3208dbf6926 Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: 49c5547d9e8e Author: lana Date: 2013-07-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/49c5547d9e8e Merge Changeset: 4fcabe8e22ce Author: lana Date: 2013-07-05 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4fcabe8e22ce Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java Changeset: 11c15607e43f Author: wetmore Date: 2013-07-05 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/11c15607e43f 8019341: Update CookieHttpsClientTest to use the newer framework. Reviewed-by: xuelei, smarks, michaelm ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java ! test/sun/security/ssl/templates/SSLEngineTemplate.java ! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java ! test/sun/security/ssl/templates/SSLSocketTemplate.java Changeset: 715d00c95fb2 Author: ehelin Date: 2013-07-08 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/715d00c95fb2 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/MemoryTest.java Changeset: 52454985425d Author: juh Date: 2013-07-08 19:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/52454985425d 8020091: Fix HTML doclint issues in java.io Reviewed-by: darcy ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/InputStreamReader.java ! src/share/classes/java/io/OutputStreamWriter.java ! src/share/classes/java/io/PipedInputStream.java ! src/share/classes/java/io/RandomAccessFile.java Changeset: eab8f4e29f5e Author: darcy Date: 2013-07-08 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eab8f4e29f5e 8020095: Fix doclint warnings in java.util.regex Reviewed-by: mchung ! src/share/classes/java/util/regex/MatchResult.java ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java Changeset: 628432ee4d68 Author: henryjen Date: 2013-07-09 09:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/628432ee4d68 8017141: java.util/stream Spliterators from sequential sources should not catch OOME Reviewed-by: mchung Contributed-by: paul.sandoz at oracle.com ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Spliterators.java Changeset: 44a634c1edc4 Author: psandoz Date: 2013-07-09 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/44a634c1edc4 8019551: Make BaseStream public Reviewed-by: chegar, psandoz Contributed-by: brian goetz ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/BaseStream.java Changeset: 43134e79c0bb Author: psandoz Date: 2013-07-09 16:04 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/43134e79c0bb 8019370: Sync j.u.c Fork/Join from 166 to tl Reviewed-by: chegar, martin Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/AbstractExecutorService.java ! src/share/classes/java/util/concurrent/Callable.java ! src/share/classes/java/util/concurrent/CancellationException.java ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/share/classes/java/util/concurrent/CompletionService.java ! src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ExecutionException.java ! src/share/classes/java/util/concurrent/Executor.java ! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/Future.java ! src/share/classes/java/util/concurrent/FutureTask.java ! src/share/classes/java/util/concurrent/RecursiveAction.java ! src/share/classes/java/util/concurrent/RecursiveTask.java ! src/share/classes/java/util/concurrent/RejectedExecutionException.java ! src/share/classes/java/util/concurrent/RunnableFuture.java ! src/share/classes/java/util/concurrent/RunnableScheduledFuture.java ! src/share/classes/java/util/concurrent/ScheduledExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java Changeset: 83c2976ef8ee Author: coffeys Date: 2013-07-09 16:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/83c2976ef8ee 8019979: Replace CheckPackageAccess test with better one from closed repo Reviewed-by: mullan ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 7bb17aa9a09f Author: dholmes Date: 2013-07-09 22:01 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7bb17aa9a09f 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently Summary: Ensure WeakRef object can't be prematurely gc'd Reviewed-by: chegar, plevart ! test/java/lang/ref/OOMEInReferenceHandler.java Changeset: 780a64979c8d Author: weijun Date: 2013-07-10 15:11 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/780a64979c8d 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 Reviewed-by: mullan ! src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.java ! test/sun/security/krb5/auto/SaslGSS.java Changeset: ff5df05222d1 Author: psandoz Date: 2013-07-10 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ff5df05222d1 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries Reviewed-by: briangoetz ! src/share/classes/java/util/Collections.java + test/java/util/Collections/UnmodifiableMapEntrySet.java Changeset: 882baa1e0a38 Author: psandoz Date: 2013-07-10 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/882baa1e0a38 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees Reviewed-by: briangoetz Contributed-by: doug lea
, paul sandoz ! src/share/classes/java/util/stream/AbstractShortCircuitTask.java ! src/share/classes/java/util/stream/AbstractTask.java ! src/share/classes/java/util/stream/ForEachOps.java ! src/share/classes/java/util/stream/Nodes.java Changeset: 7c44ea602cc8 Author: darcy Date: 2013-07-10 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7c44ea602cc8 8020294: Fix doclint issues in java.util.Spliterator Reviewed-by: psandoz ! src/share/classes/java/util/Spliterator.java Changeset: 607fa1ff3de2 Author: bpb Date: 2013-07-09 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/607fa1ff3de2 6178739: (fmt) Formatter.format("%0.4f\n", 56789.456789) generates MissingFormatWidthException Summary: Change the field width specification to require a positive value. The exception is still thrown but that is now explicitly consistent with the specification. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formatter.java Changeset: 2ee772cda1d6 Author: bpb Date: 2013-07-09 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2ee772cda1d6 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself ("0.0") Summary: Make stripTrailingZeros() return BigDecimal.ZERO if the BigDecimal is numerically equal to zero. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigDecimal.java ! test/java/math/BigDecimal/StrippingZerosTest.java Changeset: 69d9fe8175a0 Author: sspitsyn Date: 2013-07-10 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/69d9fe8175a0 8020308: Fix doclint issues in java.lang.management Reviewed-by: darcy Contributed-by: serguei.spitsyn at oracle.com ! src/share/classes/java/lang/management/LockInfo.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/MemoryMXBean.java ! src/share/classes/java/lang/management/MemoryNotificationInfo.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/MemoryUsage.java ! src/share/classes/java/lang/management/MonitorInfo.java ! src/share/classes/java/lang/management/RuntimeMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java Changeset: 702556f7977e Author: juh Date: 2013-07-10 18:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/702556f7977e 8020318: Fix doclint issues in java.net Reviewed-by: darcy, khazra ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/ProtocolFamily.java ! src/share/classes/java/net/SocketOption.java ! src/share/classes/java/net/URI.java Changeset: a46982a212e0 Author: jbachorik Date: 2013-07-11 09:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a46982a212e0 8019826: Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE Reviewed-by: sjiang, dholmes, mchung ! test/com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java Changeset: 05b164788aab Author: psandoz Date: 2013-07-11 13:07 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/05b164788aab 8019484: Sync j.u.c.ConcurrentHashMap from 166 to tl Reviewed-by: martin Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java Changeset: dadcfd84d33f Author: sundar Date: 2013-07-11 18:50 +0530 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dadcfd84d33f 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error Reviewed-by: mcimadamore, jlaskey, hannesw, attila ! src/share/classes/javax/script/ScriptEngineFactory.java Changeset: 162c015c434a Author: valeriep Date: 2013-07-11 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/162c015c434a 8020321: Problem in PKCS11 regression test TestRSAKeyLength Summary: Corrected the "isValidKeyLength" array Reviewed-by: xuelei ! test/sun/security/pkcs11/Signature/TestRSAKeyLength.java Changeset: f3211af79339 Author: jbachorik Date: 2013-07-11 21:11 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f3211af79339 8010285: Enforce the requirement of Management Interfaces being public Reviewed-by: sjiang, dfuchs, mchung ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanAnalyzer.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/package.html ! src/share/classes/sun/management/ManagementFactoryHelper.java + test/javax/management/MBeanServer/MBeanFallbackTest.java + test/javax/management/MBeanServer/MBeanTest.java + test/javax/management/mxbean/MXBeanFallbackTest.java ! test/javax/management/mxbean/MXBeanTest.java + test/javax/management/proxy/JMXProxyFallbackTest.java + test/javax/management/proxy/JMXProxyTest.java Changeset: 0bd48087e2dc Author: ksrini Date: 2013-07-11 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0bd48087e2dc 8019799: api/java_util/jar/Pack200 test failed with compactX profiles. Reviewed-by: dholmes ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java Changeset: 10d2a4b1e576 Author: dxu Date: 2013-07-11 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/10d2a4b1e576 8017212: File.createTempFile requires unnecessary "read" permission Summary: Directly call FileSystem method to check a file existence. Also reviewed by tom.hawtin at oracle.com Reviewed-by: alanb ! src/share/classes/java/io/File.java + test/java/io/File/CheckPermission.java ! test/java/io/File/NulFile.java ! test/java/io/File/createTempFile/SpecialTempFile.java Changeset: f225da733291 Author: valeriep Date: 2013-07-05 13:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f225da733291 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode Summary: Ensure the Cipher.doFinal() is called only once Reviewed-by: xuelei ! src/share/classes/javax/crypto/CipherInputStream.java + test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCM.java Changeset: 6e2a5637b286 Author: valeriep Date: 2013-07-05 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6e2a5637b286 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful Summary: Check equality based on component values instead of encoding which may vary due to optional components Reviewed-by: weijun ! src/share/classes/com/sun/crypto/provider/DHKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/share/classes/com/sun/crypto/provider/DHPublicKey.java ! src/share/classes/sun/security/pkcs11/P11Key.java Changeset: f321b78c7009 Author: ascarpino Date: 2013-07-08 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f321b78c7009 6755701: SunJCE DES/DESede SecretKeyFactory.generateSecret throws InvalidKeySpecExc if passed SecretKeySpec Reviewed-by: valeriep, wetmore, xuelei ! src/share/classes/com/sun/crypto/provider/DESKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyFactory.java + test/com/sun/crypto/provider/Cipher/DES/DESSecretKeySpec.java Changeset: 869bfa39d923 Author: valeriep Date: 2013-07-08 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/869bfa39d923 Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java Changeset: 4fcac826628c Author: valeriep Date: 2013-07-09 15:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4fcac826628c Merge Changeset: 7bd2993e03fa Author: valeriep Date: 2013-07-10 18:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7bd2993e03fa 8020310: JDK-6356530 broke the old build Summary: Add serialVersionUID to AuthProvider and P11Key class. Reviewed-by: xuelei ! src/share/classes/java/security/AuthProvider.java ! src/share/classes/sun/security/pkcs11/P11Key.java Changeset: 4c95c032c395 Author: valeriep Date: 2013-07-11 17:52 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4c95c032c395 Merge Changeset: 858c75eb83b5 Author: mchung Date: 2013-07-08 14:05 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/858c75eb83b5 8014890: (ref) Reference queues may return more entries than expected Summary: When enqueuing references check whether the j.l.r.Reference has already been enqeued or removed in the lock. Do not enqueue them again. This occurs because multiple threads may try to enqueue the same j.l.r.Reference at the same time. Reviewed-by: mchung, dholmes, plevart, shade Contributed-by: thomas.schatzl at oracle.com ! src/share/classes/java/lang/ref/Reference.java ! src/share/classes/java/lang/ref/ReferenceQueue.java + test/java/lang/ref/EnqueuePollRace.java Changeset: 2504f01bc83f Author: joehw Date: 2013-07-12 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2504f01bc83f 8020430: NullPointerException in xml sqe nightly result on 2013-07-12 Reviewed-by: chegar, lancea + test/javax/xml/jaxp/common/8020430/JAXP15RegTest.java + test/javax/xml/jaxp/common/8020430/TestBase.java Changeset: af62c6175f92 Author: darcy Date: 2013-07-12 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/af62c6175f92 8010679: Clarify "present" and annotation ordering in Core Reflection for Annotations Reviewed-by: abuckley, jfranck ! src/share/classes/java/lang/reflect/AnnotatedElement.java Changeset: fe6e4e2c367d Author: mduigou Date: 2013-07-12 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fe6e4e2c367d 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks ! src/share/classes/java/util/AbstractMap.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/NavigableSet.java ! test/java/util/Collection/MOAT.java ! test/java/util/Collections/CheckedIdentityMap.java ! test/java/util/Collections/CheckedMapBash.java ! test/java/util/Collections/CheckedSetBash.java ! test/java/util/Collections/EmptyCollectionSerialization.java + test/java/util/Collections/EmptyNavigableMap.java + test/java/util/Collections/EmptyNavigableSet.java - test/java/util/Collections/EmptySortedSet.java ! test/java/util/Map/LockStep.java ! test/java/util/NavigableMap/LockStep.java Changeset: 623a10b23ed8 Author: mduigou Date: 2013-07-12 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/623a10b23ed8 8015317: Optional.filter, map, and flatMap Reviewed-by: psandoz, mduigou Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/Optional.java ! src/share/classes/java/util/OptionalDouble.java ! src/share/classes/java/util/OptionalInt.java ! src/share/classes/java/util/OptionalLong.java ! test/java/util/Optional/Basic.java Changeset: 06749efce430 Author: mduigou Date: 2013-07-12 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/06749efce430 8015315: Stream.concat methods Reviewed-by: psandoz, mduigou Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ConcatOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ConcatTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java Changeset: 5b6f94559589 Author: mduigou Date: 2013-07-12 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5b6f94559589 Merge - test/java/util/Collections/EmptySortedSet.java Changeset: be096613bfb5 Author: psandoz Date: 2013-07-03 21:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/be096613bfb5 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method Reviewed-by: henryjen, briangoetz ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/lang/CharSequence.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSupport.java ! src/share/classes/java/util/stream/Streams.java ! src/share/classes/java/util/zip/ZipFile.java ! test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/TestData.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java Changeset: b3ca5fb77e2c Author: vinnie Date: 2013-07-12 20:44 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b3ca5fb77e2c 8019627: RuntimeException gets obscured during OCSP cert revocation checking Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! test/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java Changeset: 9b17939958e7 Author: henryjen Date: 2013-07-12 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9b17939958e7 8015320: Pull spliterator() up from Collection to Iterable Reviewed-by: psandoz, mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/ConcurrentModificationException.java ! test/java/util/Spliterator/SpliteratorCollisions.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java Changeset: 37c37361a7ad Author: henryjen Date: 2013-07-08 15:46 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/37c37361a7ad 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces Reviewed-by: psandoz, mduigou Contributed-by: brian goetz ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java - src/share/classes/java/util/stream/StreamBuilder.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java Changeset: 5f2a8db78aca Author: weijun Date: 2013-07-13 08:47 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5f2a8db78aca 8019410: sun/security/krb5/auto/ReplayCacheTestProc.java Reviewed-by: mullan ! test/sun/security/krb5/auto/ReplayCacheTestProc.java Changeset: e4ce6502eac0 Author: plevart Date: 2013-07-15 10:55 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e4ce6502eac0 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations Reviewed-by: dholmes, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/reflect/annotation/AnnotationType.java + test/java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java + test/java/lang/annotation/AnnotationType/AnnotationTypeRuntimeAssumptionTest.java Changeset: 7cc35dd1885d Author: coffeys Date: 2013-07-15 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7cc35dd1885d 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl Reviewed-by: mchung ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 94e1a4b10811 Author: bpb Date: 2013-07-15 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/94e1a4b10811 8020409: Clean up doclint problems in java.util package, part 1 Summary: Clean up doclint problems in java.util package, part 1 Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/EnumSet.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/ResourceBundle.java Changeset: f7af15e2c95b Author: juh Date: 2013-07-16 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f7af15e2c95b 8020557: javadoc cleanup in javax.security Reviewed-by: darcy ! src/share/classes/javax/security/auth/AuthPermission.java ! src/share/classes/javax/security/auth/DestroyFailedException.java ! src/share/classes/javax/security/auth/Destroyable.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/RefreshFailedException.java ! src/share/classes/javax/security/auth/Refreshable.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/security/auth/SubjectDomainCombiner.java ! src/share/classes/javax/security/auth/callback/Callback.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/callback/ChoiceCallback.java ! src/share/classes/javax/security/auth/callback/ConfirmationCallback.java ! src/share/classes/javax/security/auth/callback/LanguageCallback.java ! src/share/classes/javax/security/auth/callback/NameCallback.java ! src/share/classes/javax/security/auth/callback/PasswordCallback.java ! src/share/classes/javax/security/auth/callback/TextInputCallback.java ! src/share/classes/javax/security/auth/callback/TextOutputCallback.java ! src/share/classes/javax/security/auth/callback/UnsupportedCallbackException.java + src/share/classes/javax/security/auth/callback/package-info.java - src/share/classes/javax/security/auth/callback/package.html ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/KerberosKey.java ! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java ! src/share/classes/javax/security/auth/kerberos/KerberosTicket.java ! src/share/classes/javax/security/auth/kerberos/KeyImpl.java ! src/share/classes/javax/security/auth/kerberos/KeyTab.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java + src/share/classes/javax/security/auth/kerberos/package-info.java - src/share/classes/javax/security/auth/kerberos/package.html ! src/share/classes/javax/security/auth/login/AccountExpiredException.java ! src/share/classes/javax/security/auth/login/AppConfigurationEntry.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/ConfigurationSpi.java ! src/share/classes/javax/security/auth/login/CredentialExpiredException.java ! src/share/classes/javax/security/auth/login/FailedLoginException.java ! src/share/classes/javax/security/auth/login/LoginContext.java + src/share/classes/javax/security/auth/login/package-info.java - src/share/classes/javax/security/auth/login/package.html + src/share/classes/javax/security/auth/package-info.java - src/share/classes/javax/security/auth/package.html ! src/share/classes/javax/security/auth/spi/LoginModule.java + src/share/classes/javax/security/auth/spi/package-info.java - src/share/classes/javax/security/auth/spi/package.html ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/classes/javax/security/auth/x500/X500PrivateCredential.java + src/share/classes/javax/security/auth/x500/package-info.java - src/share/classes/javax/security/auth/x500/package.html ! src/share/classes/javax/security/cert/Certificate.java ! src/share/classes/javax/security/cert/CertificateEncodingException.java ! src/share/classes/javax/security/cert/CertificateException.java ! src/share/classes/javax/security/cert/CertificateExpiredException.java ! src/share/classes/javax/security/cert/CertificateNotYetValidException.java ! src/share/classes/javax/security/cert/CertificateParsingException.java ! src/share/classes/javax/security/cert/X509Certificate.java + src/share/classes/javax/security/cert/package-info.java - src/share/classes/javax/security/cert/package.html ! src/share/classes/javax/security/sasl/AuthenticationException.java ! src/share/classes/javax/security/sasl/AuthorizeCallback.java ! src/share/classes/javax/security/sasl/RealmCallback.java ! src/share/classes/javax/security/sasl/RealmChoiceCallback.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/security/sasl/SaslClient.java ! src/share/classes/javax/security/sasl/SaslClientFactory.java ! src/share/classes/javax/security/sasl/SaslException.java ! src/share/classes/javax/security/sasl/SaslServer.java ! src/share/classes/javax/security/sasl/SaslServerFactory.java + src/share/classes/javax/security/sasl/package-info.java - src/share/classes/javax/security/sasl/package.html Changeset: cbdd2529d93a Author: lana Date: 2013-07-17 00:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cbdd2529d93a Merge Changeset: f2558ef87d5a Author: lana Date: 2013-07-17 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f2558ef87d5a Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 5be9c5bfcfe9 Author: lana Date: 2013-07-22 17:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5be9c5bfcfe9 Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java From david.katleman at oracle.com Tue Jul 23 19:20:40 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 19:20:40 +0000 Subject: hg: jdk8/build/langtools: 25 new changesets Message-ID: <20130723192151.BEE26482B8@hg.openjdk.java.net> Changeset: e73f00139fb5 Author: cl Date: 2013-07-18 03:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e73f00139fb5 Added tag jdk8-b99 for changeset 6d85acab769e ! .hgtags Changeset: d6158f8d7235 Author: vromero Date: 2013-07-04 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d6158f8d7235 8009924: some langtools tools do not accept -cp as an alias for -classpath Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javadoc/ToolOption.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/resources/l10n.properties ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties ! test/tools/doclint/tool/HelpTest.out Changeset: 79c3146e417b Author: vromero Date: 2013-07-04 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/79c3146e417b 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/T6356530/SerializableAbstractClassWithNonAbstractMethodsTest.java + test/tools/javac/T6356530/SerializableAbstractClassWithNonAbstractMethodsTest.out Changeset: 7b756b307e12 Author: mcimadamore Date: 2013-07-05 11:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7b756b307e12 8017618: NullPointerException in RichDiagnosticFormatter for bad input program Summary: RDF crashes when diagnostic contains type 'void' Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java + test/tools/javac/lambda/BadNestedLambda.java + test/tools/javac/lambda/BadNestedLambda.out Changeset: 70b37cdb19d5 Author: mcimadamore Date: 2013-07-05 11:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/70b37cdb19d5 8019480: Javac crashes when method is called on a type-variable receiver from lambda expression Summary: Logic for shortcircuiting speculative attribution doesn't handle type-variable receivers Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java + test/tools/javac/lambda/8019480/T8019480.java + test/tools/javac/lambda/8019480/T8019480.out Changeset: b0386f0dc28e Author: mcimadamore Date: 2013-07-05 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b0386f0dc28e 8016059: Cannot compile following lambda 8016060: Lambda isn't compiled with return statement Summary: Spurious error triggered during unnecessary recovery round Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java + test/tools/javac/lambda/TargetType75.java Changeset: bfbedbfc522a Author: mcimadamore Date: 2013-07-05 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/bfbedbfc522a 8016702: use of ternary operator in lambda expression gives incorrect results Summary: Constant types erroneously creep in during inference Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/conditional/T8016702.java Changeset: 42b3c5e92461 Author: mcimadamore Date: 2013-07-05 11:05 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/42b3c5e92461 8019824: very long error messages on inference error Summary: Inference error messages shows several spurious captured variables generated during an inference loop Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8019824/T8019824.java + test/tools/javac/generics/inference/8019824/T8019824.out Changeset: 49654c9c705b Author: lana Date: 2013-07-05 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/49654c9c705b Merge Changeset: aedb3bb327d5 Author: ksrini Date: 2013-07-09 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/aedb3bb327d5 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken Reviewed-by: jjg ! test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java Changeset: 87a951c88a33 Author: mcimadamore Date: 2013-07-11 15:37 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/87a951c88a33 8013404: Unclear spec for target typing with conditional operator (?:) Summary: Fix previously ignored test Reviewed-by: jjg, vromero ! test/tools/javac/lambda/TargetType36.java + test/tools/javac/lambda/TargetType36.out Changeset: 37031963493e Author: jjg Date: 2013-07-12 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/37031963493e 8020278: NPE in javadoc Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Env.java + test/tools/doclint/BadPackageCommentTest.java + test/tools/doclint/BadPackageCommentTest.out Changeset: 44e27378f523 Author: mcimadamore Date: 2013-07-17 14:04 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/44e27378f523 8012242: Lambda compatibility and checked exceptions Summary: Inference variables in 'throws' clause with no constraints should be inferred as RuntimeException Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/generics/6723444/T6723444.java - test/tools/javac/generics/6723444/T6723444.out + test/tools/javac/generics/6723444/T6723444_1.out + test/tools/javac/generics/6723444/T6723444_2.out ! test/tools/javac/generics/7015430/T7015430.java - test/tools/javac/generics/7015430/T7015430.out + test/tools/javac/generics/7015430/T7015430_1.out + test/tools/javac/generics/7015430/T7015430_2.out + test/tools/javac/lambda/TargetType63.java + test/tools/javac/lambda/TargetType63.out Changeset: 866c87c01285 Author: mcimadamore Date: 2013-07-17 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/866c87c01285 8016175: Add bottom-up type-checking support for unambiguous method references Summary: Type-checking of non-overloaded method references should be independent from target-type Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/MethodReference68.java + test/tools/javac/lambda/MethodReference68.out + test/tools/javac/lambda/MethodReference69.java + test/tools/javac/lambda/MethodReference69.out + test/tools/javac/lambda/MethodReference70.java + test/tools/javac/lambda/MethodReference70.out + test/tools/javac/lambda/MethodReference71.java + test/tools/javac/lambda/MethodReference71.out + test/tools/javac/lambda/MethodReference72.java + test/tools/javac/lambda/MethodReference72.out ! test/tools/javac/lambda/TargetType60.out + test/tools/javac/lambda/TargetType76.java Changeset: a204cf7aab7e Author: mcimadamore Date: 2013-07-17 14:11 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a204cf7aab7e 8012238: Nested method capture and inference 8008200: java/lang/Class/asSubclass/BasicUnit.java fails to compile Summary: Inference support should be more flexible w.r.t. nested method calls returning captured types Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/NestedCapture01.java + test/tools/javac/lambda/NestedCapture02.java + test/tools/javac/lambda/NestedCapture03.java Changeset: c60a5099863a Author: mcimadamore Date: 2013-07-17 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c60a5099863a 8020147: Spurious errors when compiling nested stuck lambdas Summary: Scope of deferred types is not copied correctly; postAttr analyzer should not run on stuck expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/lambda/8020147/T8020147.java + test/tools/javac/lambda/8020147/T8020147.out Changeset: 328896931b98 Author: mcimadamore Date: 2013-07-17 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/328896931b98 8020286: Wrong diagnostic after compaction Summary: compact diagnostic shows the least relevant method in the list Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/Diagnostics/compressed/T8020286.java + test/tools/javac/Diagnostics/compressed/T8020286.out Changeset: db2c539819dd Author: mcimadamore Date: 2013-07-17 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/db2c539819dd 7041019: Bogus type-variable substitution with array types with dependencies on accessibility check Summary: call to upperBound() when performing type-variable substitution on element type leads to unsoundness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/7034511/T7034511a.java ! test/tools/javac/generics/7034511/T7034511a.out ! test/tools/javac/generics/7034511/T7034511b.java ! test/tools/javac/generics/7034511/T7034511b.out + test/tools/javac/generics/7034511/T7041019.java Changeset: fae8f309ff80 Author: mcimadamore Date: 2013-07-17 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/fae8f309ff80 8016640: compiler hangs if the generics arity of a base class is wrong Summary: Check.checkCompatibleConcretes hang when javac creates synthetic supertypes for 269 model API Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java + test/tools/javac/generics/8016640/T8016640.java + test/tools/javac/generics/8016640/T8016640.out Changeset: 155809b1b969 Author: mcimadamore Date: 2013-07-17 14:19 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/155809b1b969 8020149: Graph inference: wrong logic for picking best variable to solve Summary: Replace logic for selecting best inference leaf in the graph during an unsticking round Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8020149/T8020149.java Changeset: b577222ef7b3 Author: mcimadamore Date: 2013-07-17 14:19 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b577222ef7b3 8019340: varargs-related warnings are meaningless on signature-polymorphic methods such as MethodHandle.invokeExact Summary: Disable certain varargs warnings when compiling polymorphic signature calls Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/meth/VarargsWarn.java + test/tools/javac/meth/VarargsWarn.out Changeset: f65a807714ba Author: mcimadamore Date: 2013-07-17 14:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f65a807714ba 8019942: Graph inference: avoid redundant computation during bound incorporation Summary: Bound incorporation should not perform same operation multiple times Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/generics/inference/8019824/T8019824.out Changeset: 10711bd8bb2d Author: jlahoda Date: 2013-07-17 15:08 +0200 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/10711bd8bb2d 8020586: Warning produced for an incorrect file Summary: Always using DeferredLintHandler.immediateHandler when processing import classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/warnings/6594914/Auxiliary.java + test/tools/javac/warnings/6594914/ExplicitCompilation.out + test/tools/javac/warnings/6594914/ImplicitCompilation.java + test/tools/javac/warnings/6594914/ImplicitCompilation.out Changeset: e990e6bcecbe Author: lana Date: 2013-07-17 10:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e990e6bcecbe Merge ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java Changeset: 82f68da70e47 Author: lana Date: 2013-07-22 17:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/82f68da70e47 Merge - test/tools/javac/generics/6723444/T6723444.out - test/tools/javac/generics/7015430/T7015430.out From david.katleman at oracle.com Tue Jul 23 19:22:12 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 19:22:12 +0000 Subject: hg: jdk8/build/nashorn: 51 new changesets Message-ID: <20130723192255.166CC482B9@hg.openjdk.java.net> Changeset: 10503ced6cc2 Author: cl Date: 2013-07-18 03:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/10503ced6cc2 Added tag jdk8-b99 for changeset 10a1ab9e20a4 ! .hgtags Changeset: 313bdcd2fd22 Author: sundar Date: 2013-07-03 00:08 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/313bdcd2fd22 8019629: void operator should always evaluate to undefined Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8019629.js Changeset: 9d3a9fdab668 Author: sundar Date: 2013-07-03 13:13 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/9d3a9fdab668 8019783: typeof does not work properly for java methods and foreign objects Reviewed-by: hannesw ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8019783.js + test/script/basic/JDK-8019783.js.EXPECTED ! test/script/basic/NASHORN-759.js.EXPECTED Changeset: 4afdc5bec43b Author: sundar Date: 2013-07-03 14:08 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/4afdc5bec43b 8019791: ~ is a unary operator Reviewed-by: hannesw ! src/jdk/nashorn/internal/parser/TokenType.java + test/script/basic/JDK-8019791.js + test/script/basic/JDK-8019791.js.EXPECTED Changeset: 18d467e94150 Author: attila Date: 2013-07-03 12:39 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/18d467e94150 8010946: AccessControl.doPrivileged is broken when called from js script Reviewed-by: jlaskey, sundar ! make/build.xml ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java + src/jdk/internal/dynalink/beans/CallerSensitiveDetector.java + src/jdk/internal/dynalink/beans/CallerSensitiveDynamicMethod.java ! src/jdk/internal/dynalink/beans/ClassString.java ! src/jdk/internal/dynalink/beans/DynamicMethod.java ! src/jdk/internal/dynalink/beans/DynamicMethodLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java ! src/jdk/internal/dynalink/beans/MaximallySpecific.java ! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java ! src/jdk/internal/dynalink/beans/OverloadedMethod.java ! src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java + src/jdk/internal/dynalink/beans/SingleDynamicMethod.java ! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java ! src/jdk/internal/dynalink/support/Lookup.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java + test/script/basic/JDK-8010946-2.js + test/script/basic/JDK-8010946-2.js.EXPECTED + test/script/basic/JDK-8010946-privileged.js + test/script/basic/JDK-8010946.js + test/script/basic/JDK-8010946.js.EXPECTED Changeset: b1980b5f00a1 Author: lagergren Date: 2013-07-03 13:03 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/b1980b5f00a1 8019585: Sometimes a var declaration using itself in its init wasn't declared as canBeUndefined, causing erroneous bytecode Reviewed-by: sundar, attila ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java + test/script/basic/JDK-8019585.js Changeset: eb1437d16ab4 Author: sundar Date: 2013-07-03 17:26 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/eb1437d16ab4 8019805: for each (init; test; modify) is invalid Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8019805.js + test/script/basic/JDK-8019805.js.EXPECTED ! test/script/basic/forin.js ! test/script/basic/forin.js.EXPECTED Changeset: 961cffae0828 Author: lagergren Date: 2013-07-03 15:46 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/961cffae0828 8019811: Static calls - self referential functions needed a return type conversion if they were specialized, as they can't use the same mechanism as indy calls Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! test/script/basic/JDK-8016667.js + test/script/basic/JDK-8019808.js + test/script/basic/JDK-8019810.js + test/script/basic/JDK-8019810.js.EXPECTED + test/script/basic/JDK-8019811.js + test/script/basic/JDK-8019817.js + test/script/currently-failing/JDK-8019809.js Changeset: fcb484c43348 Author: sundar Date: 2013-07-03 19:20 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/fcb484c43348 8019814: Add regression test for passing cases Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ListAdapter.java + test/script/basic/JDK-8019814.js + test/script/basic/JDK-8019814.js.EXPECTED Changeset: 29b2b2ed954c Author: attila Date: 2013-07-03 18:10 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/29b2b2ed954c 8017768: allow dot as inner class name separator for Java.type Reviewed-by: jlaskey, sundar ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/nashorn/internal/objects/NativeJava.java + test/script/basic/JDK-8017768.js + test/script/basic/JDK-8017768.js.EXPECTED ! test/src/jdk/nashorn/test/models/OuterClass.java Changeset: 7b072ebdf5aa Author: jlaskey Date: 2013-07-03 13:41 -0300 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/7b072ebdf5aa 8011629: Object.defineProperty performance issue Reviewed-by: sundar, attila Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/AccessorProperty.java Changeset: ad6b18ee4666 Author: attila Date: 2013-07-04 14:10 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ad6b18ee4666 8019809: return after break incorrectly sets the block as terminal Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java + test/script/basic/JDK-8019809.js - test/script/currently-failing/JDK-8019809.js Changeset: be2087629eb9 Author: lagergren Date: 2013-07-04 17:27 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/be2087629eb9 8019821: allInteger switches were confused by boolean cases, as they are a narrower type than int Reviewed-by: sundar, hannesw ! src/jdk/nashorn/internal/codegen/Attr.java + test/script/basic/JDK-8019821.js Changeset: 8c4a6d9b8a23 Author: lagergren Date: 2013-07-04 17:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/8c4a6d9b8a23 Merge - test/script/currently-failing/JDK-8019809.js Changeset: ec84ba68ad39 Author: sundar Date: 2013-07-05 14:38 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ec84ba68ad39 8019947: inherited property invalidation does not work with two globals in same context Reviewed-by: jlaskey, lagergren, hannesw, attila ! make/build-nasgen.xml ! make/build.xml ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/JDK-8019947.js + test/script/basic/JDK-8019947.js.EXPECTED Changeset: edca88d3a03e Author: hannesw Date: 2013-07-05 14:36 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/edca88d3a03e 8017084: Use spill properties for large object literals Reviewed-by: lagergren, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java + src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/scripts/JO.java + test/script/basic/JDK-8017084.js + test/script/basic/JDK-8017084.js.EXPECTED Changeset: ce9cbe70f915 Author: attila Date: 2013-07-05 15:10 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ce9cbe70f915 8019819: scope symbol didn't get a slot in certain cases Reviewed-by: hannesw, jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8019819.js Changeset: 20b2c2dc20e8 Author: lagergren Date: 2013-07-05 19:35 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/20b2c2dc20e8 8019983: Void returns combined with return with expression picked the wrong return type Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java + test/script/basic/JDK-8019983.js + test/script/basic/JDK-8019983.js.EXPECTED Changeset: 36d6b6a3fbe0 Author: sundar Date: 2013-07-08 16:33 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/36d6b6a3fbe0 8020015: shared PropertyMaps should not be used without duplication Reviewed-by: hannesw, attila ! buildtools/nasgen/build.xml ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! make/code_coverage.xml ! make/project.properties ! src/jdk/nashorn/internal/lookup/Lookup.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java Changeset: a75e75cc6a61 Author: sundar Date: 2013-07-08 18:36 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/a75e75cc6a61 8020035: nashorn jdk buildfile BuildNashorn.gmk still renamed jdk.nashorn.internal.objects package Reviewed-by: attila, jlaskey ! makefiles/BuildNashorn.gmk Changeset: c96745616167 Author: sundar Date: 2013-07-08 18:43 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/c96745616167 Merge Changeset: 5106d43feed7 Author: hannesw Date: 2013-07-08 19:34 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/5106d43feed7 8019963: empty char range in regex Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java + test/script/basic/JDK-8019963.js + test/script/basic/JDK-8019963.js.EXPECTED Changeset: d3f4e5dea634 Author: attila Date: 2013-07-09 13:57 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d3f4e5dea634 8009758: reactivate the 8006529 test. Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FunctionScope.java - test/script/currently-failing/JDK-8006529.js + test/script/trusted/JDK-8006529.js Changeset: 7538a59ca241 Author: sundar Date: 2013-07-09 17:37 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/7538a59ca241 8014785: Ability to extend global instance by binding properties of another object Reviewed-by: attila, hannesw, jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java + test/script/basic/JDK-8014785.js + test/script/basic/JDK-8014785.js.EXPECTED Changeset: d480015ab732 Author: lagergren Date: 2013-07-09 15:56 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d480015ab732 8020124: In the case of an eval switch, we might need explicit conversions of the tag store, as it was not known in the surrounding environment. Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8020124.js Changeset: 997a3215744a Author: sundar Date: 2013-07-10 13:25 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/997a3215744a 8020224: LinkageError: attempted duplicate class definition when --loader-per-compiler=false Reviewed-by: hannesw ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java Changeset: a9b74daed4f9 Author: hannesw Date: 2013-07-10 10:54 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/a9b74daed4f9 8016681: regex capture behaves differently than on V8 Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8016681.js + test/script/basic/JDK-8016681.js.EXPECTED Changeset: c501b1666bda Author: sundar Date: 2013-07-10 19:08 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/c501b1666bda 8020276: interface checks in Invocable.getInterface implementation Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 798e3aa19718 Author: sundar Date: 2013-07-11 16:34 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/798e3aa19718 8020325: static property does not work on accessible, public classes Reviewed-by: attila, hannesw, lagergren ! make/build.xml ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/lookup/Lookup.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java + test/script/basic/JDK-8020325.js + test/script/basic/JDK-8020325.js.EXPECTED ! test/script/trusted/JDK-8006529.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 58614b556a0d Author: sundar Date: 2013-07-11 18:23 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/58614b556a0d 8020380: __noSuchProperty__ defined in mozilla_compat.js script should be non-enumerable Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8020380.js Changeset: 2c007a8bb0e7 Author: attila Date: 2013-07-11 18:33 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/2c007a8bb0e7 8013925: Remove symbol fields from nodes that don't need them Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/Assignment.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java + src/jdk/nashorn/internal/ir/BlockStatement.java ! src/jdk/nashorn/internal/ir/BreakableNode.java + src/jdk/nashorn/internal/ir/BreakableStatement.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java - src/jdk/nashorn/internal/ir/ExecuteNode.java + src/jdk/nashorn/internal/ir/Expression.java + src/jdk/nashorn/internal/ir/ExpressionStatement.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java + src/jdk/nashorn/internal/ir/LexicalContextExpression.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java + src/jdk/nashorn/internal/ir/LexicalContextStatement.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TemporarySymbols.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! test/script/trusted/JDK-8006529.js Changeset: 9083af56bbcb Author: sundar Date: 2013-07-11 22:58 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/9083af56bbcb 8012191: noSuchProperty can't cope with vararg functions Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/ScriptFunction.java + test/script/basic/JDK-8012191.js + test/script/basic/JDK-8012191.js.EXPECTED Changeset: 289923785ada Author: attila Date: 2013-07-11 22:01 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/289923785ada 8020125: PrintVisitor wasn't printing bodies of FunctionNode within UnaryNode Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java Changeset: d763da247244 Author: sundar Date: 2013-07-12 15:01 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d763da247244 8020437: Wrong handling of line numbers with multiline string literals Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8020437.js + test/script/basic/JDK-8020437.js.EXPECTED + test/script/error/JDK-8020437-2.js + test/script/error/JDK-8020437-2.js.EXPECTED + test/script/error/JDK-8020437.js + test/script/error/JDK-8020437.js.EXPECTED Changeset: 1a6b1799f533 Author: sundar Date: 2013-07-12 15:27 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/1a6b1799f533 8020223: ClassCastException: String can not be casted to ScriptFunction Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8020223.js Changeset: e27ebcfed6fa Author: attila Date: 2013-07-12 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/e27ebcfed6fa 8019822: Duplicate name and signature in finally block Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8019822.js Changeset: 8108ba8366fd Author: sundar Date: 2013-07-12 20:12 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/8108ba8366fd Merge - src/jdk/nashorn/internal/ir/ExecuteNode.java - test/script/currently-failing/JDK-8006529.js Changeset: 5cdf4352ee0b Author: sundar Date: 2013-07-12 20:06 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/5cdf4352ee0b 8020463: Input argument array wrapping in loadWithNewGlobal is wrong Reviewed-by: attila, jlaskey ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/Context.java + test/script/basic/JDK-8020463.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: cbfeffbcd3f2 Author: sundar Date: 2013-07-12 20:13 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/cbfeffbcd3f2 Merge Changeset: 973d78ee0728 Author: attila Date: 2013-07-15 12:33 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/973d78ee0728 8020324: Implement Object.bindProperties(target, source) for beans Reviewed-by: hannesw, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/BeansLinker.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java + src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethod.java + src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java + test/script/basic/JDK-8020324.js + test/script/basic/JDK-8020324.js.EXPECTED + test/src/jdk/nashorn/test/models/PropertyBind.java Changeset: 62c552bcc342 Author: hannesw Date: 2013-07-15 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/62c552bcc342 8020354: Object literal property initialization is not done in source order Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8020354.js + test/script/basic/JDK-8020354.js.EXPECTED Changeset: ede320e13c82 Author: attila Date: 2013-07-15 16:31 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/ede320e13c82 8020508: Enforce reflection access restrictions on Object.bindProperties Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java + test/script/basic/JDK-8020508.js + test/script/basic/JDK-8020508.js.EXPECTED Changeset: e5505f0b10de Author: hannesw Date: 2013-07-15 16:35 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/e5505f0b10de 8020283: Don't use exceptions for widening of ArrayData Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java Changeset: 01212f5e7dad Author: attila Date: 2013-07-15 16:58 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/01212f5e7dad 8011210: fix reporting of call site locations; print them on -tcs=miss Reviewed-by: jlaskey, hannesw ! src/jdk/internal/dynalink/DynamicLinker.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java Changeset: 28f1f2374004 Author: hannesw Date: 2013-07-15 18:32 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/28f1f2374004 8020358: Array(0xfffffff) throws OutOfMemoryError Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java + test/script/basic/JDK-8020358.js + test/script/basic/JDK-8020358.js.EXPECTED Changeset: d685fec24d13 Author: sundar Date: 2013-07-16 09:54 +0530 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d685fec24d13 Merge Changeset: 965d876853ec Author: attila Date: 2013-07-16 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/965d876853ec 8020357: throw RangeError for too large NativeArrayBuffer size Reviewed-by: jlaskey, hannesw, sundar ! src/jdk/nashorn/internal/objects/ArrayBufferView.java + test/script/basic/JDK-8020357.js + test/script/basic/JDK-8020357.js.EXPECTED Changeset: 7503f30c1355 Author: hannesw Date: 2013-07-16 16:12 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/7503f30c1355 8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose mutable objects Reviewed-by: attila, jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Token.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/BackRefNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StringNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java Changeset: 78bdb8a7f1e7 Author: attila Date: 2013-07-16 17:03 +0200 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/78bdb8a7f1e7 8015356: array concatenation should skip empty elements Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8015356.js + test/script/basic/JDK-8015356.js.EXPECTED Changeset: 81cbb18d558a Author: lana Date: 2013-07-17 00:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/81cbb18d558a Merge Changeset: 598321c438b5 Author: lana Date: 2013-07-22 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/598321c438b5 Merge - src/jdk/nashorn/internal/ir/ExecuteNode.java - test/script/currently-failing/JDK-8006529.js From tim.bell at oracle.com Tue Jul 23 22:15:09 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 23 Jul 2013 15:15:09 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" Message-ID: <51EF006D.3060805@oracle.com> Hello everyone- This is a small set of changes to switch from gcc to clang when building on MacOS, and also enable building on MacOS 8.x Here is the bug report: http://bugs.sun.com/view_bug.do?bug_id=8019470 Here are the webrevs: Hotspot only: http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ All of the changes: http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ Thanks in advance. Tim From leonid.romanov at oracle.com Tue Jul 23 22:44:57 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 24 Jul 2013 02:44:57 +0400 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EF006D.3060805@oracle.com> References: <51EF006D.3060805@oracle.com> Message-ID: Just to satisfy my curiosity: what are advantages of using clang instead of gcc? On Jul 24, 2013, at 2:15 AM, Tim Bell wrote: > Hello everyone- > > This is a small set of changes to switch from gcc to clang when building on MacOS, and also enable building on MacOS 8.x > > Here is the bug report: > > http://bugs.sun.com/view_bug.do?bug_id=8019470 > > Here are the webrevs: > > Hotspot only: > > http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ > > All of the changes: > > http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ > > Thanks in advance. > > Tim > From mike.duigou at oracle.com Tue Jul 23 22:55:47 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Tue, 23 Jul 2013 15:55:47 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EF006D.3060805@oracle.com> References: <51EF006D.3060805@oracle.com> Message-ID: <8ADD626A-FB61-4AC2-A3B3-938D8619FDB7@oracle.com> Nice work! toolchain.m4:: - Wouldn't COMPILER_NAME=clang now be dependent upon which compiler is used? - It also seems to require that gcc still be present for the containing conditional; 509 if test "x$GCC" = xyes; then Mike On Jul 23 2013, at 15:15 , Tim Bell wrote: > Hello everyone- > > This is a small set of changes to switch from gcc to clang when building on MacOS, and also enable building on MacOS 8.x > > Here is the bug report: > > http://bugs.sun.com/view_bug.do?bug_id=8019470 > > Here are the webrevs: > > Hotspot only: > > http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ > > All of the changes: > > http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ > > Thanks in advance. > > Tim > From david.katleman at oracle.com Tue Jul 23 23:08:09 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Tue, 23 Jul 2013 23:08:09 +0000 Subject: hg: jdk8/build/hotspot: 10 new changesets Message-ID: <20130723230830.42606482CA@hg.openjdk.java.net> Changeset: bd1dc81da579 Author: amurillo Date: 2013-07-12 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bd1dc81da579 8020382: new hotspot build - hs25-b42 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f4311079200c Author: brutisso Date: 2013-07-11 11:33 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f4311079200c 8020155: PSR:PERF G1 not collecting old regions when humongous allocations interfer Summary: Take _last_young_gc into account when deciding on starting a concurrent mark. Also reviewed-by: per.liden at oracle.com. Reviewed-by: tschatzl, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: e7a47f226600 Author: tamao Date: 2013-07-15 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e7a47f226600 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: 980532a806a5 Author: goetz Date: 2013-06-20 15:02 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/980532a806a5 8016697: Use stubs to implement safefetch Summary: Implement Safefetch as stub routines. This reduces compiler and os dependencies. Reviewed-by: twisti, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/bsd_x86_32.s ! src/os_cpu/bsd_x86/vm/bsd_x86_64.s ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/linux_sparc.s ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/linux_x86/vm/linux_x86_64.s ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_64.s ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: a74ec8831c7b Author: clucasius Date: 2013-07-15 12:24 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a74ec8831c7b Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp Changeset: 16b10327b00d Author: jprovino Date: 2013-07-16 10:55 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/16b10327b00d 8011569: ARM -- avoid native stack walking Summary: ARM compilers do not emit FramePointer on each native frame by default Reviewed-by: dholmes, zgu ! make/linux/makefiles/vm.make ! src/share/vm/services/memTracker.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 90d6c221d4e5 Author: jprovino Date: 2013-07-16 12:20 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/90d6c221d4e5 Merge ! make/linux/makefiles/vm.make - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp ! src/share/vm/services/memTracker.cpp - src/share/vm/trace/traceEventTypes.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9d18d92e54b5 Author: clucasius Date: 2013-07-18 00:52 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9d18d92e54b5 Merge Changeset: 9f71e36a471a Author: amurillo Date: 2013-07-18 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9f71e36a471a Merge Changeset: 5787fac72e76 Author: amurillo Date: 2013-07-18 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5787fac72e76 Added tag hs25-b42 for changeset 9f71e36a471a ! .hgtags From tim.bell at oracle.com Tue Jul 23 23:38:11 2013 From: tim.bell at oracle.com (Tim Bell) Date: Tue, 23 Jul 2013 16:38:11 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: References: <51EF006D.3060805@oracle.com> Message-ID: <51EF13E3.6060804@oracle.com> Hello Leonid: > Just to satisfy my curiosity: what are advantages of using clang instead of gcc? I am a mere messenger here, but I am told that clang/clang++: - is command line compatible with gcc - is faster - produces better diagnostic messages - clang on MacOS is under active development while gcc is not [citation needed] To others out there - feel free to correct these points, or add more of your own. Tim > On Jul 24, 2013, at 2:15 AM, Tim Bell wrote: > >> Hello everyone- >> >> This is a small set of changes to switch from gcc to clang when building on MacOS, and also enable building on MacOS 8.x >> >> Here is the bug report: >> >> http://bugs.sun.com/view_bug.do?bug_id=8019470 >> >> Here are the webrevs: >> >> Hotspot only: >> >> http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ >> >> All of the changes: >> >> http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ >> >> Thanks in advance. >> >> Tim >> From david.katleman at oracle.com Wed Jul 24 00:08:40 2013 From: david.katleman at oracle.com (David Katleman) Date: Tue, 23 Jul 2013 17:08:40 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EF006D.3060805@oracle.com> References: <51EF006D.3060805@oracle.com> Message-ID: <51EF1B08.3040709@oracle.com> In toolchain.m4 267 elif test "x$OPENJDK_TARGET_OS" = "xmacosx"; then 268 COMPILER_CHECK_LIST="clang gcc cc" Aren't clang & cc the same? (/usr/bin/cc -> clang) Or are there instances of macosx that do not have the symlink? That's the only question I could find. Pretty simple change. Dave On 7/23/2013 3:15 PM, Tim Bell wrote: > Hello everyone- > > This is a small set of changes to switch from gcc to clang when > building on MacOS, and also enable building on MacOS 8.x > > Here is the bug report: > > http://bugs.sun.com/view_bug.do?bug_id=8019470 > > Here are the webrevs: > > Hotspot only: > > http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ > > All of the changes: > > http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ From heliofrota at gmail.com Wed Jul 24 01:04:00 2013 From: heliofrota at gmail.com (Helio Frota) Date: Tue, 23 Jul 2013 22:04:00 -0300 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EF1B08.3040709@oracle.com> References: <51EF006D.3060805@oracle.com> <51EF1B08.3040709@oracle.com> Message-ID: Hi great all, I found this article: http://www.phoronix.com/scan.php?page=article&item=llvm_clang33_3way&num=2 http://www.phoronix.com/scan.php?page=article&item=llvm_clang33_3way&num=3 http://www.phoronix.com/scan.php?page=article&item=llvm_clang33_3way&num=4 And GCC wins all on performance issues. Best regards, Helio 2013/7/23 David Katleman > In toolchain.m4 > > 267 elif test "x$OPENJDK_TARGET_OS" = "xmacosx"; then > 268 COMPILER_CHECK_LIST="clang gcc cc" > > Aren't clang & cc the same? (/usr/bin/cc -> clang) > > Or are there instances of macosx that do not have the symlink? > > That's the only question I could find. Pretty simple change. > > Dave > > > > On 7/23/2013 3:15 PM, Tim Bell wrote: > >> Hello everyone- >> >> This is a small set of changes to switch from gcc to clang when building >> on MacOS, and also enable building on MacOS 8.x >> >> Here is the bug report: >> >> http://bugs.sun.com/view_bug.**do?bug_id=8019470 >> >> Here are the webrevs: >> >> Hotspot only: >> >> http://cr.openjdk.java.net/~**tbell/8019470/hotspot/webrev.**00/ >> >> All of the changes: >> >> http://cr.openjdk.java.net/~**tbell/8019470/webrev.00/ >> > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From david.holmes at oracle.com Wed Jul 24 11:43:05 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 24 Jul 2013 21:43:05 +1000 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EF006D.3060805@oracle.com> References: <51EF006D.3060805@oracle.com> Message-ID: <51EFBDC9.4070200@oracle.com> Hi Tim, On 24/07/2013 8:15 AM, Tim Bell wrote: > Hello everyone- > > This is a small set of changes to switch from gcc to clang when building So we already added support for clang as the compiler for hotspot - is this just extending things to allow configure to select clang? > on MacOS, and also enable building on MacOS 8.x Have we already updated all the JPRT queues to have 10.8 macs versus 10.7 ones? > Here is the bug report: > > http://bugs.sun.com/view_bug.do?bug_id=8019470 > > Here are the webrevs: > > Hotspot only: > > http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ src/os/bsd/vm/os_bsd.cpp Again I'm confused. We already allowed building via clang so why wasn't this change needed before? Thanks, David > All of the changes: > > http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ > Thanks in advance. > > Tim > From tim.bell at oracle.com Wed Jul 24 12:15:40 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 24 Jul 2013 05:15:40 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EFBDC9.4070200@oracle.com> References: <51EF006D.3060805@oracle.com> <51EFBDC9.4070200@oracle.com> Message-ID: <51EFC56C.6040304@oracle.com> On 07/24/13 04:43 AM, David Holmes wrote: > Hi Tim, > > On 24/07/2013 8:15 AM, Tim Bell wrote: >> Hello everyone- >> >> This is a small set of changes to switch from gcc to clang when building > > So we already added support for clang as the compiler for hotspot - is > this just extending things to allow configure to select clang? The earlier clang/hotspot activity was centered around Linux x86/x86_64. >> on MacOS, and also enable building on MacOS 8.x > > Have we already updated all the JPRT queues to have 10.8 macs versus > 10.7 ones? Yes, all the queues have 10.8 Macs, which have been test-only up until now. >> Here is the bug report: >> >> http://bugs.sun.com/view_bug.do?bug_id=8019470 >> >> Here are the webrevs: >> >> Hotspot only: >> >> http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ > > src/os/bsd/vm/os_bsd.cpp > > Again I'm confused. We already allowed building via clang so why > wasn't this change needed before? This file is not used when building on Linux. Tim > > Thanks, > David > >> All of the changes: >> >> http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ > > >> Thanks in advance. >> >> Tim >> From david.r.chase at oracle.com Wed Jul 24 13:12:55 2013 From: david.r.chase at oracle.com (David Chase) Date: Wed, 24 Jul 2013 09:12:55 -0400 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EF13E3.6060804@oracle.com> References: <51EF006D.3060805@oracle.com> <51EF13E3.6060804@oracle.com> Message-ID: <6C640F77-71BE-4617-B641-AB1BA264FC82@oracle.com> On 2013-07-23, at 7:38 PM, Tim Bell wrote: > Hello Leonid: > >> Just to satisfy my curiosity: what are advantages of using clang instead of gcc? > > I am a mere messenger here, but I am told that clang/clang++: > > - is command line compatible with gcc > - is faster > - produces better diagnostic messages > - clang on MacOS is under active development while gcc is not [citation needed] > > To others out there - feel free to correct these points, or add more of your own. Clang is the default compiler for the next (Mavericks) MacOS release, or so I have heard. Clang is already more up-to-date than (Apple-packaged) gcc on MacOS -- if you want to access some of the "new" (two years old) intrinsics from C or from the assembler, you need to use clang. Compilation of hotspot itself is faster with clang; not sure about the performance of hotspot itself. David From leonid.romanov at oracle.com Wed Jul 24 16:35:07 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 24 Jul 2013 20:35:07 +0400 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <6C640F77-71BE-4617-B641-AB1BA264FC82@oracle.com> References: <51EF006D.3060805@oracle.com> <51EF13E3.6060804@oracle.com> <6C640F77-71BE-4617-B641-AB1BA264FC82@oracle.com> Message-ID: <90FE4DD3-7C23-42BD-9EB9-F605595F2D5A@oracle.com> On Jul 24, 2013, at 5:12 PM, David Chase wrote: > > On 2013-07-23, at 7:38 PM, Tim Bell wrote: > >> Hello Leonid: >> >>> Just to satisfy my curiosity: what are advantages of using clang instead of gcc? >> >> I am a mere messenger here, but I am told that clang/clang++: >> >> - is command line compatible with gcc >> - is faster >> - produces better diagnostic messages >> - clang on MacOS is under active development while gcc is not [citation needed] >> >> To others out there - feel free to correct these points, or add more of your own. > > Clang is the default compiler for the next (Mavericks) MacOS release, or so I have heard. > Clang is already more up-to-date than (Apple-packaged) gcc on MacOS -- if you want to access some of the "new" (two years old) intrinsics from C or from the assembler, you need to use clang. > Compilation of hotspot itself is faster with clang; not sure about the performance of hotspot itself. I see? Thanks! Anything that reduces compilation time is good ) > > David > From Alan.Bateman at oracle.com Wed Jul 24 18:33:43 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 24 Jul 2013 11:33:43 -0700 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <51DDAF72.4000909@redhat.com> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> Message-ID: <51F01E07.3070808@oracle.com> On 10/07/2013 12:01, Omair Majid wrote: > On 07/09/2013 03:40 AM, Erik Joelsson wrote: >> I would like to see a comment explaining why the option was needed. Is >> this a bug in gcc or has the checking just become better? > -Werror is not a great default. It means "all warnings are errors". The > set of warnings that a compiler emits changes all the time. Users and > distributions can enable additional warnings by default. Newer compiler > versions may omit additional warnings. So on any compiler other than the > typical compiler used, extra warnings are possible. With -Werror, this > will probably fail. Lots of people discourage it [1]. > > We have been setting SCTP_WERROR="" to disable this -Werror on Fedora > builds [2]. > I'm curious if there was a conclusion on this one. I assume SCTP_WERROR was originally intended for building libsctp (not libnio) so it would be strange to add to SCTP_WERROR to disable -Werror for issues coming from the file system code. One other thing that isn't clear is why there aren't other warnings as there are many other JNI functions in this source file that don't use the "jclass this" parameter. -Alan From heliofrota at gmail.com Wed Jul 24 19:28:59 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:28:59 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <51F01E07.3070808@oracle.com> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: Hi, I'm curious if there was a conclusion on this one. I assume SCTP_WERROR was originally intended for building libsctp (not libnio) so it would be strange to add to SCTP_WERROR to disable -Werror for issues coming from the file system code. One other thing that isn't clear is why there aren't other warnings as there are many other JNI functions in this source file that don't use the "jclass this" parameter. I have a plain raw new fedora 19 x86 env here. Going to do the build right now... and post on this thread the feedback. Regards, Helio 2013/7/24 Alan Bateman > On 10/07/2013 12:01, Omair Majid wrote: > >> On 07/09/2013 03:40 AM, Erik Joelsson wrote: >> >>> I would like to see a comment explaining why the option was needed. Is >>> this a bug in gcc or has the checking just become better? >>> >> -Werror is not a great default. It means "all warnings are errors". The >> set of warnings that a compiler emits changes all the time. Users and >> distributions can enable additional warnings by default. Newer compiler >> versions may omit additional warnings. So on any compiler other than the >> typical compiler used, extra warnings are possible. With -Werror, this >> will probably fail. Lots of people discourage it [1]. >> >> We have been setting SCTP_WERROR="" to disable this -Werror on Fedora >> builds [2]. >> >> I'm curious if there was a conclusion on this one. I assume SCTP_WERROR > was originally intended for building libsctp (not libnio) so it would be > strange to add to SCTP_WERROR to disable -Werror for issues coming from the > file system code. One other thing that isn't clear is why there aren't > other warnings as there are many other JNI functions in this source file > that don't use the "jclass this" parameter. > > -Alan > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 19:35:14 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:35:14 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: Ok first feedback configure: error: Could not find a C++ compiler. You might be able to fix this by running 'sudo yum groupinstall "Development Tools"'. I did this but the error continue. Going to investigate a workaround. Regards, Helio 2013/7/24 Helio Frota > Hi, > > I'm curious if there was a conclusion on this one. I assume SCTP_WERROR > was originally intended for building libsctp (not libnio) so it would be > strange to add to SCTP_WERROR to disable -Werror for issues coming from the > file system code. One other thing that isn't clear is why there aren't > other warnings as there are many other JNI functions in this source file > that don't use the "jclass this" parameter. > > I have a plain raw new fedora 19 x86 env here. > > Going to do the build right now... and post on this thread the feedback. > > Regards, > Helio > > > > 2013/7/24 Alan Bateman > >> On 10/07/2013 12:01, Omair Majid wrote: >> >>> On 07/09/2013 03:40 AM, Erik Joelsson wrote: >>> >>>> I would like to see a comment explaining why the option was needed. Is >>>> this a bug in gcc or has the checking just become better? >>>> >>> -Werror is not a great default. It means "all warnings are errors". The >>> set of warnings that a compiler emits changes all the time. Users and >>> distributions can enable additional warnings by default. Newer compiler >>> versions may omit additional warnings. So on any compiler other than the >>> typical compiler used, extra warnings are possible. With -Werror, this >>> will probably fail. Lots of people discourage it [1]. >>> >>> We have been setting SCTP_WERROR="" to disable this -Werror on Fedora >>> builds [2]. >>> >>> I'm curious if there was a conclusion on this one. I assume SCTP_WERROR >> was originally intended for building libsctp (not libnio) so it would be >> strange to add to SCTP_WERROR to disable -Werror for issues coming from the >> file system code. One other thing that isn't clear is why there aren't >> other warnings as there are many other JNI functions in this source file >> that don't use the "jclass this" parameter. >> >> -Alan >> > > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 19:40:31 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:40:31 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: Hi, Please need to add the message on the autoconf config scripts: You might be able to fix this by running 'sudo yum install gcc-c++'. because " 'sudo yum groupinstall "Development Tools"' " not installed the gcc-c++ compiler. Regards, Helio 2013/7/24 Helio Frota > Ok first feedback > > configure: error: Could not find a C++ compiler. You might be able to fix > this by running 'sudo yum groupinstall "Development Tools"'. > > I did this but the error continue. > > Going to investigate a workaround. > > Regards, > Helio > > > > 2013/7/24 Helio Frota > >> Hi, >> >> I'm curious if there was a conclusion on this one. I assume SCTP_WERROR >> was originally intended for building libsctp (not libnio) so it would be >> strange to add to SCTP_WERROR to disable -Werror for issues coming from the >> file system code. One other thing that isn't clear is why there aren't >> other warnings as there are many other JNI functions in this source file >> that don't use the "jclass this" parameter. >> >> I have a plain raw new fedora 19 x86 env here. >> >> Going to do the build right now... and post on this thread the feedback. >> >> Regards, >> Helio >> >> >> >> 2013/7/24 Alan Bateman >> >>> On 10/07/2013 12:01, Omair Majid wrote: >>> >>>> On 07/09/2013 03:40 AM, Erik Joelsson wrote: >>>> >>>>> I would like to see a comment explaining why the option was needed. Is >>>>> this a bug in gcc or has the checking just become better? >>>>> >>>> -Werror is not a great default. It means "all warnings are errors". The >>>> set of warnings that a compiler emits changes all the time. Users and >>>> distributions can enable additional warnings by default. Newer compiler >>>> versions may omit additional warnings. So on any compiler other than the >>>> typical compiler used, extra warnings are possible. With -Werror, this >>>> will probably fail. Lots of people discourage it [1]. >>>> >>>> We have been setting SCTP_WERROR="" to disable this -Werror on Fedora >>>> builds [2]. >>>> >>>> I'm curious if there was a conclusion on this one. I assume >>> SCTP_WERROR was originally intended for building libsctp (not libnio) so it >>> would be strange to add to SCTP_WERROR to disable -Werror for issues coming >>> from the file system code. One other thing that isn't clear is why there >>> aren't other warnings as there are many other JNI functions in this source >>> file that don't use the "jclass this" parameter. >>> >>> -Alan >>> >> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 19:44:24 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:44:24 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: Hi, Another problem: configure: error: Could not find all X11 headers (shape.h Xrender.h XTest.h). You might be able to fix this by running 'sudo yum install libXtst-devel'. configure exiting with result code 1 I did this, but the error persists. Going to investigate... Regards, Helio 2013/7/24 Helio Frota > Hi, > > Please need to add the message on the autoconf config scripts: > > You might be able to fix this by running 'sudo yum install gcc-c++'. > > because " 'sudo yum groupinstall "Development Tools"' " not installed the > gcc-c++ compiler. > > Regards, > Helio > > > > > > 2013/7/24 Helio Frota > >> Ok first feedback >> >> configure: error: Could not find a C++ compiler. You might be able to fix >> this by running 'sudo yum groupinstall "Development Tools"'. >> >> I did this but the error continue. >> >> Going to investigate a workaround. >> >> Regards, >> Helio >> >> >> >> 2013/7/24 Helio Frota >> >>> Hi, >>> >>> I'm curious if there was a conclusion on this one. I assume SCTP_WERROR >>> was originally intended for building libsctp (not libnio) so it would be >>> strange to add to SCTP_WERROR to disable -Werror for issues coming from the >>> file system code. One other thing that isn't clear is why there aren't >>> other warnings as there are many other JNI functions in this source file >>> that don't use the "jclass this" parameter. >>> >>> I have a plain raw new fedora 19 x86 env here. >>> >>> Going to do the build right now... and post on this thread the feedback. >>> >>> Regards, >>> Helio >>> >>> >>> >>> 2013/7/24 Alan Bateman >>> >>>> On 10/07/2013 12:01, Omair Majid wrote: >>>> >>>>> On 07/09/2013 03:40 AM, Erik Joelsson wrote: >>>>> >>>>>> I would like to see a comment explaining why the option was needed. Is >>>>>> this a bug in gcc or has the checking just become better? >>>>>> >>>>> -Werror is not a great default. It means "all warnings are errors". The >>>>> set of warnings that a compiler emits changes all the time. Users and >>>>> distributions can enable additional warnings by default. Newer compiler >>>>> versions may omit additional warnings. So on any compiler other than >>>>> the >>>>> typical compiler used, extra warnings are possible. With -Werror, this >>>>> will probably fail. Lots of people discourage it [1]. >>>>> >>>>> We have been setting SCTP_WERROR="" to disable this -Werror on Fedora >>>>> builds [2]. >>>>> >>>>> I'm curious if there was a conclusion on this one. I assume >>>> SCTP_WERROR was originally intended for building libsctp (not libnio) so it >>>> would be strange to add to SCTP_WERROR to disable -Werror for issues coming >>>> from the file system code. One other thing that isn't clear is why there >>>> aren't other warnings as there are many other JNI functions in this source >>>> file that don't use the "jclass this" parameter. >>>> >>>> -Alan >>>> >>> >>> >>> >>> -- >>> Helio Frota >>> JUG Leader - CEJUG >>> http://www.cejug.org/ >>> http://www.linkedin.com/in/heliofrota >>> >>> >>> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 19:50:43 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:50:43 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: Hi, Please add the message: You might be able to fix this by running 'sudo yum install libXrender-devel'. sudo yum install libXrender-devel Because shape.h Xrender.h XTest.h are not installed with sudo yum install libXtst-devel Regards, Helio 2013/7/24 Helio Frota > Hi, > > Another problem: > > configure: error: Could not find all X11 headers (shape.h Xrender.h > XTest.h). You might be able to fix this by running 'sudo yum install > libXtst-devel'. > configure exiting with result code 1 > > I did this, but the error persists. > > Going to investigate... > > Regards, > Helio > > > > 2013/7/24 Helio Frota > >> Hi, >> >> Please need to add the message on the autoconf config scripts: >> >> You might be able to fix this by running 'sudo yum install gcc-c++'. >> >> because " 'sudo yum groupinstall "Development Tools"' " not installed >> the gcc-c++ compiler. >> >> Regards, >> Helio >> >> >> >> >> >> 2013/7/24 Helio Frota >> >>> Ok first feedback >>> >>> configure: error: Could not find a C++ compiler. You might be able to >>> fix this by running 'sudo yum groupinstall "Development Tools"'. >>> >>> I did this but the error continue. >>> >>> Going to investigate a workaround. >>> >>> Regards, >>> Helio >>> >>> >>> >>> 2013/7/24 Helio Frota >>> >>>> Hi, >>>> >>>> I'm curious if there was a conclusion on this one. I assume SCTP_WERROR >>>> was originally intended for building libsctp (not libnio) so it would be >>>> strange to add to SCTP_WERROR to disable -Werror for issues coming from the >>>> file system code. One other thing that isn't clear is why there aren't >>>> other warnings as there are many other JNI functions in this source file >>>> that don't use the "jclass this" parameter. >>>> >>>> I have a plain raw new fedora 19 x86 env here. >>>> >>>> Going to do the build right now... and post on this thread the feedback. >>>> >>>> Regards, >>>> Helio >>>> >>>> >>>> >>>> 2013/7/24 Alan Bateman >>>> >>>>> On 10/07/2013 12:01, Omair Majid wrote: >>>>> >>>>>> On 07/09/2013 03:40 AM, Erik Joelsson wrote: >>>>>> >>>>>>> I would like to see a comment explaining why the option was needed. >>>>>>> Is >>>>>>> this a bug in gcc or has the checking just become better? >>>>>>> >>>>>> -Werror is not a great default. It means "all warnings are errors". >>>>>> The >>>>>> set of warnings that a compiler emits changes all the time. Users and >>>>>> distributions can enable additional warnings by default. Newer >>>>>> compiler >>>>>> versions may omit additional warnings. So on any compiler other than >>>>>> the >>>>>> typical compiler used, extra warnings are possible. With -Werror, this >>>>>> will probably fail. Lots of people discourage it [1]. >>>>>> >>>>>> We have been setting SCTP_WERROR="" to disable this -Werror on Fedora >>>>>> builds [2]. >>>>>> >>>>>> I'm curious if there was a conclusion on this one. I assume >>>>> SCTP_WERROR was originally intended for building libsctp (not libnio) so it >>>>> would be strange to add to SCTP_WERROR to disable -Werror for issues coming >>>>> from the file system code. One other thing that isn't clear is why there >>>>> aren't other warnings as there are many other JNI functions in this source >>>>> file that don't use the "jclass this" parameter. >>>>> >>>>> -Alan >>>>> >>>> >>>> >>>> >>>> -- >>>> Helio Frota >>>> JUG Leader - CEJUG >>>> http://www.cejug.org/ >>>> http://www.linkedin.com/in/heliofrota >>>> >>>> >>>> >>> >>> >>> -- >>> Helio Frota >>> JUG Leader - CEJUG >>> http://www.cejug.org/ >>> http://www.linkedin.com/in/heliofrota >>> >>> >>> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 19:53:40 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:53:40 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: Sorry, its me again. I get the configure error: configure: error: Could not find freetype2! You might be able to fix this by running 'sudo yum install freetype2-devel'. configure exiting with result code 1 But after run the command: sudo yum install freetype2-devel Fedora 19 appears not to have the package Loaded plugins: langpacks, refresh-packagekit No package freetype2-devel available. Error: Nothing to do Going to investigate this... Regards, Helio 2013/7/24 Helio Frota > Hi, > > Please add the message: > > You might be able to fix this by running 'sudo yum install > libXrender-devel'. > > sudo yum install libXrender-devel > > Because shape.h Xrender.h XTest.h are not installed with sudo yum install > libXtst-devel > > Regards, > Helio > > > > > 2013/7/24 Helio Frota > >> Hi, >> >> Another problem: >> >> configure: error: Could not find all X11 headers (shape.h Xrender.h >> XTest.h). You might be able to fix this by running 'sudo yum install >> libXtst-devel'. >> configure exiting with result code 1 >> >> I did this, but the error persists. >> >> Going to investigate... >> >> Regards, >> Helio >> >> >> >> 2013/7/24 Helio Frota >> >>> Hi, >>> >>> Please need to add the message on the autoconf config scripts: >>> >>> You might be able to fix this by running 'sudo yum install gcc-c++'. >>> >>> because " 'sudo yum groupinstall "Development Tools"' " not installed >>> the gcc-c++ compiler. >>> >>> Regards, >>> Helio >>> >>> >>> >>> >>> >>> 2013/7/24 Helio Frota >>> >>>> Ok first feedback >>>> >>>> configure: error: Could not find a C++ compiler. You might be able to >>>> fix this by running 'sudo yum groupinstall "Development Tools"'. >>>> >>>> I did this but the error continue. >>>> >>>> Going to investigate a workaround. >>>> >>>> Regards, >>>> Helio >>>> >>>> >>>> >>>> 2013/7/24 Helio Frota >>>> >>>>> Hi, >>>>> >>>>> I'm curious if there was a conclusion on this one. I assume >>>>> SCTP_WERROR was originally intended for building libsctp (not libnio) so it >>>>> would be strange to add to SCTP_WERROR to disable -Werror for issues coming >>>>> from the file system code. One other thing that isn't clear is why there >>>>> aren't other warnings as there are many other JNI functions in this source >>>>> file that don't use the "jclass this" parameter. >>>>> >>>>> I have a plain raw new fedora 19 x86 env here. >>>>> >>>>> Going to do the build right now... and post on this thread the >>>>> feedback. >>>>> >>>>> Regards, >>>>> Helio >>>>> >>>>> >>>>> >>>>> 2013/7/24 Alan Bateman >>>>> >>>>>> On 10/07/2013 12:01, Omair Majid wrote: >>>>>> >>>>>>> On 07/09/2013 03:40 AM, Erik Joelsson wrote: >>>>>>> >>>>>>>> I would like to see a comment explaining why the option was needed. >>>>>>>> Is >>>>>>>> this a bug in gcc or has the checking just become better? >>>>>>>> >>>>>>> -Werror is not a great default. It means "all warnings are errors". >>>>>>> The >>>>>>> set of warnings that a compiler emits changes all the time. Users and >>>>>>> distributions can enable additional warnings by default. Newer >>>>>>> compiler >>>>>>> versions may omit additional warnings. So on any compiler other than >>>>>>> the >>>>>>> typical compiler used, extra warnings are possible. With -Werror, >>>>>>> this >>>>>>> will probably fail. Lots of people discourage it [1]. >>>>>>> >>>>>>> We have been setting SCTP_WERROR="" to disable this -Werror on Fedora >>>>>>> builds [2]. >>>>>>> >>>>>>> I'm curious if there was a conclusion on this one. I assume >>>>>> SCTP_WERROR was originally intended for building libsctp (not libnio) so it >>>>>> would be strange to add to SCTP_WERROR to disable -Werror for issues coming >>>>>> from the file system code. One other thing that isn't clear is why there >>>>>> aren't other warnings as there are many other JNI functions in this source >>>>>> file that don't use the "jclass this" parameter. >>>>>> >>>>>> -Alan >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Helio Frota >>>>> JUG Leader - CEJUG >>>>> http://www.cejug.org/ >>>>> http://www.linkedin.com/in/heliofrota >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Helio Frota >>>> JUG Leader - CEJUG >>>> http://www.cejug.org/ >>>> http://www.linkedin.com/in/heliofrota >>>> >>>> >>>> >>> >>> >>> -- >>> Helio Frota >>> JUG Leader - CEJUG >>> http://www.cejug.org/ >>> http://www.linkedin.com/in/heliofrota >>> >>> >>> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From omajid at redhat.com Wed Jul 24 19:54:09 2013 From: omajid at redhat.com (Omair Majid) Date: Wed, 24 Jul 2013 15:54:09 -0400 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> Message-ID: <51F030E1.6090407@redhat.com> On 07/24/2013 03:44 PM, Helio Frota wrote: > Hi, > > Another problem: > > configure: error: Could not find all X11 headers (shape.h Xrender.h > XTest.h). You might be able to fix this by running 'sudo yum install > libXtst-devel'. > configure exiting with result code 1 > > I did this, but the error persists. > > Going to investigate... > The package manager suggestions are very unlikely to be exactly right for all versions of all distributions. You can follow the error message to get better results and install the files it is complaining about. For example, using yum, you can ask to install the package that provides this file (eg XTest.h) by name: # yum install '*/XTest.h' You should do the same for all other header file dependencies configure complains about. If you are on Fedora 19, you can also get all the dependencies faster by getting all the dependencies that java-1.8.0-openjdk (that's what the OpenJDK 8 package is called in Fedora) declares: # yum-builddep java-1.8.0-openjdk This may not be as up-to-date as what configure expects, though. It should be faster. Cheers, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From heliofrota at gmail.com Wed Jul 24 19:57:05 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:57:05 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <51F030E1.6090407@redhat.com> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> Message-ID: Hi Omair, Thanks for the tips ! About freetype: Just change to sudo yum install freetype-devel This solve the problem.. Going to validate the "alsa" now... Regards, Helio 2013/7/24 Omair Majid > On 07/24/2013 03:44 PM, Helio Frota wrote: > > Hi, > > > > Another problem: > > > > configure: error: Could not find all X11 headers (shape.h Xrender.h > > XTest.h). You might be able to fix this by running 'sudo yum install > > libXtst-devel'. > > configure exiting with result code 1 > > > > I did this, but the error persists. > > > > Going to investigate... > > > > The package manager suggestions are very unlikely to be exactly right > for all versions of all distributions. You can follow the error message > to get better results and install the files it is complaining about. > > For example, using yum, you can ask to install the package that provides > this file (eg XTest.h) by name: > > # yum install '*/XTest.h' > > You should do the same for all other header file dependencies configure > complains about. > > If you are on Fedora 19, you can also get all the dependencies faster by > getting all the dependencies that java-1.8.0-openjdk (that's what the > OpenJDK 8 package is called in Fedora) declares: > > # yum-builddep java-1.8.0-openjdk > > This may not be as up-to-date as what configure expects, though. It > should be faster. > > Cheers, > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 19:59:20 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 16:59:20 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> Message-ID: Hi, Configure "ok" ==================================================== A new configuration has been successfully created in /home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release using default settings. Configuration summary: * Debug level: release * JDK variant: normal * JVM variants: server * OpenJDK target: OS: linux, CPU architecture: x86, address length: 32 Tools summary: * Boot JDK: java version "1.7.0_25" Java(TM) SE Runtime Environment (build 1.7.0_25-b15) Java HotSpot(TM) Server VM (build 23.25-b01, mixed mode) (at /home/hf/java/jdk) * C Compiler: gcc (GCC) 4.8.1 20130603 (Red Hat-1) version 4.8.1-1) (at /usr/bin/gcc) * C++ Compiler: g++ (GCC) 4.8.1 20130603 (Red Hat-1) version 4.8.1-1) (at /usr/bin/g++) Build performance summary: * Cores to use: 3 * Memory limit: 3449 MB * ccache status: not installed (consider installing) Build performance tip: ccache gives a tremendous speedup for C++ recompilations. You do not have ccache installed. Try installing it. You might be able to fix this by running 'sudo yum install ccache'. Going to build with make all Regards, Helio 2013/7/24 Helio Frota > Hi Omair, > > Thanks for the tips ! > > About freetype: > > Just change to sudo yum install freetype-devel > This solve the problem.. > > Going to validate the "alsa" now... > > Regards, > Helio > > > 2013/7/24 Omair Majid > >> On 07/24/2013 03:44 PM, Helio Frota wrote: >> > Hi, >> > >> > Another problem: >> > >> > configure: error: Could not find all X11 headers (shape.h Xrender.h >> > XTest.h). You might be able to fix this by running 'sudo yum install >> > libXtst-devel'. >> > configure exiting with result code 1 >> > >> > I did this, but the error persists. >> > >> > Going to investigate... >> > >> >> The package manager suggestions are very unlikely to be exactly right >> for all versions of all distributions. You can follow the error message >> to get better results and install the files it is complaining about. >> >> For example, using yum, you can ask to install the package that provides >> this file (eg XTest.h) by name: >> >> # yum install '*/XTest.h' >> >> You should do the same for all other header file dependencies configure >> complains about. >> >> If you are on Fedora 19, you can also get all the dependencies faster by >> getting all the dependencies that java-1.8.0-openjdk (that's what the >> OpenJDK 8 package is called in Fedora) declares: >> >> # yum-builddep java-1.8.0-openjdk >> >> This may not be as up-to-date as what configure expects, though. It >> should be faster. >> >> Cheers, >> Omair >> >> -- >> PGP Key: 66484681 (http://pgp.mit.edu/) >> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 >> > > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Wed Jul 24 20:11:22 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 17:11:22 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> Message-ID: Hi, I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro son of archlinux ) Generating precompiled header precompiled.hpp.gch cc1plus: error: the "stabs" debug format cannot be used with pre-compiled headers [-Werror=deprecated] cc1plus: all warnings being treated as errors gmake[6]: *** [precompiled.hpp.gch] Error 1 gmake[5]: *** [the_vm] Error 2 gmake[4]: *** [product] Error 2 gmake[3]: *** [generic_build2] Error 2 gmake[2]: *** [product] Error 2 gmake[1]: *** [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/hotspot/_hotspot.timestamp] Error 2 make: *** [hotspot-only] Error 2 And i did this one to solve : my web site: http://www.heliofrota.com/blog/2013/06/25/building-openjdk8-plus-gcc-4-dot-8-1-plus-manjaro-gnu-linux-x86/ Regards, Helio 2013/7/24 Helio Frota > Hi, > > Configure "ok" > > > ==================================================== > A new configuration has been successfully created in > /home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release > using default settings. > > Configuration summary: > * Debug level: release > * JDK variant: normal > * JVM variants: server > * OpenJDK target: OS: linux, CPU architecture: x86, address length: 32 > > Tools summary: > * Boot JDK: java version "1.7.0_25" Java(TM) SE Runtime Environment > (build 1.7.0_25-b15) Java HotSpot(TM) Server VM (build 23.25-b01, mixed > mode) (at /home/hf/java/jdk) > * C Compiler: gcc (GCC) 4.8.1 20130603 (Red Hat-1) version 4.8.1-1) > (at /usr/bin/gcc) > * C++ Compiler: g++ (GCC) 4.8.1 20130603 (Red Hat-1) version 4.8.1-1) > (at /usr/bin/g++) > > Build performance summary: > * Cores to use: 3 > * Memory limit: 3449 MB > * ccache status: not installed (consider installing) > > Build performance tip: ccache gives a tremendous speedup for C++ > recompilations. > You do not have ccache installed. Try installing it. > You might be able to fix this by running 'sudo yum install ccache'. > > Going to build with make all > > Regards, > Helio > > > > > 2013/7/24 Helio Frota > >> Hi Omair, >> >> Thanks for the tips ! >> >> About freetype: >> >> Just change to sudo yum install freetype-devel >> This solve the problem.. >> >> Going to validate the "alsa" now... >> >> Regards, >> Helio >> >> >> 2013/7/24 Omair Majid >> >>> On 07/24/2013 03:44 PM, Helio Frota wrote: >>> > Hi, >>> > >>> > Another problem: >>> > >>> > configure: error: Could not find all X11 headers (shape.h Xrender.h >>> > XTest.h). You might be able to fix this by running 'sudo yum install >>> > libXtst-devel'. >>> > configure exiting with result code 1 >>> > >>> > I did this, but the error persists. >>> > >>> > Going to investigate... >>> > >>> >>> The package manager suggestions are very unlikely to be exactly right >>> for all versions of all distributions. You can follow the error message >>> to get better results and install the files it is complaining about. >>> >>> For example, using yum, you can ask to install the package that provides >>> this file (eg XTest.h) by name: >>> >>> # yum install '*/XTest.h' >>> >>> You should do the same for all other header file dependencies configure >>> complains about. >>> >>> If you are on Fedora 19, you can also get all the dependencies faster by >>> getting all the dependencies that java-1.8.0-openjdk (that's what the >>> OpenJDK 8 package is called in Fedora) declares: >>> >>> # yum-builddep java-1.8.0-openjdk >>> >>> This may not be as up-to-date as what configure expects, though. It >>> should be faster. >>> >>> Cheers, >>> Omair >>> >>> -- >>> PGP Key: 66484681 (http://pgp.mit.edu/) >>> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 >>> >> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From omajid at redhat.com Wed Jul 24 20:27:15 2013 From: omajid at redhat.com (Omair Majid) Date: Wed, 24 Jul 2013 16:27:15 -0400 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> Message-ID: <51F038A3.1010001@redhat.com> On 07/24/2013 04:11 PM, Helio Frota wrote: > Hi, > > I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro > son of archlinux ) > > Generating precompiled header precompiled.hpp.gch > cc1plus: error: the "stabs" debug format cannot be used with > pre-compiled headers [-Werror=deprecated] > cc1plus: all warnings being treated as errors > gmake[6]: *** [precompiled.hpp.gch] Error 1 > gmake[5]: *** [the_vm] Error 2 > gmake[4]: *** [product] Error 2 > gmake[3]: *** [generic_build2] Error 2 > gmake[2]: *** [product] Error 2 > gmake[1]: *** > [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/hotspot/_hotspot.timestamp] > Error 2 > make: *** [hotspot-only] Error 2 from hotspot/make/linux/makefiles/gcc.make: # DEBUG_BINARIES uses full -g debug information for all configs ifeq ($(DEBUG_BINARIES), true) CFLAGS += -g else # Use the stabs format for debugging information (this is the default # on gcc-2.91). It's good enough, has all the information about line # numbers and local variables, and libjvm.so is only about 16M. # Change this back to "-g" if you want the most expressive format. # (warning: that could easily inflate libjvm.so to 150M!) The only problem is that modern gcc versions don't produce stabs either. Try: $ make DEBUG_BINARIES=true all Cheers, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From heliofrota at gmail.com Wed Jul 24 21:00:34 2013 From: heliofrota at gmail.com (Helio Frota) Date: Wed, 24 Jul 2013 18:00:34 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: <51F038A3.1010001@redhat.com> References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> <51F038A3.1010001@redhat.com> Message-ID: Hi Omair, The only problem is that modern gcc versions don't produce stabs either. Try: $ make DEBUG_BINARIES=true all Thanks for the tip ! I will try again tomorrow on job (fedora19) machine. Regards, Helio 2013/7/24 Omair Majid > On 07/24/2013 04:11 PM, Helio Frota wrote: > > Hi, > > > > I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro > > son of archlinux ) > > > > Generating precompiled header precompiled.hpp.gch > > cc1plus: error: the "stabs" debug format cannot be used with > > pre-compiled headers [-Werror=deprecated] > > cc1plus: all warnings being treated as errors > > gmake[6]: *** [precompiled.hpp.gch] Error 1 > > gmake[5]: *** [the_vm] Error 2 > > gmake[4]: *** [product] Error 2 > > gmake[3]: *** [generic_build2] Error 2 > > gmake[2]: *** [product] Error 2 > > gmake[1]: *** > > > [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/hotspot/_hotspot.timestamp] > > Error 2 > > make: *** [hotspot-only] Error 2 > > from hotspot/make/linux/makefiles/gcc.make: > > # DEBUG_BINARIES uses full -g debug information for all configs > ifeq ($(DEBUG_BINARIES), true) > CFLAGS += -g > else > # Use the stabs format for debugging information (this is the default > # on gcc-2.91). It's good enough, has all the information about line > # numbers and local variables, and libjvm.so is only about 16M. > # Change this back to "-g" if you want the most expressive format. > # (warning: that could easily inflate libjvm.so to 150M!) > > The only problem is that modern gcc versions don't produce stabs either. > > Try: > > $ make DEBUG_BINARIES=true all > > Cheers, > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From christian.thalinger at oracle.com Wed Jul 24 21:59:10 2013 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Wed, 24 Jul 2013 14:59:10 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51EFC56C.6040304@oracle.com> References: <51EF006D.3060805@oracle.com> <51EFBDC9.4070200@oracle.com> <51EFC56C.6040304@oracle.com> Message-ID: On Jul 24, 2013, at 5:15 AM, Tim Bell wrote: > On 07/24/13 04:43 AM, David Holmes wrote: >> Hi Tim, >> >> On 24/07/2013 8:15 AM, Tim Bell wrote: >>> Hello everyone- >>> >>> This is a small set of changes to switch from gcc to clang when building >> >> So we already added support for clang as the compiler for hotspot - is this just extending things to allow configure to select clang? > > The earlier clang/hotspot activity was centered around Linux x86/x86_64. That's not true. I've added Mac OS X support with the same change. -- Chris > >>> on MacOS, and also enable building on MacOS 8.x >> >> Have we already updated all the JPRT queues to have 10.8 macs versus 10.7 ones? > > Yes, all the queues have 10.8 Macs, which have been test-only up until now. > >>> Here is the bug report: >>> >>> http://bugs.sun.com/view_bug.do?bug_id=8019470 >>> >>> Here are the webrevs: >>> >>> Hotspot only: >>> >>> http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ >> >> src/os/bsd/vm/os_bsd.cpp >> >> Again I'm confused. We already allowed building via clang so why wasn't this change needed before? > > This file is not used when building on Linux. > > Tim > >> >> Thanks, >> David >> >>> All of the changes: >>> >>> http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ >> >> >>> Thanks in advance. >>> >>> Tim >>> > From tim.bell at oracle.com Wed Jul 24 22:48:03 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 24 Jul 2013 15:48:03 -0700 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: References: <51EF006D.3060805@oracle.com> <51EFBDC9.4070200@oracle.com> <51EFC56C.6040304@oracle.com> Message-ID: <51F059A3.3080403@oracle.com> Christian: > That's not true. I've added Mac OS X support with the same change. For building hotspot only, perhaps. I want to build the entire product, start to finish, using clang. That's why I needed to touch these files: common/autoconf/hotspot-spec.gmk.in common/autoconf/toolchain.m4 make/jprt.properties Tim On 07/24/13 02:59 PM, Christian Thalinger wrote: > On Jul 24, 2013, at 5:15 AM, Tim Bell wrote: > >> On 07/24/13 04:43 AM, David Holmes wrote: >>> Hi Tim, >>> >>> On 24/07/2013 8:15 AM, Tim Bell wrote: >>>> Hello everyone- >>>> >>>> This is a small set of changes to switch from gcc to clang when building >>> So we already added support for clang as the compiler for hotspot - is this just extending things to allow configure to select clang? >> The earlier clang/hotspot activity was centered around Linux x86/x86_64. > That's not true. I've added Mac OS X support with the same change. > > -- Chris > >>>> on MacOS, and also enable building on MacOS 8.x >>> Have we already updated all the JPRT queues to have 10.8 macs versus 10.7 ones? >> Yes, all the queues have 10.8 Macs, which have been test-only up until now. >> >>>> Here is the bug report: >>>> >>>> http://bugs.sun.com/view_bug.do?bug_id=8019470 >>>> >>>> Here are the webrevs: >>>> >>>> Hotspot only: >>>> >>>> http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ >>> src/os/bsd/vm/os_bsd.cpp >>> >>> Again I'm confused. We already allowed building via clang so why wasn't this change needed before? >> This file is not used when building on Linux. >> >> Tim >> >>> Thanks, >>> David >>> >>>> All of the changes: >>>> >>>> http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ >>> >>>> Thanks in advance. >>>> >>>> Tim >>>> From omajid at redhat.com Thu Jul 25 02:07:39 2013 From: omajid at redhat.com (Omair Majid) Date: Wed, 24 Jul 2013 22:07:39 -0400 Subject: [OpenJDK 2D-Dev] Add optional support for using the system libicu In-Reply-To: <51D4795D.9050908@oracle.com> References: <51AE5C60.1080303@redhat.com> <51AF0300.80808@oracle.com> <51AF7D19.7010105@oracle.com> <51C8C4C7.6040104@redhat.com> <51C8E32F.5090908@oracle.com> <51D4795D.9050908@oracle.com> Message-ID: <51F0886B.2020307@redhat.com> Hi Steven, On 07/03/2013 03:19 PM, Steven R. Loomis wrote: > Omair, > I didn't hear back from you on this list, but I will reply here with > more details. Sorry about the delay, I got busy with unrelated work. > See diffs below. I would be very suspicious of how this > could run without crashing, That's very interesting. Looking at the diff, I am not sure how my patch even compiles. And just to be sure that I was not making a mistake, I tried building today with my patch after removing the jdk/src/share/native/sun/font/layout/. It built fine. > if the tests I mentioned were run (anything > with 'kerning' in its name, using a font that actually uses kerning pairs). I ran through all the jtreg font tests I could see in the JDK. I also ran jdk/test/java/awt/font/TextLayout/KernCrash.java and jdk/test/java/awt/font/TextLayout/KerningLeak.java manually and they both passed. (KernCrash just opened up a window with some text displayed and no errors. I closed it after a few minutes). But maybe I just don't have the right fonts? KernCrash wanted Bistream Vera (Vera.ttf); I passed it the path to the system-install Vera.tff. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From david.holmes at oracle.com Thu Jul 25 04:44:13 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 25 Jul 2013 14:44:13 +1000 Subject: RFR: 8019470 "Changes needed to compile JDK8 on MacOS with clang compiler" In-Reply-To: <51F059A3.3080403@oracle.com> References: <51EF006D.3060805@oracle.com> <51EFBDC9.4070200@oracle.com> <51EFC56C.6040304@oracle.com> <51F059A3.3080403@oracle.com> Message-ID: <51F0AD1D.1080907@oracle.com> On 25/07/2013 8:48 AM, Tim Bell wrote: > Christian: > >> That's not true. I've added Mac OS X support with the same change. > > For building hotspot only, perhaps. I want to build the entire product, > start to finish, using clang. > > That's why I needed to touch these files: > > common/autoconf/hotspot-spec.gmk.in > common/autoconf/toolchain.m4 > make/jprt.properties Yes but that doesn't explain the change now needed to os_bsd.cpp in hotspot. David ----- > > Tim > > > On 07/24/13 02:59 PM, Christian Thalinger wrote: >> On Jul 24, 2013, at 5:15 AM, Tim Bell wrote: >> >>> On 07/24/13 04:43 AM, David Holmes wrote: >>>> Hi Tim, >>>> >>>> On 24/07/2013 8:15 AM, Tim Bell wrote: >>>>> Hello everyone- >>>>> >>>>> This is a small set of changes to switch from gcc to clang when >>>>> building >>>> So we already added support for clang as the compiler for hotspot - >>>> is this just extending things to allow configure to select clang? >>> The earlier clang/hotspot activity was centered around Linux x86/x86_64. >> That's not true. I've added Mac OS X support with the same change. >> >> -- Chris >> >>>>> on MacOS, and also enable building on MacOS 8.x >>>> Have we already updated all the JPRT queues to have 10.8 macs versus >>>> 10.7 ones? >>> Yes, all the queues have 10.8 Macs, which have been test-only up >>> until now. >>> >>>>> Here is the bug report: >>>>> >>>>> http://bugs.sun.com/view_bug.do?bug_id=8019470 >>>>> >>>>> Here are the webrevs: >>>>> >>>>> Hotspot only: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8019470/hotspot/webrev.00/ >>>> src/os/bsd/vm/os_bsd.cpp >>>> >>>> Again I'm confused. We already allowed building via clang so why >>>> wasn't this change needed before? >>> This file is not used when building on Linux. >>> >>> Tim >>> >>>> Thanks, >>>> David >>>> >>>>> All of the changes: >>>>> >>>>> http://cr.openjdk.java.net/~tbell/8019470/webrev.00/ >>>> >>>>> Thanks in advance. >>>>> >>>>> Tim >>>>> > From heliofrota at gmail.com Thu Jul 25 11:12:20 2013 From: heliofrota at gmail.com (Helio Frota) Date: Thu, 25 Jul 2013 08:12:20 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> <51F038A3.1010001@redhat.com> Message-ID: Hi Omair and Alan, I get this error: In file included from /home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/gensrc_x11wrappers/sizer.32.c:11:0: /home/hf/adopt_openjdk/openjdk8/jdk/src/solaris/native/sun/awt/awt_p.h:44:27: fatal error: X11/Intrinsic.h: No such file or directory #include ^ compilation terminated. gmake[2]: *** [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/gensrc_x11wrappers/sizer.32.exe] Error 1 gmake[2]: *** Waiting for unfinished jobs.... gmake[1]: *** [gensrc-only] Error 2 make: *** [jdk-only] Error 2 Omair thanks for the tip "make DEBUG_BINARIES=true all" works. Regards, Helio 2013/7/24 Helio Frota > Hi Omair, > > > The only problem is that modern gcc versions don't produce stabs either. > Try: > $ make DEBUG_BINARIES=true all > > Thanks for the tip ! > > I will try again tomorrow on job (fedora19) machine. > > Regards, > Helio > > > > 2013/7/24 Omair Majid > >> On 07/24/2013 04:11 PM, Helio Frota wrote: >> > Hi, >> > >> > I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro >> > son of archlinux ) >> > >> > Generating precompiled header precompiled.hpp.gch >> > cc1plus: error: the "stabs" debug format cannot be used with >> > pre-compiled headers [-Werror=deprecated] >> > cc1plus: all warnings being treated as errors >> > gmake[6]: *** [precompiled.hpp.gch] Error 1 >> > gmake[5]: *** [the_vm] Error 2 >> > gmake[4]: *** [product] Error 2 >> > gmake[3]: *** [generic_build2] Error 2 >> > gmake[2]: *** [product] Error 2 >> > gmake[1]: *** >> > >> [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/hotspot/_hotspot.timestamp] >> > Error 2 >> > make: *** [hotspot-only] Error 2 >> >> from hotspot/make/linux/makefiles/gcc.make: >> >> # DEBUG_BINARIES uses full -g debug information for all configs >> ifeq ($(DEBUG_BINARIES), true) >> CFLAGS += -g >> else >> # Use the stabs format for debugging information (this is the default >> # on gcc-2.91). It's good enough, has all the information about line >> # numbers and local variables, and libjvm.so is only about 16M. >> # Change this back to "-g" if you want the most expressive format. >> # (warning: that could easily inflate libjvm.so to 150M!) >> >> The only problem is that modern gcc versions don't produce stabs either. >> >> Try: >> >> $ make DEBUG_BINARIES=true all >> >> Cheers, >> Omair >> >> -- >> PGP Key: 66484681 (http://pgp.mit.edu/) >> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 >> > > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Thu Jul 25 11:52:44 2013 From: heliofrota at gmail.com (Helio Frota) Date: Thu, 25 Jul 2013 08:52:44 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> <51F038A3.1010001@redhat.com> Message-ID: Hi sudo yum install libXt-devel solve the dependency problem. but i get other... cc1: all warnings being treated as errors gmake[2]: *** [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/objs/libsctp/SctpChannelImpl.o] Error 1 gmake[2]: *** Waiting for unfinished jobs.... cc1: all warnings being treated as errors gmake[2]: *** [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/objs/libsctp/SctpNet.o] Error 1 gmake[1]: *** [libs-only] Error 2 make: *** [jdk-only] Error 2 is right disable warnings treated as errors ? Regards, Helio 2013/7/25 Helio Frota > Hi Omair and Alan, > > > I get this error: > > In file included from > /home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/gensrc_x11wrappers/sizer.32.c:11:0: > /home/hf/adopt_openjdk/openjdk8/jdk/src/solaris/native/sun/awt/awt_p.h:44:27: > fatal error: X11/Intrinsic.h: No such file or directory > #include > ^ > compilation terminated. > gmake[2]: *** > [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/gensrc_x11wrappers/sizer.32.exe] > Error 1 > gmake[2]: *** Waiting for unfinished jobs.... > gmake[1]: *** [gensrc-only] Error 2 > > make: *** [jdk-only] Error 2 > > Omair thanks for the tip "make DEBUG_BINARIES=true all" works. > > Regards, > Helio > > > > 2013/7/24 Helio Frota > >> Hi Omair, >> >> >> The only problem is that modern gcc versions don't produce stabs either. >> Try: >> $ make DEBUG_BINARIES=true all >> >> Thanks for the tip ! >> >> I will try again tomorrow on job (fedora19) machine. >> >> Regards, >> Helio >> >> >> >> 2013/7/24 Omair Majid >> >>> On 07/24/2013 04:11 PM, Helio Frota wrote: >>> > Hi, >>> > >>> > I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro >>> > son of archlinux ) >>> > >>> > Generating precompiled header precompiled.hpp.gch >>> > cc1plus: error: the "stabs" debug format cannot be used with >>> > pre-compiled headers [-Werror=deprecated] >>> > cc1plus: all warnings being treated as errors >>> > gmake[6]: *** [precompiled.hpp.gch] Error 1 >>> > gmake[5]: *** [the_vm] Error 2 >>> > gmake[4]: *** [product] Error 2 >>> > gmake[3]: *** [generic_build2] Error 2 >>> > gmake[2]: *** [product] Error 2 >>> > gmake[1]: *** >>> > >>> [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/hotspot/_hotspot.timestamp] >>> > Error 2 >>> > make: *** [hotspot-only] Error 2 >>> >>> from hotspot/make/linux/makefiles/gcc.make: >>> >>> # DEBUG_BINARIES uses full -g debug information for all configs >>> ifeq ($(DEBUG_BINARIES), true) >>> CFLAGS += -g >>> else >>> # Use the stabs format for debugging information (this is the default >>> # on gcc-2.91). It's good enough, has all the information about line >>> # numbers and local variables, and libjvm.so is only about 16M. >>> # Change this back to "-g" if you want the most expressive format. >>> # (warning: that could easily inflate libjvm.so to 150M!) >>> >>> The only problem is that modern gcc versions don't produce stabs either. >>> >>> Try: >>> >>> $ make DEBUG_BINARIES=true all >>> >>> Cheers, >>> Omair >>> >>> -- >>> PGP Key: 66484681 (http://pgp.mit.edu/) >>> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 >>> >> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From heliofrota at gmail.com Fri Jul 26 13:46:14 2013 From: heliofrota at gmail.com (Helio Frota) Date: Fri, 26 Jul 2013 10:46:14 -0300 Subject: Build error with GCC4.8 on Fedora19 In-Reply-To: References: <20130709045501.4D23E3B6274@msgw008-05.ocn.ad.jp> <51DBA3CD.9020605@oracle.com> <51DBBE7C.6070801@oracle.com> <51DDAF72.4000909@redhat.com> <51F01E07.3070808@oracle.com> <51F030E1.6090407@redhat.com> <51F038A3.1010001@redhat.com> Message-ID: Hi, Just feedback , build was ok with fedora 19. Thanks Omair Majid for the flag tips. $ sudo yum groupinstall "Development Tools" $ sudo yum install gcc-c++ $ sudo yum install libXrender-devel $ sudo yum install freetype-devel $ sudo yum install libXt-devel $ ./configure $ make DEBUG_BINARIES=true SCTP_WERROR="" all Thanks, Helio 2013/7/25 Helio Frota > Hi > > sudo yum install libXt-devel solve the dependency problem. > > but i get other... > > cc1: all warnings being treated as errors > gmake[2]: *** > [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/objs/libsctp/SctpChannelImpl.o] > Error 1 > > gmake[2]: *** Waiting for unfinished jobs.... > cc1: all warnings being treated as errors > gmake[2]: *** > [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/objs/libsctp/SctpNet.o] > Error 1 > gmake[1]: *** [libs-only] Error 2 > > make: *** [jdk-only] Error 2 > > is right disable warnings treated as errors ? > > Regards, > Helio > > > > > > 2013/7/25 Helio Frota > >> Hi Omair and Alan, >> >> >> I get this error: >> >> In file included from >> /home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/gensrc_x11wrappers/sizer.32.c:11:0: >> /home/hf/adopt_openjdk/openjdk8/jdk/src/solaris/native/sun/awt/awt_p.h:44:27: >> fatal error: X11/Intrinsic.h: No such file or directory >> #include >> ^ >> compilation terminated. >> gmake[2]: *** >> [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/jdk/gensrc_x11wrappers/sizer.32.exe] >> Error 1 >> gmake[2]: *** Waiting for unfinished jobs.... >> gmake[1]: *** [gensrc-only] Error 2 >> >> make: *** [jdk-only] Error 2 >> >> Omair thanks for the tip "make DEBUG_BINARIES=true all" works. >> >> Regards, >> Helio >> >> >> >> 2013/7/24 Helio Frota >> >>> Hi Omair, >>> >>> >>> The only problem is that modern gcc versions don't produce stabs either. >>> Try: >>> $ make DEBUG_BINARIES=true all >>> >>> Thanks for the tip ! >>> >>> I will try again tomorrow on job (fedora19) machine. >>> >>> Regards, >>> Helio >>> >>> >>> >>> 2013/7/24 Omair Majid >>> >>>> On 07/24/2013 04:11 PM, Helio Frota wrote: >>>> > Hi, >>>> > >>>> > I got the same problem with GCC 4.8.1 and Manjaro distribution ( >>>> distro >>>> > son of archlinux ) >>>> > >>>> > Generating precompiled header precompiled.hpp.gch >>>> > cc1plus: error: the "stabs" debug format cannot be used with >>>> > pre-compiled headers [-Werror=deprecated] >>>> > cc1plus: all warnings being treated as errors >>>> > gmake[6]: *** [precompiled.hpp.gch] Error 1 >>>> > gmake[5]: *** [the_vm] Error 2 >>>> > gmake[4]: *** [product] Error 2 >>>> > gmake[3]: *** [generic_build2] Error 2 >>>> > gmake[2]: *** [product] Error 2 >>>> > gmake[1]: *** >>>> > >>>> [/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release/hotspot/_hotspot.timestamp] >>>> > Error 2 >>>> > make: *** [hotspot-only] Error 2 >>>> >>>> from hotspot/make/linux/makefiles/gcc.make: >>>> >>>> # DEBUG_BINARIES uses full -g debug information for all configs >>>> ifeq ($(DEBUG_BINARIES), true) >>>> CFLAGS += -g >>>> else >>>> # Use the stabs format for debugging information (this is the default >>>> # on gcc-2.91). It's good enough, has all the information about line >>>> # numbers and local variables, and libjvm.so is only about 16M. >>>> # Change this back to "-g" if you want the most expressive format. >>>> # (warning: that could easily inflate libjvm.so to 150M!) >>>> >>>> The only problem is that modern gcc versions don't produce stabs either. >>>> >>>> Try: >>>> >>>> $ make DEBUG_BINARIES=true all >>>> >>>> Cheers, >>>> Omair >>>> >>>> -- >>>> PGP Key: 66484681 (http://pgp.mit.edu/) >>>> Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 >>>> >>> >>> >>> >>> -- >>> Helio Frota >>> JUG Leader - CEJUG >>> http://www.cejug.org/ >>> http://www.linkedin.com/in/heliofrota >>> >>> >>> >> >> >> -- >> Helio Frota >> JUG Leader - CEJUG >> http://www.cejug.org/ >> http://www.linkedin.com/in/heliofrota >> >> >> > > > -- > Helio Frota > JUG Leader - CEJUG > http://www.cejug.org/ > http://www.linkedin.com/in/heliofrota > > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From jonathan.gibbons at oracle.com Fri Jul 26 18:25:22 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 26 Jul 2013 11:25:22 -0700 Subject: when to reconfigure? Message-ID: <51F2BF12.2090705@oracle.com> Build folk, I want to writing a script that loops over recent changesets, and builds JDK each time. One factor to take into account is that I will occasionally need to rerun the configure script. Is it enough to see if (just) the generated-configure.sh has changed? Or, do I need to check if any other files may have changed as well? -- Jon From tim.bell at oracle.com Fri Jul 26 18:58:07 2013 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 26 Jul 2013 11:58:07 -0700 Subject: when to reconfigure? In-Reply-To: <51F2BF12.2090705@oracle.com> References: <51F2BF12.2090705@oracle.com> Message-ID: <51F2C6BF.1080507@oracle.com> Hi Jon: > Build folk, > > I want to writing a script that loops over recent changesets, and > builds JDK each time. One factor to take into account is that I will > occasionally need to rerun the configure script. > > Is it enough to see if (just) the generated-configure.sh has changed? > Or, do I need to check if any other files may have changed as well The generated-configure.sh files (there are two, one in open, one in closed) are supposed to be regenerated and checked in whenever any of the open/closed .m4 files are touched. From time to time, we get OpenJDK fixes that involve the common/autoconf/*.m4 files. In this case, even if the open generated-configure.sh file is updated and checked in as per the normal procedure, someone inside Oracle needs to step in and push an update to the closed generated-configure.sh. The closed side of the build will be broken until one of us does this. Yes, this is unfortunate, but we do not have a better solution so far. In summary, you should also look for updates to the .m4 files. Tim From jonathan.gibbons at oracle.com Fri Jul 26 19:13:22 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 26 Jul 2013 12:13:22 -0700 Subject: when to reconfigure? In-Reply-To: <51F2C6BF.1080507@oracle.com> References: <51F2BF12.2090705@oracle.com> <51F2C6BF.1080507@oracle.com> Message-ID: <51F2CA52.2050405@oracle.com> On 07/26/2013 11:58 AM, Tim Bell wrote: > Hi Jon: > >> Build folk, >> >> I want to writing a script that loops over recent changesets, and >> builds JDK each time. One factor to take into account is that I will >> occasionally need to rerun the configure script. >> >> Is it enough to see if (just) the generated-configure.sh has changed? >> Or, do I need to check if any other files may have changed as well > > The generated-configure.sh files (there are two, one in open, one in > closed) are supposed to be regenerated and checked in whenever any of > the open/closed .m4 files are touched. > > From time to time, we get OpenJDK fixes that involve the > common/autoconf/*.m4 files. In this case, even if the open > generated-configure.sh file is updated and checked in as per the > normal procedure, someone inside Oracle needs to step in and push an > update to the closed generated-configure.sh. The closed side of the > build will be broken until one of us does this. Yes, this is > unfortunate, but we do not have a better solution so far. > > In summary, you should also look for updates to the .m4 files. > > Tim > Thanks. Yes, in the end I simply checked the entire contents of the autoconf directory. --Jon From peter.brunet at oracle.com Sat Jul 27 01:41:28 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 26 Jul 2013 20:41:28 -0500 Subject: jdk 8 building just jdk Message-ID: <51F32548.3030204@oracle.com> Am doing my first jdk8 build. After reading through the build readme I didn't see any info on building just jdk and using an import lib. I'm guessing this is no longer possible but checking... Pete From mike.duigou at oracle.com Sat Jul 27 03:38:23 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 26 Jul 2013 20:38:23 -0700 Subject: jdk 8 building just jdk In-Reply-To: <51F32548.3030204@oracle.com> References: <51F32548.3030204@oracle.com> Message-ID: <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> On Jul 26 2013, at 18:41 , Pete Brunet wrote: > Am doing my first jdk8 build. After reading through the build readme I > didn't see any info on building just jdk and using an import lib. I'm > guessing this is no longer possible but checking... It's probably possible but usually not necessary. Even on a modest system a full build takes only 20 minutes and an incremental rebuild is less than 3 minutes (even faster if you use sjavac or JDK_FILTER). Mike From peter.brunet at oracle.com Sat Jul 27 04:14:17 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 26 Jul 2013 23:14:17 -0500 Subject: jdk8 first build attempt - failed Message-ID: <51F34919.8010900@oracle.com> Hi, My build was running pretty well but then failed inside the jdk build. My invocation was: cd .../jdk8 bash ./configure --withfreetype=... --with-target-bits=32 --with-debug-level=fastdebug make all The log is ... ## Starting jdk Importing CORBA src.zip Importing CORBA classes.jar Importing CORBA bin.zip Importing JAXP src.zip Importing JAXP classes.jar Importing JAXWS src.zip Importing JAXWS classes.jar Importing LANGTOOLS src.zip Importing LANGTOOLS classes.jar Compiling 166 files for BUILD_TOOLS Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 for 80x86 Copyright (C) Microsoft Corporation. All rights reserved. genSocketOptionRegistry.c Generating charsetmapping classes Generating buffer classes Generating exceptions classes Microsoft (R) Incremental Linker Version 10.00.40219.01 Copyright (C) Microsoft Corporation. All rights reserved. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. Copying and cleaning 53 properties Compiling 522 properties into resource bundles Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. Generating sun/misc/Version.java Generating sun/misc/Version.java compact1 Generating sun/misc/Version.java compact2 Generating sun/misc/Version.java compact3 Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 Classes: Table size 32 (5 bits), shift 1, max chain depth 3 Cache: Table size 32 (5 bits), shift 1, max chain depth 3 Generating beaninfo Generating Nimbus source files [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, 16.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) Compiling 4 files for BUILD_BREAKITERATOR Generating HTML DTD file [Parsed DTD html32 in 801ms] Compiling 9795 files for BUILD_JDK c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: error: cannot find symbol private BindingListHolder _bindingList; // list of bindings ^ symbol: class BindingListHolder location: class CNBindingEnumeration c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: error: cannot find symbol private BindingIterator _bindingIter; // iterator for getting list of bindings ^ symbol: class BindingIterator location: class CNBindingEnumeration c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: error: package org.omg.CosNaming.NamingContextPackage does not exist import org.omg.CosNaming.NamingContextPackage.*; ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: error: cannot find symbol private javax.naming.Binding mapBinding(org.omg.CosNaming.Binding bndg) ^ symbol: class Binding location: package org.omg.CosNaming c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: error: cannot find symbol public NamingContext _nc; // public for accessing underlying NamingContext ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: error: cannot find symbol private NameComponent[] _name = null; ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: error: cannot find symbol import org.omg.CosNaming.NameComponent; ^ symbol: class NameComponent location: package org.omg.CosNaming c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: error: cannot find symbol CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: error: cannot find symbol Hashtable env, NameComponent[]name) ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: error: cannot find symbol NameComponent[] makeFullName(NameComponent[] child) { ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: error: cannot find symbol NameComponent[] makeFullName(NameComponent[] child) { ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: error: cannot find symbol java.lang.Object callResolve(NameComponent[] path) ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: error: cannot find symbol private void callBindOrRebind(NameComponent[] pth, Name name, ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: error: cannot find symbol private void callUnbind(NameComponent[] path) throws NamingException { ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: error: cannot find symbol private boolean leafNotFound(NotFound e, NameComponent leaf) { ^ symbol: class NotFound location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: error: cannot find symbol private boolean leafNotFound(NotFound e, NameComponent leaf) { ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: error: cannot find symbol private void callDestroy(NamingContext nc) ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: error: cannot find symbol private javax.naming.Context callBindNewContext(NameComponent[] path) ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: error: cannot find symbol static NameComponent[] nameToCosName(Name name) ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: error: cannot find symbol static String cosNameToInsString(NameComponent[] cname) { ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: error: cannot find symbol static Name cosNameToName(NameComponent[] cname) { ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: error: cannot find symbol private static NameComponent parseComponent(String compStr) ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: error: cannot find symbol private static String stringifyComponent(NameComponent comp) { ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: error: package org.omg.CosNaming.NamingContextPackage does not exist import org.omg.CosNaming.NamingContextPackage.*; ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: error: cannot find symbol CNCtx ctx, NameComponent[] inputName) throws NamingException { ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: error: cannot find symbol private static final NamingException tryFed(NotFound e, CNCtx ctx, ^ symbol: class NotFound location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: error: cannot find symbol NameComponent[] inputName) throws NamingException { ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: warning: auxiliary class InetAddressContainer in c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java should not be accessed from outside its own source file static native void localAddress(int fd, InetAddressContainer in) throws SocketException; ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: error: cannot find symbol _bindingList = new BindingListHolder(); ^ symbol: class BindingListHolder location: class CNBindingEnumeration c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: error: cannot find symbol BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); ^ symbol: class BindingIteratorHolder location: class CNBindingEnumeration c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: error: cannot find symbol BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); ^ symbol: class BindingIteratorHolder location: class CNBindingEnumeration c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: error: cannot find symbol org.omg.CosNaming.Binding bndg = _bindingList.value[counter]; ^ symbol: class Binding location: package org.omg.CosNaming c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: error: cannot find symbol NameComponent[] comps = _ctx.makeFullName(bndg.binding_name); ^ symbol: class NameComponent location: class CNBindingEnumeration c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: error: cannot find symbol NameComponent[] answer = new NameComponent[_name.length+child.length]; ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: error: cannot find symbol NameComponent[] answer = new NameComponent[_name.length+child.length]; ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: error: cannot find symbol _nc = NamingContextHelper.narrow(obj); ^ symbol: variable NamingContextHelper location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: error: cannot find symbol _nc = NamingContextHelper.narrow(ncRef); ^ symbol: variable NamingContextHelper location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: error: cannot find symbol _nc = NamingContextHelper.narrow(ncRef); ^ symbol: variable NamingContextHelper location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: error: cannot find symbol NamingContext nc = ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: error: cannot find symbol NamingContextHelper.narrow(obj); ^ symbol: variable NamingContextHelper location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: error: cannot find symbol NameComponent[] path = CNNameParser.nameToCosName(name); ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: error: cannot find symbol if ( obj instanceof org.omg.CosNaming.NamingContext) { ^ symbol: class NamingContext location: package org.omg.CosNaming c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: error: cannot find symbol NamingContext nobj = ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: error: cannot find symbol NamingContextHelper.narrow((org.omg.CORBA.Object)obj); ^ symbol: variable NamingContextHelper location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: error: cannot find symbol NameComponent[] path = CNNameParser.nameToCosName(name); ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: error: cannot find symbol NameComponent[] path = CNNameParser.nameToCosName(name); ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: error: cannot find symbol } catch (NotFound e) { ^ symbol: class NotFound location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: error: cannot find symbol NameComponent rest; ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: error: cannot find symbol return e.why.value() == NotFoundReason._missing_node && ^ symbol: variable NotFoundReason location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: error: cannot find symbol NameComponent[] path = CNNameParser.nameToCosName(name); ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: error: cannot find symbol NamingContext the_nc = _nc; ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: error: cannot find symbol NameComponent[] path = CNNameParser.nameToCosName(name); ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: error: cannot find symbol if (e.getRootCause() instanceof NotFound && ^ symbol: class NotFound location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: error: cannot find symbol leafNotFound((NotFound)e.getRootCause(), ^ symbol: class NotFound location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: error: cannot find symbol NamingContext nctx = _nc.bind_new_context(path); ^ symbol: class NamingContext location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: error: cannot find symbol NameComponent[] path = CNNameParser.nameToCosName(name); ^ symbol: class NameComponent location: class CNCtx c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: error: cannot find symbol return new NameComponent[0]; ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: error: cannot find symbol NameComponent[] answer = new NameComponent[len]; ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: error: cannot find symbol NameComponent[] answer = new NameComponent[len]; ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: error: cannot find symbol new NameComponent(new String(id, 0, idCount), ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: error: cannot find symbol NameComponent comp = new NameComponent(); ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: error: cannot find symbol NameComponent comp = new NameComponent(); ^ symbol: class NameComponent location: class CNNameParser c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: error: cannot find symbol if (e instanceof NotFound) { ^ symbol: class NotFound location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: error: cannot find symbol return tryFed((NotFound)e, ctx, inputName); ^ symbol: class NotFound location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: error: cannot find symbol } else if (e instanceof CannotProceed) { ^ symbol: class CannotProceed location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: error: cannot find symbol NamingContext nc = ((CannotProceed) e).cxt; ^ symbol: class NamingContext location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: error: cannot find symbol NamingContext nc = ((CannotProceed) e).cxt; ^ symbol: class CannotProceed location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: error: cannot find symbol NameComponent[] rest = ((CannotProceed) e).rest_of_name; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: error: cannot find symbol NameComponent[] rest = ((CannotProceed) e).rest_of_name; ^ symbol: class CannotProceed location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: error: cannot find symbol NameComponent[] resolvedName = ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: error: cannot find symbol new NameComponent[inputName.length - rest.length]; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: error: cannot find symbol } else if (e instanceof InvalidName) { ^ symbol: class InvalidName location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: error: cannot find symbol } else if (e instanceof AlreadyBound) { ^ symbol: class AlreadyBound location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: error: cannot find symbol } else if (e instanceof NotEmpty) { ^ symbol: class NotEmpty location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: error: cannot find symbol NameComponent[] rest = e.rest_of_name; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: error: cannot find symbol NameComponent lastIn = inputName[inputName.length-1]; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: error: cannot find symbol NameComponent[] resolvedName = null; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: error: cannot find symbol if (e.why == NotFoundReason.not_context) { ^ symbol: variable NotFoundReason location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: error: cannot find symbol NameComponent[] tmp = new NameComponent[rest.length-1]; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: error: cannot find symbol NameComponent[] tmp = new NameComponent[rest.length-1]; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: error: cannot find symbol resolvedName = new NameComponent[len]; ^ symbol: class NameComponent location: class ExceptionMapper c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: warning: [overrides] Class XMLX509IssuerSerial overrides equals, but neither it nor any superclass overrides hashCode method public class XMLX509IssuerSerial extends SignatureElementProxy ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: warning: [overrides] Class XMLX509SKI overrides equals, but neither it nor any superclass overrides hashCode method public class XMLX509SKI extends SignatureElementProxy ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: warning: [overrides] Class XMLX509SubjectName overrides equals, but neither it nor any superclass overrides hashCode method public class XMLX509SubjectName extends SignatureElementProxy ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: warning: [overrides] Class XMLX509Certificate overrides equals, but neither it nor any superclass overrides hashCode method public class XMLX509Certificate extends SignatureElementProxy ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: warning: [overrides] Class DOMTransform overrides equals, but neither it nor any superclass overrides hashCode method public class DOMTransform extends DOMStructure implements Transform { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: warning: [overrides] Class DOMCanonicalizationMethod overrides equals, but neither it nor any superclass overrides hashCode method public class DOMCanonicalizationMethod extends DOMTransform ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: warning: [overrides] Class DOMSignedInfo overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMSignedInfo extends DOMStructure implements SignedInfo { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: warning: [overrides] Class DOMKeyInfo overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMKeyInfo extends DOMStructure implements KeyInfo { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: warning: [overrides] Class DOMKeyName overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMKeyName extends DOMStructure implements KeyName { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: warning: [overrides] Class DOMKeyValue overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMKeyValue extends DOMStructure implements KeyValue { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: warning: [overrides] Class DOMManifest overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMManifest extends DOMStructure implements Manifest { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: warning: [overrides] Class DOMReference overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMReference extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: warning: [overrides] Class DOMRetrievalMethod overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMRetrievalMethod extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: warning: [overrides] Class DOMSignatureProperties overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMSignatureProperties extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: warning: [overrides] Class DOMSignatureProperty overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMSignatureProperty extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: warning: [overrides] Class DOMX509Data overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMX509Data extends DOMStructure implements X509Data { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: warning: [overrides] Class DOMX509IssuerSerial overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMX509IssuerSerial extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: warning: [overrides] Class DOMXMLObject overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMXMLObject extends DOMStructure implements XMLObject { ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: warning: [overrides] Class DOMXMLSignature.DOMSignatureValue overrides equals, but neither it nor any superclass overrides hashCode method public class DOMSignatureValue extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: warning: [overrides] Class DOMXMLSignature overrides equals, but neither it nor any superclass overrides hashCode method public final class DOMXMLSignature extends DOMStructure ^ c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: warning: auxiliary class InetAddressContainer in c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java should not be accessed from outside its own source file localAddress(nativefd, (InetAddressContainer)iaContainerObj); ^ c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: warning: auxiliary class InetAddressContainer in c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java should not be accessed from outside its own source file InetAddressContainer in = new InetAddressContainer(); ^ c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: warning: auxiliary class InetAddressContainer in c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java should not be accessed from outside its own source file InetAddressContainer in = new InetAddressContainer(); ^ c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: warning: [overrides] Class Translator overrides equals, but neither it nor any superclass overrides hashCode method public class Translator extends AccessibleContext ^ Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 80 errors 25 warnings make[2]: *** [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] Error 1 make[1]: *** [classes-only] Error 2 make: *** [jdk-only] Error 2 From peter.brunet at oracle.com Sat Jul 27 04:40:57 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Fri, 26 Jul 2013 23:40:57 -0500 Subject: jdk 8 building just jdk In-Reply-To: <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> References: <51F32548.3030204@oracle.com> <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> Message-ID: <51F34F59.4030805@oracle.com> Hi Mike, Thanks. Below are my build times (prior to a crash in jdk). I'm running 64 bit Win 7 on a 2.53 GHz dual core 8 GB Lenovo T500. I'm using cygwin. langtools: 4:34 hotspot: 18:29 corba: 2:51 jaxp: 5:31 jaxws: 10:26 jdk: failed So I'm up to about 40 min with just those. Are you running cygwin or MinGW/MSYS? Pete On 7/26/13 10:38 PM, Mike Duigou wrote: > On Jul 26 2013, at 18:41 , Pete Brunet wrote: > >> Am doing my first jdk8 build. After reading through the build readme I >> didn't see any info on building just jdk and using an import lib. I'm >> guessing this is no longer possible but checking... > It's probably possible but usually not necessary. Even on a modest system a full build takes only 20 minutes and an incremental rebuild is less than 3 minutes (even faster if you use sjavac or JDK_FILTER). > > Mike From Alan.Bateman at oracle.com Sat Jul 27 05:49:25 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 26 Jul 2013 22:49:25 -0700 Subject: jdk 8 building just jdk In-Reply-To: <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> References: <51F32548.3030204@oracle.com> <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> Message-ID: <51F35F65.2030903@oracle.com> On 26/07/2013 20:38, Mike Duigou wrote: > On Jul 26 2013, at 18:41 , Pete Brunet wrote: > >> Am doing my first jdk8 build. After reading through the build readme I >> didn't see any info on building just jdk and using an import lib. I'm >> guessing this is no longer possible but checking... > It's probably possible but usually not necessary. Even on a modest system a full build takes only 20 minutes and an incremental rebuild is less than 3 minutes (even faster if you use sjavac or JDK_FILTER). > I agree, it shouldn't really be necessary to do partial builds any more (it was way too fragile in the past with the old build). That said, the new build does have --with-import-* options to configure the build to import some of the components from another JDK. -Alan From mike.duigou at oracle.com Sat Jul 27 06:16:07 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 26 Jul 2013 23:16:07 -0700 Subject: jdk 8 building just jdk In-Reply-To: <51F34F59.4030805@oracle.com> References: <51F32548.3030204@oracle.com> <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> <51F34F59.4030805@oracle.com> Message-ID: MacOS in my closest config. Windows is quite a bit slower on comparable hardware,and an SSD also makes a huge difference. I would guess that these times seem about reasonable for a clean windows build On Jul 26, 2013, at 9:40 PM, Pete Brunet wrote: > Hi Mike, Thanks. Below are my build times (prior to a crash in jdk). > I'm running 64 bit Win 7 on a 2.53 GHz dual core 8 GB Lenovo T500. I'm > using cygwin. > > langtools: 4:34 > hotspot: 18:29 > corba: 2:51 > jaxp: 5:31 > jaxws: 10:26 > jdk: failed > > So I'm up to about 40 min with just those. Are you running cygwin or > MinGW/MSYS? > > Pete > > On 7/26/13 10:38 PM, Mike Duigou wrote: >> On Jul 26 2013, at 18:41 , Pete Brunet wrote: >> >>> Am doing my first jdk8 build. After reading through the build readme I >>> didn't see any info on building just jdk and using an import lib. I'm >>> guessing this is no longer possible but checking... >> It's probably possible but usually not necessary. Even on a modest system a full build takes only 20 minutes and an incremental rebuild is less than 3 minutes (even faster if you use sjavac or JDK_FILTER). >> >> Mike > From philip.race at oracle.com Sat Jul 27 06:24:21 2013 From: philip.race at oracle.com (Phil Race) Date: Fri, 26 Jul 2013 23:24:21 -0700 Subject: jdk 8 building just jdk In-Reply-To: <51F35F65.2030903@oracle.com> References: <51F32548.3030204@oracle.com> <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> <51F35F65.2030903@oracle.com> Message-ID: <51F36795.9000401@oracle.com> Flogging a dead horse here .. > it shouldn't really be necessary to do partial builds any more (it was way too fragile in the past with the old build) I whole heartedly disagree. I've said it before and I say it again. I do not want to build hotspot or anything else besides JDK I do not want to maintain all the disk space for these. The overhead of these repos is painful. It is not fragile to build only JDK. I have > 10 years of experience here. I used to do incrementals in 10-15 seconds with the old build. Much better than 3 mins. I tried JDK_FILTER but it was not reliable. sjavac working by default was supposed to be a pre-requisite to the new build but that didn't happen. I've learned the new build is fast on Linux but slow on Windows which is what matters most. Bear in mind that 999/1000 of my builds are incremental and calculate how that adds up. Bottom line: the new build is costing me a lot. If people who don't work primarily on Windows aren't working on this, then that needs to be fixed. -phil On 7/26/13 10:49 PM, Alan Bateman wrote: > On 26/07/2013 20:38, Mike Duigou wrote: >> On Jul 26 2013, at 18:41 , Pete Brunet wrote: >> >>> Am doing my first jdk8 build. After reading through the build readme I >>> didn't see any info on building just jdk and using an import lib. I'm >>> guessing this is no longer possible but checking... >> It's probably possible but usually not necessary. Even on a modest >> system a full build takes only 20 minutes and an incremental rebuild >> is less than 3 minutes (even faster if you use sjavac or JDK_FILTER). >> > I agree, it shouldn't really be necessary to do partial builds any > more (it was way too fragile in the past with the old build). That > said, the new build does have --with-import-* options to configure the > build to import some of the components from another JDK. > > -Alan From peter.brunet at oracle.com Sat Jul 27 06:31:53 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Sat, 27 Jul 2013 01:31:53 -0500 Subject: location of DirectX SDK Message-ID: <51F36959.1040007@oracle.com> Finished reading the jdk8 build doc. I see the link in the build directions for the DirectX SDK goes to a non-helpful page so from here: http://en.wikipedia.org/wiki/DirectX#cite_note-11 I ended up here http://www.microsoft.com/en-us/download/details.aspx?id=35 hth, Pete From peter.brunet at oracle.com Sat Jul 27 17:17:13 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Sat, 27 Jul 2013 12:17:13 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F34919.8010900@oracle.com> References: <51F34919.8010900@oracle.com> Message-ID: <51F40099.5060408@oracle.com> repulled, configure ..., make clean, make all jdk build still fails - same failure any ideas on what to try next? On 7/26/13 11:14 PM, Pete Brunet wrote: > Hi, My build was running pretty well but then failed inside the jdk > build. My invocation was: > > cd .../jdk8 > bash ./configure --withfreetype=... --with-target-bits=32 > --with-debug-level=fastdebug > make all > > The log is > ... > ## Starting jdk > Importing CORBA src.zip > Importing CORBA classes.jar > Importing CORBA bin.zip > Importing JAXP src.zip > Importing JAXP classes.jar > Importing JAXWS src.zip > Importing JAXWS classes.jar > Importing LANGTOOLS src.zip > Importing LANGTOOLS classes.jar > Compiling 166 files for BUILD_TOOLS > Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 > for 80x86 > > Copyright (C) Microsoft Corporation. All rights reserved. > > > > genSocketOptionRegistry.c > Generating charsetmapping classes > Generating buffer classes > Generating exceptions classes > Microsoft (R) Incremental Linker Version 10.00.40219.01 > > Copyright (C) Microsoft Corporation. All rights reserved. > > > > Note: Some input files use unchecked or unsafe operations. > > Note: Recompile with -Xlint:unchecked for details. > > Copying and cleaning 53 properties > Compiling 522 properties into resource bundles > Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. > Generating sun/misc/Version.java > Generating sun/misc/Version.java compact1 > Generating sun/misc/Version.java compact2 > Generating sun/misc/Version.java compact3 > Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 > > Classes: Table size 32 (5 bits), shift 1, max chain depth 3 > > Cache: Table size 32 (5 bits), shift 1, max chain depth 3 > > Generating beaninfo > Generating Nimbus source files > [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, > 16.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) > > [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) > > Compiling 4 files for BUILD_BREAKITERATOR > Generating HTML DTD file > [Parsed DTD html32 in 801ms] > > Compiling 9795 files for BUILD_JDK > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: > error: cannot find symbol > > private BindingListHolder _bindingList; // list of bindings > > ^ > > symbol: class BindingListHolder > > location: class CNBindingEnumeration > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: > error: cannot find symbol > > private BindingIterator _bindingIter; // iterator for getting list > of bindings > > ^ > > symbol: class BindingIterator > > location: class CNBindingEnumeration > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: > error: package org.omg.CosNaming.NamingContextPackage does not exist > > import org.omg.CosNaming.NamingContextPackage.*; > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: > error: cannot find symbol > > private javax.naming.Binding mapBinding(org.omg.CosNaming.Binding bndg) > > ^ > > symbol: class Binding > > location: package org.omg.CosNaming > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: > error: cannot find symbol > > public NamingContext _nc; // public for accessing underlying > NamingContext > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: > error: cannot find symbol > > private NameComponent[] _name = null; > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: > error: cannot find symbol > > import org.omg.CosNaming.NameComponent; > > ^ > > symbol: class NameComponent > > location: package org.omg.CosNaming > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: > error: cannot find symbol > > CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: > error: cannot find symbol > > Hashtable env, NameComponent[]name) > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: > error: cannot find symbol > > NameComponent[] makeFullName(NameComponent[] child) { > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: > error: cannot find symbol > > NameComponent[] makeFullName(NameComponent[] child) { > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: > error: cannot find symbol > > java.lang.Object callResolve(NameComponent[] path) > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: > error: cannot find symbol > > private void callBindOrRebind(NameComponent[] pth, Name name, > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: > error: cannot find symbol > > private void callUnbind(NameComponent[] path) throws NamingException { > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: > error: cannot find symbol > > private boolean leafNotFound(NotFound e, NameComponent leaf) { > > ^ > > symbol: class NotFound > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: > error: cannot find symbol > > private boolean leafNotFound(NotFound e, NameComponent leaf) { > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: > error: cannot find symbol > > private void callDestroy(NamingContext nc) > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: > error: cannot find symbol > > private javax.naming.Context callBindNewContext(NameComponent[] path) > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: > error: cannot find symbol > > static NameComponent[] nameToCosName(Name name) > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: > error: cannot find symbol > > static String cosNameToInsString(NameComponent[] cname) { > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: > error: cannot find symbol > > static Name cosNameToName(NameComponent[] cname) { > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: > error: cannot find symbol > > private static NameComponent parseComponent(String compStr) > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: > error: cannot find symbol > > private static String stringifyComponent(NameComponent comp) { > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: > error: package org.omg.CosNaming.NamingContextPackage does not exist > > import org.omg.CosNaming.NamingContextPackage.*; > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: > error: cannot find symbol > > CNCtx ctx, NameComponent[] inputName) throws NamingException { > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: > error: cannot find symbol > > private static final NamingException tryFed(NotFound e, CNCtx ctx, > > ^ > > symbol: class NotFound > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: > error: cannot find symbol > > NameComponent[] inputName) throws NamingException { > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: > warning: auxiliary class InetAddressContainer in > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > should not be accessed from outside its own source file > > static native void localAddress(int fd, InetAddressContainer in) > throws SocketException; > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: > error: cannot find symbol > > _bindingList = new BindingListHolder(); > > ^ > > symbol: class BindingListHolder > > location: class CNBindingEnumeration > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: > error: cannot find symbol > > BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); > > ^ > > symbol: class BindingIteratorHolder > > location: class CNBindingEnumeration > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: > error: cannot find symbol > > BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); > > ^ > > symbol: class BindingIteratorHolder > > location: class CNBindingEnumeration > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: > error: cannot find symbol > > org.omg.CosNaming.Binding bndg = _bindingList.value[counter]; > > ^ > > symbol: class Binding > > location: package org.omg.CosNaming > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: > error: cannot find symbol > > NameComponent[] comps = _ctx.makeFullName(bndg.binding_name); > > ^ > > symbol: class NameComponent > > location: class CNBindingEnumeration > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: > error: cannot find symbol > > NameComponent[] answer = new > NameComponent[_name.length+child.length]; > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: > error: cannot find symbol > > NameComponent[] answer = new > NameComponent[_name.length+child.length]; > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: > error: cannot find symbol > > _nc = NamingContextHelper.narrow(obj); > > ^ > > symbol: variable NamingContextHelper > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: > error: cannot find symbol > > _nc = NamingContextHelper.narrow(ncRef); > > ^ > > symbol: variable NamingContextHelper > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: > error: cannot find symbol > > _nc = NamingContextHelper.narrow(ncRef); > > ^ > > symbol: variable NamingContextHelper > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: > error: cannot find symbol > > NamingContext nc = > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: > error: cannot find symbol > > NamingContextHelper.narrow(obj); > > ^ > > symbol: variable NamingContextHelper > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: > error: cannot find symbol > > NameComponent[] path = CNNameParser.nameToCosName(name); > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: > error: cannot find symbol > > if ( obj instanceof org.omg.CosNaming.NamingContext) { > > ^ > > symbol: class NamingContext > > location: package org.omg.CosNaming > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: > error: cannot find symbol > > NamingContext nobj = > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: > error: cannot find symbol > > > NamingContextHelper.narrow((org.omg.CORBA.Object)obj); > > ^ > > symbol: variable NamingContextHelper > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: > error: cannot find symbol > > NameComponent[] path = CNNameParser.nameToCosName(name); > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: > error: cannot find symbol > > NameComponent[] path = CNNameParser.nameToCosName(name); > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: > error: cannot find symbol > > } catch (NotFound e) { > > ^ > > symbol: class NotFound > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: > error: cannot find symbol > > NameComponent rest; > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: > error: cannot find symbol > > return e.why.value() == NotFoundReason._missing_node && > > ^ > > symbol: variable NotFoundReason > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: > error: cannot find symbol > > NameComponent[] path = CNNameParser.nameToCosName(name); > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: > error: cannot find symbol > > NamingContext the_nc = _nc; > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: > error: cannot find symbol > > NameComponent[] path = CNNameParser.nameToCosName(name); > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: > error: cannot find symbol > > if (e.getRootCause() instanceof NotFound && > > ^ > > symbol: class NotFound > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: > error: cannot find symbol > > leafNotFound((NotFound)e.getRootCause(), > > ^ > > symbol: class NotFound > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: > error: cannot find symbol > > NamingContext nctx = _nc.bind_new_context(path); > > ^ > > symbol: class NamingContext > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: > error: cannot find symbol > > NameComponent[] path = CNNameParser.nameToCosName(name); > > ^ > > symbol: class NameComponent > > location: class CNCtx > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: > error: cannot find symbol > > return new NameComponent[0]; > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: > error: cannot find symbol > > NameComponent[] answer = new NameComponent[len]; > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: > error: cannot find symbol > > NameComponent[] answer = new NameComponent[len]; > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: > error: cannot find symbol > > new NameComponent(new String(id, 0, idCount), > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: > error: cannot find symbol > > NameComponent comp = new NameComponent(); > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: > error: cannot find symbol > > NameComponent comp = new NameComponent(); > > ^ > > symbol: class NameComponent > > location: class CNNameParser > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: > error: cannot find symbol > > if (e instanceof NotFound) { > > ^ > > symbol: class NotFound > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: > error: cannot find symbol > > return tryFed((NotFound)e, ctx, inputName); > > ^ > > symbol: class NotFound > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: > error: cannot find symbol > > } else if (e instanceof CannotProceed) { > > ^ > > symbol: class CannotProceed > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: > error: cannot find symbol > > NamingContext nc = ((CannotProceed) e).cxt; > > ^ > > symbol: class NamingContext > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: > error: cannot find symbol > > NamingContext nc = ((CannotProceed) e).cxt; > > ^ > > symbol: class CannotProceed > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: > error: cannot find symbol > > NameComponent[] rest = ((CannotProceed) e).rest_of_name; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: > error: cannot find symbol > > NameComponent[] rest = ((CannotProceed) e).rest_of_name; > > ^ > > symbol: class CannotProceed > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: > error: cannot find symbol > > NameComponent[] resolvedName = > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: > error: cannot find symbol > > new NameComponent[inputName.length - rest.length]; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: > error: cannot find symbol > > } else if (e instanceof InvalidName) { > > ^ > > symbol: class InvalidName > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: > error: cannot find symbol > > } else if (e instanceof AlreadyBound) { > > ^ > > symbol: class AlreadyBound > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: > error: cannot find symbol > > } else if (e instanceof NotEmpty) { > > ^ > > symbol: class NotEmpty > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: > error: cannot find symbol > > NameComponent[] rest = e.rest_of_name; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: > error: cannot find symbol > > NameComponent lastIn = inputName[inputName.length-1]; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: > error: cannot find symbol > > NameComponent[] resolvedName = null; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: > error: cannot find symbol > > if (e.why == NotFoundReason.not_context) { > > ^ > > symbol: variable NotFoundReason > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: > error: cannot find symbol > > NameComponent[] tmp = new NameComponent[rest.length-1]; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: > error: cannot find symbol > > NameComponent[] tmp = new NameComponent[rest.length-1]; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: > error: cannot find symbol > > resolvedName = new NameComponent[len]; > > ^ > > symbol: class NameComponent > > location: class ExceptionMapper > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: > warning: [overrides] Class XMLX509IssuerSerial overrides equals, but > neither it nor any superclass overrides hashCode method > > public class XMLX509IssuerSerial extends SignatureElementProxy > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: > warning: [overrides] Class XMLX509SKI overrides equals, but neither it > nor any superclass overrides hashCode method > > public class XMLX509SKI extends SignatureElementProxy > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: > warning: [overrides] Class XMLX509SubjectName overrides equals, but > neither it nor any superclass overrides hashCode method > > public class XMLX509SubjectName extends SignatureElementProxy > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: > warning: [overrides] Class XMLX509Certificate overrides equals, but > neither it nor any superclass overrides hashCode method > > public class XMLX509Certificate extends SignatureElementProxy > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: > warning: [overrides] Class DOMTransform overrides equals, but neither it > nor any superclass overrides hashCode method > > public class DOMTransform extends DOMStructure implements Transform { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: > warning: [overrides] Class DOMCanonicalizationMethod overrides equals, > but neither it nor any superclass overrides hashCode method > > public class DOMCanonicalizationMethod extends DOMTransform > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: > warning: [overrides] Class DOMSignedInfo overrides equals, but neither > it nor any superclass overrides hashCode method > > public final class DOMSignedInfo extends DOMStructure implements > SignedInfo { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: > warning: [overrides] Class DOMKeyInfo overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMKeyInfo extends DOMStructure implements KeyInfo { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: > warning: [overrides] Class DOMKeyName overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMKeyName extends DOMStructure implements KeyName { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: > warning: [overrides] Class DOMKeyValue overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMKeyValue extends DOMStructure implements KeyValue { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: > warning: [overrides] Class DOMManifest overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMManifest extends DOMStructure implements Manifest { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: > warning: [overrides] Class DOMReference overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMReference extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: > warning: [overrides] Class DOMRetrievalMethod overrides equals, but > neither it nor any superclass overrides hashCode method > > public final class DOMRetrievalMethod extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: > warning: [overrides] Class DOMSignatureProperties overrides equals, but > neither it nor any superclass overrides hashCode method > > public final class DOMSignatureProperties extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: > warning: [overrides] Class DOMSignatureProperty overrides equals, but > neither it nor any superclass overrides hashCode method > > public final class DOMSignatureProperty extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: > warning: [overrides] Class DOMX509Data overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMX509Data extends DOMStructure implements X509Data { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: > warning: [overrides] Class DOMX509IssuerSerial overrides equals, but > neither it nor any superclass overrides hashCode method > > public final class DOMX509IssuerSerial extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: > warning: [overrides] Class DOMXMLObject overrides equals, but neither it > nor any superclass overrides hashCode method > > public final class DOMXMLObject extends DOMStructure implements XMLObject { > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: > warning: [overrides] Class DOMXMLSignature.DOMSignatureValue overrides > equals, but neither it nor any superclass overrides hashCode method > > public class DOMSignatureValue extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: > warning: [overrides] Class DOMXMLSignature overrides equals, but neither > it nor any superclass overrides hashCode method > > public final class DOMXMLSignature extends DOMStructure > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: > warning: auxiliary class InetAddressContainer in > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > should not be accessed from outside its own source file > > localAddress(nativefd, (InetAddressContainer)iaContainerObj); > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: > warning: auxiliary class InetAddressContainer in > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > should not be accessed from outside its own source file > > InetAddressContainer in = new InetAddressContainer(); > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: > warning: auxiliary class InetAddressContainer in > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > should not be accessed from outside its own source file > > InetAddressContainer in = new InetAddressContainer(); > > ^ > > c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: > warning: [overrides] Class Translator overrides equals, but neither it > nor any superclass overrides hashCode method > > public class Translator extends AccessibleContext > > ^ > > Note: Some input files use or override a deprecated API. > > Note: Recompile with -Xlint:deprecation for details. > > Note: Some input files use unchecked or unsafe operations. > > Note: Recompile with -Xlint:unchecked for details. > > 80 errors > > 25 warnings > > make[2]: *** > [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] > Error 1 > make[1]: *** [classes-only] Error 2 > make: *** [jdk-only] Error 2 From heliofrota at gmail.com Sat Jul 27 17:21:06 2013 From: heliofrota at gmail.com (Helio Frota) Date: Sat, 27 Jul 2013 14:21:06 -0300 Subject: jdk8 first build attempt - failed In-Reply-To: <51F40099.5060408@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> Message-ID: Hi Pete, Please try this from adopt openjdk: (win7) https://java.net/projects/adoptopenjdk/pages/BuildWindows (win8) http://betoweb.com.br/blog/2013/07/12/building-openjdk-on-ms-windows-8/ Regards, Helio Frota 2013/7/27 Pete Brunet > repulled, configure ..., make clean, make all > > jdk build still fails - same failure > > any ideas on what to try next? > > On 7/26/13 11:14 PM, Pete Brunet wrote: > > Hi, My build was running pretty well but then failed inside the jdk > > build. My invocation was: > > > > cd .../jdk8 > > bash ./configure --withfreetype=... --with-target-bits=32 > > --with-debug-level=fastdebug > > make all > > > > The log is > > ... > > ## Starting jdk > > Importing CORBA src.zip > > Importing CORBA classes.jar > > Importing CORBA bin.zip > > Importing JAXP src.zip > > Importing JAXP classes.jar > > Importing JAXWS src.zip > > Importing JAXWS classes.jar > > Importing LANGTOOLS src.zip > > Importing LANGTOOLS classes.jar > > Compiling 166 files for BUILD_TOOLS > > Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 > > for 80x86 > > > > Copyright (C) Microsoft Corporation. All rights reserved. > > > > > > > > genSocketOptionRegistry.c > > Generating charsetmapping classes > > Generating buffer classes > > Generating exceptions classes > > Microsoft (R) Incremental Linker Version 10.00.40219.01 > > > > Copyright (C) Microsoft Corporation. All rights reserved. > > > > > > > > Note: Some input files use unchecked or unsafe operations. > > > > Note: Recompile with -Xlint:unchecked for details. > > > > Copying and cleaning 53 properties > > Compiling 522 properties into resource bundles > > Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. > > Generating sun/misc/Version.java > > Generating sun/misc/Version.java compact1 > > Generating sun/misc/Version.java compact2 > > Generating sun/misc/Version.java compact3 > > Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 > > > > Classes: Table size 32 (5 bits), shift 1, max chain depth 3 > > > > Cache: Table size 32 (5 bits), shift 1, max chain depth 3 > > > > Generating beaninfo > > Generating Nimbus source files > > [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, > > 16.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, > 15.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, > 15.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, > 15.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, > 15.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, > 15.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, > 15.0) > > > > [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, > 25.0) > > > > [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) > > > > Compiling 4 files for BUILD_BREAKITERATOR > > Generating HTML DTD file > > [Parsed DTD html32 in 801ms] > > > > Compiling 9795 files for BUILD_JDK > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: > > error: cannot find symbol > > > > private BindingListHolder _bindingList; // list of bindings > > > > ^ > > > > symbol: class BindingListHolder > > > > location: class CNBindingEnumeration > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: > > error: cannot find symbol > > > > private BindingIterator _bindingIter; // iterator for getting list > > of bindings > > > > ^ > > > > symbol: class BindingIterator > > > > location: class CNBindingEnumeration > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: > > error: package org.omg.CosNaming.NamingContextPackage does not exist > > > > import org.omg.CosNaming.NamingContextPackage.*; > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: > > error: cannot find symbol > > > > private javax.naming.Binding mapBinding(org.omg.CosNaming.Binding > bndg) > > > > ^ > > > > symbol: class Binding > > > > location: package org.omg.CosNaming > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: > > error: cannot find symbol > > > > public NamingContext _nc; // public for accessing underlying > > NamingContext > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: > > error: cannot find symbol > > > > private NameComponent[] _name = null; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: > > error: cannot find symbol > > > > import org.omg.CosNaming.NameComponent; > > > > ^ > > > > symbol: class NameComponent > > > > location: package org.omg.CosNaming > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: > > error: cannot find symbol > > > > CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: > > error: cannot find symbol > > > > Hashtable env, NameComponent[]name) > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: > > error: cannot find symbol > > > > NameComponent[] makeFullName(NameComponent[] child) { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: > > error: cannot find symbol > > > > NameComponent[] makeFullName(NameComponent[] child) { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: > > error: cannot find symbol > > > > java.lang.Object callResolve(NameComponent[] path) > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: > > error: cannot find symbol > > > > private void callBindOrRebind(NameComponent[] pth, Name name, > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: > > error: cannot find symbol > > > > private void callUnbind(NameComponent[] path) throws NamingException > { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: > > error: cannot find symbol > > > > private boolean leafNotFound(NotFound e, NameComponent leaf) { > > > > ^ > > > > symbol: class NotFound > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: > > error: cannot find symbol > > > > private boolean leafNotFound(NotFound e, NameComponent leaf) { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: > > error: cannot find symbol > > > > private void callDestroy(NamingContext nc) > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: > > error: cannot find symbol > > > > private javax.naming.Context callBindNewContext(NameComponent[] path) > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: > > error: cannot find symbol > > > > static NameComponent[] nameToCosName(Name name) > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: > > error: cannot find symbol > > > > static String cosNameToInsString(NameComponent[] cname) { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: > > error: cannot find symbol > > > > static Name cosNameToName(NameComponent[] cname) { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: > > error: cannot find symbol > > > > private static NameComponent parseComponent(String compStr) > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: > > error: cannot find symbol > > > > private static String stringifyComponent(NameComponent comp) { > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: > > error: package org.omg.CosNaming.NamingContextPackage does not exist > > > > import org.omg.CosNaming.NamingContextPackage.*; > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: > > error: cannot find symbol > > > > CNCtx ctx, NameComponent[] inputName) throws NamingException { > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: > > error: cannot find symbol > > > > private static final NamingException tryFed(NotFound e, CNCtx ctx, > > > > ^ > > > > symbol: class NotFound > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: > > error: cannot find symbol > > > > NameComponent[] inputName) throws NamingException { > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: > > warning: auxiliary class InetAddressContainer in > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > > should not be accessed from outside its own source file > > > > static native void localAddress(int fd, InetAddressContainer in) > > throws SocketException; > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: > > error: cannot find symbol > > > > _bindingList = new BindingListHolder(); > > > > ^ > > > > symbol: class BindingListHolder > > > > location: class CNBindingEnumeration > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: > > error: cannot find symbol > > > > BindingIteratorHolder _bindingIterH = new > BindingIteratorHolder(); > > > > ^ > > > > symbol: class BindingIteratorHolder > > > > location: class CNBindingEnumeration > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: > > error: cannot find symbol > > > > BindingIteratorHolder _bindingIterH = new > BindingIteratorHolder(); > > > > ^ > > > > symbol: class BindingIteratorHolder > > > > location: class CNBindingEnumeration > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: > > error: cannot find symbol > > > > org.omg.CosNaming.Binding bndg = _bindingList.value[counter]; > > > > ^ > > > > symbol: class Binding > > > > location: package org.omg.CosNaming > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: > > error: cannot find symbol > > > > NameComponent[] comps = _ctx.makeFullName(bndg.binding_name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNBindingEnumeration > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: > > error: cannot find symbol > > > > NameComponent[] answer = new > > NameComponent[_name.length+child.length]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: > > error: cannot find symbol > > > > NameComponent[] answer = new > > NameComponent[_name.length+child.length]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: > > error: cannot find symbol > > > > _nc = NamingContextHelper.narrow(obj); > > > > ^ > > > > symbol: variable NamingContextHelper > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: > > error: cannot find symbol > > > > _nc = NamingContextHelper.narrow(ncRef); > > > > ^ > > > > symbol: variable NamingContextHelper > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: > > error: cannot find symbol > > > > _nc = NamingContextHelper.narrow(ncRef); > > > > ^ > > > > symbol: variable NamingContextHelper > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: > > error: cannot find symbol > > > > NamingContext nc = > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: > > error: cannot find symbol > > > > NamingContextHelper.narrow(obj); > > > > ^ > > > > symbol: variable NamingContextHelper > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: > > error: cannot find symbol > > > > NameComponent[] path = CNNameParser.nameToCosName(name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: > > error: cannot find symbol > > > > if ( obj instanceof org.omg.CosNaming.NamingContext) { > > > > ^ > > > > symbol: class NamingContext > > > > location: package org.omg.CosNaming > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: > > error: cannot find symbol > > > > NamingContext nobj = > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: > > error: cannot find symbol > > > > > > NamingContextHelper.narrow((org.omg.CORBA.Object)obj); > > > > ^ > > > > symbol: variable NamingContextHelper > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: > > error: cannot find symbol > > > > NameComponent[] path = CNNameParser.nameToCosName(name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: > > error: cannot find symbol > > > > NameComponent[] path = CNNameParser.nameToCosName(name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: > > error: cannot find symbol > > > > } catch (NotFound e) { > > > > ^ > > > > symbol: class NotFound > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: > > error: cannot find symbol > > > > NameComponent rest; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: > > error: cannot find symbol > > > > return e.why.value() == NotFoundReason._missing_node && > > > > ^ > > > > symbol: variable NotFoundReason > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: > > error: cannot find symbol > > > > NameComponent[] path = CNNameParser.nameToCosName(name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: > > error: cannot find symbol > > > > NamingContext the_nc = _nc; > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: > > error: cannot find symbol > > > > NameComponent[] path = CNNameParser.nameToCosName(name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: > > error: cannot find symbol > > > > if (e.getRootCause() instanceof NotFound && > > > > ^ > > > > symbol: class NotFound > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: > > error: cannot find symbol > > > > leafNotFound((NotFound)e.getRootCause(), > > > > ^ > > > > symbol: class NotFound > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: > > error: cannot find symbol > > > > NamingContext nctx = _nc.bind_new_context(path); > > > > ^ > > > > symbol: class NamingContext > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: > > error: cannot find symbol > > > > NameComponent[] path = CNNameParser.nameToCosName(name); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNCtx > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: > > error: cannot find symbol > > > > return new NameComponent[0]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: > > error: cannot find symbol > > > > NameComponent[] answer = new NameComponent[len]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: > > error: cannot find symbol > > > > NameComponent[] answer = new NameComponent[len]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: > > error: cannot find symbol > > > > new NameComponent(new String(id, 0, idCount), > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: > > error: cannot find symbol > > > > NameComponent comp = new NameComponent(); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: > > error: cannot find symbol > > > > NameComponent comp = new NameComponent(); > > > > ^ > > > > symbol: class NameComponent > > > > location: class CNNameParser > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: > > error: cannot find symbol > > > > if (e instanceof NotFound) { > > > > ^ > > > > symbol: class NotFound > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: > > error: cannot find symbol > > > > return tryFed((NotFound)e, ctx, inputName); > > > > ^ > > > > symbol: class NotFound > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: > > error: cannot find symbol > > > > } else if (e instanceof CannotProceed) { > > > > ^ > > > > symbol: class CannotProceed > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: > > error: cannot find symbol > > > > NamingContext nc = ((CannotProceed) e).cxt; > > > > ^ > > > > symbol: class NamingContext > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: > > error: cannot find symbol > > > > NamingContext nc = ((CannotProceed) e).cxt; > > > > ^ > > > > symbol: class CannotProceed > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: > > error: cannot find symbol > > > > NameComponent[] rest = ((CannotProceed) e).rest_of_name; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: > > error: cannot find symbol > > > > NameComponent[] rest = ((CannotProceed) e).rest_of_name; > > > > ^ > > > > symbol: class CannotProceed > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: > > error: cannot find symbol > > > > NameComponent[] resolvedName = > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: > > error: cannot find symbol > > > > new NameComponent[inputName.length - rest.length]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: > > error: cannot find symbol > > > > } else if (e instanceof InvalidName) { > > > > ^ > > > > symbol: class InvalidName > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: > > error: cannot find symbol > > > > } else if (e instanceof AlreadyBound) { > > > > ^ > > > > symbol: class AlreadyBound > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: > > error: cannot find symbol > > > > } else if (e instanceof NotEmpty) { > > > > ^ > > > > symbol: class NotEmpty > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: > > error: cannot find symbol > > > > NameComponent[] rest = e.rest_of_name; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: > > error: cannot find symbol > > > > NameComponent lastIn = inputName[inputName.length-1]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: > > error: cannot find symbol > > > > NameComponent[] resolvedName = null; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: > > error: cannot find symbol > > > > if (e.why == NotFoundReason.not_context) { > > > > ^ > > > > symbol: variable NotFoundReason > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: > > error: cannot find symbol > > > > NameComponent[] tmp = new > NameComponent[rest.length-1]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: > > error: cannot find symbol > > > > NameComponent[] tmp = new > NameComponent[rest.length-1]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: > > error: cannot find symbol > > > > resolvedName = new NameComponent[len]; > > > > ^ > > > > symbol: class NameComponent > > > > location: class ExceptionMapper > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: > > warning: [overrides] Class XMLX509IssuerSerial overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public class XMLX509IssuerSerial extends SignatureElementProxy > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: > > warning: [overrides] Class XMLX509SKI overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public class XMLX509SKI extends SignatureElementProxy > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: > > warning: [overrides] Class XMLX509SubjectName overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public class XMLX509SubjectName extends SignatureElementProxy > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: > > warning: [overrides] Class XMLX509Certificate overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public class XMLX509Certificate extends SignatureElementProxy > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: > > warning: [overrides] Class DOMTransform overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public class DOMTransform extends DOMStructure implements Transform { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: > > warning: [overrides] Class DOMCanonicalizationMethod overrides equals, > > but neither it nor any superclass overrides hashCode method > > > > public class DOMCanonicalizationMethod extends DOMTransform > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: > > warning: [overrides] Class DOMSignedInfo overrides equals, but neither > > it nor any superclass overrides hashCode method > > > > public final class DOMSignedInfo extends DOMStructure implements > > SignedInfo { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: > > warning: [overrides] Class DOMKeyInfo overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMKeyInfo extends DOMStructure implements KeyInfo { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: > > warning: [overrides] Class DOMKeyName overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMKeyName extends DOMStructure implements KeyName { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: > > warning: [overrides] Class DOMKeyValue overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMKeyValue extends DOMStructure implements KeyValue { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: > > warning: [overrides] Class DOMManifest overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMManifest extends DOMStructure implements Manifest { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: > > warning: [overrides] Class DOMReference overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMReference extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: > > warning: [overrides] Class DOMRetrievalMethod overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public final class DOMRetrievalMethod extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: > > warning: [overrides] Class DOMSignatureProperties overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public final class DOMSignatureProperties extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: > > warning: [overrides] Class DOMSignatureProperty overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public final class DOMSignatureProperty extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: > > warning: [overrides] Class DOMX509Data overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMX509Data extends DOMStructure implements X509Data { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: > > warning: [overrides] Class DOMX509IssuerSerial overrides equals, but > > neither it nor any superclass overrides hashCode method > > > > public final class DOMX509IssuerSerial extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: > > warning: [overrides] Class DOMXMLObject overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public final class DOMXMLObject extends DOMStructure implements > XMLObject { > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: > > warning: [overrides] Class DOMXMLSignature.DOMSignatureValue overrides > > equals, but neither it nor any superclass overrides hashCode method > > > > public class DOMSignatureValue extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: > > warning: [overrides] Class DOMXMLSignature overrides equals, but neither > > it nor any superclass overrides hashCode method > > > > public final class DOMXMLSignature extends DOMStructure > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: > > warning: auxiliary class InetAddressContainer in > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > > should not be accessed from outside its own source file > > > > localAddress(nativefd, (InetAddressContainer)iaContainerObj); > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: > > warning: auxiliary class InetAddressContainer in > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > > should not be accessed from outside its own source file > > > > InetAddressContainer in = new InetAddressContainer(); > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: > > warning: auxiliary class InetAddressContainer in > > > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java > > should not be accessed from outside its own source file > > > > InetAddressContainer in = new InetAddressContainer(); > > > > ^ > > > > > c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: > > warning: [overrides] Class Translator overrides equals, but neither it > > nor any superclass overrides hashCode method > > > > public class Translator extends AccessibleContext > > > > ^ > > > > Note: Some input files use or override a deprecated API. > > > > Note: Recompile with -Xlint:deprecation for details. > > > > Note: Some input files use unchecked or unsafe operations. > > > > Note: Recompile with -Xlint:unchecked for details. > > > > 80 errors > > > > 25 warnings > > > > make[2]: *** > > > [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] > > Error 1 > > make[1]: *** [classes-only] Error 2 > > make: *** [jdk-only] Error 2 > > -- Helio Frota JUG Leader - CEJUG http://www.cejug.org/ http://www.linkedin.com/in/heliofrota From Alan.Bateman at oracle.com Sat Jul 27 17:22:23 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 27 Jul 2013 10:22:23 -0700 Subject: jdk 8 building just jdk In-Reply-To: <51F36795.9000401@oracle.com> References: <51F32548.3030204@oracle.com> <32C5C83E-ED08-4CC8-BC8E-18E8A4467401@oracle.com> <51F35F65.2030903@oracle.com> <51F36795.9000401@oracle.com> Message-ID: <51F401CF.9000705@oracle.com> On 26/07/2013 23:24, Phil Race wrote: > Flogging a dead horse here .. > > > it shouldn't really be necessary to do partial builds any more (it > was way too fragile in the past with the old build) > > I whole heartedly disagree. I've said it before and I say it again. > I do not want to build hotspot or anything else besides JDK > I do not want to maintain all the disk space for these. > The overhead of these repos is painful. > It is not fragile to build only JDK. I have > 10 years of experience > here. > > I used to do incrementals in 10-15 seconds with the old build. Much > better than 3 mins. > I tried JDK_FILTER but it was not reliable. sjavac working by default > was supposed to > be a pre-requisite to the new build but that didn't happen. > > I've learned the new build is fast on Linux but slow on Windows which > is what matters most. > > Bear in mind that 999/1000 of my builds are incremental and calculate > how that adds up. > > Bottom line: the new build is costing me a lot. If people who don't > work primarily on > Windows aren't working on this, then that needs to be fixed. Partial builds, as in the old build, are very fragile. When doing partial builds then the import JDK has to match almost exactly the repository that you are building as otherwise there will be problems and those problems can be very hard to diagnose. There are been dozens of changes in jdk8 that have required coordinated changes to two or more repositories (typically langtools+jdk or hotspot+jdk, even one or two that were langtools+hotspot+jdk). The new build has some support for this things of working, maybe --with-import-hotspot will be useful to you (assuming you have the disk space, and disk space should be cheap). For most people then incremental build performance is the highest priority. If you have issues with JDK_FILTER (which is really just a short term workaround until sjavac is enabled) then make sure that there is a bug submitted. I don't think that sjavac was ever a pre-requisite to the new build (I wish it were) but hopefully the remaining issues can be sorted out soon. -Alan From peter.brunet at oracle.com Mon Jul 29 13:27:07 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 08:27:07 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F40099.5060408@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> Message-ID: <51F66DAB.9070103@oracle.com> The first failure is error: cannot find symbol symbol: class BindingListHolder location: class CNBindingEnumeration Googling shows that BindingListHolder is in package org.omg.CosNaming. The class file is not in build\windows-x86-normal-server-fastdebug\corba\classes\org\omg\CosNaming and the source file is not in corba\src\share\classes\org\omg\CosNaming Is that a useful hint? Pete On 7/27/13 12:17 PM, Pete Brunet wrote: > repulled, configure ..., make clean, make all > > jdk build still fails - same failure > > any ideas on what to try next? > > On 7/26/13 11:14 PM, Pete Brunet wrote: >> Hi, My build was running pretty well but then failed inside the jdk >> build. My invocation was: >> >> cd .../jdk8 >> bash ./configure --withfreetype=... --with-target-bits=32 >> --with-debug-level=fastdebug >> make all >> >> The log is >> ... >> ## Starting jdk >> Importing CORBA src.zip >> Importing CORBA classes.jar >> Importing CORBA bin.zip >> Importing JAXP src.zip >> Importing JAXP classes.jar >> Importing JAXWS src.zip >> Importing JAXWS classes.jar >> Importing LANGTOOLS src.zip >> Importing LANGTOOLS classes.jar >> Compiling 166 files for BUILD_TOOLS >> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 >> for 80x86 >> >> Copyright (C) Microsoft Corporation. All rights reserved. >> >> >> >> genSocketOptionRegistry.c >> Generating charsetmapping classes >> Generating buffer classes >> Generating exceptions classes >> Microsoft (R) Incremental Linker Version 10.00.40219.01 >> >> Copyright (C) Microsoft Corporation. All rights reserved. >> >> >> >> Note: Some input files use unchecked or unsafe operations. >> >> Note: Recompile with -Xlint:unchecked for details. >> >> Copying and cleaning 53 properties >> Compiling 522 properties into resource bundles >> Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. >> Generating sun/misc/Version.java >> Generating sun/misc/Version.java compact1 >> Generating sun/misc/Version.java compact2 >> Generating sun/misc/Version.java compact3 >> Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 >> >> Classes: Table size 32 (5 bits), shift 1, max chain depth 3 >> >> Cache: Table size 32 (5 bits), shift 1, max chain depth 3 >> >> Generating beaninfo >> Generating Nimbus source files >> [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, >> 16.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >> >> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >> >> [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) >> >> Compiling 4 files for BUILD_BREAKITERATOR >> Generating HTML DTD file >> [Parsed DTD html32 in 801ms] >> >> Compiling 9795 files for BUILD_JDK >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: >> error: cannot find symbol >> >> private BindingListHolder _bindingList; // list of bindings >> >> ^ >> >> symbol: class BindingListHolder >> >> location: class CNBindingEnumeration >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: >> error: cannot find symbol >> >> private BindingIterator _bindingIter; // iterator for getting list >> of bindings >> >> ^ >> >> symbol: class BindingIterator >> >> location: class CNBindingEnumeration >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: >> error: package org.omg.CosNaming.NamingContextPackage does not exist >> >> import org.omg.CosNaming.NamingContextPackage.*; >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: >> error: cannot find symbol >> >> private javax.naming.Binding mapBinding(org.omg.CosNaming.Binding bndg) >> >> ^ >> >> symbol: class Binding >> >> location: package org.omg.CosNaming >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: >> error: cannot find symbol >> >> public NamingContext _nc; // public for accessing underlying >> NamingContext >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: >> error: cannot find symbol >> >> private NameComponent[] _name = null; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: >> error: cannot find symbol >> >> import org.omg.CosNaming.NameComponent; >> >> ^ >> >> symbol: class NameComponent >> >> location: package org.omg.CosNaming >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: >> error: cannot find symbol >> >> CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: >> error: cannot find symbol >> >> Hashtable env, NameComponent[]name) >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >> error: cannot find symbol >> >> NameComponent[] makeFullName(NameComponent[] child) { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >> error: cannot find symbol >> >> NameComponent[] makeFullName(NameComponent[] child) { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: >> error: cannot find symbol >> >> java.lang.Object callResolve(NameComponent[] path) >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: >> error: cannot find symbol >> >> private void callBindOrRebind(NameComponent[] pth, Name name, >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: >> error: cannot find symbol >> >> private void callUnbind(NameComponent[] path) throws NamingException { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >> error: cannot find symbol >> >> private boolean leafNotFound(NotFound e, NameComponent leaf) { >> >> ^ >> >> symbol: class NotFound >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >> error: cannot find symbol >> >> private boolean leafNotFound(NotFound e, NameComponent leaf) { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: >> error: cannot find symbol >> >> private void callDestroy(NamingContext nc) >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: >> error: cannot find symbol >> >> private javax.naming.Context callBindNewContext(NameComponent[] path) >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: >> error: cannot find symbol >> >> static NameComponent[] nameToCosName(Name name) >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: >> error: cannot find symbol >> >> static String cosNameToInsString(NameComponent[] cname) { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: >> error: cannot find symbol >> >> static Name cosNameToName(NameComponent[] cname) { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: >> error: cannot find symbol >> >> private static NameComponent parseComponent(String compStr) >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: >> error: cannot find symbol >> >> private static String stringifyComponent(NameComponent comp) { >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: >> error: package org.omg.CosNaming.NamingContextPackage does not exist >> >> import org.omg.CosNaming.NamingContextPackage.*; >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: >> error: cannot find symbol >> >> CNCtx ctx, NameComponent[] inputName) throws NamingException { >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: >> error: cannot find symbol >> >> private static final NamingException tryFed(NotFound e, CNCtx ctx, >> >> ^ >> >> symbol: class NotFound >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: >> error: cannot find symbol >> >> NameComponent[] inputName) throws NamingException { >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: >> warning: auxiliary class InetAddressContainer in >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >> should not be accessed from outside its own source file >> >> static native void localAddress(int fd, InetAddressContainer in) >> throws SocketException; >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: >> error: cannot find symbol >> >> _bindingList = new BindingListHolder(); >> >> ^ >> >> symbol: class BindingListHolder >> >> location: class CNBindingEnumeration >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >> error: cannot find symbol >> >> BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); >> >> ^ >> >> symbol: class BindingIteratorHolder >> >> location: class CNBindingEnumeration >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >> error: cannot find symbol >> >> BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); >> >> ^ >> >> symbol: class BindingIteratorHolder >> >> location: class CNBindingEnumeration >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: >> error: cannot find symbol >> >> org.omg.CosNaming.Binding bndg = _bindingList.value[counter]; >> >> ^ >> >> symbol: class Binding >> >> location: package org.omg.CosNaming >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: >> error: cannot find symbol >> >> NameComponent[] comps = _ctx.makeFullName(bndg.binding_name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNBindingEnumeration >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >> error: cannot find symbol >> >> NameComponent[] answer = new >> NameComponent[_name.length+child.length]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >> error: cannot find symbol >> >> NameComponent[] answer = new >> NameComponent[_name.length+child.length]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: >> error: cannot find symbol >> >> _nc = NamingContextHelper.narrow(obj); >> >> ^ >> >> symbol: variable NamingContextHelper >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: >> error: cannot find symbol >> >> _nc = NamingContextHelper.narrow(ncRef); >> >> ^ >> >> symbol: variable NamingContextHelper >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: >> error: cannot find symbol >> >> _nc = NamingContextHelper.narrow(ncRef); >> >> ^ >> >> symbol: variable NamingContextHelper >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: >> error: cannot find symbol >> >> NamingContext nc = >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: >> error: cannot find symbol >> >> NamingContextHelper.narrow(obj); >> >> ^ >> >> symbol: variable NamingContextHelper >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: >> error: cannot find symbol >> >> NameComponent[] path = CNNameParser.nameToCosName(name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: >> error: cannot find symbol >> >> if ( obj instanceof org.omg.CosNaming.NamingContext) { >> >> ^ >> >> symbol: class NamingContext >> >> location: package org.omg.CosNaming >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: >> error: cannot find symbol >> >> NamingContext nobj = >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: >> error: cannot find symbol >> >> >> NamingContextHelper.narrow((org.omg.CORBA.Object)obj); >> >> ^ >> >> symbol: variable NamingContextHelper >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: >> error: cannot find symbol >> >> NameComponent[] path = CNNameParser.nameToCosName(name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: >> error: cannot find symbol >> >> NameComponent[] path = CNNameParser.nameToCosName(name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: >> error: cannot find symbol >> >> } catch (NotFound e) { >> >> ^ >> >> symbol: class NotFound >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: >> error: cannot find symbol >> >> NameComponent rest; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: >> error: cannot find symbol >> >> return e.why.value() == NotFoundReason._missing_node && >> >> ^ >> >> symbol: variable NotFoundReason >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: >> error: cannot find symbol >> >> NameComponent[] path = CNNameParser.nameToCosName(name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: >> error: cannot find symbol >> >> NamingContext the_nc = _nc; >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: >> error: cannot find symbol >> >> NameComponent[] path = CNNameParser.nameToCosName(name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: >> error: cannot find symbol >> >> if (e.getRootCause() instanceof NotFound && >> >> ^ >> >> symbol: class NotFound >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: >> error: cannot find symbol >> >> leafNotFound((NotFound)e.getRootCause(), >> >> ^ >> >> symbol: class NotFound >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: >> error: cannot find symbol >> >> NamingContext nctx = _nc.bind_new_context(path); >> >> ^ >> >> symbol: class NamingContext >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: >> error: cannot find symbol >> >> NameComponent[] path = CNNameParser.nameToCosName(name); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNCtx >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: >> error: cannot find symbol >> >> return new NameComponent[0]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >> error: cannot find symbol >> >> NameComponent[] answer = new NameComponent[len]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >> error: cannot find symbol >> >> NameComponent[] answer = new NameComponent[len]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: >> error: cannot find symbol >> >> new NameComponent(new String(id, 0, idCount), >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >> error: cannot find symbol >> >> NameComponent comp = new NameComponent(); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >> error: cannot find symbol >> >> NameComponent comp = new NameComponent(); >> >> ^ >> >> symbol: class NameComponent >> >> location: class CNNameParser >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: >> error: cannot find symbol >> >> if (e instanceof NotFound) { >> >> ^ >> >> symbol: class NotFound >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: >> error: cannot find symbol >> >> return tryFed((NotFound)e, ctx, inputName); >> >> ^ >> >> symbol: class NotFound >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: >> error: cannot find symbol >> >> } else if (e instanceof CannotProceed) { >> >> ^ >> >> symbol: class CannotProceed >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >> error: cannot find symbol >> >> NamingContext nc = ((CannotProceed) e).cxt; >> >> ^ >> >> symbol: class NamingContext >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >> error: cannot find symbol >> >> NamingContext nc = ((CannotProceed) e).cxt; >> >> ^ >> >> symbol: class CannotProceed >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >> error: cannot find symbol >> >> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >> error: cannot find symbol >> >> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >> >> ^ >> >> symbol: class CannotProceed >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: >> error: cannot find symbol >> >> NameComponent[] resolvedName = >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: >> error: cannot find symbol >> >> new NameComponent[inputName.length - rest.length]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: >> error: cannot find symbol >> >> } else if (e instanceof InvalidName) { >> >> ^ >> >> symbol: class InvalidName >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: >> error: cannot find symbol >> >> } else if (e instanceof AlreadyBound) { >> >> ^ >> >> symbol: class AlreadyBound >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: >> error: cannot find symbol >> >> } else if (e instanceof NotEmpty) { >> >> ^ >> >> symbol: class NotEmpty >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: >> error: cannot find symbol >> >> NameComponent[] rest = e.rest_of_name; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: >> error: cannot find symbol >> >> NameComponent lastIn = inputName[inputName.length-1]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: >> error: cannot find symbol >> >> NameComponent[] resolvedName = null; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: >> error: cannot find symbol >> >> if (e.why == NotFoundReason.not_context) { >> >> ^ >> >> symbol: variable NotFoundReason >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >> error: cannot find symbol >> >> NameComponent[] tmp = new NameComponent[rest.length-1]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >> error: cannot find symbol >> >> NameComponent[] tmp = new NameComponent[rest.length-1]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: >> error: cannot find symbol >> >> resolvedName = new NameComponent[len]; >> >> ^ >> >> symbol: class NameComponent >> >> location: class ExceptionMapper >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: >> warning: [overrides] Class XMLX509IssuerSerial overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public class XMLX509IssuerSerial extends SignatureElementProxy >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: >> warning: [overrides] Class XMLX509SKI overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public class XMLX509SKI extends SignatureElementProxy >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: >> warning: [overrides] Class XMLX509SubjectName overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public class XMLX509SubjectName extends SignatureElementProxy >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: >> warning: [overrides] Class XMLX509Certificate overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public class XMLX509Certificate extends SignatureElementProxy >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: >> warning: [overrides] Class DOMTransform overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public class DOMTransform extends DOMStructure implements Transform { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: >> warning: [overrides] Class DOMCanonicalizationMethod overrides equals, >> but neither it nor any superclass overrides hashCode method >> >> public class DOMCanonicalizationMethod extends DOMTransform >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: >> warning: [overrides] Class DOMSignedInfo overrides equals, but neither >> it nor any superclass overrides hashCode method >> >> public final class DOMSignedInfo extends DOMStructure implements >> SignedInfo { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: >> warning: [overrides] Class DOMKeyInfo overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMKeyInfo extends DOMStructure implements KeyInfo { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: >> warning: [overrides] Class DOMKeyName overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMKeyName extends DOMStructure implements KeyName { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: >> warning: [overrides] Class DOMKeyValue overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMKeyValue extends DOMStructure implements KeyValue { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: >> warning: [overrides] Class DOMManifest overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMManifest extends DOMStructure implements Manifest { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: >> warning: [overrides] Class DOMReference overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMReference extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: >> warning: [overrides] Class DOMRetrievalMethod overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public final class DOMRetrievalMethod extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: >> warning: [overrides] Class DOMSignatureProperties overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public final class DOMSignatureProperties extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: >> warning: [overrides] Class DOMSignatureProperty overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public final class DOMSignatureProperty extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: >> warning: [overrides] Class DOMX509Data overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMX509Data extends DOMStructure implements X509Data { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: >> warning: [overrides] Class DOMX509IssuerSerial overrides equals, but >> neither it nor any superclass overrides hashCode method >> >> public final class DOMX509IssuerSerial extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: >> warning: [overrides] Class DOMXMLObject overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public final class DOMXMLObject extends DOMStructure implements XMLObject { >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: >> warning: [overrides] Class DOMXMLSignature.DOMSignatureValue overrides >> equals, but neither it nor any superclass overrides hashCode method >> >> public class DOMSignatureValue extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: >> warning: [overrides] Class DOMXMLSignature overrides equals, but neither >> it nor any superclass overrides hashCode method >> >> public final class DOMXMLSignature extends DOMStructure >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: >> warning: auxiliary class InetAddressContainer in >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >> should not be accessed from outside its own source file >> >> localAddress(nativefd, (InetAddressContainer)iaContainerObj); >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >> warning: auxiliary class InetAddressContainer in >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >> should not be accessed from outside its own source file >> >> InetAddressContainer in = new InetAddressContainer(); >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >> warning: auxiliary class InetAddressContainer in >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >> should not be accessed from outside its own source file >> >> InetAddressContainer in = new InetAddressContainer(); >> >> ^ >> >> c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: >> warning: [overrides] Class Translator overrides equals, but neither it >> nor any superclass overrides hashCode method >> >> public class Translator extends AccessibleContext >> >> ^ >> >> Note: Some input files use or override a deprecated API. >> >> Note: Recompile with -Xlint:deprecation for details. >> >> Note: Some input files use unchecked or unsafe operations. >> >> Note: Recompile with -Xlint:unchecked for details. >> >> 80 errors >> >> 25 warnings >> >> make[2]: *** >> [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] >> Error 1 >> make[1]: *** [classes-only] Error 2 >> make: *** [jdk-only] Error 2 From peter.brunet at oracle.com Mon Jul 29 14:09:30 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 09:09:30 -0500 Subject: jdk 8 skipping javadocs Message-ID: <51F6779A.5080105@oracle.com> In the new JDK 8 build doc I see this sentence: Creating the javadocs can be very slow, if you are running javadoc, consider skipping that step. but I don't see any switches documented that would skip creating javadocs. From mike.duigou at oracle.com Mon Jul 29 14:39:14 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Mon, 29 Jul 2013 07:39:14 -0700 Subject: jdk 8 skipping javadocs In-Reply-To: <51F6779A.5080105@oracle.com> References: <51F6779A.5080105@oracle.com> Message-ID: <07D6F123-F462-459C-BA4F-31436D66B1A9@oracle.com> On Jul 29 2013, at 07:09 , Pete Brunet wrote: > In the new JDK 8 build doc I see this sentence: > Creating the javadocs can be very slow, if you are running javadoc, > consider skipping that step. > but I don't see any switches documented that would skip creating javadocs. The docs target is not run by default. It has to be explicitly invoked to create docs. Mike From peter.brunet at oracle.com Mon Jul 29 15:01:25 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 10:01:25 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F66DAB.9070103@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> Message-ID: <51F683C5.5090108@oracle.com> I don't see BindingListHolder.java in the repo at hg.openjdk.java.net/jdk8/awt/corba/file/a013024b0747/src/share/classes/org/omg/CosNaming Is it supposed to be there? Or is this line of code in error by using BindingListHolder? c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: Or something else? Pete On 7/29/13 8:27 AM, Pete Brunet wrote: > The first failure is > > error: cannot find symbol > symbol: class BindingListHolder > location: class CNBindingEnumeration > > Googling shows that BindingListHolder is in package org.omg.CosNaming. > The class file is not in > build\windows-x86-normal-server-fastdebug\corba\classes\org\omg\CosNaming and > the source file is not in corba\src\share\classes\org\omg\CosNaming > > Is that a useful hint? > > Pete > > On 7/27/13 12:17 PM, Pete Brunet wrote: >> repulled, configure ..., make clean, make all >> >> jdk build still fails - same failure >> >> any ideas on what to try next? >> >> On 7/26/13 11:14 PM, Pete Brunet wrote: >>> Hi, My build was running pretty well but then failed inside the jdk >>> build. My invocation was: >>> >>> cd .../jdk8 >>> bash ./configure --withfreetype=... --with-target-bits=32 >>> --with-debug-level=fastdebug >>> make all >>> >>> The log is >>> ... >>> ## Starting jdk >>> Importing CORBA src.zip >>> Importing CORBA classes.jar >>> Importing CORBA bin.zip >>> Importing JAXP src.zip >>> Importing JAXP classes.jar >>> Importing JAXWS src.zip >>> Importing JAXWS classes.jar >>> Importing LANGTOOLS src.zip >>> Importing LANGTOOLS classes.jar >>> Compiling 166 files for BUILD_TOOLS >>> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 >>> for 80x86 >>> >>> Copyright (C) Microsoft Corporation. All rights reserved. >>> >>> >>> >>> genSocketOptionRegistry.c >>> Generating charsetmapping classes >>> Generating buffer classes >>> Generating exceptions classes >>> Microsoft (R) Incremental Linker Version 10.00.40219.01 >>> >>> Copyright (C) Microsoft Corporation. All rights reserved. >>> >>> >>> >>> Note: Some input files use unchecked or unsafe operations. >>> >>> Note: Recompile with -Xlint:unchecked for details. >>> >>> Copying and cleaning 53 properties >>> Compiling 522 properties into resource bundles >>> Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. >>> Generating sun/misc/Version.java >>> Generating sun/misc/Version.java compact1 >>> Generating sun/misc/Version.java compact2 >>> Generating sun/misc/Version.java compact3 >>> Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 >>> >>> Classes: Table size 32 (5 bits), shift 1, max chain depth 3 >>> >>> Cache: Table size 32 (5 bits), shift 1, max chain depth 3 >>> >>> Generating beaninfo >>> Generating Nimbus source files >>> [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, >>> 16.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>> >>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>> >>> [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) >>> >>> Compiling 4 files for BUILD_BREAKITERATOR >>> Generating HTML DTD file >>> [Parsed DTD html32 in 801ms] >>> >>> Compiling 9795 files for BUILD_JDK >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: >>> error: cannot find symbol >>> >>> private BindingListHolder _bindingList; // list of bindings >>> >>> ^ >>> >>> symbol: class BindingListHolder >>> >>> location: class CNBindingEnumeration >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: >>> error: cannot find symbol >>> >>> private BindingIterator _bindingIter; // iterator for getting list >>> of bindings >>> >>> ^ >>> >>> symbol: class BindingIterator >>> >>> location: class CNBindingEnumeration >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: >>> error: package org.omg.CosNaming.NamingContextPackage does not exist >>> >>> import org.omg.CosNaming.NamingContextPackage.*; >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: >>> error: cannot find symbol >>> >>> private javax.naming.Binding mapBinding(org.omg.CosNaming.Binding bndg) >>> >>> ^ >>> >>> symbol: class Binding >>> >>> location: package org.omg.CosNaming >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: >>> error: cannot find symbol >>> >>> public NamingContext _nc; // public for accessing underlying >>> NamingContext >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: >>> error: cannot find symbol >>> >>> private NameComponent[] _name = null; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: >>> error: cannot find symbol >>> >>> import org.omg.CosNaming.NameComponent; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: package org.omg.CosNaming >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: >>> error: cannot find symbol >>> >>> CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: >>> error: cannot find symbol >>> >>> Hashtable env, NameComponent[]name) >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >>> error: cannot find symbol >>> >>> NameComponent[] makeFullName(NameComponent[] child) { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >>> error: cannot find symbol >>> >>> NameComponent[] makeFullName(NameComponent[] child) { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: >>> error: cannot find symbol >>> >>> java.lang.Object callResolve(NameComponent[] path) >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: >>> error: cannot find symbol >>> >>> private void callBindOrRebind(NameComponent[] pth, Name name, >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: >>> error: cannot find symbol >>> >>> private void callUnbind(NameComponent[] path) throws NamingException { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >>> error: cannot find symbol >>> >>> private boolean leafNotFound(NotFound e, NameComponent leaf) { >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >>> error: cannot find symbol >>> >>> private boolean leafNotFound(NotFound e, NameComponent leaf) { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: >>> error: cannot find symbol >>> >>> private void callDestroy(NamingContext nc) >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: >>> error: cannot find symbol >>> >>> private javax.naming.Context callBindNewContext(NameComponent[] path) >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: >>> error: cannot find symbol >>> >>> static NameComponent[] nameToCosName(Name name) >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: >>> error: cannot find symbol >>> >>> static String cosNameToInsString(NameComponent[] cname) { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: >>> error: cannot find symbol >>> >>> static Name cosNameToName(NameComponent[] cname) { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: >>> error: cannot find symbol >>> >>> private static NameComponent parseComponent(String compStr) >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: >>> error: cannot find symbol >>> >>> private static String stringifyComponent(NameComponent comp) { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: >>> error: package org.omg.CosNaming.NamingContextPackage does not exist >>> >>> import org.omg.CosNaming.NamingContextPackage.*; >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: >>> error: cannot find symbol >>> >>> CNCtx ctx, NameComponent[] inputName) throws NamingException { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: >>> error: cannot find symbol >>> >>> private static final NamingException tryFed(NotFound e, CNCtx ctx, >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: >>> error: cannot find symbol >>> >>> NameComponent[] inputName) throws NamingException { >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: >>> warning: auxiliary class InetAddressContainer in >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>> should not be accessed from outside its own source file >>> >>> static native void localAddress(int fd, InetAddressContainer in) >>> throws SocketException; >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: >>> error: cannot find symbol >>> >>> _bindingList = new BindingListHolder(); >>> >>> ^ >>> >>> symbol: class BindingListHolder >>> >>> location: class CNBindingEnumeration >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >>> error: cannot find symbol >>> >>> BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); >>> >>> ^ >>> >>> symbol: class BindingIteratorHolder >>> >>> location: class CNBindingEnumeration >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >>> error: cannot find symbol >>> >>> BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); >>> >>> ^ >>> >>> symbol: class BindingIteratorHolder >>> >>> location: class CNBindingEnumeration >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: >>> error: cannot find symbol >>> >>> org.omg.CosNaming.Binding bndg = _bindingList.value[counter]; >>> >>> ^ >>> >>> symbol: class Binding >>> >>> location: package org.omg.CosNaming >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: >>> error: cannot find symbol >>> >>> NameComponent[] comps = _ctx.makeFullName(bndg.binding_name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNBindingEnumeration >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >>> error: cannot find symbol >>> >>> NameComponent[] answer = new >>> NameComponent[_name.length+child.length]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >>> error: cannot find symbol >>> >>> NameComponent[] answer = new >>> NameComponent[_name.length+child.length]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: >>> error: cannot find symbol >>> >>> _nc = NamingContextHelper.narrow(obj); >>> >>> ^ >>> >>> symbol: variable NamingContextHelper >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: >>> error: cannot find symbol >>> >>> _nc = NamingContextHelper.narrow(ncRef); >>> >>> ^ >>> >>> symbol: variable NamingContextHelper >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: >>> error: cannot find symbol >>> >>> _nc = NamingContextHelper.narrow(ncRef); >>> >>> ^ >>> >>> symbol: variable NamingContextHelper >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: >>> error: cannot find symbol >>> >>> NamingContext nc = >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: >>> error: cannot find symbol >>> >>> NamingContextHelper.narrow(obj); >>> >>> ^ >>> >>> symbol: variable NamingContextHelper >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: >>> error: cannot find symbol >>> >>> NameComponent[] path = CNNameParser.nameToCosName(name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: >>> error: cannot find symbol >>> >>> if ( obj instanceof org.omg.CosNaming.NamingContext) { >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: package org.omg.CosNaming >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: >>> error: cannot find symbol >>> >>> NamingContext nobj = >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: >>> error: cannot find symbol >>> >>> >>> NamingContextHelper.narrow((org.omg.CORBA.Object)obj); >>> >>> ^ >>> >>> symbol: variable NamingContextHelper >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: >>> error: cannot find symbol >>> >>> NameComponent[] path = CNNameParser.nameToCosName(name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: >>> error: cannot find symbol >>> >>> NameComponent[] path = CNNameParser.nameToCosName(name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: >>> error: cannot find symbol >>> >>> } catch (NotFound e) { >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: >>> error: cannot find symbol >>> >>> NameComponent rest; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: >>> error: cannot find symbol >>> >>> return e.why.value() == NotFoundReason._missing_node && >>> >>> ^ >>> >>> symbol: variable NotFoundReason >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: >>> error: cannot find symbol >>> >>> NameComponent[] path = CNNameParser.nameToCosName(name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: >>> error: cannot find symbol >>> >>> NamingContext the_nc = _nc; >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: >>> error: cannot find symbol >>> >>> NameComponent[] path = CNNameParser.nameToCosName(name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: >>> error: cannot find symbol >>> >>> if (e.getRootCause() instanceof NotFound && >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: >>> error: cannot find symbol >>> >>> leafNotFound((NotFound)e.getRootCause(), >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: >>> error: cannot find symbol >>> >>> NamingContext nctx = _nc.bind_new_context(path); >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: >>> error: cannot find symbol >>> >>> NameComponent[] path = CNNameParser.nameToCosName(name); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNCtx >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: >>> error: cannot find symbol >>> >>> return new NameComponent[0]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >>> error: cannot find symbol >>> >>> NameComponent[] answer = new NameComponent[len]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >>> error: cannot find symbol >>> >>> NameComponent[] answer = new NameComponent[len]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: >>> error: cannot find symbol >>> >>> new NameComponent(new String(id, 0, idCount), >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >>> error: cannot find symbol >>> >>> NameComponent comp = new NameComponent(); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >>> error: cannot find symbol >>> >>> NameComponent comp = new NameComponent(); >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class CNNameParser >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: >>> error: cannot find symbol >>> >>> if (e instanceof NotFound) { >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: >>> error: cannot find symbol >>> >>> return tryFed((NotFound)e, ctx, inputName); >>> >>> ^ >>> >>> symbol: class NotFound >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: >>> error: cannot find symbol >>> >>> } else if (e instanceof CannotProceed) { >>> >>> ^ >>> >>> symbol: class CannotProceed >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >>> error: cannot find symbol >>> >>> NamingContext nc = ((CannotProceed) e).cxt; >>> >>> ^ >>> >>> symbol: class NamingContext >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >>> error: cannot find symbol >>> >>> NamingContext nc = ((CannotProceed) e).cxt; >>> >>> ^ >>> >>> symbol: class CannotProceed >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >>> error: cannot find symbol >>> >>> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >>> error: cannot find symbol >>> >>> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >>> >>> ^ >>> >>> symbol: class CannotProceed >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: >>> error: cannot find symbol >>> >>> NameComponent[] resolvedName = >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: >>> error: cannot find symbol >>> >>> new NameComponent[inputName.length - rest.length]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: >>> error: cannot find symbol >>> >>> } else if (e instanceof InvalidName) { >>> >>> ^ >>> >>> symbol: class InvalidName >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: >>> error: cannot find symbol >>> >>> } else if (e instanceof AlreadyBound) { >>> >>> ^ >>> >>> symbol: class AlreadyBound >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: >>> error: cannot find symbol >>> >>> } else if (e instanceof NotEmpty) { >>> >>> ^ >>> >>> symbol: class NotEmpty >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: >>> error: cannot find symbol >>> >>> NameComponent[] rest = e.rest_of_name; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: >>> error: cannot find symbol >>> >>> NameComponent lastIn = inputName[inputName.length-1]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: >>> error: cannot find symbol >>> >>> NameComponent[] resolvedName = null; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: >>> error: cannot find symbol >>> >>> if (e.why == NotFoundReason.not_context) { >>> >>> ^ >>> >>> symbol: variable NotFoundReason >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >>> error: cannot find symbol >>> >>> NameComponent[] tmp = new NameComponent[rest.length-1]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >>> error: cannot find symbol >>> >>> NameComponent[] tmp = new NameComponent[rest.length-1]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: >>> error: cannot find symbol >>> >>> resolvedName = new NameComponent[len]; >>> >>> ^ >>> >>> symbol: class NameComponent >>> >>> location: class ExceptionMapper >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: >>> warning: [overrides] Class XMLX509IssuerSerial overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public class XMLX509IssuerSerial extends SignatureElementProxy >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: >>> warning: [overrides] Class XMLX509SKI overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public class XMLX509SKI extends SignatureElementProxy >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: >>> warning: [overrides] Class XMLX509SubjectName overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public class XMLX509SubjectName extends SignatureElementProxy >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: >>> warning: [overrides] Class XMLX509Certificate overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public class XMLX509Certificate extends SignatureElementProxy >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: >>> warning: [overrides] Class DOMTransform overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public class DOMTransform extends DOMStructure implements Transform { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: >>> warning: [overrides] Class DOMCanonicalizationMethod overrides equals, >>> but neither it nor any superclass overrides hashCode method >>> >>> public class DOMCanonicalizationMethod extends DOMTransform >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: >>> warning: [overrides] Class DOMSignedInfo overrides equals, but neither >>> it nor any superclass overrides hashCode method >>> >>> public final class DOMSignedInfo extends DOMStructure implements >>> SignedInfo { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: >>> warning: [overrides] Class DOMKeyInfo overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMKeyInfo extends DOMStructure implements KeyInfo { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: >>> warning: [overrides] Class DOMKeyName overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMKeyName extends DOMStructure implements KeyName { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: >>> warning: [overrides] Class DOMKeyValue overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMKeyValue extends DOMStructure implements KeyValue { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: >>> warning: [overrides] Class DOMManifest overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMManifest extends DOMStructure implements Manifest { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: >>> warning: [overrides] Class DOMReference overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMReference extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: >>> warning: [overrides] Class DOMRetrievalMethod overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public final class DOMRetrievalMethod extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: >>> warning: [overrides] Class DOMSignatureProperties overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public final class DOMSignatureProperties extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: >>> warning: [overrides] Class DOMSignatureProperty overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public final class DOMSignatureProperty extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: >>> warning: [overrides] Class DOMX509Data overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMX509Data extends DOMStructure implements X509Data { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: >>> warning: [overrides] Class DOMX509IssuerSerial overrides equals, but >>> neither it nor any superclass overrides hashCode method >>> >>> public final class DOMX509IssuerSerial extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: >>> warning: [overrides] Class DOMXMLObject overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public final class DOMXMLObject extends DOMStructure implements XMLObject { >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: >>> warning: [overrides] Class DOMXMLSignature.DOMSignatureValue overrides >>> equals, but neither it nor any superclass overrides hashCode method >>> >>> public class DOMSignatureValue extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: >>> warning: [overrides] Class DOMXMLSignature overrides equals, but neither >>> it nor any superclass overrides hashCode method >>> >>> public final class DOMXMLSignature extends DOMStructure >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: >>> warning: auxiliary class InetAddressContainer in >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>> should not be accessed from outside its own source file >>> >>> localAddress(nativefd, (InetAddressContainer)iaContainerObj); >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >>> warning: auxiliary class InetAddressContainer in >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>> should not be accessed from outside its own source file >>> >>> InetAddressContainer in = new InetAddressContainer(); >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >>> warning: auxiliary class InetAddressContainer in >>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>> should not be accessed from outside its own source file >>> >>> InetAddressContainer in = new InetAddressContainer(); >>> >>> ^ >>> >>> c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: >>> warning: [overrides] Class Translator overrides equals, but neither it >>> nor any superclass overrides hashCode method >>> >>> public class Translator extends AccessibleContext >>> >>> ^ >>> >>> Note: Some input files use or override a deprecated API. >>> >>> Note: Recompile with -Xlint:deprecation for details. >>> >>> Note: Some input files use unchecked or unsafe operations. >>> >>> Note: Recompile with -Xlint:unchecked for details. >>> >>> 80 errors >>> >>> 25 warnings >>> >>> make[2]: *** >>> [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] >>> Error 1 >>> make[1]: *** [classes-only] Error 2 >>> make: *** [jdk-only] Error 2 From philip.race at oracle.com Mon Jul 29 17:22:05 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 29 Jul 2013 10:22:05 -0700 Subject: jdk8 first build attempt - failed In-Reply-To: <51F683C5.5090108@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> Message-ID: <51F6A4BD.3040709@oracle.com> Its generated from the IDL file by the idl compiler. Should be under build/macosx.../corba/gensrc/ -phil. On 7/29/2013 8:01 AM, Pete Brunet wrote: > I don't see BindingListHolder.java in the repo at > hg.openjdk.java.net/jdk8/awt/corba/file/a013024b0747/src/share/classes/org/omg/CosNaming > > Is it supposed to be there? > Or is this line of code in error by using BindingListHolder? > c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: > Or something else? > > Pete > > On 7/29/13 8:27 AM, Pete Brunet wrote: >> The first failure is >> >> error: cannot find symbol >> symbol: class BindingListHolder >> location: class CNBindingEnumeration >> >> Googling shows that BindingListHolder is in package org.omg.CosNaming. >> The class file is not in >> build\windows-x86-normal-server-fastdebug\corba\classes\org\omg\CosNaming and >> the source file is not in corba\src\share\classes\org\omg\CosNaming >> >> Is that a useful hint? >> >> Pete >> >> On 7/27/13 12:17 PM, Pete Brunet wrote: >>> repulled, configure ..., make clean, make all >>> >>> jdk build still fails - same failure >>> >>> any ideas on what to try next? >>> >>> On 7/26/13 11:14 PM, Pete Brunet wrote: >>>> Hi, My build was running pretty well but then failed inside the jdk >>>> build. My invocation was: >>>> >>>> cd .../jdk8 >>>> bash ./configure --withfreetype=... --with-target-bits=32 >>>> --with-debug-level=fastdebug >>>> make all >>>> >>>> The log is >>>> ... >>>> ## Starting jdk >>>> Importing CORBA src.zip >>>> Importing CORBA classes.jar >>>> Importing CORBA bin.zip >>>> Importing JAXP src.zip >>>> Importing JAXP classes.jar >>>> Importing JAXWS src.zip >>>> Importing JAXWS classes.jar >>>> Importing LANGTOOLS src.zip >>>> Importing LANGTOOLS classes.jar >>>> Compiling 166 files for BUILD_TOOLS >>>> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 >>>> for 80x86 >>>> >>>> Copyright (C) Microsoft Corporation. All rights reserved. >>>> >>>> >>>> >>>> genSocketOptionRegistry.c >>>> Generating charsetmapping classes >>>> Generating buffer classes >>>> Generating exceptions classes >>>> Microsoft (R) Incremental Linker Version 10.00.40219.01 >>>> >>>> Copyright (C) Microsoft Corporation. All rights reserved. >>>> >>>> >>>> >>>> Note: Some input files use unchecked or unsafe operations. >>>> >>>> Note: Recompile with -Xlint:unchecked for details. >>>> >>>> Copying and cleaning 53 properties >>>> Compiling 522 properties into resource bundles >>>> Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. >>>> Generating sun/misc/Version.java >>>> Generating sun/misc/Version.java compact1 >>>> Generating sun/misc/Version.java compact2 >>>> Generating sun/misc/Version.java compact3 >>>> Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 >>>> >>>> Classes: Table size 32 (5 bits), shift 1, max chain depth 3 >>>> >>>> Cache: Table size 32 (5 bits), shift 1, max chain depth 3 >>>> >>>> Generating beaninfo >>>> Generating Nimbus source files >>>> [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 11.0, >>>> 16.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, 14.0, 15.0) >>>> >>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 25.0) >>>> >>>> [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) >>>> >>>> Compiling 4 files for BUILD_BREAKITERATOR >>>> Generating HTML DTD file >>>> [Parsed DTD html32 in 801ms] >>>> >>>> Compiling 9795 files for BUILD_JDK >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: >>>> error: cannot find symbol >>>> >>>> private BindingListHolder _bindingList; // list of bindings >>>> >>>> ^ >>>> >>>> symbol: class BindingListHolder >>>> >>>> location: class CNBindingEnumeration >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: >>>> error: cannot find symbol >>>> >>>> private BindingIterator _bindingIter; // iterator for getting list >>>> of bindings >>>> >>>> ^ >>>> >>>> symbol: class BindingIterator >>>> >>>> location: class CNBindingEnumeration >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: >>>> error: package org.omg.CosNaming.NamingContextPackage does not exist >>>> >>>> import org.omg.CosNaming.NamingContextPackage.*; >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: >>>> error: cannot find symbol >>>> >>>> private javax.naming.Binding mapBinding(org.omg.CosNaming.Binding bndg) >>>> >>>> ^ >>>> >>>> symbol: class Binding >>>> >>>> location: package org.omg.CosNaming >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: >>>> error: cannot find symbol >>>> >>>> public NamingContext _nc; // public for accessing underlying >>>> NamingContext >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: >>>> error: cannot find symbol >>>> >>>> private NameComponent[] _name = null; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: >>>> error: cannot find symbol >>>> >>>> import org.omg.CosNaming.NameComponent; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: package org.omg.CosNaming >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: >>>> error: cannot find symbol >>>> >>>> CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: >>>> error: cannot find symbol >>>> >>>> Hashtable env, NameComponent[]name) >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >>>> error: cannot find symbol >>>> >>>> NameComponent[] makeFullName(NameComponent[] child) { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >>>> error: cannot find symbol >>>> >>>> NameComponent[] makeFullName(NameComponent[] child) { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: >>>> error: cannot find symbol >>>> >>>> java.lang.Object callResolve(NameComponent[] path) >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: >>>> error: cannot find symbol >>>> >>>> private void callBindOrRebind(NameComponent[] pth, Name name, >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: >>>> error: cannot find symbol >>>> >>>> private void callUnbind(NameComponent[] path) throws NamingException { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >>>> error: cannot find symbol >>>> >>>> private boolean leafNotFound(NotFound e, NameComponent leaf) { >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >>>> error: cannot find symbol >>>> >>>> private boolean leafNotFound(NotFound e, NameComponent leaf) { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: >>>> error: cannot find symbol >>>> >>>> private void callDestroy(NamingContext nc) >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: >>>> error: cannot find symbol >>>> >>>> private javax.naming.Context callBindNewContext(NameComponent[] path) >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: >>>> error: cannot find symbol >>>> >>>> static NameComponent[] nameToCosName(Name name) >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: >>>> error: cannot find symbol >>>> >>>> static String cosNameToInsString(NameComponent[] cname) { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: >>>> error: cannot find symbol >>>> >>>> static Name cosNameToName(NameComponent[] cname) { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: >>>> error: cannot find symbol >>>> >>>> private static NameComponent parseComponent(String compStr) >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: >>>> error: cannot find symbol >>>> >>>> private static String stringifyComponent(NameComponent comp) { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: >>>> error: package org.omg.CosNaming.NamingContextPackage does not exist >>>> >>>> import org.omg.CosNaming.NamingContextPackage.*; >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: >>>> error: cannot find symbol >>>> >>>> CNCtx ctx, NameComponent[] inputName) throws NamingException { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: >>>> error: cannot find symbol >>>> >>>> private static final NamingException tryFed(NotFound e, CNCtx ctx, >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: >>>> error: cannot find symbol >>>> >>>> NameComponent[] inputName) throws NamingException { >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: >>>> warning: auxiliary class InetAddressContainer in >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>> should not be accessed from outside its own source file >>>> >>>> static native void localAddress(int fd, InetAddressContainer in) >>>> throws SocketException; >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: >>>> error: cannot find symbol >>>> >>>> _bindingList = new BindingListHolder(); >>>> >>>> ^ >>>> >>>> symbol: class BindingListHolder >>>> >>>> location: class CNBindingEnumeration >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >>>> error: cannot find symbol >>>> >>>> BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); >>>> >>>> ^ >>>> >>>> symbol: class BindingIteratorHolder >>>> >>>> location: class CNBindingEnumeration >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >>>> error: cannot find symbol >>>> >>>> BindingIteratorHolder _bindingIterH = new BindingIteratorHolder(); >>>> >>>> ^ >>>> >>>> symbol: class BindingIteratorHolder >>>> >>>> location: class CNBindingEnumeration >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: >>>> error: cannot find symbol >>>> >>>> org.omg.CosNaming.Binding bndg = _bindingList.value[counter]; >>>> >>>> ^ >>>> >>>> symbol: class Binding >>>> >>>> location: package org.omg.CosNaming >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: >>>> error: cannot find symbol >>>> >>>> NameComponent[] comps = _ctx.makeFullName(bndg.binding_name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNBindingEnumeration >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >>>> error: cannot find symbol >>>> >>>> NameComponent[] answer = new >>>> NameComponent[_name.length+child.length]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >>>> error: cannot find symbol >>>> >>>> NameComponent[] answer = new >>>> NameComponent[_name.length+child.length]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: >>>> error: cannot find symbol >>>> >>>> _nc = NamingContextHelper.narrow(obj); >>>> >>>> ^ >>>> >>>> symbol: variable NamingContextHelper >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: >>>> error: cannot find symbol >>>> >>>> _nc = NamingContextHelper.narrow(ncRef); >>>> >>>> ^ >>>> >>>> symbol: variable NamingContextHelper >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: >>>> error: cannot find symbol >>>> >>>> _nc = NamingContextHelper.narrow(ncRef); >>>> >>>> ^ >>>> >>>> symbol: variable NamingContextHelper >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: >>>> error: cannot find symbol >>>> >>>> NamingContext nc = >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: >>>> error: cannot find symbol >>>> >>>> NamingContextHelper.narrow(obj); >>>> >>>> ^ >>>> >>>> symbol: variable NamingContextHelper >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: >>>> error: cannot find symbol >>>> >>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: >>>> error: cannot find symbol >>>> >>>> if ( obj instanceof org.omg.CosNaming.NamingContext) { >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: package org.omg.CosNaming >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: >>>> error: cannot find symbol >>>> >>>> NamingContext nobj = >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: >>>> error: cannot find symbol >>>> >>>> >>>> NamingContextHelper.narrow((org.omg.CORBA.Object)obj); >>>> >>>> ^ >>>> >>>> symbol: variable NamingContextHelper >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: >>>> error: cannot find symbol >>>> >>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: >>>> error: cannot find symbol >>>> >>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: >>>> error: cannot find symbol >>>> >>>> } catch (NotFound e) { >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: >>>> error: cannot find symbol >>>> >>>> NameComponent rest; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: >>>> error: cannot find symbol >>>> >>>> return e.why.value() == NotFoundReason._missing_node && >>>> >>>> ^ >>>> >>>> symbol: variable NotFoundReason >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: >>>> error: cannot find symbol >>>> >>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: >>>> error: cannot find symbol >>>> >>>> NamingContext the_nc = _nc; >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: >>>> error: cannot find symbol >>>> >>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: >>>> error: cannot find symbol >>>> >>>> if (e.getRootCause() instanceof NotFound && >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: >>>> error: cannot find symbol >>>> >>>> leafNotFound((NotFound)e.getRootCause(), >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: >>>> error: cannot find symbol >>>> >>>> NamingContext nctx = _nc.bind_new_context(path); >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: >>>> error: cannot find symbol >>>> >>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNCtx >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: >>>> error: cannot find symbol >>>> >>>> return new NameComponent[0]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >>>> error: cannot find symbol >>>> >>>> NameComponent[] answer = new NameComponent[len]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >>>> error: cannot find symbol >>>> >>>> NameComponent[] answer = new NameComponent[len]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: >>>> error: cannot find symbol >>>> >>>> new NameComponent(new String(id, 0, idCount), >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >>>> error: cannot find symbol >>>> >>>> NameComponent comp = new NameComponent(); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >>>> error: cannot find symbol >>>> >>>> NameComponent comp = new NameComponent(); >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class CNNameParser >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: >>>> error: cannot find symbol >>>> >>>> if (e instanceof NotFound) { >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: >>>> error: cannot find symbol >>>> >>>> return tryFed((NotFound)e, ctx, inputName); >>>> >>>> ^ >>>> >>>> symbol: class NotFound >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: >>>> error: cannot find symbol >>>> >>>> } else if (e instanceof CannotProceed) { >>>> >>>> ^ >>>> >>>> symbol: class CannotProceed >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >>>> error: cannot find symbol >>>> >>>> NamingContext nc = ((CannotProceed) e).cxt; >>>> >>>> ^ >>>> >>>> symbol: class NamingContext >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >>>> error: cannot find symbol >>>> >>>> NamingContext nc = ((CannotProceed) e).cxt; >>>> >>>> ^ >>>> >>>> symbol: class CannotProceed >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >>>> error: cannot find symbol >>>> >>>> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >>>> error: cannot find symbol >>>> >>>> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >>>> >>>> ^ >>>> >>>> symbol: class CannotProceed >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: >>>> error: cannot find symbol >>>> >>>> NameComponent[] resolvedName = >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: >>>> error: cannot find symbol >>>> >>>> new NameComponent[inputName.length - rest.length]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: >>>> error: cannot find symbol >>>> >>>> } else if (e instanceof InvalidName) { >>>> >>>> ^ >>>> >>>> symbol: class InvalidName >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: >>>> error: cannot find symbol >>>> >>>> } else if (e instanceof AlreadyBound) { >>>> >>>> ^ >>>> >>>> symbol: class AlreadyBound >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: >>>> error: cannot find symbol >>>> >>>> } else if (e instanceof NotEmpty) { >>>> >>>> ^ >>>> >>>> symbol: class NotEmpty >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: >>>> error: cannot find symbol >>>> >>>> NameComponent[] rest = e.rest_of_name; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: >>>> error: cannot find symbol >>>> >>>> NameComponent lastIn = inputName[inputName.length-1]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: >>>> error: cannot find symbol >>>> >>>> NameComponent[] resolvedName = null; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: >>>> error: cannot find symbol >>>> >>>> if (e.why == NotFoundReason.not_context) { >>>> >>>> ^ >>>> >>>> symbol: variable NotFoundReason >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >>>> error: cannot find symbol >>>> >>>> NameComponent[] tmp = new NameComponent[rest.length-1]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >>>> error: cannot find symbol >>>> >>>> NameComponent[] tmp = new NameComponent[rest.length-1]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: >>>> error: cannot find symbol >>>> >>>> resolvedName = new NameComponent[len]; >>>> >>>> ^ >>>> >>>> symbol: class NameComponent >>>> >>>> location: class ExceptionMapper >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: >>>> warning: [overrides] Class XMLX509IssuerSerial overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public class XMLX509IssuerSerial extends SignatureElementProxy >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: >>>> warning: [overrides] Class XMLX509SKI overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public class XMLX509SKI extends SignatureElementProxy >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: >>>> warning: [overrides] Class XMLX509SubjectName overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public class XMLX509SubjectName extends SignatureElementProxy >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: >>>> warning: [overrides] Class XMLX509Certificate overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public class XMLX509Certificate extends SignatureElementProxy >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: >>>> warning: [overrides] Class DOMTransform overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public class DOMTransform extends DOMStructure implements Transform { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: >>>> warning: [overrides] Class DOMCanonicalizationMethod overrides equals, >>>> but neither it nor any superclass overrides hashCode method >>>> >>>> public class DOMCanonicalizationMethod extends DOMTransform >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: >>>> warning: [overrides] Class DOMSignedInfo overrides equals, but neither >>>> it nor any superclass overrides hashCode method >>>> >>>> public final class DOMSignedInfo extends DOMStructure implements >>>> SignedInfo { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: >>>> warning: [overrides] Class DOMKeyInfo overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMKeyInfo extends DOMStructure implements KeyInfo { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: >>>> warning: [overrides] Class DOMKeyName overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMKeyName extends DOMStructure implements KeyName { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: >>>> warning: [overrides] Class DOMKeyValue overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMKeyValue extends DOMStructure implements KeyValue { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: >>>> warning: [overrides] Class DOMManifest overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMManifest extends DOMStructure implements Manifest { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: >>>> warning: [overrides] Class DOMReference overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMReference extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: >>>> warning: [overrides] Class DOMRetrievalMethod overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public final class DOMRetrievalMethod extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: >>>> warning: [overrides] Class DOMSignatureProperties overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public final class DOMSignatureProperties extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: >>>> warning: [overrides] Class DOMSignatureProperty overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public final class DOMSignatureProperty extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: >>>> warning: [overrides] Class DOMX509Data overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMX509Data extends DOMStructure implements X509Data { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: >>>> warning: [overrides] Class DOMX509IssuerSerial overrides equals, but >>>> neither it nor any superclass overrides hashCode method >>>> >>>> public final class DOMX509IssuerSerial extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: >>>> warning: [overrides] Class DOMXMLObject overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public final class DOMXMLObject extends DOMStructure implements XMLObject { >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: >>>> warning: [overrides] Class DOMXMLSignature.DOMSignatureValue overrides >>>> equals, but neither it nor any superclass overrides hashCode method >>>> >>>> public class DOMSignatureValue extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: >>>> warning: [overrides] Class DOMXMLSignature overrides equals, but neither >>>> it nor any superclass overrides hashCode method >>>> >>>> public final class DOMXMLSignature extends DOMStructure >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: >>>> warning: auxiliary class InetAddressContainer in >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>> should not be accessed from outside its own source file >>>> >>>> localAddress(nativefd, (InetAddressContainer)iaContainerObj); >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >>>> warning: auxiliary class InetAddressContainer in >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>> should not be accessed from outside its own source file >>>> >>>> InetAddressContainer in = new InetAddressContainer(); >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >>>> warning: auxiliary class InetAddressContainer in >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>> should not be accessed from outside its own source file >>>> >>>> InetAddressContainer in = new InetAddressContainer(); >>>> >>>> ^ >>>> >>>> c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: >>>> warning: [overrides] Class Translator overrides equals, but neither it >>>> nor any superclass overrides hashCode method >>>> >>>> public class Translator extends AccessibleContext >>>> >>>> ^ >>>> >>>> Note: Some input files use or override a deprecated API. >>>> >>>> Note: Recompile with -Xlint:deprecation for details. >>>> >>>> Note: Some input files use unchecked or unsafe operations. >>>> >>>> Note: Recompile with -Xlint:unchecked for details. >>>> >>>> 80 errors >>>> >>>> 25 warnings >>>> >>>> make[2]: *** >>>> [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] >>>> Error 1 >>>> make[1]: *** [classes-only] Error 2 >>>> make: *** [jdk-only] Error 2 From peter.brunet at oracle.com Mon Jul 29 17:25:33 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 12:25:33 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F6A4BD.3040709@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> <51F6A4BD.3040709@oracle.com> Message-ID: <51F6A58D.2070700@oracle.com> Thanks Phil, I found build\windows-x86-normal-server-fastdebug\corba\gensrc and in that dir is one file _the_idls.d with one line IDLS_ARE_CREATED=yes Pete On 7/29/13 12:22 PM, Phil Race wrote: > Its generated from the IDL file by the idl compiler. > Should be under build/macosx.../corba/gensrc/ > > -phil. > > On 7/29/2013 8:01 AM, Pete Brunet wrote: >> I don't see BindingListHolder.java in the repo at >> hg.openjdk.java.net/jdk8/awt/corba/file/a013024b0747/src/share/classes/org/omg/CosNaming >> >> >> Is it supposed to be there? >> Or is this line of code in error by using BindingListHolder? >> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: >> >> Or something else? >> >> Pete >> >> On 7/29/13 8:27 AM, Pete Brunet wrote: >>> The first failure is >>> >>> error: cannot find symbol >>> symbol: class BindingListHolder >>> location: class CNBindingEnumeration >>> >>> Googling shows that BindingListHolder is in package org.omg.CosNaming. >>> The class file is not in >>> build\windows-x86-normal-server-fastdebug\corba\classes\org\omg\CosNaming >>> and >>> the source file is not in corba\src\share\classes\org\omg\CosNaming >>> >>> Is that a useful hint? >>> >>> Pete >>> >>> On 7/27/13 12:17 PM, Pete Brunet wrote: >>>> repulled, configure ..., make clean, make all >>>> >>>> jdk build still fails - same failure >>>> >>>> any ideas on what to try next? >>>> >>>> On 7/26/13 11:14 PM, Pete Brunet wrote: >>>>> Hi, My build was running pretty well but then failed inside the jdk >>>>> build. My invocation was: >>>>> >>>>> cd .../jdk8 >>>>> bash ./configure --withfreetype=... --with-target-bits=32 >>>>> --with-debug-level=fastdebug >>>>> make all >>>>> >>>>> The log is >>>>> ... >>>>> ## Starting jdk >>>>> Importing CORBA src.zip >>>>> Importing CORBA classes.jar >>>>> Importing CORBA bin.zip >>>>> Importing JAXP src.zip >>>>> Importing JAXP classes.jar >>>>> Importing JAXWS src.zip >>>>> Importing JAXWS classes.jar >>>>> Importing LANGTOOLS src.zip >>>>> Importing LANGTOOLS classes.jar >>>>> Compiling 166 files for BUILD_TOOLS >>>>> Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.40219.01 >>>>> for 80x86 >>>>> >>>>> Copyright (C) Microsoft Corporation. All rights reserved. >>>>> >>>>> >>>>> >>>>> genSocketOptionRegistry.c >>>>> Generating charsetmapping classes >>>>> Generating buffer classes >>>>> Generating exceptions classes >>>>> Microsoft (R) Incremental Linker Version 10.00.40219.01 >>>>> >>>>> Copyright (C) Microsoft Corporation. All rights reserved. >>>>> >>>>> >>>>> >>>>> Note: Some input files use unchecked or unsafe operations. >>>>> >>>>> Note: Recompile with -Xlint:unchecked for details. >>>>> >>>>> Copying and cleaning 53 properties >>>>> Compiling 522 properties into resource bundles >>>>> Creating sun/util/LocaleDataMetaInfo.java from 422 found resources. >>>>> Generating sun/misc/Version.java >>>>> Generating sun/misc/Version.java compact1 >>>>> Generating sun/misc/Version.java compact2 >>>>> Generating sun/misc/Version.java compact3 >>>>> Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3 >>>>> >>>>> Classes: Table size 32 (5 bits), shift 1, max chain depth 3 >>>>> >>>>> Cache: Table size 32 (5 bits), shift 1, max chain depth 3 >>>>> >>>>> Generating beaninfo >>>>> Generating Nimbus source files >>>>> [Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, >>>>> 11.0, >>>>> 16.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, >>>>> 14.0, 15.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, >>>>> 14.0, 15.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, >>>>> 14.0, 15.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, >>>>> 14.0, 15.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, >>>>> 14.0, 15.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] encoded value was greater than 3: encode(15.029411, 1.0, >>>>> 14.0, 15.0) >>>>> >>>>> [Error] encoded value was less than 0: encode(-0.05882353, 1.0, >>>>> 24.0, 25.0) >>>>> >>>>> [Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0) >>>>> >>>>> Compiling 4 files for BUILD_BREAKITERATOR >>>>> Generating HTML DTD file >>>>> [Parsed DTD html32 in 801ms] >>>>> >>>>> Compiling 9795 files for BUILD_JDK >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:49: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private BindingListHolder _bindingList; // list of bindings >>>>> >>>>> ^ >>>>> >>>>> symbol: class BindingListHolder >>>>> >>>>> location: class CNBindingEnumeration >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:50: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private BindingIterator _bindingIter; // iterator for >>>>> getting list >>>>> of bindings >>>>> >>>>> ^ >>>>> >>>>> symbol: class BindingIterator >>>>> >>>>> location: class CNBindingEnumeration >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:41: >>>>> >>>>> error: package org.omg.CosNaming.NamingContextPackage does not exist >>>>> >>>>> import org.omg.CosNaming.NamingContextPackage.*; >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:208: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private javax.naming.Binding >>>>> mapBinding(org.omg.CosNaming.Binding bndg) >>>>> >>>>> ^ >>>>> >>>>> symbol: class Binding >>>>> >>>>> location: package org.omg.CosNaming >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:67: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> public NamingContext _nc; // public for accessing underlying >>>>> NamingContext >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:77: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private NameComponent[] _name = null; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:33: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> import org.omg.CosNaming.NameComponent; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: package org.omg.CosNaming >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:147: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> CNCtx(ORB orb, OrbReuseTracker tracker, NamingContext nctx, >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:148: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> Hashtable env, >>>>> NameComponent[]name) >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] makeFullName(NameComponent[] child) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:164: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] makeFullName(NameComponent[] child) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:483: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> java.lang.Object callResolve(NameComponent[] path) >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:573: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private void callBindOrRebind(NameComponent[] pth, Name name, >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:722: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private void callUnbind(NameComponent[] path) throws >>>>> NamingException { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private boolean leafNotFound(NotFound e, NameComponent leaf) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:742: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private boolean leafNotFound(NotFound e, NameComponent leaf) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:898: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private void callDestroy(NamingContext nc) >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:975: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private javax.naming.Context >>>>> callBindNewContext(NameComponent[] path) >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:80: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> static NameComponent[] nameToCosName(Name name) >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:98: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> static String cosNameToInsString(NameComponent[] cname) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:114: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> static Name cosNameToName(NameComponent[] cname) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:191: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private static NameComponent parseComponent(String compStr) >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:256: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private static String stringifyComponent(NameComponent comp) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:33: >>>>> >>>>> error: package org.omg.CosNaming.NamingContextPackage does not exist >>>>> >>>>> import org.omg.CosNaming.NamingContextPackage.*; >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:46: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> CNCtx ctx, NameComponent[] inputName) throws >>>>> NamingException { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:103: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> private static final NamingException tryFed(NotFound e, CNCtx >>>>> ctx, >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:104: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] inputName) throws NamingException { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:279: >>>>> >>>>> warning: auxiliary class InetAddressContainer in >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>>> >>>>> should not be accessed from outside its own source file >>>>> >>>>> static native void localAddress(int fd, InetAddressContainer in) >>>>> throws SocketException; >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:77: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> _bindingList = new BindingListHolder(); >>>>> >>>>> ^ >>>>> >>>>> symbol: class BindingListHolder >>>>> >>>>> location: class CNBindingEnumeration >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> BindingIteratorHolder _bindingIterH = new >>>>> BindingIteratorHolder(); >>>>> >>>>> ^ >>>>> >>>>> symbol: class BindingIteratorHolder >>>>> >>>>> location: class CNBindingEnumeration >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:78: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> BindingIteratorHolder _bindingIterH = new >>>>> BindingIteratorHolder(); >>>>> >>>>> ^ >>>>> >>>>> symbol: class BindingIteratorHolder >>>>> >>>>> location: class CNBindingEnumeration >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:105: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> org.omg.CosNaming.Binding bndg = >>>>> _bindingList.value[counter]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class Binding >>>>> >>>>> location: package org.omg.CosNaming >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNBindingEnumeration.java:230: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] comps = >>>>> _ctx.makeFullName(bndg.binding_name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNBindingEnumeration >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] answer = new >>>>> NameComponent[_name.length+child.length]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:168: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] answer = new >>>>> NameComponent[_name.length+child.length]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:258: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> _nc = NamingContextHelper.narrow(obj); >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NamingContextHelper >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:381: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> _nc = NamingContextHelper.narrow(ncRef); >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NamingContextHelper >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:419: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> _nc = NamingContextHelper.narrow(ncRef); >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NamingContextHelper >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:488: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContext nc = >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:489: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContextHelper.narrow(obj); >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NamingContextHelper >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:536: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:587: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> if ( obj instanceof >>>>> org.omg.CosNaming.NamingContext) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: package org.omg.CosNaming >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:588: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContext nobj = >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:589: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> >>>>> NamingContextHelper.narrow((org.omg.CORBA.Object)obj); >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NamingContextHelper >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:632: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:691: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:728: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> } catch (NotFound e) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:749: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent rest; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:750: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> return e.why.value() == NotFoundReason._missing_node && >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NotFoundReason >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:781: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:933: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContext the_nc = _nc; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:934: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:952: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> if (e.getRootCause() instanceof NotFound && >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:953: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> leafNotFound((NotFound)e.getRootCause(), >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:981: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContext nctx = _nc.bind_new_context(path); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNCtx.java:1012: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] path = CNNameParser.nameToCosName(name); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNCtx >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:84: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> return new NameComponent[0]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] answer = new NameComponent[len]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:87: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] answer = new NameComponent[len]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:177: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> new NameComponent(new String(id, 0, idCount), >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent comp = new NameComponent(); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\CNNameParser.java:193: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent comp = new NameComponent(); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class CNNameParser >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:56: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> if (e instanceof NotFound) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:58: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> return tryFed((NotFound)e, ctx, inputName); >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotFound >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:64: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> } else if (e instanceof CannotProceed) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class CannotProceed >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContext nc = ((CannotProceed) e).cxt; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NamingContext >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:67: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NamingContext nc = ((CannotProceed) e).cxt; >>>>> >>>>> ^ >>>>> >>>>> symbol: class CannotProceed >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:68: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] rest = ((CannotProceed) e).rest_of_name; >>>>> >>>>> ^ >>>>> >>>>> symbol: class CannotProceed >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:74: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] resolvedName = >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:75: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> new NameComponent[inputName.length - >>>>> rest.length]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:89: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> } else if (e instanceof InvalidName) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class InvalidName >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:91: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> } else if (e instanceof AlreadyBound) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class AlreadyBound >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:93: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> } else if (e instanceof NotEmpty) { >>>>> >>>>> ^ >>>>> >>>>> symbol: class NotEmpty >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:105: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] rest = e.rest_of_name; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:118: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent lastIn = inputName[inputName.length-1]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:135: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] resolvedName = null; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:139: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> if (e.why == NotFoundReason.not_context) { >>>>> >>>>> ^ >>>>> >>>>> symbol: variable NotFoundReason >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] tmp = new >>>>> NameComponent[rest.length-1]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:149: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> NameComponent[] tmp = new >>>>> NameComponent[rest.length-1]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\jndi\cosnaming\ExceptionMapper.java:158: >>>>> >>>>> error: cannot find symbol >>>>> >>>>> resolvedName = new NameComponent[len]; >>>>> >>>>> ^ >>>>> >>>>> symbol: class NameComponent >>>>> >>>>> location: class ExceptionMapper >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509IssuerSerial.java:38: >>>>> >>>>> warning: [overrides] Class XMLX509IssuerSerial overrides equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public class XMLX509IssuerSerial extends SignatureElementProxy >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SKI.java:43: >>>>> >>>>> warning: [overrides] Class XMLX509SKI overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public class XMLX509SKI extends SignatureElementProxy >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509SubjectName.java:36: >>>>> >>>>> warning: [overrides] Class XMLX509SubjectName overrides equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public class XMLX509SubjectName extends SignatureElementProxy >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\com\sun\org\apache\xml\internal\security\keys\content\x509\XMLX509Certificate.java:39: >>>>> >>>>> warning: [overrides] Class XMLX509Certificate overrides equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public class XMLX509Certificate extends SignatureElementProxy >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMTransform.java:51: >>>>> >>>>> warning: [overrides] Class DOMTransform overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public class DOMTransform extends DOMStructure implements Transform { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMCanonicalizationMethod.java:43: >>>>> >>>>> warning: [overrides] Class DOMCanonicalizationMethod overrides >>>>> equals, >>>>> but neither it nor any superclass overrides hashCode method >>>>> >>>>> public class DOMCanonicalizationMethod extends DOMTransform >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignedInfo.java:57: >>>>> >>>>> warning: [overrides] Class DOMSignedInfo overrides equals, but >>>>> neither >>>>> it nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMSignedInfo extends DOMStructure implements >>>>> SignedInfo { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyInfo.java:48: >>>>> >>>>> warning: [overrides] Class DOMKeyInfo overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMKeyInfo extends DOMStructure implements >>>>> KeyInfo { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyName.java:43: >>>>> >>>>> warning: [overrides] Class DOMKeyName overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMKeyName extends DOMStructure implements >>>>> KeyName { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMKeyValue.java:54: >>>>> >>>>> warning: [overrides] Class DOMKeyValue overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMKeyValue extends DOMStructure implements >>>>> KeyValue { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMManifest.java:45: >>>>> >>>>> warning: [overrides] Class DOMManifest overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMManifest extends DOMStructure implements >>>>> Manifest { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMReference.java:66: >>>>> >>>>> warning: [overrides] Class DOMReference overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMReference extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMRetrievalMethod.java:61: >>>>> >>>>> warning: [overrides] Class DOMRetrievalMethod overrides equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMRetrievalMethod extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperties.java:45: >>>>> >>>>> warning: [overrides] Class DOMSignatureProperties overrides >>>>> equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMSignatureProperties extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMSignatureProperty.java:45: >>>>> >>>>> warning: [overrides] Class DOMSignatureProperty overrides equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMSignatureProperty extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509Data.java:52: >>>>> >>>>> warning: [overrides] Class DOMX509Data overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMX509Data extends DOMStructure implements >>>>> X509Data { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMX509IssuerSerial.java:45: >>>>> >>>>> warning: [overrides] Class DOMX509IssuerSerial overrides equals, but >>>>> neither it nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMX509IssuerSerial extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLObject.java:46: >>>>> >>>>> warning: [overrides] Class DOMXMLObject overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMXMLObject extends DOMStructure implements >>>>> XMLObject { >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:474: >>>>> >>>>> warning: [overrides] Class DOMXMLSignature.DOMSignatureValue >>>>> overrides >>>>> equals, but neither it nor any superclass overrides hashCode method >>>>> >>>>> public class DOMSignatureValue extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\org\jcp\xml\dsig\internal\dom\DOMXMLSignature.java:67: >>>>> >>>>> warning: [overrides] Class DOMXMLSignature overrides equals, but >>>>> neither >>>>> it nor any superclass overrides hashCode method >>>>> >>>>> public final class DOMXMLSignature extends DOMStructure >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\DualStackPlainSocketImpl.java:224: >>>>> >>>>> warning: auxiliary class InetAddressContainer in >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>>> >>>>> should not be accessed from outside its own source file >>>>> >>>>> localAddress(nativefd, >>>>> (InetAddressContainer)iaContainerObj); >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >>>>> >>>>> warning: auxiliary class InetAddressContainer in >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>>> >>>>> should not be accessed from outside its own source file >>>>> >>>>> InetAddressContainer in = new InetAddressContainer(); >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\windows\classes\java\net\TwoStacksPlainSocketImpl.java:125: >>>>> >>>>> warning: auxiliary class InetAddressContainer in >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\share\classes\java\net\AbstractPlainSocketImpl.java >>>>> >>>>> should not be accessed from outside its own source file >>>>> >>>>> InetAddressContainer in = new InetAddressContainer(); >>>>> >>>>> ^ >>>>> >>>>> c:\Users\Pete\JDK8\jdk8\jdk\src\closed\windows\classes\com\sun\java\accessibility\util\Translator.java:43: >>>>> >>>>> warning: [overrides] Class Translator overrides equals, but >>>>> neither it >>>>> nor any superclass overrides hashCode method >>>>> >>>>> public class Translator extends AccessibleContext >>>>> >>>>> ^ >>>>> >>>>> Note: Some input files use or override a deprecated API. >>>>> >>>>> Note: Recompile with -Xlint:deprecation for details. >>>>> >>>>> Note: Some input files use unchecked or unsafe operations. >>>>> >>>>> Note: Recompile with -Xlint:unchecked for details. >>>>> >>>>> 80 errors >>>>> >>>>> 25 warnings >>>>> >>>>> make[2]: *** >>>>> [/cygdrive/c/Users/Pete/JDK8/jdk8/build/windows-x86-normal-server-fastdebug/jdk/classes/_the.batch] >>>>> >>>>> Error 1 >>>>> make[1]: *** [classes-only] Error 2 >>>>> make: *** [jdk-only] Error 2 > From philip.race at oracle.com Mon Jul 29 17:36:02 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 29 Jul 2013 10:36:02 -0700 Subject: jdk8 first build attempt - failed In-Reply-To: <51F6A58D.2070700@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> <51F6A4BD.3040709@oracle.com> <51F6A58D.2070700@oracle.com> Message-ID: <51F6A802.10304@oracle.com> On 7/29/2013 10:25 AM, Pete Brunet wrote: > Thanks Phil, I found > build\windows-x86-normal-server-fastdebug\corba\gensrc and in that dir > is one file _the_idls.d with one line > IDLS_ARE_CREATED=yes > > Pete > Hmm .. in my case that is there but there are also com & org directories with in all about 3Mb of generated sources. So the first failure is really somewhere before where you are seeing it reported. If you aren't already, build with LOG=debug -phil. From peter.brunet at oracle.com Tue Jul 30 00:13:34 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 19:13:34 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F6A802.10304@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> <51F6A4BD.3040709@oracle.com> <51F6A58D.2070700@oracle.com> <51F6A802.10304@oracle.com> Message-ID: <51F7052E.9040502@oracle.com> Thanks Phil, No luck looking through the log so far but will keep looking. BTW, I grep'd for BindingListHolder in all the IDL files under jdk8 with no matches. Pete On 7/29/13 12:36 PM, Phil Race wrote: > On 7/29/2013 10:25 AM, Pete Brunet wrote: >> Thanks Phil, I found >> build\windows-x86-normal-server-fastdebug\corba\gensrc and in that dir >> is one file _the_idls.d with one line >> IDLS_ARE_CREATED=yes >> >> Pete >> > > Hmm .. in my case that is there but there are also com & org > directories with > in all about 3Mb of generated sources. So the first failure is really > somewhere > before where you are seeing it reported. > > If you aren't already, build with LOG=debug > > -phil. From peter.brunet at oracle.com Tue Jul 30 02:31:26 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 21:31:26 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F7052E.9040502@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> <51F6A4BD.3040709@oracle.com> <51F6A58D.2070700@oracle.com> <51F6A802.10304@oracle.com> <51F7052E.9040502@oracle.com> Message-ID: <51F7257E.4050503@oracle.com> Looking through the corba section of the make debug log I don't see any errors other than two occurrences of this line: find: ???/cy/cygdrive/c/Users/Pete/JDK8/jdk8/corba/src/share/classes???: No such file or directory Is that indicative of anything wrong? The prefix and suffix sure look strange and that directory nzmd (minus the garbage) does exist. Pete On 7/29/13 7:13 PM, Pete Brunet wrote: > Thanks Phil, > > No luck looking through the log so far but will keep looking. > > BTW, I grep'd for BindingListHolder in all the IDL files under jdk8 with > no matches. > > Pete > > On 7/29/13 12:36 PM, Phil Race wrote: >> On 7/29/2013 10:25 AM, Pete Brunet wrote: >>> Thanks Phil, I found >>> build\windows-x86-normal-server-fastdebug\corba\gensrc and in that dir >>> is one file _the_idls.d with one line >>> IDLS_ARE_CREATED=yes >>> >>> Pete >>> >> Hmm .. in my case that is there but there are also com & org >> directories with >> in all about 3Mb of generated sources. So the first failure is really >> somewhere >> before where you are seeing it reported. >> >> If you aren't already, build with LOG=debug >> >> -phil. From david.holmes at oracle.com Tue Jul 30 02:53:10 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 30 Jul 2013 12:53:10 +1000 Subject: jdk8 first build attempt - failed In-Reply-To: <51F7257E.4050503@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> <51F6A4BD.3040709@oracle.com> <51F6A58D.2070700@oracle.com> <51F6A802.10304@oracle.com> <51F7052E.9040502@oracle.com> <51F7257E.4050503@oracle.com> Message-ID: <51F72A96.4090204@oracle.com> Hi Peter, On 30/07/2013 12:31 PM, Pete Brunet wrote: > Looking through the corba section of the make debug log I don't see any > errors other than two occurrences of this line: > > find: ???/cy/cygdrive/c/Users/Pete/JDK8/jdk8/corba/src/share/classes???: > No such file or directory > > Is that indicative of anything wrong? The prefix and suffix sure look > strange and that directory nzmd (minus the garbage) does exist. Yes this is a recently discovered bug affecting some systems. See 8021430. Workaround (from the bug): "A little deeper investigation revealed that a call to macro at corba/makefiles/BuildCorba.gmk:147 goes to macro "SetupIdlCompilation" defined in common/makefiles/IdlCompilation.gmk . The abspath function was mangling the path. Commenting out line 87 and 88 (to remove abspath's effect on the paths) enabled the build to succeed . " I just raised the priority of that bug. Not clear what the critical environmental factors are. David ----- > Pete > > On 7/29/13 7:13 PM, Pete Brunet wrote: >> Thanks Phil, >> >> No luck looking through the log so far but will keep looking. >> >> BTW, I grep'd for BindingListHolder in all the IDL files under jdk8 with >> no matches. >> >> Pete >> >> On 7/29/13 12:36 PM, Phil Race wrote: >>> On 7/29/2013 10:25 AM, Pete Brunet wrote: >>>> Thanks Phil, I found >>>> build\windows-x86-normal-server-fastdebug\corba\gensrc and in that dir >>>> is one file _the_idls.d with one line >>>> IDLS_ARE_CREATED=yes >>>> >>>> Pete >>>> >>> Hmm .. in my case that is there but there are also com & org >>> directories with >>> in all about 3Mb of generated sources. So the first failure is really >>> somewhere >>> before where you are seeing it reported. >>> >>> If you aren't already, build with LOG=debug >>> >>> -phil. > From mfbutner at ucdavis.edu Tue Jul 30 03:12:12 2013 From: mfbutner at ucdavis.edu (Matthew Butner) Date: Mon, 29 Jul 2013 20:12:12 -0700 Subject: Trouble with Testing Message-ID: So I have been able to successfully build the Java 1.8 but the testing fails due to errors on the Lines.jtr test under jdk/test/java/io/BufferedReader. I haven't modified any of the source code since I pulled it. Since I haven't changed anything I would assume my problem is coming from my build, jtreg, or testng. Any help would be greatly appreciated. The following is the error report generated by jtreg. Matthew #Test Results (version 2) #Mon Jul 29 06:51:29 PDT 2013 #checksum:30474354d53d86ec #-----testdescription----- $file=/home/username/dl/Java8/jdk/test/java/io/BufferedReader/Lines.java $root=/home/username/dl/Java8/jdk/test keywords=bug8003258 run=USER_SPECIFIED testng Lines\n source=Lines.java title=\ #-----environment----- #-----testresult----- description=file\:/home/username/dl/Java8/jdk/test/java/io/BufferedReader/Lines.java elapsed=462 0\:00\:00.462 end=Mon Jul 29 06\:51\:29 PDT 2013 environment=regtest execStatus=Failed. Execution failed\: `main' threw exception\: java.lang.Exception\: failures\: 4 hostname=ubuntu.ubuntu-domain javatestOS=Linux 3.2.0-49-generic (amd64) javatestVersion=4.4 jtregVersion=jtreg 4.1 fcs b05 script=com.sun.javatest.regtest.RegressionScript sections=script_messages build testng start=Mon Jul 29 06\:51\:28 PDT 2013 test=java/io/BufferedReader/Lines.javauser.name=username work=/home/username/dl/Java8/jdk/build/linux-amd64/testoutput/jdk_io/JTwork/java/io/BufferedReader #section:script_messages ----------messages:(5/288)---------- JDK under test: (/home/username/dl/Java8/test/../build/linux-x86_64-normal-server-release/images/j2sdk-image) openjdk version "1.8.0-internal" OpenJDK Runtime Environment (build 1.8.0-internal-matthebutner_2013_07_15_19_01-b00) OpenJDK 64-Bit Server VM (build 25.0-b42, mixed mode) #section:build ----------messages:(3/88)---------- command: build Lines reason: Named class compiled on demand elapsed time (seconds): 0.0 result: Passed. All files up to date #section:testng ----------messages:(3/101)---------- command: testng Lines reason: User specified action: run testng Lines elapsed time (seconds): 0.458 ----------System.out:(147/9673)---------- [TestNG] Running: java/io/BufferedReader/Lines.java test public void Lines.testInterlacedRead() throws java.io.IOException: failure java.lang.IncompatibleClassChangeError at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:383) at Lines.testInterlacedRead(Lines.java:268) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at org.testng.SuiteRunner.run(SuiteRunner.java:240) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) at org.testng.TestNG.run(TestNG.java:1030) at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) at java.lang.Thread.run(Thread.java:724) Caused by: java.lang.NoSuchMethodException: no such method: java.lang.invoke.LambdaMetafactory.metaFactory(Lookup,String,MethodType,MethodHandle,MethodHandle,MethodType)CallSite/invokeStatic at java.lang.invoke.MemberName.makeAccessException(MemberName.java:765) at java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:882) at java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:1019) at java.lang.invoke.MethodHandles$Lookup.linkMethodHandleConstant(MethodHandles.java:1284) at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:381) ... 29 more Caused by: java.lang.NoSuchMethodError: java.lang.invoke.LambdaMetafactory.metaFactory(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/CallSite; at java.lang.invoke.MethodHandleNatives.resolve(Native Method) at java.lang.invoke.MemberName$Factory.resolve(MemberName.java:854) at java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:879) ... 32 more test public void Lines.testIterator() throws java.io.IOException: success test public void Lines.testLinesBasic(): failure java.lang.IncompatibleClassChangeError: at Lines.testLinesBasic(Lines.java:170) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at org.testng.SuiteRunner.run(SuiteRunner.java:240) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) at org.testng.TestNG.run(TestNG.java:1030) at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) at java.lang.Thread.run(Thread.java:724) test public void Lines.testPartialReadAndLineNo() throws java.io.IOException: failure java.lang.IncompatibleClassChangeError: at Lines.testPartialReadAndLineNo(Lines.java:241) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at org.testng.SuiteRunner.run(SuiteRunner.java:240) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) at org.testng.TestNG.run(TestNG.java:1030) at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) at java.lang.Thread.run(Thread.java:724) test public void Lines.testUncheckedIOException() throws java.io.IOException: failure java.lang.IncompatibleClassChangeError: at Lines.testUncheckedIOException(Lines.java:189) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at org.testng.TestRunner.privateRun(TestRunner.java:767) at org.testng.TestRunner.run(TestRunner.java:617) at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at org.testng.SuiteRunner.run(SuiteRunner.java:240) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) at org.testng.TestNG.run(TestNG.java:1030) at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) at java.lang.Thread.run(Thread.java:724) =============================================== java/io/BufferedReader/Lines.java Total tests run: 5, Failures: 4, Skips: 0 =============================================== ----------System.err:(12/626)---------- java.lang.Exception: failures: 4 at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:154) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:491) at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) at java.lang.Thread.run(Thread.java:724) JavaTest Message: Test threw exception: java.lang.Exception JavaTest Message: shutting down test result: Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 4 test result: Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 4 From david.holmes at oracle.com Tue Jul 30 03:59:55 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 30 Jul 2013 13:59:55 +1000 Subject: Trouble with Testing In-Reply-To: References: Message-ID: <51F73A3B.4050606@oracle.com> Hi Matthew, This is a change in the javac output related to lambda expressions that was recently pushed (and which ties in to a hotspot change IIRC). The tests need to be recompiled with latest JDK8 (or at least they need to be recompiled with a version comparable to the one you are testing). David On 30/07/2013 1:12 PM, Matthew Butner wrote: > So I have been able to successfully build the Java 1.8 but the testing > fails due to errors on the Lines.jtr test under > jdk/test/java/io/BufferedReader. I haven't modified any of the source code > since I pulled it. Since I haven't changed anything I would assume my > problem is coming from my build, jtreg, or testng. Any help would be > greatly appreciated. The following is the error report generated by jtreg. > Matthew > > #Test Results (version 2) > #Mon Jul 29 06:51:29 PDT 2013 > #checksum:30474354d53d86ec > #-----testdescription----- > $file=/home/username/dl/Java8/jdk/test/java/io/BufferedReader/Lines.java > $root=/home/username/dl/Java8/jdk/test > keywords=bug8003258 > run=USER_SPECIFIED testng Lines\n > source=Lines.java > title=\ > > #-----environment----- > > #-----testresult----- > description=file\:/home/username/dl/Java8/jdk/test/java/io/BufferedReader/Lines.java > elapsed=462 0\:00\:00.462 > end=Mon Jul 29 06\:51\:29 PDT 2013 > environment=regtest > execStatus=Failed. Execution failed\: `main' threw exception\: > java.lang.Exception\: failures\: 4 > hostname=ubuntu.ubuntu-domain > javatestOS=Linux 3.2.0-49-generic (amd64) > javatestVersion=4.4 > jtregVersion=jtreg 4.1 fcs b05 > script=com.sun.javatest.regtest.RegressionScript > sections=script_messages build testng > start=Mon Jul 29 06\:51\:28 PDT 2013 > test=java/io/BufferedReader/Lines.javauser.name=username > work=/home/username/dl/Java8/jdk/build/linux-amd64/testoutput/jdk_io/JTwork/java/io/BufferedReader > > #section:script_messages > ----------messages:(5/288)---------- > JDK under test: > (/home/username/dl/Java8/test/../build/linux-x86_64-normal-server-release/images/j2sdk-image) > openjdk version "1.8.0-internal" > OpenJDK Runtime Environment (build > 1.8.0-internal-matthebutner_2013_07_15_19_01-b00) > OpenJDK 64-Bit Server VM (build 25.0-b42, mixed mode) > > > #section:build > ----------messages:(3/88)---------- > command: build Lines > reason: Named class compiled on demand > elapsed time (seconds): 0.0 > result: Passed. All files up to date > > #section:testng > ----------messages:(3/101)---------- > command: testng Lines > reason: User specified action: run testng Lines > elapsed time (seconds): 0.458 > ----------System.out:(147/9673)---------- > [TestNG] Running: > java/io/BufferedReader/Lines.java > > test public void Lines.testInterlacedRead() throws java.io.IOException: failure > java.lang.IncompatibleClassChangeError > at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:383) > at Lines.testInterlacedRead(Lines.java:268) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) > at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) > at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) > at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) > at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at org.testng.TestRunner.privateRun(TestRunner.java:767) > at org.testng.TestRunner.run(TestRunner.java:617) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) > at org.testng.SuiteRunner.run(SuiteRunner.java:240) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) > at org.testng.TestNG.run(TestNG.java:1030) > at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) > at java.lang.Thread.run(Thread.java:724) > Caused by: java.lang.NoSuchMethodException: no such method: > java.lang.invoke.LambdaMetafactory.metaFactory(Lookup,String,MethodType,MethodHandle,MethodHandle,MethodType)CallSite/invokeStatic > at java.lang.invoke.MemberName.makeAccessException(MemberName.java:765) > at java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:882) > at java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:1019) > at java.lang.invoke.MethodHandles$Lookup.linkMethodHandleConstant(MethodHandles.java:1284) > at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:381) > ... 29 more > Caused by: java.lang.NoSuchMethodError: > java.lang.invoke.LambdaMetafactory.metaFactory(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/CallSite; > at java.lang.invoke.MethodHandleNatives.resolve(Native Method) > at java.lang.invoke.MemberName$Factory.resolve(MemberName.java:854) > at java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:879) > ... 32 more > test public void Lines.testIterator() throws java.io.IOException: success > test public void Lines.testLinesBasic(): failure > java.lang.IncompatibleClassChangeError: > at Lines.testLinesBasic(Lines.java:170) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) > at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) > at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) > at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) > at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at org.testng.TestRunner.privateRun(TestRunner.java:767) > at org.testng.TestRunner.run(TestRunner.java:617) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) > at org.testng.SuiteRunner.run(SuiteRunner.java:240) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) > at org.testng.TestNG.run(TestNG.java:1030) > at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) > at java.lang.Thread.run(Thread.java:724) > test public void Lines.testPartialReadAndLineNo() throws > java.io.IOException: failure > java.lang.IncompatibleClassChangeError: > at Lines.testPartialReadAndLineNo(Lines.java:241) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) > at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) > at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) > at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) > at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at org.testng.TestRunner.privateRun(TestRunner.java:767) > at org.testng.TestRunner.run(TestRunner.java:617) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) > at org.testng.SuiteRunner.run(SuiteRunner.java:240) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) > at org.testng.TestNG.run(TestNG.java:1030) > at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) > at java.lang.Thread.run(Thread.java:724) > test public void Lines.testUncheckedIOException() throws > java.io.IOException: failure > java.lang.IncompatibleClassChangeError: > at Lines.testUncheckedIOException(Lines.java:189) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80) > at org.testng.internal.Invoker.invokeMethod(Invoker.java:715) > at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:907) > at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1237) > at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at org.testng.TestRunner.privateRun(TestRunner.java:767) > at org.testng.TestRunner.run(TestRunner.java:617) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:334) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) > at org.testng.SuiteRunner.run(SuiteRunner.java:240) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:51) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:85) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1197) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1122) > at org.testng.TestNG.run(TestNG.java:1030) > at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:151) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) > at java.lang.Thread.run(Thread.java:724) > > =============================================== > java/io/BufferedReader/Lines.java > Total tests run: 5, Failures: 4, Skips: 0 > =============================================== > > ----------System.err:(12/626)---------- > java.lang.Exception: failures: 4 > at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:154) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:491) > at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:706) > at java.lang.Thread.run(Thread.java:724) > > JavaTest Message: Test threw exception: java.lang.Exception > JavaTest Message: shutting down test > > result: Failed. Execution failed: `main' threw exception: > java.lang.Exception: failures: 4 > > > test result: Failed. Execution failed: `main' threw exception: > java.lang.Exception: failures: 4 > From peter.brunet at oracle.com Tue Jul 30 04:24:48 2013 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 29 Jul 2013 23:24:48 -0500 Subject: jdk8 first build attempt - failed In-Reply-To: <51F72A96.4090204@oracle.com> References: <51F34919.8010900@oracle.com> <51F40099.5060408@oracle.com> <51F66DAB.9070103@oracle.com> <51F683C5.5090108@oracle.com> <51F6A4BD.3040709@oracle.com> <51F6A58D.2070700@oracle.com> <51F6A802.10304@oracle.com> <51F7052E.9040502@oracle.com> <51F7257E.4050503@oracle.com> <51F72A96.4090204@oracle.com> Message-ID: <51F74010.5090407@oracle.com> On 7/29/13 9:53 PM, David Holmes wrote: > Hi Peter, > > On 30/07/2013 12:31 PM, Pete Brunet wrote: >> Looking through the corba section of the make debug log I don't see any >> errors other than two occurrences of this line: >> >> find: ???/cy/cygdrive/c/Users/Pete/JDK8/jdk8/corba/src/share/classes???: >> No such file or directory >> >> Is that indicative of anything wrong? The prefix and suffix sure look >> strange and that directory nzmd (minus the garbage) does exist. > > Yes this is a recently discovered bug affecting some systems. See > 8021430. Workaround (from the bug): > > "A little deeper investigation revealed that a call to macro at > corba/makefiles/BuildCorba.gmk:147 goes to macro "SetupIdlCompilation" > defined in common/makefiles/IdlCompilation.gmk . The abspath function > was mangling the path. Commenting out line 87 and 88 (to remove > abspath's effect on the paths) enabled the build to succeed . " > > I just raised the priority of that bug. Not clear what the critical > environmental factors are. Thank you David, That was it!!! Thanks very much for your help. I can go to bed a much happier man :-) Good to raise the priority. I lost Friday, half a day Saturday, and a long Monday. My environment is: 64 bit W7, cygwin, dual core Lenovo T500. I'll be happy to provide any other info on my build if need be. Pete > > David > ----- > > >> Pete >> >> On 7/29/13 7:13 PM, Pete Brunet wrote: >>> Thanks Phil, >>> >>> No luck looking through the log so far but will keep looking. >>> >>> BTW, I grep'd for BindingListHolder in all the IDL files under jdk8 >>> with >>> no matches. >>> >>> Pete >>> >>> On 7/29/13 12:36 PM, Phil Race wrote: >>>> On 7/29/2013 10:25 AM, Pete Brunet wrote: >>>>> Thanks Phil, I found >>>>> build\windows-x86-normal-server-fastdebug\corba\gensrc and in that >>>>> dir >>>>> is one file _the_idls.d with one line >>>>> IDLS_ARE_CREATED=yes >>>>> >>>>> Pete >>>>> >>>> Hmm .. in my case that is there but there are also com & org >>>> directories with >>>> in all about 3Mb of generated sources. So the first failure is really >>>> somewhere >>>> before where you are seeing it reported. >>>> >>>> If you aren't already, build with LOG=debug >>>> >>>> -phil. >> From mkorszun at gmail.com Wed Jul 31 08:46:50 2013 From: mkorszun at gmail.com (matchew) Date: Wed, 31 Jul 2013 10:46:50 +0200 Subject: Build jdk8-b100 with custom cacerts file and java compiler Message-ID: Hey All, I try to build above version. Since i want to provide custom cacert file as well as java compiler I set this env variables (that is how it worked for 6 & 7): export ALT_BOOTDIR=[JAVA_COMPILER_DIR] export ALT_CACERTS_FILE=[CUSTOM_CACERTS_FILE] Configure script passes and proper java compiler is taken (i have specified java7 / default on my box is java6), but got this warning anyway: WARNING: You have old-style ALT_ environment variables set. These are not respected, and will be ignored. It is recommended that you clean your environment. The following variables are set: ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 ALT_CACERTS_FILE=/etc/ssl/certs/java/cacerts WARNING: You have the following ALT_ variables set: ALT_CACERTS_FILE=/etc/ssl/certs/java/cacerts ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 ALT_ variables are deprecated and will be ignored. Please clean your environment. If these variables are deprecated and ignored how is it possible that java-7 was used for the compilation instead of default one? Anyway to build process continues and will check if cacert file was included. If not, what is the alternative way to provide it? Best Regards -- Mateusz From david.holmes at oracle.com Wed Jul 31 09:28:28 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 31 Jul 2013 19:28:28 +1000 Subject: Build jdk8-b100 with custom cacerts file and java compiler In-Reply-To: References: Message-ID: <51F8D8BC.5030802@oracle.com> On 31/07/2013 6:46 PM, matchew wrote: > Hey All, > > I try to build above version. Since i want to provide custom cacert file as > well as java compiler I set this env variables (that is how it worked for 6 > & 7): > > export ALT_BOOTDIR=[JAVA_COMPILER_DIR] > export ALT_CACERTS_FILE=[CUSTOM_CACERTS_FILE] > > Configure script passes and proper java compiler is taken (i have specified > java7 / default on my box is java6), but got this warning anyway: > > WARNING: You have old-style ALT_ environment variables set. > These are not respected, and will be ignored. It is recommended > that you clean your environment. The following variables are set: > ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 > ALT_CACERTS_FILE=/etc/ssl/certs/java/cacerts sh configure --help shows: --with-cacerts-file specify alternative cacerts file --with-boot-jdk path to Boot JDK (used to bootstrap build) [probed] Cheers, David ------ > > WARNING: You have the following ALT_ variables set: > ALT_CACERTS_FILE=/etc/ssl/certs/java/cacerts > ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 > ALT_ variables are deprecated and will be ignored. Please clean your > environment. > > If these variables are deprecated and ignored how is it possible that > java-7 was used for the compilation instead of default one? Anyway to build > process continues and will check if cacert file was included. If not, what > is the alternative way to provide it? > > Best Regards > -- > Mateusz > From aleksej.efimov at oracle.com Wed Jul 31 12:18:05 2013 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Wed, 31 Jul 2013 16:18:05 +0400 Subject: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx] Message-ID: <51F9007D.8090801@oracle.com> Hi, Can I have a review for the following problem: The MACOSX JDK (more precisely - the java.net classes) uses the select() system call to wait for different events on sockets fds. And the default behaviour for select() on Darwin is to fail when fdset contains the fd with id greater than FDSET_SIZE(=1024). Test case in webrev illustrates this behavior. There is at least one solution for it: use -D_DARWIN_UNLIMITED_SELECT compilation flag for all macosx sources: this won't affect other parts of JDK because they are not using select(). Currently, I have added this compilation flag to common/autoconf/generated-configure.sh and common/autoconf/generated-configure.sh. I wonder, if there is a better place where I can put this flag? The webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.00/ BUG: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021820 Thanks, -Aleksej From Alan.Bateman at oracle.com Wed Jul 31 13:45:47 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 Jul 2013 06:45:47 -0700 Subject: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx] In-Reply-To: <51F9007D.8090801@oracle.com> References: <51F9007D.8090801@oracle.com> Message-ID: <51F9150B.4000008@oracle.com> On 31/07/2013 05:18, Aleksej Efimov wrote: > Hi, > Can I have a review for the following problem: > The MACOSX JDK (more precisely - the java.net classes) uses the > select() system call to wait for different events on sockets fds. And > the default behaviour for select() on Darwin is to fail when fdset > contains the fd with id greater than FDSET_SIZE(=1024). Test case in > webrev illustrates this behavior. > There is at least one solution for it: use -D_DARWIN_UNLIMITED_SELECT > compilation flag for all macosx sources: this won't affect other parts > of JDK because they are not using select(). > Currently, I have added this compilation flag to > common/autoconf/generated-configure.sh and > common/autoconf/generated-configure.sh. I wonder, if there is a better > place where I can put this flag? > > The webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.00/ > BUG: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021820 Thanks for looking into this one. The build changes look okay to me but it's probably best that someone on build-dev agree to those. Michael McMahon can probably explain why the net code is using select for timed read/accept (I have a vague recollection of there being an issue with poll due to the way that it is implemented on kqueue with the result that it had to be changed to use select). I think the test needs re-work. It looks to me that the it attempts to connect to an Oracle internal site so that's not going to work everywhere. In general we don't want the tests to be dependent on hosts that may or may not exist (we had tests that used to this in the past but they caused a lot of grief). It also looks like the test doesn't close the 1023 files that it opens at the start and so I assume this test will always fail on Windows when jtreg tries to clean-up. -Alan. From chris.hegarty at oracle.com Wed Jul 31 14:25:35 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 31 Jul 2013 15:25:35 +0100 Subject: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx] In-Reply-To: <51F9150B.4000008@oracle.com> References: <51F9007D.8090801@oracle.com> <51F9150B.4000008@oracle.com> Message-ID: <51F91E5F.2080805@oracle.com> On 31/07/2013 14:45, Alan Bateman wrote: > On 31/07/2013 05:18, Aleksej Efimov wrote: >> Hi, >> Can I have a review for the following problem: >> The MACOSX JDK (more precisely - the java.net classes) uses the >> select() system call to wait for different events on sockets fds. And >> the default behaviour for select() on Darwin is to fail when fdset >> contains the fd with id greater than FDSET_SIZE(=1024). Test case in >> webrev illustrates this behavior. >> There is at least one solution for it: use -D_DARWIN_UNLIMITED_SELECT >> compilation flag for all macosx sources: this won't affect other parts >> of JDK because they are not using select(). >> Currently, I have added this compilation flag to >> common/autoconf/generated-configure.sh and >> common/autoconf/generated-configure.sh. I wonder, if there is a better >> place where I can put this flag? >> >> The webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.00/ >> BUG: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021820 > > Thanks for looking into this one. The build changes look okay to me but Agreed. > it's probably best that someone on build-dev agree to those. Michael > McMahon can probably explain why the net code is using select for timed > read/accept (I have a vague recollection of there being an issue with > poll due to the way that it is implemented on kqueue with the result > that it had to be changed to use select). I don't remember the the specifics either, but that sounds familiar. -Chris. > I think the test needs re-work. It looks to me that the it attempts to > connect to an Oracle internal site so that's not going to work > everywhere. In general we don't want the tests to be dependent on hosts > that may or may not exist (we had tests that used to this in the past > but they caused a lot of grief). It also looks like the test doesn't > close the 1023 files that it opens at the start and so I assume this > test will always fail on Windows when jtreg tries to clean-up. > > -Alan. From tim.bell at oracle.com Wed Jul 31 14:35:19 2013 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 31 Jul 2013 07:35:19 -0700 Subject: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx] In-Reply-To: <51F9150B.4000008@oracle.com> References: <51F9007D.8090801@oracle.com> <51F9150B.4000008@oracle.com> Message-ID: <51F920A7.3000600@oracle.com> Aleksej, Alan The change in common/autoconf/toolchain.m4 looks correct to me, and I think that is a good place to have it. Remember to run 'bash common/autoconf/autogen.sh' and check in the generated-configure.sh files as part of the changeset. I didn't look at the test case, but I think Alan has some good points. Tim On 07/31/13 06:45 AM, Alan Bateman wrote: > On 31/07/2013 05:18, Aleksej Efimov wrote: >> Hi, >> Can I have a review for the following problem: >> The MACOSX JDK (more precisely - the java.net classes) uses the >> select() system call to wait for different events on sockets fds. And >> the default behaviour for select() on Darwin is to fail when fdset >> contains the fd with id greater than FDSET_SIZE(=1024). Test case in >> webrev illustrates this behavior. >> There is at least one solution for it: use -D_DARWIN_UNLIMITED_SELECT >> compilation flag for all macosx sources: this won't affect other >> parts of JDK because they are not using select(). >> Currently, I have added this compilation flag to >> common/autoconf/generated-configure.sh and >> common/autoconf/generated-configure.sh. I wonder, if there is a >> better place where I can put this flag? >> >> The webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.00/ >> BUG: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021820 > > Thanks for looking into this one. The build changes look okay to me > but it's probably best that someone on build-dev agree to those. > Michael McMahon can probably explain why the net code is using select > for timed read/accept (I have a vague recollection of there being an > issue with poll due to the way that it is implemented on kqueue with > the result that it had to be changed to use select). > > I think the test needs re-work. It looks to me that the it attempts to > connect to an Oracle internal site so that's not going to work > everywhere. In general we don't want the tests to be dependent on > hosts that may or may not exist (we had tests that used to this in the > past but they caused a lot of grief). It also looks like the test > doesn't close the 1023 files that it opens at the start and so I > assume this test will always fail on Windows when jtreg tries to > clean-up. > > -Alan. From sandeep.konchady at oracle.com Wed Jul 31 16:42:42 2013 From: sandeep.konchady at oracle.com (Sandeep Konchady) Date: Wed, 31 Jul 2013 09:42:42 -0700 Subject: Cannot build OpenJDK 8 on Mac 10.8.4 Message-ID: <478E9013-8D20-4E24-9A8B-A94758D7FC17@oracle.com> Hi, I am trying to build OpenJDK 8 as outlined in the README file in openjdk. I am running into the following issue and didn't find a reasonable solution. I am doing this on a MacBook Pro w/ 8 GB RAM, dual core CPU, 10.8.4 OS X, compatible Xcode and ccache installed. Any help would be much appreciated. =============== BUILD ISSUE ================ SandeepMac-2:jdk8 sandeepk$ make Building OpenJDK for target 'default' in configuration 'macosx-x86_64-normal-server-release' ## Starting langtools ## Finished langtools (build time 00:00:01) ## Starting hotspot make[2]: warning: -jN forced in submake: disabling jobserver mode. Rescanned ../generated/adfiles/bsd_x86_64.ad but encountered no changes. dtrace headers generated Compiling /Users/sandeepk/Workspace/JDK/jdk8/hotspot/src/os/bsd/vm/attachListener_bsd.cpp Compiling /Users/sandeepk/Workspace/JDK/jdk8/hotspot/src/share/vm/runtime/basicLock.cpp cc1plus: warnings being treated as errors /Users/sandeepk/Workspace/JDK/jdk8/hotspot/src/os/bsd/vm/attachListener_bsd.cpp: In static member function ?static void AttachListener::vm_start()?: /Users/sandeepk/Workspace/JDK/jdk8/hotspot/src/os/bsd/vm/attachListener_bsd.cpp:455: warning: ?stat64? is deprecated (declared at /usr/include/sys/stat.h:466) /Users/sandeepk/Workspace/JDK/jdk8/hotspot/src/os/bsd/vm/attachListener_bsd.cpp:455: warning: ?stat64? is deprecated (declared at /usr/include/sys/stat.h:466) make[8]: *** [attachListener_bsd.o] Error 1 make[8]: *** Waiting for unfinished jobs.... make[7]: *** [the_vm] Error 2 make[6]: *** [product] Error 2 make[5]: *** [generic_build2] Error 2 make[4]: *** [product] Error 2 make[3]: *** [all_product_universal] Error 2 make[2]: *** [universal_product] Error 2 make[1]: *** [/Users/sandeepk/Workspace/JDK/jdk8/build/macosx-x86_64-normal-server-release/hotspot/_hotspot.timestamp] Error 2 make: *** [hotspot-only] Error 2 SandeepMac-2:jdk8 sandeepk$ uname -a Darwin dhcp-santaclara22-2fl-west-10-132-182-75.usdhcp.oraclecorp.com 12.4.0 Darwin Kernel Version 12.4.0: Wed May 1 17:57:12 PDT 2013; root:xnu-2050.24.15~1/RELEASE_X86_64 x86_64 SandeepMac-2:jdk8 sandeepk$ make -v GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. This program built for i386-apple-darwin11.3.0 ====================================================================================== Thanks, Sandeep From tim.bell at oracle.com Wed Jul 31 17:12:33 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:12:33 +0000 Subject: hg: jdk8/build: Added tag jdk8-b100 for changeset d2dcb110e9db Message-ID: <20130731171234.3EFD2484BE@hg.openjdk.java.net> Changeset: 9f74a220677d Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/9f74a220677d Added tag jdk8-b100 for changeset d2dcb110e9db ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:12:40 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:12:40 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b100 for changeset 8d492f1dfd1b Message-ID: <20130731171241.941EA484BF@hg.openjdk.java.net> Changeset: a013024b0747 Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/a013024b0747 Added tag jdk8-b100 for changeset 8d492f1dfd1b ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:21:28 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:21:28 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b100 for changeset 5d1974c1d7b9 Message-ID: <20130731172132.096E3484C2@hg.openjdk.java.net> Changeset: 0a7432f898e5 Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0a7432f898e5 Added tag jdk8-b100 for changeset 5d1974c1d7b9 ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:22:03 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:22:03 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b100 for changeset 5be9c5bfcfe9 Message-ID: <20130731172230.D3635484C4@hg.openjdk.java.net> Changeset: 690161232823 Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/690161232823 Added tag jdk8-b100 for changeset 5be9c5bfcfe9 ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:21:41 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:21:41 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b100 for changeset 4fd722afae5c Message-ID: <20130731172145.32F1B484C3@hg.openjdk.java.net> Changeset: 60b623a36164 Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/60b623a36164 Added tag jdk8-b100 for changeset 4fd722afae5c ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:23:24 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:23:24 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b100 for changeset 82f68da70e47 Message-ID: <20130731172329.A087E484C5@hg.openjdk.java.net> Changeset: 0324dbf07b0f Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/0324dbf07b0f Added tag jdk8-b100 for changeset 82f68da70e47 ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:23:37 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:23:37 +0000 Subject: hg: jdk8/build/nashorn: Added tag jdk8-b100 for changeset 598321c438b5 Message-ID: <20130731172339.8F03E484C6@hg.openjdk.java.net> Changeset: a302b05d0ee4 Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/a302b05d0ee4 Added tag jdk8-b100 for changeset 598321c438b5 ! .hgtags From tim.bell at oracle.com Wed Jul 31 17:16:40 2013 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Wed, 31 Jul 2013 17:16:40 +0000 Subject: hg: jdk8/build/hotspot: 39 new changesets Message-ID: <20130731171802.BAB45484C0@hg.openjdk.java.net> Changeset: 9d7b55c8a0c4 Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9d7b55c8a0c4 Added tag jdk8-b100 for changeset 5787fac72e76 ! .hgtags Changeset: 2285b4a0a4e6 Author: amurillo Date: 2013-07-18 09:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2285b4a0a4e6 8020797: new hotspot build - hs25-b43 Reviewed-by: jcoomes ! make/hotspot_version Changeset: dbc0b5dc08f5 Author: fparain Date: 2013-07-10 15:49 +0000 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dbc0b5dc08f5 7143807: ResourceMark nesting problem in stringStream Reviewed-by: kvn, dcubed ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: c9a5fab39234 Author: zgu Date: 2013-07-11 13:15 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c9a5fab39234 8012241: NMT huge memory footprint, it usually leads to OOME Summary: Enforce memory limitation on NMT to prevent JVM OOM Reviewed-by: acorn, dcubed, minqi ! src/share/vm/services/memTracker.cpp Changeset: 5f056abe17c6 Author: zgu Date: 2013-07-12 04:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5f056abe17c6 Merge Changeset: 2e8f19c2feef Author: allwin Date: 2013-07-12 18:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2e8f19c2feef 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Summary: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff ! src/os/bsd/vm/attachListener_bsd.cpp ! src/os/linux/vm/attachListener_linux.cpp ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/windows/vm/attachListener_windows.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/attachListener.hpp + test/serviceability/attach/AttachWithStalePidFile.java + test/serviceability/attach/AttachWithStalePidFileTarget.java Changeset: c0cb474be37e Author: ctornqvi Date: 2013-07-12 20:47 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c0cb474be37e Merge Changeset: 862625d214fa Author: fparain Date: 2013-07-15 00:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/862625d214fa Merge Changeset: 23123fc6968a Author: rbackman Date: 2013-07-15 11:35 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/23123fc6968a 8019324: assert(_f2 == 0 || _f2 == f2) failed: illegal field change Reviewed-by: dholmes, rbackman Contributed-by: David Simms ! src/share/vm/oops/cpCache.hpp Changeset: ee9e76adced3 Author: rbackman Date: 2013-07-15 12:06 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ee9e76adced3 Merge Changeset: 33c52908bcdb Author: dholmes Date: 2013-07-15 23:23 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/33c52908bcdb 8015759: hotspot changes needed to compile with Visual Studio 2012 Reviewed-by: anthony, dholmes, dcubed Contributed-by: Tim Bell ! make/windows/makefiles/compile.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/vm.make ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp Changeset: 39deebbc90b3 Author: mgerdin Date: 2013-07-16 07:33 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/39deebbc90b3 6671508: JNI GetPrimitiveArrayCritical should not be callable on object arrays Summary: Checked JNI now reports error for Get/ReleasePrimitiveArrayCritical on object arrays Reviewed-by: dholmes, acorn Contributed-by: david.simms at oracle.com ! src/share/vm/prims/jniCheck.cpp Changeset: e619a2766bcc Author: rbackman Date: 2013-06-12 11:17 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e619a2766bcc 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()' Reviewed-by: jrose, kvn, mgronlun ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 732af649bc3a Author: ccheung Date: 2013-07-17 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/732af649bc3a 8017498: JVM crashes when native code calls sigaction(sig) where sig>=0x20 Summary: Added (sig < MAXSIGNUM) check in jsig.c Reviewed-by: dholmes, acorn ! src/os/linux/vm/jsig.c + test/runtime/jsig/Test8017498.sh + test/runtime/jsig/TestJNI.c + test/runtime/jsig/TestJNI.java Changeset: 825e6cb66923 Author: jiangli Date: 2013-07-17 18:06 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/825e6cb66923 8020309: Eliminate InstanceKlass::_cached_class_file_len. Summary: Use JvmtiCachedClassFileData. Reviewed-by: iklam, sspitsyn, dcubed ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: 6388dbc4b7ca Author: jiangli Date: 2013-07-17 17:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6388dbc4b7ca Merge Changeset: c29568b733d2 Author: dholmes Date: 2013-07-18 06:47 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c29568b733d2 8020697: jniCheck.cpp:check_is_obj_array asserts on TypeArrayKlass::cast(aOop->klass()) Reviewed-by: dcubed, fparain, dholmes Contributed-by: David Simms ! src/share/vm/prims/jniCheck.cpp Changeset: 5e3b6f79d280 Author: rbackman Date: 2013-07-17 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5e3b6f79d280 8020701: Avoid crashes in WatcherThread Reviewed-by: acorn, dcubed, dsimms ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 248c459b2b75 Author: dcubed Date: 2013-07-18 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/248c459b2b75 Merge ! src/share/vm/services/memTracker.cpp Changeset: af21010d1062 Author: dcubed Date: 2013-07-18 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/af21010d1062 Merge ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/runtime/os.hpp Changeset: 02d7aa1456c9 Author: ccheung Date: 2013-07-18 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/02d7aa1456c9 8004872: Early loading of HashMap and StringValue under -XX:+AggressiveOpts can be removed Summary: this fix also removes the -XX:+UseStringCache option Reviewed-by: dholmes, acorn, iklam ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: 383a5e21cc2d Author: minqi Date: 2013-07-18 18:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/383a5e21cc2d Merge Changeset: 060ae9b7ffea Author: mgronlun Date: 2013-07-19 17:56 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/060ae9b7ffea 8020547: Event based tracing needs a UNICODE string type Reviewed-by: egahlin, rbackman, dcubed, brutisso, acorn ! src/share/vm/trace/traceDataTypes.hpp ! src/share/vm/trace/tracetypes.xml ! src/share/vm/trace/xinclude.mod Changeset: 4614a598dae1 Author: minqi Date: 2013-07-19 08:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4614a598dae1 8016538: volatile double access via Unsafe.cpp is not atomic Summary: volatile jdouble load/store is not atomic, fix by using of existing volatile jlong operations which are atomic for jdouble. Reviewed-by: kvn, vladidan, jrose Contributed-by: david.holmes at oracle.com ! src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp Changeset: 55a61ceb2fe7 Author: minqi Date: 2013-07-19 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/55a61ceb2fe7 Merge Changeset: 16511b7e3d35 Author: emc Date: 2013-07-22 17:57 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/16511b7e3d35 8019632: Method parameters are not copied in clone_with_new_data Summary: Add code to copy method parameters data in clone_with_new_data Reviewed-by: coleenp, sspitsyn ! src/share/vm/oops/method.cpp Changeset: 72727c4b6dec Author: ccheung Date: 2013-07-19 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/72727c4b6dec 8020791: [TESTBUG] runtime/jsig/Test8017498.sh failed to compile native code Summary: Added -DLINUX to the gcc command and improved the .sh script Reviewed-by: dcubed, dholmes, minqi ! test/runtime/jsig/Test8017498.sh ! test/runtime/jsig/TestJNI.c Changeset: 5165d659cebd Author: minqi Date: 2013-07-22 22:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5165d659cebd Merge Changeset: c0f353803b47 Author: minqi Date: 2013-07-23 12:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c0f353803b47 Merge Changeset: c90c698831d7 Author: kvn Date: 2013-07-12 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c90c698831d7 8020215: Different execution plan when using JIT vs interpreter Summary: fix bytecode analyzer Reviewed-by: twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp + test/compiler/EscapeAnalysis/Test8020215.java Changeset: fcf521c3fbc6 Author: kvn Date: 2013-07-12 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fcf521c3fbc6 8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier() Summary: generate one "fat" membar instead of set of barriers for volitile store Reviewed-by: roland ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/parse3.cpp + test/compiler/membars/DekkerTest.java Changeset: 34ce0b5acb81 Author: morris Date: 2013-07-15 06:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/34ce0b5acb81 Merge Changeset: 0f57ccdb9084 Author: kvn Date: 2013-07-15 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0f57ccdb9084 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std Reviewed-by: jrose ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp + test/compiler/cpuflags/RestoreMXCSR.java Changeset: 46a90f83df31 Author: morris Date: 2013-07-19 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/46a90f83df31 Merge ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 6efedc114807 Author: morris Date: 2013-07-24 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6efedc114807 Merge Changeset: 01aa164323fa Author: dholmes Date: 2013-07-24 19:23 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/01aa164323fa 8020799: Allow customization of hotspot source directories and files Reviewed-by: kvn, dlong ! make/linux/makefiles/vm.make Changeset: a4b9a8ec8f4a Author: jiangli Date: 2013-07-25 18:12 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a4b9a8ec8f4a Merge Changeset: 46487ba40ff2 Author: amurillo Date: 2013-07-26 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/46487ba40ff2 Merge Changeset: f6921c876db1 Author: amurillo Date: 2013-07-26 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f6921c876db1 Added tag hs25-b43 for changeset 46487ba40ff2 ! .hgtags From ioi.lam at oracle.com Wed Jul 31 21:52:49 2013 From: ioi.lam at oracle.com (Ioi Lam) Date: Wed, 31 Jul 2013 14:52:49 -0700 Subject: Solaris/x86 build - dtrace syntax error near "umpiconninfo_t" Message-ID: <51F98731.90104@oracle.com> |Hi, when I try to build for solaris/x86/32bit/client, I get this error (on a 64-bit host):|| || However, I can successfully build the 64-bit VM. --- make log --- ||Making libjvm_db.so|| ||cc -m32 -DCOMPILER1 -I. -I../generated \|| || -G -M /net/sc11136754/scratch/iklam/jdk/vtab/make/solaris/makefiles/mapfile-vers-jvm_db -mt -KPIC -xnolib -o libjvm_db.so /net/sc11136754/scratch/iklam/jdk/vtab/src/os/solaris/dtrace/libjvm_db.c -lc|| ||dtrace: failed to compile script dtrace.d: "/usr/lib/dtrace/mpi.d", line 68: syntax error near "umpiconninfo_t"|| ||--- The failing command is this ------------ $ (cd /net/sc11136754/scratch/iklam/jdk/vtab/build/solaris/solaris_i486_compiler1/product; /usr/sbin/dtrace -C -I. -G -xlazyload -o dtrace.o -s dtrace.d ciEnv.o classLoadingService.o compileBroker.o hashtable.o instanceKlass.o java.o jni.o jvm.o memoryManager.o nmethod.o objectMonitor.o runtimeService.o sharedRuntime.o synchronizer.o thread.o unsafe.o vmThread.o vmCMSOperations.o vmPSOperations.o vmGCOperations.o ) dtrace: failed to compile script dtrace.d: "/usr/lib/dtrace/mpi.d", line 68: syntax error near "umpiconninfo_t" ----------- ||Any hints? Thanks - Ioi |