RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

Tim Bell tim.bell at oracle.com
Sat Jul 13 11:51:11 UTC 2013 

Hello everyone-

Many thanks for the early feedback on this JDK8 hotspot + VS2012 project.

A revised webrev is here:

   http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/

These changes build and pass all of the standard 119 tests (as listed in 
the jprt.properties file - see below) when using VS2012 and also using 
VS2010.

Thanks in advance for any feedback-

Tim

*** Build targets:
   windows_i586_5.1-product with attributes compiler=VS2010 (or i586_6.1 
VS2012)
   windows_i586_5.1-fastdebug with attributes compiler=VS2010 (or 
i586_6.1 VS2012)
   windows_x64_5.2-product with attributes compiler=VS2010 (or i586_6.1 
VS2012)
   windows_x64_5.2-fastdebug with attributes compiler=VS2010 (or 
i586_6.1 VS2012)

*** Test targets:
   windows_i586-product-c1-jvm98
   windows_i586-product-c2-jvm98
   windows_i586-fastdebug-c1-jvm98
   windows_i586-fastdebug-c2-jvm98
   windows_i586-product-c2-jvm98_nontiered
   windows_i586-fastdebug-c2-jvm98_nontiered
   windows_i586-product-c1-scimark
   windows_i586-product-c2-scimark
   windows_i586-fastdebug-c1-scimark
   windows_i586-fastdebug-c2-scimark
   windows_i586-product-c1-runThese
   windows_i586-product-c2-runThese
   windows_i586-product-c1-runThese_Xcomp
   windows_i586-product-c2-runThese_Xcomp
   windows_i586-fastdebug-c1-runThese_Xshare
   windows_i586-product-c1-GCBasher_SerialGC
   windows_i586-product-c2-GCBasher_SerialGC
   windows_i586-fastdebug-c1-GCBasher_SerialGC
   windows_i586-fastdebug-c2-GCBasher_SerialGC
   windows_i586-product-c1-GCBasher_ParallelGC
   windows_i586-product-c2-GCBasher_ParallelGC
   windows_i586-fastdebug-c1-GCBasher_ParallelGC
   windows_i586-fastdebug-c2-GCBasher_ParallelGC
   windows_i586-product-c1-GCBasher_ParNewGC
   windows_i586-product-c2-GCBasher_ParNewGC
   windows_i586-fastdebug-c1-GCBasher_ParNewGC
   windows_i586-fastdebug-c2-GCBasher_ParNewGC
   windows_i586-product-c1-GCBasher_CMS
   windows_i586-product-c2-GCBasher_CMS
   windows_i586-fastdebug-c1-GCBasher_CMS
   windows_i586-fastdebug-c2-GCBasher_CMS
   windows_i586-product-c1-GCBasher_G1
   windows_i586-product-c2-GCBasher_G1
   windows_i586-fastdebug-c1-GCBasher_G1
   windows_i586-fastdebug-c2-GCBasher_G1
   windows_i586-product-c1-GCBasher_ParOldGC
   windows_i586-product-c2-GCBasher_ParOldGC
   windows_i586-fastdebug-c1-GCBasher_ParOldGC
   windows_i586-fastdebug-c2-GCBasher_ParOldGC
   windows_i586-product-c1-GCOld_SerialGC
   windows_i586-product-c2-GCOld_SerialGC
   windows_i586-product-c1-GCOld_ParallelGC
   windows_i586-product-c2-GCOld_ParallelGC
   windows_i586-product-c1-GCOld_ParNewGC
   windows_i586-product-c2-GCOld_ParNewGC
   windows_i586-product-c1-GCOld_CMS
   windows_i586-product-c2-GCOld_CMS
   windows_i586-product-c1-GCOld_G1
   windows_i586-product-c2-GCOld_G1
   windows_i586-product-c1-GCOld_ParOldGC
   windows_i586-product-c2-GCOld_ParOldGC
   windows_i586-product-c1-jbb_default
   windows_i586-product-c2-jbb_default
   windows_i586-fastdebug-c1-jbb_default
   windows_i586-fastdebug-c2-jbb_default
   windows_i586-product-c2-jbb_default_nontiered
   windows_i586-fastdebug-c2-jbb_default_nontiered
   windows_i586-product-c1-jbb_ParallelGC
   windows_i586-product-c2-jbb_ParallelGC
   windows_i586-product-c1-jbb_CMS
   windows_i586-product-c2-jbb_CMS
   windows_i586-product-c1-jbb_G1
   windows_i586-product-c2-jbb_G1
   windows_i586-product-c1-jbb_ParOldGC
   windows_i586-product-c2-jbb_ParOldGC
   windows_x64-product-c2-jvm98
   windows_x64-fastdebug-c2-jvm98
   windows_x64-product-c2-jvm98_nontiered
   windows_x64-fastdebug-c2-jvm98_nontiered
   windows_x64-product-c2-scimark
   windows_x64-fastdebug-c2-scimark
   windows_x64-product-c2-runThese
   windows_x64-product-c2-runThese_Xcomp
   windows_x64-product-c2-GCBasher_SerialGC
   windows_x64-fastdebug-c2-GCBasher_SerialGC
   windows_x64-product-c2-GCBasher_ParallelGC
   windows_x64-fastdebug-c2-GCBasher_ParallelGC
   windows_x64-product-c2-GCBasher_ParNewGC
   windows_x64-fastdebug-c2-GCBasher_ParNewGC
   windows_x64-product-c2-GCBasher_CMS
   windows_x64-fastdebug-c2-GCBasher_CMS
   windows_x64-product-c2-GCBasher_G1
   windows_x64-fastdebug-c2-GCBasher_G1
   windows_x64-product-c2-GCBasher_ParOldGC
   windows_x64-fastdebug-c2-GCBasher_ParOldGC
   windows_x64-product-c2-GCOld_SerialGC
   windows_x64-fastdebug-c2-GCOld_SerialGC
   windows_x64-product-c2-GCOld_ParallelGC
   windows_x64-fastdebug-c2-GCOld_ParallelGC
   windows_x64-product-c2-GCOld_ParNewGC
   windows_x64-fastdebug-c2-GCOld_ParNewGC
   windows_x64-product-c2-GCOld_CMS
   windows_x64-fastdebug-c2-GCOld_CMS
   windows_x64-product-c2-GCOld_G1
   windows_x64-fastdebug-c2-GCOld_G1
   windows_x64-product-c2-GCOld_ParOldGC
   windows_x64-fastdebug-c2-GCOld_ParOldGC
   windows_x64-product-c2-jbb_default
   windows_x64-fastdebug-c2-jbb_default
   windows_x64-product-c2-jbb_default_nontiered
   windows_x64-fastdebug-c2-jbb_default_nontiered
   windows_x64-product-c2-jbb_CMS
   windows_x64-product-c2-jbb_ParallelGC
   windows_x64-product-c2-jbb_G1
   windows_x64-product-c2-jbb_ParOldGC
   windows_i586-fastdebug-c1-clienttest
   windows_i586-product-c1-clienttest
   windows_i586-fastdebug-c2-servertest
   windows_i586-product-c2-servertest
   windows_x64-fastdebug-c2-servertest
   windows_x64-product-c2-servertest
   windows_i586-fastdebug-c2-internalvmtests
   windows_x64-fastdebug-c2-internalvmtests
   windows_i586-product-c2-wbapitest
   windows_i586-fastdebug-c2-wbapitest
   windows_x64-product-c2-wbapitest
   windows_x64-fastdebug-c2-wbapitest
   windows_i586-product-c1-wbapitest
   windows_i586-fastdebug-c1-wbapitest


On 06/ 3/13 06:41 AM, Daniel D. Daugherty wrote:
> On 6/1/13 11:02 AM, Tim Bell wrote:
>> 8015759: hotspot changes needed to compile with Visual Studio 2012
>>
>> The bug report will be visible in a few days here:
>> http://bugs.sun.com/view_bug.do?bug_id=8015759
>>
>> Minor Makefile changes and one source file was touched to compile 
>> with Visual Studio 2012.  These changes also compile under
>> Visual Studio 2010 with no problem so we can upgrade gracefully. 
>> Tested by building the forest with both compilers.
>>
>> % hg status
>> M make/windows/makefiles/compile.make
>
>     same question about the STATIC_CPPLIB stuff as David H.
>
>
>> M make/windows/makefiles/sanity.make
>
>     No comments.
>
>
>> M make/windows/makefiles/vm.make
>
>     Same question about the new 'ifdef DEVELOP' change as David H.
>
>     Sanity check: The patch shows this change:
>
>  # Special case files not using precompiled header files.
>
> -c1_RInfo_$(Platform_arch).obj: 
> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp
> +c1_RInfo_$(Platform_arch).obj: 
> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp
>       $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c 
> $(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp
>
>     But I don't see a change. And this diff doesn't show up in the
>     other views.  Oh wait, there's a blank at the end of the '+'
>     line...
>
>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp
>
>     No comments.
>
> Dan
>
>
>>
>> webrev and patch file are here:
>>
>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/
>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch 
>>
>>
>> Thanks to Anthony Petrov who provided the initial set of patches for 
>> this work.
>>
>> I believe this should go in via the hotspot-rt forest (let me know if 
>> that is not correct), in which case I will need a sponsor from that 
>> team to push the change.
>>
>> Thanks in advance-
>> Tim
>>
>>
>

More information about the build-dev mailing list