Review Request: 8015644 : makefile changes to allow integration of new features

[Erik Joelsson]

Looks good.
/Erik

On 2013-06-04 04:59, Amy Wang wrote:
> Hi, All,
>
> This is the newly updated webrev at
> http://cr.openjdk.java.net/~katleman/8015644/webrev.jdk.02/ 
> <http://cr.openjdk.java.net/%7Ekatleman/8015644/webrev.jdk.02/>
>
> I removed the space before the ":" in line 627.
> Thanks,
> Amy
>
> On 6/3/2013 4:51 PM, David Holmes wrote:
>> Hi Amy,
>>
>> This just needed to go to build-dev list - now cc'd.
>>
>> This change is unnecessary:
>>
>> 627 $(JRE_INFO_FILE) : $(OUTPUT_ROOT)/spec.gmk 
>> $(OUTPUT_ROOT)/source_tips
>>
>> A space was added before the colon but it is not needed and is out of 
>> style with the rest of the file.
>>
>> The main change of moving the include position for the custom 
>> Images.gmk is ok with respect to our custom Images.gmk. I haven't 
>> heard of any external community members utilizing this mechanism yet 
>> so the change should not affect anyone else.
>>
>> Thanks,
>> David
>>
>> On 4/06/2013 8:45 AM, Amy Wang wrote:
>>> Resend this as it was bounced.
>>>
>>> -------- Original Message --------
>>> Subject:     Review Request: 8015644 : makefile changes to allow
>>> integration of new features
>>> Date:     Mon, 03 Jun 2013 13:54:15 -0700
>>> From:     Amy Wang <amy.y.wang at oracle.com>
>>> Organization:     Oracle Corporation
>>> To:     jdk8-dev at openjdk.java.net
>>>
>>>
>>>
>>> Hi, All,
>>>
>>> Please help in code review of the following change:
>>> 8015644 <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015644> :
>>> makefile changes to allow integration of new features
>>>
>>> The webrev is available at
>>> http://cr.openjdk.java.net/~katleman/8015644/webrev.jdk.01/
>>> <http://cr.openjdk.java.net/%7Ekatleman/8015644/webrev.jdk.01/>
>>>
>>> Thank you very much!
>>> Amy
>>>
>>>
>>>
>>>
>>>
>>
>>
>