RFR: 8016605: New files dont apear in src.zip

[David Holmes]

On 14/06/2013 11:58 PM, Tim Bell wrote:
> Erk-
>
> That was a subtle one.  I had to look at the unified diffs to see it.

Yeah I've been bitten by this numerous times. One of Make's biggest 
flaws is the way it handles parsing these things - missing commas should 
cause an error. :(

David

> Looks good.
>
> Tim
>
> On 06/14/13 04:18 AM, Erik Joelsson wrote:
>> I found the problem. Missing commas in a macro call caused the list of
>> sources to end up empty which made src.zip depend on nothing.
>> Corrected one other instance having the same problem. (The other
>> instance was also about dependency calculation but I doubt anybody had
>> run into trouble with that one yet.)
>>
>> http://cr.openjdk.java.net/~erikj/8016605/webrev.root.01/
>>
>> /Erik
>>
>> On 2013-06-14 11:09, Erik Joelsson wrote:
>>> I must have missed that mail, sorry. I've filed "8016605: New files
>>> dont apear in src.zip"
>>>
>>> /Erik
>>>
>>> On 2013-06-14 10:48, Boaz Nahum wrote:
>>>> Hi.
>>>>
>>>> Sorry I'm raising it again but it is (very) annoying
>>>>
>>>> I'm building lambda/lambda on daily basis.
>>>>
>>>> The problem is that I don't delete src.zip it is not update in jdk
>>>> image
>>>>
>>>> Sure make clean solve the problem.
>>>>
>>>> Please see
>>>> http://mail.openjdk.java.net/pipermail/build-dev/2013-April/008721.html
>>>>
>>>> Thanks
>>>> Boaz
>