RFR: 8017047: Can't use --with-java-devtools and --with-devkit at the same time
Tim Bell
tim.bell at oracle.com
Mon Jun 24 18:45:03 UTC 2013
Erik:
> Open part of this review:
>
> There is an artificial limitation put into configure that prevents
> usage of options --with-devkit and --with-tools-dir at the same time.
> The reason was probably because they could potentially be conflicting.
> This patch removes this check and makes them work together, both
> ending up on the search path for tools (with --with-tools-dir ending
> up ahead of devkit).
>
> I also stumbled on some dead code that was causing warnings to be
> printed when using --with-devkit and decided to remove that while
> touching that option anyway.
>
> http://cr.openjdk.java.net/~erikj/8017047/webrev.root.01/
In the new basics.m4:
362 TOOLS_DIR=$TOOLS_DIR:$with_devkit/bin
If TOOLS_DIR was empty, this will add an extra :
Probably harmless, but I'd prefer not to see it happen. If you feel it
is harmless, go ahead.
Code deletion looks good.
Tim
More information about the build-dev
mailing list