RFR: 8010385: build with LOG=trace broken on mac

[Phil Race]

Looks fine to me too ... I wish I'd seen this 30 seconds ago.
I literally just hit this bug on mac and filed a dup (which I'll close)
and then saw this RFR.

BTW What I'm trying to do is see the gcc compiler options that
are actually used on Mac. debug and info options didn't
reveal anything. What should I use ?

-phil.

On 6/27/2013 10:51 AM, Tim Bell wrote:
> Hi Erik
>
> Looks good to me as well.  Approved.
>
> Tim
>
>
> On 06/27/13 05:21 AM, David Holmes wrote:
>> On 27/06/2013 7:16 PM, Erik Joelsson wrote:
>>> Would be great if someone could take a look at this, thanks.
>>
>> Looks reasonable to me.
>>
>> David
>>
>>> /Erik
>>>
>>> On 2013-06-18 16:38, Erik Joelsson wrote:
>>>> The log level 'trace' is broken on both mac and solaris. When trace is
>>>> used, the shell variable is overridden to do the following:
>>>>
>>>> 1. Add -x to echo each line that gets executed. This causes all
>>>> $(shell) expressions to be printed in addition to recipes.
>>>> 2. Add some text explaining if it's a $(shell) or a recipe, what rule
>>>> it belongs to and what triggered it.
>>>> 3. Add /usr/bin/time to each line and print the output to a special
>>>> log file
>>>>
>>>> What's failing on Mac and Solaris is 3 since the formatted output and
>>>> ability to print to a separate file is only available in GNU time. On
>>>> Solaris 1 is also failing due to the default shell, /bin/sh, not
>>>> seeming to like this.
>>>>
>>>> I solved 1 by overriding the shell with /bin/bash. We already require
>>>> bash for configure so this should be safe.
>>>>
>>>> For 3, if we don't have GNU time, we can't use the feature, so I let
>>>> configure check for this and disable it if not found.
>>>>
>>>> http://cr.openjdk.java.net/~erikj/8010385/webrev.root.01/
>>>>
>>>> /Erik
>