RFR 8009517: Disable fatal compiler warning in the old build

[Alan Bateman]

On 08/03/2013 13:24, Chris Hegarty wrote:
> Since the new build does not enable -Werror when compiling any java 
> code, and disables quite a few lint options, new changes my 
> inadvertently introduce warnings without even realizing. This can 
> cause problems when building with the old build as many areas do 
> compile with -Werror set. Since the old build is on life support, 
> probably best to just completely disable -Werror, so anyone still 
> needing to use it can.
>
> diff -r 48b7295f02f8 make/common/shared/Defs-java.gmk
> --- a/make/common/shared/Defs-java.gmk  Thu Mar 07 10:07:13 2013 +0000
> +++ b/make/common/shared/Defs-java.gmk  Thu Mar 07 11:10:37 2013 +0000
> @@ -122,9 +122,10 @@ ifeq ($(JAVAC_MAX_WARNINGS), true)
>  ifeq ($(JAVAC_MAX_WARNINGS), true)
>    JAVAC_LINT_OPTIONS += -Xlint:all
>  endif
> -ifeq ($(JAVAC_WARNINGS_FATAL), true)
> -  JAVACFLAGS  += -Werror
> -endif
> +# Disable fatal warnings, 8009517
> +#ifeq ($(JAVAC_WARNINGS_FATAL), true)
> +#  JAVACFLAGS  += -Werror
> +#endif
>
>  # TODO: Workaround for CR 7063027. Remove -path eventually.
>  JAVAC_LINT_OPTIONS += -Xlint:-path
>
> -Chris.
This seems the most sensible thing to me as it is impossible to keep the 
old build warning working when warnings aren't fatal in the new build.

-Alan.