RFR: JDK-8009819 build-infra: RE jdk8 build forest fails for windows since addition of --with-dxsdk

[David Holmes]

Looks okay to me.

David

On 13/03/2013 9:31 AM, Tim Bell wrote:
> On 03/12/13 15:05, Tim Bell wrote:
>> On 03/12/13 14:54, Tim Bell wrote:
>>> Please review this change, which provides a fallback to the
>>> traditional location for the DXSDK if it is not specified on the
>>> configure line.  We don't like doing this, but in this case I will
>>> give in. It seems many of the legacy build systems we use internally
>>> do not have the environment variable defined.
>>>
>>> Bug report (not visible externally yet... should be soon):
>>>
>>>     http://bugs.sun.com/view_bug.do?bug_id=8009819
>>>
>>> JDK-8009819
>>> build-infra: RE jdk8 build forest fails for windows since addition of
>>> --with-dxsdk
>>>
>>> Webrev:
>>>
>>>    http://cr.openjdk.java.net/~tbell/8009819/webrev.00/
>>
>> For some reason, this webrev did not find any changes.  While I debug
>> webrev :-/  ...
>
> It was a case of a newer hg versus the older forest extension.  Here is
> a corrected webrev:
>
>    http://cr.openjdk.java.net/~tbell/8009819/webrev.01/
>
> Sorry for the extra emails.
>
> Tim
>