Allow configure to detect if EC implementation is present

[Andrew Hughes]

----- Original Message -----
> On 14/03/2013 6:09 AM, Omair Majid wrote:
> > Hi,
> >
> > jdk/makefiles/CompileNativeLibraries.gmk has a little note:
> >
> > TODO Set DISABLE_INTREE_EC in configure if
> > src/share/native/sun/security/ec/impl is not present
> >
> > The webrev at
> > http://cr.openjdk.java.net/~omajid/webrevs/intree-ec/00/
> > implements this. Does this look okay for jdk8/build ? Can I get a
> > bug id?
> 
> Bug ID:  8010030
> 
> I think it is more consistent to set the variable to yes/no and
> change:
> 
> ifndef DISABLE_INTREE_EC
> 
> to
> 
> ifeq ($DISABLE_INTREE_EC), yes)
> 

I agree.  I didn't suggest this myself because it was already being
used as ifndef and I wasn't sure if there were other occurrences elsewhere.
I think I may even be the person who introduced it in this form in the old build ;)

Using the standard form is preferable, though you need to make sure all uses get
changed.   However, this test is the wrong way round.  It needs to either
check for no or the variable needs to be ENABLE_INTREE_EC :) 

It would be nice to turn this off via a configure option but that's really
something for another patch.  Note that, even with this patch, unless someone
manually deletes that directory, configure will not set DISABLE_INTREE_EC.
It's present in the OpenJDK tree.

> Thanks,
> David
> 
> 
> 
> > Thanks,
> > Omair
> >
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07