RFR 8009517: Disable fatal compiler warning in the old build

Brad Wetmore bradford.wetmore at oracle.com
Fri Mar 22 19:10:46 UTC 2013



On 3/22/2013 1:34 AM, Alan Bateman wrote:
> On 21/03/2013 22:12, Brad Wetmore wrote:
>> :
>>
>> The codereview is here:
>>
>> http://cr.openjdk.java.net/~wetmore/8009517/webrev.00/
>>
>> I plan to push through the deploy gate, as they have an integration
>> next week.  Thomas Ng will do the push for us.
>>
>> Any objections, please speak now.
> No objection here but just to mention that since you need to set
> NEWBUILD=false then it might not be too much extra to also set
> JAVAC_WARNINGS_FATAL=false.

At least for me, I'm not using the new build environment at all.  (I 
think RE is doing the same when building the JCE jar files):

     % cd jdk/make
     % make381 all

That is, NEWBUILD doesn't exist in this build hierarchy.

As for adding JAVAC_WARNINGS_FATAL=false, I thought we were keeping 
warnings fatal here to so that folks running builds in this environment 
can the developers know they are introducing warnings/crud into their code?

> In any case, I think it would be desirable if there was a retirement
> date set for the old build so that the remaining users (I assume very
> few at this point) have something to aim for.

Erik is now more aware of our JCE build problems, so hopefully we won't 
be far behind.  I was surprised to hear deploy still has the dependency.

Brad



More information about the build-dev mailing list