RFR: 8010908: Images target failes when configured with --disable-zip-debug-info

[Tim Bell]

See inline...

On 03/28/13 01:27, Erik Joelsson wrote:
>
>
> On 2013-03-28 04:41, David Holmes wrote:
>> On 27/03/2013 10:58 PM, Erik Joelsson wrote:
>>> On 2013-03-27 13:20, David Holmes wrote:
>>>> On 27/03/2013 8:59 PM, Erik Joelsson wrote:
>>>>> I found the problem and fixed it:
>>>>>
>>>>> http://cr.openjdk.java.net/~erikj/8010908/webrev.jdk.01/
>>>>
>>>> I don't understand - how did this:
>>>>
>>>> `$(FIND) $(JDK_OUTPUTDIR)/bin -type f -name \*$(EXE_SUFFIX)`
>>>>
>>>> match .debuginfo files but not .diz files (EXE_SUFFIX is empty) ???
>>>>
>>> It didn't, that was handled by the file command and grep. The 
>>> problem is
>>> file output is more or less the same for the executable and the
>>> debuginfo file, but at least those can be separated by name.
>>
>> Ah! Got it - thanks.
>>
>> So is this line buggy anyway:
>>
>>   ALL_BIN_LIST := $(filter-out %.debuginfo %.diz, $(ALL_BIN_LIST))
>>
>> I thought you could only have a single wildcard.
>>
> I wasn't sure, but I added some debug printing around it and verified 
> that it actually works. Both patterns are filtered out.
>
> /Erik

I agree with Erik.

According to my reading of the doc:
http://www.gnu.org/software/make/manual/make.html#index-filter-574

It is ok to have more than one % pattern before the , in a filter or a 
filter-out call.

patsubst is the function where only the first % has a special meaning.

Tim