Please review changes for JDK-8012975: Remove rhino from jdk8
A. Sundararajan
sundararajan.athijegannathan at oracle.com
Mon May 13 12:14:24 UTC 2013
Incorporated changes as suggested. Uploaded webrev for historical purpose:
http://cr.openjdk.java.net/~sundar/8012975/webrev.02/
PS. I am going ahead with push..
Thanks
-Sundar
On Friday 10 May 2013 06:17 PM, A. Sundararajan wrote:
> Okay, thanks. com.sun.script.util is not supported API (no CCC done
> for it in the past). I'll remove it as suggested and run "make
> profiles" to check
>
> Thanks
> -Sundar
>
> On Friday 10 May 2013 04:09 PM, Alan Bateman wrote:
>> On 10/05/2013 11:23, A. Sundararajan wrote:
>>> com/sun/script/util is generic utility package for script engine
>>> implementations. Only com/sun/script/javascript package is being
>>> removed. Since we include javax/script for profile 3, should we also
>>> include com/sun/script/util ?
>> Is com.sun.script.util meant to be a supported/documented API? Do you
>> know if anything outside of the JDK is using it? Is Nashorn using it?
>> The only usage I see is in com.sun.script.javascript so this is why I
>> assumed that com.sun.script.** would go away.
>>
>> As you know, we moved javax.script to compact1. It doesn't require
>> com.sun.script.util of course but if this is used by 3rd party
>> scripting engines then it may have to be added to compact1 builds to
>> get them working.
>>
>>>
>>> On refs.allowed, I'll remove it. How should I check this?
>> "make profiles" on Linux should be fine. As part of the profiles
>> build it will run a dependency analyzer that checks for references to
>> types that do not exist (this is catch configuration issues).
>>
>> -Alan
>
More information about the build-dev
mailing list