Please review changes for JDK-8012975: Remove rhino from jdk8

A. Sundararajan sundararajan.athijegannathan at oracle.com
Mon May 13 15:40:24 UTC 2013


I agree that it is better to remove com.sun.script.util package as well. 
It is not used elsewhere and was never declared as supported API. I've 
removed the same and re-generated webrev.

http://cr.openjdk.java.net/~sundar/8012975/webrev.03/

I ran NEWBUILD=false as well as NEWBUILD=true to make sure build 
finishes fine.

Please review.

Thanks
-Sundar

On Monday 13 May 2013 05:56 PM, Alan Bateman wrote:
> On 13/05/2013 13:14, A. Sundararajan wrote:
>> Incorporated changes as suggested. Uploaded webrev for historical 
>> purpose:
>>
>> http://cr.openjdk.java.net/~sundar/8012975/webrev.02/
>>
>> PS. I am going ahead with push..
>>
> Thanks for fixing up refs.allowed, that one looks fine okay.
>
> Did you decide to keep com.sun.script.util? Just wondering because it 
> appears that only com.sun.script.javascript is being removed. If the 
> util API is going away then I assume that make/com/sun/script/Makefile 
> should be removed (although we don't really care about the old build 
> anymore). On the other, if the util API is staying then we need to 
> figure out which profile is should go in. If nothing is using it then 
> I assume it should be listed in FULL_JRE_RTJAR_INCLUDE_PACKAGES.
>
> -Alan




More information about the build-dev mailing list