Fix for 8014669, build flags issue

David Holmes david.holmes at oracle.com
Thu May 16 00:05:47 UTC 2013


Hi Bill,

(re-fixed the build-dev alias)

On 16/05/2013 6:48 AM, BILL PITTORE wrote:
> Some architecture dependent flags do not make it through to the
> libjsig.so and libsaproc.so makefiles. As a result, the libs are not
> compiled/linked with the correct flags for that particular variant. Fix
> is to make sure EXTRA_CFLAGS propogates down correctly.
>
> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/

I need to look closer at this. Passing all of the EXTRA_CFLAGS as link 
options seems wrong to me as they may not be valid linker options. That 
said I see that in this case we are actually using the C compiler to do 
the linking. But that said, in the saproc case we are also compiling C 
source files at the same time which means that EXTRA_CFLAGS is needed on 
the main command line, not tucked onto the LD flags. And the implication 
here is that cross-compilation of libsaproc has been broken all this 
time for any platform where the default gcc output would be wrong!

David




More information about the build-dev mailing list