RFR: 8014003: New build does not handle symlinks in workspace path

Tim Bell tim.bell at oracle.com
Thu May 30 16:05:57 UTC 2013


Erik:

OK - looks good to me.

Tim

On 05/30/13 02:22 AM, Erik Joelsson wrote:
> The bash builtin version of pwd seems to behave more uniformly. 
> Changed to use this version of pwd and also explicitly added either -L 
> or -P to all invocations of it to make sure the expected result was 
> generated.
>
> http://cr.openjdk.java.net/~erikj/8014003/webrev.root.02/
>
> /Erik
>
> On 2013-05-29 13:44, Erik Joelsson wrote:
>> Unfortunately the /bin/pwd on fedora 9 doesn't follow this. I will 
>> try to figure out something else.
>>
>> /Erik
>>
>> On 2013-05-29 05:38, Mike Duigou wrote:
>>> http://pubs.opengroup.org/onlinepubs/009695399/utilities/pwd.html
>>>
>>> Yep, -L is part of IEEE Std 1003.1-2001 standard which basically 
>>> everything in use today supports. If only the same could be said 
>>> about C99.
>>>
>>> Mike
>>>
>>>
>>> On May 28 2013, at 19:40 , Tim Bell wrote:
>>>
>>>> Erik:
>>>>
>>>>> Due to a difference in the default output of the pwd command on 
>>>>> mac vs linux and solaris, configure wouldn't allow the source root 
>>>>> to be a symlink on mac. This patch fixes this by adding -L to the 
>>>>> pwd command, forcing it to show the logical directory rather than 
>>>>> the symlink free one.
>>>>>
>>>>> http://cr.openjdk.java.net/~erikj/8014003/webrev.root.01/
>>>> Looks good to me.
>>>>
>>>> I checked pwd on Solaris, Linux, Cygwin on Windows, and Mac.  They 
>>>> all show -L as an option.  Unfortunately, I don't have the means at 
>>>> this time to check other platforms such as (non-Mac) BSD, AIX, 
>>>> HP-UX, Unicos, etc.
>>>>
>>>>
>>>> Tim
>>>>
>>>>




More information about the build-dev mailing list