Removal of the old build system, partial and preliminary review (part 3)
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Mon Nov 4 11:44:55 UTC 2013
Here is the final part of the patch to remove the old build system.
(I'll get back with a comprehensive review showing all changes, when the
fix is cleared for inclusion in JDK8.)
This time, I've basically moved the files from "makefiles" to "make",
and updated paths correspondingly.
Apart from this, I also sorted the top-level makefiles in one of two sets:
a) files used only at the top-level
b) files common to all sub repos
The files in a) were moved to make, but the files in b) were moved to
make/common. The common/makefiles/javadoc directory was removed -- the
CORE_PKGS files moved to make/common, the relevant documentation (one
section) in Notes.html was moved into Javadoc.gmk (the rest was
irrelevant) and Javadoc.gmk moved to make.
The webrev is created with the previous review as baseline.
As usual, here are the (somewhat filtered) log excerpts from my sandbox
for this change:
[top-level]
* Remove references to makefiles in subrepos.
* Move top-level common/makefiles to make, and shared files to make/common.
* Remove lecagy jprt.gmk file.
* Move make/javadoc/(NON_)CORE_PKGS.gmk to make/common.
* Move relevant documentation from Notes.html into Javadoc.gmk.
* Move Javadoc.gmk from make/javadoc to make.
[langtools]
* Move all files from makefiles to make.
* Update top-level move from common/makefiles.
[corba]
* Move all files from makefiles to make.
* Update top-level move from common/makefiles.
[jaxws]
* Move all files from makefiles to make.
* Update top-level move from common/makefiles.
[jaxp]
* Move all files from makefiles to make.
* Update top-level move from common/makefiles.
[jdk]
* Move all files from makefiles to make.
* Update top-level move from common/makefiles.
[nashorn]
* Move all files from makefiles to make.
* Update top-level move from common/makefiles.
Unfortunately, WebRev is not very intelligent at presenting these
changes. :-( I have made modifications to files that I have also moved,
but WebRev just lists these files as "New" without any reference or diff
with the original file. I don't know if if is possible to get an
improved behaviour. I'm using the -f flag, on a repo that is cloned
locally from the one I based the previous review on.
Anyway, here is the webrev:
http://cr.openjdk.java.net/~ihse/remove-old-build-part-3/webrev.02
/Magnus
More information about the build-dev
mailing list