Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

[Mike Duigou]

I would like to but haven't had a chance. I have the source for the webrev script frequently used by the hotspot team but so far haven't attempted to merge it. Volunteers are of course welcome--I had hoped that the mainline webrev updates would be so awesome that current users of the HotSpot script might seek to merge their changes in or at least resync with mainline.

Mike

On Nov 5 2013, at 17:51 , David Holmes <david.holmes at oracle.com> wrote:

> Aside: but I thought I recalled that someone added Tom Rodriguez' webrev updates that handle the next/prev file etc? But now I don't see it.
> 
> Example output:
> 
> http://cr.openjdk.java.net/~dholmes/8027755/webrev/makefiles/CompileLaunchers.gmk.cdiff.html
> 
> Thanks,
> David
> 
> On 6/11/2013 2:50 AM, Mike Duigou wrote:
>> Thanks for looking into this issue!
>> 
>> I tried the patch and it worked correctly for me and the code looks good.
>> 
>> I've been using only Major.Minor version numbering for recent updates. This fix seems worthy of being "25.1"
>> 
>> Mike
>> 
>> On Nov 5 2013, at 06:10 , Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8027836
>>> 
>>> If the last file from a directory is moved by hg mv, the directory itself is removed by mercurial.
>>> 
>>> Webrev cannot handle this situation properly.
>>> 
>>> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8027836-fix-webrev-moved-from-removed-dir/webrev.02
>>> 
>>> /Magnus
>>> 
>>