Removal of the old build system, partial and preliminary review (part 3)

Erik Joelsson erik.joelsson at oracle.com
Wed Nov 6 09:33:45 UTC 2013


On 2013-11-06 01:57, David Holmes wrote:
> On 6/11/2013 12:20 AM, Magnus Ihse Bursie wrote:
>> On 2013-11-04 12:44, Magnus Ihse Bursie wrote:
>>>
>>> Unfortunately, WebRev is not very intelligent at presenting these
>>> changes. :-( I have made modifications to files that I have also
>>> moved, but WebRev just lists these files as "New" without any
>>> reference or diff with the original file. I don't know if if is
>>> possible to get an improved behaviour. I'm using the -f flag, on a
>>> repo that is cloned locally from the one I based the previous review 
>>> on.
>>
>> Here is an updated webrev that fixes these problems. The actual code
>> changes are the same:
>>
>> http://cr.openjdk.java.net/~ihse/remove-old-build-part-3/webrev.06
>
> Just one comment, I don't know how JPRT finds jprt.gmk so am unsure if 
> this will require JPRT changes?
>
>  ./make/Jprt.gmk (was ./common/makefiles/Jprt.gmk)
>
Jprt just looks for a root Makefile and ours includes Jprt.gmk which 
contains the jprt specific stuff, just to keep it out of the way for others.

/Erik



More information about the build-dev mailing list