Removal of the old build system, partial review
Bradford Wetmore
bradford.wetmore at oracle.com
Thu Nov 7 06:00:21 UTC 2013
On 11/6/2013 9:31 PM, Bradford Wetmore wrote:
> I've looked over:
>
> jdk/make/com/oracle/security/ucrypto
> jdk/make/com/sun/crypto/provider
> jdk/make/com/sun/security
> jdk/make/java/security
> jdk/make/javax/crypto
> There may be some things we want to add back as part of the work
> ErikJ/I are doing
> jdk/make/javax/others
> jdk/make/javax/rmi
> jdk/make/javax/security
> jdk/make/sun/security
>
> My only comment:
>
> Just to make sure nothing is inadvertently removed, in the jdk directory
> I noticed 44 mapfile-vers* being removed, but only 37 are present in the
> new makefiles/mapfiles. Any concerns here?
Don't quote me on these numbers, I think I had my count scripting wrong
and wasn't looking at the right filenames. As long as things are being
built correctly, I'm good.
Brad
> Brad
>
>
>
> On 10/30/2013 7:22 AM, Magnus Ihse Bursie wrote:
>> I have started working on removing the old build system. See
>> https://bugs.openjdk.java.net/browse/JDK-8027566.
>>
>> I plan do to this in several steps. I have not decided wether to commit
>> these steps as separate bugs, or just use this division to facilitate
>> developing and reviewing the fix. (Feedback on this appreciated!)
>>
>> As a first step, I identified all files that was not used at all
>> anymore, and deleted these. The webrev I'm publishing here contains
>> these deletes.
>>
>> As a second step, I'm processing the remaining files and see why they
>> are still used, from where, and if they can move to better places. A lot
>> of them are only used in closed sources, and should therefore move to
>> the closed repositories. Some of them are used by the new build system,
>> and should be integrated into the new build system instead.
>>
>> Finally, I plan to move the new build system from "makefiles" to the
>> now-more-or-less-empty "make" directories. For a full rationale of this,
>> please see the JBS bug. In short: it makes no sense to have to make
>> directories, and we can't get rid of the "make" directory anyhow.
>>
>> But in this step is just the removal of the non-problematic parts of the
>> old build. If you see anything being removed here that should not be,
>> please let me now!
>>
>> Also, I have replaced the old top-level Makefile with the contents of
>> NewMakefile.gmk.
>>
>> (The .jcheck removals are just while I'm working, I couldn't find an
>> easy way to hide them in the webrev. I do not intend to check them in).
>>
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/remove-old-build-part-1/webrev.02
>>
>> /Magnus
>>
More information about the build-dev
mailing list