Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

[Magnus Ihse Bursie]

On 2013-11-08 01:19, David Holmes wrote:
> On 7/11/2013 11:26 PM, Magnus Ihse Bursie wrote:
>> On 2013-11-06 03:01, Jonathan Gibbons wrote:
>>> Pwrhaps we should only have one copy of the webrev script around.
>>
>> ... and perhaps it should not be tied to a specific source branch. That
>> has always seemed weird to me.
>>
>> I would suggest creating a code-tools/webrev repository, and moving
>> webrev.ksh there.
>
> Create it where exactly?
>
> Having a copy of webrev in the openjdk forest is useful for people to 
> get their hands on it. But webrev is not specific to openjdk or a 
> particular forest, it is just a tool. I keep a copy of webrev in ~/bin 
> because I use it over numerous forests and I always want the same 
> version of webrev used (latest one or at least late enough to have the 
> features I like). I then have to update it periodically.

As I said to Jonathan, I suggest creating a repo at 
http://hg.openjdk.java.net/code-tools/webrev.

I agree that webrev is just a tool that is not specific to a particular 
forest. That's the reason I'm suggesting that it should be moved to a 
more neutral location.

It seems your use case (as well as mine; I do the same as you) should be 
simplified by having a single authorative version of the webrev script, 
that can be easily updated.

/Magnus