RFR JDK-8027900: pack200 option is broken due to the incorrect makefile definition for its driver

Alexander Zuev alexander.zuev at oracle.com
Fri Nov 8 14:57:04 UTC 2013


Hello,

   please review my fix for the issue JDK-8027900: pack200 option is 
broken due to the incorrect makefile definition for its driver

   The problem is that in the definition of the pack200 native launcher 
we added explicit option "--pack"
This is incorrect because:

   1. this option is being thrown away by the called class, from the 
initialization of the driver class -
             String arg0 = av.isEmpty() ? "" : av.get(0);
             switch (arg0) {
                 case "--pack":
                 av.remove(0);
                     break;
   2. passing this option explicitly renders --unpack option invalid.

   Here is the suggested fix: 
http://cr.openjdk.java.net/~kizune/8027900/webrev.00

   Link to the issue: https://bugs.openjdk.java.net/browse/JDK-8027900

/Alex




More information about the build-dev mailing list