Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Nov 8 15:54:14 UTC 2013


On 11/08/2013 12:22 AM, Magnus Ihse Bursie wrote:
> On 2013-11-07 22:39, Jonathan Gibbons wrote:
>>
>> It's not clear to me whether you mean a new repository within the 
>> standard existing code-tools project, or another repo in a JDK 
>> forest, in a "common" subdirectory.
>
> I meant a new repository within the code-tools project, most 
> reasonably named http://hg.openjdk.java.net/code-tools/webrev.
>
>>
>> How important is it to keep [compatibility with] make/script/webrev.ksh?
>
> If we can achieve both the goal of moving the webrev script away from 
> being tied to a specific jdk repo, and still let everyone keep their 
> scripts/command lines/etc intact, I can't see the harm in that. It's 
> no big deal forcing people to clone yet another repo to use webrev, 
> but on the other hand, it's no big deal to make this change completely 
> transparant as well -- and then I'd prefer the latter.
>
> /Magnus

Magnus,

I have no problem with another code-tools repo, but it does raise the 
question of how folk should get tools provided in the such repos. I 
presume you would not suggest that if someone wants to use jtreg, some 
script should automagically download and build jtreg. What about 
jcheck?  If someone wants to use jcheck locally, should the OpenJDK 
forest provide a script to download and install jcheck somewhere?

-- Jon



More information about the build-dev mailing list