RFR JDK-8027900: pack200 option is broken due to the incorrect makefile definition for its driver

Mon Nov 11 10:13:04 UTC 2013

On 2013-11-08 15:57, Alexander Zuev wrote:
> Hello,
>
>   please review my fix for the issue JDK-8027900: pack200 option is 
> broken due to the incorrect makefile definition for its driver
>
>   The problem is that in the definition of the pack200 native launcher 
> we added explicit option "--pack"
> This is incorrect because:
>
>   1. this option is being thrown away by the called class, from the 
> initialization of the driver class -
>             String arg0 = av.isEmpty() ? "" : av.get(0);
>             switch (arg0) {
>                 case "--pack":
>                 av.remove(0);
>                     break;
>   2. passing this option explicitly renders --unpack option invalid.
>
>   Here is the suggested fix: 
> http://cr.openjdk.java.net/~kizune/8027900/webrev.00

Looks good to me from a build perspective (but I'm not a formal reviewer).

/Magnus