RFR 6726154: javadoc generated with incorrect version in comment

Tim Bell tim.bell at oracle.com
Tue Nov 12 18:40:31 UTC 2013


On 11/12/13 09:48 AM, Jonathan Gibbons wrote:
> On 11/12/2013 01:33 AM, Alexander Zuev wrote:
>> Hello,
>>
>>   please review my fix for the issue JDK-6726154: javadoc generated 
>> with incorrect version in comment
>>
>>   The problem is that in the build time we are using bootstrap JDK to 
>> run javadoc classes so it reads incorrect
>> JDK version. In order to retain correct version i've changed 
>> makefiles/BuildLangtools.gmk to create resource bundle
>> with the correct version information - the same way version is 
>> retained for javac or javap.
>>
>>   The fix can be found here: 
>> http://cr.openjdk.java.net/~kizune/6726154/webrev.00
>>
>>   Link to the bug description: 
>> https://bugs.openjdk.java.net/browse/JDK-6726154
>>
>> /Alex
>
> I approve the general change, and the changes to the source code in 
> particular.   I think someone from the build team should approve the 
> change to the makefile.

This makefiles/BuildLangtools.gmk change looks like a straightforward 
application of what you are already doing for javac, jdeps, etc.  Approved.

Tim




More information about the build-dev mailing list