RFR: JDK-8028645: [infra] purge applet demos from the Solaris distros
Kumar Srinivasan
kumar.x.srinivasan at oracle.com
Wed Nov 20 15:34:37 UTC 2013
Thanks Erik, I will take care of those.
Kumar
On 11/20/2013 1:52 AM, Erik Joelsson wrote:
> Looks good, but one style nit.
>
> 195 $(JDK_OUTPUTDIR)/demo/nbproject/%:
> $(JDK_TOPDIR)/src/closed/share/demo/nbproject/%
> 196 $(call install-file)
> 197 $(CHMOD) -f ug+w $@
> 198 ifeq ($(OPENJDK_TARGET_OS), solaris)
> 199 $(RM) -r $(JDK_OUTPUTDIR)/demo/nbproject/jfc/SwingApplet
> 200 endif
>
> Make conditionals in recipes should be indented the same as the
> recipe, but with spaces so not to confuse make:
>
> 195 $(JDK_OUTPUTDIR)/demo/nbproject/%:
> $(JDK_TOPDIR)/src/closed/share/demo/nbproject/%
> 196 $(call install-file)
> 197 $(CHMOD) -f ug+w $@
> 198 ifeq ($(OPENJDK_TARGET_OS), solaris)
> 199 $(RM) -r $(JDK_OUTPUTDIR)/demo/nbproject/jfc/SwingApplet
> 200 endif
>
> /Erik
>
> On 2013-11-20 00:36, Kumar Srinivasan wrote:
>> Hello,
>>
>> Please review these changes to remove applet related demos from the
>> images and thereby
>> from the Solaris distributions. Note: at this time appletviewer is
>> still available in the distros,
>> as there are tests dependent on it.
>>
>> http://cr.openjdk.java.net/~ksrini/8028645/webrev.0/
>>
>> Thanks
>> Kumar
>>
>
More information about the build-dev
mailing list