Code review for bug fix 8025741

[Bhavesh Patel]

Thanks Magnus.

I have made the changes to the common/makefiles/javadoc/Javadoc.gmk file for the new build. I have uploaded the updated webrev at http://cr.openjdk.java.net/~bpatel/8025741/webrev.01/

Thanks,
Bhavesh.

----- Original Message -----
From: magnus.ihse.bursie at oracle.com
To: bhavesh.x.patel at oracle.com
Cc: build-dev at openjdk.java.net
Sent: Wednesday, October 2, 2013 12:46:19 AM GMT -08:00 US/Canada Pacific
Subject: Re: Code review for bug fix 8025741

On 2013-10-01 23:41, Bhavesh Patel wrote:
> Hi,
>     There is a bug in jdk/make/docs/Makefile for JDK8. The bug is listed at https://bugs.openjdk.java.net/browse/JDK-8025741. The Makefile for JDK 8 does not include the DEV_DOCS_URL that should point to the developer documentation URL for JDK 8. This creates an empty href in <a> HTML tag resulting in tidy warnings in the generated JDK API documentation.
>     I have fixed the Makefile to include the variable and have pointed it to the JDK 8 developer documentation URL. The webrev for the fix it at http://cr.openjdk.java.net/~bpatel/8025741/webrev.00/.

This needs to be fixed for the new build as well. In 
common/makefiles/javadoc/Javadoc.gmk, I see there is already a prepared, 
but commented out, line:

# This isn't added in old build yet.
#DEV_DOCS_URL-8 = http://download.oracle.com/javase/7/docs/index.html

Restore that and remove the comment above which does not apply any longer.

/Magnus