JDK 8 RFR: JDK-8024603 Turn on javac lint checking for auxiliaryclass, empty, and try in jdk build

[Joseph Darcy]

Some of the fixes I need are in the TL repo, some are in awt. If I can't 
arrange for the full set of fixes to be in the same repo soon, I plan to 
push just the "try" fix now and then "auxiliaryclass" and "empty" once 
the fixes propagate.

(There is a hazard of new instances of problem popping up in the interim 
so I'd prefer to get new lint categories enabled as soon as possible.)

Thanks,

-Joe

On 10/2/2013 1:17 AM, Erik Joelsson wrote:
> The change looks ok. Pushing it through JPRT sounds like a good idea.
>
> /Erik
>
> On 2013-10-02 01:22, Joe Darcy wrote:
>> Hello,
>>
>> As a follow-up to  JDK-8024643 "Turn on javac lint checking in 
>> building the jdk repo", the time approaches to enable a few more lint 
>> warnings in the build of the jdk repo:
>>
>>     JDK-8024603 Turn on javac lint checking for auxiliaryclass and 
>> empty in jdk build
>>     http://cr.openjdk.java.net/~darcy/8024603.0/
>>
>> The webrev above and patch below adds the "auxiliaryclass", "empty", 
>> and "try" categories:
>>
>> --- old/makefiles/Setup.gmk    2013-10-01 15:53:23.000000000 -0700
>> +++ new/makefiles/Setup.gmk    2013-10-01 15:53:23.000000000 -0700
>> @@ -27,7 +27,7 @@
>>
>>  # To build with all warnings enabled, do the following:
>>  # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
>> -JAVAC_WARNINGS:=-Xlint:-unchecked,-deprecation,-overrides,classfile,dep-ann,divzero,varargs 
>> -Werror
>> +JAVAC_WARNINGS:=-Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,try,varargs 
>> -Werror
>>
>>  # The generate old bytecode javac setup uses the new compiler to 
>> compile for the
>>  # boot jdk to generate tools that need to be run with the boot jdk.
>>
>> The bugs blocking these categories are fixed or out for review.
>>
>> Please review the change; it would only be pushed on a successful 
>> full jprt run.
>>
>> Thanks,
>>
>> -Joe
>>
>