RFR (S): JDK-8025921 Make LOG=debug output more readable

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Oct 8 11:42:45 UTC 2013


On 2013-10-07 17:52, Erik Joelsson wrote:
> Unfortunately, the patch failed when I tried submitting it. Usage of 
> the ListPathsSafely macro in SetupArchive is a bit different and needs 
> to be adjusted. Here is a webrev that I have verified to work:
>
> http://cr.openjdk.java.net/~erikj/8025921/webrev.root.01/
>
> I also reduced duplication and slightly changed the debug message. At 
> least to me, assuming word 2 of $3 to be a filename feels a bit of a 
> hack, even if it's usually the case.

I considered "word 2 of $3" part of the API of ListPathsSafely, but I 
agree that it might get violated. We should probably improve the API 
slightly, so the filename is clearly specified. But that is a larger 
work. So, if you feel this is the best, I accept it, even if the output 
looks a slight bit weirder. :)

In summary, looks good to me.

Thanks for fixing the issues I failed to detect!

/Magnus



More information about the build-dev mailing list