RFR: 8025612: rt.jar still has old specification value in the manifest

[Erik Joelsson]

On 2013-10-11 20:14, Bradford Wetmore wrote:
> As the submitter, I also agree with this part of the fix and all 
> comments made here. ;)
>
> Erik, one thing I did not check is whether other .jars in j2re/j2sdk 
> use a different manifest template than the one you modified.  Have you 
> checked them all?
>
I could not find any other manifests and greping for 
"Specification-Version" did not give me any other hits. There are jars 
that do not specify this attribute, for example nashorn, but I assume 
they don't count.

/Erik
> You do not need to check these .jars, they will be updated shortly.
>
> ./ec/sunec.jar
> ./jce/jce.jar
> ./jce/local_policy.jar
> ./jce/sunjce_provider.jar
> ./jce/US_export_policy.jar
> ./mscapi/sunmscapi.jar
> ./pkcs11/sunpkcs11.jar
> ./ucrypto/ucrypto.jar
>
> I only noticed this when upgrading the JCE build to use the new 
> build-infra, and noticed my JCE jar files still had 1.7, which meant 
> the others had the same problem.  (Alan...I was close to throwing the 
> JCE new build-infra switch when we discovered RE has different build 
> output format, and then got a couple small P1's yesterdays.)
>
> Brad
>
>
> On 10/11/2013 7:09 AM, Tim Bell wrote:
>> Erik:
>>
>>> Please review this small change, updating the specification version in
>>> the manifest of the jar files. Posted diff inline since it's so small.
>>> I couldn't find anywhere else where this would need changing, but if
>>> anyone knows of somewhere, please speak up.
>>>
>>> /Erik
>>>
>>> diff -r 98d98ec01f07 make/tools/manifest.mf
>>> --- a/make/tools/manifest.mf
>>> +++ b/make/tools/manifest.mf
>>> @@ -1,6 +1,6 @@
>>>   Manifest-Version: 1.0
>>>   Specification-Title: Java Platform API Specification
>>> -Specification-Version: 1.7
>>> +Specification-Version: 1.8
>>>   Specification-Vendor: Oracle Corporation
>>>   Implementation-Title: Java Runtime Environment
>>>   Implementation-Version: @@RELEASE@@
>>>
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8025612
>>
>> Looks good.
>>
>> /Tim
>>