RFR: JDK -8001933 Move Gensrc*.gmk and Gendata*.gmk into separate directories

Erik Joelsson erik.joelsson at oracle.com
Mon Oct 14 08:17:31 UTC 2013


I'm in favor of this change and it looks good to me.

/Erik

On 2013-10-14 10:07, Magnus Ihse Bursie wrote:
> On 2013-10-11 20:18, Magnus Ihse Bursie wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8001933
>>
>> In the makefiles directory in the jdk repo, there are a lot of files 
>> -- important files, and lot of small helper files. Many of them share 
>> a common filename prefix; however, there is a better kind of 
>> namespaces to show hierarchy in file systems: directories! :-)
>>
>> This fix moves all the "Gensrc*" files into the "gensrc" directory, 
>> and all the "Gendata*" into the "gendata" directory. The result is a 
>> clearer picture of the overall structure of the JDK build system.
>>
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8001933-move-gensrc-and-gendata/webrev.01
>
> In private communication, Erik suggested that we take this opportunity 
> to rename GenerateJavaSources.gmk to GenerateSources.gmk, since it's 
> actually more accurate (we are generating other kinds of sources, not 
> only Java source code).
>
> Updated WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8001933-move-gensrc-and-gendata/webrev.02
>
> /Magnus




More information about the build-dev mailing list